ependencies. Perhaps provide the gradle command and a link to the
"building.." page.
Cheers,
-andy
From: Nir Lisker
Date: Tuesday, 2022/11/15 at 09:44
To: Andy Goryachev
Cc: Nir Lisker , openjfx-dev@openjdk.org
Subject: [External] : Re: RFR: 8221708 Update Eclipse project files [v4
is will load and build
> the dependencies (lucene).
>
>
>
> Perhaps we should also add a section dedicated to configuring error
> levels, as the default configuration turns off important warnings and
> enables too many unimportant ones.
>
>
>
> Thank you again
>
:09
To: openjfx-dev@openjdk.org
Subject: Re: RFR: 8221708 Update Eclipse project files [v4]
On Sun, 13 Nov 2022 02:27:55 GMT, John Hendrikx wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> John Hendrikx has updated the pull request incrementally with one additional
>
On Tue, 15 Nov 2022 02:05:33 GMT, Nir Lisker wrote:
> I updated
> https://wiki.openjdk.org/display/OpenJFX/Using+an+IDE#UsinganIDE-UsingEclipse.
Looks good, nicely explained :)
-
PR: https://git.openjdk.org/jfx/pull/930
On Sun, 13 Nov 2022 02:27:55 GMT, John Hendrikx wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix controls classpath
I updated
https://wiki.openjdk.org/display/
On Sun, 13 Nov 2022 02:27:55 GMT, John Hendrikx wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix controls classpath
Marked as reviewed by nlisker (Reviewer).
-
On Sun, 13 Nov 2022 01:41:45 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary add-exports attribute from Eclipse files
>
> tests/manual/controls/.classpath line 10:
>
>> 8:
>>
> See https://bugs.openjdk.org/browse/JDK-8221708
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Fix controls classpath
-
Changes:
- all: https://git.openjdk.org/jfx/pull/930/files
- new: https://git.openjdk.org/jf
On Sun, 13 Nov 2022 01:43:30 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove unnecessary add-exports attribute from Eclipse files
>
> tests/manual/desktop/.classpath line 23:
>
>> 21:
On Sat, 12 Nov 2022 20:38:49 GMT, John Hendrikx wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove unnecessary add-exports attribute from Eclipse files
tests/m
> See https://bugs.openjdk.org/browse/JDK-8221708
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Remove unnecessary add-exports attribute from Eclipse files
-
Changes:
- all: https://git.openjdk.org/jfx/pull/930/file
On Mon, 7 Nov 2022 08:32:22 GMT, John Hendrikx wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update Eclipse classpath files
>
> - Stripped dependencies to a
On Mon, 7 Nov 2022 08:32:22 GMT, John Hendrikx wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update Eclipse classpath files
>
> - Stripped dependencies to a
On Mon, 7 Nov 2022 08:32:22 GMT, John Hendrikx wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> John Hendrikx has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update Eclipse classpath files
>
> - Stripped dependencies to a
On Mon, 7 Nov 2022 08:26:58 GMT, John Hendrikx wrote:
>> The new changes look good. I get a bogus error marker on the apps folder in
>> Project Explorer, but in Package Explorer there is no error. Looks like some
>> Eclipse hiccup.
>>
>> My only comment is about some classpath files that defin
On Sun, 6 Nov 2022 21:31:49 GMT, Nir Lisker wrote:
> The new changes look good. I get a bogus error marker on the apps folder in
> Project Explorer, but in Package Explorer there is no error. Looks like some
> Eclipse hiccup.
Yes, this happens sometimes to me as well. The import process of so
> See https://bugs.openjdk.org/browse/JDK-8221708
John Hendrikx has updated the pull request incrementally with one additional
commit since the last revision:
Update Eclipse classpath files
- Stripped dependencies to a minimum
- Added ".settings" to exclusion for projects with sources i
On Sat, 22 Oct 2022 07:49:12 GMT, John Hendrikx wrote:
> See https://bugs.openjdk.org/browse/JDK-8221708
The new changes look good. I get a bogus error marker on the apps folder in
Project Explorer, but in Package Explorer there is no error. Looks like some
Eclipse hiccup.
My only comment is
On Sat, 22 Oct 2022 07:49:12 GMT, John Hendrikx wrote:
> See https://bugs.openjdk.org/browse/JDK-8221708
Alright, we'll go with option 2 then and keep option 3 for further research.
The new changes look fine, I'll do a formal review soon.
-
PR: https://git.openjdk.org/jfx/pull/930
On Thu, 27 Oct 2022 11:41:27 GMT, Kevin Rushforth wrote:
>> I don't see how a closed build will be affected by Eclipse files.
>
> Nor do I. The build doesn't care, and if a developer clones the repo into
> `rt` after the name is changed to `jfx` it will be no different than someone
> who clones
On Wed, 26 Oct 2022 23:24:20 GMT, Nir Lisker wrote:
>> We do still clone the repo into a directory named `rt` when doing a closed
>> build, but I doubt this change will cause problems. Maybe Andy can check? As
>> Nir mentioned, people can (and do) name the root directory whatever they
>> want
On Wed, 26 Oct 2022 23:20:30 GMT, Kevin Rushforth wrote:
>> .project line 3:
>>
>>> 1:
>>> 2:
>>> 3: jfx
>>
>> this may cause issues with internal setup at oracle
>
> We do still clone the repo into a directory named `rt` when doing a closed
> build, but I doubt this change will cause probl
On Wed, 26 Oct 2022 22:51:10 GMT, Andy Goryachev wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> .project line 3:
>
>> 1:
>> 2:
>> 3: jfx
>
> this may cause issues with internal setup at oracle
We do still clone the repo into a directory named `rt` when doing a closed
build,
On Fri, 28 Oct 2022 21:18:54 GMT, Nir Lisker wrote:
> But this patch just fixes the Eclipse setup. Changing the Gradle root script
> is something that should be done when considering the whole repository.
I agree with @nlisker, and don't want to see changes to the gradle scripts as
part of wha
On Fri, 28 Oct 2022 21:18:54 GMT, Nir Lisker wrote:
>>> but that's another issue for another time.
>>
>> I respectfully disagree - the initial import (with all the documented extra
>> steps) should result in a clean state - as it is currently with the master
>> branch.
>
>> > but that's anothe
On Fri, 28 Oct 2022 21:18:54 GMT, Nir Lisker wrote:
>>> but that's another issue for another time.
>>
>> I respectfully disagree - the initial import (with all the documented extra
>> steps) should result in a clean state - as it is currently with the master
>> branch.
>
>> > but that's anothe
On Fri, 28 Oct 2022 20:47:21 GMT, Nir Lisker wrote:
> but that's another issue for another time.
I respectfully disagree - the initial import (with all the documented extra
steps) should result in a clean state - as it is currently with the master
branch.
@nlisker :
could you repeat the docu
On Fri, 28 Oct 2022 20:49:47 GMT, Andy Goryachev wrote:
> > but that's another issue for another time.
>
> I respectfully disagree - the initial import (with all the documented extra
> steps) should result in a clean state - as it is currently with the master
> branch.
But this patch just fix
On Fri, 28 Oct 2022 20:42:39 GMT, John Hendrikx wrote:
>> yes, something is wrong with test projects.
>> Nir's screenshot shows a project-like Properties UI, mine shows a different
>> UI:
>>
>> > src="https://user-images.githubusercontent.com/107069028/198727492-2961ad7b-b0a0-4725-b952-afdd794b
On Thu, 27 Oct 2022 00:11:48 GMT, Nir Lisker wrote:
> I didn't explain this well. There are 3 projects under apps/samples that have
> a `build.gradle` file with the `application` plugin: Ensemble8, 3DViewer and
> Modena. This implies that these can be run with Gradle. However, doing so
> cause
On Fri, 28 Oct 2022 20:38:18 GMT, Andy Goryachev wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> yes, something is wrong with test projects.
> Nir's screenshot shows a project-like Properties UI, mine shows a different
> UI:
>
> src="https://user-images.githubusercontent.com/1070
On Wed, 26 Oct 2022 11:16:19 GMT, Kevin Rushforth wrote:
>> I've rebased this on master. For some reason I mistakenly based this on
>> some old version of master.
>>
>> I do notice the same kind of problems Andy experienced. Eclipse can give
>> many errors when switching branches. Closing a
On Wed, 26 Oct 2022 23:34:39 GMT, Kevin Rushforth wrote:
> The swt-debug.jar library is copied to build/libs as part of gradle sdk, so
> it's at least available (maybe just needs to be pointed to)?
I previously added it to the project's classpath and the error wasn't being
resolved so I assume
On Wed, 26 Oct 2022 16:48:34 GMT, Andy Goryachev wrote:
> One difference I see is that the official process to import the project,
> according to
> https://wiki.openjdk.org/display/OpenJFX/Using+an+IDE#UsinganIDE-ConfigureEclipsetousethelatestJDK
> , is to use `Import as Gradle Project` rather
On Wed, 26 Oct 2022 17:00:03 GMT, Nir Lisker wrote:
>>> I've rebased this on master. For some reason I mistakenly based this on
>>> some old version of master.
>>
>> As a reminder, please use `git merge master` rather than `git rebase master`
>> (the latter of which requires a force push and m
On Wed, 26 Oct 2022 11:16:19 GMT, Kevin Rushforth wrote:
>> I've rebased this on master. For some reason I mistakenly based this on
>> some old version of master.
>>
>> I do notice the same kind of problems Andy experienced. Eclipse can give
>> many errors when switching branches. Closing a
On Tue, 25 Oct 2022 16:43:48 GMT, John Hendrikx wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> I've added the manual ones. I think not all of the manual code is correct.
> `DNDWebViewTest` has no `main` for example. The `swt` tests need eclipse SWT
> libraries that don't seem
On Wed, 26 Oct 2022 08:10:15 GMT, John Hendrikx wrote:
> I've rebased this on master. For some reason I mistakenly based this on some
> old version of master.
As a reminder, please use `git merge master` rather than `git rebase master`
(the latter of which requires a force push and makes incre
On Mon, 24 Oct 2022 13:25:37 GMT, Nir Lisker wrote:
> I managed to solve is using `gradlew --write-verification-metadata sha256
> help`. The manual says it should be run after updating a dependency, so I
> wonder why I'm the only one with this problem.
That should not be necessary, since no de
On Sat, 22 Oct 2022 12:03:46 GMT, Kevin Rushforth wrote:
>> See https://bugs.openjdk.org/browse/JDK-8221708
>
> @andy-goryachev-oracle can you also take a look at this?
@kevinrushforth I'm getting errors on a gradle build. Is it just me or do we
need to change some configuration?
The supplied
On Sat, 22 Oct 2022 07:49:12 GMT, John Hendrikx wrote:
> See https://bugs.openjdk.org/browse/JDK-8221708
This is the review for /apps.
apps itself is a gradle project as specific in the root project build.gradle
file. I think that a gradle file should be generated there and the gradle
nature
On Sun, 23 Oct 2022 00:33:22 GMT, Nir Lisker wrote:
> I'm getting errors on a gradle build. Is it just me or do we need to change
> some configuration?
I don't see any errors, and we aren't seeing any on GitHub actions runs, so it
is likely something in your configuration. What version of grad
On Sat, 22 Oct 2022 07:49:12 GMT, John Hendrikx wrote:
> See https://bugs.openjdk.org/browse/JDK-8221708
I took a look at the tests folder. There are several nested testapps in this
folder. These give compile errors because they're not using the correct source
root folder (they use `/src/tes
See https://bugs.openjdk.org/browse/JDK-8221708
-
Commit messages:
- Fix line endings for Eclipse project files
- Add Eclipse encoding files (UTF8)
- Add buildship Eclipse files to all gradle projects
- Remove Eclipse files from non-projects
- Fix 3DLighting project
- Add swt-de
On Sat, 22 Oct 2022 07:49:12 GMT, John Hendrikx wrote:
> See https://bugs.openjdk.org/browse/JDK-8221708
@andy-goryachev-oracle can you also take a look at this?
-
PR: https://git.openjdk.org/jfx/pull/930
On Sat, 22 Oct 2022 07:49:12 GMT, John Hendrikx wrote:
> See https://bugs.openjdk.org/browse/JDK-8221708
tens of thousand of errors in eclipse.
looks like some projects are misconfigured.
Changes requested by angorya (Author).
removed the project, imported back as a gradle project, reverted th
46 matches
Mail list logo
