On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote:
> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.
Looks good.
-
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.org/jfx17u/pull/102
On Fri, 3 Feb 2023 08:44:53 GMT, Johan Vos wrote:
>> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.
>
> I'm ok with this.
> Apart from the functionality, this BP also makes it easier to backport future
> changes in build.gradle (because it backports a structural
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote:
> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.
Marked as reviewed by jvos (Reviewer).
I'm ok with this.
Apart from the functionality, this BP also makes it easier to backport future
changes in build.gradle (because
On Tue, 31 Jan 2023 13:19:56 GMT, Ao Qi wrote:
>> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.
>
> RFC and RFR. Thanks. Should I take this PR out of Draft?
@theaoqi Yes, if you take it out of draft, I'll review it.
-
PR:
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote:
> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.
RFC and RFR. Thanks. Should I take this PR out of Draft?
-
PR: https://git.openjdk.org/jfx17u/pull/102
On Mon, 9 Jan 2023 13:41:49 GMT, Kevin Rushforth wrote:
>> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.
>
> Backports to `jfx17u` require prior approval. You will need to seek such
> approval from one of the project leads before taking this PR out of Draft.
>
>
On Mon, 9 Jan 2023 13:28:51 GMT, Ao Qi wrote:
> Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.
Backports to `jfx17u` require prior approval. You will need to seek such
approval from one of the project leads before taking this PR out of Draft.
If it is approved,
Clean backport. Verified on Linux/LoongArch64, Linux/x64 and Linux/aarch64.
-
Commit messages:
- 8293214: Add support for Linux/LoongArch64
Changes: https://git.openjdk.org/jfx17u/pull/102/files
Webrev: https://webrevs.openjdk.org/?repo=jfx17u=102=00
Issue:
On Fri, 16 Sep 2022 14:09:39 GMT, Kevin Rushforth wrote:
>> Ao Qi has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> disable msse2 by default, use IS_LOONGARCH64 and IS_AARCH64
>
> The changes look good. I'm doing a final sanity test on
On Thu, 8 Sep 2022 07:26:48 GMT, Ao Qi wrote:
>> LoongArch is a new RISC ISA. This issue proposes adding support for
>> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
>> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
>> is updated to
On Thu, 8 Sep 2022 07:26:48 GMT, Ao Qi wrote:
>> LoongArch is a new RISC ISA. This issue proposes adding support for
>> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
>> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
>> is updated to
On Thu, 8 Sep 2022 07:26:48 GMT, Ao Qi wrote:
>> LoongArch is a new RISC ISA. This issue proposes adding support for
>> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
>> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
>> is updated to
On Thu, 15 Sep 2022 13:31:54 GMT, Johan Vos wrote:
>> Ao Qi has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> disable msse2 by default, use IS_LOONGARCH64 and IS_AARCH64
>
> It looks good. I'll do a build and then hopefully I can approve
On Thu, 8 Sep 2022 07:26:48 GMT, Ao Qi wrote:
>> LoongArch is a new RISC ISA. This issue proposes adding support for
>> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
>> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
>> is updated to
On Thu, 15 Sep 2022 13:31:54 GMT, Johan Vos wrote:
> It looks good. I'll do a build and then hopefully I can approve (those
> ifeq/ifneq changes often need more than a few pair of eyes)
Yes. We need to check it carefully:) I did some tests like:
ifneq (,$(findstring $(ARCH), x64 x32
On Thu, 8 Sep 2022 07:26:48 GMT, Ao Qi wrote:
>> LoongArch is a new RISC ISA. This issue proposes adding support for
>> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
>> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
>> is updated to
On Wed, 7 Sep 2022 12:02:37 GMT, Johan Vos wrote:
>> Ao Qi has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> revert
>
> This PR looks safe to me. I don't see a scenario where this can cause
> regression. I can't say if those changes are
On Wed, 7 Sep 2022 11:59:42 GMT, Johan Vos wrote:
>> Ao Qi has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> revert
>
> build.gradle line 313:
>
>> 311: } else if (IS_MAC && OS_ARCH != "x86_64" && OS_ARCH != "aarch64") {
>> 312:
> LoongArch is a new RISC ISA. This issue proposes adding support for
> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
> is updated to OpenJFX, it is supposed to work.
>
> Testing:
> -
On Thu, 1 Sep 2022 13:00:24 GMT, Ao Qi wrote:
>> LoongArch is a new RISC ISA. This issue proposes adding support for
>> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
>> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
>> is updated to
On Thu, 1 Sep 2022 13:00:24 GMT, Ao Qi wrote:
>> LoongArch is a new RISC ISA. This issue proposes adding support for
>> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
>> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
>> is updated to
On Thu, 1 Sep 2022 13:00:24 GMT, Ao Qi wrote:
>> LoongArch is a new RISC ISA. This issue proposes adding support for
>> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
>> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
>> is updated to
On Tue, 6 Sep 2022 23:00:22 GMT, Alexander Matveev wrote:
>> Ao Qi has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> revert
>
> Media changes looks good.
Thanks for the review, @sashamatveev.
-
PR:
On Thu, 1 Sep 2022 13:00:24 GMT, Ao Qi wrote:
>> LoongArch is a new RISC ISA. This issue proposes adding support for
>> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
>> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
>> is updated to
On Thu, 1 Sep 2022 12:51:34 GMT, Kevin Rushforth wrote:
> The easiest way is to push an empty commit to your branch.
Thanks, @kevinrushforth . The GHA tests passed. Some additional test results
were updated in the PR description.
-
PR: https://git.openjdk.org/jfx/pull/888
> LoongArch is a new RISC ISA. This issue proposes adding support for
> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
> is updated to OpenJFX, it is supposed to work.
Ao Qi has updated
> LoongArch is a new RISC ISA. This issue proposes adding support for
> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
> is updated to OpenJFX, it is supposed to work.
Ao Qi has updated
On Thu, 1 Sep 2022 12:19:23 GMT, Ao Qi wrote:
> LoongArch is a new RISC ISA. This issue proposes adding support for
> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
> is updated to
On Thu, 1 Sep 2022 12:19:23 GMT, Ao Qi wrote:
> LoongArch is a new RISC ISA. This issue proposes adding support for
> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
> is updated to
On Thu, 1 Sep 2022 12:19:23 GMT, Ao Qi wrote:
> LoongArch is a new RISC ISA. This issue proposes adding support for
> Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
> the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit
> is updated to
LoongArch is a new RISC ISA. This issue proposes adding support for
Linux/LoongArch64. Upstream WebKit for LoongArch64 support is not ready, but
the OpenJFX part is simple and ready. When the LoongArch64 supported Webkit is
updated to OpenJFX, it is supposed to work.
-
Commit
31 matches
Mail list logo
