On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
On Mon, 22 Apr 2024 15:31:25 GMT, Andy Goryachev wrote:
> let's try this one:
>
> Reviewer: @karthikpandelu
Yep.
There is no Skara command to request a review from someone. The `/reviewer` is
use to credit someone who has not done a review in GitHub (and is not expected
to), but who has revi
On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
On Mon, 22 Apr 2024 08:34:34 GMT, eduardsdv wrote:
> closing the overflow-menu with the ESC key when the currently focused Node
> (e.g. ListView) processes the ESC itself.
On macOS, option-ESC closes the overflow menu.
-
PR Comment: https://git.openjdk.org/jfx/pull/1434#issuecomme
On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
On Fri, 19 Apr 2024 16:14:27 GMT, Andy Goryachev wrote:
>> So, none of them can be reproduced on windows, only on mac.
>>
>> The #2 can be reproduced in the version before PR and after PR.
>>
>> The #3 is reproducible only with PR changes and in my opinion an other bug
>> in JavaFX, which is m
On Fri, 19 Apr 2024 14:18:36 GMT, eduardsdv wrote:
> Should it be **quick**-fixed in this PR
I would rather not.
We *could* create a ticket named "improve focus handling in ToolBar" but then
again, since no functionality is disabled, it will be a P5 (very low priority).
-
PR Comm
On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
On Tue, 16 Apr 2024 16:18:09 GMT, eduardsdv wrote:
>> how silly of me! you are right, of course. thank you for clarification.
>
> You are welcome, partner :-).
> It was a surprise for me too.
> It's strange, why it needs to be an unmodifiable collection.
good question! admittedly, it might
On Tue, 16 Apr 2024 16:08:12 GMT, Andy Goryachev wrote:
>> The ``Node.getPseudoClassStates()`` returns an unmodifiable collection. The
>> bindings would not work. Therefore we need to use a listener and change the
>> pseudo-class-state by using the ``Node.pseudoClassStateChanged(PseudoClass,
>
On Tue, 16 Apr 2024 16:04:34 GMT, eduardsdv wrote:
>> line 575 still uses a listener instead of
>> Bindings.bindContent(**Set,ObservableSet**)
>
> The ``Node.getPseudoClassStates()`` returns an unmodifiable collection. The
> bindings would not work. Therefore we need to use a listener and chang
On Tue, 16 Apr 2024 15:58:21 GMT, Andy Goryachev wrote:
>> ~~Done. See
>> [92921e3](https://github.com/openjdk/jfx/pull/1434/commits/92921e36987e3cd1cfe78c17b464547aa73d241e)~~
>
> line 575 still uses a listener instead of
> Bindings.bindContent(**Set,ObservableSet**)
The ``Node.getPseudoClass
On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
On Tue, 16 Apr 2024 15:54:11 GMT, eduardsdv wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/ToolBarSkin.java
>> line 575:
>>
>>> 573: Bindings.bindContent(overflowBox.getStyleClass(),
>>> box.getStyleClass());
>>> 574: Bindings.bindContent(overflowBox.
On Mon, 15 Apr 2024 15:49:04 GMT, Andy Goryachev wrote:
>> eduardsdv has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8328577: Refactor and fix binding of style related properties
>
> modules/javafx.controls/src/main/java/javafx/scene
On Tue, 16 Apr 2024 15:30:26 GMT, eduardsdv wrote:
> Can this pull request be merged?
Almost there: please address the remaining review comments, and we need one
more reviewer.
-
PR Comment: https://git.openjdk.org/jfx/pull/1434#issuecomment-2059385959
On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
On Mon, 15 Apr 2024 15:41:19 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>> ``Node
> This change fixes the calculation of which nodes go to the toolbar and which
> go to the overflow menu.
> It is now determined before the nodes are removed from the scene graph.
> This is important because the values returned by
> ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on whe
24 matches
Mail list logo
