On Mon, 28 Nov 2022 17:04:17 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be aut
On Mon, 28 Nov 2022 17:04:17 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be aut
On Tue, 29 Nov 2022 21:47:05 GMT, John Hendrikx wrote:
>> I see that this change has been reverted. That's good.
>>
>> FWIW, I disagree with the original premise of removing it. The subclass
>> shouldn't have to know or care that the superclass method is empty or not.
>>
>> I looked through th
On Tue, 29 Nov 2022 21:36:11 GMT, Kevin Rushforth wrote:
>> I think that we should refrain from making "structural" changes in this
>> pass. Let's keep the warning on and deal with these later.
>
> I see that this change has been reverted. That's good.
>
> FWIW, I disagree with the original pre
On Wed, 23 Nov 2022 21:41:09 GMT, Nir Lisker wrote:
>> The `processEndElement` in the base class was an empty method that throws
>> `IOException`. By making it `abstract` the warning is avoided, but this
>> means the call to `super` here is no longer relevant (it wasn't relevant
>> anyway as
On Mon, 28 Nov 2022 17:04:17 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be aut
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class d
On Tue, 22 Nov 2022 19:10:27 GMT, Kevin Rushforth wrote:
>> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446:
>>
>>> 1444: }
>>> 1445: }
>>> 1446:
>>
>> this suggests a specific pattern, even though there is probably no
>> development expected in thi
On Tue, 22 Nov 2022 18:52:32 GMT, John Hendrikx wrote:
>> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446:
>>
>>> 1444: @Override
>>> 1445: public void processEndElement() throws IOException {
>>> 1446: super.processEndElement();
>>
>> I don't
On Tue, 22 Nov 2022 19:06:47 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be aut
On Tue, 22 Nov 2022 18:35:36 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix indent of 5 spaces to 4 spaces
>
> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446:
>
>
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class d
On Tue, 22 Nov 2022 18:45:13 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert changes to javafx.web src/main/native
>
> modules/javafx.swing/src/main/java/com/sun/javafx/embed/swing/newim
On Tue, 22 Nov 2022 16:49:52 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be aut
On Tue, 22 Nov 2022 18:41:18 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert changes to javafx.web src/main/native
>
> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1446
On Tue, 22 Nov 2022 18:45:58 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix warnings in fxml
>
> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 1497:
>
>> 1495: pu
On Tue, 22 Nov 2022 18:30:00 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert changes to javafx.web src/main/native
>
> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line
On Tue, 22 Nov 2022 18:54:11 GMT, John Hendrikx wrote:
>> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 156:
>>
>>> 154:
>>> 155: @SuppressWarnings("unchecked")
>>> 156: public void add(Object element) {
>>
>> by removing a checked exception we are changing
On Tue, 22 Nov 2022 16:43:06 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be aut
On Tue, 22 Nov 2022 16:49:52 GMT, John Hendrikx wrote:
>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be aut
On Tue, 22 Nov 2022 15:09:30 GMT, Kevin Rushforth wrote:
> I just noticed that this touches files under `javafx.web/src/main/native`.
> This will cause extra work for us, since we keep all of the files under
> `javafx.web/src/main/native` in sync across release families (and we will
> definite
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class d
> - Remove unsupported/unnecessary SuppressWarning annotations
> - Remove reduntant type specifications (use diamond operator)
> - Remove unused or duplicate imports
> - Remove unnecessary casts (type is already correct type or can be autoboxed)
> - Remove unnecessary semi-colons (at end of class d
23 matches
Mail list logo
