Re: [Openlp-core] [Merge] lp:~trb143/openlp/general into lp:openlp

2011-03-16 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/general/+merge/53518 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/json into lp:openlp

2011-03-16 Thread Jonathan Corwin
Review: Needs Fixing Line 1669: I think it gets the text of the current song, rather than slide? But may be wrong... Remove commented code on 1734, 1743, 1744, 2062, 2063 Indent too big on line 1765 -- https://code.launchpad.net/~raoul-snyman/openlp/json/+merge/53605 Your team OpenLP Core is

[Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2011-03-16 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/53615 Hello Fixed adjusting x, y, height and width fields to the values of

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/json into lp:openlp

2011-03-16 Thread Tim Bentley
Review: Approve From my point of view looks fine. I don't read JS ! -- https://code.launchpad.net/~raoul-snyman/openlp/json/+merge/53605 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2011-03-16 Thread Tim Bentley
Review: Needs Fixing No sure how the code change matches with the comment. The screens object should hold the current screen so the answer should be the same. What happens if size is not set? Mark as needs fixing so I can have a closer look tonite. --

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/json into lp:openlp

2011-03-16 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/json/+merge/53618 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2011-03-16 Thread Andreas Preikschat
Let me explain it in detail. The signal config_screen_changed will be emitted when the position/size of the display screen has been changed (in OpenLP), which reloads the gerneral tab. In trunk the screen values (from the system) will be adjusted to the values the user set in OpenLP. See

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2011-03-16 Thread Raoul Snyman
Actually, I think that we shouldn't have the top set of labels. Just have the labels and edit boxes, with the current checkbox /below/ the edit boxes, and when the person checks the checkbox, the edit boxes become editable. By default the edit boxes read readonly/disabled, and display the

[Openlp-core] [Bug 735039] Re: Cannot import PowerPoint Presentations with PowerPoint 2010

2011-03-16 Thread Jonathan Corwin
** Changed in: openlp/trunk Status: In Progress = Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/735039 Title: Cannot import PowerPoint Presentations with PowerPoint 2010 Status

[Openlp-core] [Bug 727732] Re: Openlp 1.9.?? crashes on start

2011-03-16 Thread Jonathan Corwin
** Changed in: openlp Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/727732 Title: Openlp 1.9.?? crashes on start Status in OpenLP - Worship Presentation

[Openlp-core] [Bug 696637] Re: Alert not positioned correctly in single screen

2011-03-16 Thread Jonathan Corwin
** Changed in: openlp Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/696637 Title: Alert not positioned correctly in single screen Status in OpenLP -

[Openlp-core] [Bug 696021] Re: presentation loader does not work fine in Windows using Powerpoint Viewer 2007

2011-03-16 Thread Jonathan Corwin
** Changed in: openlp Milestone: None = 1.9.5 ** Changed in: openlp Status: Confirmed = In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/696021 Title: presentation loader does

[Openlp-core] [Bug 690774] Re: Add missing songs floods the database with duplicates

2011-03-16 Thread Andreas Preikschat
** Changed in: openlp Status: Confirmed = Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/690774 Title: Add missing songs floods the database with duplicates Status in OpenLP -

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/songs into lp:openlp

2011-03-16 Thread Jonathan Corwin
Review: Needs Fixing 107: typo: serach Comment starting on lines 275. I think perhaps you need to clarify old with say v1.9.4. That way in 25 years time when developing version 15, we'll know how old old is and whether we need to keep the code in or not. I think it would be useful in all

[Openlp-core] [Merge] lp:~trb143/openlp/general into lp:openlp

2011-03-16 Thread noreply
The proposal to merge lp:~trb143/openlp/general into lp:openlp has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~trb143/openlp/general/+merge/53518 -- https://code.launchpad.net/~trb143/openlp/general/+merge/53518 Your team OpenLP Core is

[Openlp-core] [Bug 730474] Re: Does not add big media to OOS

2011-03-16 Thread Launchpad Bug Tracker
** Branch linked: lp:openlp -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/730474 Title: Does not add big media to OOS Status in OpenLP - Worship Presentation Software: Fix Released Bug

[Openlp-core] [Bug 707725] Re: Live mode, down arrow loops within service items

2011-03-16 Thread Tim Bentley
** Changed in: openlp Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/707725 Title: Live mode, down arrow loops within service items Status in OpenLP -

[Openlp-core] [Bug 730160] Re: Display if a single screen does not work

2011-03-16 Thread Tim Bentley
** Changed in: openlp Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/730160 Title: Display if a single screen does not work Status in OpenLP - Worship

[Openlp-core] [Bug 730474] Re: Does not add big media to OOS

2011-03-16 Thread Tim Bentley
** Changed in: openlp Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/730474 Title: Does not add big media to OOS Status in OpenLP - Worship Presentation

[Openlp-core] [Merge] lp:~googol-hush/openlp/songs into lp:openlp

2011-03-16 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/songs into lp:openlp. Requested reviews: Jonathan Corwin (j-corwin) For more details, see: https://code.launchpad.net/~googol-hush/openlp/songs/+merge/53661 Hello Added a function to clean songs before saving. This function

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/songs into lp:openlp

2011-03-16 Thread Andreas Preikschat
I also removed an old check, which is not necessary as we do not have the ability to add songs without authors. -- https://code.launchpad.net/~googol-hush/openlp/songs/+merge/53661 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing

[Openlp-core] [Merge] lp:~googol-hush/openlp/songs into lp:openlp

2011-03-16 Thread Andreas Preikschat
The proposal to merge lp:~googol-hush/openlp/songs into lp:openlp has been updated. Description changed to: Hello Added a function to clean songs before saving. This function takes care of the Author unknown, build the search_lyrics and search_title field. - fixed Bug #690774 I added a

[Openlp-core] [Bug 736265] [NEW] MPEG file is not played

2011-03-16 Thread Kamae Norihiro
Public bug reported: I click preview button on media manager with mpeg item selected, it did not display the movie. After that, some function seems working but OpenLP cannot stop with no message. I hit ctrl+C, this error occur. The detailed step is: 1. add mpeg file to media. 2. restart OpenLP

[Openlp-core] [Bug 736265] Re: MPEG file is not played

2011-03-16 Thread Kamae Norihiro
** Attachment added: main window https://bugs.launchpad.net/bugs/736265/+attachment/1912459/+files/mediamanager01.png -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/736265 Title: MPEG file is

[Openlp-core] [Merge] lp:~googol-hush/openlp/songs into lp:openlp

2011-03-16 Thread Andreas Preikschat
The proposal to merge lp:~googol-hush/openlp/songs into lp:openlp has been updated. Description changed to: Hello Added a function to clean songs before saving. This function takes care of the Author unknown, build the search_lyrics and search_title field. - fixed Bug #690774 I added a

[Openlp-core] [Merge] lp:~phill-ridout/openlp/sspBug into lp:openlp

2011-03-16 Thread phill
phill has proposed merging lp:~phill-ridout/openlp/sspBug into lp:openlp. Requested reviews: Tim Bentley (trb143) Jonathan Corwin (j-corwin) Related bugs: Bug #735357 in OpenLP: Songshow plus import adds O1 for title slide in verse order https://bugs.launchpad.net/openlp/+bug/735357 For

[Openlp-core] [Bug 736265] Re: MPEG file is not played

2011-03-16 Thread Tim Bentley
*** This bug is a duplicate of bug 730474 *** https://bugs.launchpad.net/bugs/730474 ** Changed in: openlp Milestone: None = 1.9.5 ** This bug has been marked a duplicate of bug 730474 Does not add big media to OOS * You can subscribe to bug 730474 by following this link:

[Openlp-core] [Bug 736315] [NEW] Media player plugin plays 2 songs at once

2011-03-16 Thread Stevan Pettit
Public bug reported: I started the Media plug-in. selected an MP3 file, then selected Preview. while the song was playing, I clicked Go Live Had 2 instances of the song playing at once. This caused Openlp to lockup (ie I couldn't quit the app). had to power off the machine. Win 7 64 bit.

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/sspBug into lp:openlp

2011-03-16 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/sspBug/+merge/53670 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/songs into lp:openlp

2011-03-16 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol-hush/openlp/songs/+merge/53661 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/json into lp:openlp

2011-03-16 Thread Jonathan Corwin
Review: Approve I'm going to approve as it is much better than previously. Looks great. However one issue that may need looking at is that on my android browser, for some reason when I go into the slides or service I then need to force a reload through the browser to pick up changes. Once I've

[Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2011-03-16 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/trivial into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/53702 Hello - reworked the ui a bit, as requested by Raoul

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2011-03-16 Thread Tim Bentley
Review: Needs Fixing The screen changes are not correct. I had screen 2 selected with override to smaller screen but still got screen 2 Full Screen. Had to restart openlp to get Screen 1 with override to work at all. There is a but with 2 screens in current code but has more issues. --

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/sspBug into lp:openlp

2011-03-16 Thread Jonathan Corwin
Review: Approve Approve -- https://code.launchpad.net/~phill-ridout/openlp/sspBug/+merge/53670 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net

[Openlp-core] [Bug 705614] Re: Bible searches are broken

2011-03-16 Thread Andreas Preikschat
** Changed in: openlp Assignee: (unassigned) = Jon Tibble (meths) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/705614 Title: Bible searches are broken Status in OpenLP - Worship Presentation

[Openlp-core] [Bug 603798] Re: Traceback when saving service

2011-03-16 Thread Andreas Preikschat
** Changed in: openlp Assignee: (unassigned) = Jon Tibble (meths) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/603798 Title: Traceback when saving service Status in OpenLP - Worship

[Openlp-core] [Bug 608409] Re: bible web search does not work

2011-03-16 Thread Andreas Preikschat
** Changed in: openlp Assignee: (unassigned) = Jon Tibble (meths) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/608409 Title: bible web search does not work Status in OpenLP - Worship

[Openlp-core] [Bug 607030] Re: Song Book combo accepts data it doesn't save in song edit form

2011-03-16 Thread Andreas Preikschat
** Changed in: openlp Assignee: (unassigned) = Jon Tibble (meths) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/607030 Title: Song Book combo accepts data it doesn't save in song edit form

[Openlp-core] [Merge] lp:~phill-ridout/openlp/sspBug into lp:openlp

2011-03-16 Thread noreply
The proposal to merge lp:~phill-ridout/openlp/sspBug into lp:openlp has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~phill-ridout/openlp/sspBug/+merge/53670 -- https://code.launchpad.net/~phill-ridout/openlp/sspBug/+merge/53670 Your team

[Openlp-core] [Bug 735357] Re: Songshow plus import adds O1 for title slide in verse order

2011-03-16 Thread Jonathan Corwin
** Changed in: openlp Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/735357 Title: Songshow plus import adds O1 for title slide in verse order Status in

[Openlp-core] [Bug 648346] Re: The help menu does not work with OS X 10.5.8

2011-03-16 Thread Jonathan Corwin
If it's now working for you then I think we can consider it fixed until such time we hear otherwise. ** Changed in: openlp Status: Confirmed = Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP.

[Openlp-core] [Bug 648472] Re: Jpegs can't be used as backgrounds in MacOS

2011-03-16 Thread Jonathan Corwin
Is this something that can be fixed in 10.5? If so, how likely before next week or should we bump to 1.9.6? -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/648472 Title: Jpegs can't be used as

[Openlp-core] [Bug 648472] Re: Jpegs can't be used as backgrounds in MacOS

2011-03-16 Thread Matthias Hub
It is just a packaging problem (I guess), which I have some time next weekend to look into. The bad thing is that I cannot ensure that this will be fixed, because I don't know the root cause of the problem yet :-( -- You received this bug notification because you are a member of OpenLP Core,

[Openlp-core] [Bug 696021] Re: presentation loader does not work fine in Windows using Powerpoint Viewer 2007

2011-03-16 Thread Jonathan Corwin
** Changed in: openlp Status: In Progress = Fix Committed ** Branch linked: lp:~j-corwin/openlp/general -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/696021 Title: presentation loader does

[Openlp-core] [Merge] lp:~j-corwin/openlp/general into lp:openlp

2011-03-16 Thread Jonathan Corwin
The proposal to merge lp:~j-corwin/openlp/general into lp:openlp has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~j-corwin/openlp/general/+merge/53717 -- https://code.launchpad.net/~j-corwin/openlp/general/+merge/53717 Your team OpenLP

[Openlp-core] [Merge] lp:~j-corwin/openlp/general into lp:openlp

2011-03-16 Thread Jonathan Corwin
The proposal to merge lp:~j-corwin/openlp/general into lp:openlp has been updated. Status: Approved = Work in progress For more details, see: https://code.launchpad.net/~j-corwin/openlp/general/+merge/53717 -- https://code.launchpad.net/~j-corwin/openlp/general/+merge/53717 Your team

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/json into lp:openlp

2011-03-16 Thread noreply
The proposal to merge lp:~raoul-snyman/openlp/json into lp:openlp has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/json/+merge/53618 -- https://code.launchpad.net/~raoul-snyman/openlp/json/+merge/53618 Your team OpenLP

[Openlp-core] [Merge] lp:~googol-hush/openlp/songs into lp:openlp

2011-03-16 Thread Raoul Snyman
The proposal to merge lp:~googol-hush/openlp/songs into lp:openlp has been updated. Status: Needs review = Approved For more details, see: https://code.launchpad.net/~googol-hush/openlp/songs/+merge/53661 -- https://code.launchpad.net/~googol-hush/openlp/songs/+merge/53661 Your team OpenLP

[Openlp-core] [Merge] lp:~googol-hush/openlp/songs into lp:openlp

2011-03-16 Thread noreply
The proposal to merge lp:~googol-hush/openlp/songs into lp:openlp has been updated. Status: Approved = Merged For more details, see: https://code.launchpad.net/~googol-hush/openlp/songs/+merge/53661 -- https://code.launchpad.net/~googol-hush/openlp/songs/+merge/53661 Your team OpenLP Core

[Openlp-core] [Bug 690774] Re: Add missing songs floods the database with duplicates

2011-03-16 Thread Andreas Preikschat
fixed in trunk revision 1395 ** Changed in: openlp Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/690774 Title: Add missing songs floods the database

Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/general into lp:openlp

2011-03-16 Thread Raoul Snyman
Review: Approve Looks OK to me. -- https://code.launchpad.net/~j-corwin/openlp/general/+merge/53718 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to :