[Openlp-core] [Bug 1795876] Re: License violations

2018-10-10 Thread Jonathan Corwin
I permit any code of mine to be relicensed to GPLv3+ -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1795876 Title: License violations Status in OpenLP: New Bug description: OpenLP (GPLv2 only)

Re: [Openlp-core] [Question #658172]: Where to download 2.5 for Linux with chord support

2017-09-18 Thread Jonathan Corwin
Question #658172 on OpenLP changed: https://answers.launchpad.net/openlp/+question/658172 Status: Open => Answered Jonathan Corwin proposed the following answer: Hi Brian, Version 2.5 is still in development and not yet finished or released, so I'm afraid there is no simple

[Openlp-core] [Bug 1489649] Re: Video not displaying in 2.1.6

2015-08-28 Thread Jonathan Corwin
OK, I've uninstalled VLC and reinstalled it. The error messages at startup have gone away, yay! However in OpenLP 2.1.6 I'm still sadly only getting a blank screen when playing the video, I only hear the audio. 2.1.5 continues to display the video fine. (I've also tried installing 2.1.6 into a cl

[Openlp-core] [Bug 1489649] Re: Video not displaying in 2.1.6

2015-08-28 Thread Jonathan Corwin
OK I'll try removing all trace when next at Church, but I'm not sure why it currently works fine in OpenLP 2.1.5 and below, but not in 2.1.6? -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1489649 Titl

[Openlp-core] [Bug 1489649] [NEW] Video not displaying in 2.1.6

2015-08-27 Thread Jonathan Corwin
Public bug reported: Windows 7 32 bit. OpenLP configured to use VLC for video. OpenLP 2.1.5 plays video fine with either VLC 2.0.3 or VLC 2.2.1 (32 bit versions) OpenLP 2.1.6 however will only play the audio, the second screen remains black. With VLC 2.0.3 installed, I see no errors on startup.

[Openlp-core] [Bug 1419300] Re: OpenLP freezes when double clicking an image in media manager

2015-02-21 Thread Jonathan Corwin
This and #1413324 may well be the same bug. I've now inadvertently hit it three times at Church, fortunately pre-service, although I'm getting good at saving as I go along now. (Serves me right for using beta software!) Fortunately my operators are better at avoiding this than me. -- You receiv

[Openlp-core] [Bug 1413325] Re: Going live on songs too quickly causes hang

2015-01-21 Thread Jonathan Corwin
Duplicate ** Changed in: openlp Status: New => Invalid -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1413325 Title: Going live on songs too quickly causes hang Status in OpenLP - Worship Pr

[Openlp-core] [Bug 1413324] [NEW] Going live on songs too quickly causes hang

2015-01-21 Thread Jonathan Corwin
Public bug reported: Windows 8.1 OpenLP version 2.1.1 build 2479 In the Song Library or Service file, double click a song to send it live very rapidly over and over. This causes the OpenLP process to hang and never recover. The actual first occurrence of this error occurred on a Sunday morning

[Openlp-core] [Bug 1413325] [NEW] Going live on songs too quickly causes hang

2015-01-21 Thread Jonathan Corwin
Public bug reported: Windows 8.1 OpenLP version 2.1.1 build 2479 In the Song Library or Service file, double click a song to send it live very rapidly over and over. This causes the OpenLP process to hang and never recover. The actual first occurrence of this error occurred on a Sunday morning

[Openlp-core] [Bug 1410843] Re: Drag and drop to Service Manager always goes to bottom

2015-01-15 Thread Jonathan Corwin
I've seen this more recently than the beta. I think it only happens with certain types of item. (Not got OpenLP to try at present) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1410843 Title: Drag a

[Openlp-core] [Bug 1393199] Re: Dragging service manager, prevents dragging songs to it

2015-01-12 Thread Jonathan Corwin
This is a bug, not a feature request. Happy for it to stay at low but it isn't a wish. It could also lead to a bad first experience if a new user rearranges the interface and then finds drag and drop doesn't work, they may think it isn't supported. ** Changed in: openlp Importance: Wishlist

[Openlp-core] [Bug 1405476] [NEW] Media finish time not defaulting correctly

2014-12-24 Thread Jonathan Corwin
Public bug reported: OpenLP 2.1 r2460. Windows 7. Add a media file (a .mp4 in my case) to the service. Right click on the media item in the service, choose Start Time, and edit the Finish Time of the clip. Click OK Right click on the media item again and choose Start Time again. The Finish time

[Openlp-core] [Bug 1401234] [NEW] If preview next item, focus on wrong service item

2014-12-10 Thread Jonathan Corwin
Public bug reported: Windows 7 OpenLP 2.1r2455 If the setting "Automatically preview next item in service" is set, when going live on an item in the service the next item in the service list gets highlighted. This causes some confusion to my operators who can be momentarily unsure which item to s

[Openlp-core] [Bug 1391638] Re: Songs database error when upgrading from 2.0.5 to 2.1.1

2014-11-21 Thread Jonathan Corwin
So can we check for the existence of the authors_songs_1.author_type column (or whatever it is that is different between 2.0.4 and 2.0.5) and do it that way? If it isn't there, give up with a message. -- You received this bug notification because you are a member of OpenLP Core, which is subscrib

[Openlp-core] [Bug 1393199] [NEW] Dragging service manager, prevents dragging songs to it

2014-11-16 Thread Jonathan Corwin
Public bug reported: Windows 7 OpenLP 2.1.1 build bzr2445 If I drag the Service Manager window to a new location, I am then unable to drop a song into it that has been dragged from the Song Library. ** Affects: openlp Importance: Undecided Status: New -- You received this bug not

[Openlp-core] [Bug 1393186] [NEW] Problems editing Start/Finish time of DVD clip in Service

2014-11-16 Thread Jonathan Corwin
Public bug reported: In the media manager I click the DVD button and add a clip, starting at say 2 minutes and ending at 2m30s Save the clip and then add it to the service. In the service manager, right click and choose Start Time since I discover I got it wrong. This defaults the Start time co

[Openlp-core] [Bug 1391638] Re: Songs database error when upgrading from 2.0.5 to 2.1.1

2014-11-15 Thread Jonathan Corwin
Check if the _existing_ version is <2.0.5, that should have said -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1391638 Title: Songs database error when upgrading from 2.0.5 to 2.1.1 Status in OpenL

[Openlp-core] [Bug 1391638] Re: Songs database error when upgrading from 2.0.5 to 2.1.1

2014-11-15 Thread Jonathan Corwin
I think there was some decision made to remove a whole load of legacy upgrade code (some of which pre dated the original final release) but I may well be corrected. I have been thinking the same thing. If the code that offers to do the backup could first check if the version is "<2.0.5", and if so

[Openlp-core] [Bug 1390704] Re: Missing space in ProjectorManager

2014-11-08 Thread Jonathan Corwin
** Changed in: openlp Status: New => Confirmed ** Changed in: openlp Importance: Undecided => Low -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1390704 Title: Missing space in ProjectorMa

[Openlp-core] [Bug 1387275] Re: Cosmetic issues in Projector Manager

2014-11-08 Thread Jonathan Corwin
This seems to have progressed to Fix Committed without all the points being addressed. However Point 2 has since been duplicated on #1390704 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1387275 Titl

[Openlp-core] [Bug 1387284] Re: Select media clip hanging on some DVD's

2014-11-03 Thread Jonathan Corwin
I left it several minutes -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1387284 Title: Select media clip hanging on some DVD's Status in OpenLP - Worship Presentation Software: New Bug descripti

[Openlp-core] [Bug 1387275] Re: Cosmetic issues in Projector Manager

2014-11-02 Thread Jonathan Corwin
Discovered the empty entry is for Unblanking the projector when testing this today. (It worked well with our Sanyo XLM 100) Could the 6 Connect/Disconnect, Blank/Unblank and Power/Standby items all be replaced by 3 toggle icons without text and just tooltips. This would stop them scrolling off the

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bug-1388258 into lp:openlp

2014-11-01 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~trb143/openlp/bug-1388258/+merge/240356 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscr

[Openlp-core] [Bug 1388258] Re: Focus doesn't switch to Live verse when going live on song

2014-10-31 Thread Jonathan Corwin
This works in 2.0.5, so has regressed in 2.1 ** Summary changed: - Service item slide limits + Focus doesn't switch to Live verse when going live on song ** Changed in: openlp Status: New => Confirmed ** Changed in: openlp Importance: Undecided => Medium -- You received this bug not

[Openlp-core] [Bug 1388227] Re: Crash upgrading from 2.0.3 to 2.1.0.2435

2014-10-31 Thread Jonathan Corwin
Portable 2.0.3 -> 2.0.5 -> 2.1.0.2435 works fine. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1388227 Title: Crash upgrading from 2.0.3 to 2.1.0.2435 Status in OpenLP - Worship Presentation Softw

[Openlp-core] [Bug 1388227] Re: Crash upgrading from 2.0.3 to 2.1.0.2435

2014-10-31 Thread Jonathan Corwin
Note, installing 2.1 into a brand new location is fine -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1388227 Title: Crash upgrading from 2.0.3 to 2.1.0.2435 Status in OpenLP - Worship Presentation

[Openlp-core] [Bug 1388227] [NEW] Crash upgrading from 2.0.3 to 2.1.0.2435

2014-10-31 Thread Jonathan Corwin
Public bug reported: Windows 7 In my case the Portable package, but has occurred for normal package too. I installed OpenLPPortable_2.0.3.paf.exe into a new location, and ran OpenLP. I then installed OpenLPPortable_2.1.0.2435.paf into the same location. Installation went fine. During first run i

[Openlp-core] [Bug 1387278] Re: Crash when exporting settings

2014-10-30 Thread Jonathan Corwin
Looking in the registry I have most of the settings directly under 'custom' where they should be, but I do also have display footer duplicated under 'custom/custom'. Bear in mind that my PC has probably had most OpenLP's installed on it, so I guess this setting crept in temporarily at one point,

[Openlp-core] [Bug 1387304] [NEW] Live panel width resizing / blank buttons

2014-10-29 Thread Jonathan Corwin
Public bug reported: O/S: Windows 7 Version: trunk 2.1r2434 I have the Live panel sized to the minimum, so the single drop-down blank buttons appear. If I go live on another song, the panel will sometimes increase and it will display both the dropdown blank buttons and the individual 3 side by

[Openlp-core] [Bug 1387293] [NEW] Unable to set Start/End time on DVD clip

2014-10-29 Thread Jonathan Corwin
Public bug reported: O/S: Windows 7 Version: trunk 2.1r2434 Latest version of VLC. Library -> Media -> Load CD/DVD Loaded a Mamma Mia DVD. This loaded 9 tracks and defaulted to the first one (the film). In the track dropdown list each track showed the correct track length. However in the dialog,

[Openlp-core] [Bug 1387286] [NEW] CD clip gives unsupported filetype error

2014-10-29 Thread Jonathan Corwin
Public bug reported: O/S: Windows 7 Version: trunk 2.1r2434 Latest version of VLC. Library -> Media -> Load CD/DVD Loaded the CD. Created a clip from a CD track. Note the CD played fine from within Select Media Clip dialog. Saved and Closed. Go Live on the new item. I get the message "Unsupporte

[Openlp-core] [Bug 1387284] [NEW] Select media clip hanging on some DVD's

2014-10-29 Thread Jonathan Corwin
Public bug reported: O/S: Windows 7 Version: trunk 2.1r2434 Latest version of VLC. Library -> Media -> Load CD/DVD I had an issue where this just hung OpenLP for some DVD's and I had to kill OpenLP in the task manager. Sadly I can't now reproduce, it will load them fine. Is it possible to intr

[Openlp-core] [Bug 1387278] [NEW] Crash when exporting settings

2014-10-29 Thread Jonathan Corwin
Public bug reported: O/S: Windows 7 Version: trunk 2.1r2434 File -> Export -> Settings. Choose location and Enter a file name. Gives crash dialog: Traceback (most recent call last): File "C:\Users\Jonathan\Documents\projects\openlp\trunk\openlp\core\ui\mainwindow.py", line 981, in on_settings

[Openlp-core] [Bug 1387275] [NEW] Cosmetic issues in Projector Manager

2014-10-29 Thread Jonathan Corwin
Public bug reported: O/S:Windows 7 Version: trunk 2.1r2434 1. In the Projector Manager panel, on the toolbar, there is an empty entry at the end after Blank Projector. 2. On the 'View' menu, there is a missing space in "ProjectorManager" 3. Do we want the Projector Manager visible by default?

Re: [Openlp-core] [Merge] lp:~sam92/openlp/footer-copyright into lp:openlp

2014-07-06 Thread Jonathan Corwin
I would like the copyright field to be free format as now. More often as not I copy and paste this as is, I don't want to have to remember to ignore the copyright symbol. Also many of the song importers will bring in a copyright symbol. Also some folk may want the copyright symbol elsewhere in

Re: [Openlp-core] [Merge] lp:~sam92/openlp/footer-copyright into lp:openlp

2014-07-06 Thread Jonathan Corwin
Yes. -- https://code.launchpad.net/~sam92/openlp/footer-copyright/+merge/225641 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : ht

Re: [Openlp-core] [Merge] lp:~sam92/openlp/2.0-bug-1310523 into lp:openlp/2.0

2014-04-21 Thread Jonathan Corwin
> > For some reason my support login isn't working, probably because I haven't > > logged in for who knows how long, so I have no clue as to the bizarre > > situation causing someone to have 26 verse 1's. > They had put a whole service (multiple songs and announcements) in one son OK, so sounds li

Re: [Openlp-core] [Merge] lp:~sam92/openlp/2.0-bug-1310523 into lp:openlp/2.0

2014-04-21 Thread Jonathan Corwin
Review: Needs Information For some reason my support login isn't working, probably because I haven't logged in for who knows how long, so I have no clue as to the bizarre situation causing someone to have 26 verse 1's. But anyway if OpenLyrics doesn't want multiple v1's (hence why we append the

[Openlp-core] [Bug 1304677] Re: Theme Level defaults to Song, should default to Global

2014-04-08 Thread Jonathan Corwin
Related to this, when using Global themes: The Theme dropdown still appears in the service manager. When editing/adding a song, the option to assign it a theme still appears which could lead to confusion since it won't be used. -- You received this bug notification because you are a member of Op

Re: [Openlp-core] [Merge] lp:~sam92/openlp/author-types into lp:openlp

2014-04-01 Thread Jonathan Corwin
> > 168 why remove. You can now haw songs without an author! > Yes, the string "Author unknown" is being shown in the footer when a song has > no author. We have made a conscious decision previously to always force an author when adding a song just to encourage folk to obey copyright and credit t

[Openlp-core] [Bug 1259606] Re: Clicking Verse Button doesn't alter live slide

2013-12-10 Thread Jonathan Corwin
** Changed in: openlp Status: New => Confirmed ** Changed in: openlp Importance: Undecided => Medium -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1259606 Title: Clicking Verse Button doe

Re: [Openlp-core] [Merge] lp:~felipe-q/openlp/Powerpoint-COM-Interface into lp:openlp

2013-11-06 Thread Jonathan Corwin
Review: Disapprove I don't think we need to add a 1.1MB file that isn't actually being used yet. I suggest we just add the definitions we need as and when we make use of them. This file could be held elsewhere for reference rather than in bzr. -- https://code.launchpad.net/~felipe-q/openlp/Pow

Re: [Openlp-core] [Merge] lp:~felipe-q/openlp/Powerpoint-COM-Interface into lp:openlp

2013-11-06 Thread Jonathan Corwin
Why? -- https://code.launchpad.net/~felipe-q/openlp/Powerpoint-COM-Interface/+merge/194019 Your team OpenLP Core is requested to review the proposed merge of lp:~felipe-q/openlp/Powerpoint-COM-Interface into lp:openlp. ___ Mailing list: https://launchp

Re: [Openlp-core] [Merge] lp:~oliwee/openlp/bug-1247025 into lp:openlp

2013-11-01 Thread Jonathan Corwin
This behaviour has been bugging me forever, glad someone has been brave enough to dive in! :) Have you tried out all the various scenarios such as when adding multiple images as a group, dropping in an image group and either side of it, ensuring things are OK when expanded, etc? -- https://cod

[Openlp-core] [Merge] lp:~phill-ridout/openlp/1012110_2.0 into lp:openlp/2.0

2013-10-26 Thread Jonathan Corwin
The proposal to merge lp:~phill-ridout/openlp/1012110_2.0 into lp:openlp/2.0 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~phill-ridout/openlp/1012110_2.0/+merge/192230 -- https://code.launchpad.net/~phill-ridout/openlp/1012110_2.0/+me

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1012110_2.0 into lp:openlp/2.0

2013-10-26 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/1012110_2.0/+merge/192230 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.ne

[Openlp-core] [Merge] lp:~oliwee/openlp/bug-1223841 into lp:openlp/2.0

2013-10-16 Thread Jonathan Corwin
The proposal to merge lp:~oliwee/openlp/bug-1223841 into lp:openlp/2.0 has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~oliwee/openlp/bug-1223841/+merge/188229 -- https://code.launchpad.net/~oliwee/openlp/bug-1223841/+merge/188229 Your te

Re: [Openlp-core] [Merge] lp:~oliwee/openlp/bug-1223841 into lp:openlp/2.0

2013-10-16 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~oliwee/openlp/bug-1223841/+merge/188229 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsu

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1012110_2.0 into lp:openlp/2.0

2013-10-07 Thread Jonathan Corwin
> Presumably it worked fine opening the file in Power Point with out using > OpenLP? Yes it did -- https://code.launchpad.net/~phill-ridout/openlp/1012110_2.0/+merge/189494 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1012110_2.0 into lp:openlp/2.0

2013-10-07 Thread Jonathan Corwin
Worked with an English file name. Didn't work with the file name Հայաստան.pptx (Didn't crash, just said it couldn't open filename ?.pptx) However this might be an issue with the C++ in pptviewlib.dll rather than the python. -- https://code.launchpad.net/~phill-ridout/openlp/1012110_2.0/+

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/20_bug_1117098 into lp:openlp/2.0

2013-09-30 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~marmyshev/openlp/20_bug_1117098/+merge/186251 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.ne

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-songbeamer-import into lp:openlp

2013-09-26 Thread Jonathan Corwin
Review: Needs Fixing -- https://code.launchpad.net/~sam92/openlp/fix-songbeamer-import/+merge/187815 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpa

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-09-18 Thread Jonathan Corwin
This now works fine on Windows -- https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/186095 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launch

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/bug_1117098 into lp:openlp

2013-09-17 Thread Jonathan Corwin
Review: Needs Fixing This causes a 1 pixel white border to appear around the transparent display screen on Windows. -- https://code.launchpad.net/~marmyshev/openlp/bug_1117098/+merge/186095 Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/20_bug_1117098 into lp:openlp/2.0

2013-09-17 Thread Jonathan Corwin
Has it been tested on Windows / Linux? I recall having fun with transparency where fixing something on one platform had nasty side effects on others! -- https://code.launchpad.net/~marmyshev/openlp/20_bug_1117098/+merge/186100 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-718797-2.0 into lp:openlp/2.0

2013-09-16 Thread Jonathan Corwin
I fear this could be the start of a slippery slope. We managed to introduce a bug into 2.0.2 without adding new features. If we start adding a little surprise feature here and there, no matter how small, then more little bugs could creep in. My personal opinion is that we should stick to bug fi

[Openlp-core] [Bug 1215830] Re: OSIS import is line/regex based, not XML based

2013-08-23 Thread Jonathan Corwin
Tomas, is this a hypothetical bug "It might not work if...", or have you found an example OSIS Bible which didn't import? If the latter, please attach it. If the former then I'm sure we've got plenty of real bugs to fix before we worry about code that might not work under situations that might n

Re: [Openlp-core] [Merge] lp:~oliwee/openlp/HideBibleVerses into lp:openlp

2013-08-15 Thread Jonathan Corwin
I personally don't like adding stuff to the media manager unless it is really necessary, to avoid clutter. I would prefer it to start in the settings, and then wait and see if a load of people would find it convenient to have it more easily accessible since they change it frequently. If so, we

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/mupdf into lp:openlp

2013-07-26 Thread Jonathan Corwin
Push it and get it reviewed :) -- https://code.launchpad.net/~tomasgroth/openlp/mupdf/+merge/174849 Your team OpenLP Core is requested to review the proposed merge of lp:~tomasgroth/openlp/mupdf into lp:openlp. ___ Mailing list: https://launchpad.net/~

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/mupdf into lp:openlp

2013-07-23 Thread Jonathan Corwin
Tim, I don't understand why adding a new player /here/ will be a big problem. Yes it was a problem for media because that was all integrated with songs, the toolbar, etc and there was a lot of overlap across plugins. However the Presentations plugin is completely designed to deal with third par

Re: [Openlp-core] [Merge] lp:~tomasgroth/openlp/mupdf into lp:openlp

2013-07-22 Thread Jonathan Corwin
(Note comment only, I've not looked at the code) I too think it is nice to keep it in the Presentation plugin. The user is dealing with a PDF file as far as they are concerned and transporting the PDF in the service file rather than lots of images is in my view the correct way of doing this. Im

Re: [Openlp-core] [Merge] lp:~openlp-core/openlp/python3-productive into lp:openlp

2013-07-13 Thread Jonathan Corwin
Windows: Traceback (most recent call last): File "openlp.py", line 45, in main() File "C:\Users\Jonathan\Documents\projects\openlp\python3-2to3\openlp\core\__i nit__.py", line 275, in main qInitResources() File "C:\Users\Jonathan\Documents\projects\openlp\python3-2to3\openlp\core\re

Re: [Openlp-core] [Merge] lp:~trb143/openlp/junefixes into lp:openlp

2013-06-30 Thread Jonathan Corwin
Review: Needs Fixing Started and then exited OpenLP... Traceback (most recent call last): File "C:\Users\Jonathan\Documents\projects\openlp\junefixes\openlp\core\ui\mainwindow.py", line 1036, in closeEvent self.clean_up() File "C:\Users\Jonathan\Documents\projects\openlp\junefixes\open

Re: [Openlp-core] [Merge] lp:~trb143/openlp/title into lp:openlp

2013-05-25 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~trb143/openlp/title/+merge/165730 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

[Openlp-core] [Bug 1165905] Re: import generic doc on OSX

2013-04-16 Thread Jonathan Corwin
So we'd convert it to a plain text file and then import that? This would be OK for the generic doc/ppt as long as page breaks/slide breaks can be detected in the output file somehow. However the "Songs of Fellowship" import relies on knowing where bold/italics/breaks are etc to figure out where v

[Openlp-core] [Bug 1090641] Re: CCLI license doesn't display

2013-03-08 Thread Jonathan Corwin
I never said it was a simple fix Tim, but it is still a bug. Now we have the registry, I'm sure it'll be easier to find out plugin knowledge, or have a standard method in a plugin which takes a mediaitem and updates it with any site specific changes that are needed. If I install OpenLP on a new co

[Openlp-core] [Bug 1090641] Re: CCLI license doesn't display

2013-03-08 Thread Jonathan Corwin
Andreas, not sure what you thought was missing? The CCLI information displayed on screen should reflect the settings of the computer currently being used, not the one that the service was created on. -- You received this bug notification because you are a member of OpenLP Core, which is subscribe

[Openlp-core] [Bug 914637] Re: Translucent display has broken phonon video

2013-03-08 Thread Jonathan Corwin
Unlikely -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/914637 Title: Translucent display has broken phonon video Status in OpenLP - Worship Presentation Software: Confirmed Bug description: I

Re: [Openlp-core] [Merge] lp:~googol/openlp/transitions into lp:openlp

2013-03-06 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~googol/openlp/transitions/+merge/151975 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscr

Re: [Openlp-core] [Merge] lp:~googol/openlp/transitions into lp:openlp

2013-03-05 Thread Jonathan Corwin
Umm "did actually" not "didn't actually" -- https://code.launchpad.net/~googol/openlp/transitions/+merge/151808 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@list

Re: [Openlp-core] [Merge] lp:~googol/openlp/transitions into lp:openlp

2013-03-05 Thread Jonathan Corwin
I see on lines 41 and 42 that I didn't actually try css transitions and commented on why I didn't go ahead. Obviously the manual approach (as slow as it is) was still quicker than the HTML5 approach back then! Hopefully things have improved since then... I assume you've tried it on something oth

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-902964-2 into lp:openlp/2.0

2013-03-04 Thread Jonathan Corwin
Ahh, I hadn't spotted that. Why do we need to fix this in 2.0, aren't they just warning messages? -- https://code.launchpad.net/~googol/openlp/bug-902964-2/+merge/151088 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. ___ Mailing list: htt

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-902964-2 into lp:openlp/2.0

2013-03-04 Thread Jonathan Corwin
My view is that if someone is running an older system, then they should also be happy running an older OpenLP (i.e. 2.0). If at some point they really want/need to run a newer OpenLP then they ought to be prepared to upgrade the system too. -- https://code.launchpad.net/~googol/openlp/bug-90296

Re: [Openlp-core] [Merge] lp:~googol/openlp/tests into lp:openlp

2013-02-16 Thread Jonathan Corwin
But it's not testing you're always getting the tags correctly. All it's testing is the function returns the same thing twice. It could be returning a collection of turnips. -- https://code.launchpad.net/~googol/openlp/tests/+merge/148748 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/presentation into lp:openlp

2013-02-13 Thread Jonathan Corwin
You may have tried this, but is it possible to re-activate the PowerPoint window prior to sending the commands? There looks to be some "Activate" applescript command to do this? -- https://code.launchpad.net/~marmyshev/openlp/presentation/+merge/143389 Your team OpenLP Core is subscribed to bran

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp

2013-02-11 Thread Jonathan Corwin
Review: Needs Fixing I decided to join in... Line 45, should be a space before the 'and' :) -- https://code.launchpad.net/~raoul-snyman/openlp/imp/+merge/147748 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpa

Re: [Openlp-core] [Merge] lp:~trb143/openlp/settings_migration into lp:openlp

2013-02-11 Thread Jonathan Corwin
Review: Needs Fixing Line 9: qq? Is this a debug line that needs removing? The assert messages... still not getting these right. From what I understand, the messages appear if the test fails, but the message once again is stating that they 'is' something, when they won't be that thing if we see

Re: [Openlp-core] [Question #221503]: Is there a page describing the OSZ file format?

2013-02-11 Thread Jonathan Corwin
Question #221503 on OpenLP changed: https://answers.launchpad.net/openlp/+question/221503 Jonathan Corwin posted a new comment: Regarding the service files, there is an open wishlist item to make a more portable service file, however as with many things it just requires someone with the time to

Re: [Openlp-core] [Merge] lp:~googol/openlp/screen into lp:openlp

2013-02-06 Thread Jonathan Corwin
Seems to be missing a test... -- https://code.launchpad.net/~googol/openlp/screen/+merge/146811 Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/screen into lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-

[Openlp-core] [Bug 1113740] [NEW] Resetting keyboard shortcuts crashes

2013-02-02 Thread Jonathan Corwin
Public bug reported: In 2.0.1 Settings -> Configure Shortcuts Click Restore Defaults Yes to the warning. Click OK. Get the following traceback... Traceback (most recent call last): File "C:\Users\Jonathan\Documents\projects\openlp\2.0\openlp\core\ui\mainwindow.py", line 941, in onSettingsS

Re: [Openlp-core] [Merge] lp:~trb143/openlp/media into lp:openlp

2013-01-30 Thread Jonathan Corwin
Review: Approve Approve, but I think Raoul should cast his eye over the UI click tests to make sure he's happy -- https://code.launchpad.net/~trb143/openlp/media/+merge/145680 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

Re: [Openlp-core] [Merge] lp:~trb143/openlp/media into lp:openlp

2013-01-29 Thread Jonathan Corwin
Review: Needs Fixing When I put [duplicate service|missing service|deleted service] I meant pick the relevant one for each assert... 3629: u'KeyError exception should have been thrown for duplicate service' 3639: u'KeyError exception should have been thrown for missing service' 3647: u'KeyError

Re: [Openlp-core] [Merge] lp:~trb143/openlp/media into lp:openlp

2013-01-28 Thread Jonathan Corwin
Review: Needs Fixing 1275 load_File -> load_file 3163 no space after = Several of the assert messages are saying the expected thing has happened, rather than should have happened. Also on 3737 I don't understand the message. -- https://code.launchpad.net/~trb143/openlp/media/+merge/145103 Yo

Re: [Openlp-core] [Merge] lp:~trb143/openlp/media into lp:openlp

2013-01-27 Thread Jonathan Corwin
Review: Needs Fixing Line 100 - If changing a setting key, the old/new pair needs to be added to Settings.__obsolete_settings__ to migrate it. -- https://code.launchpad.net/~trb143/openlp/media/+merge/145084 Your team OpenLP Core is subscribed to branch lp:openlp. __

Re: [Openlp-core] [Merge] lp:~googol/openlp/central-settings-place into lp:openlp

2013-01-23 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~googol/openlp/central-settings-place/+merge/144588 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.n

Re: [Openlp-core] [Merge] lp:~elderp/openlp/packaging-version into lp:openlp/packaging

2013-01-23 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~elderp/openlp/packaging-version/+merge/144042 Your team OpenLP Core is subscribed to branch lp:openlp/packaging. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launch

Re: [Openlp-core] [Merge] lp:~elderp/openlp/packaging2-version into lp:openlp/packaging-2.0

2013-01-23 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~elderp/openlp/packaging2-version/+merge/144041 Your team OpenLP Core is subscribed to branch lp:openlp/packaging-2.0. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.l

Re: [Openlp-core] [Merge] lp:~googol/openlp/central-settings-place into lp:openlp

2013-01-23 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~googol/openlp/central-settings-place/+merge/144198 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.n

[Openlp-core] [Bug 1102642] Re: Slide Loop does not work when display is blanked

2013-01-21 Thread Jonathan Corwin
I don't think it should loop when blanked, that is a bit silly. However yes the looping should restart when the display is unblanked. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1102642 Title: Sl

[Openlp-core] [Bug 1085921] Re: Locale aware sorting has broken the song export form

2013-01-20 Thread Jonathan Corwin
** Changed in: openlp Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1085921 Title: Locale aware sorting has broken the song export form Status in OpenLP -

Re: [Openlp-core] [Merge] lp:~googol/openlp/central-settings-place into lp:openlp

2013-01-20 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~googol/openlp/central-settings-place/+merge/144019 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.n

Re: [Openlp-core] [Merge] lp:~googol/openlp/central-settings-place into lp:openlp

2013-01-20 Thread Jonathan Corwin
Review: Needs Fixing Loading a service file... Traceback (most recent call last): File "C:\Users\Jonathan\Documents\projects\openlp\central-settings-place\openlp\core\ui\servicemanager.py", line 379, in onLoadServiceClicked self.loadFile(fileName) File "C:\Users\Jonathan\Documents\proj

Re: [Openlp-core] [Merge] lp:~googol/openlp/central-settings-place into lp:openlp

2013-01-20 Thread Jonathan Corwin
Review: Needs Fixing Traceback (most recent call last): File "openlp.pyw", line 53, in main() File "C:\Users\Jonathan\Documents\projects\openlp\central-settings-place\openl p\core\__init__.py", line 318, in main sys.exit(app.run(qt_args)) File "C:\Users\Jonathan\Documents\projects\o

Re: [Openlp-core] [Merge] lp:~trb143/openlp/media into lp:openlp

2013-01-19 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~trb143/openlp/media/+merge/143994 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

Re: [Openlp-core] [Merge] lp:~trb143/openlp/media into lp:openlp

2013-01-19 Thread Jonathan Corwin
Review: Approve Approved for the application code, however could do with someone else checking the Tests since I don't have enough knowledge yet to know if these are correct. -- https://code.launchpad.net/~trb143/openlp/media/+merge/143988 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~trb143/openlp/media into lp:openlp

2013-01-19 Thread Jonathan Corwin
Review: Needs Information What is the .has_all_original_files property for? It seems to be set a lot but I can't see it used. -- https://code.launchpad.net/~trb143/openlp/media/+merge/143985 Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~trb143/openlp/media into lp:openlp

2013-01-19 Thread Jonathan Corwin
Review: Needs Fixing Existing line of code in vlcplayer.py:239 (update_ui) causes the video to jump backwards and forwards. If I comment this line out it works fine, other than the slider not moving in time with the video. controller.seekSlider.setSliderPosition(display.vlcMediaPlayer.get_time

Re: [Openlp-core] [Merge] lp:~googol/openlp/not-used-imports into lp:openlp

2013-01-19 Thread Jonathan Corwin
Review: Approve Taking over from Meths? :) -- https://code.launchpad.net/~googol/openlp/not-used-imports/+merge/143968 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-co

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/item_title into lp:openlp

2013-01-11 Thread Jonathan Corwin
Also you need to bear in mind that songs and customs can be linked between the media manager and the service manager. So editing a song will sometimes also change the media manager item (depending on settings). Therefore you need to consider the consequences of changing the service item name.

[Openlp-core] [Bug 1098167] Re: Images always get black background when loaded from saved service file

2013-01-10 Thread Jonathan Corwin
** Changed in: openlp Status: New => Confirmed ** Also affects: openlp/2.0 Importance: Undecided Status: New ** Changed in: openlp Milestone: None => 2.1.1 ** Changed in: openlp/2.0 Milestone: None => 2.0.1 ** Changed in: openlp Assignee: (unassigned) => Arjan Schr

  1   2   3   4   5   6   7   8   9   10   >