n
Other n
Comments (indicate scope for each "y" above):
-
changeset 8ce952bca114deaf024fb46e748be49f7b51f5b9
Author: Anders Bjornerstedt <anders.bjornerst...@ericsson.com>
Date: Mon, 05 Oct 2015 10:04:47 +0200
osaf/services/saf/immsv/README | 309 -
1 files changed, 306 insertions(+), 3 deletions(-)
diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README
--- a/osaf/services/saf/immsv/README
+++ b/osaf/services/saf/immsv/README
@@ -2378,6
Other n
Comments (indicate scope for each "y" above):
-
changeset 76ff50abc2d6549cf900173a80470d34ba741c91
Author: Anders Bjornerstedt <anders.bjornerst...@ericsson.com>
Date: Fri, 02 Oct 2015 12:57:26 +0200
osaf/services/saf/immsv/README | 202 -
1 files changed, 200 insertions(+), 2 deletions(-)
diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README
--- a/osaf/services/saf/immsv/README
+++ b/osaf/services/saf/immsv/README
@@ -2378,6
osaf/services/saf/immsv/immnd/ImmModel.cc | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
Correction done to ImmModel::ccbApply for correctly handling an attempt
to apply a CCB that is already aborted.
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
n
Other n
Comments (indicate scope for each y above):
-
changeset b063db9e91b864153e4fef54140d674fc27cc245
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Fri, 10 Jul 2015 15:53:15 +0200
IMM
osaf/services/saf/immsv/immpbed/immpbe.cc | 22 +-
1 files changed, 13 insertions(+), 9 deletions(-)
Using a syncronous admin-op results in the PBE getting blocked until the
admin-op has been completed. The admin-op only sets a flag in he IMMND coord
indicating the request
Other n
Comments (indicate scope for each y above):
-
changeset d844faaf6d52f9096283e16cad438785388a617f
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Wed, 08 Jul 2015 14:46:29 +0200
IMM PBE: use syncronous
osaf/services/saf/immsv/immnd/ImmModel.cc | 67 --
1 files changed, 62 insertions(+), 5 deletions(-)
Essentially the same code sections that exist in ImmModel::ccbObjectCreate
for adding to the sReverseRefsNoDanglingMMap have been cloned to
ImmModel::objectSync. The
n
Other n
Comments (indicate scope for each y above):
-
changeset 18f4d1d50a9c415ad896aa7a34e69d3207b07a0e
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Thu, 04 Jun 2015 17:45:26 +0200
IMM
osaf/services/saf/immsv/immnd/ImmModel.cc | 66 +++---
1 files changed, 33 insertions(+), 33 deletions(-)
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
--- a/osaf/services/saf/immsv/immnd/ImmModel.cc
+++
n
Comments (indicate scope for each y above):
-
changeset 1f4806fc69b78224e59d754cfcaecc9d6978ccf3
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Thu, 04 Jun 2015 18:16:23 +0200
#1382 IMM: Correct syslog
n
Other n
Comments (indicate scope for each y above):
-
changeset ec4019e68ed3a24a738d9cc403fb7277e188f0d6
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Tue, 26 May 2015 14:08:00 +0200
IMM: Detour
osaf/services/saf/immsv/immnd/ImmModel.cc | 30 +++---
osaf/services/saf/immsv/immnd/immnd_evt.c | 2 +-
2 files changed, 16 insertions(+), 16 deletions(-)
The detour seemed mostly to deal with handling of the SaImmScopeT type.
The scope of SA_IMM_ONE is only relevant
n
Other n
Comments (indicate scope for each y above):
-
changeset 8073b1de0515c7a82cc4cdc89aee39a682a86e06
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Thu, 21 May 2015 14:26:58 +0200
IMM: Detach
osaf/services/saf/immsv/immpbed/immpbe.cc | 24 ++--
1 files changed, 22 insertions(+), 2 deletions(-)
If the PBE detaches and re-attaches while there are one or more open
non-critical (not yet committing) but non-empty CCBs, then before this
enhancement one would see the
osaf/services/saf/immsv/immnd/ImmModel.cc | 34 --
1 files changed, 23 insertions(+), 11 deletions(-)
The original fix only worked for aborting CCBs where there was an OI
actively involved in processing a ccb callback at the time of the admin-op.
It did not work
Other n
Comments (indicate scope for each y above):
-
changeset a2d0bc92571db5d5aac892cb55e79aed1ad0bb32
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Wed, 20 May 2015 23:48:21 +0200
IMM: Correction
osaf/libs/common/immsv/include/immsv_api.h | 5 +-
osaf/services/saf/immsv/README | 33 +---
osaf/services/saf/immsv/immnd/ImmModel.cc | 47 +++--
osaf/services/saf/immsv/immnd/ImmModel.hh | 5 +-
4 files changed, 71 insertions(+), 19
n
Comments (indicate scope for each y above):
-
changeset 24e645d723715705aaa1a69290a4e41a7a03ff00
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Wed, 06 May 2015 16:27:56 +0200
IMM: Support admin-op
Other n
Comments (indicate scope for each y above):
-
changeset b2ca36ec5d86f5df64bede49617a31cca1d82484
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Mon, 27 Apr 2015 09:48:03 +0200
immsv: Revert
osaf/libs/agents/saf/imma/imma_cb.h | 2 +-
osaf/libs/agents/saf/imma/imma_proc.c | 5 -
2 files changed, 5 insertions(+), 2 deletions(-)
The member imma_client_node-replyPending was in OpenSAF4.1 and earlier
defined as 'uns8', i.e. a byte. But this member is a counter and not a
osaf/services/saf/immsv/README | 6 +++---
osaf/services/saf/immsv/README.SASTRINGT_API | 15 ---
2 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README
--- a/osaf/services/saf/immsv/README
+++
n
Comments (indicate scope for each y above):
-
changeset 60b2136fcadf82f653b43ba1b5790f6dc3be3161
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Fri, 24 Apr 2015 14:40:09 +0200
IMM: Clarifications
osaf/services/saf/immsv/immnd/ImmModel.cc | 6 +-
osaf/services/saf/immsv/immnd/immnd_evt.c | 2 +-
2 files changed, 6 insertions(+), 2 deletions(-)
The problem was triggerde by the handling of the unusual case of a PRTA
update failing during on going sync due to PBE being configured but
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 027d50d366a89fd40049c8e54b72089ce19a0437
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Thu, 09 Apr 2015 06:46:10 +0200
n
Comments (indicate scope for each y above):
-
changeset 38ee6c6effb4a682924e90e07a2c62c72b669291
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Thu, 26 Mar 2015 14:30:33 +0100
IMM: Update immsv/README
osaf/services/saf/immsv/README | 22 --
1 files changed, 0 insertions(+), 22 deletions(-)
diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README
--- a/osaf/services/saf/immsv/README
+++ b/osaf/services/saf/immsv/README
@@ -2281,28 +2281,6 @@ The main
osaf/services/saf/immsv/immnd/ImmModel.cc | 7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
The IMMND server maintains request continuations containing the destination
for replying on non CCB requests such as to update PRT data or class-create,
schema-change and class-delete.
Some
n
Other n
Comments (indicate scope for each y above):
-
changeset 347a2a15ece303e619a85d1f324781e413fc0eaf
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Thu, 26 Mar 2015 16:04:33 +0100
IMM
n
Other n
Comments (indicate scope for each y above):
-
changeset f2ac5db4eb089751b882e8464b19d06127db19a8
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Wed, 25 Mar 2015 06:11:29 +0100
IMM: Add
osaf/services/saf/immsv/README.SASTRINGT_API | 265 +++
1 files changed, 265 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/immsv/README.SASTRINGT_API
b/osaf/services/saf/immsv/README.SASTRINGT_API
new file mode 100644
--- /dev/null
+++
osaf/services/saf/immsv/README | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
This README clarification patch is related to the fix done in:
6129:492918cdca13
branch: opensaf-4.4.x
parent: 6126:9b636f41027f
user:Zoran Milinkovic
Hi Hung,
Ack from me.
Tested with immomtest immoitest.
Good work
/AndersBj
Hung Nguyen wrote:
Summary: imm: Return BAD_OPERATION for OiRtObject operations whith no
implementer [#1064]
Review request for Trac Ticket(s): 1064
Peer Reviewer(s): AndersBj, Neelakanta
Pull request to:
Ack from me (not tested).
/AndersBj
reddy.neelaka...@oracle.com wrote:
osaf/services/saf/immsv/immnd/ImmModel.cc | 25 +
osaf/services/saf/immsv/immnd/immnd_evt.c | 6 +++---
osaf/services/saf/immsv/immnd/immnd_proc.c | 4 ++--
3 files changed, 18
Hi Neel,
Ack from me, if you have tested the trailing slash case.
I tested only the normal case (patch non interference).
[I think i would have not copied the string for the normal case (no
trailing slash).
Its also possible to local stack allocate an array of a given size,
avoiding local
Fix in ImmModel.cc is OK
But there are still problems with the fix of ModifyCallback.
Some error cases that jump to done will now omitt to remove the immutils
data.
So I have to nack this patch.
unless the fix in ModifyCallback is really simple, then at this point I
would suggest the
Sorry, my mistake.
I took the new version as the old version and vice versa.
Ack
To the patch.
/AndersBj
Anders Bjornerstedt wrote:
Fix in ImmModel.cc is OK
But there are still problems with the fix of ModifyCallback.
Some error cases that jump to done will now omitt to remove the immutils
Ack from me.'
I tested with immomtest and immoitest.
There are some oddities in these tests, but they seem to be errors in
the testlogic and not
errors in the imm code as such.
/AndersBj
Zoran Milinkovic wrote:
osaf/libs/agents/saf/imma/imma_proc.c | 30 +-
1
osaf/services/saf/immsv/README | 25 +
1 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/osaf/services/saf/immsv/README b/osaf/services/saf/immsv/README
--- a/osaf/services/saf/immsv/README
+++ b/osaf/services/saf/immsv/README
@@ -1907,6 +1907,31 @@
n
Other n
Comments (indicate scope for each y above):
-
changeset 01de2f755fc809ce363f8737c03463e09c73324e
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Wed, 19 Nov 2014 13:36:14 +0100
IMM
Hi Neel,
First: Good work in analyzing the problem and finding the location where
it starts.
There is a serious bug in pbe2_ok_to_prepare_ccb_at_B() in
immpbe_daemon.cc.
It is a bit surprising to me that the problem has not been observed earlier.
You are doing quite intense stress testing of
The severity error log messages seen in the original syslogs should be
seen contributing to the
signaling that something was seriously wrong. That signaling does not
need fixing/elimination.
When things are working properly we should either get OK from both or
error from both.
The error
Good work in general, but one serious bug see below.
While testing I also see this:
Nov 17 10:55:52.381328 osafimmnd [407:immsv_evt.c:2423] ER DECODE
IMMND_EVT_A2ND_SEARCHINIT WRONG ENUM VALUE
Ack conditional on fixing the serious bug below.
/AndersBj
Zoran Milinkovic wrote:
osaf/libs/agents/saf/imma/imma_proc.c | 49 +
osaf/libs/common/immsv/immsv_evt.c | 8 +++-
osaf/libs/common/immsv/include/immsv_evt.h | 1 +
osaf/services/saf/immsv/immnd/ImmModel.cc | 48 ++--
osaf/libs/agents/saf/imma/imma_proc.c | 37 ++--
osaf/libs/common/immsv/immsv_evt.c | 8 -
osaf/libs/common/immsv/include/immsv_evt.h | 1 +
osaf/services/saf/immsv/immnd/ImmModel.cc | 38 ++---
Yes I agree with that.
This would be an update to the README clarifying that an OI doing a ccb
augmentation should
not do other things interleaved with ccb augmentation operations.
In addition, an enhancement ticket should be written to fix the problem
that after the augmentation is
closed,
But the REAMDE fix and the enhancewment are not caused by the fix for
this ticket.
/AndersBj
Anders Bjornerstedt wrote:
Yes I agree with that.
This would be an update to the README clarifying that an OI doing a ccb
augmentation should
not do other things interleaved with ccb augmentation
n
Other n
Comments (indicate scope for each y above):
-
changeset e97a9e305b04f2fcbef71eb900120196616f88d2
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Thu, 06 Nov 2014 12:20:00 +0100
IMM
osaf/services/saf/immsv/immnd/ImmModel.cc | 18 +++---
osaf/services/saf/immsv/immnd/ImmModel.hh | 2 +-
2 files changed, 12 insertions(+), 8 deletions(-)
The case of an object-applier (note *not* class-applier) re-attaching
idempotently (it already has existed as an object
osaf/services/saf/immsv/immnd/ImmModel.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
saImmOmCcbValidate retuurned without canceling the ccb-oi-timer resulting
in the potential abort of the ccb due to timeout when the om-user is
idling, between saImmOmCcbValidate and the
n
Comments (indicate scope for each y above):
-
changeset 64d212d11dbb21399a7b953f1b9b3d3389d4c7e5
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Tue, 04 Nov 2014 14:30:10 +0100
IMM: saImmOmCcbValidate must
Hi Zoran,
Overall the fixes are in the right direction.
But I found a few problems so I have to NACK this patch version.
This is an unusually tricky ticket.
We only allow augmentations of one level currently so at least that puts
some limitation on the complexity.
The most complex case is a
Other n
Comments (indicate scope for each y above):
-
changeset 0d2f4f196e2a9d73013834172010dcee47cad681
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Wed, 29 Oct 2014 16:09:46 +0100
2PBE: PBE slave
osaf/services/saf/immsv/immnd/immnd_proc.c | 9 +
1 files changed, 5 insertions(+), 4 deletions(-)
The imm.db file is regenerated by the slave if cb-mPbeVeteranB is false.
The logic for setting mPbeVeteranB to false has been corrected in a few
places to be more eager. In particular
Other n
Comments (indicate scope for each y above):
-
changeset 08b37f75f0c72168af718b8628a7f8a71a6545e7
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Mon, 27 Oct 2014 11:27:07 +0100
IMM 2PBE: Slave main
osaf/services/saf/immsv/immloadd/imm_loader.cc | 21 ++---
1 files changed, 14 insertions(+), 7 deletions(-)
The sync retry time was changed from 150msec to the huge value of 2 seconds
in ticket #851 (OpenSAF 4.5). This large value may have been apropriate
for optimizing some
n
Other n
Comments (indicate scope for each y above):
-
changeset d4db60a064ef9d803a8fd757dadf9ea50b97ad95
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Thu, 23 Oct 2014 11:06:45 +0200
IMM: Sync
n
Other n
Comments (indicate scope for each y above):
-
changeset 587f7e4c0d6d517322a039d75e5d36905a1ae517
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Wed, 22 Oct 2014 14:33:13 +0200
IMM 2PBE
Other n
Comments (indicate scope for each y above):
-
changeset 9e75d7c5fa2e9d2fe80e957b79c12c2c80e73d0d
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Fri, 10 Oct 2014 14:23:34 +0200
IMM (2PBE): Fix
osaf/libs/common/immsv/immpbe_dump.cc| 7 ++---
osaf/services/saf/immsv/immnd/immnd_evt.c| 22 +++---
osaf/services/saf/immsv/immpbed/immpbe_daemon.cc | 28
3 files changed, 30 insertions(+), 27 deletions(-)
This patch is not a pure
osaf/services/saf/immsv/immnd/ImmModel.cc | 37 +-
1 files changed, 30 insertions(+), 7 deletions(-)
Updating the config attribute 'longDnsAllowed' in the object
'opensafImm=opensafImm,safApp=safImmService' to the value 0 has the
meaning of not allowing long DNs.
Other n
Comments (indicate scope for each y above):
-
changeset 994787ecf9d429b61cca8fdd0ffdd86d990675ea
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Tue, 07 Oct 2014 13:53:42 +0200
IMM: Validating
osaf/services/saf/immsv/immnd/immnd_evt.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c
b/osaf/services/saf/immsv/immnd/immnd_evt.c
--- a/osaf/services/saf/immsv/immnd/immnd_evt.c
+++
n
Other n
Comments (indicate scope for each y above):
-
changeset 19bd95b8f891f5a6daad8a7262a792dc03c91157
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Thu, 02 Oct 2014 16:09:03 +0200
IMM: Changed
Ack from me with the following three minor comments:
(1)
To be consistent and complete section 2.1 should mention API version
A.2.14 (om API only) related to OpenSAF 4.5.
The new API is for saImmOmCcbValidate and saImmOmCcbAbort (can be found
under osaf/libs/saf/include/saImmOm_A_2_14.h)
but
Ack from me.
/AndersBj
Zoran Milinkovic wrote:
osaf/libs/agents/saf/imma/imma_om_api.c | 22 +++---
1 files changed, 15 insertions(+), 7 deletions(-)
Add missing check for the case that root name length is great than 0, and
root name value length is 0.
diff --git
Tentative ACK with same comment as Neel.
Plus a question on a small part of the code below, see inline.
Zoran Milinkovic wrote:
osaf/libs/agents/saf/imma/imma_om_api.c | 24 ++--
1 files changed, 18 insertions(+), 6 deletions(-)
Add missing check for the case that root
Ack with comment inlined below.
Only tested for non-interference.
Not tested for effectiveness.
Hans Feldt wrote:
osaf/services/saf/immsv/immnd/immnd_evt.c | 67
++
1 files changed, 48 insertions(+), 19 deletions(-)
SMF running as non root cannot change
n
Other n
Comments (indicate scope for each y above):
-
changeset 9f43733a20d973b066e87a0a1d3251c6f89afdb9
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Wed, 24 Sep 2014 13:00:35 +0200
IMM: Failure
Other n
Comments (indicate scope for each y above):
-
changeset 2b3ee8b1df5e360f716a741603f7554a1f81ccdb
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Mon, 22 Sep 2014 10:56:38 +0200
imm: Corrected trace
osaf/services/saf/immsv/immnd/ImmModel.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Problem reported by coverity.
A trace statement was using the wrong iterator variable.
diff --git a/osaf/services/saf/immsv/immnd/ImmModel.cc
b/osaf/services/saf/immsv/immnd/ImmModel.cc
---
n
Other n
Comments (indicate scope for each y above):
-
changeset df26c266f9c0f713bf1313c5202dfb279ff4fa59
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Mon, 22 Sep 2014 16:50:07 +0200
imm
osaf/services/saf/immsv/immnd/immnd_evt.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
The case is where a CCB has passed validation by all involved OIs. Normally the
next step, if PBE is enabled, is to send the completed callbac to the PBE-OI.
The PBE actually commits the
Right.
Ack from me.
/AndesBj
Zoran Milinkovic wrote:
The problem is not ignored.
Just after switch statement, there is a check if the iterator points to the
end of list, and handle this situation.
Regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: den 19
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 2b8de6fac4a8c77b5f1f54c8b1b7ed4817662985
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Fri, 19 Sep 2014 12
osaf/services/saf/immsv/immnd/ImmModel.cc | 13 -
1 files changed, 12 insertions(+), 1 deletions(-)
Reset the iterator to make sure it still points to the same position.
The element has been deleted and re-created. All the standard associative
containers keep their elements in
Ack from me.
AndersBj
reddy.neelaka...@oracle.com wrote:
osaf/services/saf/immsv/immnd/immnd_evt.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c
b/osaf/services/saf/immsv/immnd/immnd_evt.c
---
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 34cfbb17a1bf2580ca4fac6d2ad77fab8b17cad7
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Fri, 19 Sep 2014 12:53:32 +0200
osaf/services/saf/immsv/immnd/ImmModel.cc | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
The existing assert in ImmModel::adjustEpoch is extended to cover the
case of the object pointer being NULL. This should never be the case
because an entry in the object-map (with the DN being
Other n
Comments (indicate scope for each y above):
-
changeset c0b63ca1b14b2cf5876e25d95e39fc54f2f38382
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Fri, 19 Sep 2014 13:21:23 +0200
IMM: Extend osafassert
n
Other n
Comments (indicate scope for each y above):
-
changeset ef22ceaed5f5cb2afea7e01a1769c6e493498ecc
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Tue, 16 Sep 2014 09:10:30 +0200
imm
osaf/services/saf/immsv/immnd/immnd_evt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Error detected by coverity.
diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c
b/osaf/services/saf/immsv/immnd/immnd_evt.c
--- a/osaf/services/saf/immsv/immnd/immnd_evt.c
+++
Other n
Comments (indicate scope for each y above):
-
changeset d01668fdd65d9f64622f747043d0d972483d184d
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Tue, 16 Sep 2014 09:41:47 +0200
IMM: Add client
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset 8d97fb57dc57b0be9dcf51eca0cc1ab6c6ea4072
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Tue, 16 Sep 2014 17:41:42 +0200
osaf/services/saf/immsv/immnd/ImmModel.cc | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
The incorrect expression resulted in the omission of appending to the
ccb-create-oi-callback, the default values for persistent runtime attributes
that (a) where not explicitly assigned in the
n
Other n
Comments (indicate scope for each y above):
-
changeset 490ab6ebfdbefb8503123dd87d9bb2b824f7af67
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Thu, 11 Sep 2014 11:30:35 +0200
IMM
osaf/services/saf/immsv/immnd/immnd_evt.c | 48 +-
1 files changed, 34 insertions(+), 14 deletions(-)
The local immnd enforces access control for saImmOmAdminOwnerClear if
access-control is enabled.
In addition, a minor change of code is done for
A few questions below, see inline.
Hans Feldt wrote:
osaf/libs/agents/saf/imma/imma.h | 1 +
osaf/libs/agents/saf/imma/imma_init.c | 6 ++
osaf/libs/agents/saf/imma/imma_mds.c | 7 ---
3 files changed, 11 insertions(+), 3 deletions(-)
diff --git
Hans Feldt wrote:
-Original Message-
From: Anders Bjornerstedt [mailto:anders.bjornerst...@ericsson.com]
Sent: den 10 september 2014 11:37
To: Hans Feldt
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [devel] [PATCH 2 of 2] imma: use mds_auth_server_disconnect
[#1050]
A few
Usually, when I find myself in a situation where there is an error case
that in theory could happen
but I cant figure out if/when it will happen, which also should mean
that it is rare, then instead
of writing any elaborate code to deal with it, I either osafassert
(which will log an error and
osaf/services/saf/immsv/immnd/ImmModel.cc | 40 +++---
1 files changed, 30 insertions(+), 10 deletions(-)
The IMMND logs database size at certain threshold levels. The log severity
for these mesages was set to WArning as early as 5000 objects. The warning
severity
n
Comments (indicate scope for each y above):
-
changeset c3bc91d3bd60613401dabdc203e6569824d831ff
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Mon, 08 Sep 2014 11:23:35 +0200
IMM: Reduce log severity
Yes thanks.
I will introduce an 'else' branch before pushing.
/AndersBj
Zoran Milinkovic wrote:
On every 10 objects, the same message will be written twice to the log.
Ack when the comment is fixed.
Best regards,
Zoran
-Original Message-
From: Anders Björnerstedt
Sent: den
n
Tests n
Other n
Comments (indicate scope for each y above):
-
changeset ea38da749f5ac89f16349fb133a4786303f849a1
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Fri, 05 Sep 2014 15
osaf/services/saf/immsv/immnd/immnd_evt.c | 40 --
1 files changed, 21 insertions(+), 19 deletions(-)
Access controll for the imm service has been generalized to cover
any modifications of the two imm service objects:
opensafImm=opensafImm,safApp=safImmService
osaf/services/saf/immsv/immnd/ImmModel.cc | 67 ++
1 files changed, 48 insertions(+), 19 deletions(-)
When the attribute 'longDnsAllowed' is changed form non-zero to zero,
this implies that the imm is transitoning from allowing long DNs to
not allowing long DNs.
n
Other n
Comments (indicate scope for each y above):
-
changeset 6b2e0aa0dadf26ccabe52822604841803680917c
Author: Anders Bjornerstedt anders.bjornerst...@ericsson.com
Date: Thu, 04 Sep 2014 11:49:31 +0200
IMM: PBE exits
osaf/services/saf/immsv/immpbed/immpbe.cc| 15 +++
osaf/services/saf/immsv/immpbed/immpbe_daemon.cc | 8 ++--
2 files changed, 13 insertions(+), 10 deletions(-)
Errors returned from calls in the library:
osaf/libs/common/immsv/immpbe_dump.cc
where the sqlite
Ack from me with the nano-optimization suggested below
reddy.neelaka...@oracle.com wrote:
osaf/services/saf/immsv/immnd/ImmModel.cc | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
At the time of OIfinalizing of the OI handle, An FEVS message is sent to
clear the implementer. A
1 - 100 of 230 matches
Mail list logo
