[devel] [PATCH 1 of 1] clm: avoid checking length of sanamet when clm service is filling data [#2002]

2016-09-09 Thread mathi . naickan
osaf/libs/agents/saf/clma/clma_api.c | 23 --- 1 files changed, 0 insertions(+), 23 deletions(-) When CLM is going to fill the values of notification buffer, there is no need to check the length values that is passed by the user. Also, there can be cases when user has a big

[devel] [PATCH 0 of 1] Review Request for clm: avoid checking length of sanamet when clm service is filling data [#2002]

2016-09-09 Thread mathi . naickan
Summary: clm: avoid checking length of sanamet when clm service is filling data [#2002] Review request for Trac Ticket(s): #2002 Peer Reviewer(s): Zoran Pull request to: <> Affected branch(es): opensaf-5.1.x, default Development branch: <> Impacted area Im

[devel] [PATCH 0 of 1] Review Request for smfd: fix the calculation of elapsedtime wrt the user configured smfRebootTimeout attr [#1811]

2016-05-12 Thread mathi . naickan
Summary: smfd: fix the calculation of elapsedtime wrt the user configured smfRebootTimeout attr [#1811] Review request for Trac Ticket(s): #1811 Peer Reviewer(s): Rafael, Lennart Pull request to: <> Affected branch(es): opensaf-4.7.x, 5.0, default Development branch: <> -

[devel] [PATCH 1 of 1] smfd: include elapsedtime correctly in waitForNodeDestination and getNodeDestination [#1811]

2016-05-12 Thread mathi . naickan
osaf/services/saf/smfsv/smfd/SmfUpgradeAction.cc | 4 ++-- osaf/services/saf/smfsv/smfd/SmfUpgradeStep.cc | 8 osaf/services/saf/smfsv/smfd/SmfUtils.cc | 23 +++ osaf/services/saf/smfsv/smfd/SmfUtils.hh | 2 +- 4 files changed, 26 insertions(+)

[devel] [PATCH 0 of 1] Review Request for smfd: choose the AU type with highest scope in merged procedure [#1810]

2016-05-10 Thread mathi . naickan
Summary: smfd: choose the AU type with highest scope in merged procedure [#1810] Review request for Trac Ticket(s): #1810 Peer Reviewer(s): rafael.odza...@ericsson.com;lennart.l...@ericsson.com Pull request to: Affected branch(es): 4.7.x, 5.0.x, default Development branch: <>

[devel] [PATCH 1 of 1] smfd: choose the AU type with highest scope in merged procedure [#1810]

2016-05-10 Thread mathi . naickan
osaf/services/saf/smfsv/smfd/SmfUpgradeStep.cc | 70 ++ 1 files changed, 70 insertions(+), 0 deletions(-) When SMF_MERGE_TO_SINGLE_STEP feature is enabled and the step requires reboot, i.e. when saSmfBundleInstallOfflineScope or saSmfBundleRemoveOfflineScope is set to SA

[devel] [PATCH 4 of 4] msg: init with clm before entering initialize_for_assignment() [#1781]

2016-04-28 Thread mathi . naickan
osaf/services/saf/mqsv/mqd/mqd_api.c | 95 --- 1 files changed, 53 insertions(+), 42 deletions(-) With the introduction of spares support #79, all services were modified to wait for AMF role assignment to register with MDS and proceed further with their lifecycl

[devel] [PATCH 3 of 4] evt: init with clm before entering initialize_for_assignment() [#1781]

2016-04-28 Thread mathi . naickan
osaf/services/saf/edsv/eds/eds_api.c | 23 ++- 1 files changed, 14 insertions(+), 9 deletions(-) With the introduction of spares support #79, all services were modified to wait for AMF role assignment to register with MDS and proceed further with their lifecycle. However, t

[devel] [PATCH 2 of 4] ckpt: init with clm before entering initialize_for_assignment() [#1781]

2016-04-28 Thread mathi . naickan
osaf/services/saf/cpsv/cpd/cpd_init.c | 94 +++--- 1 files changed, 52 insertions(+), 42 deletions(-) With the introduction of spares support #79, all services were modified to wait for AMF role assignment to register with MDS and proceed further with their lifecycl

[devel] [PATCH 0 of 4] Review Request for osaf: init with clm before setting up to wait for AMF role [#1781]

2016-04-28 Thread mathi . naickan
Summary: init with clm before setting up to wait for AMF role [#1781] Review request for Trac Ticket(s): #1781 Peer Reviewer(s): Praveen/HansN, rameshb, Mahesh Pull request to: <> Affected branch(es): opensaf-5.0.x, default Development branch: <> Impacted area

[devel] [PATCH 1 of 4] amf: init with clm before entering initialize_for_assignment() [#1781]

2016-04-28 Thread mathi . naickan
osaf/services/saf/amf/amfd/main.cc | 8 osaf/services/saf/amf/amfd/role.cc | 5 - 2 files changed, 8 insertions(+), 5 deletions(-) With the introduction of spares support #79, all services were modified to wait for AMF role assignment to register with MDS and proceed further with

[devel] [PATCH 1 of 1] clm: fix node_down handling at standby when preceded by admin op [#1643]

2015-12-18 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_evt.c | 4 1 files changed, 4 insertions(+), 0 deletions(-) Node downs are checkpointing to the standbys. Standby CLMD is also a subscriber of MDS NODE_DOWN events. The Standby CLMD should ensure integrity when processing duplicate or out-of-order arrival

[devel] [PATCH 0 of 1] Review Request for clm: fix node_down handling at standby when preceded by admin op [#1643]

2015-12-18 Thread mathi . naickan
Summary: clm: fix node_down handling at standby when preceded by admin op [#1643] Review request for Trac Ticket(s): #1643 Peer Reviewer(s): ramesh.bet...@oracle.com Pull request to: <> Affected branch(es): <> Development branch: 4.6, 4.7, default Impacted area

[devel] [PATCH 1 of 1] osaf: During adminrestart of node directors, before re-instantiating kill them [#1326]

2015-05-06 Thread mathi . naickan
osaf/services/saf/cpsv/cpnd/cpnd_amf.c | 14 +- osaf/services/saf/cpsv/cpnd/scripts/osaf-ckptnd.in | 13 + osaf/services/saf/glsv/glnd/glnd_amf.c | 14 ++ osaf/services/saf/glsv/glnd/scripts/osaf-lcknd.in | 13 + osaf

[devel] [PATCH 0 of 1] Review Request for osaf: During adminrestart of node directors, before re-instantiating kill them [#1326]

2015-05-06 Thread mathi . naickan
Summary: osaf: During adminrestart of node directors, before re-instantiating kill them [#1326] Review request for Trac Ticket(s): #1326 Peer Reviewer(s): AndersW, Ramesh - General aspects. HansN,Nagendra, Praveen from AMF perspective Pull request to: <> Affected branch(es): opensaf-4.5.x, 4.6.x,

[devel] [PATCH 1 of 1] osaf: kill NodeDirector processes before re-instantiating to support admin restart [#1326]

2015-04-29 Thread mathi . naickan
osaf/services/saf/cpsv/cpnd/cpnd_amf.c | 13 - osaf/services/saf/cpsv/cpnd/scripts/osaf-ckptnd.in | 13 + osaf/services/saf/glsv/glnd/glnd_amf.c | 12 osaf/services/saf/glsv/glnd/scripts/osaf-lcknd.in | 13 + osaf/se

[devel] [PATCH 0 of 1] Review Request for osaf: During adminrestart, kill NodeDirector processes before re-instantiating [#1326]

2015-04-29 Thread mathi . naickan
Summary: osaf: kill NodeDirector processes before re-instantiating to support adminrestart [#1326] Review request for Trac Ticket(s): #1326 Peer Reviewer(s): AndersW, Ramesh, HansN, Nagendra, Praveen Pull request to: <> Affected branch(es): All Development branch: <>

[devel] [PATCH 1 of 1] smfd: smfd: adjust smfRebootTimeout to include time spent in getNodeDestination v2 [#1272]

2015-04-13 Thread mathi . naickan
osaf/services/saf/smfsv/smfd/SmfUpgradeAction.cc | 4 +- osaf/services/saf/smfsv/smfd/SmfUpgradeStep.cc | 32 ++-- osaf/services/saf/smfsv/smfd/SmfUtils.cc | 20 ++ osaf/services/saf/smfsv/smfd/SmfUtils.hh | 2 +- osaf/services/saf/smfsv/smfd

[devel] [PATCH 0 of 1] Review Request for smfd: adjust smfRebootTimeout to include time spent in getNodeDestination v2[#1272]

2015-04-13 Thread mathi . naickan
Summary: smfd: adjust smfRebootTimeout to include time spent in getNodeDestination v2 [#1272] Review request for Trac Ticket(s): #1272 Peer Reviewer(s): Robert, Ingvar (Alex, everyone interested) Pull request to: <> Affected branch(es): opensaf-4.5.x, 4.6.x, default Development branch: <> ---

[devel] [PATCH 1 of 1] smfd: adjust smfRebootTimeout to include time spent in getNodeDestination [#1272]

2015-04-07 Thread mathi . naickan
osaf/services/saf/smfsv/smfd/SmfUpgradeAction.cc | 4 ++-- osaf/services/saf/smfsv/smfd/SmfUpgradeStep.cc | 24 +--- osaf/services/saf/smfsv/smfd/SmfUtils.cc | 9 +++-- osaf/services/saf/smfsv/smfd/SmfUtils.hh | 2 +- 4 files changed, 27 insertions(

[devel] [PATCH 0 of 1] Review Request for smfd: adjust smfRebootTimeout to include time spent in getNodeDestination [#1272]

2015-04-07 Thread mathi . naickan
Summary: smfd: adjust smfRebootTimeout to include time spent in getNodeDestination [#1272] Review request for Trac Ticket(s): #1272 Peer Reviewer(s): Ingvar, Robert Pull request to: <> Affected branch(es): 4.5.x, 4.6.x, default Development branch: <> Impacted area

[devel] [PATCH 1 of 1] pyosaf: add immom subpackage under utils of pyosaf [#1223]

2015-03-16 Thread mathi . naickan
Makefile.common |2 + configure.ac |2 + opensaf.spec.in |6 + python/pyosaf/Makefile.am |2 + python/pyosaf/utils/Makefile.am | 24 ++ python/pyosaf/utils/__init__.py |0 python/pyo

[devel] [PATCH 0 of 1] Review Request for pyosaf: add immom subpackage under utils of pyosaf -v3 [#1223]

2015-03-16 Thread mathi . naickan
Summary: pyosaf: add immom subpackage of tools repo under utils of pyosaf -v3 [#1223] Review request for Trac Ticket(s): #1223 Peer Reviewer(s): HansF Pull request to: <> Affected branch(es): default Development branch: <> Impacted area Impact y/n -

[devel] [PATCH 1 of 1] pyosaf: add immom subpackage under utils of pyosaf [#1223]

2015-03-16 Thread mathi . naickan
Makefile.common |2 + configure.ac |2 + opensaf.spec.in |6 + python/pyosaf/Makefile.am |2 + python/pyosaf/utils/Makefile.am | 24 ++ python/pyosaf/utils/immom/Makefile.am | 26 ++ python/p

[devel] [PATCH 0 of 1] Review Request for pyosaf: add immom subpackage under utils of pyosaf - v2 [#1223]

2015-03-16 Thread mathi . naickan
Summary: pyosaf: add immom subpackage of tools repo under utils of pyosaf: v2 [#1223] Review request for Trac Ticket(s): #1223 Peer Reviewer(s): HansF Pull request to: <> Affected branch(es): default Development branch: <> Impacted area Impact y/n -

[devel] [PATCH 0 of 1] Review Request for pyosaf: add amf/immom subpackage of tools repo under utils of pyosaf [#1223]

2015-03-11 Thread mathi . naickan
Summary: pyosaf: add amf/immom subpackage of tools repo under utils of pyosaf [#1223] Review request for Trac Ticket(s): #1223 Peer Reviewer(s): HansF, SrikanthR Pull request to: <> Affected branch(es): 4.6(default) Development branch: <> Impacted area Imp

[devel] [PATCH 1 of 1] pyosaf: add immom subpackage under utils of pyosaf [#1223]

2015-03-11 Thread mathi . naickan
Makefile.common |2 + configure.ac |2 + opensaf.spec.in |6 + python/pyosaf/Makefile.am |2 + python/pyosaf/utils/Makefile.am | 24 ++ python/pyosaf/utils/immom/Makefile.am | 27 +++ python/

[devel] [PATCH 0 of 1] Review Request for clm: return SA_AIS_ERR_INVALID_PARAM for negative timeout values [#738]

2015-03-11 Thread mathi . naickan
Summary: clm: return SA_AIS_ERR_INVALID_PARAM for negative timeout values [#738] Review request for Trac Ticket(s): #738 Peer Reviewer(s): Neel Pull request to: <> Affected branch(es): all Development branch: <> Impacted area Impact y/n --

[devel] [PATCH 1 of 1] clm: return SA_AIS_ERR_INVALID_PARAM for negative timeout values [#738]

2015-03-11 Thread mathi . naickan
osaf/libs/agents/saf/clma/clma_api.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) Currently reverting to this behaviour of returing SA_AIS_ERR_INVALID_PARAM for negative timeout values. Can be takenup later to have a uniform treatment. diff --git a/osaf/libs/agents/saf/clma/clm

[devel] [PATCH 1 of 1] clm: retry when notificationsend return TRY_AGAIN and log error [#1195]

2015-03-11 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms.h |1 + osaf/services/saf/clmsv/clms/clms_ntf.c | 106 +-- 2 files changed, 58 insertions(+), 49 deletions(-) sendStateChangeNotificationClms() is modified to log the error in the following cases when notificationallocate, s

[devel] [PATCH 0 of 1] Review Request for clm: retry when notificationsend return TRY_AGAIN and log error [#1195]

2015-03-11 Thread mathi . naickan
Summary: clm: retry when notificationsend return TRY_AGAIN and log error [#1195] Review request for Trac Ticket(s): #1195 Peer Reviewer(s): Robert, Ramesh/Neel Pull request to: <> Affected branch(es): all Development branch: <> Impacted area Impact y/n --

[devel] [PATCH 0 of 1] Review Request for clm: protect node down processing when checkpointing arrives earlier v2 [#1221]

2014-11-27 Thread mathi . naickan
Summary: clm: protect node down processing when checkpointing arrives earlier - v2 [#1221] Review request for Trac Ticket(s): 1221 Peer Reviewer(s): Bertil, HansNordeBack, Praveen Pull request to: <> Affected branch(es): opensaf-4.3.x and above Development branch: <> ---

[devel] [PATCH 1 of 1] clm: protect node down processing when checkpointing arrives earlier - v2 [#1221]

2014-11-27 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_evt.c | 65 + 1 files changed, 65 insertions(+), 0 deletions(-) On top of fix for #1120, protection is needed while processing node_down by adding a check whether checkpoint entry already exists (instead of handling it during f

[devel] [PATCH 1 of 1] clm: protect node down processing when checkpointing arrives earlier [#1221]

2014-11-27 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_evt.c | 60 + 1 files changed, 60 insertions(+), 0 deletions(-) On top of fix for #1120, protection is needed while processing node_down by adding a check whether checkpoint entry already exists (instead of handling it during f

[devel] [PATCH 0 of 1] Review Request for clm: protect node down processing when checkpointing arrives earlier [#1221]

2014-11-27 Thread mathi . naickan
Summary: clm: protect node down processing when checkpointing arrives earlier [#1221] Review request for Trac Ticket(s): #1221 Peer Reviewer(s): Bertil, HansNordeBack, Praveen Pull request to: <> Affected branch(es): opensaf-4.3 onwards Development branch: <> Impa

[devel] [PATCH 0 of 1] Review Request for smf: fix mem leak call saClmFinalize when saClmClusterNodeGet returns error [#1205]

2014-11-07 Thread mathi . naickan
Summary: smf: fix mem leak call saClmFinalize when saClmClusterNodeGet returns error [#1205] Review request for Trac Ticket(s): #1205 Peer Reviewer(s): Ingvar Pull request to: <> Affected branch(es): opensaf-4.x Development branch: <> Impacted area Impact y/

[devel] [PATCH 1 of 1] smf: fix mem leak, call saClmFinalize when saClmClusterNodeGet returns error [#1205]

2014-11-07 Thread mathi . naickan
osaf/services/saf/smfsv/smfd/smfd_smfnd.c | 4 1 files changed, 4 insertions(+), 0 deletions(-) call saClmFinalize before returning from smfnd_up() whenever saClmClusterNodeGet() returns error. This issue is applicable only to 4.x code base because this leak was fixed by ticket #1166 in

[devel] [PATCH 2 of 3] clm: during failover, process agent down before node downs [#1120]

2014-09-24 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_evt.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) It is quite possible that the agent downs are for the agents that were running on the same node that went down. So, process agent downs first, before processing node downs. diff --

[devel] [PATCH 3 of 3] clm: do not send track for the node that left the cluster because of reboot [#1120]

2014-09-24 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_imm.c | 25 + 1 files changed, 21 insertions(+), 4 deletions(-) It is possible that when a payload that goes down during controller failover, can reboot and come back fast. As a part of failover processing, it is possible that the agent

[devel] [PATCH 1 of 3] clm: avoid stale node down processing and unexpected track callback [#1120]

2014-09-24 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_cb.h | 6 + osaf/services/saf/clmsv/clms/clms_evt.c | 35 - 2 files changed, 40 insertions(+), 1 deletions(-) There is a possiblity that the checkpointing message for a NODE_DOWN reaches the STANDBY first, i.e. before the

[devel] [PATCH 0 of 3] Review Request for clm: harden processing of node & agent down events during failover [#1120]

2014-09-24 Thread mathi . naickan
Summary: clm: harden processing node down events and agents during failover [#1120] Review request for Trac Ticket(s): #1120 Peer Reviewer(s): <> Pull request to: <> Affected branch(es): 4.3 and above Development branch: <> Impacted area Impact y/n -

[devel] [PATCH 0 of 1] Review Request for clm: avoid stale node down processing and unexpected track callback [#1120]

2014-09-22 Thread mathi . naickan
Summary: clm: avoid stale node down processing and unexpected track callback [#1120] Review request for Trac Ticket(s): #1120 Peer Reviewer(s): HansN, RameshB Pull request to: <> Affected branch(es): opensaf-4.3.x and above Development branch: <> Impacted area

[devel] [PATCH 1 of 1] clm: avoid stale node down processing and unexpected track callback [#1120]

2014-09-22 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_cb.h | 6 osaf/services/saf/clmsv/clms/clms_evt.c | 48 2 files changed, 47 insertions(+), 7 deletions(-) There is a possiblity that the checkpointing message for a NODE_DOWN reaches the STANDBY first, i.e. before the M

[devel] [PATCH 1 of 1] base: check and truncate(with character T) logtrace messages >= 1024 bytes [#970]

2014-09-12 Thread mathi . naickan
osaf/libs/core/common/logtrace.c | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) logtrace has locally defined limit of 1024 bytes for the length of message to be printed. It is possible that user of logtrace (TRACE OR LOG_**) can pass messages longer than 1024 byt

[devel] [PATCH 0 of 1] Review Request for base: check and truncate(with character T) logtrace messages >= 1024 bytes [#970]

2014-09-12 Thread mathi . naickan
Summary: base: check and truncate(with character T) logtrace messages >= 1024 bytes [#970] Review request for Trac Ticket(s): #970 Peer Reviewer(s): Hans, Ramesh, Neel Pull request to: <> Affected branch(es): all branches Development branch: <> Impacted area

[devel] [PATCH 0 of 1] Review Request for clm: imm reinit mechanism shall check for impl_set flag in BAD_OPER scenarios [#1067]

2014-09-12 Thread mathi . naickan
Summary: clm: imm reinit mechanism shall check for impl_set flag in BAD_OPER scenarios [#1067] Review request for Trac Ticket(s): #1067 Peer Reviewer(s): Neel Pull request to: <> Affected branch(es): 4.4.x, 4.5.x, default Development branch: <> Impacted area

[devel] [PATCH 1 of 1] clm: imm reinit mechanism shall check for impl_set flag in BAD_OPER scenarios [#1067]

2014-09-12 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_imm.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) It is possible that IMM (probably because of 1057) returns BAD_OPER. This requires hardening of the CLM imm reinit mechanism when error such as BAD_OPER is returned. As a part of admin-sta

[devel] [PATCH 1 of 1] smf: retry modify information model upon CCB abort post cluster restart [#973]

2014-08-07 Thread mathi . naickan
osaf/services/saf/smfsv/smfd/SmfUpgradeStep.cc | 57 ++--- 1 files changed, 50 insertions(+), 7 deletions(-) An upgrade can result ina cluster reboot if requested by the application and post cluster reboot, there is less guarantee(typically in an uncontroller cluster/enviro

[devel] [PATCH 0 of 1] Review Request for smf: retry modify information model when CCB aborted post cluster restart [#973]

2014-08-07 Thread mathi . naickan
Summary: retry modify information model when CCB aborted post cluster restart [#973] Review request for Trac Ticket(s): #973 Peer Reviewer(s): Ingvar, Robert Pull request to: <> Affected branch(es): opensaf-4.3.x, opensaf-4.4.x, default Development branch: <> Impa

[devel] [PATCH 3 of 5] amf: use thread safe localtime_r instead of localtime [#958]

2014-07-16 Thread mathi . naickan
osaf/services/saf/amf/amfwdog/amf_wdog.c | 6 +- 1 files changed, 5 insertions(+), 1 deletions(-) localtime is not thread safe and it can(has) cause crashes in services that are multi threaded. diff --git a/osaf/services/saf/amf/amfwdog/amf_wdog.c b/osaf/services/saf/amf/amfwdog/amf_wdog.

[devel] [PATCH 4 of 5] ntf: use thread safe localtime_r instead of localtime [#958]

2014-07-16 Thread mathi . naickan
osaf/services/saf/ntfsv/ntfs/ntfs_evt.c | 6 +- osaf/tools/safntf/src/ntfclient.c | 6 +- 2 files changed, 10 insertions(+), 2 deletions(-) localtime is not thread safe and it can(has) cause crashes in services that are multi threaded. diff --git a/osaf/services/saf/ntfsv/ntfs/n

[devel] [PATCH 1 of 5] osaf: use thread safe localtime_r instead of localtime [#958]

2014-07-16 Thread mathi . naickan
osaf/libs/core/common/include/logtrace.h | 2 +- osaf/libs/core/common/logtrace.c | 6 +- 2 files changed, 6 insertions(+), 2 deletions(-) localtime is not thread safe and it can(has) cause crashes in services that are multi threaded. diff --git a/osaf/libs/core/common/include/log

[devel] [PATCH 2 of 5] mds: use thread safe localtime_r instead of localtime [#958]

2014-07-16 Thread mathi . naickan
osaf/libs/core/mds/mds_log.c | 6 +- 1 files changed, 5 insertions(+), 1 deletions(-) localtime is not thread safe and it can(has) cause crashes in services that are multi threaded. diff --git a/osaf/libs/core/mds/mds_log.c b/osaf/libs/core/mds/mds_log.c --- a/osaf/libs/core/mds/mds_log.c

[devel] [PATCH 5 of 5] plm: use thread safe localtime_r instead of localtime [#958]

2014-07-16 Thread mathi . naickan
osaf/services/saf/plmsv/plms/plms_dbg_utils.c | 6 +- 1 files changed, 5 insertions(+), 1 deletions(-) localtime is not thread safe and it can(has) cause crashes in services that are multi threaded. diff --git a/osaf/services/saf/plmsv/plms/plms_dbg_utils.c b/osaf/services/saf/plmsv/plms/

[devel] [PATCH 0 of 5] Review Request for replace localtime with thread safe localtime_r [#958]

2014-07-16 Thread mathi . naickan
Summary: replace localtime with thread safe localtime_r [#958] Review request for Trac Ticket(s): #958 Peer Reviewer(s): ramesh, mahesh, hans, praveen, nagendra, alex Pull request to: <> Affected branch(es): 4.3.x, 4.4.x Development branch: <> Impacted area I

[devel] [PATCH 0 of 1] Review Request for smf: update campaign state before restoring pbe in the completed state [#944]

2014-06-23 Thread mathi . naickan
Summary: smf: update campaign state before restoring pbe in the completed state Review request for Trac Ticket(s): #944 Peer Reviewer(s): ingvar.bergst...@ericsson.com Pull request to: <> Affected branch(es): 4.4.x, default Development branch: <> Impacted area

[devel] [PATCH 1 of 1] smf: update campaign state before restoring pbe in the completed state [#944]

2014-06-23 Thread mathi . naickan
osaf/services/saf/smfsv/smfd/SmfCampState.cc | 7 --- 1 files changed, 4 insertions(+), 3 deletions(-) By way of ticket #677 we restore the pbe in the campaign completed state itself. i.e. In SmfCampStateExecuting::executeWrapup() { a) we first restore the pbe i.e. i_camp->restorePbe(); b

[devel] [PATCH 0 of 1] Review Request for log: handle ending quote for messages in variable log records: v2 [#882]

2014-05-22 Thread mathi . naickan
Summary: log: handle ending quote for messages in variable log records: v2 [#882] Review request for Trac Ticket(s): <> Peer Reviewer(s): Lennart Pull request to: <> Affected branch(es): 4.3.x, 4.4.x, default Development branch: <> Impacted area Impact y/n

[devel] [PATCH 1 of 1] log: handle ending quote for messages in variable log records [#882]

2014-05-22 Thread mathi . naickan
osaf/services/saf/logsv/lgs/lgs_evt.c | 2 +- osaf/services/saf/logsv/lgs/lgs_fmt.c | 26 +++--- osaf/services/saf/logsv/lgs/lgs_fmt.h | 2 +- osaf/services/saf/logsv/lgs/lgs_mbcsv.c | 2 +- 4 files changed, 26 insertions(+), 6 deletions(-) Currently, When varibl

[devel] [PATCH 0 of 1] Review Request for log: handle ending quote for messages in variable log records [#882]

2014-05-19 Thread mathi . naickan
Summary: log: handle ending quote for messages in variable log records [#882] Review request for Trac Ticket(s): #882 Peer Reviewer(s): lennart.l...@ericsson.com Pull request to: <> Affected branch(es): opensaf-4.3.x, 4.4.x, default Development branch: <> Impacted

[devel] [PATCH 1 of 1] log: handle ending quote for messages in variable log records [#882]

2014-05-19 Thread mathi . naickan
osaf/services/saf/logsv/lgs/lgs_fmt.c | 8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) Currently, When varible log records are enabled for applications, the log message is missing the ending quote. i.e. as below -a test will create this message: " -a test hello will create this

[devel] [PATCH 1 of 1] clm: pass client_id for deletion; post to mbox only when svc_id is filled [#888]

2014-05-16 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_evt.c | 2 +- osaf/services/saf/clmsv/clms/clms_mds.c | 15 --- 2 files changed, 9 insertions(+), 8 deletions(-) Valgrind reported the following: ==9425== Invalid read of size 4 ==9425== at 0x40AAE2: clms_client_delete_by_mds_dest (clms_evt.c:167)

[devel] [PATCH 0 of 1] Review Request for clm: pass client_id for deletion; post to mbox only when svc_id is filled [#888]

2014-05-16 Thread mathi . naickan
Summary: clm: pass client_id for deletion; post to mbox only when svc_id is filled [#888] Review request for Trac Ticket(s): #888 Peer Reviewer(s): ramesh.bet...@oracle.com Pull request to: <> Affected branch(es): opensaf-4.3.x, opensaf-4.4.x, default Development branch: <> -

[devel] [PATCH 1 of 2] log: saflogger to return EXIT_FAILURE when SaLogWriteLogCallbackT fails- v2 [#884]

2014-05-06 Thread mathi . naickan
osaf/tools/saflog/saflogger/saf_logger.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) saflogger is not returning appropriate exit code to the shell when SaLogWriteLogCallbackT fails either because of an error reported in the callback or because of an invalid invocationId. The pat

[devel] [PATCH 2 of 2] log: saflogtest to return EXIT_FAILURE when SaLogWriteLogCallbackT fails- v1 [#884]

2014-05-06 Thread mathi . naickan
tests/logsv/saflogtest.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) saflogtest is not returning appropriate exit code to the shell when SaLogWriteLogCallbackT fails either because of an error reported in the callback or because of an invalid invocationId. The patch exits with E

[devel] [PATCH 0 of 2] Review Request for log: saflogger to return EXIT_FAILURE when SaLogWriteLogCallbackT fails - v2 [#884]

2014-05-06 Thread mathi . naickan
Summary: log: saflogger to return EXIT_FAILURE when SaLogWriteLogCallbackT fails - v2 [#884] Review request for Trac Ticket(s): #884 Peer Reviewer(s): Lennart Pull request to: <> Affected branch(es): opensaf-4.3.x, 4.4.x, default Development branch: <> Impacted ar

[devel] [PATCH 0 of 1] Review Request for log: saflogger to return EXIT_FAILURE when SaLogWriteLogCallbackT reports error [#884]

2014-05-06 Thread mathi . naickan
Summary: log: saflogger to return EXIT_FAILURE when SaLogWriteLogCallbackT reports error [#884] Review request for Trac Ticket(s): #884 Peer Reviewer(s): lennart.l...@ericsson.com Pull request to: <> Affected branch(es): opensaf-4.3.x, 4.4.x, default Development branch: <> ---

[devel] [PATCH 1 of 1] log: saflogger to return EXIT_FAILURE when SaLogWriteLogCallbackT reports error [#884]

2014-05-06 Thread mathi . naickan
osaf/tools/saflog/saflogger/saf_logger.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) saflogger is not returning appropriate exit code to the shell when SaLogWriteLogCallbackT returns error. The patch exits with EXIT_FAILURE when the SaLogWriteLogCallbackT returns error diff --git

[devel] [PATCH 2 of 2] log: fix errno usage for calls to strtoul - part two [#841]

2014-05-02 Thread mathi . naickan
osaf/services/saf/logsv/lgs/lgs_imm.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) On UML based on ubuntu, the following code fails consistently. if ((val_str = getenv(LOGSV_MAX_LOGRECSIZE)) != NULL) { val_uint = strtoul(val_str, NULL, 0);

[devel] [PATCH 0 of 2] Review Request for log: ignore environment variables when config object exists [#841]

2014-05-02 Thread mathi . naickan
Summary: log: ignore environment variables when config object exists [#841] Review request for Trac Ticket(s): #841 Peer Reviewer(s): lennart.l...@ericsson.com Pull request to: <> Affected branch(es): opensaf-4.3.x, 4.4.x, default Development branch: <> Impacted

[devel] [PATCH 1 of 2] log: ignore environment variables when config object exists - part two [#841]

2014-05-02 Thread mathi . naickan
osaf/services/saf/logsv/config/logsv_classes.xml | 5 +- osaf/services/saf/logsv/lgs/lgs_imm.c| 58 +++- 2 files changed, 61 insertions(+), 2 deletions(-) The OpenSAF integrator can either use the log service configuration object or the environment variables t

[devel] [PATCH 0 of 2] Review Request for clm: process node down outside impl_set thread to avoid race [#800]

2014-05-01 Thread mathi . naickan
Summary: clm: avoid any functional processing from impl_set thread #800 Review request for Trac Ticket(s): #800 Peer Reviewer(s): ramesh.bet...@oracle.com; tony hart @btisystems Pull request to: <> Affected branch(es): opensaf-4.3.x, 4.4.x, default Development branch: <> --

[devel] [PATCH 1 of 2] clm: process node down outside impl_set thread to avoid race [#800]

2014-05-01 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms.h | 1 + osaf/services/saf/clmsv/clms/clms_amf.c | 2 ++ osaf/services/saf/clmsv/clms/clms_evt.c | 26 +- osaf/services/saf/clmsv/clms/clms_imm.c | 18 -- 4 files changed, 28 insertions(+), 19 deletions(-) The st

[devel] [PATCH 2 of 2] clm: setup mds and mbcsv role first during role change [#800]

2014-05-01 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_amf.c | 19 +++ osaf/services/saf/clmsv/clms/clms_evt.c | 16 ++-- 2 files changed, 21 insertions(+), 14 deletions(-) I think it is best to first setup the mds and mbcsv role first before doing any functional processing during role

[devel] [PATCH 1 of 1] log: allow zero sized log records for app streams [#857]

2014-04-18 Thread mathi . naickan
osaf/libs/agents/saf/lga/lga_api.c | 5 - 1 files changed, 0 insertions(+), 5 deletions(-) There is a check in LGA as below: if (logFileCreateAttributes->maxLogRecordSize == 0) { TRACE(maxLogRecordSize);

[devel] [PATCH 0 of 1] Review Request for log: allow zero sized log records for app streams [#857]

2014-04-18 Thread mathi . naickan
Summary: log: allow zero sized log records for app streams [#857] Review request for Trac Ticket(s): #857 Peer Reviewer(s): lennart.l...@ericsson.com Pull request to: <> Affected branch(es): 4.4.x, default Development branch: <> Impacted area Impact y/n

[devel] [PATCH 1 of 1] log: use %z length modifier for printing size_t [#852]

2014-04-15 Thread mathi . naickan
osaf/services/saf/logsv/lgs/lgs_stream.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) The function log_stream_write() currently uses %ld to print size_t. This leads the following warning: cc1: warnings being treated as errors lgs_stream.c: In function ‘log_stream_write’: lgs_stream.

[devel] [PATCH 0 of 1] Review Request for log: use %z length modifier for printing size_t [#852]

2014-04-15 Thread mathi . naickan
Summary: log: use %z length modifier for printing size_t [#852] Review request for Trac Ticket(s): #852 Peer Reviewer(s): lennart.l...@ericsson.com Pull request to: <> Affected branch(es): opensaf-4.3.x Development branch: <> Impacted area Impact y/n

[devel] [PATCH 1 of 1] log: saflogger tool to honour try again [#839]

2014-04-14 Thread mathi . naickan
osaf/tools/saflog/saflogger/saf_logger.c | 82 +-- 1 files changed, 66 insertions(+), 16 deletions(-) Currently the saflogger tool does not honours the SA_AIS_ERR_TRY_AGAIN for the saLogInitialize(), saLogStreamOpen_2(), saLogStreamClose(), saLogFin

[devel] [PATCH 0 of 1] Review Request for log: saflogger tool shall TRY_AGAIN for all log apis [#839]

2014-04-14 Thread mathi . naickan
Summary: saflogger tool shall TRY_AGAIN for all log apis: v2 [#839] Review request for Trac Ticket(s): #839 Peer Reviewer(s): Lennart Pull request to: <> Affected branch(es): opensaf-4.3.x, 4.4.x, default Development branch: <> Impacted area Impact y/n --

[devel] [PATCH 0 of 1] Review Request for log: saflogger tool shall TRY_AGAIN for all log apis [#839]

2014-04-14 Thread mathi . naickan
Summary: saflogger tool shall TRY_AGAIN for all log apis [#839] Review request for Trac Ticket(s): #839 Peer Reviewer(s): Lennart Pull request to: <> Affected branch(es): opensaf-4.3.x, 4.4.x, default Development branch: <> Impacted area Impact y/n --

[devel] [PATCH 1 of 1] log: saflogger tool shall TRY_AGAIN for all log apis [#839]

2014-04-14 Thread mathi . naickan
osaf/tools/saflog/saflogger/saf_logger.c | 82 +-- 1 files changed, 66 insertions(+), 16 deletions(-) Currently the saflogger tool does not honours the SA_AIS_ERR_TRY_AGAIN for the saLogInitialize(), saLogStreamOpen_2(), saLogStreamClose(), saLogFinalize() APIs. This

[devel] [PATCH 3 of 3] clm: clmna to be respawned by nid when node join request fails [#816]

2014-03-26 Thread mathi . naickan
osaf/services/saf/clmsv/nodeagent/main.c | 8 1 files changed, 8 insertions(+), 0 deletions(-) When a node join request for an unconfigured/misconfigured node or when a node join request with a duplicate node_name is attempted, then clmna should report those errors to NID such that NID

[devel] [PATCH 2 of 3] clm: change log message for unconfigured nodes, connectivity problems [#816]

2014-03-26 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_evt.c | 12 ++-- osaf/services/saf/clmsv/nodeagent/main.c | 7 +++ 2 files changed, 13 insertions(+), 6 deletions(-) When a node join request from an unconfigured/misconfigured node is attempted, then CLM prints the following log message: Mar 26

[devel] [PATCH 1 of 3] clm: add null check for unconfigured node join request [#816]

2014-03-26 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_evt.c | 48 ++-- 1 files changed, 27 insertions(+), 21 deletions(-) When a node tries to join with a node name that is not configured or just gets simply mis-configured, then CLM crashes causing due to lack of null check during the p

[devel] [PATCH 0 of 3] Review Request for clm: handle unconfigured and misconfigured node join requests [#816]

2014-03-26 Thread mathi . naickan
Summary: clm: modify log string and respawn clmna for failed node join requests [#816] Review request for Trac Ticket(s): #816 Peer Reviewer(s): HansF and/or RameshB Pull request to: <> Affected branch(es): opensaf-4.4.x, default Development branch: <> Impacted

[devel] [PATCH 1 of 1] clm: initialize address family length with default value [#800]

2014-02-28 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_imm.c | 3 ++- osaf/services/saf/clmsv/clms/clms_util.c | 9 + 2 files changed, 11 insertions(+), 1 deletions(-) diff --git a/osaf/services/saf/clmsv/clms/clms_imm.c b/osaf/services/saf/clmsv/clms/clms_imm.c --- a/osaf/services/saf/clmsv/clms/clms_im

[devel] [PATCH 0 of 1] Review Request for clm: initialize address family length with default value [#800]

2014-02-28 Thread mathi . naickan
Summary: clm: initialize nodeaddress family to default values [#800] Review request for Trac Ticket(s): #800 Peer Reviewer(s): ramesh.bet...@oracle.com or th...@btisystems.com Pull request to: <> Affected branch(es): 4.2.x, 4.3.x Development branch: <> Impacted are

[devel] [PATCH 5 of 5] msg: mqnd to use daemon_sigterm_install [#512]

2014-02-18 Thread mathi . naickan
osaf/libs/common/mqsv/include/mqnd.h| 2 ++ osaf/services/saf/mqsv/mqnd/mqnd_init.c | 31 +++ osaf/services/saf/mqsv/mqnd/mqnd_main.c | 1 - 3 files changed, 25 insertions(+), 9 deletions(-) All core services and cpsv now register for a common sigterm handler

[devel] [PATCH 1 of 1] rde: print controller role as string and refine log messages [#63]

2014-02-18 Thread mathi . naickan
osaf/services/infrastructure/rde/rde_main.c | 24 +--- 1 files changed, 17 insertions(+), 7 deletions(-) diff --git a/osaf/services/infrastructure/rde/rde_main.c b/osaf/services/infrastructure/rde/rde_main.c --- a/osaf/services/infrastructure/rde/rde_main.c +++ b/osaf/servi

[devel] [PATCH 0 of 1] Review Request for rde: print controller role as string and refine log messages [#63]

2014-02-18 Thread mathi . naickan
Summary: rde: print controller role as string and refine log messages [#63] Review request for Trac Ticket(s): #63 Peer Reviewer(s): anders.wid...@ericsson.com Pull request to: <> Affected branch(es): opensaf-4.2.x, 4.3.x, 4.x, default Development branch: <> Impact

[devel] [PATCH 3 of 5] lck: glnd to use daemon_sigterm_install [#512]

2014-02-18 Thread mathi . naickan
osaf/libs/common/glsv/include/glnd.h | 2 ++ osaf/services/saf/glsv/glnd/glnd_api.c | 15 +-- 2 files changed, 15 insertions(+), 2 deletions(-) All core services and cpsv now register for a common sigterm handler. This patch series takes a stab at the optional services diff --g

[devel] [PATCH 1 of 5] evt: use daemon_sigterm_install [#512]

2014-02-18 Thread mathi . naickan
osaf/libs/common/edsv/include/eds.h | 2 ++ osaf/services/saf/edsv/eds/eds_cb.c | 33 - osaf/services/saf/edsv/eds/eds_main.c | 1 - 3 files changed, 26 insertions(+), 10 deletions(-) All core services and cpsv now register for a common sigterm handler. T

[devel] [PATCH 2 of 5] lck: gld to use daemon_sigterm_install [#512]

2014-02-18 Thread mathi . naickan
osaf/libs/common/glsv/include/gld.h | 2 ++ osaf/services/saf/glsv/gld/gld_api.c | 30 ++ osaf/services/saf/glsv/gld/gld_main.c | 1 - 3 files changed, 24 insertions(+), 9 deletions(-) All core services and cpsv now register for a common sigterm handler. This

[devel] [PATCH 4 of 5] msg: mqd to use daemon_sigterm_install [#512]

2014-02-18 Thread mathi . naickan
osaf/libs/common/mqsv/include/mqd.h | 2 ++ osaf/services/saf/mqsv/mqd/mqd_api.c | 26 -- osaf/services/saf/mqsv/mqd/mqd_main.c | 1 - 3 files changed, 22 insertions(+), 7 deletions(-) All core services and cpsv now register for a common sigterm handler. This patc

[devel] [PATCH 0 of 5] Review Request for osaf: use common sigterm handler [#512]

2014-02-18 Thread mathi . naickan
Summary: use common sigterm handler [#512] Review request for Trac Ticket(s): #512 Peer Reviewer(s): anders.wid...@ericsson.com Pull request to: <> Affected branch(es): 4.4.x, default Development branch: <> Impacted area Impact y/n --

[devel] [PATCH 3 of 4] ntf: initialize saflog() early during clm init [#720]

2014-02-03 Thread mathi . naickan
osaf/services/saf/ntfsv/ntfs/Makefile.am | 4 +++- osaf/services/saf/ntfsv/ntfs/ntfs_main.c | 6 ++ 2 files changed, 9 insertions(+), 1 deletions(-) This is necessary to avoid blocking in saflog during role changes. diff --git a/osaf/services/saf/ntfsv/ntfs/Makefile.am b/osaf/services/sa

[devel] [PATCH 2 of 4] clm: initialize saflog() early during clm init [#720]

2014-02-03 Thread mathi . naickan
osaf/services/saf/clmsv/clms/clms_main.c | 6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) This is necessary to avoid blocking in saflog during role changes. diff --git a/osaf/services/saf/clmsv/clms/clms_main.c b/osaf/services/saf/clmsv/clms/clms_main.c --- a/osaf/services/saf/clm

[devel] [PATCH 0 of 4] Review Request for osaf: add safloginit routine and call early during init of clm, ntf - v2.0

2014-02-03 Thread mathi . naickan
Summary: osaf: add new safloginit routine and call early during init of clm, ntf - v2.0 [#720] Review request for Trac Ticket(s): #720 Peer Reviewer(s): HansF, Praveen, Lennart Pull request to: <> Affected branch(es): all branches Development branch: <> Impacted

[devel] [PATCH 4 of 4] clm and ntf: increase csisetcallback timeout to 40 seconds [#720]

2014-02-03 Thread mathi . naickan
osaf/services/saf/clmsv/config/clmsv_objects.xml | 4 ++-- osaf/services/saf/ntfsv/config/ntfsv_objects.xml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/osaf/services/saf/clmsv/config/clmsv_objects.xml b/osaf/services/saf/clmsv/config/clmsv_objects.xml --- a/osaf/serv

  1   2   >