Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-10-01 Thread Tran Thuan
icsson.com; ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70] Hi Thuan, I can't seem to reproduce this. Can you tell me the exact steps for how you are setting it up? Alex On 09/27/2018

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-09-28 Thread Jones, Alex
, Thuan From: Jones, Alex [8] Sent: Wednesday, September 26, 2018 12:10 AM To: Tran Thuan [9]; [10]nagen...@hasolutions.in; 'Gary Lee' [11]; [12]hans.nordeb...@ericsson.com; [13]ravisekhar.ko...@oracle.com Cc: [14]opensaf-devel@lists.sourceforge.net Subject: Re: [

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-09-27 Thread Tran Thuan
x' ; nagen...@hasolutions.in; 'Gary Lee' ; hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70] Hi Alex, I can fetch your code. Will try it and reply if any conce

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-09-26 Thread Tran Thuan
#x27;Gary Lee' ; hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70] Hi Thuan, I pushed the latest ticket-70 to my review repo. For these concerns you have try clea

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-09-25 Thread Jones, Alex
SC-1 opensaf_reboot: Rebooting local node; timeout=60 Best Regards, Thuan -Original Message- From: [8]nagen...@hasolutions.in [9] Sent: Friday, September 7, 2018 12:57 PM To: Alex Jones [10]; Gary Lee [11]; [12]hans.nordeb...@ericsson.com; [13]

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-09-23 Thread Tran Thuan
; hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70] Hi Tran, Here is a patch you can overlay to fix this crash. Alex On 09/21/2018 06:31 AM, Tran Thuan wrote:

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-09-21 Thread Jones, Alex
[6]ravisekhar.ko...@oracle.com Cc: [7]opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70] Hi Alex, Thanks for the patch. From my side Ack. I wish that I could have tested the following area (I assume you w

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-09-21 Thread Tran Thuan
: Alex Jones ; Gary Lee ; hans.nordeb...@ericsson.com; ravisekhar.ko...@oracle.com Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70] Hi Alex, Thanks for the patch. >From my side Ack. I wish that I could have tested the following area (I assu

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-09-06 Thread nagendra
Hi Alex, Thanks for the patch. >From my side Ack. I wish that I could have tested the following area (I assume >you would have covered it): - Headless enabled test cases - CSI Dep, SI Dep testing(in 2N red model) - Combinations of Admin operations on Container and contained (in all 5 red models

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-09-06 Thread Alex Jones
Hi Nagu, Here's a patch that fixes your issue in test #1. For the other code review issues, is it OK if I just add them when I push the final patch. Or do you want to review them now? Alex On 08/30/2018 01:44 AM, [1]nagen...@hasolutions.in wrote: _

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-08-29 Thread nagendra
Hi Alex, Thanks for your response. For Test #2, I had configured all SUs on the single node SC-1. So, 2 container SUs and 2 contained SUs are on the same node. In such cases, we can have the implementation as having only one SU of that node(higher rank SUs may be) to be the container for all t

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-08-29 Thread Alex Jones
The probation time is the default in the config: 4s. Alex On 08/28/2018 01:32 AM, Gary Lee wrote: __ NOTICE: This email was received from an EXTERNAL sender _

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-08-29 Thread Alex Jones
Hi Nagu, I have a fix for your issue test #1. I will send out a patch along with changes for code review #1 and #2. For issue test #2, I think this needs to be handled in the configuration. In this case because there is no explicit node set for the contained SUs, su.cc:m

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-08-28 Thread nagendra
Hi Alex, Code review: 1. Header for few functions are missing. 2. Clc.cc: Need to add '0' in place avnd_comp_clc_inst_try_again_hdler in other fsm states. Testing: 1. Uploaded AppConfig-container.xml and AppConfig-contained-2N.xml Performed: amf-adm unlock-in safSu=SU1,safSg=Container,safApp=Con

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-08-27 Thread Gary Lee
Hi Alex No, I just ran kill 10 times to escalate restart to failover. Do you have a really small probation time in your demo config? Gary On 28/8/18 4:09 am, Alex Jones wrote: G'day Gary,     I can't reproduce this. Do you have a script or something that reproduces it? Alex On 08/15/20

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-08-27 Thread Alex Jones
G'day Gary, I can't reproduce this. Do you have a script or something that reproduces it? Alex On 08/15/2018 11:52 PM, Gary Lee wrote: __ NOTICE: This email was received from an EXTERNAL sender _

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-08-15 Thread Gary Lee
Hi Alex Thanks, it looks much better. So I tried ‘killall amf_container_demo” 10 times really quickly: 2018-08-16 13:43:22.652 SC-1 osafamfnd[286]: NO 'safSu=SU1,safSg=Container,safApp=Container' restarts have reached configured limit of 10 2018-08-16 13:43:22.653 SC-1 osafamfnd[286]

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-08-15 Thread Alex Jones
G'day Gary, I see you were adding the XML file dynamically with "immcfg -f". I hadn't tried that. I hadn't tried killing the sample app, either. Here is a patch that should fix both issues. Apply it on top of the latest big one I sent. Alex On 08/13/2018 10:37 PM, G

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-08-13 Thread Gary Lee
Hi Alex I modified AppConfig-container.xml and changed saAmfSgtRedundancyModel from 4 (NwayAct) to 1 (2N). The xml still loads and I could unlock, resulting in: root@SC-1:/var/log# immlist safVersion=1,safSgType=Container Name   Type Value(s) ==

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-08-13 Thread Alex Jones
Hi Gary, I just resubmitted a new patch which breaks out the different components, and addresses the other comments here. But, #2 (rejecting all but NWay-active for container) should already be in there. Is there a specific test you ran that didn't work? Alex On 08/13/20

Re: [devel] [PATCH 1/1] amf: add support for container/contained [#70]

2018-08-12 Thread Gary Lee
Hi Alex Some initial comments: 0. Is it possible to split up the patch into amfd / amfnd / common / samples. Just makes it easier to reply inline. 1. Please compile the container demo by default, and make amf_container_script world executable. Eg. diff --git a/samples/amf/Makefile.am b/samp