It is not a bug in syslog(), as explained in the web page Hans Feldt
sent. syslog() is illegal between fork() and exec() in a multithreaded
program.
regards,
Anders Widell
2013-08-12 06:00, Nagendra Kumar skrev:
> Hi,
> I agree with Anders. We had reproduced last week only with
practice.
regards,
Anders Widell
2013-08-09 15:20, Lennart Lund skrev:
> Summary: logsv: Fix hanging main thread when file i/o don't return
> Review request for Trac Ticket(s): #9
> Peer Reviewer(s): Madhurika Koppula, (Anders Widell, Hans Feldt)
> Pull request to: NA
> Affect
One more comment:
* saf_logger.c needs to be updated to handle the error code
SA_AIS_ERR_TIMEOUT
regards,
Anders Widell
2013-08-16 12:16, Lennart Lund skrev:
> Hi,
>
> See my comments to Anders W below
>
> Thanks'
> Lennart
>
>> -Original Mes
Yes, I can look into that. We used to have on the wiki, but the wiki has
not yet been moved to SourceForge (though the old wiki should still be
accessible).
regards,
Anders Widell
2013-08-19 10:28, Hans Feldt skrev:
> The first one liner of the commit message should describe what the
>
undo the write.
regards,
Anders Widell
2013-08-19 10:07, Lennart Lund skrev:
> Summary: logsv: Fix hanging main thread when file i/o don't return
> Review request for Trac Ticket(s): #9
> Peer Reviewer(s): Madhurika Koppula, (Anders Widell, Hans Feldt)
> Pull request to: NA
>
the agent libraries are linked with
that library.
regards,
Anders Widell
--
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and
he "future" milestone. So please, when
possible, set the "milestone" field of the tickets you intend to
implement within the next few OpenSAF releases.
thanks,
Anders Widell
PS if you wish to see all open tickets for a service (including the
unplanned ones), you can still do so b
d int' [-Werror=format=]
LOG_NO("%s: wrong number of bytes to decode (%u vs %lu)",
^
cc1: all warnings being treated as errors
It seems the sizeof(AVSV_NDA_AVA_MSG) needs to be casted to (unsigned long).
regards,
Anders Widell
-
otice opensaf_reboot: Rebooting local node;
timeout=60
I configured it with:
./configure --enable-tipc CFLAGS="-O2 -DRUNASROOT" CXXFLAGS="-O2
-DRUNASROOT"
regards,
Anders Widell
2013-09-26 05:54, mahesh.va...@oracle.com skrev:
> Summary:opensaf:make MDS/TCP as the default open
I think it looks like you require IP addresses to be configured
correctly in /etc/opensaf/dtmd.conf even when I am running with TIPC. Is
this neccessary? It was not necessary before this patch...
regards,
Anders Widell
2013-10-03 05:53, A V Mahesh skrev:
> Hi Anders Widell ,
>
>
No you were right, I had misconfigured it. :-)
regards,
Anders Widell
2013-10-03 10:35, Anders Widell skrev:
> I think it looks like you require IP addresses to be configured
> correctly in /etc/opensaf/dtmd.conf even when I am running with TIPC. Is
> this neccessary? It was not necessa
n
Other y
Comments (indicate scope for each "y" above):
-
changeset aeb1847efef6204a3cbec12892d911643e83edcc
Author: Anders Widell
Date: Fri, 04 Oct 2013 17:18:43 +0200
uml: Support both TC
tools/cluster_sim_uml/archive/scripts/40opensaf.rc | 1 +
tools/cluster_sim_uml/build_uml| 5 +
2 files changed, 6 insertions(+), 0 deletions(-)
Add support for the TCP transport in the UML environment. Select TIPC
transport when OpenSAF was built with TIPC enabled.
di
otherwise the UML environment will be broken (or at least it won't work
out of the box).
regards,
Anders Widell
2013-09-26 05:54, mahesh.va...@oracle.com skrev:
> Summary:opensaf:make MDS/TCP as the default opensaf transport[#232]
> Review request for Trac Ticket(s): #232
> Peer
uxCON Europe, please see the link below:
http://events.linuxfoundation.org/events/linuxcon-europe
regards,
Anders Widell
--
October Webinars: Code for Performance
Free Intel webinars can help you accelerate applic
://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Static_and_Global_Variables#Static_and_Global_Variables
regards,
Anders Widell
2013-10-07 10:06, Mathivanan Naickan Palanivelu skrev:
> On a related topic, I had this patch written(untested) sometime back for the
> rest of the se
Isn't this info provided by CLM? Or could the MDS IP address be
different from the CLM IP address?
regards,
Anders Widell
2013-10-08 11:35, Mathivanan Naickan Palanivelu skrev:
> Well, this is not in the context of this ticket, but in general,
> I think MDS could support somet
osaf/libs/core/common/Makefile.am |2 +
osaf/libs/core/common/include/osaf_poll.h | 97 +++
osaf/libs/core/common/include/osaf_time.h | 371 ++
osaf/libs/core/common/osaf_poll.c | 130 ++
osaf/libs/core/common/osaf_time.c |
Comments (indicate scope for each "y" above):
-
changeset ec1fad7a66407a0f27893f83191af5c7b7c7c3e3
Author: Anders Widell
Date: Tue, 08 Oct 2013 10:56:42 +0200
base: Add osaf_poll.h and osaf_time.h APIs [#580]
Add new u
highlighted.
* Trailing whitespace at the end of lines is made visible
You can find the sample .emacs configuration here:
https://sourceforge.net/p/opensaf/wiki/configuration-emacs/
regards,
Anders Widell
--
October
destruction. However, such variables are allowed if they are constexpr:
they have no dynamic initialization or destruction.
regards,
Anders Widell
2013-10-03 14:54, Hans Feldt skrev:
> osaf/libs/core/common/daemon.c | 9 ++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
>
the first thing we do in main() ?
regards,
Anders Widell
2013-10-09 16:12, Anders Björnerstedt skrev:
> The imm uses static global (non-pointer) variables for a number of C++ STL
> objects.
> Maps, Sets, Vectors etc.
>
> I have never seen any problems with this.
>
> /And
then it ought to be safe.
regards,
Anders Widell
2013-10-09 19:49, Anders Björnerstedt skrev:
> Or perhaps not the same kind of crash.
> But I dont think you are saying that we should alter the imm implementation to
> allow exit in the signal handler?!
>
> Besides the main thread, t
because exit() will only destroy the global pointer
itself, not the object it is pointing to (unless it is a shared_ptr or
similar, of course).
regards,
Anders Widell
2013-10-10 10:50, Anders Björnerstedt skrev:
> And if only the main thread does exit()
>
> Using multiple threads
Yes, I think it would be safer to have it that way. :-)
regards,
Anders Widell
2013-10-10 11:09, Anders Björnerstedt skrev:
> The conclusion is that this should be fixed (coverting the global inline
> static data to
> be either not global or to be only global pointer data) in IMMN
Hi!
Thanks for the comments. Se my replies inline below.
regards,
Anders Widell
2013-10-30 10:00, Ramesh Betham skrev:
> Hi Anders,
>
> I am not sure on the motivation behind adding more utilities to
> core/leap area.
>
> Also to what extent all these utility functions a
ou wish, I guess I could insert checks for invalid input
parameters. But then this is not the only case to check - there are a
lot of ways to misuse the API.
regards,
Anders Widell
>
> Thanks,
> Ramesh.
>
> On 10/30/2013 3:22 PM, Anders Widell wrote:
>> Hi!
>>
>&g
osaf/libs/agents/saf/lga/lga_api.c | 2 +-
osaf/libs/agents/saf/lga/lga_util.c | 7 ++-
osaf/tools/saflog/saflogger/saf_logger.c | 1 -
tests/logsv/Makefile.am | 6 --
4 files changed, 7 insertions(+), 9 deletions(-)
The select() function cannot handle fil
osaf/libs/agents/saf/cpa/cpa_init.c | 8 +
osaf/libs/agents/saf/cpa/cpa_proc.c | 9 ++
osaf/services/saf/cpsv/cpnd/cpnd_init.c | 46 +++-
3 files changed, 32 insertions(+), 31 deletions(-)
The select() function cannot handle file descriptors large
osaf/libs/agents/saf/gla/gla_init.c| 9 ++
osaf/services/saf/glsv/glnd/glnd_api.c | 41 +++--
2 files changed, 26 insertions(+), 24 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To avoid
this limitation, we replace all
osaf/libs/agents/saf/amfa/ava_init.c | 8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To avoid
this limitation, we replace all usages of select() with poll().
diff --git a/osaf/libs/agents/saf/amfa/ava_init.c
osaf/services/infrastructure/nid/nodeinit.c | 42 ++--
1 files changed, 9 insertions(+), 33 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To avoid
this limitation, we replace all usages of select() with poll().
diff --git a/osaf/ser
osaf/libs/agents/saf/mqa/mqa_init.c | 13 +++--
1 files changed, 3 insertions(+), 10 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To avoid
this limitation, we replace all usages of select() with poll().
diff --git a/osaf/libs/agents/saf/mqa/mqa_in
osaf/services/infrastructure/dtms/dtm/dtm_main.c | 12 +++-
1 files changed, 3 insertions(+), 9 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To avoid
this limitation, we replace all usages of select() with poll().
diff --git a/osaf/services/infras
osaf/libs/agents/saf/eda/eda_mds.c | 10 +++---
osaf/libs/agents/saf/eda/eda_saf_api.c | 2 +-
2 files changed, 4 insertions(+), 8 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To avoid
this limitation, we replace all usages of select() with poll(
osaf/libs/core/include/ncs_osprm.h | 142 +-
osaf/libs/core/include/os_defs.h |1 -
osaf/libs/core/leap/os_defs.c | 203 +---
osaf/libs/core/leap/sysf_ipc.c |9 +-
osaf/libs/core/leap/sysf_tmr.c | 68 ++--
5
osaf/libs/core/mds/mds_c_sndrcv.c | 9 +---
osaf/libs/core/mds/mds_main.c | 7 +--
tests/mds/mdstipc_conf.c | 78 ++
3 files changed, 35 insertions(+), 59 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To
contrib/plmc/plmcd/plmcd.c | 18 ++
osaf/libs/agents/saf/plma/plma_mds.c | 7 +
osaf/services/saf/plmsv/plms/hpi_intf/plms_hrb.c | 28 +++
3 files changed, 19 insertions(+), 34 deletions(-)
The select() function cannot han
s have not yet been fixed. They will be fixed in
a patch that will be sent out later.
changeset 8bd7a81783f17268607be9ad703bc7978e1df7ff
Author: Anders Widell
Date: Thu, 31 Oct 2013 14:13:50 +0100
amf: Replace select() with osaf_poll() to avoid 1024 fd limit [#452]
The select(
osaf/libs/agents/infrastructure/rda/rda_papi.c | 36 +
1 files changed, 7 insertions(+), 29 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To avoid
this limitation, we replace all usages of select() with poll().
diff --git a/osaf/lib
osaf/libs/agents/saf/imma/imma_init.c | 7 ++-
osaf/tools/safimm/immfind/imm_find.c | 1 -
osaf/tools/safimm/immlist/imm_list.c | 1 -
3 files changed, 2 insertions(+), 7 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To avoid
this limitation, we rep
osaf/libs/agents/saf/ntfa/ntfa_api.c | 2 +-
osaf/libs/agents/saf/ntfa/ntfa_util.c | 8 +++-
osaf/tools/safntf/ntfread/ntfread.c | 1 -
osaf/tools/safntf/ntfsend/ntfsend.c | 1 -
osaf/tools/safntf/ntfsubscribe/ntfsubscribe.c | 1 -
tests/ntfsv/Makefile
osaf/libs/agents/saf/clma/clma_util.c | 7 ++-
tests/clmsv/Makefile.am | 3 ++-
2 files changed, 4 insertions(+), 6 deletions(-)
The select() function cannot handle file descriptors larger than 1023. To avoid
this limitation, we replace all usages of select() with poll().
di
ments are not in the list, check that you have set the
correct milestone and accepted them.
thanks,
Anders Widell
--
Android is increasing in popularity, but the open development platform that
developers love is also a
will be moved to the OpenSAF 4.5.FC milestone.
Anders Widell
191 IMM: SaNameT 256 byte size limit and RDN 64 byte size limit.
452 osaf: Allow us to use more than 1024 file descriptors
580 base: Add utilility functions for poll() and time handling
Anders Bjornerstedt
21 IMM: Allow
1
This happens if I don't specify the option --enable-imm-pbe when
configuring OpenSAF.
regards,
Anders Widell
--
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles,
f429e0de000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x7f429deda000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x7f429db19000)
/lib64/ld-linux-x86-64.so.2 (0x7f429e5bf000)
regards,
Anders Widell
2013-11-14 15:59, Hans Feldt skrev:
> Yeah I don't get
Ok, I will add error loggings and push this later today.
regards,
Anders Widell
2013-11-29 09:53, Mathivanan Naickan Palanivelu skrev:
> Ack.
> Good that you were able to work on this ticket, would be a good value add.
> One comment is that, we should log the fd and strerror(errno) in
. Please check your
tickets and make sure that the only defect tickets with the 4.4.FC
milestone are defects for new functionality that is not present on
earlier branches.
regards,
Anders Widell
--
Rapidly troubleshoot
Oops, forgot about that one. It is fixed now.
thanks,
Anders Widell
2013-12-02 07:43, Ramesh Betham skrev:
> Hi Anders,
>
> make rpm fails, please check. (osaf_poll.h, osaf_time.h should add in
> ../osaf/libs/core/common/includeMakefile.am)
>
> Thanks,
> Ramesh.
>
The POLLHUP seems to happen quite frequently (revents=17), so I will
filter the log messages in that case.
regards,
Anders Widell
2013-11-29 09:53, Mathivanan Naickan Palanivelu skrev:
> Ack.
> Good that you were able to work on this ticket, would be a good value add.
> One comment is
n
Other n
Comments (indicate scope for each "y" above):
-
changeset 3a4fb82924524285936c51762aeae223bf0d8f7e
Author: Anders Widell
Date: Thu, 05 Dec 2013 14:02:35 +0100
nid: Fix infinite loops when sy
osaf/services/infrastructure/nid/nodeinit.c | 9 +++--
1 files changed, 7 insertions(+), 2 deletions(-)
There were three loops in nodeinit.c that could potentially become infinite if a
system call returns -1. It is fine to try again when e.g. errno == EINTR, since
that is a temporary error
Hi!
Yes this is a bug fix so it will go into all branches. Thanks for
comments. Se my replies inline.
regards,
Anders Widell
2013-12-06 08:08, Ramesh Betham skrev:
> Hi Anders,
>
> Ack. Comments inline.
> I hope some of these changes will reflect in later branches of 4.2.x
>
,
Anders Widell
--
Sponsored by Intel(R) XDK
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.cl
I get the following build error in PLM:
plms_dbg_utils.c: In function ‘plms_cb_dump_routine’:
plms_dbg_utils.c:50:2: error: implicit declaration of function
‘m_GET_ASCII_DATE_TIME_STAMP’ [-Werror=implicit-function-declaration]
regards,
Anders Widell
2013-12-05 13:51, ramesh.bet...@oracle.com
was done (i.e. that we wish to dump coverage data on
termination, but that exit() cannot be used since it is not thread-safe).
2) I usually prefer to use _Exit() over _exit() since the former one is
declared as nothrow.
regards,
Anders Widell
2013-12-09 09:23, Hans Nordeback skrev:
> o
00-README.conf | 2 +-
Makefile.common | 4 ++--
README | 16
configure.ac | 18 ++
tools/cluster_sim_uml/README | 2 +-
5 files changed, 34 insertions(+), 8 deletions(-)
By default, build w
n
Comments (indicate scope for each "y" above):
-
changeset f627d356bf1737c254ac36b2d008c5b787093d21
Author: Anders Widell
Date: Mon, 09 Dec 2013 12:38:54 +0100
build: Add extra GCC hardening compilation flags [#650]
And it is only used at one place in PLM, so the macro can be removed and
code inserted at that place.
regards,
Anders Widell
2013-12-09 16:13, Hans Feldt skrev:
> If PLM is now the only user of this please change PLM instead.
> /Hans
>
> On 12/09/2013 08:31 AM, ramesh.bet...@orac
done that here):
#include
#include
static inline int m_KEY_CMP(const NCS_PATRICIA_TREE* t, const uint8_t*
k1, const uint8_t* k2)
{
return memcmp(k1, k2, t->params.key_size);
}
static inline int m_GET_BIT(const uint8_t* key, int bit)
{
return (bit < 0) ? 0 : ((int) ((*(key + (
dout and stderr are redirected to /dev/null in all OpenSAF
services, these should be removed. Or if they are relevant, the printf's
can be converted to TRACE() and the fprintf's to LOG_ER().
regards,
Anders Widell
--
Ack with comment. The ticket number is still not surrounded with square
brackets [#581] in the first line of the commit message.
regards,
Anders Widell
2013-12-10 10:37, Hans Nordeback skrev:
> Summary: base: use _Exit instead of exit in daemon_exit [#581]
> Review request for Trac Ti
Ack with the comments I sent out in earlier mails.
Good work, this code is in need of some clean-up and this is a step in
the right direction!
regards,
Anders Widell
2013-12-05 13:51, ramesh.bet...@oracle.com skrev:
> Summary: Clean up unused code in "base" [#537]
> Review
Ok, I will close both of them when this is fixed.
regards,
Anders Widell
2013-12-10 15:57, Hans Nordebäck skrev:
> a ticket for this already exists
> http://sourceforge.net/p/opensaf/tickets/320/ /BR HansN
>
> -Original Message-----
> From: Anders Widell [mailto:anders.wid.
Ok, I am fine with that!
regards,
Anders Widell
On 2013-12-11 06:31, Ramesh Betham wrote:
> Hi Anders,
>
> Let me submit the set of patches what I published in this cycle.
> Still there is a scope of stream lining the legacy BASE code, will
> take it up in the next iterat
java/ais_api_impl_native/Makefile.am | 2 ++
java/ais_api_impl_native/j_ais_clm_libHandle.c | 2 ++
java/ais_api_impl_native/j_ais_clm_manager.c | 4
java/ais_api_impl_native/j_ais_socketUtil.c| 3 ---
java/ais_api_impl_native/j_utils.c | 7 +++
java/ais_a
n
Other n
Comments (indicate scope for each "y" above):
-
changeset 5c7edc02bb32b47b6bddde619a440fc1324675d9
Author: Anders Widell
Date: Thu, 12 Dec 2013 16:34:13 +0100
java: Fix compiler warnings
e function.
regards,
Anders Widell
2013-12-13 13:47, Hans Feldt skrev:
> osaf/libs/core/common/logtrace.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> diff --git a/osaf/libs/core/common/logtrace.c
> b/osaf/libs/core/common/logtrace.c
> --- a/osaf/libs
It was an interesting page; I haven't read it before. Btw the name
CPPFLAGS could be confusing at first: "CPP" stands for C PreProcessor,
not "C Plus Plus". So it applies to both C and C++ code.
regards,
Anders Widell
2013-12-13 11:34, Mathivanan Naickan Palanivelu sk
java/ais_api_impl_native/Makefile.am |1 +
java/ais_api_impl_native/j_ais_amf_libHandle.c | 191 +-
java/ais_api_impl_native/j_ais_clm_libHandle.c | 192 +--
java/ais_api_impl_native/j_ais_libHandle.c | 206 +---
java
n
Comments (indicate scope for each "y" above):
-
changeset d98fa15454e76ac81e24a1b92b74b6e353584b68
Author: Anders Widell
Date: Tue, 17 Dec 2013 16:34:04 +0100
java: Replace select() with osaf_poll() to avoid 102
efore the freeze either.
Below is a list of still open enhancement tickets for 4.4.FC:
Anders Widell
452 osaf: Allow us to use more than 1024 file descriptors
A V Mahesh (AVM)
561 CKPT: add "CkptArrivalCallback" as part of the CKPT API
617 Internal mds/base function/api to read i
Will this work if we do /etc/init.d/opensafd stop followed by
/etc/init.d/opensafd start with no reboot in between?
regards,
Anders Widell
2013-12-19 13:50, Hans Feldt skrev:
> osaf/services/infrastructure/dtms/scripts/osaf-dtm.in | 4
> 1 files changed, 4 insertions(+), 0 del
ary function that is executed by
all services.
Also, the modifications to Makefile.common look a bit strange. It seems
to work, but I find it more natural to do it this way:
AM_CFLAGS = -Wall -fno-strict-aliasing -Werror -fPIC @OSAF_HARDEN_FLAGS@
-DINTERNAL_VERSION_ID='"@I
Ok, I can take a look at the re-based patches and push them.
regards,
Anders Widell
2013-12-19 17:04, Mathivanan Naickan Palanivelu skrev:
> Hi Anders,
>
> I have manually rebased the patches sent in
> http://list.opensaf.org/pipermail/devel/2013-January/028573.html
> It was al
be to run the "hg" command either as part of "make
dist", or by postprocessing the configure script in the bootstrap.sh
script. I.e. adding a "sed" command as the last thing in bootstrap.sh
regards,
Anders Widell
2013-12-19 16:39, Hans Nordeback skrev:
> M
I think something like this could do the trick:
In configure.ac:
INTERNAL_VERSION_ID=0:
AC_SUBST([INTERNAL_VERSION_ID])
In bootstrap.sh:
autoreconf -vi
sed -i "s/^INTERNAL_VERSION_ID=.*\$/INTERNAL_VERSION_ID=$(hg parent
--template "{rev}:{node|short}")/" config
Ack with minor comment: the please update the short description in the
commit message to the following:
uml: Handle log split file system setting when building uml env [#685]
regards,
Anders Widell
2013-12-20 11:02, Lennart Lund skrev:
> tools/cluster_sim_uml/build_uml |
Ack (not tested)
regards,
Anders Widell
2014-01-07 12:35, Hans Nordeback skrev:
> Makefile.common | 4 ++--
> bootstrap.sh | 4 +++-
> configure.ac | 3 +++
>
.
regards,
Anders Widell
2014-01-08 11:08, Anders Björnerstedt skrev:
> Does this also mean we are ending support for the 4.2 branch from now?
> Or is that only when 4.4.0 is released?
>
> /AndersBj
>
> -Original Message-----
> From: Anders Widell [mailto:anders.wid...@eric
that
maintainers agree. Otherwise, only bug-fixes shall be pushed to the
opensaf-4.4.x branch from now on.
regards,
Anders Widell
--
Rapidly troubleshoot problems before they affect your business. Most IT
organizations
these cases, SaNameT.length would get a value that is
0x or >= SA_MAX_NAME_LENGTH, respectively.
is_config_valid() is a validation function that seems to return 1 when
successful and 0 otherwise. So if the above case happens, I would guess
it is a good idea to return 0.
regards,
Anders Wid
n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset b030f158fa19817ac62b65cebf371a8b7167b2b6
Author: Anders Widell
Date: Fri, 17 Jan 2014 15:43:56 +0100
osaf/libs/core/leap/os_defs.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
OpenSAF would fail to start when an invalid thread scheduling policy has been
configured, e.g. using the following configuration options for one of the
OpenSAF services:
export OSAF_MDS_SCHED_PRI
osaf/libs/core/mds/mds_dt_tipc.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
Remove an unnecessary log message regarding the configured TIPC importance,
that was introduced in ticket [#589]. The information in the log message is
unnecessary since the same information can be found
n
Tests n
Other n
Comments (indicate scope for each "y" above):
-
changeset 7db32ad52774d8b371b43aa5aabccc6feafa13f2
Author: Anders Widell
Date: Thu, 30 Jan 2014 16:46:04 +0100
m
n
Tests n
Other y
Comments (indicate scope for each "y" above):
-
changeset 8631919bdd815be3e70e9fc389d84c5911cc2b54
Author: Anders Widell
Date: Fri, 31 Jan 2014 14:06:00 +0100
uml:
brary function osaf_sleep_forever()
to make it visible that it is intended to be infinite. Or, in this
particular case, maybe it shouldn't sleep forever. It could sleep for,
say, an hour, and if the process is still alive after that it can log a
message about this and then call opensaf_reboot().
on this?
thanks
/ Anders Widell
2014-01-29 19:00, mathi.naic...@oracle.com skrev:
> Summary: failover using OPENSAF_MANAGE_TIPC flag and failover after down of
> critical services [#721]
> Review request for Trac Ticket(s): #721
> Peer Reviewer(s): ramesh.bet...@oracle.com
Ok, now I see what you mean. In the case of failover without OS reboot,
the FM process is terminated and will not perform the waiting.
/ Anders Widell
2014-02-04 12:56, Mathivanan Naickan Palanivelu skrev:
> - anders.wid...@ericsson.com wrote:
>
>> I am not sure if I fully un
Well, except for the code in the agent library. That code must be
written in C.
regards,
Anders Widell
2014-02-04 15:59, Anders Widell skrev:
> Hi guys!
>
> Just to let you know: we are trying to move away from the patricia tree
> code and use C++ STL instead. So if you already have
Hi guys!
Just to let you know: we are trying to move away from the patricia tree
code and use C++ STL instead. So if you already have implemented this
with an STL map, there is no need to port it to use the patricia tree.
regards,
Anders Widell
2014-02-04 15:24, Domrachev, Mikhail skrev:
>
tools/devel/review/00-README | 77 ++---
tools/devel/review/commit.template | 51 ++--
tools/devel/review/hgeditor.sh | 32 +++
3 files changed, 91 insertions(+), 69 deletions(-)
Update the commit message template with
n
Other y
Comments (indicate scope for each "y" above):
-
changeset 27485a5e44ed4fbc542f24ecc11a6c97df9c5bc8
Author: Anders Widell
Date: Mon, 17 Feb 2014 17:40:30 +0100
osaf: Update the commit messag
Ack with comments.
1) It is probably a good idea to validate that role is within bounds
before accessing the array with strings role_string[role]. It could be
done e.g. in the following way:
LOG_NO("RDE role set to %s", role >= 0 && role < sizeof(role_string) /
sizeof(role_string[0]) ? role_st
replace with:
+ while (osaf_poll(&sel[0], NUM_FD, -1) > 0) {
/ Anders Widell
2014-02-19 02:36, mathi.naic...@oracle.com skrev:
> Summary: use common sigterm handler [#512]
> Review request for Trac Ticket(s): #512
> Peer Reviewer(s): anders.wid...@ericsson.com
> Pull
server, so there are several remaining things in it that can be improved.
regards,
Anders Widell
2014-02-26 14:30, Mathivanan Naickan Palanivelu skrev:
> Anders,
>
> It's a good stab to update the figures. Ack.
> (I thought we could perhaps highlight "posix" besides the
HG: seems to be the comment prefix used by mercurial, but I agree it
would look better with e.g. hash signs (#). I can change the script to
use hash signs instead of HG:.
Will add an example to the README file.
/ Anders Widell
2014-03-07 10:45, Mathivanan Naickan Palanivelu skrev:
> Hi And
osaf/libs/saf/include/Makefile.am| 1 +
osaf/libs/saf/include/saAis.h| 2 +
osaf/libs/saf/include/saAis_B_5_14.h | 39
3 files changed, 42 insertions(+), 0 deletions(-)
Add a definition of SaConstStringT as an OpenSAF extension to the AIS typ
501 - 600 of 993 matches
Mail list logo
