Re: [opensc-devel] Initial ECDSA modifications to OpenSC for use with PIV cards in OpenSC #295

2010-12-09 Thread Aleksey Samsonov
Hello, Douglas E. Engert wrote: Great for now. But in SVN pkcs15-sec.c:188,189: 187 switch (obj-type) { 188 /* FIXME -DEE GOSTR is misusing the sc_card_find_rsa_alg */ 189 case SC_PKCS15_TYPE_PRKEY_GOSTR3410: 190 case SC_PKCS15_TYPE_PRKEY_RSA: 191

Re: [opensc-devel] [opensc-commits] svn opensc changed[4930] add to r4904: fix calculating of signature size for CKK_GOSTR3410

2010-12-09 Thread Aleksey Samsonov
Hello, 2010/12/9 Martin Paljak mar...@paljak.pri.ee: Hello, On Dec 9, 2010, at 9:23 AM, webmas...@opensc-project.org wrote: Revision: 4930 Author:   s Date:     2010-12-09 07:23:10 + (Thu, 09 Dec 2010) Log Message: --- add to r4904: fix calculating of signature size for

Re: [opensc-devel] Initial ECDSA modifications to OpenSC for use with PIV cards in OpenSC #295

2010-12-08 Thread Aleksey Samsonov
Hello, 2010/11/30 Douglas E. Engert deeng...@anl.gov: On 11/29/2010 4:36 AM, Aleksey Samsonov wrote: After fix it, I have fail in my tests with GOSTR (PKCS#11 C_Sign). Unfortunately, I don't have logs now. One thing to look at: In pkcs15-sec.c in sc_pkcs15_compute_signature in the old code

Re: [opensc-devel] r4904 and OpenSSL-1.0.0b in Fedora 14

2010-12-03 Thread Aleksey Samsonov
Hello, One remark. We need use 'include openssl/opensslconf.h' for use OPENSSL_NO_EC. Сomplete example (or see src/pkcs11/openssl.c): #include openssl/opensslv.h /* for OPENSSL_VERSION_NUMBER */ #if OPENSSL_VERSION_NUMBER = 0x1000L #include openssl/conf.h #include openssl/opensslconf.h /*

Re: [opensc-devel] Initial ECDSA modifications to OpenSC for use with PIV cards in OpenSC #295

2010-11-29 Thread Aleksey Samsonov
Hello Douglas, 2010/11/23 Douglas E. Engert deeng...@anl.gov: I would especially like the GOSTR maintainers to look at this closely, as many of the flag tests and if statements where modified to support EC and hopefully make it easier to add algorithms in the future. There have compile error

Re: [opensc-devel] Personal Review Of The Upcoming 0.12.0 Release

2010-09-03 Thread Aleksey Samsonov
Hello Andre, Andre Zepezauer wrote: Hello Aleksey, I really hope that it isn't a huge disaster for your personal life, when support for Rutoken S will be dropped in the near future. The rational behind this decision may be the fact, that such a kind of device is technology from the past.

Re: [opensc-devel] Personal Review Of The Upcoming 0.12.0 Release

2010-09-02 Thread Aleksey Samsonov
Hello, Martin Paljak wrote: On Sep 1, 2010, at 9:41 AM, Aleksey Samsonov wrote: Rutoken S [1] doesn't support on-board RSA (as opposed to Rutoken ECP). Rutoken ECP [2] have on-board RSA (with RSA keys up to 2048 bits), GOST R 34.10-2001 (public-key cryptography), GOST 34.11-94 (hash

Re: [opensc-devel] Personal Review Of The Upcoming 0.12.0 Release

2010-09-01 Thread Aleksey Samsonov
Hello, Martin Paljak wrote: On Aug 30, 2010, at 2:52 PM, Emanuele Pucciarelli wrote: The handful of drivers with insecure operations I was talking about, I got with the following command: grep -n OPENSSL libopensc/card-*.c But looking closer to each drivers source, I must confess that there

Re: [opensc-devel] Personal Review Of The Upcoming 0.12.0 Release

2010-08-31 Thread Aleksey Samsonov
Hello, Martin Paljak wrote: 2. The announcement of the GOST public key algorithm seems to me very optimistic. Because the current implementation isn't functional at all [1][2]. Good catch. The GOST public key algorithm is working (the current implementation), but in [1] [2] by a lucky

Re: [opensc-devel] new versions

2010-06-06 Thread Aleksey Samsonov
Hello, Aleksey Samsonov wrote: martin, do you want to create new releases? Need to test 0.11 branch with the openssl engine fix. Could you wait a few days? I'm try to find more clean solution. We have problem under the stipulation that load gost engine before loading engine_pkcs11 (which

Re: [opensc-devel] new versions

2010-06-02 Thread Aleksey Samsonov
Hello, Martin Paljak wrote: * what happend to opensc 0.11.*? I thought the problem with gost / engine_pkcs11 is so big, it should be fixed in the 0.11 line to help normal users, and so distributions can backport that fix if they want. Apparently Jean-Michel has some specific bugfixes in

Re: [opensc-devel] opensc 0.11.13 and openssl 1.0 oddity

2010-05-13 Thread Aleksey Samsonov
Hello, Fix committed to trunk (revision 4347). Could you please test it? Thanks Aleksey Samsonov wrote: Hello, Martin Paljak wrote: Hello, On Apr 22, 2010, at 23:08 , Aleksey Samsonov wrote: What are you think about solution in attachment? (openssl.cnf isn't needed in this case

Re: [opensc-devel] opensc 0.11.13 and openssl 1.0 oddity

2010-04-27 Thread Aleksey Samsonov
Hello, Martin Paljak wrote: Hello, On Apr 22, 2010, at 23:08 , Aleksey Samsonov wrote: What are you think about solution in attachment? (openssl.cnf isn't needed in this case) Thanks Index: src/pkcs11/openssl.c +#ifndef OPENSSL_NO_ENGINE +ENGINE *e; + +#if !defined

Re: [opensc-devel] opensc 0.11.13 and openssl 1.0 oddity

2010-04-18 Thread Aleksey Samsonov
Hello, Call OPENSSL_config(NULL) was need for loading GOST engine. It was need for applications which use PKCS#11 (opensc-pkcs11.so) with GOST algorithms and which don't use openssl directly (not call OPENSSL_config(NULL)). Jan was right, he wrote more detailed: Jan Just Keijser wrote: the

Re: [opensc-devel] opensc 0.11.13 and openssl 1.0 oddity

2010-04-16 Thread Aleksey Samsonov
Hello, Andreas Jellinghaus wrote: Am Freitag 16 April 2010 08:51:31 schrieb Aleksey Samsonov: Hello, Jan Just Keijser wrote: in opensc-0.11.13/src/pkcs11/openssl.c there's section 106 void 107 sc_pkcs11_register_openssl_mechanisms(struct sc_pkcs11_card *card) 108 { 109

Re: [opensc-devel] New project coordinator: Martin Paljak

2010-04-11 Thread Aleksey Samsonov
Hello Andreas, Thank you for your work! Good luck Martin! Andreas Jellinghaus wrote: Dear all, for several years I have coordinated the OpenSC, OpenCT, Libp11, Pam_p11 and Engine_PKCS11 projects: Created new releases, fixed some bugs, helped many users with questions, applied patches from

Re: [opensc-devel] pkcs15-rtecp.c question

2010-02-17 Thread Aleksey Samsonov
Hello Viktor, Viktor TARASOV wrote: rv = sc_change_reference_data(card, pin_info-type, pin_info-reference, ... My humble question is: does there any mis-usage of the 'type' member of the 'pin_info' data? Afaik, 'type' in 'sc_pkcs15_pin_info' structure holds the PKCS#15

Re: [opensc-devel] opensc 0.11.13 - all fixes commited?

2010-02-15 Thread Aleksey Samsonov
Hi, Andreas Jellinghaus wrote: so is everything we want for 0.11.13 commited? Сhangeset r4027 and r4028. What do you think? ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org

Re: [opensc-devel] opensc 0.11.13 - all fixes commited?

2010-02-15 Thread Aleksey Samsonov
Martin Paljak wrote: On Feb 15, 2010, at 19:04 , Aleksey Samsonov wrote: Сhangeset r4027 and r4028. What do you think? Leaks are bugs. Yes. Andreas Jellinghaus wrote: they look like nice clean bug fixes, so they make good candidates for the 0.11.13 release. feel free to commit them

Re: [opensc-devel] new ubuntu packages

2010-02-11 Thread Aleksey Samsonov
Hello, Andreas Jellinghaus wrote: Thanks to Stephan Hermann new openct and opensc packages for ubuntu are available: https://launchpad.net/ubuntu/+source/openct/0.6.19-1ubuntu2 https://launchpad.net/ubuntu/+source/opensc/0.11.12-1ubuntu1 To my knowledge they contain all the changes and

Re: [opensc-devel] keycache broken between pkcs11 and pkcs15 layers

2010-01-18 Thread Aktiv Co. Aleksey Samsonov
Hello, Xiaoshuo Wu wrote: On Sun, 17 Jan 2010 20:36:53 +0800, Xiaoshuo Wu xiaos...@ftsafe.com wrote: I'd like to hear your plan for these changes so as to help me fix this. I recovered cache_pin() in rev 3783, renamed it add_pins_to_keycache() and had some adjustment. When login/change

Re: [opensc-devel] PKCS#11 and check parameters for NULL_PTR

2009-12-10 Thread Aktiv Co. Aleksey Samsonov
Hello, Committed at trunk revision 3891. ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org http://www.opensc-project.org/mailman/listinfo/opensc-devel

[opensc-devel] PKCS#11 and check parameters for NULL_PTR

2009-12-08 Thread Aktiv Co. Aleksey Samsonov
Hello, I propose a patch for PKCS#11 Fix: any of these calls C_CreateObject(hSession, NULL_PTR, 1, NULL_PTR); C_GetAttributeValue(hSession, hObject, NULL_PTR, 1); C_SetAttributeValue(hSession, hObject, NULL_PTR, 1); C_FindObjectsInit(hSession, NULL_PTR, 1); C_FindObjects(hSession, NULL_PTR, 0,

[opensc-devel] PKCS#11 and read-only session

2009-12-08 Thread Aktiv Co. Aleksey Samsonov
Hello, I propose a patch for PKCS#11 Fix: return CKR_SESSION_READ_ONLY from C_InitPIN, C_SetPIN, C_CreateObject, C_CopyObject, C_DestroyObject, C_SetAttributeValue, C_GenerateKey, C_GenerateKeyPair, C_UnwrapKey, C_DeriveKey if session is read-only. PKCS#11: C_InitPIN can only be called in

Re: [opensc-devel] PKCS#11 and check parameters for NULL_PTR

2009-12-08 Thread Aktiv Co. Aleksey Samsonov
Aktiv Co. Aleksey Samsonov: or 1. no for the present and to try further (that'll do CKR_TEMPLATE_INCOMPLETE, CKR_OK and etc) Incidentally: CK_MECHANISM gostMech = { CKM_GOSTR3410_KEY_PAIR_GEN, NULL, 0 }; ... C_GenerateKeyPair(hSession, gostMech, NULL_PTR, 0, NULL_PTR, 0, hPubKey, hPrvKey

Re: [opensc-devel] PKCS#11 and read-only session

2009-12-08 Thread Aktiv Co. Aleksey Samsonov
Martin Paljak: I don't think that obvious fixes for spec conformance need any vetting period. +1 anyway. Thanks. Committed at trunk revision 3886. ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org

Re: [opensc-devel] Unblocking PIN via PKCS#11?

2009-12-03 Thread Aktiv Co. Aleksey Samsonov
Pierre Ossman: I think we might have a language barrier here as I'm not quite following what you're trying to say. Sorry for inconvenience caused. The basic problem is that none of my PKCS#15 cards have an object for the PUK (and from what I can tell the PKCS#15 standard doesn't require

Re: [opensc-devel] Unblocking PIN via PKCS#11?

2009-12-03 Thread Aktiv Co. Aleksey Samsonov
Viktor TARASOV: - in CKU_SO_PIN context -- set PIN after SOPIN authentication; Sorry, it's not good idea -- there should be possibility to change SOPIN. Incidentally, this isn't work for current trunk. (change SOPIN by C_SetPin) (see slot_data_auth/slot_data_pin_info and

Re: [opensc-devel] Unblocking PIN via PKCS#11?

2009-12-02 Thread Aktiv Co. Aleksey Samsonov
Pierre Ossman: I've had another look at this and implemented a somewhat ugly hack to provide this functionality. Basically C_Login will return success for CKU_SO if it can't find an auth object and then rely on the PIN cache in C_InitPIN. Comment away! Please see:

Re: [opensc-devel] Patch to make pkcs11 pin cache working

2009-11-19 Thread Aleksey Samsonov
François Leblanc wrote: For now I propose this small patch to permit generate_key with pkcs11-tool. More universal (but not full and not good for future) patch is here: http://www.opensc-project.org/pipermail/opensc-devel/2009-November/012863.html ___

Re: [opensc-devel] pkcs11 trouble on 0.12.0-svn

2009-11-18 Thread Aktiv Co. Aleksey Samsonov
François Leblanc: Hi there, Hi, Does someone do commands like : pkcs11-tool -l -O It fails for me: error: PKCS11 function C_OpenSession failed: rv = CKR_TOKEN_NOT_PRESENT (0xe0) but if I do : pkcs11-tool -T Available slots: Slot 4 CEVGroup Software Reader 1 Please

Re: [opensc-devel] ID of cryptographic objects

2009-11-18 Thread Aleksey Samsonov
Hello, Viktor TARASOV wrote: Aleksey Samsonov wrote: Thanks, but some potencial memory leaks. See patch in attachment. You can apply this patch, if you think it should be. ok As for me, there is no potential leaks -- I trust entirely the sc_asn1_encode() . Agree

Re: [opensc-devel] ID of cryptographic objects

2009-11-17 Thread Aleksey Samsonov
Hello, Viktor TARASOV wrote: Aktiv Co. Aleksey Samsonov wrote: Viktor TARASOV: skipped It's commited ... Thanks, but some remarks: Potencial memory leaks (see /* */): Thanks for your code revision. Thanks, but some potencial memory leaks. See patch in attachment. Index: src/pkcs15init

[opensc-devel] Re-implement PIN cache and sc_pkcs15init_authenticate (sc_keycache_get_key)

2009-11-16 Thread Aktiv Co. Aleksey Samsonov
Hello, After changeset 3784 http://www.opensc-project.org/opensc/changeset/3784/branches Give special attention to: -static void cache_pin(void *, int, const sc_path_t *, const void *, size_t); and

Re: [opensc-devel] ID of cryptographic objects

2009-11-11 Thread Aktiv Co. Aleksey Samsonov
Viktor TARASOV: Aktiv Co. Aleksey Samsonov wrote: Viktor TARASOV: Hi, Hi Hi, Nevertheless, IMHO, it would be nice, for the cryptographic objects (and maybe for the others) to have the possibility of some unique ID calculated from the object itself, as it was discussed in thread: 'CKA_ID

Re: [opensc-devel] ID of cryptographic objects

2009-11-11 Thread Aktiv Co. Aleksey Samsonov
Viktor TARASOV: Aktiv Co. Aleksey Samsonov wrote: Viktor TARASOV: skipped It's commited ... Thanks, but some remarks: Potencial memory leaks (see /* */): Thanks for your code revision. I'll be more attentive. Considering the 'SC_ERROR_OUT_OF_MEMORY' error, IMHO, it's quiet dangerous

Re: [opensc-devel] ID of cryptographic objects

2009-11-11 Thread Aleksey Samsonov
Viktor TARASOV: Aktiv Co. Aleksey Samsonov wrote: Viktor TARASOV: Aktiv Co. Aleksey Samsonov wrote: Viktor TARASOV: skipped It's commited ... Thanks, good work. --- /trunk/src/libopensc/pkcs15-pubkey.c (revision 3818) +++ /trunk/src/libopensc/pkcs15-pubkey.c (revision 3820) @@ -70,5

Re: [opensc-devel] 'return' versus 'SC_FUNC_RETURN'

2009-11-04 Thread Aleksey Samsonov
Aleksey Samsonov wrote: Does it exists any rule for the assigning of the debug level for debug messages ? I think we have to follow common sence. Also you can find some information here http://www.opensc-project.org/pipermail/opensc-devel/2009-September/012466.html

Re: [opensc-devel] pkcs15 init, problem with the profile

2009-10-30 Thread Aktiv Co. Aleksey Samsonov
Hello, Aventra development: Does the other drivers work when initializing a card, and is the ACL set correctly? The ACL is set correctly for Rutoken. Example (Rutoken ECP): $ pkcs15-init -E -C --so-pin 87654321 --so-puk 21 1.txt 1.txt attached See: card.c:362:sc_create_file: called;

Re: [opensc-devel] OpenSC 0.11.11 -rc1 release candidate available

2009-10-23 Thread Aktiv Co. Aleksey Samsonov
Hello, Kalev Lember: On 10/23/2009 04:39 PM, Andreas Jellinghaus wrote: Please give it a final test. http://www.opensc-project.org/files/opensc/testing/opensc-0.11.11-rc1.tar.gz Doesn't seem to compile with openssl-1.0 beta3 (distributed with Fedora 12, for example): /bin/sh

Re: [opensc-devel] OpenSC 0.11.11 -rc1 release candidate available

2009-10-23 Thread Aktiv Co. Aleksey Samsonov
Aktiv Co. Aleksey Samsonov: Hello, Kalev Lember: On 10/23/2009 04:39 PM, Andreas Jellinghaus wrote: Please give it a final test. http://www.opensc-project.org/files/opensc/testing/opensc-0.11.11-rc1.tar.gz Doesn't seem to compile with openssl-1.0 beta3 (distributed with Fedora 12

Re: [opensc-devel] opensc 0.11.11-pre1 with openssl 0.9.7 fix

2009-10-21 Thread Aktiv Co. Aleksey Samsonov
Hello, Andreas Jellinghaus: here is a preview to 0.11.11, it contains a fix for compiling with openssl 0.9.7. please give it a try. I'm going to support GOST in tools, also I have some time to cleanup and fix warnings. Do we need a new branch? Thanks

Re: [opensc-devel] OpenSC 0.11.10-pre1 preview for testing

2009-10-09 Thread Aktiv Co. Aleksey Samsonov
Hi, Andreas Jellinghaus: Hi, I made a preview in case we forgot something important. if you find some time, please test and report back. thanks! http://www.opensc-project.org/files/opensc/testing/opensc-0.11.10-pre1.tar.gz My tests are working. Thanks

Re: [opensc-devel] changeset 3765 and sc_keycache_set_pin_name

2009-10-08 Thread Aktiv Co. Aleksey Samsonov
Hello, Aktiv Co. Aleksey Samsonov: I think, we need to rollback: Index: src/pkcs15init/keycache.c === --- src/pkcs15init/keycache.c (revision 3765) +++ src/pkcs15init/keycache.c (working copy) @@ -259,17 +259,11

Re: [opensc-devel] changeset 3765 and sc_keycache_set_pin_name

2009-10-08 Thread Aleksey Samsonov
Hello, Andreas Jellinghaus wrote: Am Mittwoch 07 Oktober 2009 11:34:36 schrieb Aktiv Co. Aleksey Samsonov: I think, we need to rollback: propably the best idea. the old code was working, I don't understand why the new code is necessary (ok, I don't understand the whole keycache stuff I

Re: [opensc-devel] changeset 3765 and sc_keycache_set_pin_name

2009-10-07 Thread Aktiv Co. Aleksey Samsonov
Hello, Thanks for the answer. I think that this code is become obsolete and it needs to review, however I haven't detailed information about it. Martin Paljak: Hello Aleksey and others, Those of you who have used pkcs15init API, can anyone explain the way keycache works? There is some extra

Re: [opensc-devel] changeset 3765 and sc_keycache_set_pin_name

2009-10-07 Thread Aktiv Co. Aleksey Samsonov
Hello, Andreas Jellinghaus: Am Dienstag 06 Oktober 2009 16:06:52 schrieb Aktiv Co. Aleksey Samsonov: Aktiv Co. Aleksey Samsonov: Hello, Rutoken initialization failed after http://www.opensc-project.org/opensc/changeset/3765#file8 $ pkcs15-init -l Rutoken ECP User PIN -a 02 --pin 12345678

Re: [opensc-devel] [opensc-commits] svn opensc changed [3757] add GOST R 34.10-2001 algorithm (only PKCS#11) by Aktiv Co.

2009-10-06 Thread Aktiv Co. Aleksey Samsonov
Alon Bar-Lev: The pkcs11.h hank looks right. On Tue, Oct 6, 2009 at 8:08 AM, Andreas Jellinghaus a...@dungeon.inka.de wrote: When updating pkcs11.h, please sync with scut [1] Maintainer is at [2]. no worries, I will take care of that. is the patch ok otherwise? then I will apply it.

[opensc-devel] changeset 3765 and sc_keycache_set_pin_name

2009-10-06 Thread Aktiv Co. Aleksey Samsonov
Hello, Rutoken initialization failed after http://www.opensc-project.org/opensc/changeset/3765#file8 only (trunk/src/pkcs15init/keycache.c) Example: $ pkcs15-init -E -C --so-pin 87654321 --so-puk OK! $ pkcs15-init -l Rutoken ECP User PIN -a 02 --pin 12345678 --puk -P --so-pin 87654321 -F

Re: [opensc-devel] [PATCH] Fix OpenSC PKCS#11 object grouping

2009-10-06 Thread Aktiv Co. Aleksey Samsonov
Hello, Pierre Ossman: On Mon, 5 Oct 2009 11:28:12 +0300 Martin Paljak mar...@paljak.pri.ee wrote: On 05.10.2009, at 11:01, Pierre Ossman wrote: New attempt, this time against r3756 (r18006 was our internal repo, for those curious :)), as an attachment and without a signature on the mail.

Re: [opensc-devel] changeset 3765 and sc_keycache_set_pin_name

2009-10-06 Thread Aktiv Co. Aleksey Samsonov
Aktiv Co. Aleksey Samsonov: Hello, Rutoken initialization failed after http://www.opensc-project.org/opensc/changeset/3765#file8 $ pkcs15-init -l Rutoken ECP User PIN -a 02 --pin 12345678 --puk -P --so-pin 87654321 -F Failed to store PIN: Requested object not found = new_entry - calloc

Re: [opensc-devel] new opensc 0.11.* release?

2009-10-06 Thread Aktiv Co. Aleksey Samsonov
Andreas Jellinghaus: Am Dienstag 06 Oktober 2009 10:17:08 schrieb Aktiv Co. Aleksey Samsonov: I want to make a few changes to cleanup. It takes me a few hours to do it. ok. no hurries, let me know when its done. a few days more or less before the next release doesn't matter

Re: [opensc-devel] add new public key algorithm (GOSTR3410)

2009-10-05 Thread Aleksey Samsonov
Hello, Patch applied in revision 3757. Aleksey Samsonov wrote: Hello! I propose a patch for add GOST R 34.10-2001 algorithm (only PKCS#11 for the present). PKCS#11 and GOST: ftp://ftp.rsasecurity.com/pub/pkcs/pkcs-11/v2-30/pkcs-11v2-30m1-d7.pdf This patch is first step. If it OK, I'll do

Re: [opensc-devel] Changeset 3752: sc_check_apdu and datalen (lc)

2009-10-04 Thread Aleksey Samsonov
Hello, Martin Paljak wrote: On 03.10.2009, at 15:19, Aleksey Samsonov wrote: Hello, Martin, could you explain please what for we need this change? http://www.opensc-project.org/opensc/changeset/3752/branches/martin/0.12/src/libopensc/apdu.c if SC_APDU_CASE_3_SHORT and apdu-datalen

[opensc-devel] Changeset 3752: sc_check_apdu and datalen (lc)

2009-10-03 Thread Aleksey Samsonov
Hello, Martin, could you explain please what for we need this change? http://www.opensc-project.org/opensc/changeset/3752/branches/martin/0.12/src/libopensc/apdu.c if SC_APDU_CASE_3_SHORT and apdu-datalen == 0 and apdu-lc == 0 then no error? Why? Thanks

Re: [opensc-devel] pkcs15 init, problem with the profile

2009-10-02 Thread Aktiv Co. Aleksey Samsonov
Hi, Example (This is a circumstance worthy of being noted) $ pkcs15-init -E -C ... ... No PIN objects ... Create DF (Example PKCS15-AppDF: (rutoken_ecp.profile) acl = *=NONE, DELETE=___CHV2___) ... Create PIN ... Create DF (Example PKCS15-AODF: (rutoken_ecp.profile) acl = *=NEVER, READ=NONE,

Re: [opensc-devel] new openct release?

2009-09-23 Thread Aktiv Co. Aleksey Samsonov
Hi, shall we create a new openct release? There are almost no changes, but I'm for release. since 0.6.17 trunk got bsd fixes and rutoken S support. anything else we should wait for before creating a new release? Current trunk are working in RutokenS and RutokenECP tests. Andreas

Re: [opensc-devel] add new public key algorithm (GOSTR3410)

2009-09-22 Thread Aktiv Co. Aleksey Samsonov
the correct value CKA_GOSTR3410PARAMS in next patch. Thanks Aktiv Co. Aleksey Samsonov: Hello! I propose a patch for add GOST R 34.10-2001 algorithm (only PKCS#11 for the present). PKCS#11 and GOST: ftp://ftp.rsasecurity.com/pub/pkcs/pkcs-11/v2-30/pkcs-11v2-30m1-d7.pdf This patch is first

[opensc-devel] westcos_select_file and iso7816_select_file

2009-09-21 Thread Aktiv Co. Aleksey Samsonov
Hello! I propose a patch for src/libopensc/card-westcos.c if it's working. src/libopensc/card-westcos.c:westcos_select_file: 309:case SC_PATH_TYPE_PATH: apdu.p1 = 9;// Why is it needed? (9 ?) 336:if (file_out != NULL) { apdu.resp = buf;

[opensc-devel] add new public key algorithm (GOSTR3410)

2009-09-21 Thread Aktiv Co. Aleksey Samsonov
Hello! I propose a patch for add GOST R 34.10-2001 algorithm (only PKCS#11 for the present). PKCS#11 and GOST: ftp://ftp.rsasecurity.com/pub/pkcs/pkcs-11/v2-30/pkcs-11v2-30m1-d7.pdf This patch is first step. If it OK, I'll do: - cleanup code - add support to tools (pkcs15-init pkcs15-tool

Re: [opensc-devel] SC_FUNC_RETURN and ctx-debug = level (/branches/martin/0.12)

2009-09-16 Thread Aktiv Co. Aleksey Samsonov
Hi! Martin Paljak: Privet, On 14.09.2009, at 14:57, Aktiv Co. Aleksey Samsonov wrote: Patch for /branches/martin/0.12 revision 3732 is in attachment: rollback check (ctx-debug = level) in SC_FUNC_RETURN macro. Martin, could you please add it? Thanks for double-checking, applied/rolled

[opensc-devel] Fix: serial::len is used uninitialized in card-rtecp.c

2009-09-15 Thread Aktiv Co. Aleksey Samsonov
Hello. BUG: serial-len is used uninitialized in rtecp_card_ctl:SC_CARDCTL_GET_SERIALNR (src/libopensc/card-rtecp.c) Could you please add attached patch? Thanks diff -u -r opensc-trunk-r3719/src/libopensc/card-rtecp.c opensc-trunk-r3719_new/src/libopensc/card-rtecp.c ---

Re: [opensc-devel] westcos broke compiling without openssl

2009-09-14 Thread Aktiv Co. Aleksey Samsonov
Andreas Jellinghaus: I haven't checked myself, but someone told me that opensc trunk isn't compiling without openssl. can anyone check? Version: 0.11.9-svn (trunk-r3720) User binaries: /usr/local/bin Configuration files: /usr/local/etc XSL stylesheets:

[opensc-devel] SC_FUNC_RETURN and ctx-debug = level (/branches/martin/0.12)

2009-09-14 Thread Aktiv Co. Aleksey Samsonov
Hello! Patch for /branches/martin/0.12 revision 3732 is in attachment: rollback check (ctx-debug = level) in SC_FUNC_RETURN macro. Martin, could you please add it? Thanks diff -u -r 0.12-r3732/src/libopensc/log.h 0.12-r3732_new/src/libopensc/log.h --- 0.12-r3732/src/libopensc/log.h

Re: [opensc-devel] unused parameters / -Wno-unused-parameter

2009-09-11 Thread Aktiv Co. Aleksey Samsonov
Andreas Jellinghaus: I don't want to put __attribute__((unused)) everywhere to quiet gcc. Should we use -Wno-unused-parameters in configure when --enable-strict is added? that should quiet a lot of unreasonable warnings. I believe that the only true way to quiet a lot of unreasonable warnings

Re: [opensc-devel] Patch adding support for westcos card.

2009-09-11 Thread Aktiv Co. Aleksey Samsonov
Martin Paljak: On 11.09.2009, at 14:30, Aktiv Co. Aleksey Samsonov wrote: Hello. I propose a patch for src/libopensc/card-westcos.c to fix some compiler warnings and coding style and remove code duplication, but unfortunately I can't test it. Patch for trunk revision 3718. Were

Re: [opensc-devel] Patch adding support for westcos card.

2009-09-08 Thread Aktiv Co. Aleksey Samsonov
François Leblanc: Hi there, Hello. If someone can have a look and apply this patch or tell me correction to be made, . --- src/libopensc/cards.h (revision 3716)^M +++ src/libopensc/cards.h (working copy)^M @@ -148,6 +148,8 @@^M SC_CARD_TYPE_ENTERSAFE_FTCOS_PK_01C,

[opensc-devel] Fix:OpenCT:etc/openct.fdi and etc/openct.udev.modalias.in for Rutoken S

2009-08-14 Thread Aktiv Co. Aleksey Samsonov
Hello, Patch for trunk revision 1163 is in attachment: Add support for Rutoken S in etc/openct.fdi and etc/openct.udev.modalias.in. Could you please add it? Thanks diff -u -r openct-trunk-r1163/etc/openct.fdi new/openct-trunk-r1163/etc/openct.fdi --- openct-trunk-r1163/etc/openct.fdi

[opensc-devel] Fix: call sc_free_apps for pkcs15init-erase

2009-07-17 Thread Aktiv Co. Aleksey Samsonov
Hello, Bug (Rutoken S, Rutoken ECP): $ pkcs15-init -E -C $ pkcs15-init -E -C $ opensc-explorer OpenSC [3F00] cat 2f00 : 61 1F 4F 0C A0 00 00 00 63 50 4B 43 53 2D 31 35 a.O. ...cPKCS-15 0010: 50 09 52 75 74 6F 6B 65 6E 20 53 51 04 3F 00 50 P.Rutoken SQ.?.P 0020: 15 61 1F 4F 0C A0

Re: [opensc-devel] OpenCT:ChipCard Interface Descriptor:dwFeatures and ISO/IEC 7816-12:2005

2009-07-16 Thread Aktiv Co. Aleksey Samsonov
Hello, Ludovic Rousseau: It looks like your patch is correct. All the ICCD devices I know have dwFeatures 0x = 0x840. Patch applied in revision 1158 Thanks! Could you please add patch for support Rutoken ECP tokens? (Patch for trunk revision 1158 is in attachment) Thanks. diff -u -r

[opensc-devel] OpenCT:ChipCard Interface Descriptor:dwFeatures and ISO/IEC 7816-12:2005

2009-07-15 Thread Aktiv Co. Aleksey Samsonov
Hello, ISO/IEC 7816-12:2005 7.2 The Class Specific Descriptor Table 8 - Class specific descriptor for a USB-ICC Offset: 40 Field: dwFeatures Size:4 Value: 00840h 0002 00840h 0004 00840h Description: The value of the lower word (=0840) indicates

Re: [opensc-devel] iso7816.c:set_security_env:OPERATION_DECIPHER

2009-06-26 Thread Aktiv Co. Aleksey Samsonov
Hello, Ludovic Rousseau: maybe we can obsolete some of those card specific implementations, if the only difference was this value? Maybe. I had a look at card-setcos.c and the two iso7816_set_security_env() functions are very similar. And they are even more similar with the patch applied. Any

Re: [opensc-devel] iso7816.c:set_security_env:OPERATION_DECIPHER

2009-06-26 Thread Aktiv Co. Aleksey Samsonov
Ludovic Rousseau: 2009/6/23 Andreas Jellinghaus a...@dungeon.inka.de: maybe we can obsolete some of those card specific implementations, if the only difference was this value? Maybe. I had a look at card-setcos.c and the two iso7816_set_security_env() functions are very similar. And they are

[opensc-devel] Add new driver for Rutoken ECP tokens

2009-06-24 Thread Aktiv Co. Aleksey Samsonov
Hi, I implemented support (currently only RSA) Rutoken ECP tokens (in Russian http://rutoken.ru/products/rutokends/) for OpenSC. Worked: ccid-1.3.10 + pcsc-lite-1.5.4 (pcsc-lite-1.5.2) + opensc Patch for trunk revision 3695 is in attachment. Initialize: $ pkcs15-init --erase-card

Re: [opensc-devel] iso7816.c:set_security_env:OPERATION_DECIPHER

2009-06-23 Thread Aktiv Co. Aleksey Samsonov
Hi, I propose the attached patch for iso7816.c. It looks like your patch is correct (according to ISO 7816-4 2003, page 54, 7.5.11 MANAGE SECURITY ENVIRONMENT command) Any objection from other list members? almost every card driver has it's own set_security_env implementation, so this change

[opensc-devel] iso7816.c:set_security_env:OPERATION_DECIPHER

2009-06-22 Thread Aktiv Co. Aleksey Samsonov
Hi, ISO 7816-4: 7.5.11 MANAGE SECURITY ENVIRONMENT command: Table 78 - P1 b8 b7 b6 b5 b4 b3 b2 b1 Meaning - - - 1 - - - - Secure messaging in command data field - - 1 - - - - - Secure messaging in response data field - 1 - - - - - - Computation, decipherment, internal authentication and key

[opensc-devel] BUG compiling with --disable-openssl

2009-05-06 Thread Aktiv Co. Aleksey Samsonov
Hi! cardos-tool.c: In function 'cardos_format': cardos-tool.c:621: error: label 'erase_state' used but not defined cardos-tool.c:779: #ifdef ENABLE_OPENSSL ... erase_state: Thanks ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org

Re: [opensc-devel] patch for Rutoken

2009-02-03 Thread Aktiv Co. Aleksey Samsonov
Alon Bar-Lev: On Monday 02 February 2009 12:35:20 Aktiv Co. Aleksey Samsonov wrote: also, do you know any resellers of the rutoken in eu? Unfortunately, Rutoken S is not exported from Russia. Why? The export of cryptography (GOST 28147-89) from Russia is a problem

Re: [opensc-devel] patch for Rutoken

2009-01-29 Thread Aktiv Co. Aleksey Samsonov
Alon Bar-Lev: Can you please update the openct trunk so that Rutoken use the new event interface? OK, the updated patch is attached. On 1/28/09, Alon Bar-Lev alon.bar...@gmail.com wrote: Thanks. Applied. Thanks! diff -u -r openct-0.6.15.trunk-r1127/src/ifd/ifd-rutoken.c

[opensc-devel] patch for Rutoken

2009-01-28 Thread Aktiv Co. Aleksey Samsonov
Hello. I propose the attached patch for Rutoken S codes. Changes: - use PKCS#15 (not builtin PKCS#15 emulator) - rutoken.profile (add privdata) - correct using ACL - correct erase procedure bin0MSZ0ZoczJ.bin Description: application/gzip ___

Re: [opensc-devel] new releases before xmas?

2008-12-19 Thread Aktiv Co. Aleksey Samsonov
not sure if they follow this mailing list. pkcs11-tool for Rutoken S is not yet supported (have problems). pkcs15-tool is supported (almost all options). Andreas Jellinghaus: Hi Pavel, can you check with the rutoken authors? not sure if they follow this mailing list. I neither have a

Re: [opensc-devel] opensc-explorer double free - fix

2008-05-04 Thread Aktiv Co. Aleksey Samsonov
Aktiv Co. Aleksey Samsonov: Examples: $ opensc-explorer OpenSC Explorer version 0.11.4-svn OpenSC [3F00] cat only working EFs may be read OpenSC [3F00] cat only working EFs may be read opensc-explorer: sc.c:492: sc_file_free: Assertion `sc_file_valid(file)' failed. Aborted Doesn't

[opensc-devel] SIGSEGV print_tags_recursive - fix

2008-04-28 Thread Aktiv Co. Aleksey Samsonov
Patch opensc-0.11.4.trunk-r3502-fix-segv_print_tags_asn1.diff (for trunk trunk revision 3502) is draft. Example 1 (SIGSEGV): OpenSC Explorer version 0.11.4-svn OpenSC [3F00] cd ff00 OpenSC [3F00/FF00] asn1 0001 Printing tags for buffer of length 512 [Switching to Thread -1211906368 (LWP

[opensc-devel] OpenCT SIGSEGV mmap - fix

2008-04-25 Thread Aktiv Co. Aleksey Samsonov
Program received signal SIGSEGV, Segmentation fault. [Switching to Thread -1210038592 (LWP 2240)] 0xb7e6e5b4 in memset () from /lib/tls/libc.so.6 (gdb) backtrace #0 0xb7e6e5b4 in memset () from /lib/tls/libc.so.6 #1 0xb7f4c28e in ct_status_alloc_slot (num=0xbffaed24) at status.c:144 #2

[opensc-devel] OpenSC svn build on Windows rutoken issues - fix

2008-04-24 Thread Aktiv Co. Aleksey Samsonov
Patch for trunk revision 3489 is in attachment. opensc-0.11.4.trunk-r3489-fix_msvc_build.diff.gz Description: application/gzip ___ opensc-devel mailing list opensc-devel@lists.opensc-project.org

Re: [opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-18 Thread Aktiv Co. Aleksey Samsonov
Alon Bar-Lev: Much better!!! Can you please rebase and send all your modifications as single patch? Patch for trunk revision 3477 is in attachment. opensc-0.11.4.trunk-r3477-0.11.4.trunk-r3477_rutoken-0.3.3.diff.gz Description: application/gzip ___

[opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-17 Thread Aktiv Co. Aleksey Samsonov
Alon Bar-Lev: Patch opensc-0.11.4.trunk-r3476_rutoken-0.3.2_2.diff (for opensc-0.11.4.trunk-r3476-0.11.4.trunk-r3476_rutoken-0.3.2.diff) is draft. This patch solves the problem with exported functions. (Instead of pkcs15-prkey-rutoken.c it'll be rutoken-prkey.h). If this solution is better than

[opensc-devel] OpenSC svn build on Windows rutoken issues

2008-04-16 Thread Aktiv Co. Aleksey Samsonov
On Fri, Apr 11, 2008 at 11:40 AM, Aktiv Co. Aleksey Samsonov wrote: We are going to release tested patch for the current version of your code in a couple of days. It fixes a number of bugs in Rutoken code and changes card-rutoken.c file to meet OpenSC coding standards. Patch for trunk