On 06/05/2012 09:38 AM, Ludovic Rousseau wrote:
Hello,
[...]
3- the idea is to start gerrit with a new clean copy of what is on github
The problem now is to find manpower (and expertise) to implement point 3.
I have taken a look into it. It seems simple at first sight. Basically
you just need
Hi!
We have the following symptoms:
- some modifications come as a set of patches. Gerrit lets you review a
patch a time.
- sometimes it is not even clear what are really the changes
- sometimes approved patches fail to apply
It would be nice if
- all patches in gerrit would be shown as relative
Would https://www.opensc-project.org/codereview/#/c/263/ also fall to
the Commits that obviously should be bundled with some other change
category?
Half of the changes needed is at
https://www.opensc-project.org/codereview/#/c/262/1, and the two or
three lines being the main point has been changed
I have a little concern about the review procedure.
If I go to the point in the code review comment, it will be short and
not too encouraging.
However the guys submitting the patches do the Right Thing, they are
important ones, and some encouragement would be in place.
Should I also include some
On 03/27/2012 03:19 AM, Peter Stuge wrote:
Graeme did some rework of the patch, but generally did not seem to
agree with the review. The new solution included the addition of new
API calls, however without any documentation. As anyone who has
looked at the code and doxygen output, libusb is
On 03/25/2012 01:14 PM, Peter Stuge wrote:
Jean-Michel Pouré - GOOZE wrote:
iterative modifications and evolutions. This only happens if the
first version of a patch is committed fast and spreads using the
Internet.
WTF?
This goes diametrically against the goal of software quality.
Please
On 03/24/2012 09:45 AM, Ludovic Rousseau wrote:
Most of your remarks were already in
https://www.opensc-project.org/opensc/wiki/DevelopmentPolicy#Movingmasterforward
I added what was missing. Thanks
Thank you, I added the link to the CodeReview page.
Could someone tell me what happened with this change in gerrit?
I see the messages but do not understand.
On 03/24/2012 07:01 PM, Alon Bar-Lev wrote:
On Sat, Mar 24, 2012 at 1:19 PM, Ludovic Rousseau
ludovic.rouss...@gmail.com wrote:
Le 24 mars 2012 12:05, Magosányi, Árpád m4g...@gmail.com
Simple End User Joe here,
A suggestion for all concerned:
Please try to forget personal differences, and solve the problem ahead.
You are all very bright, you do awesome work, we all endlessly admire
you and thank you for all you have achieved so far. But.
For me it seems that there IS a problem
Hi,
On 03/23/2012 05:48 PM, Martin Paljak wrote:
The trick is having a system that works and also helps to achieve the
target of having more people *actually* looking at code and some
testing (like automatic building) done before even considering ack-ing
something. But lagging on processing
On 03/23/2012 07:10 PM, Peter Stuge wrote:
Magosányi, Árpád wrote:
6 months worth of patches which cannot be reviewed
This is simply not true. *Anyone* can register on Gerrit and review,
and *all* review is a helpful contribution!
The problem is not that the code can not be reviewed
On 03/23/2012 09:16 PM, Douglas E. Engert wrote:
Another issues with this project is many of the modifications can only be
tested
by a subset of developers (maybe only one) who have the cards that can use
the modification.
I am more optimistic than that. If it is made clear that the patch
I have registered to gerrit, because saying stuff is one thing, doing it
is another. I guess I am supposed to verify and/or review. Which is
what, and how?
I have choosen Change I1e6f787d to experiment with, which is a nice
oneliner. Some guy have changed an email address in a comment to his own.
On 03/23/2012 11:10 PM, NdK wrote:
I'd do reviews, but the last time I tried to really understand OpenSC's
flow, all I got was an headache (a big one...) :(
So it's not a will issue, it's more an understandig issue. At least for
me. And I'd really like to be able to help, but it seems only a
Looking at https://www.opensc-project.org/codereview/#/c/150/ , which is
a patch which is overwritten by a later patch in gerrit, I started to
wonder again about quality standards. And this:
http://lwn.net/Articles/328438/
And there should be others. This is what I have gathered so far:
-
15 matches
Mail list logo
