Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-16 Thread Ludovic Rousseau
Le 16 mars 2012 21:58, Ludovic Rousseau a écrit : > Le 13 mars 2012 18:15, Peter Stuge a écrit : >> Hi, >> >> Ludovic Rousseau wrote: >>> I don't know if gerrit is broken or if I do not know how to use it :-) >> >> I would say that gerrit has some problem. >> >> >>> Example with https://www.opens

Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-16 Thread Ludovic Rousseau
Le 13 mars 2012 18:15, Peter Stuge a écrit : > Hi, > > Ludovic Rousseau wrote: >> I don't know if gerrit is broken or if I do not know how to use it :-) > > I would say that gerrit has some problem. > > >> Example with https://www.opensc-project.org/codereview/#change,6 >> The status is "Submitted

Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-14 Thread Peter Stuge
Ludovic Rousseau wrote: > Change 2 now merged. Ok! > I also tried with change 3 > https://www.opensc-project.org/codereview/#change,3 but I get the > error: > "Gerrit Code Review 8:45 PM > > Change cannot be merged due to unsatisfiable dependencies. > > The following dependency error

Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-14 Thread Ludovic Rousseau
Le 14 mars 2012 09:59, Viktor Tarasov a écrit : > Commit 51630a844e8e95e7108cb1966c5f3e21b93a463b is the last common commit > for OpenSC/OpenSC.git(staging) and gerrit's repo. > (By the way, this commit where not submitted to OpenSC.git by gerrit -- > there is no Change-Id in comments) > > Two las

Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-14 Thread Jean-Michel Pouré - GOOZE
Le mercredi 14 mars 2012 à 10:36 -0500, Douglas E. Engert a écrit : > Rather the stating from zero, or taking a very large branch with many > little patches, > would it be better to have the authors of these patches combine them > into one or > a hand full of larger patches? For example my ECDH wa

Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-14 Thread Douglas E. Engert
Good to see Ludovic and Peter making progress, Thanks!" Rather the stating from zero, or taking a very large branch with many little patches, would it be better to have the authors of these patches combine them into one or a hand full of larger patches? For example my ECDH was 4 separate patches

Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-14 Thread Viktor Tarasov
On Tue, Mar 13, 2012 at 6:59 PM, Peter Stuge wrote: > Peter Stuge wrote: > > I made an attempt to kick change 1 loose. > > Ok, so that worked. It would work fine to repeat this for each > change, even if it is a bit labour intensive at least now, to clear > the backlog. I've done it also for chan

Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-13 Thread Ludovic Rousseau
Le 13 mars 2012 18:59, Peter Stuge a écrit : > Peter Stuge wrote: >> I made an attempt to kick change 1 loose. > > Ok, so that worked. It would work fine to repeat this for each > change, even if it is a bit labour intensive at least now, to clear > the backlog. I've done it also for change 2 now.

Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-13 Thread Ludovic Rousseau
Le 13 mars 2012 19:04, Peter Stuge a écrit : > Ludovic Rousseau wrote: >> I added my SSH public key on my gerrit account but the access is >> still denied. > > So the username between local host and gerrit doesn't match. Check > https://www.opensc-project.org/codereview/#settings My username was

Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-13 Thread Peter Stuge
Peter Stuge wrote: > The current config has strong arguments, even if it brings slightly > more inconvenience. I actually favor not changing the config, even if > we will have to rebase each and every change. Thinking again about this, there's another possible problematic situation which I don't l

Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-13 Thread Peter Stuge
Ludovic Rousseau wrote: > > I made an attempt to kick change 1 loose. > > Done. > The status is now "Merged" and the change is available in git at > https://www.opensc-project.org/codereview/p/OpenSC but not yet on > git://github.com/OpenSC/OpenSC.git I guess github is synced only periodically.

Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-13 Thread Peter Stuge
Peter Stuge wrote: > I made an attempt to kick change 1 loose. Ok, so that worked. It would work fine to repeat this for each change, even if it is a bit labour intensive at least now, to clear the backlog. I've done it also for change 2 now. As you may recall, approving and submitting the change

Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-13 Thread Ludovic Rousseau
Le 13 mars 2012 18:15, Peter Stuge a écrit : > Hi, > > Ludovic Rousseau wrote: >> I don't know if gerrit is broken or if I do not know how to use it :-) > > I would say that gerrit has some problem. > > >> Example with https://www.opensc-project.org/codereview/#change,6 >> The status is "Submitted

Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-13 Thread Peter Stuge
Hi, Ludovic Rousseau wrote: > I don't know if gerrit is broken or if I do not know how to use it :-) I would say that gerrit has some problem. > Example with https://www.opensc-project.org/codereview/#change,6 > The status is "Submitted, Merge Pending". And has not changed since > Feb 19 (one m

Re: [opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-13 Thread Douglas E. Engert
On 3/13/2012 5:17 AM, Ludovic Rousseau wrote: > Hello Martin, or other gerrit expert, > > I don't know if gerrit is broken or if I do not know how to use it :-) > > Example with https://www.opensc-project.org/codereview/#change,6 > The status is "Submitted, Merge Pending". And has not changed sin

[opensc-devel] gerrit and merge process: "Submitted, Merge Pending" state

2012-03-13 Thread Ludovic Rousseau
Hello Martin, or other gerrit expert, I don't know if gerrit is broken or if I do not know how to use it :-) Example with https://www.opensc-project.org/codereview/#change,6 The status is "Submitted, Merge Pending". And has not changed since Feb 19 (one month ago). What is the next step? So I ha