Re: [Openvpn-devel] [PATCH] plugin: load plugin relative to plugindir

2012-06-26 Thread Alon Bar-Lev
On Tue, Jun 26, 2012 at 8:05 PM, Alon Bar-Lev wrote: > Currently openvpn requires/endorses specifying full path in plugin > parameter. As build system already aware of plugin location, it is > possible to load plugin relative to this directory, so full path is not > required nor more secured. > >

[Openvpn-devel] [PATCH] plugin: load plugin relative to plugindir

2012-06-26 Thread Alon Bar-Lev
Currently openvpn requires/endorses specifying full path in plugin parameter. As build system already aware of plugin location, it is possible to load plugin relative to this directory, so full path is not required nor more secured. Windows is a little more complex as user may change installation

Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows

2012-06-26 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/06/12 16:11, Alon Bar-Lev wrote: > On Tue, Jun 26, 2012 at 5:06 PM, Gert Doering > wrote: >> Hi, >> >> On Tue, Jun 26, 2012 at 04:56:54PM +0300, Alon Bar-Lev wrote: >>> You are more than welcome to maintain the build system and do >>> whatever

Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows

2012-06-26 Thread Alon Bar-Lev
On Tue, Jun 26, 2012 at 5:06 PM, Gert Doering wrote: > Hi, > > On Tue, Jun 26, 2012 at 04:56:54PM +0300, Alon Bar-Lev wrote: >> You are more than welcome to maintain the build system and do whatever you >> like. > > I'm not exactly sure what I did wrong this time - I particularily did > *not* wan

Re: [Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic

2012-06-26 Thread Gert Doering
Hi, On Tue, Jun 26, 2012 at 05:03:26PM +0300, Alon Bar-Lev wrote: > pam cannot be compiled on OpenBSD and Windows. > down-root cannot be compiled on Windows. > > Signed-off-by: Alon Bar-Lev > --- > configure.ac | 21 - > 1 files changed, 16 insertions(+), 5 deletions(-) >

Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows

2012-06-26 Thread Gert Doering
Hi, On Tue, Jun 26, 2012 at 04:56:54PM +0300, Alon Bar-Lev wrote: > You are more than welcome to maintain the build system and do whatever you > like. I'm not exactly sure what I did wrong this time - I particularily did *not* want to start a fight. You offered to rewrite the build system, so

Re: [Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic

2012-06-26 Thread Alon Bar-Lev
This removes the Linux from the help string. On Tue, Jun 26, 2012 at 5:03 PM, Alon Bar-Lev wrote: > pam cannot be compiled on OpenBSD and Windows. > down-root cannot be compiled on Windows. > > Signed-off-by: Alon Bar-Lev > --- >  configure.ac |   21 - >  1 files changed, 16

[Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic

2012-06-26 Thread Alon Bar-Lev
pam cannot be compiled on OpenBSD and Windows. down-root cannot be compiled on Windows. Signed-off-by: Alon Bar-Lev --- configure.ac | 21 - 1 files changed, 16 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index db19d4a..d3d974d 100644 --- a/confi

Re: [Openvpn-devel] [PATCH] Added notes about upgrading from 2.3-alpha1 and earlier to INSTALL-win32.txt

2012-06-26 Thread Gert Doering
Hi, On Tue, Jun 26, 2012 at 12:02:15PM +0300, sam...@openvpn.net wrote: > From: Samuli Seppänen > > Signed-off-by: Samuli Seppänen > --- > INSTALL-win32.txt | 24 > 1 files changed, 24 insertions(+), 0 deletions(-) Sounds good to me. ACK. gert -- USENET is *not*

Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows

2012-06-26 Thread Alon Bar-Lev
On Tue, Jun 26, 2012 at 4:50 PM, Gert Doering wrote: > Hi, > > On Tue, Jun 26, 2012 at 04:41:49PM +0300, Alon Bar-Lev wrote: >> This is exactly the reason why *ALL* plugins should be disabled by default. >> We are left with only Linux enabled... and distro maintainer can take >> care of that anywa

Re: [Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic

2012-06-26 Thread Alon Bar-Lev
If anyone here is opened minded - still. This shows that default should be "no" for all plugins. Distro maintainer should decide what to switch on. Anyway, this is my recommendation. On Tue, Jun 26, 2012 at 4:55 PM, Alon Bar-Lev wrote: > pam cannot be compiled on OpenBSD and Windows. > down-root

[Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic

2012-06-26 Thread Alon Bar-Lev
pam cannot be compiled on OpenBSD and Windows. down-root cannot be compiled on Windows. Signed-off-by: Alon Bar-Lev --- configure.ac | 21 - 1 files changed, 16 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index db19d4a..b1140f8 100644 --- a/confi

Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows

2012-06-26 Thread Gert Doering
Hi, On Tue, Jun 26, 2012 at 04:41:49PM +0300, Alon Bar-Lev wrote: > This is exactly the reason why *ALL* plugins should be disabled by default. > We are left with only Linux enabled... and distro maintainer can take > care of that anyway. > But again... my opinion is not matter, right... sending a

Re: [Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic

2012-06-26 Thread Gert Doering
Hi, On Tue, Jun 26, 2012 at 04:45:55PM +0300, Alon Bar-Lev wrote: > pam cannot be compiled on *BSD and Windows. *Open*BSD. Not *BSD. gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germ

[Openvpn-devel] [PATCH] build: plugins: set defaults using a complex logic

2012-06-26 Thread Alon Bar-Lev
pam cannot be compiled on *BSD and Windows. down-root cannot be compiled on Windows. Signed-off-by: Alon Bar-Lev --- configure.ac | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index db19d4a..9fb24ad 100644 --- a/configure

Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows

2012-06-26 Thread Alon Bar-Lev
This is exactly the reason why *ALL* plugins should be disabled by default. We are left with only Linux enabled... and distro maintainer can take care of that anyway. But again... my opinion is not matter, right... sending a new patch. On Tue, Jun 26, 2012 at 4:35 PM, Gert Doering wrote: > Hi, >

Re: [Openvpn-devel] [PATCH] build: plugins: set default to no in Windows

2012-06-26 Thread Gert Doering
Hi, On Tue, Jun 26, 2012 at 04:02:06PM +0300, Alon Bar-Lev wrote: > Both plugins cannot be compiled on Windows anyway. Can you auto-disable plugin-auth-pam for OpenBSD as well, please? We ran into this on the OpenBSD buildslave today - OpenBSD has no PAM whatsoever, so it would be nice to not

[Openvpn-devel] Configure options for the Windows builds

2012-06-26 Thread Samuli Seppänen
Hi all, Do these configure options look ok for the 2.3-alpha2 Windows builds? enable_crypto=yes enable_debug=no enable_def_auth=yes enable_dlopen=unknown enable_dlopen_self=unknown enable_dlopen_self_static=unknown enable_eurephia=yes enable_fast_install=needless enable_fragment=yes enable_http_p

[Openvpn-devel] [PATCH] build: plugins: set default to no in Windows

2012-06-26 Thread Alon Bar-Lev
Both plugins cannot be compiled on Windows anyway. Signed-off-by: Alon Bar-Lev --- configure.ac | 20 +++- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index db19d4a..7235a87 100644 --- a/configure.ac +++ b/configure.ac @@ -195,16

[Openvpn-devel] Tap-windows release and version numbering

2012-06-26 Thread Samuli Seppänen
Hi all, I'm preparing a (signed) release of tap-windows[1] so that we can bundle it with OpenVPN 2.3-alpha2, instead of using some arbitrary tap-windows package built from Git sources. Anyways, I was wondering if we should bump the version number in tap-windows/version.m4 [2]? Would that force Wi

Re: [Openvpn-devel] [PATCH] build: msvc: chdir with change drive to script location

2012-06-26 Thread Alon Bar-Lev
Please apply. https://github.com/alonbl/openvpn/commit/692c35a3cce6226dd36bbc6b9138a353d1d14634 On Sat, Apr 28, 2012 at 9:51 PM, Alon Bar-Lev wrote: > Signed-off-by: Alon Bar-Lev > --- >  msvc-build.bat |    1 + >  msvc-dev.bat   |    2 +- >  msvc-env.bat   |    2 -- >  3 files changed, 2 insert

Re: [Openvpn-devel] [PATCH] cleanup: windows: convert argv (UCS-2 to UTF-8) at earliest

2012-06-26 Thread Alon Bar-Lev
Please apply. https://github.com/alonbl/openvpn/compare/master...unicode On Thu, May 3, 2012 at 8:47 PM, Alon Bar-Lev wrote: > On Thu, May 3, 2012 at 1:53 PM, Samuli Seppänen wrote: >> >>> On Thu, May 3, 2012 at 10:26 AM, David Sommerseth >>> wrote: -BEGIN PGP SIGNED MESSAGE-

Re: [Openvpn-devel] [PATCH] build: integrate plugins build into core build

2012-06-26 Thread David Sommerseth
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 15/05/12 00:42, Alon Bar-Lev wrote: > As disucssed[1], keep plugins in repository. > > 1, Proper automake/libtool build. > > 2. Move example plugins to samples/sample-plugins. > > 3. Plugins are installed at LIBDIR/openvpn/plugins. > > [1] http:

[Openvpn-devel] [PATCH v2] Added notes about upgrading from 2.3-alpha1 and earlier to INSTALL-win32.txt

2012-06-26 Thread samuli
From: Samuli Seppänen Signed-off-by: Samuli Seppänen --- INSTALL-win32.txt | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/INSTALL-win32.txt b/INSTALL-win32.txt index 5a0f3a9..571d618 100644 --- a/INSTALL-win32.txt +++ b/INSTALL-win32.txt @@ -1,

[Openvpn-devel] [PATCH] Added notes about upgrading from 2.3-alpha1 and earlier to INSTALL-win32.txt

2012-06-26 Thread samuli
From: Samuli Seppänen Signed-off-by: Samuli Seppänen --- INSTALL-win32.txt | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/INSTALL-win32.txt b/INSTALL-win32.txt index 5a0f3a9..4afef32 100644 --- a/INSTALL-win32.txt +++ b/INSTALL-win32.txt @@ -1,3

Re: [Openvpn-devel] After compiling openVPN 2.3 alpha. I get R6034 error on execution

2012-06-26 Thread Samuli Seppänen
> Hi, > > On Tue, Jun 26, 2012 at 11:16:31AM +0530, Gauri Bhave wrote: >> I downloaded the openvpn-2.3-alpha1.zip from openvpn.net and successfully >> compiled it for windows using the Python build system. But when I run the >> application I get following runtime error for openvpn.exe. R6034 An >>

Re: [Openvpn-devel] After compiling openVPN 2.3 alpha. I get R6034 error on execution

2012-06-26 Thread Gert Doering
Hi, On Tue, Jun 26, 2012 at 11:16:31AM +0530, Gauri Bhave wrote: > I downloaded the openvpn-2.3-alpha1.zip from openvpn.net and successfully > compiled it for windows using the Python build system. But when I run the > application I get following runtime error for openvpn.exe. R6034 An > applicati

[Openvpn-devel] After compiling openVPN 2.3 alpha. I get R6034 error on execution

2012-06-26 Thread Gauri Bhave
Hi, I downloaded the openvpn-2.3-alpha1.zip from openvpn.net and successfully compiled it for windows using the Python build system. But when I run the application I get following runtime error for openvpn.exe. R6034 An application has made an attempt to load the c runtime library incorrectly. Ple