Re: [Openvpn-devel] static build

2012-02-27 Thread Samuli Seppänen
ies from standard URLs, see "openvpn-build/generic/build.vars". Best regards, -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > On Sun, Feb 26, 2012 at 5:42 PM, Mr Dash Four > wrote: >>> arm-unknown-linux-gnueabi-objdump: >>

Re: [Openvpn-devel] [build] tap-windows

2012-02-27 Thread Samuli Seppänen
> 2012/2/27 Samuli Seppänen : >>> Hello, >>> >>> A repository is available[1], stripped down with only tap sources. >>> >>> To build use you need ddk available: >>>> configure >>>> build >> Checked out the sources us

Re: [Openvpn-devel] static build

2012-02-28 Thread Samuli Seppänen
lly, use this on my android device without further problems, > fingers crossed! Good to hear you got it working! Take care, -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock

Re: [Openvpn-devel] openvpn windows gui

2012-02-28 Thread Samuli Seppänen
ed ones if that fails. Not sure if we want do that, but it's an option. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock

[Openvpn-devel] OpenVPN 2.3-alpha1 released

2012-02-28 Thread Samuli Seppänen
n-devel at irc.freenode.net (requires Freenode registration) -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock 2012.02.21 -- Version 2.3-alpha1 Adriaan de Jong (127): Added Doxygen doxyfile Changed configure to accept --with-ssl-type=op

Re: [Openvpn-devel] openvpn windows gui

2012-02-29 Thread Samuli Seppänen
Il 28.02.2012 14:55, Jan Just Keijser ha scritto: > Samuli Seppänen wrote: >>>> We should probably write an installer. >>>> >>> I'm not sure if it's the best idea to make each and every GUI project out >>> there write it's own ins

Re: [Openvpn-devel] OpenVPN 2.3-alpha1 released

2012-02-29 Thread Samuli Seppänen
so they're probably described here: <http://openvpn.net/index.php/open-source/documentation/miscellaneous/79-management-interface.html> If not, then maybe on the man-page, or not at all. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock

[Openvpn-devel] Project management and direction (WAS: Re: OpenVPN 2.3-alpha1 released)

2012-03-01 Thread Samuli Seppänen
ildsystem overhaul was. Some plans for OpenVPN 3.0 were made a while ago: <https://community.openvpn.net/openvpn/wiki/RoadMap> We should probably reopen this discussion once 2.3 (final) is out. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock

Re: [Openvpn-devel] Project management and direction (WAS: Re: OpenVPN 2.3-alpha1 released)

2012-03-01 Thread Samuli Seppänen
Il 01.03.2012 14:49, Alon Bar-Lev ha scritto: > On Thu, Mar 1, 2012 at 12:41 PM, Samuli Seppänen wrote: >> 1) Preliminary topic list is sent to openvpn-devel ml >> 2) The actual meeting (fully open) >> 3) The meeting summary + complete chatlog is sent to openvpn-devel ml

Re: [Openvpn-devel] [PATCH 02/52] package: rpm: strip should be handled by package management

2012-03-06 Thread Samuli Seppänen
ess %{_rpmconfigdir}/brp-strip %{_rpmconfigdir}/brp-strip-static-archive %{_rpmconfigdir}/brp-strip-comment-note If so, I give this one an ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock [1] See <http://groups.google.com/group/linux.redhat.rpm/browse_thread/thread/4cacfa2591cad1c9>

Re: [Openvpn-devel] [PATCH 04/52] cleanup: remove C++ warnings

2012-03-06 Thread Samuli Seppänen
.c b/ssl_polarssl.c > index c50cf0a..02dc233 100644 > --- a/ssl_polarssl.c > +++ b/ssl_polarssl.c > @@ -324,8 +324,10 @@ tls_ctx_load_priv_file (struct tls_root_ctx *ctx, const > char *priv_key_file >warn_if_group_others_accessible (priv_key_file); > >/* TODO: Check Private Key */ > -// if (!SSL_CTX_check_private_key (ctx)) > -//msg (M_SSLERR, "Private key does not match the certificate"); > +#if 0 > + if (!SSL_CTX_check_private_key (ctx)) > +msg (M_SSLERR, "Private key does not match the certificate"); > +#endif >return 0; > } > The C++ style commenting[1] has not spread widely in OpenVPN: $ grep "//" *.c|less Although this commenting style has been valid in C since C99 (year 2000), the actual C99 implementations seem to be incomplete[2]. So, just to be on the safe side, I'll give this one an ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock [1] <http://en.wikipedia.org/wiki/C_syntax#Comments> [2] <http://en.wikipedia.org/wiki/C99#Implementations>

Re: [Openvpn-devel] [PATCH 06/52] cleanup: remove redundant ';'

2012-03-06 Thread Samuli Seppänen
open (const char *path, const char *mode); Seems like an anomaly. ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock

Re: [Openvpn-devel] [PATCH 07/52] cleanup: crypto_openssl.c: remove support for pre-openssl-0.9.6

2012-03-06 Thread Samuli Seppänen
ty(x) 1 > -#endif /* SSLEAY_VERSION_NUMBER < 0x0090581f */ > - > #ifndef EVP_CIPHER_name > #define EVP_CIPHER_name(e) OBJ_nid2sn(EVP_CIPHER_nid(e)) > #endif It has been agreed earlier that OpenSSL 0.9.6 will not be supported anymore. ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock

Re: [Openvpn-devel] [PATCH 08/52] cleanup: tun.c: fix incorrect option in message (ip-win32)

2012-03-06 Thread Samuli Seppänen
msg (M_FATAL, "ERROR: --ip-win32 dynamic [offset] : offset is outside of > --ifconfig subnet"); > >gc_free (&gc); >return htonl(dsa); ACK. There is indeed no --tap-win32 option. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock

Re: [Openvpn-devel] [PATCH 09/52] cleanup: memcmp.c: remove unused source

2012-03-06 Thread Samuli Seppänen
char *p1 = s1, *p2 = s2; > - int d; > - > - if (n) > -while (n-- > 0) > - { > - d = *p1++ - *p2++; > - if (d != 0) > - return d; > - } > - return 0; > -} My C-fu is fairly low, but this still seems to make sense as there's no

Re: [Openvpn-devel] [PATCH 11/52] build: correct place to alter WINVER is at build system

2012-03-06 Thread Samuli Seppänen
NSOLE -D_MBCS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS > -D_CRT_SECURE_NO_WARNINGS $(INCLUDE_DIRS) /FD /c > > LINK32=link.exe > Makes sense. WINVER defines the minimum supported Windows version[1]. In this case (0x501) we support WIndows XP and later. Making this a buil

Re: [Openvpn-devel] [PATCH 12/52] Update .gitignore

2012-03-06 Thread Samuli Seppänen
c > *.so > +*~ > .deps > Makefile > Makefile.in Editor backup files in "git status" are annoying. ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock

Re: [Openvpn-devel] [PATCH 16/52] build: we need the sample.ovpn in future

2012-03-06 Thread Samuli Seppänen
> +# You can generate a static OpenVPN key > +# by selecting the Generate Key option > +# in the start menu. > +# > +# You can also generate key.txt manually > +# with the following command: > +# openvpn --genkey --secret key.txt > +# > +# key must match on both ends

Re: [Openvpn-devel] [PATCH 18/52] Remove easy-rsa

2012-03-06 Thread Samuli Seppänen
Moving easy-rsa into a separate subproject, so this makes sense. ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Signed-off-by: Alon Bar-Lev > --- > Makefile.am|1 - > easy-rs

Re: [Openvpn-devel] [PATCH 17/52] Remove install-win32

2012-03-06 Thread Samuli Seppänen
The "install-win32" directory is obsolete, and will be even more so with this new buildsystem. ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Signed-off-by: Alon Bar-Lev > --- > Makefile.am

Re: [Openvpn-devel] [PATCH 20/52] cleanup: rename tap-windows function from win32 to win

2012-03-06 Thread Samuli Seppänen
As is said on tap-win32/common.h and in many other places: "TAP-Win32/TAP-Win64 -- A kernel driver to provide virtual tap device functionality on Windows." So, it's not 32-bit only. Thus converting "tap-win32" into "tap-win" makes sense. ACK. -- Samuli

Re: [Openvpn-devel] [PATCH 19/52] Remove tap-win32

2012-03-06 Thread Samuli Seppänen
As tap-win32 is being moved to a separate subproject, this makes sense. ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Introduce tap-windows.h which is modified tap-win32/common.h. > Except of function rename, it is the same without the

Re: [Openvpn-devel] [PATCH 21/52] build: remove windows specific build system

2012-03-06 Thread Samuli Seppänen
There goes all the sweat and tears I poured onto that buildsystem :). I say let it burn. ACK. Samuli > It will be completely re-written in future > > Signed-off-by: Alon Bar-Lev > --- > Makefile.am|8 +- > doclean| 73 - > domake-win | 138

Re: [Openvpn-devel] [PATCH 27/52] build: autoconf: remove OPENVPN_ADD_LIBS useless macro

2012-03-08 Thread Samuli Seppänen
Looks fairly straightforward: the OPENVPN_ADD_LIBS(LIB) macro[1] from "acinclude.m4" is being phased out, e.g. OPENVPN_ADD_LIBS(-ldmalloc) becomes LIBS="${LIBS} -ldmalloc" I don't think the macro does anything _that_ special it would be worth saving. ACK. --

Re: [Openvpn-devel] [PATCH 28/52] build: remove awk and non-standard autoconf output processing

2012-03-08 Thread Samuli Seppänen
f running "set" does not produce output that would match the regexps without being related to the OpenVPN builds. Given that the regexps are very strictly defined, that doesn't sound likely. I give this one an ACK. Please NACK if you disagree :). -- Samuli Seppänen Community Manager

Re: [Openvpn-devel] [PATCH 31/52] build: autoconf: commands as environment

2012-03-08 Thread Samuli Seppänen
ectly? I don't know autotools well enough to give this one an ACK at this point. That said, the patch does clean up configure.ac a lot, and cleanups are always nice :). -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Signed-off-by: Alon Bar-Lev

Re: [Openvpn-devel] [PATCH 33/52] build: properly detect and use socket libs

2012-03-08 Thread Samuli Seppänen
r case? Apparently both have their uses. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Signed-off-by: Alon Bar-Lev > --- > configure.ac| 27 +-- > src/openvpn/Makefile.am |1 + > 2 files changed,

Re: [Openvpn-devel] [PATCH 35/52] build: proper selinux detection and usage

2012-03-08 Thread Samuli Seppänen
Looks like a cleaner implementation than the earlier one. I take it AC_CHECK_HEADER is not anymore needed to detect selinux.h, but why exactly? Besides that I give this one an ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Signed-off-by: A

Re: [Openvpn-devel] [PATCH 36/52] build: distribute pkg.m4

2012-03-08 Thread Samuli Seppänen
If we need pkg-config, then we also want this one: "Macros to locate and utilise pkg-config" ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > RHEL and others do not install this globally, so we provide our own copy. > > Sign

Re: [Openvpn-devel] [PATCH 37/52] build: proper pkcs11-helper detection and usage

2012-03-08 Thread Samuli Seppänen
These changes follow the same style as earlier patches, e.g. the selinux patch. Pkg-config is now being used to detect pkcs11-helper afaics. Also, pkcs11-helper now disabled by default, which I think makes sense. I don't see why this shouldn't be included, so it's an ACK. --

Re: [Openvpn-devel] [PATCH 38/52] build: properly process lzo-stub

2012-03-08 Thread Samuli Seppänen
speaks up, I say ACK this. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Signed-off-by: Alon Bar-Lev > --- > configure.ac | 12 +++- > src/openvpn/lzo.c | 20 ++-- > src/openvpn/l

Re: [Openvpn-devel] [PATCH 41/52] build: autoconf: update defaults for options

2012-03-08 Thread Samuli Seppänen
I'd rather not RTFM... could somebody explain to me what the funky "@<:@default=no@:>@" thing exactly does? Does it just add the default "enabled/disabled" value to the help strings? If so it's an ACK. -- Samuli Seppänen Community Manager OpenVPN Technolo

Re: [Openvpn-devel] [PATCH 42/52] build: win-msvc: msbuild format

2012-03-08 Thread Samuli Seppänen
it worked fine on Windows 2008r2. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Signed-off-by: Alon Bar-Lev > --- > .gitignore| 11 +- > Makefile.am | 10 +

Re: [Openvpn-devel] [PATCH 44/52] build: split out compat

2012-03-08 Thread Samuli Seppänen
The commit message makes sense to me, so it's a feature-ACK. Somebody else might want to look at the code itself. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > compat should not use any of the main project headers or conventions, > it

Re: [Openvpn-devel] [PATCH 46/52] build: move daemon() emulation into compat

2012-03-08 Thread Samuli Seppänen
Which platforms need daemon() emulation? Only Windows? I think it makes sense to isolate OS compatibility functions to files under src/compat. Better than having them in misc.c. Also, I can't see any obvious issues with the patch, code-vise. ACK. -- Samuli Seppänen Community Manager Op

Re: [Openvpn-devel] [PATCH 47/52] build: move inet_ntop(), inet_pton() emulation into compat

2012-03-08 Thread Samuli Seppänen
. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock PS. These links should cover the basic idea, in case somebody is interested: <http://us.generation-nt.com/inet-pton-windows-convert-address-presentation-format-network-format-help-37036482.html>

Re: [Openvpn-devel] [PATCH 48/52] cleanup: move console related function into its own module

2012-03-08 Thread Samuli Seppänen
tions" Feature-vise I give this one an ACK. Somebody else might want to look at the actual changes. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock [1] For you own amusement, you can try something like this: for i in `ls *.c`;do echo -n $i": ";ca

Re: [Openvpn-devel] [PATCH 49/52] build: move wrappers into platform module

2012-03-08 Thread Samuli Seppänen
This probably makes sense, lots of good refactorings. That said, I'd like to know how you selected what goes to platform.c? -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > + Some fixups within the platform.c functions. > - need to check

Re: [Openvpn-devel] [PATCH 50/52] build: windows: install version.sh to allow installer read version

2012-03-08 Thread Samuli Seppänen
Is this meant to allow using these variables[1] in the NSIS script(s)? -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock [1] OPENVPN_PACKAGE_NAME="@PACKAGE_NAME@" OPENVPN_PACKAGE_TARNAME="@PACKAGE_TARNAME@" OPENVPN_PACKAGE_VERSI

Re: [Openvpn-devel] [PATCH 51/52] build: distribute samples in windows

2012-03-08 Thread Samuli Seppänen
So, this essentially makes sure client.conf and server.conf are included in Windows (installers) as client.ovpn and server.ovpn? If so, ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Signed-off-by: Alon Bar-Lev > --- > con

Re: [Openvpn-devel] [PATCH 52/52] build: use tap-windows.h as external dependency

2012-03-08 Thread Samuli Seppänen
If I understood this correctly, include/tap-windows.h gets removed, and will then be included using the same mechanism that's used to include LZO headers, OpenSSL headers, etc. I think this makes sense now that the TAP-driver is a separate subproject. ACK. -- Samuli Seppänen Community Ma

Re: [Openvpn-devel] [easy-rsa 1/4] cleanup: fix execute permission

2012-03-08 Thread Samuli Seppänen
ACK. A few related questions/suggestions: - perhaps "easy-rsa/1.0" could be removed altogether? - perhaps "openssl-0.9.6.cnf" and any references to it could be removed also? -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Sign

Re: [Openvpn-devel] [easy-rsa 2/4] build: simple autotools build

2012-03-08 Thread Samuli Seppänen
nVPN" with "easy-rsa" where applicable. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Signed-off-by: Alon Bar-Lev > --- > .gitignore|9 ++ > COPYING | 42 +

Re: [Openvpn-devel] [easy-rsa 3/4] build: doc

2012-03-08 Thread Samuli Seppänen
Looks good. Moves docs into a separate directory with it's own makefile. Provided that patch 2/4 was sane autotools-vise, I give this one an ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Signed-off-by: Alon Bar-Lev > --- >

Re: [Openvpn-devel] [easy-rsa 4/4] packaging: rpm: initial add

2012-03-08 Thread Samuli Seppänen
Support for RPM in easy-rsa, nice. Feature-vise it's an ACK. Afaics autotools stuff is ok, but I'm no expert. Somebody else have a look please :). -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock PS. We need Debian rules files too... that&

Re: [Openvpn-devel] [PATCH 50/52] build: windows: install version.sh to allow installer read version

2012-03-09 Thread Samuli Seppänen
Ok. ACK. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Not exactly. > It is used[1] by the packaging script... just sourced to get some > environment variables. > > [1] https://github.com/alonbl/openvpn-build/blob/master/windows

Re: [Openvpn-devel] [PATCH 47/52] build: move inet_ntop(), inet_pton() emulation into compat

2012-03-09 Thread Samuli Seppänen
Ok. We need this for at least 2 years when XP has EOL and I think compat is the right place. ACK just as earlier :). -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Not exactly... windows has this in Vista and above. > As long as we need to s

Re: [Openvpn-devel] [PATCH 49/52] build: move wrappers into platform module

2012-03-09 Thread Samuli Seppänen
maintenance load of our shoulders. I give this one a feature-ACK, but could somebody else take a better look at the actual code changes? -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > Well, at first I wanted to split it into its own libplatform disti

Re: [Openvpn-devel] [PATCH 35/52] build: proper selinux detection and usage

2012-03-09 Thread Samuli Seppänen
Thanks for the clarification. ACK then. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock > I wrote this in the introduction of the patch set. > > There are two approaches to detecting dependencies: > > 1. Detect all compile time dependen

Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.3-alpha1 released

2012-03-12 Thread Samuli Seppänen
f complaining here :). -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock

Re: [Openvpn-devel] [Openvpn-users] OpenVPN 2.3-alpha1 released

2012-03-13 Thread Samuli Seppänen
ays, we need to be very careful to avoid privilege escalation bugs. I'll also try to get James to explain his GUI/service separation approach in more detail, maybe in an IRC meeting... -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock

Re: [Openvpn-devel] [PATCH 00/35] build revolution

2012-03-14 Thread Samuli Seppänen
ling that the Python-based MSVC buildsystem he started writing (and which I finished) was a reaction to the general crappiness of OpenVPN Windows buildsystem(s). And that should not be an argument after the new "generic" buildsystem is merged. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock

[Openvpn-devel] Topics for tomorrow's meeting

2012-03-14 Thread Samuli Seppänen
el - look here for details: <https://community.openvpn.net/openvpn/wiki/GettingHelp#DeveloperIRCchannel> -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock

Re: [Openvpn-devel] ASLR/DEP -enabled 2.4.0 Windows installer available

2017-01-23 Thread Samuli Seppänen
Il 21/01/2017 05:11, Selva Nair ha scritto: > Hi, > On Fri, Jan 20, 2017 at 11:42 AM, Selva Nair <mailto:selva.n...@gmail.com>> wrote: > > On Fri, Jan 20, 2017 at 9:43 AM, Samuli Seppänen > mailto:sam...@openvpn.net>> wrote: > Thanks for

Re: [Openvpn-devel] [PATCH] Resolve several travis-ci issues

2017-01-30 Thread Samuli Seppänen
:-) (but I shouldn't be surprised: git >> is known to do everything to ease lazy committers' work :-) ) > > Weee! I realize I will need to read the man pages again ... I was > neither aware of -v :) Thanks for the hint, Antonio! Same here, so another thanks to Antonio

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-01-30 Thread Samuli Seppänen
gt; > > > 2017-01-21 0:24 GMT+05:00 David Sommerseth > <mailto:open...@sf.lists.topphemmelig.net>>: > > On 13/01/17 10:05, Samuli Seppänen wrote: > > Il 13/01/2017 10:50, Ilya Shipitsin ha scritto: > >> --- > &

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-02-02 Thread Samuli Seppänen
On 31/01/2017 15:49, David Sommerseth wrote: > On 30/01/17 13:34, Samuli Seppänen wrote: >> I agree with you on keeping the pull request template minimal and having >> the more fine-grained information in Trac. >> >> ACK. > > Don't get me wrong! I agree we sh

Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

2017-02-02 Thread Samuli Seppänen
lly did not know about "git send-email" until now. I've used "git-send-email" which on Debian/Ubuntu resides in /usr/lib/git-core. Are these the same thing? Anyways, let's use "git send-email"

Re: [Openvpn-devel] [PATCH applied] github: Add PR template with contributor related information

2017-02-07 Thread Samuli Seppänen
ntradictory? Or if the documentation is hidden as well as the CodeStyle page? I will create a copy of the DeveloperDocumentation page and clean that one up. Then I will send a link so that others can have a look. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock

Re: [Openvpn-devel] [PATCH applied] github: Add PR template with contributor related information

2017-02-07 Thread Samuli Seppänen
On 07/02/2017 11:06, Samuli Seppänen wrote: > On 06/02/2017 12:44, David Sommerseth wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> I have ACKed and applied this, just to get this one resolved. But I am very >> disappointed that you have

Re: [Openvpn-devel] [PATCH applied] github: Add PR template with contributor related information

2017-02-07 Thread Samuli Seppänen
On 07/02/2017 15:03, David Sommerseth wrote: > On 07/02/17 11:09, Samuli Seppänen wrote: >> Actually, that was just the line length for _code_, not for commit >> messages. So the only indirect guideline for Git commit message line >> length was > > Correct. > >

[Openvpn-devel] Topics for the upcoming (Wednesday, 22nd February 2016) community meeting

2017-02-21 Thread Samuli Seppänen
g to this email or to the summary email sent after the meeting. Whenever possible, we'll also respond to existing, related email threads. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock --

[Openvpn-devel] Summary of today's (Wed 22nd Oct 2017) community meeting

2017-02-22 Thread Samuli Seppänen
(name + email), such as this one: <https://community.openvpn.net/openvpn/ticket/825> Agreed that we can take responsibility of the smaller patches if the author can't be reached. Larger patches that can't be attributed will be simply ignored. --- Full chatlog has been attached to t

Re: [Openvpn-devel] [PATCH] Fix "--dev null"

2017-02-24 Thread Samuli Seppänen
gt; +(tt->type == DEV_TYPE_TUN && tt->topology == TOP_SUBNET) || > + tt->type == DEV_TYPE_NULL ) > { > tun = false; > } > -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock --

Re: [Openvpn-devel] could be gitlab-ci an alternative to buildbot cloud?

2017-03-08 Thread Samuli Seppänen
> Openvpn-devel mailing list > Openvpn-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/openvpn-devel > -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock ---

Re: [Openvpn-devel] could be gitlab-ci an alternative to buildbot cloud?

2017-03-13 Thread Samuli Seppänen
On 08/03/2017 21:58, Samuli Seppänen wrote: > Hi, > > On 05/03/2017 16:25, Илья Шипицин wrote: >> Hello, >> >> there was some buzz related to improvement of testing system, like >> patchwork. >> we tried gitlab-ci on our internal project, it looks very pr

[Openvpn-devel] Reviewer(s) for French translation fixes in OpenVPN GUI?

2017-03-13 Thread Samuli Seppänen
Hi, Is anyone interested in reviewing some French-language fixes to OpenVPN GUI? <https://github.com/OpenVPN/openvpn-gui/pull/136> If we don't get any review, we'll have to merge the PR with a lazy-ACK. Any help would be appreciated! -- Samuli Seppänen Community Manager Open

[Openvpn-devel] Topics for tomorrow's (Wed, 15th Mar 2017) community meeting

2017-03-14 Thread Samuli Seppänen
email sent after the meeting. Whenever possible, we'll also respond to existing, related email threads. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock 0x40864578.asc Description: application/pgp-keys signature.asc Description:

Re: [Openvpn-devel] Topics for tomorrow's (Wed, 15th Mar 2017) community meeting

2017-03-14 Thread Samuli Seppänen
Correction to the below text. Today -> tomorrow. On 14/03/2017 15:14, Samuli Seppänen wrote: > Hi, > > We're going to have an IRC meeting today starting at 20:00 CEST (18:00 > UTC) on #openvpn-meeting irc.freenode.net. You do not have to be > logged in to Freen

[Openvpn-devel] Summary of today's (Wed, 15th Mar 2017) community meeting

2017-03-15 Thread Samuli Seppänen
se the upcoming Monday (20th March). The OpenSSL support patches will have to be postponed to 2.4.2. -- Discussed the VLAN patchset: <https://github.com/OpenVPN/openvpn/pull/76> Agreed that it is too big a chunk to tackle right now. --- Full chatlog has been attached to this email. -

Re: [Openvpn-devel] Consider git tags for I60x

2017-03-22 Thread Samuli Seppänen
ck should consider to add > @cron2 | true > > Regards > For openvpn-build I have not added release tags, as the commit message usually contains the necessary information. For example: --- commit 23d42200f282d2fcdc57bd4262d1fffc0832c7ff Author: Samuli Seppänen Date: Tue Dec 27 12:3

[Openvpn-devel] OpenVPN 2.4.1 released

2017-03-22 Thread Samuli Seppänen
ns here: Bug tracker and wiki: <https://community.openvpn.net> Developer mailing list: <http://sourceforge.net/mail/?group_id=48978> Developer IRC channel: #openvpn-devel at irc.freenode.net (requires Freenode registration) -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc ir

Re: [Openvpn-devel] OpenVPN 2.4.1 released

2017-03-22 Thread Samuli Seppänen
Please note that the GPG key used to sign the release files has changed. The new key is available here: <https://openvpn.net/index.php/open-source/documentation/sig.html> -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock On 22/03/2017 19:20,

Re: [Openvpn-devel] Consider git tags for I60x

2017-03-23 Thread Samuli Seppänen
Hi, On 23/03/2017 05:11, Antonio Quartulli wrote: > On Wed, Mar 22, 2017 at 02:11:56PM +0100, David Sommerseth wrote: >> On 22/03/17 10:07, Samuli Seppänen wrote: >>> On 20/03/2017 17:13, debbie10t wrote: >>>> Hi >>>> >>>> just so this does

Re: [Openvpn-devel] Consider git tags for I60x

2017-03-23 Thread Samuli Seppänen
On 23/03/2017 13:48, David Sommerseth wrote: > On 23/03/17 08:52, Samuli Seppänen wrote: >> Hi, >> >> On 23/03/2017 05:11, Antonio Quartulli wrote: >>> On Wed, Mar 22, 2017 at 02:11:56PM +0100, David Sommerseth wrote: > [...snip...] >>>> Currently w

Re: [Openvpn-devel] building HEAD + openssl 1.1 api fails @ "crypto.c:823:32: error: invalid application of ???sizeof??? to incomplete type ???cipher_ctx_t"

2017-03-28 Thread Samuli Seppänen
viously - the --tls-remote bit) > > Suggestion: A Wiki Page detailing deprecation plans with dated targets. > +1. That would also help us remember what features are being deprecated and what their deprecation status is. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc

Re: [Openvpn-devel] building HEAD + openssl 1.1 api fails @ "crypto.c:823:32: error: invalid application of ???sizeof??? to incomplete type ???cipher_ctx_t"

2017-03-28 Thread Samuli Seppänen
eep this list on one location only, and I think > Changes.rst is the right place. > > -Steffan Ah, Changes.rst had "Deprecated features" section, good. I think that is sufficient. The question then becomes: do we need to link to Changes.rst from somewhere so that people find it? --

Re: [Openvpn-devel] building HEAD + openssl 1.1 api fails @ "crypto.c:823:32: error: invalid application of ???sizeof??? to incomplete type ???cipher_ctx_t"

2017-03-28 Thread Samuli Seppänen
On 28/03/2017 17:11, debbie10t wrote: >> >> Agreed: a simple Deprecation page on the wiki linking to changes.rst >> >> The wiki page *could* also be updated from time to time to provide >> specific warnings of important changes like deprecating --ns-cert-type >> as it has been identified that it wi

Re: [Openvpn-devel] Wik page drafti: DeprecationWarnings

2017-03-29 Thread Samuli Seppänen
On 29/03/2017 03:30, debbie10t wrote: > Hi > > On 28/03/17 20:53, David Sommerseth wrote: >> On 28/03/17 21:24, debbie10t wrote: >>> >>> >>> On 28/03/17 19:18, debbie10t wrote: Hi, Following on from: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg14330.html

[Openvpn-devel] Upgrading EasyRSA 2's defaults

2017-03-31 Thread Samuli Seppänen
we should upgrade these to something more recent. What would more modern reasonable defaults be? -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock 0x40864578.asc Description: application/pgp-keys signature.asc Description: Op

Re: [Openvpn-devel] Upgrading EasyRSA 2's defaults

2017-04-03 Thread Samuli Seppänen
On 02/04/2017 10:57, Steffan Karger wrote: > Hi, > > On 31-03-17 22:34, David Sommerseth wrote: >> On 31/03/17 10:56, Илья Шипицин wrote: >>> 2017-03-31 13:26 GMT+05:00 Samuli Seppänen >> <mailto:sam...@openvpn.net>>: >>> >>> H

Re: [Openvpn-devel] Upgrading EasyRSA 2's defaults

2017-04-05 Thread Samuli Seppänen
On 04/04/2017 10:48, Steffan Karger wrote: > Hi, > > On 3 April 2017 at 23:14, Selva Nair wrote: >> >> >> On Mon, Apr 3, 2017 at 4:43 PM, David Sommerseth >> wrote: >>> >>> On 03/04/17 16:12, Jan Just Keijser wrote: >>>> Hi Samuli,

Re: [Openvpn-devel] [PATCH] travis-ci: add 2 mingw "build only configurations"

2017-04-10 Thread Samuli Seppänen
-z ${CHOST+xxx} ]; then That said, please do what Steffan suggested and split the block into human-readable logical functions and call those functions as needed. Then we can review the patch again and hopefully merge it as-is. -- Samuli Seppänen Community Manager OpenVPN Technologies, I

[Openvpn-devel] Reviewing Korean translation of OpenVPN-GUI?

2017-04-15 Thread Samuli Seppänen
Hi all, Do we have any Korean speakers here who could review this PR? <https://github.com/OpenVPN/openvpn-gui/pull/155> -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock 0x40864578.asc Description: application/pgp-keys signature.asc Descr

Re: [Openvpn-devel] devel mailing list

2017-04-15 Thread Samuli Seppänen
On 15/04/2017 23:08, Selva Nair wrote: > I did not get this mail > > https://sourceforge.net/p/openvpn/mailman/message/35789733/ > > Something up with the list or is it only me? I never received that email either. It must be the 7z attachment... -- Samuli Seppänen Community

Re: [Openvpn-devel] 2.4 sees all client certificates as expired when using crl-verify

2017-04-24 Thread Samuli Seppänen
t would be extremely >>>> useful to maintain (at least optional) backward compatibility with >>>> already existing setups, which originally relied on 2.3 behaviour. >>>> >>> >>> No, there is not. And I don't think there is an easy way to

Re: [Openvpn-devel] For Windows: DHCP Client dependency

2017-04-25 Thread Samuli Seppänen
N-GUI as an admin w/o OpenVPNServiceInteractive So having a (better) error message makes sense. - -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock -BEGIN PGP SIGNATURE- Version: GnuPG v2 iQEcBAEBCAAGBQJY/x04AAoJEClYTZ9Ahk

Re: [Openvpn-devel] [PATCH] travis-ci: add 2 mingw "build only" configurations

2017-04-25 Thread Samuli Seppänen
-a /etc/apt/sources.list.d/xenial.list + echo "deb > http://archive.ubuntu.com/ubuntu xenial main" | sudo tee -a > /etc/apt/sources.list.d/xenial.list + sudo apt-get update + > sudo apt-get -y install dpkg mingw-w64 +fi + # Download and build > crypto lib -mkdir -p

Re: [Openvpn-devel] For Windows: DHCP Client dependency

2017-04-25 Thread Samuli Seppänen
ely in the right place, perhaps usability could be improved somewhat. One simple option would be to make the anchor visible, so that the user sees TAP-Win32 adapter is not coming up: "Initialization sequence completed with errors". [#dhcpclientserv] instead of TAP-Win32 adapter is not

Re: [Openvpn-devel] For Windows: DHCP Client dependency

2017-04-26 Thread Samuli Seppänen
On 25/04/2017 15:29, Samuli Seppänen wrote: > On 25/04/2017 15:11, debbie10t wrote: >> >> >> On 25/04/17 01:18, debbie10t wrote: >>> Hi, >>> >>> generally, Openvpn on Windows is dependent on the "Windows DHCP Client >>> service" .

Re: [Openvpn-devel] For Windows: DHCP Client dependency

2017-04-26 Thread Samuli Seppänen
On 26/04/2017 13:12, David Sommerseth wrote: > On 26/04/17 10:32, Samuli Seppänen wrote: >> >> So I made the anchor visible: >> >> <https://community.openvpn.net/openvpn/wiki/FAQ> >> >> Not necessarily very pretty, but should help users figure out whic

[Openvpn-devel] OpenVPN releases tomorrow at 14:00 UTC (fixes vulnerabilities)

2017-05-10 Thread Samuli Seppänen
Hi all, We will make OpenVPN releases tomorrow (11th May 2017) at 14:00 UTC, fixing two remote DoS vulnerabilities. More details will follow at release time. -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock 0x40864578.asc Description: application/pgp

[Openvpn-devel] OpenVPN 2.4.2 released (with security fixes)

2017-05-11 Thread Samuli Seppänen
at irc.freenode.net Please report bugs and ask development questions here: Bug tracker and wiki: <https://community.openvpn.net> Developer mailing list: <http://sourceforge.net/mail/?group_id=48978> Developer IRC channel: #openvpn-devel at irc.freenode.net (requires Freenode registrat

[Openvpn-devel] OpenVPN 2.3.15 released (with security fixes)

2017-05-11 Thread Samuli Seppänen
at irc.freenode.net Please report bugs and ask development questions here: Bug tracker and wiki: <https://community.openvpn.net> Developer mailing list: <http://sourceforge.net/mail/?group_id=48978> Developer IRC channel: #openvpn-devel at irc.freenode.net (requires Freenode registration)

[Openvpn-devel] OpenVPN 2.3.16 released

2017-05-19 Thread Samuli Seppänen
/mail/?group_id=48978> Developer IRC channel: #openvpn-devel at irc.freenode.net (requires Freenode registration) -- Samuli Seppänen Community Manager OpenVPN Technologies, Inc irc freenode net: mattock 0x40864578.asc Description: application/pgp-keys -

Re: [Openvpn-devel] OpenVPN 2.3.16 released

2017-05-19 Thread Samuli Seppänen
On 19/05/2017 13:46, Jonathan K. Bullard wrote: > On Fri, May 19, 2017 at 5:29 AM, Samuli Seppänen wrote: >> >> The OpenVPN community project team is proud to release OpenVPN 2.3.16. >> It can be downloaded from here: >> >> <http://openvpn.net/index.php/open-so

Re: [Openvpn-devel] Problem with sig for 2.3.16?

2017-05-19 Thread Samuli Seppänen
a couple of > hours ago. I expect it to be fixed in not too long. > Hi, Joomla did not seem to like the fact that file name was secur...@openvpn.net.key.asc. So I renamed it as security.key.asc. That seems to work fine. Right now the signature situation is a bit confusing, as 2.4.2 is still

Re: [Openvpn-devel] OpenVPN 2.3.16 released

2017-05-22 Thread Samuli Seppänen
On 19/05/2017 15:37, David Sommerseth wrote: > On 19/05/17 12:46, Jonathan K. Bullard wrote: >> On Fri, May 19, 2017 at 5:29 AM, Samuli Seppänen wrote: >>> >>> The OpenVPN community project team is proud to release OpenVPN 2.3.16. >>> It can be downloaded fr

Re: [Openvpn-devel] Ubuntu 16.04.2 LTS --enable-systemd ./configure error

2017-05-28 Thread Samuli Seppänen
SECCOMP +BLKID +ELFUTILS > +KMOD -IDN > > > sorry about that blunder > > >> >>> apt-get install libsystemd-dev is done >> >> Can you locate libsystemd.pc or systemd.pc on your system? Are there >> other systemd related -dev packages available? >&

Re: [Openvpn-devel] Ubuntu 16.04.2 LTS --enable-systemd ./configure error

2017-05-29 Thread Samuli Seppänen
Hi, On 29/05/2017 11:47, David Sommerseth wrote: > On 29/05/17 07:57, Samuli Seppänen wrote: >> On 29/05/2017 00:36, debbie10t wrote: > [...snip...] >>> >>> $ systemctl --version >>> systemd 229 >>> +PAM +AUDIT +SELINUX +IMA +APPARMOR +SMACK +SYSVIN

<    1   2   3   4   5   6   7   8   9   10   >