Re: [ovs-dev] [PATCH] ovs-rcu: Remove unneeded mutex from struct ovsrcu_perthread.

Hello Ben, On Tue, Jun 29, 2021 at 5:36 PM Ben Pfaff wrote: > > It was not really used. If I am not mistaken, this is the same patch as https://patchwork.ozlabs.org/project/openvswitch/patch/d89cc03128a6e449ce49f729b9eeafe687356b4e.1621517561.git.gr...@u256.net/. > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [RFC PATCH ovn] Introduce representor port plugging support

On Thu, Jun 10, 2021 at 10:13 AM Frode Nordahl wrote: > > On Thu, Jun 10, 2021 at 1:46 PM Ilya Maximets wrote: > > > > On 6/10/21 8:36 AM, Han Zhou wrote: > > > > > > > > > On Thu, May 13, 2021 at 9:25 AM Frode Nordahl > > > mailto:frode.nord...@canonical.com>> wrote: > > >> > > >> On Thu, May

Re: [ovs-dev] ovn-northd-ddlog scale issues

On Mon, Jun 28, 2021 at 05:40:53PM +0200, Dumitru Ceara wrote: > On 5/20/21 5:50 PM, Ben Pfaff wrote: > > On Thu, May 20, 2021 at 05:06:26PM +0200, Dumitru Ceara wrote: > >> On 4/7/21 6:49 PM, Ben Pfaff wrote: > >> > >> [...] > >> > > Thanks! I can download them now. It's back on my

Re: [ovs-dev] [PATCH v2 ovn 0/9] northd: rework ovn-northd lb flow installation

On Fri, Jun 18, 2021 at 9:04 AM Lorenzo Bianconi wrote: > > Rework lb flow logic in order to visit first each load_balancer and then > related datapath during lb flow installation. > This patch allows to reduce memory footprint and cpu utilization in > ovn-northd. > Hi Lorenzo, The ovsrobot CI

Re: [ovs-dev] [PATCH ovn] Set release date for 21.06.0.

On Tue, Jun 29, 2021 at 4:57 PM Mark Michelson wrote: > > Thanks for fixing my error, Numan. > > Acked-by: Mark Michelson Thanks. I applied to the main branch. Numan > > On 6/25/21 8:00 PM, num...@ovn.org wrote: > > From: Numan Siddique > > > > And also prepare for 21.6.90. This was missed

Re: [ovs-dev] [PATCH ovn v8 4/6] northd: Add IP routing and ARP resolution flows for NAT/LB addresses.

On Thu, Jun 3, 2021 at 2:50 PM Mark Michelson wrote: > > Dealing with NAT and load balancer IPs has been a bit of a pain point. > It requires creating static routes if east-west traffic to those > addresses is desired. Further, it requires ARPs to be sent between the > logical routers in order to

Re: [ovs-dev] [PATCH ovn] Set release date for 21.06.0.

Thanks for fixing my error, Numan. Acked-by: Mark Michelson On 6/25/21 8:00 PM, num...@ovn.org wrote: From: Numan Siddique And also prepare for 21.6.90. This was missed out when v21.06.0 was released. Signed-off-by: Numan Siddique --- NEWS | 6 +- configure.ac | 2

Re: [ovs-dev] [PATCH v10] ofproto-dpif: APIs and CLI option to add/delete static fdb entry

Hi Eelco/Ben, I found that the documentation for ovs-vswitchd did not reflect the last minute change I made to the fdb/del syntax. This last patch v11 version reflects that change. Thanks -Vasu *Vasu Dasari* On Tue, Jun

[ovs-dev] [PATCH v11] ofproto-dpif: APIs and CLI option to add/delete static fdb entry

Currently there is an option to add/flush/show ARP/ND neighbor. This covers L3 side. For L2 side, there is only fdb show command. This patch gives an option to add/del an fdb entry via ovs-appctl. CLI command looks like: To add: ovs-appctl fdb/add ovs-appctl fdb/add br0 p1 0

Re: [ovs-dev] [PATCH ovn] northd: avoid memory reallocation while building ACL and QoS rules

On Tue, Jun 22, 2021 at 5:22 PM Mark Michelson wrote: > > On 6/22/21 1:14 PM, Dan Williams wrote: > > On Fri, 2021-06-18 at 21:49 +0200, Dumitru Ceara wrote: > >> On 6/4/21 10:00 PM, Dan Williams wrote: > >>> Inspried by: > >>> > >>> 3b6362d64e86b northd: Avoid memory reallocation while building

Re: [ovs-dev] [External] : [PATCH ovn] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

On Tue, Jun 29, 2021 at 2:29 PM Brendan Doyle wrote: > > > Thanks for doing the ddlog for this, comment below > > On 29/06/2021 17:08, num...@ovn.org wrote: > > From: Numan Siddique > > > > The commit [1] didn't add the ddlog part. > > > > [1] - 8087cbc7462("ovn-northd.c: Add proxy ARP support

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

On Tue, Jun 29, 2021 at 09:57:44PM +0200, Ilya Maximets wrote: > For the more or less automatic ways of solving the disbalance there are > few more ideas that we can explore: > > - Try to measure the load on the ovsdb-server process and report it > somehow in the _Server database, so the client

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

On 6/29/21 8:05 PM, Ben Pfaff wrote: > On Tue, Jun 29, 2021 at 10:29:59AM -0700, Han Zhou wrote: >> On Tue, Jun 29, 2021 at 8:43 AM Ben Pfaff wrote: >>> >>> On Tue, Jun 29, 2021 at 12:56:18PM +0200, Ilya Maximets wrote: If a new database server added to the cluster, or if one of the

Re: [ovs-dev] [PATCH v10] ofproto-dpif: APIs and CLI option to add/delete static fdb entry

Thank you Eelco for your careful review. I appreciate and thank you for all your comments. -Vasu *Vasu Dasari* On Tue, Jun 29, 2021 at 11:08 AM Eelco Chaudron wrote: > > > On 29 Jun 2021, at 15:19, Vasu Dasari wrote: > > > Currently there is an option to add/flush/show ARP/ND neighbor. This

Re: [ovs-dev] [PATCH ovn v3 3/3] ovn-controller: Fix incremental processing for logical port references.

On Thu, Jun 24, 2021 at 10:33 AM Dumitru Ceara wrote: > > On 6/24/21 7:20 PM, Han Zhou wrote: > > For the reason mentioned above, we can't make this change. In fact, I > > wouldn't worry much about lflow_ref_lookup()'s cost. It is O(1) operation. > > If it really turns out to be a bottleneck, we

[ovs-dev] [PATCH ovn v4] ovn-controller: Fix incremental processing for logical port references.

If a lflow has an lport name in the match, but when the lflow is processed the port-binding is not seen by ovn-controller, the corresponding openflow will not be created. Later if the port-binding is created/monitored by ovn-controller, the lflow is not reprocessed because the lflow didn't change

Re: [ovs-dev] [PATCH ovn] ovs-sandbox: Allow specifying initial contents for NB and SB database.

Bleep bloop. Greetings Ben Pfaff, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line has non-spaces leading whitespace #73 FILE: tutorial/ovs-sandbox:284:

Re: [ovs-dev] [PATCH] dpif/dpcls: limit count subtable search info logs

On Tue, Jun 29, 2021 at 10:19:41PM +0530, Kumar Amber wrote: > From: Harry van Haaren > > This commit avoids many instances of "using subtable X for miniflow (x,y)" > in the ovs-vswitchd log when using the DPCLS Autovalidator. This occurs > when no specialized subtable is found, and the generic

[ovs-dev] [PATCH ovn] ovs-sandbox: Allow specifying initial contents for NB and SB database.

This makes it easier to test northd behavior with particular database contents, like the ones that Dumitru posted to the mailing list: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/384519.html You just do something like this: make sandbox

Re: [ovs-dev] [v4 07/12] test/sytem-dpdk: Add unit test for mfex autovalidator

Hi Flavio, Comments Inline. > -Original Message- > From: Flavio Leitner > Sent: Tuesday, June 29, 2021 11:49 PM > To: Amber, Kumar > Cc: Eelco Chaudron ; d...@openvswitch.org; > i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v4 07/12] test/sytem-dpdk: Add unit test for mfex >

Re: [ovs-dev] [External] : [PATCH ovn] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

Thanks for doing the ddlog for this, comment below On 29/06/2021 17:08, num...@ovn.org wrote: From: Numan Siddique The commit [1] didn't add the ddlog part. [1] - 8087cbc7462("ovn-northd.c: Add proxy ARP support to OVN") Signed-off-by: Numan Siddique --- northd/ovn.dl| 1 +

Re: [ovs-dev] [v4 07/12] test/sytem-dpdk: Add unit test for mfex autovalidator

On Tue, Jun 29, 2021 at 05:11:00PM +, Amber, Kumar wrote: > Hi Eelco, Flavio, > > Pls find my replies Inline > > > -Original Message- > > From: Flavio Leitner > > Sent: Tuesday, June 29, 2021 7:51 PM > > To: Eelco Chaudron > > Cc: Amber, Kumar ; Van Haaren, Harry > > ;

Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to select the best mfex function

On Tue, Jun 29, 2021 at 04:32:05PM +, Van Haaren, Harry wrote: > > -Original Message- > > From: dev On Behalf Of Eelco Chaudron > > Sent: Tuesday, June 29, 2021 1:38 PM > > To: Amber, Kumar > > Cc: d...@openvswitch.org; i.maxim...@ovn.org > > Subject: Re: [ovs-dev] [v4 03/12]

Re: [ovs-dev] [PATCH ovn v3 1/3] ovn-northd: Remove lflow_add_unique.

On Tue, Jun 29, 2021 at 7:04 AM Dumitru Ceara wrote: > > On 6/21/21 8:51 AM, Han Zhou wrote: > > This patch removes the workaround when adding multicast group related > > lflows, because the multicast group dependency problem is fixed in > > ovn-controller in the previous commit. > > > > This

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

On Tue, Jun 29, 2021 at 10:29:59AM -0700, Han Zhou wrote: > On Tue, Jun 29, 2021 at 8:43 AM Ben Pfaff wrote: > > > > On Tue, Jun 29, 2021 at 12:56:18PM +0200, Ilya Maximets wrote: > > > If a new database server added to the cluster, or if one of the > > > database servers changed its IP address

Re: [ovs-dev] [PATCH ovn] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

Hi Ben, This patch is not working as expected. Need your help here. Not very urgent. Please see below. Thanks Numan On Tue, Jun 29, 2021 at 12:09 PM wrote: > > From: Numan Siddique > > The commit [1] didn't add the ddlog part. > > [1] - 8087cbc7462("ovn-northd.c: Add proxy ARP support to

Re: [ovs-dev] [v4 10/12] dpif-netdev/mfex: Add AVX512 based optimized miniflow extract

Hi Ian, Pls find my replies inline and Thanks again for review. BR Amber > -Original Message- > From: Stokes, Ian > Sent: Tuesday, June 29, 2021 10:11 PM > To: Amber, Kumar ; d...@openvswitch.org > Cc: i.maxim...@ovn.org > Subject: RE: [ovs-dev] [v4 10/12] dpif-netdev/mfex: Add AVX512

Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for miniflow extract

Hi, On Tue, Jun 29, 2021 at 03:20:36PM +, Amber, Kumar wrote: > Hi Flavio, > > Replies inline. > > > > > > > Guess the above needs to be atomic. > > > > > > Removed based on Flavio comments. > > > > I asked to initialize that using an API and Eelco is asking to set it > > atomically. > >

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

On Tue, Jun 29, 2021 at 8:43 AM Ben Pfaff wrote: > > On Tue, Jun 29, 2021 at 12:56:18PM +0200, Ilya Maximets wrote: > > If a new database server added to the cluster, or if one of the > > database servers changed its IP address or port, then you need to > > update the list of remotes for the

Re: [ovs-dev] [PATCH ovn] docs: fix git format-patch command for backports

On Tue, Jun 29, 2021 at 12:50:54PM -0400, Ihar Hrachyshka wrote: > On Tue, Jun 29, 2021 at 12:46 PM Ben Pfaff wrote: > > > > On Tue, Jun 29, 2021 at 12:24:11PM -0400, Ihar Hrachyshka wrote: > > > One, HEAD~, not HEAD, should be used to generate any patches. Two, add > > > "ovn" to the generated

Re: [ovs-dev] [v4 07/12] test/sytem-dpdk: Add unit test for mfex autovalidator

Hi Eelco, Flavio, Pls find my replies Inline > -Original Message- > From: Flavio Leitner > Sent: Tuesday, June 29, 2021 7:51 PM > To: Eelco Chaudron > Cc: Amber, Kumar ; Van Haaren, Harry > ; d...@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v4 07/12] test/sytem-dpdk:

Re: [ovs-dev] [v4 12/12] dpif/dpcls: limit count subtable search info logs

> Hi Ian, > > Pls find the separated patch for DPCLS at : > http://patchwork.ozlabs.org/project/openvswitch/patch/20210629164941.1563 > 52-1-kumar.am...@intel.com/ > > Regards > Amber Just spotted it, thanks. Regards Ian > > > -Original Message- > > From: Van Haaren, Harry > > Sent:

Re: [ovs-dev] [v4 12/12] dpif/dpcls: limit count subtable search info logs

Hi Ian, Pls find the separated patch for DPCLS at : http://patchwork.ozlabs.org/project/openvswitch/patch/20210629164941.156352-1-kumar.am...@intel.com/ Regards Amber > -Original Message- > From: Van Haaren, Harry > Sent: Tuesday, June 29, 2021 10:16 PM > To: Stokes, Ian ; Amber, Kumar

[ovs-dev] [PATCH] dpif/dpcls: limit count subtable search info logs

From: Harry van Haaren This commit avoids many instances of "using subtable X for miniflow (x,y)" in the ovs-vswitchd log when using the DPCLS Autovalidator. This occurs when no specialized subtable is found, and the generic "_any" version of the avx512 subtable search implementation was used.

Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to select the best mfex function

> > -Original Message- > > From: Stokes, Ian > > Sent: Thursday, June 24, 2021 2:20 PM > > To: Amber, Kumar ; d...@openvswitch.org; Van > > Haaren, Harry > > Cc: Amber, Kumar ; i.maxim...@ovn.org > > Subject: RE: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to select > > the > >

Re: [ovs-dev] [PATCH ovn] docs: fix git format-patch command for backports

On Tue, Jun 29, 2021 at 12:46 PM Ben Pfaff wrote: > > On Tue, Jun 29, 2021 at 12:24:11PM -0400, Ihar Hrachyshka wrote: > > One, HEAD~, not HEAD, should be used to generate any patches. Two, add > > "ovn" to the generated mail topic. Third, update branch name to a > > fresh one. > > > >

Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for miniflow extract

> > -Original Message- > > From: Amber, Kumar > > Sent: Thursday, June 24, 2021 12:27 PM > > To: Stokes, Ian ; d...@openvswitch.org; Van Haaren, > Harry > > > > Cc: i.maxim...@ovn.org > > Subject: RE: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function > > for > > miniflow

Re: [ovs-dev] [v4 12/12] dpif/dpcls: limit count subtable search info logs

> -Original Message- > From: Stokes, Ian > Sent: Tuesday, June 29, 2021 5:40 PM > To: Amber, Kumar ; d...@openvswitch.org > Cc: i.maxim...@ovn.org; Ferriter, Cian ; Van Haaren, > Harry > Subject: RE: [ovs-dev] [v4 12/12] dpif/dpcls: limit count subtable search > info logs > > > From:

Re: [ovs-dev] [PATCH ovn] docs: fix git format-patch command for backports

On Tue, Jun 29, 2021 at 12:24:11PM -0400, Ihar Hrachyshka wrote: > One, HEAD~, not HEAD, should be used to generate any patches. Two, add > "ovn" to the generated mail topic. Third, update branch name to a > fresh one. > > Signed-off-by: Ihar Hrachyshka Both of these look odd to me: > -$

Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for miniflow extract

> Hi Ian, > > Thanks for reviews, replies are inlined. > Thanks Amber looking forward to the v5. BR Ian > > > > > > +/* Call optimized miniflow for each batch of packet. */ > > > +uint32_t hit_mask = mfex_impls[j].extract_func(packets, > > > test_keys, > > > +

Re: [ovs-dev] [PATCH ovn branch-21.06] Disable ARP/NA responders for vlan-passthru switches

Bleep bloop. Greetings Ihar Hrachyshka, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or

Re: [ovs-dev] [v4 10/12] dpif-netdev/mfex: Add AVX512 based optimized miniflow extract

> From: Harry van Haaren > > This commit adds AVX512 implementations of miniflow extract. > By using the 64 bytes available in an AVX512 register, it is > possible to convert a packet to a miniflow data-structure in > a small quantity instructions. > > The implementation here probes for

Re: [ovs-dev] [v4 08/12] dpif/stats: add miniflow extract opt hits counter

> From: Harry van Haaren > > This commit adds a new counter to be displayed to the user when > requesting datapath packet statistics. It counts the number of > packets that are parsed and a miniflow built up from it by the > optimized miniflow extract parsers. > > The ovs-appctl command

Re: [ovs-dev] [v4 09/12] dpdk: add additional CPU ISA detection strings

> From: Harry van Haaren > > This commit enables OVS to at runtime check for more detailed > AVX512 capabilities, specifically Byte and Word (BW) extensions, > and Vector Bit Manipulation Instructions (VBMI). > > These instructions will be used in the CPU ISA optimized > implementations of

Re: [ovs-dev] [v4 07/12] test/sytem-dpdk: Add unit test for mfex autovalidator

> Tests: > 6: OVS-DPDK - MFEX Autovalidator > 7: OVS-DPDK - MFEX Autovalidator Fuzzy > > Added a new directory to store the PCAP file used > in the tests and a script to generate the fuzzy traffic > type pcap to be used in fuzzy unit test. Hi Amber, I don't have much to add here that Flavio

Re: [ovs-dev] [v4 12/12] dpif/dpcls: limit count subtable search info logs

> From: Harry van Haaren > > This commit avoids many instances of "using subtable X for miniflow (x,y)" > in the ovs-vswitchd log when using the DPCLS Autovalidator. This occurs > when no specialized subtable is found, and the generic "_any" version of > the avx512 subtable search implementation

Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to select the best mfex function

> -Original Message- > From: dev On Behalf Of Eelco Chaudron > Sent: Tuesday, June 29, 2021 1:38 PM > To: Amber, Kumar > Cc: d...@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to select > the best > mfex function > > More

[ovs-dev] [PATCH ovn] docs: fix git format-patch command for backports

One, HEAD~, not HEAD, should be used to generate any patches. Two, add "ovn" to the generated mail topic. Third, update branch name to a fresh one. Signed-off-by: Ihar Hrachyshka --- Documentation/internals/contributing/backporting-patches.rst | 2 +- 1 file changed, 1 insertion(+), 1

Re: [ovs-dev] [PATCH ovn] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 85 characters long (recommended limit is 79) #38 FILE: northd/ovn.rs:187:

[ovs-dev] [PATCH ovn branch-21.06] Disable ARP/NA responders for vlan-passthru switches

When vlan-passthru is on, VIFs may attach different VLAN tags. In this case, VIFs are not guaranteed to belong to the same L2 broadcast domain. Because of that, we don't know if a peer port on the switch has the same tag used and should not allow the local responder to generate neighbour traffic.

Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for miniflow extract

Hi Eelco , Sorry the formatting seems broken on this email thread. Replies are inlined . From: Eelco Chaudron Sent: Tuesday, June 29, 2021 7:36 PM To: Amber, Kumar Cc: Van Haaren, Harry ; d...@openvswitch.org; i.maxim...@ovn.org; Stokes, Ian ; Flavio Leitner Subject: Re: [ovs-dev] [v4

[ovs-dev] [PATCH ovn] northd-ddlog: Add proxy arp flows for configured addresses in lsp router port.

From: Numan Siddique The commit [1] didn't add the ddlog part. [1] - 8087cbc7462("ovn-northd.c: Add proxy ARP support to OVN") Signed-off-by: Numan Siddique --- northd/ovn.dl| 1 + northd/ovn.rs| 13 + northd/ovn_northd.dl | 38

Re: [ovs-dev] Openvswitch patch doubts:conntrack: Fix missed 'conn' lookup checks.

On Mon, Jun 28, 2021 at 11:45:11AM +0800, user wrote: > I think this situation may not happen, because if there are two pkts > are going to create the same conntrack, their headers will be roughly > the same, the rss of the hardware will assign the packets to the same > cpu, so there is no chance

Re: [ovs-dev] [PATCH v7 1/4] conntrack: handle already natted packets

Dumitru Ceara writes: > On 6/25/21 2:01 PM, Paolo Valerio wrote: >> Dumitru Ceara writes: >> >>> On 6/21/21 12:06 PM, Paolo Valerio wrote: when a packet gets dnatted and then recirculated, it could be possible that it matches another rule that performs another nat action. The

Re: [ovs-dev] [PATCH] reconnect: Add graceful reconnect.

On Tue, Jun 29, 2021 at 01:20:35PM +0200, Dumitru Ceara wrote: > Until now clients that needed to reconnect immediately could only use > reconnect_force_reconnect(). However, reconnect_force_reconnect() > doesn't reset the backoff for connections that were alive long enough > (more than backoff

Re: [ovs-dev] [v4 06/12] dpif-netdev: Add additional packet count parameter for study function

Hi Eelco, Replies are inline. > > +++ b/Documentation/topics/dpdk/bridge.rst > > @@ -288,7 +288,13 @@ An implementation can be selected manually by > the following command :: > > Also user can select the study implementation which studies the > > traffic for a specific number of packets by

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

On Tue, Jun 29, 2021 at 12:56:18PM +0200, Ilya Maximets wrote: > If a new database server added to the cluster, or if one of the > database servers changed its IP address or port, then you need to > update the list of remotes for the client. For example, if a new > OVN_Southbound database server

Re: [ovs-dev] "Why perthread->mutex is needed?"

On Tue, Jun 29, 2021 at 09:49:39PM +0800, 贺鹏 wrote: > I am investigating the OVS RCU code, and feel confused about the > perthread->mutex, what's the usage of this mutex? it seems in the code > there are only codes that inits and destroys the mutex, but there is > no code that locks and unlocks

[ovs-dev] [PATCH] ovs-rcu: Remove unneeded mutex from struct ovsrcu_perthread.

It was not really used. Signed-off-by: Ben Pfaff Reported-by: 贺鹏 --- lib/ovs-rcu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/ovs-rcu.c b/lib/ovs-rcu.c index cde1e925ba94..1866bd308822 100644 --- a/lib/ovs-rcu.c +++ b/lib/ovs-rcu.c @@ -47,7 +47,6 @@ struct ovsrcu_cbset { struct

[ovs-dev] Fwd: "Why perthread->mutex is needed?"

-- 转发的邮件 -- 发件人： *贺鹏* 日期： 2021年6月29日星期二 主题： "Why perthread->mutex is needed?" 收件人： Sriharsha Basavapatna via dev , Ben Pfaff < b...@ovn.org> Hi，Ben, I am investigating the OVS RCU code, and feel confused about the perthread->mutex, what's the usage of this mutex? it seems in

Re: [ovs-dev] [v4 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

> -Original Message- > From: Eelco Chaudron > Sent: Tuesday, June 29, 2021 2:56 PM > To: Amber, Kumar > Cc: Van Haaren, Harry ; d...@openvswitch.org; > i.maxim...@ovn.org; Flavio Leitner > Subject: Re: [ovs-dev] [v4 01/12] dpif-netdev: Add command line and function > pointer for

Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for miniflow extract

Hi Flavio, Replies inline. > > > > Guess the above needs to be atomic. > > > > Removed based on Flavio comments. > > I asked to initialize that using an API and Eelco is asking to set it > atomically. > The requests are complementary, right? > Yes True sorry for confusion so we have

Re: [ovs-dev] [PATCH v3 0/2] add port-based ingress policing based packet-per-second rate-limiting

On Wed, Jun 23, 2021 at 03:47:45PM +0200, Simon Horman wrote: > On Wed, Jun 09, 2021 at 11:52:07AM +0200, Simon Horman wrote: > > Hi, > > > > this short test adds support for add port-based ingress policing based > > packet-per-second rate-limiting. This builds on existing support for > >

Re: [ovs-dev] [PATCH v10] ofproto-dpif: APIs and CLI option to add/delete static fdb entry

On 29 Jun 2021, at 15:19, Vasu Dasari wrote: > Currently there is an option to add/flush/show ARP/ND neighbor. This covers L3 > side. For L2 side, there is only fdb show command. This patch gives an option > to add/del an fdb entry via ovs-appctl. > > CLI command looks like: > > To add: >

Re: [ovs-dev] [v4 10/12] dpif-netdev/mfex: Add AVX512 based optimized miniflow extract

Hi Flavio, Pls find my replies inline. > -Original Message- > From: Flavio Leitner > Sent: Tuesday, June 29, 2021 6:50 PM > To: Amber, Kumar > Cc: d...@openvswitch.org; i.maxim...@ovn.org > Subject: Re: [ovs-dev] [v4 10/12] dpif-netdev/mfex: Add AVX512 based > optimized miniflow

Re: [ovs-dev] [v4 09/12] dpdk: add additional CPU ISA detection strings

On 17 Jun 2021, at 18:27, Kumar Amber wrote: > From: Harry van Haaren > > This commit enables OVS to at runtime check for more detailed > AVX512 capabilities, specifically Byte and Word (BW) extensions, > and Vector Bit Manipulation Instructions (VBMI). > > These instructions will be used in

Re: [ovs-dev] [v4 07/12] test/sytem-dpdk: Add unit test for mfex autovalidator

On Tue, Jun 29, 2021 at 03:50:22PM +0200, Eelco Chaudron wrote: > > > On 28 Jun 2021, at 4:57, Flavio Leitner wrote: > > > Hi, > > > > > > On Thu, Jun 17, 2021 at 09:57:49PM +0530, Kumar Amber wrote: > >> Tests: > >> 6: OVS-DPDK - MFEX Autovalidator > >> 7: OVS-DPDK - MFEX Autovalidator

Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for miniflow extract

Not sure how you replied, but it’s hard to see which comments are mine, and which are yours. On 29 Jun 2021, at 14:27, Amber, Kumar wrote: Hi Eelco, Thanks Again for reviews , Pls find my replies inline. From: Eelco Chaudron Sent: Tuesday, June 29, 2021 5:14 PM To: Van Haaren, Harry ;

Re: [ovs-dev] [PATCH ovn v3 1/3] ovn-northd: Remove lflow_add_unique.

On 6/21/21 8:51 AM, Han Zhou wrote: > This patch removes the workaround when adding multicast group related > lflows, because the multicast group dependency problem is fixed in > ovn-controller in the previous commit. > > This patch also removes the UniqueFlow/AnnotatedFlow usage in northd >

Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for miniflow extract

Hi, On Tue, Jun 29, 2021 at 12:27:57PM +, Amber, Kumar wrote: > Hi Eelco, > > Thanks Again for reviews , Pls find my replies inline. > > From: Eelco Chaudron > Sent: Tuesday, June 29, 2021 5:14 PM > To: Van Haaren, Harry ; Amber, Kumar > > Cc: d...@openvswitch.org; i.maxim...@ovn.org;

Re: [ovs-dev] [PATCH v3] flow: Read recirc depth and flow api enabled once per batch in miniflow_extract

On 6/29/21 7:35 AM, Eli Britstein wrote: > > On 6/28/2021 6:19 PM, Balazs Nemeth wrote: >> External email: Use caution opening links or attachments >> >> >> The call to recirc_depth_get involves accessing a TLS value. So read >> that once, and store it on the stack for re-use while processing the

Re: [ovs-dev] [v4 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

On 29 Jun 2021, at 13:59, Amber, Kumar wrote: > Hi Eelco, > > Thanks a lot for the comments and my replies are inline. > >>> +return; >>> +} >>> + >>> +/* Add all mfex functions to reply string. */ >>> +struct ds reply = DS_EMPTY_INITIALIZER; >>> +ds_put_cstr(,

Re: [ovs-dev] [v4 07/12] test/sytem-dpdk: Add unit test for mfex autovalidator

On 28 Jun 2021, at 4:57, Flavio Leitner wrote: > Hi, > > > On Thu, Jun 17, 2021 at 09:57:49PM +0530, Kumar Amber wrote: >> Tests: >> 6: OVS-DPDK - MFEX Autovalidator >> 7: OVS-DPDK - MFEX Autovalidator Fuzzy >> >> Added a new directory to store the PCAP file used >> in the tests and a

[ovs-dev] "Why perthread->mutex is needed?"

Hi，Ben, I am investigating the OVS RCU code, and feel confused about the perthread->mutex, what's the usage of this mutex? it seems in the code there are only codes that inits and destroys the mutex, but there is no code that locks and unlocks it. Thanks. -- hepeng

Re: [ovs-dev] [v4 10/12] dpif-netdev/mfex: Add AVX512 based optimized miniflow extract

Hi, On Thu, Jun 17, 2021 at 09:57:52PM +0530, Kumar Amber wrote: > From: Harry van Haaren > > This commit adds AVX512 implementations of miniflow extract. > By using the 64 bytes available in an AVX512 register, it is > possible to convert a packet to a miniflow data-structure in > a small

Re: [ovs-dev] [External] : Re: [PATCH ovn v5] ovn-northd.c: Add proxy ARP support to OVN

On 29/06/2021 13:24, Numan Siddique wrote: On Tue, Jun 29, 2021 at 7:48 AM Brendan Doyle wrote: Numan, Did this version apply ? I'm guessing not. This was generated with git mail. But I don't see an entry in

[ovs-dev] [PATCH v10] ofproto-dpif: APIs and CLI option to add/delete static fdb entry

Currently there is an option to add/flush/show ARP/ND neighbor. This covers L3 side. For L2 side, there is only fdb show command. This patch gives an option to add/del an fdb entry via ovs-appctl. CLI command looks like: To add: ovs-appctl fdb/add ovs-appctl fdb/add br0 p1 0

Re: [ovs-dev] [v4 06/12] dpif-netdev: Add additional packet count parameter for study function

See some additional comments below. //Eelco On 17 Jun 2021, at 18:27, Kumar Amber wrote: > This commit introduces additonal command line paramter > for mfex study function. If user provides additional packet out > it is used in study to compare minimum packets which must be processed > else a

Re: [ovs-dev] [v4 03/12] dpif-netdev: Add study function to select the best mfex function

More comments below. FYI I’m only reviewing right now, no testing. //Eelco On 17 Jun 2021, at 18:27, Kumar Amber wrote: > The study function runs all the available implementations > of miniflow_extract and makes a choice whose hitmask has > maximum hits and sets the mfex to that function. > >

Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for miniflow extract

Hi Eelco, Thanks Again for reviews , Pls find my replies inline. From: Eelco Chaudron Sent: Tuesday, June 29, 2021 5:14 PM To: Van Haaren, Harry ; Amber, Kumar Cc: d...@openvswitch.org; i.maxim...@ovn.org; Stokes, Ian ; Flavio Leitner Subject: Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto

Re: [ovs-dev] [PATCH ovn v5] ovn-northd.c: Add proxy ARP support to OVN

On Tue, Jun 29, 2021 at 7:48 AM Brendan Doyle wrote: > > Numan, > > Did this version apply ? I'm guessing not. This was generated with git > mail. But I don't see > an entry in https://patchwork.ozlabs.org/project/ovn/list/ > for it. Please let me know if this has issue, if so I'll try generate a

Re: [ovs-dev] [PATCH 4/4] dpif-netdev: Allow cross-NUMA polling on selected ports

Bleep bloop. Greetings , I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Jan

Re: [ovs-dev] [PATCH 3/4] dpif-netdev: pmd-rxq-affinity with optional PMD isolation

Bleep bloop. Greetings , I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Jan

Re: [ovs-dev] [PATCH 2/4] dpif-netdev: Least-loaded scheduling algorithm for rxqs

Bleep bloop. Greetings , I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Jan

Re: [ovs-dev] [PATCH 1/4] dpif-netdev: Refactor rxq auto-lb dry-run code.

Bleep bloop. Greetings , I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Jan

Re: [ovs-dev] [PATCH v5 ovn 3/4] ovn-northd: Add CoPP policies for flows that punt packets to ovn-controller.

On 23/06/2021 12:05, Lorenzo Bianconi wrote: > From: Dumitru Ceara > > Change the ovn-northd implementation to set the new 'controller_meter' > field for flows that need to punt packets to ovn-controller. > > Protocol packets for which CoPP is enforced when sending packets to > ovn-controller

Re: [ovs-dev] [v4 01/12] dpif-netdev: Add command line and function pointer for miniflow extract

Hi Eelco, Thanks a lot for the comments and my replies are inline. > -Original Message- > From: Eelco Chaudron > Sent: Tuesday, June 29, 2021 2:59 PM > To: Amber, Kumar ; Van Haaren, Harry > > Cc: d...@openvswitch.org; i.maxim...@ovn.org; Flavio Leitner > > Subject: Re: [ovs-dev] [v4

Re: [ovs-dev] Fwd: Openvswitch patch doubts:conntrack: Fix missed 'conn' lookup checks.

On 6/29/21 8:51 AM, user wrote: > Hi Gaetan, >Thanks for your resolve. It is indeed possible for tunneled packets to be > allocated to different CPUs by RSS, in which case a check before adding > connTrack is necessary. >And I didn't made it clear that the two packets belong to the same

Re: [ovs-dev] [PATCH V7 00/13] Netdev vxlan-decap offload

> -Original Message- > From: Ilya Maximets > Sent: Monday, June 28, 2021 3:33 PM > To: Van Haaren, Harry ; Ilya Maximets > ; Sriharsha Basavapatna > > Cc: Eli Britstein ; ovs dev ; Ivan > Malov > ; Majd Dibbiny ; Stokes, Ian > ; Ferriter, Cian ; Ben Pfaff > ; Balazs Nemeth > Subject:

Re: [ovs-dev] [PATCH ovn v5] ovn-northd.c: Add proxy ARP support to OVN

Numan, Did this version apply ? I'm guessing not. This was generated with git mail. But I don't see an entry in https://patchwork.ozlabs.org/project/ovn/list/ for it. Please let me know if this has issue, if so I'll try generate a PR. Thanks Brendan On 28/06/2021 12:16, Brendan Doyle

Re: [ovs-dev] [PATCH] ovsdb-cs: Avoid unnecessary re-connections when updating remotes.

On 6/29/21 12:56 PM, Ilya Maximets wrote: > If a new database server added to the cluster, or if one of the > database servers changed its IP address or port, then you need to > update the list of remotes for the client. For example, if a new > OVN_Southbound database server is added, you need to

Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for miniflow extract

On 17 Jun 2021, at 18:27, Kumar Amber wrote: This patch introduced the auto-validation function which allows users to compare the batch of packets obtained from different miniflow implementations against the linear miniflow extract and return a hitmask. The autovaidator function can be

[ovs-dev] [PATCH 4/4] dpif-netdev: Allow cross-NUMA polling on selected ports

From: Anurag Agarwal Today dpif-netdev considers PMD threads on a non-local NUMA node for automatic assignment of the rxqs of a port only if there are no local, non-isolated PMDs. On typical servers with both physical ports on one NUMA node, this often leaves the PMDs on the other NUMA node

[ovs-dev] [PATCH 3/4] dpif-netdev: pmd-rxq-affinity with optional PMD isolation

From: Anurag Agarwal In some scenarios it is beneficial for DPDK datapath performance to pin rx queues to specific PMDs, for example to allow cross-NUMA polling when both physical ports are on one NUMA node but the PMD configuration is symmetric. Today such rxq pinning unconditionally makes

[ovs-dev] [PATCH 2/4] dpif-netdev: Least-loaded scheduling algorithm for rxqs

From: Anurag Agarwal The current algorithm for balancing unpinned rxqs over non-isolated pmds assigns the rxqs in descending load order to pmds in a "zig-zag" fashion (e.g. A,B,C,C,B,A,A,B,...). This simple heuristic relies on the pmds being initially "empty" and produces optimal results only if

[ovs-dev] [PATCH 1/4] dpif-netdev: Refactor rxq auto-lb dry-run code.

From: Anurag Agarwal The current functions performing a dry-run of the allocation of non-pinned rxqs to PMDs during rxq auto load-balancing duplicate most of the code of the rxq_scheduling() function used during actual rxq reconfiguration. This is difficult to maintain and there are actually

[ovs-dev] [PATCH 0/4] dpif-netdev: rxq auto-lb improvements

From: Anurag Agarwal = Disclaimer == This patch set was prepared and verified downstream in early 2021. A very similar set of patches with auto load balance enhancements has recently been submitted by Red Hat:

[ovs-dev] [PATCH] reconnect: Add graceful reconnect.

Until now clients that needed to reconnect immediately could only use reconnect_force_reconnect(). However, reconnect_force_reconnect() doesn't reset the backoff for connections that were alive long enough (more than backoff seconds). Moreover, the reconnect library cannot determine the exact

Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for miniflow extract

On 29 Jun 2021, at 13:05, Van Haaren, Harry wrote: Hi Eelco, Would you describe the actual test being run below? I'm having a hard time figuring out what the actual datapath packet flow is. It seems strange that MFEX optimizations are affected by flow-count, that doesn't really logically

Re: [ovs-dev] [v4 02/12] dpif-netdev: Add auto validation function for miniflow extract

Hi Eelco, Would you describe the actual test being run below? I'm having a hard time figuring out what the actual datapath packet flow is. It seems strange that MFEX optimizations are affected by flow-count, that doesn't really logically make sense. Hence, some more understanding on what the

  1   2   >