Re: [ovs-dev] Dealing with extreme kernel memory leaks

2022-03-31 Thread Frode Nordahl
On Thu, Mar 31, 2022 at 5:06 PM Stéphane Graber wrote: > > On Thu, Mar 31, 2022 at 6:55 AM Ilya Maximets wrote: > > > > On 3/31/22 06:24, Stéphane Graber wrote: > > > Thanks for the patch! > > > > > > I've applied it on top of my 5.17.1 and I'm now getting a very very > > > large number of: > > >

Re: [ovs-dev] [PATCH v1] dpcls: Add the dpcls subtable lookup function in flow dump.

2022-03-31 Thread Amber, Kumar
Hi Ilya, Thanks for review comments. > -Original Message- > From: Ilya Maximets > Sent: Wednesday, March 30, 2022 10:46 PM > To: Amber, Kumar ; ovs-dev@openvswitch.org > Cc: i.maxim...@ovn.org; Ferriter, Cian ; Stokes, Ian > ; f...@sysclose.org; echau...@redhat.com; Van > Haaren, Harry

[ovs-dev] OVN weekly meeting time change

2022-03-31 Thread Mark Michelson
Hi everyone, We have a weekly OVN development meeting on Thursdays in the #openvswitch channel on the Libera.Chat IRC server. Some OVN devs found the current meeting time to be inconvenient, so during today's meeting we agreed that we would move the meeting one hour earlier than it already is

Re: [ovs-dev] [PATCH v3 8/9] netdev-offload-tc: Check for none offloadable ct_state flag combination

2022-03-31 Thread Marcelo Ricardo Leitner
On Tue, Mar 29, 2022 at 01:06:36PM +0200, Ilya Maximets wrote: > On 2/25/22 13:29, Marcelo Ricardo Leitner wrote: > > On Thu, Feb 24, 2022 at 03:20:23PM +0100, Eelco Chaudron wrote: > >> > >> > >> On 23 Feb 2022, at 17:23, Marcelo Ricardo Leitner wrote: > >> > >>> On Tue, Feb 22, 2022 at 04:26:10PM

Re: [ovs-dev] [PATCH] openvswitch: Add recirc_id to recirc warning

2022-03-31 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Wed, 30 Mar 2022 15:42:45 -0400 you wrote: > When hitting the recirculation limit, the kernel would currently log > something like this: > > [ 58.586597] openvswitch: ovs-system: deferred action limit reached, drop

Re: [ovs-dev] [PATCH] dpif-netdev: Fix dp_netdev_get_pmd() function getting correct core_id.

2022-03-31 Thread Maxime Coquelin
On 3/31/22 17:21, David Marchand wrote: On Thu, Mar 31, 2022 at 4:41 PM Eelco Chaudron wrote: The dp_netdev_get_pmd() function is using only the hash of the core_id to get the pmd structure. So in case of hash collisions, the wrong pmd is returned. This patch is fixing this by checking for

Re: [ovs-dev] [PATCH] dpif-netdev: Fix dp_netdev_get_pmd() function getting correct core_id.

2022-03-31 Thread David Marchand
On Thu, Mar 31, 2022 at 4:41 PM Eelco Chaudron wrote: > > The dp_netdev_get_pmd() function is using only the hash of the core_id > to get the pmd structure. So in case of hash collisions, the wrong pmd > is returned. > > This patch is fixing this by checking for the correct core_id using > the CMA

Re: [ovs-dev] Dealing with extreme kernel memory leaks

2022-03-31 Thread Stéphane Graber
On Thu, Mar 31, 2022 at 6:55 AM Ilya Maximets wrote: > > On 3/31/22 06:24, Stéphane Graber wrote: > > Thanks for the patch! > > > > I've applied it on top of my 5.17.1 and I'm now getting a very very > > large number of: > > > > [ 188.616220] openvswitch: netlink: ovs_ct_free_action at depth 3 >

Re: [ovs-dev] [PATCH ovn v4] northd: Add support for NAT with multiple DGP

2022-03-31 Thread Numan Siddique
On Thu, Mar 31, 2022, 8:32 AM Abhiram Sangana wrote: > Hi Numan, > > Is it ok if we make the “gateway_port” column optional in a subsequent > patch? > Will send out a v5 patch that addresses other comments. > I'm fine if you can - make the column as weak reference - and if gateway_port is not

[ovs-dev] [PATCH] dpif-netdev: Fix dp_netdev_get_pmd() function getting correct core_id.

2022-03-31 Thread Eelco Chaudron
The dp_netdev_get_pmd() function is using only the hash of the core_id to get the pmd structure. So in case of hash collisions, the wrong pmd is returned. This patch is fixing this by checking for the correct core_id using the CMAP_FOR_EACH_WITH_HASH macro. Fixes: b19befaef ("dpif-netdev: Add fu

Re: [ovs-dev] [PATCH v7 4/4] tests/mfex: Improve pcap script for mfex tests.

2022-03-31 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Wednesday 23 March 2022 12:40 > To: ovs-dev@openvswitch.org > Cc: f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian > ; Stokes, Ian > ; echau...@redhat.com; Van Haaren, Harry > ; Amber, > Kumar > Subject: [PATCH v7 4/4] tests/mfex

Re: [ovs-dev] [PATCH v7 2/4] dpif-netdev/mfex: Add packet hash check to autovalidator.

2022-03-31 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Wednesday 23 March 2022 12:40 > To: ovs-dev@openvswitch.org > Cc: f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian > ; Stokes, Ian > ; echau...@redhat.com; Van Haaren, Harry > ; Amber, > Kumar > Subject: [PATCH v7 2/4] dpif-netde

Re: [ovs-dev] [PATCH v7 3/4] dpif-netdev/mfex: Avoid hashing when opt mfex called.

2022-03-31 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Wednesday 23 March 2022 12:40 > To: ovs-dev@openvswitch.org > Cc: f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian > ; Stokes, Ian > ; echau...@redhat.com; Van Haaren, Harry > ; Amber, > Kumar > Subject: [PATCH v7 3/4] dpif-netde

Re: [ovs-dev] [PATCH v7 1/4] dpif-netdev/mfex: Add ipv4 profile based hashing.

2022-03-31 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Wednesday 23 March 2022 12:40 > To: ovs-dev@openvswitch.org > Cc: f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian > ; Stokes, Ian > ; echau...@redhat.com; Van Haaren, Harry > ; Amber, > Kumar > Subject: [PATCH v7 1/4] dpif-netde

Re: [ovs-dev] [PATCH v7 0/4] IPv4 Hashing AVX512 Optimizations

2022-03-31 Thread Ferriter, Cian
> -Original Message- > From: Amber, Kumar > Sent: Wednesday 23 March 2022 12:40 > To: ovs-dev@openvswitch.org > Cc: f...@sysclose.org; i.maxim...@ovn.org; Ferriter, Cian > ; Stokes, Ian > ; echau...@redhat.com; Van Haaren, Harry > ; Amber, > Kumar > Subject: [PATCH v7 0/4] IPv4 Hashi

Re: [ovs-dev] [PATCH ovn v4] northd: Add support for NAT with multiple DGP

2022-03-31 Thread Abhiram Sangana
Hi Numan, Is it ok if we make the “gateway_port” column optional in a subsequent patch? Will send out a v5 patch that addresses other comments. Thanks, Abhiram Sangana > On 30 Mar 2022, at 19:32, Numan Siddique wrote: > > On Wed, Mar 30, 2022 at 1:41 PM Abhiram Sangana > wrote: >> >> Hi Numa

[ovs-dev] [PATCH ovn] controller/binding: prevent claiming container lport to ovs bridge

2022-03-31 Thread Mohammad Heib
currently ovn-controller allow users to claim lport of type container to ovs bridge which is invalid use-case. This patch will prevent such invalid use-cases by ignoring the claiming requests for container lports and will throw a warning message to the controller logs. Signed-off-by: Mohammad Hei

Re: [ovs-dev] Dealing with extreme kernel memory leaks

2022-03-31 Thread Ilya Maximets
On 3/31/22 06:24, Stéphane Graber wrote: > Thanks for the patch! > > I've applied it on top of my 5.17.1 and I'm now getting a very very > large number of: > > [ 188.616220] openvswitch: netlink: ovs_ct_free_action at depth 3 > > After just 3 minutes of uptime I'm seeing 230 such lines but also

Re: [ovs-dev] [PATCH 0/2] Deprecate the Linux OOT driver

2022-03-31 Thread Ilya Maximets
On 3/30/22 22:36, Gregory Rose wrote: > > > On 3/21/2022 3:18 AM, Ilya Maximets wrote: >> On 1/6/21 20:42, Ilya Maximets wrote: >>> On 1/6/21 8:09 PM, Gregory Rose wrote: On 1/6/2021 10:55 AM, Ilya Maximets wrote: > On 1/6/21 7:09 PM, Gregory Rose wrote: >> >> >> On

Re: [ovs-dev] [PATCH] openvswitch: Add recirc_id to recirc warning

2022-03-31 Thread Eelco Chaudron
On 30 Mar 2022, at 21:42, Stéphane Graber wrote: > When hitting the recirculation limit, the kernel would currently log > something like this: > > [ 58.586597] openvswitch: ovs-system: deferred action limit reached, drop > recirc action > > Which isn't all that useful to debug as we only have

Re: [ovs-dev] [PATCH v5 00/15] Fix undefined behavior in loop macros

2022-03-31 Thread Adrian Moreno
On 3/30/22 22:35, Ilya Maximets wrote: On 3/23/22 12:56, Adrian Moreno wrote: When running builds with UBSan, some undefined behavior was detected in the iteration of common data data structures in OVS. Coincidentally, a bug was reported [1] whose root cause whas another, this time undetecte