Re: [ovs-dev] [PATCH V2] xenserver: Remove xenserver

2022-08-25 Thread Gregory Rose
On 8/22/2022 7:15 AM, David Marchand wrote: On Mon, Aug 15, 2022 at 1:49 PM Ilya Maximets wrote: On 8/8/22 22:36, Greg Rose wrote: Remove the current xenserver implementation - it is obsolete and since 3.0 we do not support kernel module builds [1]. 1. https://mail.openvswitch.org/piperma

Re: [ovs-dev] [PATCH] xenserver: Remove xenserver

2022-07-29 Thread Gregory Rose
On 7/29/2022 6:52 AM, David Marchand wrote: Hello Greg, On Wed, Jul 27, 2022 at 7:37 PM Greg Rose wrote: Remove the current xenserver implementation - it is obsolete and since 3.0 we do not support kernel module builds [1]. 1. https://mail.openvswitch.org/pipermail/ovs-dev/2022-July/395

Re: [ovs-dev] [PATCH v4 9/9] debian: Add option to build without DPDK.

2022-07-18 Thread Gregory Rose
On 7/15/2022 4:01 AM, Ilya Maximets wrote: On 7/15/22 10:53, Ilya Maximets wrote: On 7/15/22 05:04, Gregory Rose wrote: On 7/14/2022 6:45 PM, Ilya Maximets wrote: On 7/14/22 17:55, Frode Nordahl wrote: From: Ilya Maximets Signed-off-by: Ilya Maximets Co-authored-by: Frode Nordahl

Re: [ovs-dev] [PATCH V6 0/6] Remove OVS kernel driver

2022-07-15 Thread Gregory Rose
On 7/15/2022 5:18 AM, Ilya Maximets wrote: On 7/14/22 23:23, Greg Rose wrote: It is time to remove support for the ovs kernel driver and push towards use of the upstream linux openvswitch kernel driver in it's place [1]. 1. https://mail.openvswitch.org/pipermail/ovs-dev/2022-april/393292.ht

Re: [ovs-dev] [PATCH v4 9/9] debian: Add option to build without DPDK.

2022-07-14 Thread Gregory Rose
On 7/14/2022 6:45 PM, Ilya Maximets wrote: On 7/14/22 17:55, Frode Nordahl wrote: From: Ilya Maximets Signed-off-by: Ilya Maximets Co-authored-by: Frode Nordahl Signed-off-by: Frode Nordahl --- .ci/linux-build.sh | 6 ++- .github/workflows/build-and-test.yml | 1

Re: [ovs-dev] [PATCH V5 4/6] Make: Remove the Linux datapath.

2022-07-13 Thread Gregory Rose
On 7/13/2022 4:52 PM, Ilya Maximets wrote: On 7/14/22 01:05, 0-day Robot wrote: Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: mv tests/testsuite

Re: [ovs-dev] [PATCH V4 0/8] Remove OVS kernel driver

2022-07-12 Thread Gregory Rose
On 7/12/2022 2:02 PM, David Marchand wrote: On Tue, Jul 12, 2022 at 7:58 PM Greg Rose wrote: It is time to remove support for the ovs kernel driver and push towards use of the upstream linux openvswitch kernel driver in it's place [1]. 1. https://mail.openvswitch.org/pipermail/ovs-dev/202

Re: [ovs-dev] [PATCH V4 7/8] Documentation: Remove kernel module documentation

2022-07-12 Thread Gregory Rose
On 7/12/2022 1:50 PM, David Marchand wrote: On Tue, Jul 12, 2022 at 8:07 PM Gregory Rose wrote: On 7/12/2022 10:56 AM, Greg Rose wrote: As of Open vSwitch release 2.18 the OVS kernel module is no longer supported. Pull the documentation references. Signed-off-by: Greg Rose

Re: [ovs-dev] [PATCH V4 6/8] acinclude.m4: Remove support for building the OVS kernel module

2022-07-12 Thread Gregory Rose
On 7/12/2022 1:49 PM, David Marchand wrote: On Tue, Jul 12, 2022 at 7:58 PM Greg Rose wrote: Since the openvswitch project inception it has had support for building a Linux kernel module to support the OVS kernel datapath. Since Linux kernel release 5.8 support for newer kernels has been d

Re: [ovs-dev] [PATCH V4 4/8] Make: Remove the Linux datapath

2022-07-12 Thread Gregory Rose
On 7/12/2022 1:35 PM, David Marchand wrote: build-aux/initial-tab-allowed-files is updated in patch 5, so I'd expect a build check failure at this point of the series as mentionned in v3. On 7/12/22 19:56, Greg Rose wrote: diff --git a/Makefile.am b/Makefile.am index cb8076433..eda0d91eb 100

Re: [ovs-dev] [PATCH V4 3/8] tests: Remove support for check-kmod test

2022-07-12 Thread Gregory Rose
On 7/12/2022 1:27 PM, David Marchand wrote: On Tue, Jul 12, 2022 at 8:01 PM Greg Rose wrote: The OVS kernel module is no longer supported as of OVS 2.18 Signed-off-by: Greg Rose With a '.' at the end of the title: Reviewed-by: David Marchand Will do. - Greg ___

Re: [ovs-dev] [PATCH V4 2/8] rhel: Remove kernel mode spec

2022-07-12 Thread Gregory Rose
On 7/12/2022 1:26 PM, David Marchand wrote: On Tue, Jul 12, 2022 at 8:03 PM Greg Rose wrote: Remove the kernel driver specification for RHEL 6.x, 7.x, 8.x and Fedora. Signed-off-by: Greg Rose The patch lgtm. I suggest a title like: rhel: Stop packaging OVS kernel module. You can add: R

Re: [ovs-dev] [PATCH V4 1/8] Disable unsupported kernel builds

2022-07-12 Thread Gregory Rose
On 7/12/2022 1:12 PM, David Marchand wrote: On Tue, Jul 12, 2022 at 7:58 PM Greg Rose wrote: Remove kernel based github workflows since the OVS kernel driver is no longer supported since Release 2.18 Signed-off-by: Greg Rose Just one last nit on the title. We are still building a part o

Re: [ovs-dev] [PATCH V4 4/8] Make: Remove the Linux datapath

2022-07-12 Thread Gregory Rose
On 7/12/2022 11:25 AM, 0-day Robot wrote: Bleep bloop. Greetings Gregory Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: mv tests/testsuite.tmp tests/testsuite /bin/sh

Re: [ovs-dev] [PATCH V4 1/8] Disable unsupported kernel builds

2022-07-12 Thread Gregory Rose
On 7/12/2022 10:56 AM, Greg Rose wrote: Remove kernel based github workflows since the OVS kernel driver is no longer supported since Release 2.18 Signed-off-by: Greg Rose This patch should actually have David Marchand as a co-author. I'll fix that up next rev. - Greg --- .ci/linux-b

Re: [ovs-dev] [PATCH V4 7/8] Documentation: Remove kernel module documentation

2022-07-12 Thread Gregory Rose
On 7/12/2022 10:56 AM, Greg Rose wrote: As of Open vSwitch release 2.18 the OVS kernel module is no longer supported. Pull the documentation references. Signed-off-by: Greg Rose --- Documentation/faq/releases.rst| 4 +- .../contributing/backporting-patches.rst | 7

Re: [ovs-dev] [PATCH V3 7/7] Documentation: Remove kernel module documentation

2022-07-11 Thread Gregory Rose
On 7/9/2022 12:31 AM, David Marchand wrote: On Fri, Jul 8, 2022 at 10:09 PM Greg Rose wrote: diff --git a/Documentation/internals/contributing/backporting-patches.rst b/Documentation/internals/contributing/backporting-patches.rst index 162e9d209..8370c954d 100644 --- a/Documentation/interna

Re: [ovs-dev] [PATCH V3 6/7] acinclude.m4: Remove support for building the OVS kernel module

2022-07-11 Thread Gregory Rose
On 7/9/2022 12:27 AM, David Marchand wrote: On Fri, Jul 8, 2022 at 10:10 PM Greg Rose wrote: Since the openvswitch project inception it has had support for building a Linux kernel module to support the OVS kernel datapath. Since Linux kernel release 5.8 support for newer kernels has been d

Re: [ovs-dev] [PATCH V3 5/7] tests: Remove support for check-kmod test

2022-07-11 Thread Gregory Rose
On 7/9/2022 12:23 AM, David Marchand wrote: On Fri, Jul 8, 2022 at 10:05 PM Greg Rose wrote: The OVS kernel module is no longer supported as of OVS 2.18 Signed-off-by: Greg Rose This leaves behind some reference in the documentation. WDYT of: diff --git a/Documentation/topics/testing.

Re: [ovs-dev] [PATCH V3 4/7] Make: Remove the Linux datapath

2022-07-11 Thread Gregory Rose
On 7/9/2022 12:20 AM, David Marchand wrote: On Fri, Jul 8, 2022 at 10:11 PM Greg Rose wrote: Update the necessary make and configure files to remove the Linux datapath and then remove the datapath. Move datapath/linux/compat/include/linux/openvswitch.h to include/linux/openvswitch.h becaus

Re: [ovs-dev] [PATCH V3 3/7] aux:utilities: Remove references to the Linux datapath

2022-07-11 Thread Gregory Rose
On 7/9/2022 12:09 AM, David Marchand wrote: On Fri, Jul 8, 2022 at 10:29 PM Gregory Rose wrote: On 7/8/2022 1:03 PM, Greg Rose wrote: Remove references to the Linux datapath from auxiliary files and utilities since it is no longer supported. Signed-off-by: Greg Rose --- build-aux

Re: [ovs-dev] [PATCH V3 2/7] rhel: Remove kernel mode spec

2022-07-11 Thread Gregory Rose
On 7/9/2022 12:02 AM, David Marchand wrote: On Fri, Jul 8, 2022 at 10:04 PM Greg Rose wrote: Remove the kernel driver specification for RHEL 6.x, 7.x, 8.x and Fedora. Signed-off-by: Greg Rose --- Documentation/intro/install/rhel.rst | 18 Vagrantfile |

Re: [ovs-dev] [PATCH V3 1/7] Disable unsupported kernel builds

2022-07-11 Thread Gregory Rose
On 7/8/2022 11:26 PM, David Marchand wrote: On Fri, Jul 8, 2022 at 10:06 PM Greg Rose wrote: Remove kernel based github workflows since the OVS kernel driver is no longer supported since Release 2.18 I won't comment on the debian parts, those are handled by Frode series. This patch remov

Re: [ovs-dev] [PATCH V3 3/7] aux:utilities: Remove references to the Linux datapath

2022-07-08 Thread Gregory Rose
On 7/8/2022 1:03 PM, Greg Rose wrote: Remove references to the Linux datapath from auxiliary files and utilities since it is no longer supported. Signed-off-by: Greg Rose --- build-aux/initial-tab-allowed-files | 1 - utilities/docker/debian/build-kernel-modules.sh | 13 -

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

2022-07-08 Thread Gregory Rose
On 7/8/2022 12:00 PM, Ilya Maximets wrote: On 7/8/22 17:37, Ben Pfaff wrote: On Fri, Jul 8, 2022 at 1:53 AM David Marchand mailto:david.march...@redhat.com>> wrote: On Thu, Jul 7, 2022 at 11:21 PM Gregory Rose mailto:gvrose8...@gmail.com>> wrote: > > xen

Re: [ovs-dev] [PATCH V2 3/8] rhel: Remove RHEL 6 kernel module spec

2022-07-08 Thread Gregory Rose
On 7/8/2022 9:14 AM, Greg Rose wrote: Remove the RHEL 6 kernel driver module specification. Signed-off-by: Greg Rose --- Documentation/intro/install/rhel.rst | 18 poc/playbook-centos-builder.yml | 8 -- rhel/automake.mk | 10 --- rhel/kmod-openvswitch-

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

2022-07-07 Thread Gregory Rose
On 7/7/2022 4:53 AM, David Marchand wrote: On Wed, Jul 6, 2022 at 6:57 PM Greg Rose wrote: It is time to remove support for the OVS kernel driver and push towards use of the upstream Linux openvswitch kernel driver in it's place [1]. There are many Linux specific source modules in the data

Re: [ovs-dev] [PATCH 3/6] rhel: Remove RHEL 6 kernel module spec

2022-07-07 Thread Gregory Rose
On 7/7/2022 4:34 AM, David Marchand wrote: On Wed, Jul 6, 2022 at 7:05 PM Greg Rose wrote: Remove the RHEL 6 kernel driver module specification. Signed-off-by: Greg Rose --- rhel/automake.mk| 5 -- rhel/kmod-openvswitch-rhel6.spec.in | 123

Re: [ovs-dev] [PATCH 3/6] rhel: Remove RHEL 6 kernel module spec

2022-07-07 Thread Gregory Rose
On 7/7/2022 4:34 AM, David Marchand wrote: On Wed, Jul 6, 2022 at 7:05 PM Greg Rose wrote: Remove the RHEL 6 kernel driver module specification. Signed-off-by: Greg Rose --- rhel/automake.mk| 5 -- rhel/kmod-openvswitch-rhel6.spec.in | 123

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

2022-07-07 Thread Gregory Rose
On 7/7/2022 2:30 AM, Ilya Maximets wrote: On 7/7/22 10:27, David Marchand wrote: Hi Greg, On Wed, Jul 6, 2022 at 11:57 PM Gregory Rose wrote: On 7/6/2022 9:57 AM, Greg Rose wrote: It is time to remove support for the OVS kernel driver and push towards use of the upstream Linux

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

2022-07-07 Thread Gregory Rose
On 7/7/2022 1:27 AM, David Marchand wrote: Hi Greg, On Wed, Jul 6, 2022 at 11:57 PM Gregory Rose wrote: On 7/6/2022 9:57 AM, Greg Rose wrote: It is time to remove support for the OVS kernel driver and push towards use of the upstream Linux openvswitch kernel driver in it's pla

Re: [ovs-dev] [PATCH 0/6] Remove OVS kernel driver

2022-07-06 Thread Gregory Rose
On 7/6/2022 9:57 AM, Greg Rose wrote: It is time to remove support for the OVS kernel driver and push towards use of the upstream Linux openvswitch kernel driver in it's place [1]. There are many Linux specific source modules in the datapath that will need eventual removal but some headers ar

Re: [ovs-dev] [RFC PATCH 0/6] Remove OVS kernel driver

2022-07-05 Thread Gregory Rose
On 6/29/2022 3:42 PM, Ilya Maximets wrote: On 6/10/22 02:31, Frode Nordahl wrote: On Fri, Jun 3, 2022 at 4:16 PM Frode Nordahl wrote: On Thu, Jun 2, 2022 at 6:58 PM Ilya Maximets wrote: On 6/1/22 22:53, Gregory Rose wrote: On 5/31/2022 12:22 PM, Frode Nordahl wrote: On Tue, May 31

Re: [ovs-dev] [RFC PATCH 0/6] Remove OVS kernel driver

2022-06-01 Thread Gregory Rose
On 5/31/2022 12:22 PM, Frode Nordahl wrote: On Tue, May 31, 2022 at 7:05 PM Ilya Maximets wrote: On 5/31/22 17:36, Gregory Rose wrote: On 5/25/2022 6:47 AM, Flavio Leitner wrote: Hi Greg, On Mon, May 23, 2022 at 09:10:36PM +0200, Ilya Maximets wrote: On 5/19/22 20:04, Gregory Rose

Re: [ovs-dev] [RFC PATCH 0/6] Remove OVS kernel driver

2022-05-31 Thread Gregory Rose
On 5/25/2022 6:47 AM, Flavio Leitner wrote: Hi Greg, On Mon, May 23, 2022 at 09:10:36PM +0200, Ilya Maximets wrote: On 5/19/22 20:04, Gregory Rose wrote: On 4/15/2022 2:42 PM, Greg Rose wrote: It is time to remove support for the OVS kernel driver and push towards use of the upstream

Re: [ovs-dev] [RFC PATCH 0/6] Remove OVS kernel driver

2022-05-19 Thread Gregory Rose
On 4/15/2022 2:42 PM, Greg Rose wrote: It is time to remove support for the OVS kernel driver and push towards use of the upstream Linux openvswitch kernel driver in it's place [1]. This patch series represents a first attempt but there are a few primary remaining issues that I have yet to ad

Re: [ovs-dev] [RFC PATCH 6/6] Disable unsupported kernel builds

2022-05-03 Thread Gregory Rose
On 4/26/2022 9:35 AM, Gregory Rose wrote: On 4/22/2022 8:34 AM, David Marchand wrote: On Fri, Apr 22, 2022 at 9:24 AM Dumitru Ceara wrote: @@ -37,14 +30,6 @@ jobs:     - compiler: clang   opts: --disable-ssl -  - compiler: gcc

Re: [ovs-dev] [RFC PATCH 6/6] Disable unsupported kernel builds

2022-04-26 Thread Gregory Rose
On 4/22/2022 8:34 AM, David Marchand wrote: On Fri, Apr 22, 2022 at 9:24 AM Dumitru Ceara wrote: @@ -37,14 +30,6 @@ jobs: - compiler: clang opts: --disable-ssl - - compiler: gcc -testsuite:test -kernel: 3.1

Re: [ovs-dev] [PATCH 0/2] Deprecate the Linux OOT driver

2022-04-12 Thread Gregory Rose
ll post the RFC patches and get the conversation started by Friday this week (ends 4/15/22) and we'll see how it goes. Thanks, - Greg On 3/30/2022 1:36 PM, Gregory Rose wrote: On 3/21/2022 3:18 AM, Ilya Maximets wrote: On 1/6/21 20:42, Ilya Maximets wrote: On 1/6/21 8:09 PM, Gregory R

Re: [ovs-dev] [PATCH 0/2] Deprecate the Linux OOT driver

2022-03-30 Thread Gregory Rose
On 3/21/2022 3:18 AM, Ilya Maximets wrote: On 1/6/21 20:42, Ilya Maximets wrote: On 1/6/21 8:09 PM, Gregory Rose wrote: On 1/6/2021 10:55 AM, Ilya Maximets wrote: On 1/6/21 7:09 PM, Gregory Rose wrote: On 1/6/2021 4:34 AM, Ilya Maximets wrote: On 1/5/21 7:33 PM, Greg Rose wrote: As

Re: [ovs-dev] [PATCH v1] ofp-packet: Silence the 'may be uninitialized' warning.

2022-02-25 Thread Gregory Rose
On 2/25/2022 12:02 PM, Mike Pattrick wrote: GCC 11.2.1-2.2 emits a false-positive warnings like: lib/ofp-packet.c: In function 'ofputil_decode_packet_in': lib/ofp-packet.c:155:25: warning: 'reason' may be used uninitialized [-Wmaybe-uninitialized] lib/ofp-packet.c: In function 'ofputil_d

Re: [ovs-dev] [PATCH] acinclude: Detect avx512 vpopcntdq compiler support.

2022-01-27 Thread Gregory Rose
On 1/26/2022 7:45 PM, William Tu wrote: Ubuntu Xenial 16.04 is using GCC 5.4 and it does not support target "-mavx512vpopcntdq" and cuases error lib/dpif-netdev-lookup-avx512-gather.c:356:47: error: attribute(target("avx512vpopcntdq")) is unknown GCC 7+ supports vpopcntdq: https://gcc.gnu

Re: [ovs-dev] [PATCH] datapath: fix crash when ipv6 fragment pkt recalculate L4 checksum

2021-12-06 Thread Gregory Rose
On 11/30/2021 10:16 PM, zhounan (E) via dev wrote: From: Zhou Nan When we set ipv6 addr, we need to recalculate checksum of L4 header. In our testcase, after send ipv6 fragment package, KASAN detect "use after free" when calling function update_ipv6_checksum, and crash occurred after a whil

Re: [ovs-dev] [PATCH] compat: handle NF_REPEAT error on nf_conntrack_in

2021-12-06 Thread Gregory Rose
On 11/26/2021 12:59 PM, Vladislav Odintsov wrote: In patch [1] rpl_nf_conntrack_in was backported as static inline function without do..while loop handling NF_REPEAT error. In patch [2] rpl_nf_conntrack_in backported function was removed from compat/include/net/netfilter/nf_conntrack_core.h as

Re: [ovs-dev] problem: long tcp session instantiation with conntrack and OOT ovs kmod

2021-11-03 Thread Gregory Rose
On 11/2/2021 9:50 AM, Vladislav Odintsov wrote: Hi, it’s just a quick reminder, that if you know how to debug/fix this, please let me know. Thanks. Regards, Vladislav Odintsov Hi Vladislav, I'm very short on time at my day job right now and haven't had a chance to consider this issue. I'

Re: [ovs-dev] [PATCH] correct macro name

2021-09-13 Thread Gregory Rose
On 9/13/2021 6:33 AM, chengtcli--- via dev wrote: From: lic121 fix macro name from "VLXAN_GPE_FLAGS_P" to "VXLAN_GPE_FLAGS_P" Signed-off-by: lic121 --- lib/packets.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/packets.h b/lib/packets.h index 515bb59..e8bdf08

Re: [ovs-dev] OpenFlow Experimenters in 2.15+

2021-09-10 Thread Gregory Rose
On 9/9/2021 11:06 PM, Timofei D wrote: Hello, I'm writing OF Experimenters for the ovs. There is a deprecation warning while building the source code that says: "Starting with Open vSwitch 2.15, building the Linux kernel module from the Open vSwitch source tree is deprecated. It will not be u

Re: [ovs-dev] [PATCH] rhel: Fix dual kernel rpm install for RHEL 8.4

2021-09-08 Thread Gregory Rose
On 9/8/2021 9:05 AM, Timothy Redaelli wrote: On Mon, Aug 23, 2021 at 6:33 PM Greg Rose wrote: RHEL 8.4 is the first of the RHEL 8.x kernels that has broken ABI so it requires the same sort of fix as we did for several RHEL 7.x kernel that needed two kernel rpms to work for all minor revisio

Re: [ovs-dev] [PATCH] rhel: Fix dual kernel rpm install for RHEL 8.4

2021-09-07 Thread Gregory Rose
Thanks William! On 9/3/2021 8:43 PM, William Tu wrote: On Wed, Aug 25, 2021 at 3:08 PM Gregory Rose wrote: On 8/25/2021 11:42 AM, Yifeng Sun wrote: LGTM, thanks Greg. Reviewed-by: Yifeng Sun Thanks, I pushed to master. William ___ dev

Re: [ovs-dev] [PATCH] rhel: Fix dual kernel rpm install for RHEL 8.4

2021-08-25 Thread Gregory Rose
On 8/25/2021 11:42 AM, Yifeng Sun wrote: LGTM, thanks Greg. Reviewed-by: Yifeng Sun Thanks Yifeng! - Greg On Mon, Aug 23, 2021 at 9:33 AM Greg Rose wrote: RHEL 8.4 is the first of the RHEL 8.x kernels that has broken ABI so it requires the same sort of fix as we did for several RHEL

Re: [ovs-dev] [PATCH] dpif-netlink: "bonding_masters" is a reserved name

2021-06-24 Thread Gregory Rose
On 6/23/2021 6:35 AM, Ilya Maximets wrote: On 6/23/21 2:12 PM, Timothy Redaelli wrote: Currently, on Linux, if you try to create a system datapath called "bonding_masters", when you have bonding module loaded, you have a kernel trace ("sysfs: cannot create duplicate filename '/class/net/bondi

Re: [ovs-dev] [PATCH] dpif-netlink: "bonding_masters" is a reserved name

2021-06-24 Thread Gregory Rose
On 6/23/2021 5:12 AM, Timothy Redaelli wrote: Currently, on Linux, if you try to create a system datapath called "bonding_masters", when you have bonding module loaded, you have a kernel trace ("sysfs: cannot create duplicate filename '/class/net/bonding_masters'"). This trace appears since "

Re: [ovs-dev] [PATCH v2] netlink: removed incorrect optimization

2021-06-04 Thread Gregory Rose
On 6/2/2021 3:00 PM, Toms Atteka wrote: This optimization caused FLOW_TNL_F_UDPIF flag not to be used in hash calculation for geneve tunnel when revalidating flows which resulted in different cache hash values and incorrect behaviour. Added test to prevent regression. Reported-at: https://gi

Re: [ovs-dev] [PATCH] flow: Read recirculation depth once for whole batch in miniflow_extract

2021-04-09 Thread Gregory Rose
On 4/9/2021 3:09 AM, Balazs Nemeth wrote: The call to recirc_depth_get involves accessing a TLS value which is slower than accessing the stack. Signed-off-by: Balazs Nemeth --- lib/dpif-netdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/

Re: [ovs-dev] [EXTERNAL] Re: Segfaults when loading openvswitch.ko

2021-03-31 Thread Gregory Rose
On 3/31/2021 5:18 PM, Gregory Rose wrote: Openvswitch should be checking for this and defining 'HAVE_INET_FRAGS_RND' if so.  Check the generated kcomat.h Excuse the typo - 'kcompat.h' My apologies. ___ dev mailing list

Re: [ovs-dev] [EXTERNAL] Re: Segfaults when loading openvswitch.ko

2021-03-31 Thread Gregory Rose
27; in ./acinclude.m4. - Greg Thanks, Dan On 3/31/21, 4:05 PM, "Gregory Rose" wrote: CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance. On 3/30/2021 2:11 PM, Lynch, Daniel wr

Re: [ovs-dev] Segfaults when loading openvswitch.ko

2021-03-31 Thread Gregory Rose
On 3/30/2021 2:11 PM, Lynch, Daniel wrote: This is a long shot, but I'm hoping that someone will have some insight for an issue that we are encountering. We are using an older version of Open vSwitch (2.7.1) with LEDE 17.01 on the Atom processor of a Puma7 SoC (MaxLinear SDK R7.2.1), and are

Re: [ovs-dev] crash in dst_cache_destroy

2021-03-24 Thread Gregory Rose
On 3/24/2021 12:48 AM, wanghan...@corp.netease.com wrote: Hi ALL, We found a kernel panic about ovs 2.8.2 with kernel 4.9.65. That's a very old release on an old kernel. Can you repro with something more recent? I suggest upgrading your OVS version. - Greg [20655819.900423] BUG: unabl

Re: [ovs-dev] [PATCH] rhel: Do not update kmod RPM newer major revision kernels

2021-03-24 Thread Gregory Rose
On 3/22/2021 4:58 AM, Ilya Maximets wrote: On 2/9/21 8:47 PM, Greg Rose wrote: The ovs-kmod-manage.sh script will run weak-updates even on newer release kernels installing a non-compatible or un-runnable kernel module. Update the script to never install weak-updates onto kernels with newer m

Re: [ovs-dev] [PATCH branch-2.7] ofproto-dpif-xlate: Fix leak in learn action

2021-02-25 Thread Gregory Rose
On 2/25/2021 3:18 AM, Darragh O'Reilly via dev wrote: This is a backport of commit 1bddcb5dc (ofproto-dpif-xlate: Fix bug that may leak ofproto_flow_mod) from branch-2.8. That commit won't cherry-pick cleanly onto branch-2.7 as the addition of the learn limit in 2.8 changed xlate_learn_action(

Re: [ovs-dev] [PATCH v2] netlink: ignore IFLA_WIRELESS events

2021-02-08 Thread Gregory Rose
On 1/14/2021 1:09 AM, Michal Kazior wrote: From: Michal Kazior Some older wireless drivers - ones relying on the old and long deprecated wireless extension ioctl system - can generate quite a bit of IFLA_WIRELESS events depending on their configuration and runtime conditions. These are deliv

Re: [ovs-dev] [PATCH] netdev-afxdp: Add start qid support.

2021-02-08 Thread Gregory Rose
On 2/6/2021 9:00 AM, William Tu wrote: On Fri, Feb 5, 2021 at 1:08 PM Gregory Rose wrote: On 2/4/2021 7:08 PM, William Tu wrote: On Thu, Feb 4, 2021 at 3:17 PM Gregory Rose wrote: On 2/3/2021 1:21 PM, William Tu wrote: Mellanox card has different XSK design. It requires users to

Re: [ovs-dev] [PATCH] netdev-afxdp: Add start qid support.

2021-02-05 Thread Gregory Rose
On 2/4/2021 7:08 PM, William Tu wrote: On Thu, Feb 4, 2021 at 3:17 PM Gregory Rose wrote: On 2/3/2021 1:21 PM, William Tu wrote: Mellanox card has different XSK design. It requires users to create dedicated queues for XSK. Unlike Intel's NIC which loads XDP program to all q

Re: [ovs-dev] [PATCH] netdev-afxdp: Add start qid support.

2021-02-04 Thread Gregory Rose
On 2/3/2021 1:21 PM, William Tu wrote: Mellanox card has different XSK design. It requires users to create dedicated queues for XSK. Unlike Intel's NIC which loads XDP program to all queues, Mellanox only loads XDP program to a subset of its queue. When OVS uses AF_XDP with mlx5, it doesn't r

Re: [ovs-dev] [PATCH V5 0/2] Deprecate Linux kernel module

2021-01-15 Thread Gregory Rose
On 1/15/2021 11:10 AM, Ilya Maximets wrote: On 1/12/21 8:15 PM, Greg Rose wrote: As agreed in (1) deprecate building the Linux kernel module from the Open vSwitch source tree. github Build and Test here: https://github.com/gvrose8192/ovs-experimental/actions/runs/480920378 1. https://mail.o

Re: [ovs-dev] [PATCH V4 1/2] doc: Deprecate the Linux Out of Tree module

2021-01-12 Thread Gregory Rose
On 1/11/2021 1:51 PM, Flavio Leitner wrote: On Mon, Jan 11, 2021 at 12:26:49PM -0800, Greg Rose wrote: It is decided (1) to deprecate the Linux Out of Tree (OOT) module. Update the NEWS and FAQ to provide notice. I suggest to rephrase the out of tree above as well. fbl I'll redo the verb

Re: [ovs-dev] [PATCH V3 1/2] doc: Deprecate the Linux Out of Tree module

2021-01-11 Thread Gregory Rose
On 1/11/2021 9:28 AM, Ilya Maximets wrote: On 1/7/21 8:36 PM, Greg Rose wrote: It is decided (1) to deprecate the Linux Out of Tree (OOT) module. Update the NEWS and FAQ to provide notice. 1. https://mail.openvswitch.org/pipermail/ovs-dev/2020-December/378831.html Signed-off-by: Greg Rose

Re: [ovs-dev] [PATCH V3 2/2] acinclude: Warn when --with-linux parameter is supplied

2021-01-07 Thread Gregory Rose
On 1/7/2021 11:36 AM, Greg Rose wrote: The Linux Out of Tree kernel driver is deprecated. Emit a warning when the '--with-linux' configure parameter is supplied to remind the user. In view of Ben's comments on the other patch in this series I will change 'Linux Out of Tree kernel driver' t

Re: [ovs-dev] [PATCH V3 1/2] doc: Deprecate the Linux Out of Tree module

2021-01-07 Thread Gregory Rose
On 1/7/2021 11:47 AM, Ben Pfaff wrote: I am not a fan of the term "out of tree" because it assumes that the reader knows what tree you're talking about. I would guess that people reading OVS documentation tend to be thinking about OVS, not Linux, so if they're thinking about any tree at all, i

Re: [ovs-dev] [PATCH V2 1/2] doc: Deprecate the Linux Out of Tree module

2021-01-07 Thread Gregory Rose
On 1/7/2021 10:56 AM, 0-day Robot wrote: Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: error: Failed to merge in the changes. hint: Use 'git am

Re: [ovs-dev] [PATCH 0/2] Deprecate the Linux OOT driver

2021-01-06 Thread Gregory Rose
On 1/6/2021 10:55 AM, Ilya Maximets wrote: On 1/6/21 7:09 PM, Gregory Rose wrote: On 1/6/2021 4:34 AM, Ilya Maximets wrote: On 1/5/21 7:33 PM, Greg Rose wrote: As agreed in (1) deprecate the Linux OOT driver. github Build and Test here: https://github.com/gvrose8192/ovs-experimental

Re: [ovs-dev] [PATCH 0/2] Deprecate the Linux OOT driver

2021-01-06 Thread Gregory Rose
On 1/6/2021 4:34 AM, Ilya Maximets wrote: On 1/5/21 7:33 PM, Greg Rose wrote: As agreed in (1) deprecate the Linux OOT driver. github Build and Test here: https://github.com/gvrose8192/ovs-experimental/actions/runs/463987690 1. https://mail.openvswitch.org/pipermail/ovs-dev/2020-December/37

Re: [ovs-dev] OVS "soft freeze" for 2.15 is in effect.

2021-01-05 Thread Gregory Rose
On 1/1/2021 3:07 PM, Ilya Maximets wrote: Hi. As described in Documentation/internals/release-process.rst, we are in a "soft freeze" state: During the freeze, we ask committers to refrain from applying patches that add new features unless those patches were already being publicly dis

Re: [ovs-dev] Question about supporting the OVS out-of-tree kernel drivers

2020-12-17 Thread Gregory Rose
On 12/17/2020 3:55 AM, Ilya Maximets wrote: On 12/16/20 9:37 PM, Flavio Leitner wrote: On Sun, Nov 29, 2020 at 02:30:29AM +0100, Ilya Maximets wrote: On 11/12/20 6:04 PM, Gregory Rose wrote: On 11/12/2020 5:10 AM, Mark Gray wrote: On 30/10/2020 18:32, Gregory Rose wrote: The question

Re: [ovs-dev] [PATCH] netdev-afxdp: updated documentation

2020-12-02 Thread Gregory Rose
On 12/2/2020 10:21 AM, Toms Atteka wrote: If system is missing ethtool, test fails silently. Signed-off-by: Toms Atteka --- Documentation/intro/install/afxdp.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/intro/install/afxdp.rst b/Documentation/intr

Re: [ovs-dev] [PATCH 0/2] Backport upstream lockdep bug fix

2020-11-30 Thread Gregory Rose
On 11/27/2020 3:47 PM, Ilya Maximets wrote: On 10/21/20 6:49 PM, Greg Rose wrote: First backport the rcu patch that adds conditional and then the bug fix from Tonghao Zhang that fixes a lockdep bug. Passes Travis here: https://travis-ci.org/github/gvrose8192/ovs-experimental/builds/737547340

Re: [ovs-dev] [PATCH] perf-counter: Split numbers in the output.

2020-11-20 Thread Gregory Rose
On 11/18/2020 1:05 PM, Ilya Maximets wrote: While trying to benchmark big functions, values could be longer than 12 digits. In this case all of them printed without spaces. It's hard ot read. Fixes: 619c3a42dc1e ("lib: add a hardware performance counter access library") Signed-off-by: Ilya

Re: [ovs-dev] [PATCH] Update scripts to support RHEL 7.9

2020-11-18 Thread Gregory Rose
Thanks again Guru! From: Guru Shetty Sent: Wednesday, November 18, 2020 2:32 PM To: Greg Rose Cc: ovs dev ; Gregory Rose Subject: Re: [ovs-dev] [PATCH] Update scripts to support RHEL 7.9 On Tue, 17 Nov 2020 at 13:32, Greg Rose mailto:gvrose8...@gmail.com>> wrote: From: Greg Rose mai

Re: [ovs-dev] [PATCH] Update scripts to support RHEL 7.9

2020-11-17 Thread Gregory Rose
On 11/17/2020 1:59 PM, 0-day Robot wrote: Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Greg Rose needs to sign off. WARNING:

Re: [ovs-dev] [PATCH V2 3/3] compat: Fix compile warning

2020-11-16 Thread Gregory Rose
On 11/16/2020 11:30 AM, Ilya Maximets wrote: On 11/13/20 8:24 PM, Yi-Hung Wei wrote: On Thu, Nov 12, 2020 at 3:10 PM Greg Rose wrote: In ../compat/nf_conntrack_reasm.c nf_frags_cache_name is declared if OVS_NF_DEFRAG6_BACKPORT is defined. However, later in the patch it is only used if HAV

Re: [ovs-dev] [PATCH V2 0/3] Fix RHEL 7.7 build

2020-11-12 Thread Gregory Rose
On 11/12/2020 3:10 PM, Greg Rose wrote: Fix build for RHEL 7.7. Also remove some stale code and fix compile warning. Greg Rose (3): compat: Remove stale code compat: Fix build issue on RHEL 7.7 compat: Fix compile warning acinclude.m4 | 4 d

Re: [ovs-dev] Question about supporting the OVS out-of-tree kernel drivers

2020-11-12 Thread Gregory Rose
On 11/12/2020 5:10 AM, Mark Gray wrote: On 30/10/2020 18:32, Gregory Rose wrote: The question is whether there is any interest in continuing to support the OVS out-of-tree (OOT) kernel driver or should we deprecate it? The latest kernel support for the OOT driver is up to 5.8.x There

Re: [ovs-dev] Status of upstreaming of "add transport ports in route lookup for geneve" patch into kernel

2020-11-12 Thread Gregory Rose
On 11/12/2020 5:42 AM, Mark Gray wrote: On 14/09/2020 22:20, Gregory Rose wrote: On 9/14/2020 2:01 PM, Mark Gray wrote: Hi, This patch does not seem to be in the in-kernel tree and I am unable to get IPsec with Geneve working without it. I ported it to the in-tree kernel module and it

Re: [ovs-dev] [PATCH] ovs-bugtool: Fix crash when enable --ovs.

2020-11-04 Thread Gregory Rose
On 11/4/2020 3:16 PM, William Tu wrote: When enabling '--ovs' or when not using '-y', ovs-bugtool crashes due to Traceback (most recent call last): File "/usr/local/sbin/ovs-bugtool", line 1410, in sys.exit(main()) File "/usr/local/sbin/ovs-bugtool", line 690, in main for (k, v

Re: [ovs-dev] [PATCH 1/2] compat: Fix build issue on RHEL 7.7

2020-11-04 Thread Gregory Rose
On 11/3/2020 5:07 PM, Yi-Hung Wei wrote: On Tue, Nov 3, 2020 at 4:06 PM Gregory Rose wrote: On 11/3/2020 2:17 PM, Yi-Hung Wei wrote: [snip] Hi Greg, I thought your change in datapath.c is to fix the following new added lines in 9ba57fc7 ("datapath: Add hash info to upcall&

Re: [ovs-dev] [PATCH 1/2] compat: Fix build issue on RHEL 7.7

2020-11-03 Thread Gregory Rose
On 11/3/2020 2:17 PM, Yi-Hung Wei wrote: On Tue, Oct 20, 2020 at 10:07 AM Greg Rose wrote: RHEL 7.7 has a KABI fixup in struct sk_buff to backport the member name change of l4_rxhash to l4_hash. This exposed a couple of issues in patch 8063e0958780 which was intended to remove support for

Re: [ovs-dev] [PATCH] Documentation: Fix rendering of extra repo info for RHEL 8

2020-11-03 Thread Gregory Rose
On 11/3/2020 2:12 AM, Timothy Redaelli wrote: In commit a82083ee3091 ("Documentation: Add extra repo info for RHEL 8") a newline was missing to correctly generate the code block to add codeready-builder repository. This commit adds the missing newline to correctly generate the code block with

[ovs-dev] Question about supporting the OVS out-of-tree kernel drivers

2020-10-30 Thread Gregory Rose
The question is whether there is any interest in continuing to support the OVS out-of-tree (OOT) kernel driver or should we deprecate it? The latest kernel support for the OOT driver is up to 5.8.x There seems to be little interest that I can tell in using the OOT driver. The main distros a

Re: [ovs-dev] [PATCH] NEWS: Move GTP-U entry to correct release.

2020-10-22 Thread Gregory Rose
On 10/21/2020 8:10 AM, Ilya Maximets wrote: GTP-U support was released in 2.14, not 2.13. Fixes: 3c6d05a02e0f ("userspace: Add GTP-U support.") Signed-off-by: Ilya Maximets --- NEWS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS b/NEWS index fa8947cb2..0991f

Re: [ovs-dev] [PATCH V4 00/24] Add support for Linux kernels up to 5.8.x

2020-10-19 Thread Gregory Rose
On 10/19/2020 6:25 AM, Ilya Maximets wrote: On 10/14/20 7:46 PM, Gregory Rose wrote: On 10/14/2020 8:41 AM, Ilya Maximets wrote: On 10/12/20 10:24 PM, Greg Rose wrote: This patch set will add support for Linux kernels up to 5.8. In addition there are quite a few patches for openvswitch on

Re: [ovs-dev] [PATCH V4 00/24] Add support for Linux kernels up to 5.8.x

2020-10-14 Thread Gregory Rose
On 10/14/2020 8:41 AM, Ilya Maximets wrote: On 10/12/20 10:24 PM, Greg Rose wrote: This patch set will add support for Linux kernels up to 5.8. In addition there are quite a few patches for openvswitch on the Linux kernel mailing list that have not been backported - here is a first batch atte

Re: [ovs-dev] [PATCH] Revert "travis: Disable check for array of flexible structures in sparse."

2020-10-12 Thread Gregory Rose
On 10/12/2020 11:15 AM, Ilya Maximets wrote: This reverts commit 3c6b3a519ae6eae3da4cf7c59894b02b95cdade7. The fix landed to Sparse main repository [1]: b5d46df743be ("flex-array: allow arrays of unions with flexible members.") [1] https://git.kernel.org/pub/scm/devel/sparse/sparse.git Si

Re: [ovs-dev] [PATCH] datapath: Fix exposing OVS_TUNNEL_KEY_ATTR_GTPU_OPTS to kernel module.

2020-10-08 Thread Gregory Rose
On 10/8/2020 6:53 AM, Ilya Maximets wrote: Kernel module doesn't know about GTPU and it should return correct out-of-range error in case this tunnel attribute passed there for any reason. Current out-of-tree module will pass the range check and will try to access ovs_tunnel_key_lens[] array by

Re: [ovs-dev] [PATCH V3 11/24] datapath: fix possible memleak on destroy flow-table

2020-10-02 Thread Gregory Rose
On 9/29/2020 2:43 PM, Yi-Hung Wei wrote: On Wed, Sep 16, 2020 at 10:33 AM Greg Rose wrote: From: Tonghao Zhang Upstream commit: commit 50b0e61b32ee890a75b4377d5fbe770a86d6a4c1 Author: Tonghao Zhang Date: Fri Nov 1 22:23:52 2019 +0800 net: openvswitch: fix possible

Re: [ovs-dev] [PATCH V3 05/24] datapath: Set OvS recirc_id from tc chain index

2020-10-02 Thread Gregory Rose
On 9/28/2020 2:46 PM, Yi-Hung Wei wrote: On Wed, Sep 16, 2020 at 10:33 AM Greg Rose wrote: From: Paul Blakey Upstream commit: commit 95a7233c452a58a4c2310c456c73997853b2ec46 Author: Paul Blakey Date: Wed Sep 4 16:56:37 2019 +0300 net: openvswitch: Set OvS recirc_id

Re: [ovs-dev] [PATCH] compat: Replace the HAVE_L4_RXHASH define with HAVE_L4_HASH

2020-09-28 Thread Gregory Rose
On 9/24/2020 6:05 AM, Flavio Leitner wrote: On Tue, Sep 22, 2020 at 12:45:03PM +0200, Ilya Maximets wrote: On 9/17/20 9:59 PM, Greg Rose wrote: The skb now uses l4_hash and it is easier to check for it. Also fixes a compile error for RHEL 7.7. Signed-off-by: Greg Rose --- acinclude.m4

Re: [ovs-dev] [PATCH 3/3] vxlan: Make vxlan tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2020-09-28 Thread Gregory Rose
On 9/23/2020 6:32 AM, Ilya Maximets wrote: On 9/17/20 7:14 PM, Greg Rose wrote: From: wenxu There is currently no support for the multicast/broadcast aspects of VXLAN in ovs. In the datapath flow the tun_dst must specific. But in the IP_TUNNEL_INFO_BRIDGE mode the tun_dst can not be specifi

Re: [ovs-dev] [PATCH 2/3] datapath: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2020-09-17 Thread Gregory Rose
On 9/17/2020 1:16 PM, 0-day Robot wrote: Bleep bloop. Greetings Greg Rose, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author wenxu needs to sign off. WARNING: Unex

Re: [ovs-dev] Status of upstreaming of "add transport ports in route lookup for geneve" patch into kernel

2020-09-14 Thread Gregory Rose
On 9/14/2020 2:01 PM, Mark Gray wrote: Hi, This patch does not seem to be in the in-kernel tree and I am unable to get IPsec with Geneve working without it. I ported it to the in-tree kernel module and it seems to work. I still need to rebase and test on net-next. Greg, I will add your review

Re: [ovs-dev] [PATCH 2/2] datapath: Make metadata_dst tunnel work in IP_TUNNEL_INFO_BRIDGE mode

2020-09-14 Thread Gregory Rose
On 9/14/2020 10:24 AM, Ilya Maximets wrote: On 9/11/20 5:37 PM, Gregory Rose wrote: On 10/14/2019 9:51 PM, wenxu wrote: On 10/15/2019 5:14 AM, Gregory Rose wrote: On 10/8/2019 4:51 PM, Greg Rose wrote: From: wenxu Upstream commit:   commit 18b6f717483a835fb98de9f0df6c724df9324e78

  1   2   3   4   5   6   7   >