On 6/7/24 16:42, Kevin Traynor wrote:
> On 07/06/2024 15:01, Ilya Maximets wrote:
>> We didn't make a stable release for a while. It's definitely time
>> to make one.
>>
>> Ilya Maximets (2):
>> Set release date for 3.3.1.
>> Prepare
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 31d235a40..aaf8d4b4a 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v3.3.1 - xx xxx
+v3.3.1 - 07 Jun 2024
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index aaf8d4b4a..f62d06ffb 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.3.2 - xx xxx
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 3.3.1.
Prepare for 3.3.2.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3 deletions
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 43ab6d806..492b096db 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.2.4 - xx xxx
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 8baf3d2aa..43ab6d806 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v3.2.3 - xx xxx
+v3.2.3 - 07 Jun 2024
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 3.2.3.
Prepare for 3.2.4.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3 deletions
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 44a3e6247..9604939b3 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v3.1.5 - xx xxx
+v3.1.5 - 07 Jun 2024
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 9604939b3..cf0700ab3 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.1.6 - xx xxx
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 3.1.5.
Prepare for 3.1.6.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3 deletions
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 3.0.7.
Prepare for 3.0.8.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3 deletions
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 088bf0dd2..504c70b6b 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.0.8 - xx xxx
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 8550e8e89..088bf0dd2 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v3.0.7 - xx xxx
+v3.0.7 - 07 Jun 2024
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 2.17.10.
Prepare for 2.17.11.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3 deletions
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index e91072dd6..a809e8e3d 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v2.17.10 - xx xxx
+v2.17.10 - 07 Jun 2024
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index a809e8e3d..8ba8a8d62 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v2.17.11 - xx xxx
On 6/6/24 19:53, Adrián Moreno wrote:
> On Thu, Jun 06, 2024 at 06:00:26PM GMT, Ilya Maximets wrote:
>> On 6/6/24 17:15, Adrian Moreno wrote:
>>> Add check_pkt_len action to the decoder list that it, itself, uses.
>>>
>>> This makes nested check_pkt_len
On 6/6/24 20:55, Terry Wilson wrote:
> On Thu, Jun 6, 2024 at 10:41 AM Dumitru Ceara wrote:
>>
>> On 5/27/24 23:39, Ilya Maximets wrote:
>>> When a row is modified, python IDL doesn't perform any operations on
>>> existing client-side indexes. This means that
plied remaining 2 patches and backported them down to 3.1.
Best regards, Ilya Maximets.
>
> Terry
>
> On Wed, Apr 10, 2024 at 4:39 PM Terry Wilson wrote:
>>
>> The Python IDL code very closely mirrors the C IDL code, which uses
>> an hmap to store table rows. hmap
hould start from the beginning of the line for patchwork to
recognize them.)
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
single caller separately. And we're still copying the TCP
header anyway.
Fixes: 9726a016d9d6 ("datapath-windows: Implement locking in conntrack NAT.")
Reported-at: https://github.com/openvswitch/ovs-issues/issues/323
Signed-off-by: Ilya Maximets
---
WARNING: I beleive this code is corr
On 6/3/24 17:09, Simon Horman wrote:
> On Fri, May 31, 2024 at 11:45:12PM +0200, Ilya Maximets wrote:
>> OVS can parse NSH, but can't compose. Fix that and get rid of plain
>> hex NSH packets in system tests as they are hard to read or modify.
>>
>> Tcpdump calls mod
David and Kevin!
I generally like the direction of this patch set, especially the
cleanup of the generic tunnel code.
I didn't test it with a real hardware nor I re-checked the math,
so will not Ack it, but it looks good to me otherwise, and I think
we should backport the whole th
today, so can be a separate patch, I think. We have a few
more
words like this in relatively recent commits, like 'poller' or 'autovalidator',
these
can be bundled in that separate commit as well.
Though updating the dictionary along with the patch that is using the word
sounds OK
to me as well.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ot; ]<[^=" ]',
> r'[^\->" ]>[^=" ]',
> - r'[^ !()/"]\*[^/]',
> + r'[^ !()/"\*]\*[^/]',
> r'[^ !&()"]&',
> r'[^" +(]\+[^"+;]',
> r'[^" \-(]\-[^"\->;]',
Please, add a unit test for this issue.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 6/4/24 13:42, Eelco Chaudron wrote:
>
>
> On 1 Jun 2024, at 0:08, Ilya Maximets wrote:
>
>> On 5/7/24 15:52, Eelco Chaudron wrote:
>>> While offloading header modifications to TC, OVS is using {TCA_PEDIT} +
>>> {TCA_CSUM} combination as that it the only
fixed in OpenStack instead.
Best regards, Ilya Maximets.
>
> On Tue, Jun 4, 2024 at 11:05 AM Simon Horman wrote:
>
>> + Ihar
>>
>> On Fri, May 31, 2024 at 03:40:08PM -0400, Brian Haley wrote:
>>> An earlier patch [1] increased the size of the liste
delay.
I'm considering this as a bug fix, because the use of a plain monitor
causes a significant traffic amplification with every small transactions
and can potentially create serious issues in large scale clusters.
Applied to main. Backporting to 2.17 is probably too much, so only ported
to 3.
ow,
the second should return both duplicates and the third should again
return one row.
Ideally, implementation should not leak the transaction details to
the query module, though I'm not sure if that is 100% achievable.
2. Taking above case into account, this change needs way more unit
On 6/3/24 13:14, Eelco Chaudron wrote:
>
>
> On 3 Jun 2024, at 13:12, Ilya Maximets wrote:
>
>> '\+' as a one-or-more match is a GNU extension and it doesn't work
>> in BSD sed. This makes the python vlog test to fail on FreeBSD 14
>> that recent
.
Fixes: 9185793e7543 ("tests: Fix compatibility issue with Python 3.13 in
vlog.at.")
Signed-off-by: Ilya Maximets
---
tests/vlog.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vlog.at b/tests/vlog.at
index efe91479a..2768c0740 100644
--- a/tests/vlog.at
+
der Checksum: 0x44c2
> +dnl Data (18 bytes)
> +eth="36 b1 ee 7c 01 02 36 b1 ee 7c 01 03 08 00"
> +ip="45 00 00 26 00 01 20 00 40 11 44 c2 0a 01 01 01 0a 01 01 02"
> +data="0b c4 08 84 00 26 e9 64 01 02 03 04 05 06 07 08 09 0a"
> +packet="${eth} ${ip
with more robust waiting for tcpdump
to start listening.
M4 macros are better than shell variables, because we can see the
substitution result in the test log. So, using m4_define and m4_join
extensively.
Signed-off-by: Ilya Maximets
---
lib/flow.c | 18
tests/system-traffic.at | 177
sleeps with more robust waiting for tcpdump
to start listening.
M4 macros are better than shell variables, because we can see the
substitution result in the test log. So, using m4_define and m4_join
extensively.
Signed-off-by: Ilya Maximets
---
tests/system-traffic.at | 233
.
Signed-off-by: Ilya Maximets
---
tests/sendpkt.py | 26 --
1 file changed, 4 insertions(+), 22 deletions(-)
diff --git a/tests/sendpkt.py b/tests/sendpkt.py
index 49ac45275..7cbea5165 100755
--- a/tests/sendpkt.py
+++ b/tests/sendpkt.py
@@ -48,28 +48,10 @@ if len(args) <
fully parse
and doesn't have a way to represent fully in OpenFlow.
Next step might be to replace some of the packet-out calls as well.
Ilya Maximets (3):
tests: sendpkt: Allow different input formats.
tests: Convert ND, MPLS and CT sendpkt tests to compose-packet.
nsh: Add support to compose
TSO packet. Flags:
> %"PRIx64,
I'd suggest adding the # qualifier to the format string, i.e. %#"PRIx64.
Can be fixed on commit, I suppose.
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
e it's not cleared properly.
>
> Fixes: 07ff77ccb82a ("db-ctl-base: Make common database command code into
> library.")
> Signed-off-by: Eelco Chaudron
> ---
> lib/db-ctl-base.c | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Ilya Maximets
_
On 5/30/24 15:10, David Marchand wrote:
> If outer checksum is not supported and OVS already set L3/L4 outer
> checksums in the packet, no outer mark should be left in ol_flags
> (as it confuses some driver, like net/ixgbe).
>
> l2_len must be adjusted to account for the tunnel header.
>
>
On 5/30/24 15:10, David Marchand wrote:
> The outer checksum offloading API in DPDK is ambiguous and was
> implemented by Intel folks in their drivers with the assumption that
> any outer offloading always goes with an inner offloading request.
>
> With net/i40e and net/ice drivers, in the case
On 5/30/24 09:28, Eelco Chaudron wrote:
>
>
> On 29 May 2024, at 12:53, Eelco Chaudron wrote:
>
>> The sFlow library uses a uint32_t to configure timeout ticks, but
>> stores this value as a time_t. Although this doesn't cause functional
>> issues, it wastes space and confuses Coverity,
On 5/31/24 04:00, Simon Jones wrote:
> Hi all,
>
> I'm using ovs-dpdk(ovs:2.17.1, dpdk:21.11.1).
> Now I found a BUG that ovs crash and could NOT fix again after set
> request_mtu.
>
> 1. How to reproduce and my Analysis:
> ```
> # start ovs and add bridge and port and openflow
>
> [root@bogon
On 5/30/24 20:17, Ilya Maximets wrote:
> On 5/30/24 01:27, William Tu wrote:
>> Add route-table support for ipv4 dst via ipv6. One use case is BGP
>> unnumbered, a mechanism that establishes peering sessions without the
>> need to explicitly configure IPv4 addresses on th
=50:54:00:00:00:09,dst=50:54:00:00:00:0a),eth_type(0x1234), dnl
packets:1, bytes:14, used:0.0s, dnl
actions:tnl_push(tnl_port(6081),header(size=50,type=5,dnl
eth(dst=f8:bc:12:44:34:b6,src=aa:55:aa:55:00:00,dl_type=0x0800),dnl
ipv4(src=1.1.2.88,dst=1.1.2.92,proto=17,tos=0,ttl=64,frag=0x4000),dnl
udp(sr
r);
> diff --git a/lib/util.c b/lib/util.c
> index 5c31d983a..c03a1ae15 100644
> --- a/lib/util.c
> +++ b/lib/util.c
> @@ -618,8 +618,9 @@ ovs_set_program_name(const char *argv0, const char
> *version)
> program_name = basename;
>
> free(program_version);
> -i
On 5/29/24 12:53, Eelco Chaudron wrote:
> This patch fixes an uninitialized gso_type case in
> netdev_linux_prepend_vnet_hdr() by returning an error.
>
> Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
> Signed-off-by: Eelco Chaudron
> ---
Recheck-request:
On 5/29/24 12:53, Eelco Chaudron wrote:
> Coverity has flagged the use of a potentially unsafe function.
> Although this is not a concern in this case since it's not used for
> encryption, we should replace it with the OVS implementation to
> achieve better randomness.
>
> Fixes: c72e245a0e2c
On 5/29/24 12:53, Eelco Chaudron wrote:
> Fix the warning from Coverity about potential truncation of the
> time_t value when copying to a local variable by changing the
> local variable's type to time_t.
>
> Fixes: ccc24fc88d59 ("ofproto-dpif: APIs and CLI option to add/delete static
> fdb
sFlow Agent library to the build system.")
> Acked-by: Ilya Maximets
> Signed-off-by: Eelco Chaudron
> --
> Note that this checkpatch reports an 'Improper whitespace
> around control block' error on this patch + some warnings.
> But I did not want to change the code style
On 5/29/24 12:53, Eelco Chaudron wrote:
> The sFlow library uses a uint32_t to configure timeout ticks, but
> stores this value as a time_t. Although this doesn't cause functional
> issues, it wastes space and confuses Coverity, potentially indicating
> a Y2K38 problem when storing uint32_t values
On 5/29/24 12:53, Eelco Chaudron wrote:
> Fix unintentional integer overflow reported by Coverity by adding
> the LL suffix to the numerical literals used in the multiplication.
>
> Fixes: 5767a79a4059 ("cfm: Require ccm received in demand mode.")
> Acked-by: Mike Pattrick
> Signed-off-by: Eelco
On 5/29/24 11:01, Eelco Chaudron wrote:
>
>
> On 28 May 2024, at 16:49, Ilya Maximets wrote:
>
>> On 5/28/24 14:36, Eelco Chaudron wrote:
>>>
>>>
>>> On 24 May 2024, at 11:20, Emma Finn wrote:
>>>
>>>> The AVX implementation f
migrate from the legacy ethtool_cmd API at some point,
but this change makes sense for now.
Applied to main and backported down to 3.3. Thanks!
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
roed out even on errors. That is defined in netdev-provider API. But
the new static netdev_linux_get_speed_locked() function didn't do the same.
I fixed that and applied the set. Individual patches backported according to
their Fixes tags. Thanks!
Best regards, Ilya Maximets.
__
contains 'offload'
and it's not necessarily hardware here. Also, flags are better printed in hex,
i.e. %#"PRIx64. And there is a missing space between the cast and a variable.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
gt; ---
> lib/sflow_api.h | 6 +++---
> lib/sflow_receiver.c | 7 ---
> ofproto/ofproto-dpif-sflow.c | 2 +-
> 3 files changed, 8 insertions(+), 7 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/28/24 19:35, Ilya Maximets wrote:
> On 5/21/24 10:38, Martin Kalcok wrote:
>> Help text for 'ovsdb-client dump' does not mention that it's capable
>> of dumping a specific column's contents if the user supplies the
>> column's name as a fourth positional argument.
>&g
\n"
> + "on SERVER to stdout\n"
I think it was '[TABLE [COLUMN]...]' until commit 85226894ddec
("ovsdb-client: support monitor2") removed that part on accident.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
issues, as
Simon pointed out previously. The change you're proposing may have
some performance impact as we'll be holding the shared mutex for
longer while allocating IDs, so I'd like to understand why it is a
problem before making the change.
Best regards, Ilya Maximets.
___
ailable_prio(ovs_be16 protocol)
> return TC_RESERVED_PRIORITY_IPV4;
> } else if (protocol == htons(ETH_P_IPV6)) {
> return TC_RESERVED_PRIORITY_IPV6;
> +} else if (protocol == htons(ETH_P_8021Q)) {
o the flow
should not be freed until the processing is over.
The flow will be dead in this case with a zero counter, but it
is not freed, i.e. should be accessible.
Do you know what exactly failed in odp_execute_actions ?
Your version of the code seems to be very differe
ade some noticeable changes to the original patch,
or if they want to clarify something that wasn't fully explained
by the original commit message. I add those sometimes as well.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
tion/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 13 insertions(+), 11 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
tion/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 13 insertions(+), 11 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 11 insertions(+), 9 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 10 insertions(+), 8 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 9 insertions(+), 7 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 8 insertions(+), 6 deletions(-)
Didn't test, but LGTM.
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ose?
For now, I'll mark this patch with 'Changes Requested'.
If you plan to send a new version based on Mike's comments, please, add
'v6' to the subject prefix, i.e. [PATCH v6], since it's technically a
6th version of it.
Best regards, Ilya Maximets.
_
On 5/28/24 14:36, Eelco Chaudron wrote:
>
>
> On 24 May 2024, at 11:20, Emma Finn wrote:
>
>> The AVX implementation for calcualting checksums was not
>> handling carry-over addition correctly in some cases.
>> This patch adds an additional shuffle to add 16-bit padding to
>> the final part of
will still need a decent amount of
glue to pair with the library as well as maintain OVS-specific counters, I
think,
it's better to keep things as-is for now and try to periodically sync with the
original code from host-sflow. Sub-projects/modules/trees are generally not
easy
to work
/NEWS
> +++ b/NEWS
> @@ -8,4 +8,6 @@ Post-v3.3.0
> The OVS tree remains hosted on GitHub.
> https://github.com/openvswitch/ovs.git
> + - DPDK:
> + * Add support for DPDK 23.11.1.
>
>
Same here. 'validated with'?
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
a/NEWS
> +++ b/NEWS
> @@ -1,4 +1,7 @@
> v3.3.1 - xx xxx
>
> + - DPDK:
> + * Add support for DPDK 23.11.1.
> +
We're normally using 'validated with'.
And the extra line is not needed here.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
al issue is added. Some extra
testing infrastructure added to be able to handle and print out the
'indexed' table from the idltest schema.
Fixes: 13973bc41524 ("Add multi-column index support for the Python IDL")
Reported-at:
https://mail.openvswitch.org/pipermail/ovs-discuss/2024-May/
not happen. But, in case it does,
I think we need to print a warning and return with error instead
of ignoring the TSO request.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> ctl_context_init_command(ctx, command, false);
> }
I don't see this string to be destroyed anywhere, should this be
added to the context_done() ? I see it's being swapped around with
command output, but it's hard to track.
Best regards, Ilya Maximets.
_
e may probably just replace sFlowRcvrTimeout with a uint32_t value and
compare agains UIN32_MAX. It doesn't have to be time_t. It's just a tick
counter that should not be too high. And we're not even using it anyway.
Best regards, Ilya Maximets.
> +
> /* The ovs_be types indicate that a
p with naming as well.
Also, please, either send all patches as separate or add a cover letter to
the set.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
netdev_features_to_bps(netdev->supported, 0) /
> 100ULL);
> +} else {
> +*current = 0;
> +*max = 0;
Please, squash these into one line as netdev_get_speed() does. Same for the
other
instance.
> }
> return netdev->get_features_err
x_read_stringset_info(netdev, );
> -if (error || !len) {
> +if (!len) {
> +return -EOPNOTSUPP;
> +} else if (error) {
> return error;
> }
Hmm. In case there is an error, we should return it. The length
check should be secondary.
Best regards, Ilya Maximet
; Signed-off-by: Mike Pattrick
> Fixes: 03fc1ad78521 ("userspace: Add SRv6 tunnel support.")
Nit: The 'Fixes' tag should go before the SoB.
Also, please, either send patches separately, or add a cover letter
to the set.
Best regards, Ilya Maximets.
> ---
> lib/netdev-nat
dev),
Hi, Roi. Thanks for the patch!
I think it is trying to fix the same issue as:
https://patchwork.ozlabs.org/project/openvswitch/patch/20240523191152.589605-6-...@redhat.com/
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
p_flags=ack
eth_src=8a:bf:7e:2f:05:84,eth_dst=0a:8f:39:4f:e0:73,dl_type=0x86dd,
ipv6_src=16bf:5603:6d40:1620:2a8e:6a83:4348:6136,
ipv6_dst=5003:74fd:47cd:6b65:353c:7fc1:5ac5:7d08,
ipv6_label=0x7661,nw_proto=6,nw_ttl=214,nw_frag=no,
tp_src=21024,tp_dst=23624,tcp_flags=ack
Feeding them into 'ovs-ofctl compose-packet --bare' produces valid packets
that trigger the issue.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/20/24 03:54, Nobuhiro MIKI wrote:
> On 2024/05/18 3:33, Ilya Maximets wrote:
>> Segments list in SRv6 header is 16-bit aligned as most of other fields
>> in packet headers. A little counter-intuitively, compilers are allowed
>> to make alignment assumptions based on th
On 5/21/24 08:32, Eelco Chaudron wrote:
>
>
> On 17 May 2024, at 20:47, Ilya Maximets wrote:
>
>> 'pkg_resources' module is deprecated and no longer available in newer
>> versions of python, so pytest tests are skipped:
>>
>> DeprecationWarning: pkg_resourc
the recently released v23.11.1.
But I think we'll need to make stable releases even if we will not be
able to incorporate changes above in time.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Adding the list back to CC.
On 5/22/24 13:28, amore...@redhat.com wrote:
> On Wed, May 22, 2024 at 12:11:37AM GMT, Ilya Maximets wrote:
>> On 5/16/24 19:03, Adrian Moreno wrote:
>>>
>>>
>>> On 4/24/24 9:53 PM, Adrian Moreno wrote:
>>>> This is
Please, keep the list in CC. :)
On 5/22/24 12:52, amore...@redhat.com wrote:
> On Wed, May 22, 2024 at 12:17:37AM GMT, Ilya Maximets wrote:
>> On 5/21/24 23:56, Ilya Maximets wrote:
>>> On 5/21/24 20:56, amore...@redhat.com wrote:
>>>> On Tue, May 21, 2024 at 08:03
bling IXGBE_HLREG0_TXPADEN for ixgbe cards for example. So, even if
the padding is not performed in software it doesn't mean it's not performed.
Doing this in software will be a waste of CPU resources in most cases.
Best regards, Ilya Maximets.
>
> Regards,
> Rohit Kumar
> --
On 5/21/24 23:56, Ilya Maximets wrote:
> On 5/21/24 20:56, amore...@redhat.com wrote:
>> On Tue, May 21, 2024 at 08:03:49PM GMT, Ilya Maximets wrote:
>>> On 5/21/24 18:13, amore...@redhat.com wrote:
>>>> On Tue, May 21, 2024 at 03:49:03PM GMT, amore...@redhat.com wro
(even without "trunc").
>
> - It requires a very big amount of work in ovs-vswitchd:
>- We'd need to decide who creates the port, if it's the user via Openflow
> and
> it's exposed as a port in a bridge or if it's a hidden vport created by the
> dpif
> layer.
>- Controls need to be established to limit OFP actions to send traffic to
> this port or it receiving traffic.
>- DPDK datapath would probably require a new netdev_class as well.
>
> - tc offload is more complicated. If we want to use act_sample (I cannot
> think
> of a way that doesn't involve act_sample), we'd need to track "sample"
> actions
> and "set_observability_metadata) to be able to build an act_sample for this.
>
> Ilya, Aaron, Eelco, did I miss something?
>
> Thoughts? Preferences?
I think, option C is a little too heavy for the end functionality for the user.
And I'm not sure if we'll be able to reuse this infrastructure for anything
else.
I'm not a fan of the design breaking part of the A and duplication of
attributes.
So, I'd prefer the B here, but I'm a little biased.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/21/24 20:56, amore...@redhat.com wrote:
> On Tue, May 21, 2024 at 08:03:49PM GMT, Ilya Maximets wrote:
>> On 5/21/24 18:13, amore...@redhat.com wrote:
>>> On Tue, May 21, 2024 at 03:49:03PM GMT, amore...@redhat.com wrote:
>>>> On Tue, May 21, 2024 at 01:51
On 5/21/24 18:13, amore...@redhat.com wrote:
> On Tue, May 21, 2024 at 03:49:03PM GMT, amore...@redhat.com wrote:
>> On Tue, May 21, 2024 at 01:51:33PM GMT, Ilya Maximets wrote:
>>> On 5/7/24 16:30, Adrian Moreno wrote:
>>>> The goal of this utility is to read bo
d:9.077s, flags:S,
actions:ct(commit,zone=269,mark=0/0x1,nat(src)),set(eth(src=3a:3b:3c:3d:3e:3f,dst=4a:4b:4c:4d:4e:4f)),set(ipv4(ttl=63)),check_pkt_len(size=8514,gt(sample(sample=100.0%,actions(meter(4),userspace(pid=4294967295,controller(reason=1,dont_send=0,continuation=0,recirc_id=29551991,rule_cookie=0x769b5340,controller_id=0,max_len=65535),le(set(eth(src=0a:0b:0c:0d:08:08,dst=aa:bb:cc:dd:ee:ff)),set(ipv4(ttl=62)),check_pkt_len(size=8514,gt(sample(sample=100.0%,actions(meter(4),userspace(pid=4294967295,controller(reason=1,dont_send=0,continuation=0,recirc_id=33861236,rule_cookie=0x9ac6aa33,controller_id=0,max_len=65535),le(ct(zone=12,nat),recirc(0x204ae75)
My guess is that it has some trouble with nested check_pkt_len.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/1/24 14:33, Eelco Chaudron wrote:
>
>
> On 29 Apr 2024, at 14:59, Ilya Maximets wrote:
>
>> On 4/16/24 09:44, Eelco Chaudron wrote:
>>> This patch adds a daily Coverity run for the OVS main branch
>>> to the GitHub actions. The result of the ru
of a driver to properly pad
packets before transmitting them. OVS doesn't know what the requirements
for the particular network it is connected to or even if it is an ethernet
or some other type of the interface. So, it can't make a decision on padding,
only driver can do that.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
t; will find the new copied tp== tp_cfg, so ``ofproto_ct_set_zone_timeout_policy`
> will not be called.
As I mentioned in reply to v1, I'd still prefer if we just removed the
get_timeout_policy_from_ovsrec() call from ct_zone_alloc().
Best regards, Ilya Maximets.
>
> Signed-off-by: chandlerwu
> ---
>
sted though. I'll reply to v2 separately.
And please keep the mailing list in CC while replying to emails (i.e.
use Reply-All), so the thread is visible in the mailing list archives.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.or
netdev_features_to_bps(netdev->supported, 0) /
> 100ULL);
> +} else {
> +*current = 0;
> }
> return netdev->get_features_error;
> }
We should be clearing both the current and a max for consistency.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ction, so we should fix it
instead, so other potential users do not have this issue.
While at it, inet_parse_active() has the same problem. It should set
the 'dns_failure' whenever it fails.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
1 - 100 of 6865 matches
Mail list logo
