On 6/19/24 08:35, Adrián Moreno wrote:
> On Tue, Jun 18, 2024 at 05:44:05PM GMT, Ilya Maximets wrote:
>> On 6/18/24 12:50, Adrián Moreno wrote:
>>> On Tue, Jun 18, 2024 at 12:22:23PM GMT, Ilya Maximets wrote:
>>>> On 6/18/24 09:00, Adrián Moreno wrote:
>>>&g
On 6/19/24 16:07, Xin Long wrote:
> On Wed, Jun 19, 2024 at 8:58 AM Ilya Maximets wrote:
>>
>> On 6/18/24 17:50, Ilya Maximets wrote:
>>> On 6/18/24 16:58, Xin Long wrote:
>>>> On Tue, Jun 18, 2024 at 7:34 AM Ilya Maximets wrote:
>>>>>
>>
On 6/18/24 17:50, Ilya Maximets wrote:
> On 6/18/24 16:58, Xin Long wrote:
>> On Tue, Jun 18, 2024 at 7:34 AM Ilya Maximets wrote:
>>>
>>> On 6/17/24 22:10, Ilya Maximets wrote:
>>>> On 7/16/23 23:09, Xin Long wrote:
>>>>> By not setting IPS_C
On 6/11/24 16:02, Aaron Conole wrote:
> Ilya Maximets writes:
>
>> On 6/5/24 16:54, Aaron Conole wrote:
>>> Mike Pattrick writes:
>>>
>>>> When conntrack is reassembling packet fragments, the same reassembly
>>>> context can be sha
On 6/18/24 16:58, Xin Long wrote:
> On Tue, Jun 18, 2024 at 7:34 AM Ilya Maximets wrote:
>>
>> On 6/17/24 22:10, Ilya Maximets wrote:
>>> On 7/16/23 23:09, Xin Long wrote:
>>>> By not setting IPS_CONFIRMED in tmpl that allows the exp not to be removed
>>
On 6/18/24 12:50, Adrián Moreno wrote:
> On Tue, Jun 18, 2024 at 12:22:23PM GMT, Ilya Maximets wrote:
>> On 6/18/24 09:00, Adrián Moreno wrote:
>>> On Mon, Jun 17, 2024 at 02:10:37PM GMT, Ilya Maximets wrote:
>>>> On 6/17/24 13:55, Ilya Maximets wrote:
>>>
On 6/17/24 22:10, Ilya Maximets wrote:
> On 7/16/23 23:09, Xin Long wrote:
>> By not setting IPS_CONFIRMED in tmpl that allows the exp not to be removed
>> from the hashtable when lookup, we can simplify the exp processing code a
>> lot in openvswitch conntrack.
>>
On 6/18/24 09:00, Adrián Moreno wrote:
> On Mon, Jun 17, 2024 at 02:10:37PM GMT, Ilya Maximets wrote:
>> On 6/17/24 13:55, Ilya Maximets wrote:
>>> On 6/3/24 20:56, Adrian Moreno wrote:
>>>> The OVS_ACTION_ATTR_SAMPLE action is, in essence,
>>>> observa
On 6/18/24 11:47, Ilya Maximets wrote:
> On 6/18/24 09:33, Adrián Moreno wrote:
>> On Mon, Jun 17, 2024 at 12:44:45PM GMT, Ilya Maximets wrote:
>>> On 6/3/24 20:56, Adrian Moreno wrote:
>>>> Add support for a new action: emit_sample.
>>>>
>>>
On 6/18/24 09:33, Adrián Moreno wrote:
> On Mon, Jun 17, 2024 at 12:44:45PM GMT, Ilya Maximets wrote:
>> On 6/3/24 20:56, Adrian Moreno wrote:
>>> Add support for a new action: emit_sample.
>>>
>>> This action accepts a u32 group id and a variable-length cooki
On 6/18/24 09:38, Adrián Moreno wrote:
> On Mon, Jun 17, 2024 at 12:00:04PM GMT, Ilya Maximets wrote:
>> On 6/3/24 20:56, Adrian Moreno wrote:
>>> If the action has a user_cookie, pass it along to the sample so it can
>>> be easily identified.
>>>
>>> S
+trk flags, but after this patch we're only getting +rel+trk and not
new. This is a problem because we need to commit this connection with the label
and we do that for +new packets. If we can't get +new packet we'll have to
commit
ev
On 6/17/24 13:55, Ilya Maximets wrote:
> On 6/3/24 20:56, Adrian Moreno wrote:
>> The OVS_ACTION_ATTR_SAMPLE action is, in essence,
>> observability-oriented.
>>
>> Apart from some corner case in which it's used a replacement of clone()
>> for old kernels,
tput",
"userspace", "recirc" and now "emit_sample". "output" and "recirc" are
consuming the skb "naturally" by stealing it when it is the last action.
"userspace" has an explicit check to consume the skb if it is the last
action. "emit_sample" should have the similar check. It should likely
be added at the point of action introduction instead of having a separate
patch.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 6/17/24 09:08, Adrián Moreno wrote:
> On Fri, Jun 14, 2024 at 12:55:59PM GMT, Aaron Conole wrote:
>> Adrian Moreno writes:
>>
>>> The behavior of actions might not be the exact same if they are being
>>> executed inside a nested sample action. Store the probability of the
>>> parent sample acti
On 6/3/24 20:56, Adrian Moreno wrote:
> Add support for a new action: emit_sample.
>
> This action accepts a u32 group id and a variable-length cookie and uses
> the psample multicast group to make the packet available for
> observability.
>
> The maximum length of the user-defined cookie is set
const struct tc_action *a,
>struct tcf_result *res)
> {
> + u8 cookie_data[TC_COOKIE_MAX_SIZE] = {};
Is it necessary to initialize these 16 bytes on every call?
Might be expensive. We're passing the data length around,
so the uninitialized pa
On 6/17/24 09:46, David Marchand wrote:
> On Fri, Jun 14, 2024 at 6:22 PM Ilya Maximets wrote:
>>> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
>>> index 0fa37d5145..a260bc8485 100644
>>> --- a/lib/netdev-dpdk.c
>>> +++ b/lib/netdev-dpdk.c
>>&g
On 6/11/24 00:09, Alin Serdean wrote:
> Acked-by: Alin-Gabriel Serdean
Thanks! Applied.
Best regards, Ilya Maximets.
>
> On Mon, Jun 10, 2024 at 11:18 PM Ilya Maximets <mailto:i.maxim...@ovn.org>> wrote:
>
> Apparently, if the cache dependency is specified, t
On 6/14/24 17:08, David Marchand wrote:
> Querying link status may get delayed for an undeterministic (long) time
> with mlx5 ports. This is a consequence of the mlx5 driver calling ethtool
> kernel API and getting stuck on the kernel RTNL lock while some other
> operation is in progress under this
On 6/13/24 12:15, Eli Britstein wrote:
>
>
>> -Original Message-----
>> From: Ilya Maximets
>> Sent: Monday, 10 June 2024 15:53
>> To: Roi Dayan ; d...@openvswitch.org
>> Cc: Eli Britstein ; Maor Dickman ;
>> i.maxim...@ovn.org
>> Subject
dex 0a685750c..ed6365414 100644
>>> --- a/lib/ofp-prop.c
>>> +++ b/lib/ofp-prop.c
>>> @@ -271,10 +271,12 @@ enum ofperr
>>> ofpprop_parse_u128(const struct ofpbuf *property, ovs_u128 *value)
>>> {
>>>
; ```
>>
>> So I suggest to just remove 'return 0'.
Hi, Simon. This is not a correct thing to do. By design, only one flow API
should be able to accept a particular port type. If two API implementations
can accept the same port, that would b
7;ll no longer
pre-fault all the guest's memory. Post-copy relies on userfaultfd
to work on shared huge pages, which is only available in 4.11+ kernels.
So, technically, it should not be possible for MCL_ONFAULT to fail and
the call without it to succeed. But keeping the check just i
d the updated cache back.
Fixes: 9d8208484a35 ("appveyor: Build with OpenSSL 3.0.")
Reported-at:
https://help.appveyor.com/discussions/problems/36144-cache-reports-up-to-date-while-it-is-not
Signed-off-by: Ilya Maximets
---
appveyor.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
so it may be better
to encourage people to use a full word instead by not adding to the
dictionary.
Some added words like 'lexograpically' seem like just legit typos. This
is not how this word supposed to be spelled.
>>
>> To make it easier to review the words added, may
7;ll get data races and crashes on
out-of-range memory accesses.
We should technically remove all the 'qid % n_txq' stuff from all the
netdev implementations and replace them with ovs_assert() on the API
level. We had a few patches for that in the past, but they didn't get
proper a
On 6/7/24 16:42, Kevin Traynor wrote:
> On 07/06/2024 15:01, Ilya Maximets wrote:
>> We didn't make a stable release for a while. It's definitely time
>> to make one.
>>
>> Ilya Maximets (2):
>> Set release date for 3.3.1.
>>
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 31d235a40..aaf8d4b4a 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v3.3.1 - xx xxx
+v3.3.1 - 07 Jun 2024
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index aaf8d4b4a..f62d06ffb 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.3.2 - xx xxx
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 3.3.1.
Prepare for 3.3.2.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 43ab6d806..492b096db 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.2.4 - xx xxx
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 8baf3d2aa..43ab6d806 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v3.2.3 - xx xxx
+v3.2.3 - 07 Jun 2024
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 3.2.3.
Prepare for 3.2.4.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 44a3e6247..9604939b3 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v3.1.5 - xx xxx
+v3.1.5 - 07 Jun 2024
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 9604939b3..cf0700ab3 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.1.6 - xx xxx
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 3.1.5.
Prepare for 3.1.6.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 3.0.7.
Prepare for 3.0.8.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index 088bf0dd2..504c70b6b 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v3.0.8 - xx xxx
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index 8550e8e89..088bf0dd2 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v3.0.7 - xx xxx
+v3.0.7 - 07 Jun 2024
We didn't make a stable release for a while. It's definitely time
to make one.
Ilya Maximets (2):
Set release date for 2.17.10.
Prepare for 2.17.11.
NEWS | 6 +-
configure.ac | 2 +-
debian/changelog | 8 +++-
3 files changed, 13 insertions(+), 3
Signed-off-by: Ilya Maximets
---
NEWS | 3 ++-
debian/changelog | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index e91072dd6..a809e8e3d 100644
--- a/NEWS
+++ b/NEWS
@@ -1,5 +1,6 @@
-v2.17.10 - xx xxx
+v2.17.10 - 07 Jun 2024
Signed-off-by: Ilya Maximets
---
NEWS | 3 +++
configure.ac | 2 +-
debian/changelog | 6 ++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index a809e8e3d..8ba8a8d62 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,6 @@
+v2.17.11 - xx xxx
On 6/6/24 19:53, Adrián Moreno wrote:
> On Thu, Jun 06, 2024 at 06:00:26PM GMT, Ilya Maximets wrote:
>> On 6/6/24 17:15, Adrian Moreno wrote:
>>> Add check_pkt_len action to the decoder list that it, itself, uses.
>>>
>>> This makes nested check_pkt_len
On 6/6/24 20:55, Terry Wilson wrote:
> On Thu, Jun 6, 2024 at 10:41 AM Dumitru Ceara wrote:
>>
>> On 5/27/24 23:39, Ilya Maximets wrote:
>>> When a row is modified, python IDL doesn't perform any operations on
>>> existing client-side indexes. This means th
.
Applied remaining 2 patches and backported them down to 3.1.
Best regards, Ilya Maximets.
>
> Terry
>
> On Wed, Apr 10, 2024 at 4:39 PM Terry Wilson wrote:
>>
>> The Python IDL code very closely mirrors the C IDL code, which uses
>> an hmap to store table rows.
tart from the beginning of the line for patchwork to
recognize them.)
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
every single caller separately. And we're still copying the TCP
header anyway.
Fixes: 9726a016d9d6 ("datapath-windows: Implement locking in conntrack NAT.")
Reported-at: https://github.com/openvswitch/ovs-issues/issues/323
Signed-off-by: Ilya Maximets
---
WARNING: I beleive this co
On 6/3/24 17:09, Simon Horman wrote:
> On Fri, May 31, 2024 at 11:45:12PM +0200, Ilya Maximets wrote:
>> OVS can parse NSH, but can't compose. Fix that and get rid of plain
>> hex NSH packets in system tests as they are hard to read or modify.
>>
>> Tcpdump call
David and Kevin!
I generally like the direction of this patch set, especially the
cleanup of the generic tunnel code.
I didn't test it with a real hardware nor I re-checked the math,
so will not Ack it, but it looks good to me otherwise, and I think
we should backport the who
ilobytes', 'megabytes',
> 'mbps',
>
>
> unless anyone objects. This is to squelch:
>
> == Checking 16f6885353c2 ("ipf: Handle common case of ipf defragmentation.")
> ==
> WARNING: Possible misspelled word: "defragmented"
> Did you mean: ['defragment ed', 'defragment-ed', 'defragment']
> Lines checked: 129, Warnings: 1, Errors: 0
It doesn't affect CI today, so can be a separate patch, I think. We have a few
more
words like this in relatively recent commits, like 'poller' or 'autovalidator',
these
can be bundled in that separate commit as well.
Though updating the dictionary along with the patch that is using the word
sounds OK
to me as well.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
t;<=', '>>=']] \
> + [r'[^<" ]<[^=" ]',
> r'[^\->" ]>[^=" ]',
> - r'[^ !()/"]\*[^/]',
> + r'[^ !()/"\*]\*[^/]',
> r'[^ !&()"]&',
> r'[^" +(]\+[^"+;]',
> r'[^" \-(]\-[^"\->;]',
Please, add a unit test for this issue.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 6/4/24 13:42, Eelco Chaudron wrote:
>
>
> On 1 Jun 2024, at 0:08, Ilya Maximets wrote:
>
>> On 5/7/24 15:52, Eelco Chaudron wrote:
>>> While offloading header modifications to TC, OVS is using {TCA_PEDIT} +
>>> {TCA_CSUM} combination as that it the only
7;d prefer this fixed in OpenStack instead.
Best regards, Ilya Maximets.
>
> On Tue, Jun 4, 2024 at 11:05 AM Simon Horman wrote:
>
>> + Ihar
>>
>> On Fri, May 31, 2024 at 03:40:08PM -0400, Brian Haley wrote:
>>> An earlier patch [1] increased the si
long delay.
I'm considering this as a bug fix, because the use of a plain monitor
causes a significant traffic amplification with every small transactions
and can potentially create serious issues in large scale clusters.
Applied to main. Backporting to 2.17 is probably too much, so on
on should return 1 row,
the second should return both duplicates and the third should again
return one row.
Ideally, implementation should not leak the transaction details to
the query module, though I'm not sure if that is 100% achievable.
2. Taking above case into account, this ch
On 6/3/24 13:14, Eelco Chaudron wrote:
>
>
> On 3 Jun 2024, at 13:12, Ilya Maximets wrote:
>
>> '\+' as a one-or-more match is a GNU extension and it doesn't work
>> in BSD sed. This makes the python vlog test to fail on FreeBSD 14
>&
ange makes CirruCI green again.
Fixes: 9185793e7543 ("tests: Fix compatibility issue with Python 3.13 in
vlog.at.")
Signed-off-by: Ilya Maximets
---
tests/vlog.at | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/vlog.at b/tests/vlog.at
index efe91479a..2768c074
Protocol: UDP (17)
> +dnl Header Checksum: 0x44c2
> +dnl Data (18 bytes)
> +eth="36 b1 ee 7c 01 02 36 b1 ee 7c 01 03 08 00"
> +ip="45 00 00 26 00 01 20 00 40 11 44 c2 0a 01 01 01 0a 01 01 02"
> +data="0b c4 08 84 00 26 e9 64 01 02 03 04 05 06 07 0
with more robust waiting for tcpdump
to start listening.
M4 macros are better than shell variables, because we can see the
substitution result in the test log. So, using m4_define and m4_join
extensively.
Signed-off-by: Ilya Maximets
---
lib/flow.c | 18
tests/system-traffic.at
sleeps with more robust waiting for tcpdump
to start listening.
M4 macros are better than shell variables, because we can see the
substitution result in the test log. So, using m4_define and m4_join
extensively.
Signed-off-by: Ilya Maximets
---
tests/system-traffic.at | 233
.
Signed-off-by: Ilya Maximets
---
tests/sendpkt.py | 26 --
1 file changed, 4 insertions(+), 22 deletions(-)
diff --git a/tests/sendpkt.py b/tests/sendpkt.py
index 49ac45275..7cbea5165 100755
--- a/tests/sendpkt.py
+++ b/tests/sendpkt.py
@@ -48,28 +48,10 @@ if len(args) <
esn't fully parse
and doesn't have a way to represent fully in OpenFlow.
Next step might be to replace some of the packet-out calls as well.
Ilya Maximets (3):
tests: sendpkt: Allow different input formats.
tests: Convert ND, MPLS and CT sendpkt tests to compose-packet.
nsh: Add sup
for TSO packet. Flags:
> %"PRIx64,
I'd suggest adding the # qualifier to the format string, i.e. %#"PRIx64.
Can be fixed on commit, I suppose.
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
e it's not cleared properly.
>
> Fixes: 07ff77ccb82a ("db-ctl-base: Make common database command code into
> library.")
> Signed-off-by: Eelco Chaudron
> ---
> lib/db-ctl-base.c | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Ilya Maximets
On 5/30/24 15:10, David Marchand wrote:
> If outer checksum is not supported and OVS already set L3/L4 outer
> checksums in the packet, no outer mark should be left in ol_flags
> (as it confuses some driver, like net/ixgbe).
>
> l2_len must be adjusted to account for the tunnel header.
>
> Fixes:
On 5/30/24 15:10, David Marchand wrote:
> The outer checksum offloading API in DPDK is ambiguous and was
> implemented by Intel folks in their drivers with the assumption that
> any outer offloading always goes with an inner offloading request.
>
> With net/i40e and net/ice drivers, in the case of
On 5/30/24 09:28, Eelco Chaudron wrote:
>
>
> On 29 May 2024, at 12:53, Eelco Chaudron wrote:
>
>> The sFlow library uses a uint32_t to configure timeout ticks, but
>> stores this value as a time_t. Although this doesn't cause functional
>> issues, it wastes space and confuses Coverity, potentia
On 5/31/24 04:00, Simon Jones wrote:
> Hi all,
>
> I'm using ovs-dpdk(ovs:2.17.1, dpdk:21.11.1).
> Now I found a BUG that ovs crash and could NOT fix again after set
> request_mtu.
>
> 1. How to reproduce and my Analysis:
> ```
> # start ovs and add bridge and port and openflow
>
> [root@bogon ~
On 5/30/24 20:17, Ilya Maximets wrote:
> On 5/30/24 01:27, William Tu wrote:
>> Add route-table support for ipv4 dst via ipv6. One use case is BGP
>> unnumbered, a mechanism that establishes peering sessions without the
>> need to explicitly configure IPv4 addresses on th
, [dnl
recirc_id(0),in_port(2),packet_type(ns=0,id=0),dnl
eth(src=50:54:00:00:00:09,dst=50:54:00:00:00:0a),eth_type(0x1234), dnl
packets:1, bytes:14, used:0.0s, dnl
actions:tnl_push(tnl_port(6081),header(size=50,type=5,dnl
eth(dst=f8:bc:12:44:34:b6,src=aa:55:aa:55:00:00,dl_type=0x0800),dnl
ipv4(src=1.
, " (%s %s)", program_name, VERSION VERSION_SUFFIX);
>
> if (inner_error) {
> char *s = ovsdb_error_to_string_free(inner_error);
> diff --git a/lib/util.c b/lib/util.c
> index 5c31d983a..c03a1ae15 100644
> --- a/lib/util.c
> +++ b/lib/util.c
> @@
On 5/29/24 12:53, Eelco Chaudron wrote:
> This patch fixes an uninitialized gso_type case in
> netdev_linux_prepend_vnet_hdr() by returning an error.
>
> Fixes: 3337e6d91c5b ("userspace: Enable L4 checksum offloading by default.")
> Signed-off-by: Eelco Chaudron
> ---
Recheck-request: github-rob
On 5/29/24 12:53, Eelco Chaudron wrote:
> Coverity has flagged the use of a potentially unsafe function.
> Although this is not a concern in this case since it's not used for
> encryption, we should replace it with the OVS implementation to
> achieve better randomness.
>
> Fixes: c72e245a0e2c ("Ad
On 5/29/24 12:53, Eelco Chaudron wrote:
> Fix the warning from Coverity about potential truncation of the
> time_t value when copying to a local variable by changing the
> local variable's type to time_t.
>
> Fixes: ccc24fc88d59 ("ofproto-dpif: APIs and CLI option to add/delete static
> fdb entry
;s sFlow Agent library to the build system.")
> Acked-by: Ilya Maximets
> Signed-off-by: Eelco Chaudron
> --
> Note that this checkpatch reports an 'Improper whitespace
> around control block' error on this patch + some warnings.
> But I did not want to change
On 5/29/24 12:53, Eelco Chaudron wrote:
> The sFlow library uses a uint32_t to configure timeout ticks, but
> stores this value as a time_t. Although this doesn't cause functional
> issues, it wastes space and confuses Coverity, potentially indicating
> a Y2K38 problem when storing uint32_t values
On 5/29/24 12:53, Eelco Chaudron wrote:
> Fix unintentional integer overflow reported by Coverity by adding
> the LL suffix to the numerical literals used in the multiplication.
>
> Fixes: 5767a79a4059 ("cfm: Require ccm received in demand mode.")
> Acked-by: Mike Pattrick
> Signed-off-by: Eelco
On 5/29/24 11:01, Eelco Chaudron wrote:
>
>
> On 28 May 2024, at 16:49, Ilya Maximets wrote:
>
>> On 5/28/24 14:36, Eelco Chaudron wrote:
>>>
>>>
>>> On 24 May 2024, at 11:20, Emma Finn wrote:
>>>
>>>> The AVX implementation f
migrate from the legacy ethtool_cmd API at some point,
but this change makes sense for now.
Applied to main and backported down to 3.3. Thanks!
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ues
are zeroed out even on errors. That is defined in netdev-provider API. But
the new static netdev_linux_get_speed_locked() function didn't do the same.
I fixed that and applied the set. Individual patches backported according to
their Fixes tags. Thanks!
Best regards, Ilya Maximets.
___
the message since 'TSO' contains 'offload'
and it's not necessarily hardware here. Also, flags are better printed in hex,
i.e. %#"PRIx64. And there is a missing space between the cast and a variable.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
entire file.
> ---
> lib/sflow_api.h | 6 +++---
> lib/sflow_receiver.c | 7 ---
> ofproto/ofproto-dpif-sflow.c | 2 +-
> 3 files changed, 8 insertions(+), 7 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
On 5/28/24 19:35, Ilya Maximets wrote:
> On 5/21/24 10:38, Martin Kalcok wrote:
>> Help text for 'ovsdb-client dump' does not mention that it's capable
>> of dumping a specific column's contents if the user supplies the
>> column's name as a fourth po
r all tables) in DATABASE\n"
> + "on SERVER to stdout\n"
I think it was '[TABLE [COLUMN]...]' until commit 85226894ddec
("ovsdb-client: support monitor2") removed that part on accident.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
, as
Simon pointed out previously. The change you're proposing may have
some performance impact as we'll be holding the shared mutex for
longer while allocating IDs, so I'd like to understand why it is a
problem before making the change.
Best regards, Ilya Maximets.
ailable_prio(ovs_be16 protocol)
> return TC_RESERVED_PRIORITY_IPV4;
> } else if (protocol == htons(ETH_P_IPV6)) {
> return TC_RESERVED_PRIORITY_IPV6;
> +} else if (protocol == htons(ETH_P_8021Q)) {
low
should not be freed until the processing is over.
The flow will be dead in this case with a zero counter, but it
is not freed, i.e. should be accessible.
Do you know what exactly failed in odp_execute_actions ?
Your version of the code seems to be very differe
ter made some noticeable changes to the original patch,
or if they want to clarify something that wasn't fully explained
by the original commit message. I add those sometimes as well.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
tion/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 13 insertions(+), 11 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
tion/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 13 insertions(+), 11 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 11 insertions(+), 9 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 10 insertions(+), 8 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 9 insertions(+), 7 deletions(-)
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
/intro/install/dpdk.rst | 8
> NEWS | 2 ++
> 4 files changed, 8 insertions(+), 6 deletions(-)
Didn't test, but LGTM.
Acked-by: Ilya Maximets
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
ose?
For now, I'll mark this patch with 'Changes Requested'.
If you plan to send a new version based on Mike's comments, please, add
'v6' to the subject prefix, i.e. [PATCH v6], since it's technically a
6th version of it.
Best regards, Ilya Maximets.
__
On 5/28/24 14:36, Eelco Chaudron wrote:
>
>
> On 24 May 2024, at 11:20, Emma Finn wrote:
>
>> The AVX implementation for calcualting checksums was not
>> handling carry-over addition correctly in some cases.
>> This patch adds an additional shuffle to add 16-bit padding to
>> the final part of t
of code and OVS will still need a decent amount of
glue to pair with the library as well as maintain OVS-specific counters, I
think,
it's better to keep things as-is for now and try to periodically sync with the
original code from host-sflow. Sub-projects/modules/trees a
/NEWS
> +++ b/NEWS
> @@ -8,4 +8,6 @@ Post-v3.3.0
> The OVS tree remains hosted on GitHub.
> https://github.com/openvswitch/ovs.git
> + - DPDK:
> + * Add support for DPDK 23.11.1.
>
>
Same here. 'validated with'?
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
a/NEWS
> +++ b/NEWS
> @@ -1,4 +1,7 @@
> v3.3.1 - xx xxx
>
> + - DPDK:
> + * Add support for DPDK 23.11.1.
> +
We're normally using 'validated with'.
And the extra line is not needed here.
Best regards, Ilya Maximets.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
301 - 400 of 1817 matches
Mail list logo
