> On Jul 16, 2018, at 7:39 PM, Darrell Ball wrote:
>
> diff --git a/lib/flow.c b/lib/flow.c
> index 76a8b9a..e84a40d 100644
> --- a/lib/flow.c
> +++ b/lib/flow.c
> @@ -453,9 +453,14 @@ invalid:
> return true;
> }
>
> +/* datap points to the first extension header and advances as parsing
>
> On Jul 16, 2018, at 7:39 PM, Darrell Ball wrote:
>
> Use 'must' instead of 'should'.
>
> Signed-off-by: Darrell Ball
> ---
> lib/conntrack.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/conntrack.c b/lib/conntrack.c
> index 682feb9..3f50fc8 100644
> --- a/lib
> On Jul 16, 2018, at 7:39 PM, Darrell Ball wrote:
>
> +static void
> +ipf_expiry_list_add(struct ipf_list *ipf_list, long long now)
> +OVS_REQUIRES(ipf_lock)
> +{
> +enum {
> +IPF_FRAG_LIST_TIMEOUT_DEFAULT = 15000,
> +};
> +
> +ipf_list->expiration = now + IPF_FRAG_LIST
> On Jul 16, 2018, at 4:39 PM, Darrell Ball wrote:
>
> diff --git a/lib/dpctl.man b/lib/dpctl.man
> index 5d987e6..a1eb026 100644
> --- a/lib/dpctl.man
> +++ b/lib/dpctl.man
> @@ -272,3 +272,18 @@ Only supported for userspace datapath.
> \*(DX\fBct\-get\-nconns\fR [\fIdp\fR]
> Prints the curren
> On Jul 16, 2018, at 4:39 PM, Darrell Ball wrote:
> diff --git a/lib/ct-dpif.h b/lib/ct-dpif.h
> index bd6234d..6eb55b4 100644
> --- a/lib/ct-dpif.h
> +++ b/lib/ct-dpif.h
> @@ -17,6 +17,7 @@
> #ifndef CT_DPIF_H
> #define CT_DPIF_H
>
> +#include "ipf.h"
I don't think it's necessary to add th
> On Jul 16, 2018, at 4:39 PM, Darrell Ball wrote:
>
> diff --git a/lib/dpctl.man b/lib/dpctl.man
> index a75fc77..f5a36b0 100644
> --- a/lib/dpctl.man
> +++ b/lib/dpctl.man
> @@ -296,3 +296,11 @@ must be specified. The default v4 value is 1200 and the
> clamped minimum is
> 400. The default
f you want to apply
the patch at the bottom and give ACL rate-limiting a try, I'd love to get some
initial feedback.
Thanks,
--Justin
-=-=-=-=-=-=-=-=-=-
commit bc89eebb0e918d2e9a903d7e4a24ab1b5b522eab (HEAD -> meter-datapath)
Author: Justin Pettit
Date: Thu Jul 26 22:28:11 2018 -0
Thanks, Greg. I actually have this queued up with another patch that will
disable meters entirely on broken kernels. I plan to send that out tomorrow.
--Justin
> On Aug 7, 2018, at 4:45 PM, Greg Rose wrote:
>
> From: Justin Pettit
>
> Upstream commit:
>From: Justin
> On Sep 26, 2017, at 8:45 AM, Ben Pfaff wrote:
>
> On Mon, Sep 25, 2017 at 11:32:50PM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Acked-by: Ben Pfaff
Thanks. I pushed the series to branch-2.7.
--Justin
__
Signed-off-by: Justin Pettit
---
NEWS | 4
configure.ac | 2 +-
debian/changelog | 7 +++
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/NEWS b/NEWS
index ef3abd56b7f2..669d4ac8 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,7 @@
+v2.8.2 - xx xxx
Signed-off-by: Justin Pettit
---
NEWS | 5 +++--
debian/changelog | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/NEWS b/NEWS
index 7e9c0f63a90b..ef3abd56b7f2 100644
--- a/NEWS
+++ b/NEWS
@@ -1,8 +1,9 @@
-v2.8.1 - xx xxx
-
+v2.8.1 - 26
> On Sep 26, 2017, at 3:58 PM, Ben Pfaff wrote:
>
> On Tue, Sep 26, 2017 at 01:37:37PM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Acked-by: Ben Pfaff
Thanks. I pushed the series to branch-2.8.
--Justin
__
Hi, Ben. Can you tag the following commits?
v2.8.1: 5c67e9cfc1eaab
v2.7.3: b8dcfbebee9e7
v2.5.4: aeb353a9fafb4
Thank you!
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-
> On Sep 29, 2017, at 10:08 AM, Ben Pfaff wrote:
>
> On Fri, Sep 29, 2017 at 09:57:42AM -0700, Justin Pettit wrote:
>> Hi, Ben. Can you tag the following commits?
>>
>> v2.8.1: 5c67e9cfc1eaab
>>
>> v2.7.3: b8dcfbebee9e7
>>
>>
Signed-off-by: Justin Pettit
---
Documentation/faq/qos.rst | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/Documentation/faq/qos.rst b/Documentation/faq/qos.rst
index ad3d95bf4fc0..1cd01f67fc9c 100644
--- a/Documentation/faq/qos.rst
+++ b/Documentation/faq/qos.rst
> On Oct 13, 2017, at 3:20 PM, Ben Pfaff wrote:
>
> On Fri, Oct 13, 2017 at 02:57:47PM -0700, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Acked-by: Ben Pfaff
Thanks. I pushed this to master and branch-2.8.
--Justin
__
Acked-by: Justin Pettit
--Justin
> On Oct 26, 2017, at 2:33 PM, Ben Pfaff wrote:
>
> From: Russell Bryant
>
> This patch introduces an Emeritus status for OVS committers. An
> Emeritus Committer is recognized as having made a significant impact
> to the project and ha
> On Nov 13, 2017, at 12:12 PM, Yi-Hung Wei wrote:
>
> This patch adds support of flushing a conntrack entry specified by the
> conntrack 5-tuple, and provides the implementation in dpif-netlink.
> The implementation of dpif-netlink in the Linux datapath utilizes the
> NFNL_SUBSYS_CTNETLINK net
> On Nov 13, 2017, at 12:13 PM, Yi-Hung Wei wrote:
>
> With this patch, ovs-dpctl flush-conntrack accepts a conntrack 5-tuple
I'd also mention ovs-appctl, since ovs-dpctl doesn't work on all platforms.
> diff --git a/NEWS b/NEWS
> index 047f34b9f402..800eb84cd24f 100644
> --- a/NEWS
> +++ b/N
Signed-off-by: Justin Pettit
---
Documentation/internals/contributing/submitting-patches.rst | 2 +-
Documentation/internals/security.rst| 2 +-
lib/netdev-linux.c | 6 +++---
lib/ovs-thread.c
Signed-off-by: Justin Pettit
---
ovn/TODO.rst | 69
1 file changed, 69 deletions(-)
diff --git a/ovn/TODO.rst b/ovn/TODO.rst
index f8569b357281..34615b9bc7d4 100644
--- a/ovn/TODO.rst
+++ b/ovn/TODO.rst
@@ -27,22 +27,9 @@ OVN To-do
> On Nov 27, 2017, at 2:57 PM, Ben Pfaff wrote:
>
> On Mon, Nov 27, 2017 at 02:28:37PM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> If you checked that the new URLs are correct (I did not), then:
> Acked-by: Ben Pfaff
Thanks. I pushed this to mas
Yes. I did the first round, and I'll do this one today.
--Justin
> On Nov 29, 2017, at 9:58 AM, Ben Pfaff wrote:
>
> Justin, are you the right person to review this series?
>
> Thanks,
>
> Ben.
>
> On Tue, Nov 21, 2017 at 05:00:52PM -0800, Yi-Hung Wei wrote:
>> This patch series add suppor
The zone Netlink attribute is supposed to be in network-byte order, but
the Windows code for deleting conntrack entries was treating it as
host-byte order.
Found by inspection.
Signed-off-by: Justin Pettit
---
datapath-windows/ovsext/Conntrack.c | 2 +-
lib/netlink-conntrack.c | 2
> On Nov 21, 2017, at 5:00 PM, Yi-Hung Wei wrote:
>
> This patch adds support of flushing a conntrack entry specified by the
> conntrack 5-tuple, and provides the implementation in dpif-netlink.
> The implementation of dpif-netlink in the linux datapath utilizes the
> NFNL_SUBSYS_CTNETLINK netl
> On Nov 21, 2017, at 5:00 PM, Yi-Hung Wei wrote:
>
> diff --git a/lib/conntrack.c b/lib/conntrack.c
> index f5a3aa9fab34..c9077c07042c 100644
> --- a/lib/conntrack.c
> +++ b/lib/conntrack.c
> @@ -2335,6 +2335,18 @@ ct_endpoint_to_ct_dpif_inet_addr(const struct ct_addr
> *a,
> }
>
> static vo
> On Nov 21, 2017, at 5:00 PM, Yi-Hung Wei wrote:
> diff --git a/lib/ct-dpif.c b/lib/ct-dpif.c
> index 5cd6b5cfd870..3cad5c928e8b 100644
> --- a/lib/ct-dpif.c
> +++ b/lib/ct-dpif.c
>
> @@ -434,3 +435,110 @@ ct_dpif_format_tcp_stat(struct ds * ds, int tcp_state,
> int conn_per_state)
> ds_pu
Signed-off-by: Justin Pettit
---
lib/dpctl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/dpctl.c b/lib/dpctl.c
index 06cfbc4abf21..5e064ec9c100 100644
--- a/lib/dpctl.c
+++ b/lib/dpctl.c
@@ -129,8 +129,8 @@ if_up(struct netdev *netdev)
}
/* Retrieve the name
> On Dec 7, 2017, at 8:21 AM, Ben Pfaff wrote:
>
>> On Wed, Dec 06, 2017 at 10:19:23PM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>> ---
>> lib/dpctl.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>>
> On Dec 7, 2017, at 10:40 AM, Yi-Hung Wei wrote:
>
> This patch series add support to flush a connection tracking entry
> specified by a 5-tuple.
Thanks for the patches. I pushed the series to the master branch.
--Justin
___
dev mailing list
d..
> On Dec 7, 2017, at 2:57 PM, Sairam Venugopal wrote:
>
> Thanks for the patch. Discussed about the patch offline.
>
> This is required since we have now introduced a newer api for deleting
> 5-tuples
> and this breaks the assumption of zone-id not being in the right byte order.
>
> Acked-b
> On Dec 8, 2017, at 11:43 AM, Ben Pfaff wrote:
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
; ovsdb-server did not. This fixes the problem.
>
> Found by inspection.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
"); print $0 }
> vconn_sub() {
> sed '
> s/tcp:127.0.0.1:[0-9][0-9]*:/unix:/
> +s/unix#[0-9]:/unix:/
It looks like this will support up to a single digit number of domain sockets
being created. Do you think it's worth making just su
> On Dec 8, 2017, at 12:53 PM, Ben Pfaff wrote:
>
> It seems best to be explicit about this.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/m
> On Dec 8, 2017, at 1:01 PM, Ben Pfaff wrote:
>
> The error message in question is about the monitor session ID but it
> actually reports the JSON-RPC request ID instead, which is surprising.
>
> Found by inspection.
>
> Signed-off-by: Ben Pfaff
Acked-by:
er utilities. It
> seems easier to just always ignore them.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Signed-off-by: Justin Pettit
---
Documentation/topics/testing.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/topics/testing.rst b/Documentation/topics/testing.rst
index 85aa6a1fb495..1ecda00d069c 100644
--- a/Documentation/topics/testing.rst
+++ b
> On Dec 8, 2017, at 3:28 PM, Ben Pfaff wrote:
>
> On Fri, Dec 08, 2017 at 03:18:42PM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>> ---
>> Documentation/topics/testing.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
> On Dec 8, 2017, at 6:23 PM, Darrell Ball wrote:
>
>
>I believe the kernel clears out expectations. As we discussed off-line, I
> think it would make sense to follow similar behavior, since presumably if the
> control channel is being flushed, the related flows should be, too.
>
> [Da
multiple times. For
example, the first two sections are very similar to the text later that
actually describe the arguments.
> diff --git a/ovsdb/ovsdb-tool.1.in b/ovsdb/ovsdb-tool.1.in
> index 8c799f4cc990..ebfd33b27163 100644
> --- a/ovsdb/ovsdb-tool.1.in
> +++ b/ovsdb/ovsdb-tool.1.in
>
> .
> -.SS "Basic Commands"
> -.IP "\fBcreate\fI db schema\fR"
> -Reads an OVSDB schema from the file named \fIschema\fR and creates a
> -new OVSDB database file named \fIdb\fR using that schema. The new
> -database is initially empty. This command will not overwrite an
> -existing \fIdb\fR.
> -.IP
> -\fIschema\fR must contain an OVSDB schema in JSON format. Refer to
> -the OVSDB specification for details.
> +.SS "Database Creation Commands"
> +These commands create a new OVSDB database file.
> +They will not overwrite an existing database file. To
Is there more than one creation command? The title and use of "these" and
they" indicate there are. Maybe it's coming with clustering? If so, it's not
worth changing in the interim.
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On Dec 13, 2017, at 3:10 PM, Ben Pfaff wrote:
>
> Delete the "tcp socket" version of the test--really there's no point in
> trying everything over N different kinds of sockets.
>
> Signed-off-by: Ben Pfaff
A
> On Dec 13, 2017, at 3:10 PM, Ben Pfaff wrote:
>
> I don't have a particular use for this but it allows ovsdb-client to do
> all the things with schemas that ovsdb-tool can.
>
> Signed-off-by: Ben Pfaff
Acked-by: J
truct ds *header, struct ds *data)
> +{
> +ovs_assert(json->type == JSON_OBJECT || json->type == JSON_ARRAY);
> +ovs_assert(!header->length);
> +ovs_assert(!data->length);
Since it asserts if 'header' or 'data' have been used, it might be wor
fIdatabase\fR] > \fIsnapshot\fR"
Same question about simplifying the markup.
> +Connects to \fIserver\fR, retrieves a snapshot of the schema and data
> +in \fIdatabase\fR, and prints it on stdout in the format used for
> +OVSDB standalone and active-backup database. This is an
"\n backup [SERVER] [DATABASE] > DB\n"
>"dump database contents in the form of a database file\n"
> + "\n [--force] restore [SERVER] [DATABASE] < DB\n"
> + "restore database con
"transact" and "query" is that
"query" is read-only. The man page descriptions are slightly different between
the commands, so it wasn't immediately obvious that was the only difference.
It might be worth making it a bit more concrete--possibly even by direct
gt; + "duplicate monitor ID");
> +goto error;
> +}
As we discussed off-line, I found the logic a bit confusing. It might be
clearer with either a comment or a slight restructuring of the code.
Acked-by: Justin Pettit
--Justin
> On Nov 28, 2017, at 4:42 PM, Ben Pfaff wrote:
>
> OVS practice has evolved over time to mix code and data more freely.
>
> See also:
> https://mail.openvswitch.org/pipermail/ovs-dev/2017-November/341032.html
>
> Signed-off-by: Ben Pfaff
Acked-by:
https://github.com/faucetsdn/faucet/blob/master/docs/README_config.rst
> which tend to suggest datapath IDs like 0x1.
>
> CC: Josh Bailey
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.or
l[type].next_max;
> They didn't do it properly because the first line changes 'tbl', so that
> the first and seconds lines' references to tbl[type] refer to different
> objects.
>
> This commit fixes the problem.
>
> Found by libfuzzer.
Signed-off-by: Justin Pettit
---
ofproto/ofproto-dpif-upcall.h | 2 +-
ofproto/ofproto-dpif-xlate.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ofproto/ofproto-dpif-upcall.h b/ofproto/ofproto-dpif-upcall.h
index efa3cd190084..cef1d34198d6 100644
--- a/ofproto/ofproto
ore modern and should have support, so it's no longer necessary to
probe.
Signed-off-by: Justin Pettit
---
ofproto/ofproto-dpif-xlate.c | 7
ofproto/ofproto-dpif.c | 85
ofproto/ofproto-dpif.h | 6
3 files changed, 98 del
Most other OVS libraries' delete and uninitialization functions allow a
null argument, but this one would cause a segfault.
Signed-off-by: Justin Pettit
---
ofproto/ofproto-dpif-xlate-cache.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/ofproto/ofproto-dpif-xlate-cache.c
b/of
This will have callers in the future.
Signed-off-by: Justin Pettit
---
ofproto/ofproto-dpif-trace.c | 2 +-
ofproto/ofproto-dpif.c | 92 +++-
ofproto/ofproto-dpif.h | 13 +--
3 files changed, 77 insertions(+), 30 deletions(-)
diff --git
- This reduces the number of times upcall cookies are processed.
- It separate true miss calls from slow-path actions.
The reorganization will also be useful for a future commit.
Signed-off-by: Justin Pettit
---
ofproto/ofproto-dpif-upcall.c | 91
It isn't otherwise useful and in fact hurts performance so it's disabled
without --enable-dummy.
An upcoming commit will make use of this.
Signed-off-by: Justin Pettit
---
include/openvswitch/ofp-actions.h | 1 +
lib/ofp-actions.c
).
Signed-off-by: Justin Pettit
---
lib/odp-util.c| 27 ++---
lib/odp-util.h| 24 ++-
ofproto/ofproto-dpif-upcall.c | 70 +++
ofproto/ofproto-dpif-xlate.c | 19
ofproto/ofproto-dpif.c
A previous patch removed slow-pathing for controller actions with the
exception of ones that specified "pause". This commit removes that
restriction so that no controller actions are slow-pathed.
Signed-off-by: Justin Pettit
---
lib/odp-util.h | 2 +-
ofproto/of
actions with the "pause" flag
set. A future patch will stop slow-pathing these pause actions as
well.
Signed-off-by: Justin Pettit
---
NEWS | 1 +
lib/odp-util.c| 27
lib/odp-util.h| 24 +++-
ofproto/ofproto-dpif-upca
Signed-off-by: Justin Pettit
---
lib/dpif.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/dpif.h b/lib/dpif.h
index ab898f4be2dd..2e739dc784be 100644
--- a/lib/dpif.h
+++ b/lib/dpif.h
@@ -787,9 +787,9 @@ const char *dpif_upcall_type_to_string(enum
> On Dec 21, 2017, at 10:21 AM, Ben Pfaff wrote:
>
> On Wed, Dec 20, 2017 at 07:42:39PM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Acked-by: Ben Pfaff
Thanks. I pushed this with yours and Yufeng's acks.
--Justin
_
> On Dec 21, 2017, at 10:05 AM, Yifeng Sun wrote:
>
> Thanks, looks good to me.
>
> Reviewed-by: Yifeng Sun
Thanks. I pushed this with yours and Ben's acks.
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/
> On Dec 21, 2017, at 3:24 PM, Gregory Rose wrote:
>
> On 12/21/2017 2:28 PM, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>> ---
>> lib/dpif.h | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/
> On Dec 8, 2017, at 12:54 PM, Ben Pfaff wrote:
>
> This can make it easier to read tables that contain wide data in some
> columns.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@ope
ittle odd to me. I think it will only provide
this warning if multiple databases are specified, and only complain if the
first one is built-in.
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
tal about it.
> Thus, we might as well ignore constraints for the purpose of dumping
> tables.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
In addition,
> the user might supply more options than can really fit in any case, so
> we might as well just use a stub.
>
> Found by libfuzzer.
>
> Reported-by: Bhargava Shastry
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
_
ustomary to use an ofpbuf with a stub of uint64_t objecs (to ensure
> proper alignment, otherwise uint8_t would be more usual). This commit
> changes to that more usual form.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
changes, I assume including "" on Windows is fine.
I just wanted to make sure, since it seems like there were some hoops jumped
for Windows.
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
gt; +hmap_remove(&s->monitors, &m->node);
> +json_destroy(m->monitor_id);
> +m->monitor_id = json_clone(new_monitor_id);
> +hmap_insert(&s->monitors, &m->node, json_hash(m->monitor_id, 0));
> +}
is a
substring of existing one (e.g., just "OVSDB"), then this will not catch it.
Probably not a big deal in practice, though.
> @@ -132,6 +158,7 @@ ovsdb_log_open(const char *name, enum ovsdb_log_open_mode
> open_mode,
>
> file = xmalloc(sizeof *file);
tely this resulted in a large number of updates to tests,
> which didn't always use JSON objects.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On Dec 7, 2017, at 4:12 PM, Ben Pfaff wrote:
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On Dec 7, 2017, at 4:12 PM, Ben Pfaff wrote:
>
> This saves all the callers from logging them separately.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.
> On Dec 7, 2017, at 4:12 PM, Ben Pfaff wrote:
>
> Until now, OVSDB_LOG_CREATE implied EXCL, but this commit breaks them
> apart.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@ope
havior as an error. Upcoming changes to OVSDB are going to make it an
> expected behavior in some cases, so this commit changes it so that it
> just becomes an empty read.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
7;state' variable, so this commit introduces one.
>
> This commit duplicates code and logic from ovsdb_rename() and
> ovsdb_compact() in ovsdb/file.c. A future commit removes this duplication.
>
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
> On Dec 7, 2017, at 4:12 PM, Ben Pfaff wrote:
>
> This will acquire a new user later on.
>
> Signed-off-by: Ben Pfaff
I think this patch has already been reviewed and merged.
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvs
> On Dec 7, 2017, at 4:12 PM, Ben Pfaff wrote:
>
> On Unix-like systems, usually /dev/stdin opens a duplicate of fd 0, and
> this will be convenient in a few places later on. This commit makes this
> support universal.
>
> Signed-off-by: Ben Pfaff
Acked-by: Jus
The man page indicated that multiple databases could be specified, but
only one is allowed.
Signed-off-by:Justin Pettit
---
ovsdb/ovsdb-server.1.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ovsdb/ovsdb-server.1.in b/ovsdb/ovsdb-server.1.in
index 870459e5d9ac..15ff77
Signed-off-by: Justin Pettit
---
ovsdb/ovsdb-client.1.in | 68 -
1 file changed, 34 insertions(+), 34 deletions(-)
diff --git a/ovsdb/ovsdb-client.1.in b/ovsdb/ovsdb-client.1.in
index 203d70cfac2d..5dbd49f25263 100644
--- a/ovsdb/ovsdb-client.1.in
> On Dec 22, 2017, at 12:49 PM, Ben Pfaff wrote:
>
> On Thu, Dec 21, 2017 at 04:18:05PM -0800, Justin Pettit wrote:
>>
>>
>>> On Dec 8, 2017, at 12:53 PM, Ben Pfaff wrote:
>>>
>>> +if (argc > 2 && argv[1][0] == '_') {
> On Dec 7, 2017, at 5:12 PM, Ben Pfaff wrote:
>
> diff --git a/ovsdb/log.c b/ovsdb/log.c
> index d25f766474dc..dd641884a2ee 100644
> --- a/ovsdb/log.c
> +++ b/ovsdb/log.c
>
> +/* Read the magic from the first log record. */
> +char header[128];
> +const char *actual_magic;
> +i
I forgot to add:
Acked-by: Justin Pettit
> On Dec 23, 2017, at 4:41 PM, Justin Pettit wrote:
>
>
>> On Dec 7, 2017, at 5:12 PM, Ben Pfaff wrote:
>>
>> diff --git a/ovsdb/log.c b/ovsdb/log.c
>> index d25f766474dc..dd641884a2ee 100644
>>
ne. The client may also use ovsdb_log_write() to write
> new
> + * records (if some records have not yet been read at this point, then the
> + * first write truncates them).
It might be nice to add some of this information to the functions themselves.
Acked-by: Justin Pettit
--Justi
*json)
>
> if (json->type != JSON_OBJECT && json->type != JSON_ARRAY) {
> -error = OVSDB_BUG("bad JSON type");
> -goto error;
> +return OVSDB_BUG("bad JSON type");
Does this not need to set the state to OVSDB_LOG_WRITE_ERROR any more?
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Signed-off-by: Justin Pettit
---
include/openvswitch/ofp-actions.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/openvswitch/ofp-actions.h
b/include/openvswitch/ofp-actions.h
index 25f61ef93ace..3d9775582f6d 100644
--- a/include/openvswitch/ofp-actions.h
+++ b
> On Dec 24, 2017, at 11:52 AM, Ben Pfaff wrote:
>
> On Sat, Dec 23, 2017 at 08:30:08PM -0800, Justin Pettit wrote:
>> Signed-off-by: Justin Pettit
>
> Acked-by: Ben Pfaff
Thanks. I pushed this to master.
--Justin
_
> On Dec 24, 2017, at 12:31 PM, Ben Pfaff wrote:
>
> Requested-by: Leonid Ryzhyk
> Signed-off-by: Ben Pfaff
Thanks for writing this up.
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.ope
> On Dec 24, 2017, at 5:24 PM, Ben Pfaff wrote:
>
> On Fri, Dec 22, 2017 at 10:40:05PM -0800, Justin Pettit wrote:
>> The man page indicated that multiple databases could be specified, but
>> only one is allowed.
>>
>> Signed-off-by:Justin Pettit
>
&
your side to see if you can narrow down
the cause?
--Justin
> On Dec 26, 2017, at 10:45 AM, Gregory Rose wrote:
>
> On 12/21/2017 2:25 PM, Justin Pettit wrote:
>> This will have callers in the future.
>>
>> Signed-off-by: Justin Pettit
>> ---
>>
> On Dec 26, 2017, at 2:14 PM, Gregory Rose wrote:
>
> I'll continue to look into it.
I looked at this patch more carefully, and I don't see where it would cause
issues. It mostly renames a couple of things and adds a new function which
isn't used in this patch. Of course it's certainly pos
> On Jan 2, 2018, at 8:40 AM, Ben Pfaff wrote:
>
> On Thu, Dec 21, 2017 at 02:25:10PM -0800, Justin Pettit wrote:
>> This will have callers in the future.
>>
>> Signed-off-by: Justin Pettit
>
> The new comment in struct ofproto_dpif only refers to one of the
> On Dec 28, 2017, at 3:22 PM, Gregory Rose wrote:
>
> SFAICT it emulates exactly what the system-traffic.at test 001 does. And it
> works fine... /shrug.
>
> What distribution, kernel, etc are you using for your check-kmod testing?
> I'll try to emulate that
> exactly and then see if I can
> On Jan 2, 2018, at 10:13 AM, Ben Pfaff wrote:
>
> On Thu, Dec 21, 2017 at 02:25:13PM -0800, Justin Pettit wrote:
>> Previously, the ofproto instance and OpenFlow port have been derived
>> based on the datapath port number. This change explicitly declares them
>>
> On Jan 3, 2018, at 4:11 PM, Ben Pfaff wrote:
>
> This may help debugging difficult controller problems.
>
> Reported-by: Su Wang
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
d...@ope
> On Jan 5, 2018, at 8:05 AM, Gregory Rose wrote:
>
> For now that's about as far as I can take my investigation since I have a few
> other things I need to work
> on. If you can think of another test I should run or something for me to
> check into let me know.
Ben noticed that this seemed
ofconn_send_error(ofconn, b->msg, OFPERR_OFPBFC_TIMEOUT);
The comment for ofconn_send_error() should be updated to indicate it's not
limited to 64 bytes anymore.
Acked-by: Justin Pettit
This seems like it will be helpful. Thanks!
--Justin
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> On Jan 9, 2018, at 10:58 AM, Ben Pfaff wrote:
>
> On Wed, Dec 20, 2017 at 07:42:40PM -0800, Justin Pettit wrote:
>> Commit e995e3df57 ("Allow OVS_USERSPACE_ATTR_USERDATA to be variable
>> length.") changed userspace action userdata from eight bytes to variabl
101 - 200 of 837 matches
Mail list logo
