https://bugzilla.redhat.com/show_bug.cgi?id=1976012
Peter Hutterer changed:
What|Removed |Added
Status|POST|CLOSED
Fixed In Version|
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
Bug 1976012 depends on bug 1981613, which changed state.
Bug 1981613 Summary: Please bump the version for pipewire-media-session.service
https://bugzilla.redhat.com/show_bug.cgi?id=1981613
What|Removed |Added
-
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
Peter Hutterer changed:
What|Removed |Added
Depends On||1981613
Referenced Bugs:
https://
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #27 from Gwyn Ciesla ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/wireplumber
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified ab
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
Neal Gompa changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #25 from Neal Gompa ---
Review notes:
> [!]: Package requires other packages for directories it uses.
> Note: No known owner of /etc/wireplumber
Rather than making you go through this again, I'll just say that you can fix it
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #24 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains n
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #23 from Neal Gompa ---
(In reply to Peter Hutterer from comment #22)
> > The devel package needs to depend on the libs package now. :)
>
> ♫ 99 issues with the review request ♩
> ♪ 99 things to change ♬
> ♬ fix them all, submit
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #22 from Peter Hutterer ---
> The devel package needs to depend on the libs package now. :)
♫ 99 issues with the review request ♩
♪ 99 things to change ♬
♬ fix them all, submit it again ♪
♩ 99 issues with the review request ♫
D
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #21 from Neal Gompa ---
(In reply to Peter Hutterer from comment #19)
> > You should consider converting any build dependencies that are located by
> > Meson via pkgconfig to use pkgconfig() names instead of their package
> > nam
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #20 from Neal Gompa ---
The devel package needs to depend on the libs package now. :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and componen
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #19 from Peter Hutterer ---
> You should consider converting any build dependencies that are located by
> Meson via pkgconfig to use pkgconfig() names instead of their package names.
> That way you'll always get them, even if the
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #18 from Neal Gompa ---
> %{_libdir}/wireplumber-0.4/libwireplumber-*.so
> %{_libdir}/libwireplumber-0.4.so.*
> %{_libdir}/girepository-1.0/Wp-0.4.typelib
These should all be in a libs subpackage, similar to how it was done for
pi
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #17 from Neal Gompa ---
> %{_libdir}/wireplumber-0.4/libwireplumber-*.so
You need a "%dir %{_libdir}/wireplumber-0.4" entry here.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notifi
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #16 from Neal Gompa ---
(In reply to Peter Hutterer from comment #15)
> > Take the asterisk off, because the asterisk makes it so RPM doesn't own
> > "%{_datadir}/wireplumber". The slash alone is sufficient for recursive
> > owne
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #15 from Peter Hutterer ---
> Take the asterisk off, because the asterisk makes it so RPM doesn't own
> "%{_datadir}/wireplumber". The slash alone is sufficient for recursive
> ownership.
I'm assuming the same applies to
%{_in
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #14 from Neal Gompa ---
> BuildRequires: systemd
Do you actually need this for anything?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and com
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #13 from Neal Gompa ---
> %{_datadir}/wireplumber/*
Take the asterisk off, because the asterisk makes it so RPM doesn't own
"%{_datadir}/wireplumber". The slash alone is sufficient for recursive
ownership.
--
You are receiving
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #12 from Peter Hutterer ---
> These should be "%dir" instead of "%config(noreplace)".
oops, sorry. fixed, same URLS.
> As a general comment, why are these in /etc instead of in /usr/share?
> Ideally, these should be installed in
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #11 from Neal Gompa ---
> %config(noreplace) %{_sysconfdir}/wireplumber/bluetooth.lua.d
> %config(noreplace) %{_sysconfdir}/wireplumber/common
> %config(noreplace) %{_sysconfdir}/wireplumber/main.lua.d
> %config(noreplace) %{_sysco
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #10 from Peter Hutterer ---
Thanks for all the comments, didn't know the provides+conflicts could work that
way without conflicting itself :)
> This needs to be enumerated and marked as "%config(noreplace)"
> Replace "%{_prefix}
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #9 from Neal Gompa ---
(In reply to Neal Gompa from comment #7)
> > Provides: pipewire-session-manager
> > Conflicts: pipewire-media-session
>
> This doesn't do what we want. This should be:
>
> Provides: pipewir
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #8 from Neal Gompa ---
I've added the necessary Conflicts to pipewire-media-session:
https://src.fedoraproject.org/rpms/pipewire/c/3d3f0022fde763c88bc9f8dadaeb43f9104e8a84
--
You are receiving this mail because:
You are on the C
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #7 from Neal Gompa ---
> Provides: pipewire-session-manager
> Conflicts: pipewire-media-session
This doesn't do what we want. This should be:
Provides: pipewire-session-manager
Conflicts: pipewire-session-ma
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #6 from Neal Gompa ---
> %{_prefix}/lib/systemd/user/wireplumber.service
> %{_prefix}/lib/systemd/user/wireplumber@.service
Replace "%{_prefix}/lib/systemd/user" with "%{_userunitdir}"
--
You are receiving this mail because:
Yo
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #5 from Neal Gompa ---
> %{_sysconfdir}/wireplumber/*
This needs to be enumerated and marked as "%config(noreplace)"
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about chan
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #4 from Peter Hutterer ---
New SRPM URL (version change upstream to 0.4.1):
Spec URL: https://people.freedesktop.org/~whot/rpms/wireplumber.spec
SRPM URL:
https://people.freedesktop.org/~whot/rpms/wireplumber-0.4.1-1.fc34.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
--- Comment #3 from Neal Gompa ---
Should PipeWire have more than one installed at a time? If not, it should be
Provides+Conflicts.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about ch
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
Yanko Kaneti changed:
What|Removed |Added
CC||yan...@declera.com
--- Comment #2 from
https://bugzilla.redhat.com/show_bug.cgi?id=1976012
Neal Gompa changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
30 matches
Mail list logo
