Re: [pirate] Python PMC's

2005-08-23 Thread Chip Salzenberg
On Tue, Aug 23, 2005 at 09:58:21PM +0200, Leopold Toetsch wrote: > Sam, please follow Parrot dev (or stop spreading FUD) - thanks. Be gentle, please. Parrot needs language developers. I'm not saying you're right or wrong. I'm just asking you to be a little more diplomatic. -- Chip Salzenberg <

Re: [pirate] Python PMC's

2005-08-23 Thread Leopold Toetsch
On Aug 23, 2005, at 20:28, Sam Ruby wrote: Leopold Toetsch wrote: I do agree with test-driven development. That is exactly the approach I took. Well, I agree - until I see such tests (pyint_1): $P2 = $P1.__abs__($P1) Take a look at the difference between r7254 and r7312. I just

Re: [pirate] Python PMC's

2005-08-23 Thread Sam Ruby
Kevin Tew wrote: >> > Point well taken, I've been leaning back between, rewrite and evolving > your work. > I have a current change set that is passing most of your original tests > that are in t/dynclasses/py*.t > It is more of an evolution than a rewrite, which I favor. > Some test fail due to re

Re: [pirate] Python PMC's Missed attachment

2005-08-23 Thread Kevin Tew
My current work. Python PMC Patch to leo5-cxt5

Re: [pirate] Python PMC's

2005-08-23 Thread Kevin Tew
Sam, Thanks for the comments, They were very much appreciated. Sam Ruby wrote: >I added self on Leo's request. Now it is unneccessary. *shrug* > I understand completely. >Check out parrot/t/dynclass/pyint_2.pmc. __add__ style methods were >working, and tested. > Yes many are working, I shou

Re: [pirate] Python PMC's

2005-08-23 Thread Sam Ruby
Leopold Toetsch wrote: > >> I do agree with test-driven development. That is exactly the approach I >> took. > > Well, I agree - until I see such tests (pyint_1): > > $P2 = $P1.__abs__($P1) Take a look at the difference between r7254 and r7312. The tests originally passed without a self a

Re: [pirate] Python PMC's

2005-08-23 Thread Leopold Toetsch
On Aug 23, 2005, at 18:21, Sam Ruby wrote: Kevin Tew wrote: We don't have to pass self around, parrot makes it available to us automatically. I added self on Leo's request. Now it is unneccessary. *shrug* Parrot's new calling conventions are passing 'self' as the first argument of

Re: [pirate] Python PMC's

2005-08-23 Thread Chip Salzenberg
On Tue, Aug 23, 2005 at 06:35:39PM +0200, Leopold Toetsch wrote: > On Aug 23, 2005, at 17:09, Kevin Tew wrote: > >Problem: > >Python PMC's just don't work in the leo-cxt5 branch which will become > >head/trunk at some time in the hopefully not to distant future. > > Err, I hope to merge RSN ;-) T

Re: [pirate] Python PMC's

2005-08-23 Thread Chip Salzenberg
On Tue, Aug 23, 2005 at 12:21:42PM -0400, Sam Ruby wrote: > Kevin Tew wrote: > > I've ripped out a lot of the explicit passing of self as the first > > argument of pmc methods. - We don't have to pass self around, parrot > > makes it available to us automatically. > > I added self on Leo's reques

Re: [pirate] Python PMC's

2005-08-23 Thread Leopold Toetsch
On Aug 23, 2005, at 17:09, Kevin Tew wrote: Problem: Python PMC's just don't work in the leo-cxt5 branch which will become head/trunk at some time in the hopefully not to distant future. Err, I hope to merge RSN ;-) I had a conversation a long time ago with Dan, in which he agreed that giv

Re: [pirate] Python PMC's

2005-08-23 Thread Sam Ruby
Kevin Tew wrote: > Problem: > Python PMC's just don't work in the leo-cxt5 branch which will become > head/trunk at some time in the hopefully not to distant future. > > What I've done up time now: > I've ported pyint.pmc, pystring.pmc to pass all tests in leo-cxt5 > I've written t/dynclasses/pyst