Re: Test names/comments/whatever?

2005-02-10 Thread Michael G Schwern
On Thu, Feb 10, 2005 at 03:02:03PM -0800, Ovid wrote: > I have no problem with this. Is anyone even using THS? Yes. Everyone who uses Test::Harness.

Re: Test names/comments/whatever?

2005-02-10 Thread Michael G Schwern
On Thu, Feb 10, 2005 at 02:49:55PM -0800, chromatic wrote: > It's a patch to Test::Harness::Straps, the documentation of which > disclaims backwards compatibility. I'd like it to work on Windows so as > to avoid people complaining if it doesn't, but I'm just saying that 1) I > don't feel any parti

Re: Test names/comments/whatever?

2005-02-10 Thread Geoffrey Young
Ovid wrote: > Is anyone even using THS? /me raises his hand > If anything, I > suspect there are a tiny handful of people who have played with it, but > haven't really used it since it's not as useful as it could be. I got Apache-Test to run .php scripts in under 10 lines by subclassing strap

Re: Test names/comments/whatever?

2005-02-10 Thread Ovid
--- chromatic <[EMAIL PROTECTED]> wrote: > It's a patch to Test::Harness::Straps, the documentation of which > disclaims backwards compatibility. I'd like it to work on Windows so > as > to avoid people complaining if it doesn't, but I'm just saying that > 1) I > don't feel any particular guilt ab

Re: Test names/comments/whatever?

2005-02-10 Thread chromatic
On Thu, 2005-02-10 at 17:30 -0500, Michael G Schwern wrote: > Err, I don't get it. It's a patch to Test::Harness::Straps, the documentation of which disclaims backwards compatibility. I'd like it to work on Windows so as to avoid people complaining if it doesn't, but I'm just saying that 1) I do

Re: Test names/comments/whatever?

2005-02-10 Thread Michael G Schwern
On Thu, Feb 10, 2005 at 01:56:50PM -0800, chromatic wrote: > On Thu, 2005-02-10 at 16:46 -0500, Michael G Schwern wrote: > > > Trouble is STDOUT is parsed while STDERR is not so T::H has to be able > > to disambiguate them while still displaying them in the correct ordering > > and not run afoul

Re: Test names/comments/whatever?

2005-02-10 Thread chromatic
On Thu, 2005-02-10 at 16:46 -0500, Michael G Schwern wrote: > Trouble is STDOUT is parsed while STDERR is not so T::H has to be able > to disambiguate them while still displaying them in the correct ordering > and not run afoul of any buffering issues. I wave the "Nope, the UNbiquitous Test::Har

Re: Test names/comments/whatever?

2005-02-10 Thread Michael G Schwern
On Sun, Feb 06, 2005 at 01:46:14PM -0800, chromatic wrote: > I don't know that that's a problem if you redirect STDERR to the same > place as STDOUT. Is there any OS where the order of printing is that > badly nondeterministic? If so, can I wave my hands at its users and > suggest either upgradin

Re: Test names/comments/whatever?

2005-02-10 Thread chromatic
On Sun, 2005-02-06 at 20:16 -0600, Andy Lester wrote: > I should NOT have applied that? It's already on my trunk. Half of it was good. The IPC::Open3 code is probably problematic, so it should revert. I really like the diagnostic-parsing code, but it's worth discussing whether to enable this b

Re: Test names/comments/whatever?

2005-02-06 Thread Andy Lester
Last I checked, IPC::Open3 has portability issues. Right. My original patch made T::H::S use that, but I now prefer to put that burden on the program that uses the module to make sure that diagnostics come in correctly. I should NOT have applied that? It's already on my trunk. xoa -- Andy Lester

Re: Test names/comments/whatever?

2005-02-06 Thread Andy Lester
On Feb 6, 2005, at 2:16 PM, Michael G Schwern wrote: On Sat, Feb 05, 2005 at 06:59:26PM -0500, Ian Langworth wrote: 'comment', however, seems just right -- it implies a short, optional description. I like comment, too. It already has a meaning in Perl (and every other language) and its just the sa

Re: Test names/comments/whatever?

2005-02-06 Thread chromatic
On Sun, 2005-02-06 at 15:08 -0500, Michael G Schwern wrote: > Last I checked, IPC::Open3 has portability issues. Right. My original patch made T::H::S use that, but I now prefer to put that burden on the program that uses the module to make sure that diagnostics come in correctly. > There's als

Re: Test names/comments/whatever?

2005-02-06 Thread Stevan Little
On Feb 6, 2005, at 3:16 PM, Michael G Schwern wrote: On Sat, Feb 05, 2005 at 06:59:26PM -0500, Ian Langworth wrote: 'comment', however, seems just right -- it implies a short, optional description. I like comment, too. It already has a meaning in Perl (and every other language) and its just the sa

Re: Test names/comments/whatever?

2005-02-06 Thread Michael G Schwern
On Sat, Feb 05, 2005 at 06:59:26PM -0500, Ian Langworth wrote: > 'comment', however, seems just right -- it implies a short, optional > description. I like comment, too. It already has a meaning in Perl (and every other language) and its just the same. So as of right now, that's official.

Re: Test names/comments/whatever?

2005-02-06 Thread Michael G Schwern
On Sat, Feb 05, 2005 at 04:47:55PM -0800, chromatic wrote: > > Let me second that one! Of course, Andy's already made it clear that > > he doesn't have a lot of time, but I still don't mind kicking 'im. :) > > I think the right approach is to patch T::H::S to collect diagnostic > information and

Re: Test names/comments/whatever?

2005-02-06 Thread Michael G Schwern
On Sat, Feb 05, 2005 at 03:12:20PM -0500, Stevan Little wrote: > I sent Schwern a patch to change 'names' to 'description', but then > Andy brought up the idea of 'labels'. At the time, Schwern said it was > 'in the pipeline', but I expect its actually been moved out since. If its not in the RT

Re: Test names/comments/whatever?

2005-02-06 Thread Stevan Little
I actually just looked over the patch and it was actually for changing 'name' to 'comment', not 'description'. I am actually going to agree with you, 'comment' does seem the best fit. 'description' would be my second choice, and 'label' third. - Steve On Feb 5, 2005, at 3:23 PM, Ian Langworth w

Re: Test names/comments/whatever?

2005-02-05 Thread Andy Lester
On Feb 5, 2005, at 6:47 PM, chromatic wrote: I think the right approach is to patch T::H::S to collect diagnostic information and make it available. It's easy enough to grab it via IPC::Open3 elsewhere and pass a combined STDOUT/STDERR filehandle to analyze_fh(). Agreed. My goal is to have Test::Ha

Re: Test names/comments/whatever?

2005-02-05 Thread chromatic
On Sat, 2005-02-05 at 16:39 -0800, Ovid wrote: > Let me second that one! Of course, Andy's already made it clear that > he doesn't have a lot of time, but I still don't mind kicking 'im. :) I think the right approach is to patch T::H::S to collect diagnostic information and make it available. I

Re: Test names/comments/whatever?

2005-02-05 Thread Ovid
--- chromatic <[EMAIL PROTECTED]> wrote: > Alternately, encourage Andy to adopt some patch to > Test::Harness::Straps > that enables collecting that diagnostic information somehow and use > an alternate harness that displays test comments. Let me second that one! Of course, Andy's already made it

Re: Test names/comments/whatever?

2005-02-05 Thread chromatic
On Sat, 2005-02-05 at 15:23 -0500, Shawn Boyette wrote: > Also, is anything ever *done* with these chunks of text? When I first > started using Test::More, I expected that I'd get that text when a > test failed instead of just a line number. Run the test with perl -Mblib instead of make test, ./B

Re: Test names/comments/whatever?

2005-02-05 Thread Shawn Boyette
On Sat, 5 Feb 2005 15:12:20 -0500, Stevan Little <[EMAIL PROTECTED]> wrote: > I sent Schwern a patch to change 'names' to 'description', but then > Andy brought up the idea of 'labels'. At the time, Schwern said it was > 'in the pipeline', but I expect its actually been moved out since. > > Person

Re: Test names/comments/whatever?

2005-02-05 Thread Ian Langworth
Stevan Little wrote: I sent Schwern a patch to change 'names' to 'description', but then Andy brought up the idea of 'labels'. At the time, Schwern said it was 'in the pipeline', but I expect its actually been moved out since. Personally, I view them as 'descriptions' since thats what I usually

Re: Test names/comments/whatever?

2005-02-05 Thread Ian Langworth
Stevan Little wrote: I sent Schwern a patch to change 'names' to 'description', but then Andy brought up the idea of 'labels'. At the time, Schwern said it was 'in the pipeline', but I expect its actually been moved out since. Personally, I view them as 'descriptions' since thats what I usually

Re: Test names/comments/whatever?

2005-02-05 Thread David Golden
If this discussion means the voting has re-opened, I'm in favor of 'label' as it implies an identifying description, but also connotes something brief. David Stevan Little wrote: I sent Schwern a patch to change 'names' to 'description', but then Andy brought up the idea of 'labels'. At the time

Re: Test names/comments/whatever?

2005-02-05 Thread Stevan Little
I sent Schwern a patch to change 'names' to 'description', but then Andy brought up the idea of 'labels'. At the time, Schwern said it was 'in the pipeline', but I expect its actually been moved out since. Personally, I view them as 'descriptions' since thats what I usually write. But 'labels'

Re: Test names/comments/whatever?

2005-02-05 Thread Andy Lester
On Feb 5, 2005, at 10:03 AM, Ovid wrote: Has there been any final decision as to what to call test names? There was quite a bit of discussion, but I don't recall the resolution. Nothing has been decided. I just don't like "name". xoa -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:

Test names/comments/whatever?

2005-02-05 Thread Ovid
Has there been any final decision as to what to call test names? There was quite a bit of discussion, but I don't recall the resolution. Cheers, Ovid = If this message is a response to a question on a mailing list, please send follow up questions to the list. Web Programming with Perl -- ht