Le 17/11/2022 à 17:59, Tom Lane a écrit :
Gilles Darold writes:
I have an incorrect behavior with pg_dump prior PG version 15. With
PostgreSQL 15, thanks to commit e3fcbbd623b9ccc16cdbda374654d91a4727d173
the problem is gone but for older versions it persists with locks on
partitioned tables.
On Fri, Nov 18, 2022 at 8:20 PM Masahiko Sawada
wrote:
>
> FYI I've not tested the patch you shared today but here are the
> benchmark results I did with the v9 patch in my environment (I used
> the second filter). I splitted 0004 patch into two patches: a patch
> for pure refactoring patch to
On Fri, Nov 18, 2022 at 04:19:15PM -0500, Robert Haas wrote:
> Fixed that, and the other mistake Álvaro spotted, and also bumped
> catversion because I forgot that earlier.
I was looking at this code yesterday, to see today that psql's
completion should be completed with this new clause, similary
Op 18-11-2022 om 22:19 schreef Robert Haas:
On Fri, Nov 18, 2022 at 1:50 PM Erik Rijkers wrote:
In grant.sgml,
'actualy permisions'
looks a bit unorthodox.
Fixed that, and the other mistake Álvaro spotted, and also bumped
catversion because I forgot that earlier.
Sorry to be nagging
Hi,
Is there a way to find out about new git commits that is more
efficient and timely than running N git fetches or whatever every
minute in a cron job? Maybe some kind of long polling where you send
an HTTP request that says "I think the tips of branches x, y, z are at
111, 222, 333" and the
Andres Freund writes:
> On 2022-11-18 15:55:34 -0500, Tom Lane wrote:
>> We realized today [1] that it's been some time since the buildfarm
>> had any debug_discard_caches (nee CLOBBER_CACHE_ALWAYS) coverage.
> Do we know when it was covered last? I assume it's before the addition of
>
Hi,
On 2022-11-18 11:20:36 +0530, Amit Kapila wrote:
> Okay, updated the patch accordingly.
Assuming it passes tests etc, this'd work for me.
- Andres
Andres Freund writes:
> On 2022-11-18 15:55:34 -0500, Tom Lane wrote:
>> The test_oat_hooks test is failing --- it's not crashing, but
>> it's emitting more NOTICE lines than the expected output includes,
>> evidently as a result of the hooks getting invoked extra times
>> during cache reloads.
On Sat, Nov 19, 2022 at 12:41 AM Tom Lane wrote:
> ... BTW, re-reading the commit message for a0ffa885e:
>
> One caveat is that PGC_USERSET GUCs are unaffected by the SET privilege
> --- one could wish that those were handled by a revocable grant to
> PUBLIC, but they are not, because
On Sat, Nov 19, 2022 at 12:33 AM Tom Lane wrote:
> Alexander Korotkov writes:
> > This makes sense. But do we really need to store the OID of the role?
> > validate_option_array_item() already checks if the placeholder option
> > passes validation for PGC_SUSET. So, we can just save a flag
>
Hi,
On 2022-11-18 15:55:34 -0500, Tom Lane wrote:
> We realized today [1] that it's been some time since the buildfarm
> had any debug_discard_caches (nee CLOBBER_CACHE_ALWAYS) coverage.
Do we know when it was covered last? I assume it's before the addition of
test_oat_hooks in 90efa2f5565?
>
... BTW, re-reading the commit message for a0ffa885e:
One caveat is that PGC_USERSET GUCs are unaffected by the SET privilege
--- one could wish that those were handled by a revocable grant to
PUBLIC, but they are not, because we couldn't make it robust enough
for GUCs defined by
@cfbot: re-rebased again
>From e1f0940e7682052b2ec9d58c361f56630aa1742e Mon Sep 17 00:00:00 2001
From: Justin Pryzby
Date: Tue, 19 Jul 2022 08:31:56 -0500
Subject: [PATCH 1/2] pg_settings_get_flags(): add DEFAULT_COMPILE and
DEFAULT_INITDB ..
for settings which vary by ./configure or platform
Alexander Korotkov writes:
> This makes sense. But do we really need to store the OID of the role?
> validate_option_array_item() already checks if the placeholder option
> passes validation for PGC_SUSET. So, we can just save a flag
> indicating that this check was not successful. If so,
Hi!
I'd like to resume this discussion.
On Wed, Jul 20, 2022 at 6:50 PM Tom Lane wrote:
> Kyotaro Horiguchi writes:
> > At Tue, 19 Jul 2022 09:53:39 -0700, Nathan Bossart
> > wrote in
> >> Hm. I would expect ALTER ROLE to store the PGC_SUSET context when executed
> >> by a superuser or a
On Fri, Nov 18, 2022 at 1:50 PM Erik Rijkers wrote:
> In grant.sgml,
>
>'actualy permisions'
>
> looks a bit unorthodox.
Fixed that, and the other mistake Álvaro spotted, and also bumped
catversion because I forgot that earlier.
--
Robert Haas
EDB: http://www.enterprisedb.com
We realized today [1] that it's been some time since the buildfarm
had any debug_discard_caches (nee CLOBBER_CACHE_ALWAYS) coverage.
Sure enough, as soon as Tomas turned that back on, kaboom [2].
The test_oat_hooks test is failing --- it's not crashing, but
it's emitting more NOTICE lines than the
On Sat, Nov 19, 2022 at 7:54 AM Simon Riggs
wrote:
> I agree. I can't see a reason to keep it anymore.
+Use of promote_trigger_file is deprecated. If you're
I think 'deprecated' usually implies that it still works but you
should avoid it. I think you need something stronger.
> I'm nervous
On Fri, Nov 18, 2022 at 02:33:26PM -0500, Bruce Momjian wrote:
> On Sun, Nov 13, 2022 at 12:56:30PM +0100, Laurenz Albe wrote:
> > > Maybe there's a way to reword the entire phrase that leads to a better
> > > formulation of the idea.
> >
> > Any of your auggestions is better than "unaborted".
>
On Tue, Nov 15, 2022 at 10:16:44AM +, Simon Riggs wrote:
> On Tue, 8 Nov 2022 at 03:41, Bruce Momjian wrote:
> >
> > On Mon, Nov 7, 2022 at 10:58:05AM +, Simon Riggs wrote:
> > > What I've posted is the merged patch, i.e. your latest patch, plus
> > > changes to RELEASE SAVEPOINT from
On Thu, Nov 10, 2022 at 11:31:25AM +, Simon Riggs wrote:
> > That's not true. Transactions waiting for table-level locks are shown
> > waiting for a "relation" lock in both "pg_stat_activity" and "pg_locks".
>
> Agreed.
>
> Lock waits on table-locks are shown waiting for a lock type of
>
On Sun, Nov 13, 2022 at 12:56:30PM +0100, Laurenz Albe wrote:
> > Maybe there's a way to reword the entire phrase that leads to a better
> > formulation of the idea.
>
> Any of your auggestions is better than "unaborted".
>
> How about:
>
> If AND CHAIN is specified, a new transaction is
>
On Thu, Nov 10, 2022 at 08:39:29AM +0100, Laurenz Albe wrote:
> > > I don't think that is an improvement. "Unaborted" is an un-word. A new
> > > transaction
> > > is always "unaborted", isn't it?
> >
> > I thought about this as well when reviewing it, but I do think
> > something is needed for
On Wed, Nov 9, 2022 at 09:16:18AM -0500, Robert Treat wrote:
> > "Subtransactions of the named savepoint" is somewhat confusing; how about
> > "subtransactions of the subtransaction established by the named savepoint"?
> >
> > If that is too long and explicit, perhaps "subtransactions of that
>
On Sat, Nov 19, 2022 at 7:38 AM Thomas Munro wrote:
> On Tue, Nov 15, 2022 at 1:55 PM Jeff Davis wrote:
> > I realize your patch is experimental, but when there is a better
> > consensus on the approach, we should consider adding declarative syntax
> > such as:
> >
> >CREATE COLLATION (or
On Mon, Nov 7, 2022 at 11:04:46PM +0100, Laurenz Albe wrote:
> On Sat, 2022-11-05 at 10:08 +, Simon Riggs wrote:
> > Agreed; new compilation patch attached, including mine and then
> > Robert's suggested rewordings.
>
> Thanks. There is clearly a lot of usefule information in this.
Sorry
On 2022-Nov-16, Alvaro Herrera wrote:
> Hmm, good find. As I recall, I was opposed to the idea of throwing an
> error if the WHEN expression writes to the database, and the previous
> implementation had some hole, so I just ripped it out after discussing
> it; but I evidently failed to notice
On Thu, 17 Nov 2022 at 20:38, Robert Haas wrote:
>
> On Thu, Nov 17, 2022 at 2:55 AM Simon Riggs
> wrote:
> > No, it will have a direct effect only on people using promote_trigger_file
> > who do not read and act upon the deprecation notice before upgrading
> > by making a one line change to
Op 18-11-2022 om 19:43 schreef Robert Haas:
On Fri, Nov 18, 2022 at 12:50 PM Robert Haas wrote:
Here's a rebased v3 to see what cfbot thinks.
cfbot is happy, so committed.
In grant.sgml,
'actualy permisions'
looks a bit unorthodox.
Andres Freund writes:
> On 2022-11-17 17:47:50 -0500, Tom Lane wrote:
>> So I'd like to have some way to make the postmaster send SIGABRT instead
>> of SIGKILL in the buildfarm environment. The lowest-tech way would be
>> to drive that off some #define or other. We could scale it up to a GUC
>>
On Fri, Nov 18, 2022 at 12:50 PM Robert Haas wrote:
> Here's a rebased v3 to see what cfbot thinks.
cfbot is happy, so committed.
--
Robert Haas
EDB: http://www.enterprisedb.com
On 2022-Nov-18, Robert Haas wrote:
> On Thu, Nov 17, 2022 at 7:24 PM Jeff Davis wrote:
> > But I'm fine if you'd like to move on with the SET ROLE privilege
> > instead, as long as we believe it grants a stable set of capabilities
> > (and conversely, that if the SET ROLE privilege is revoked,
Replying to Peter and Jeff in one email.
On Sat, Nov 12, 2022 at 3:57 AM Peter Eisentraut
wrote:
> On 22.10.22 03:22, Thomas Munro wrote:
> > I'd love to hear others' thoughts on how we can turn this into a
> > workable solution. Hopefully while staying simple...
>
> I played with this patch a
Robert Haas writes:
> On Fri, Nov 18, 2022 at 7:04 AM Simon Riggs
> wrote:
>> So if consistency is also a strong requirement, then maybe we should
>> make that new command the default, i.e. make VACUUM always just a
>> request to vacuum in background. That way it will be consistent.
> Since one
On Thu, Nov 17, 2022 at 7:24 PM Jeff Davis wrote:
> But I'm fine if you'd like to move on with the SET ROLE privilege
> instead, as long as we believe it grants a stable set of capabilities
> (and conversely, that if the SET ROLE privilege is revoked, that it
> revokes a stable set of
Hi,
On 2022-11-18 11:09:43 +0100, Drouvot, Bertrand wrote:
> > Furthermore, the pgstat_fetch_stat_tabentry() can just be a
> > static inline function.
I think that's just premature optimization for something like this. The
function call overhead on accessing stats can't be a relevant factor -
rebased
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
>From 0643a4dbc9f36d9fd383ef0cfebef13875237718 Mon Sep 17 00:00:00 2001
From: Nathan Bossart
Date: Wed, 7 Sep 2022 22:25:29 -0700
Subject: [PATCH v10 1/4] Change AclMode from a uint32 to a uint64.
---
On Fri, Nov 18, 2022 at 7:04 AM Simon Riggs
wrote:
> Outside a transaction - works perfectly
> In a transaction - throws ERROR, which prevents a whole script from
> executing correctly
Right, but your proposal would move that inconsistency to a different
place. It wouldn't eliminate it. I don't
On 18.11.22 02:07, Andrey Borodin wrote:
2. This literal
{no_compression_name}
should be replaced by explicit form
{no_compression_name, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL}
That doesn't seem better.
David Geier writes:
> On 11/18/22 14:00, Tomas Vondra wrote:
>> Seems fine. I wonder if we could/could introduce a new constant for 0,
>> similar to ATTSTATSSLOT_NUMBERS/ATTSTATSSLOT_VALUES, instead of using a
>> magic constant. Say, ATTSTATSSLOT_NONE or ATTSTATSSLOT_CHECK.
> Good idea. I called
On 11/18/22 14:00, Tomas Vondra wrote:
Seems fine. I wonder if we could/could introduce a new constant for 0,
similar to ATTSTATSSLOT_NUMBERS/ATTSTATSSLOT_VALUES, instead of using a
magic constant. Say, ATTSTATSSLOT_NONE or ATTSTATSSLOT_CHECK.
Good idea. I called it ATTSTATSSLOT_EXISTS. New
On Fri, Nov 18, 2022 at 4:11 AM Alvaro Herrera
wrote:
> On 2022-Nov-02, David G. Johnston wrote:
>
> > Version 2 attached, some significant re-working. Starting to think that
> > initdb isn't the place for some of this content - in particular the stuff
> > I'm deciding to move down to the Notes
> I don't think this is a good feature to add to PostgreSQL. First, it's
> unclear why stopping the cluster is a desirable behavior. It doesn't
> stop the user transactions from failing; it just makes them fail in
> some other way. Now it is of course perfectly legitimate for a
> particular user
pá 18. 11. 2022 v 16:06 odesílatel Tom Lane napsal:
> Sergei Kornilov writes:
> > Do we need new syntax actually? I think that a global unique index can
> be created automatically instead of raising an error "unique constraint on
> partitioned table must include all partitioning columns"
>
>
Sergei Kornilov writes:
> Do we need new syntax actually? I think that a global unique index can be
> created automatically instead of raising an error "unique constraint on
> partitioned table must include all partitioning columns"
I'm not convinced that we want this feature at all: as far as
On 11/18/22 15:43, Tom Lane wrote:
> David Geier writes:
>> On a different note: are we frequently running our tests suites with
>> debug_discard_caches=1 enabled?
>> It doesn't seem like.
>
> Hmm. Buildfarm members avocet and trilobite are supposed to be
> doing that, but their runtimes
Tomas Vondra writes:
> On 11/18/22 09:54, David Geier wrote:
>> I couldn't come up with any reasonable way of writing an automated test
>> for that.
> I don't think you can write a test for this, because there is no change
> to behavior that can be observed by the user.
Yeah, and the delta in
David Geier writes:
> On a different note: are we frequently running our tests suites with
> debug_discard_caches=1 enabled?
> It doesn't seem like.
Hmm. Buildfarm members avocet and trilobite are supposed to be
doing that, but their runtimes of late put the lie to it.
Configuration option
On 2022-11-17 Th 17:11, Andrew Dunstan wrote:
> On 2022-11-04 Fr 10:06, Jehan-Guillaume de Rorthais wrote:
>> On Thu, 3 Nov 2022 13:11:18 -0500
>> Justin Pryzby wrote:
>>
>>> On Tue, Jun 28, 2022 at 06:17:40PM -0400, Andrew Dunstan wrote:
Nice catch, but this looks like massive overkill. I
On Thu, Nov 17, 2022 at 12:24 AM Masahiko Sawada wrote:
>
> On Wed, Nov 16, 2022 at 4:39 PM John Naylor
> wrote:
> >
> >
> > On Wed, Nov 16, 2022 at 12:33 PM Masahiko Sawada
> > wrote:
> > >
> > > On Wed, Nov 16, 2022 at 1:46 PM John Naylor
> > > wrote:
> > > >
> > > >
> > > > On Tue, Nov 15,
On Sat, Nov 12, 2022 at 4:10 AM Imseih (AWS), Sami wrote:
>
> >I don't think any of these progress callbacks should be done while
> > pinning a
> >buffer and ...
>
> Good point.
>
> >I also don't understand why info->parallel_progress_callback exists?
> > It's only
> >set to
On 11/18/22 09:54, David Geier wrote:
> Thanks everyone for the great feedback and suggestions.
>
>>
>>> Yes, it is. Using zero flag would short-cut get_attstatsslot() to just
>>> return whether the slot type exists without loading it. Do you think we
>>> need to emphasize this use case in the
Hi Tom,
Back-patching but keeping RelationOpenSgmr() for extensions sounds
reasonable.
On a different note: are we frequently running our tests suites with
debug_discard_caches=1 enabled?
It doesn't seem like. I just ran make check with debug_discard_caches=1 on
- latest master: everything
On Thu, 17 Nov 2022 at 20:06, Robert Haas wrote:
>
> On Wed, Nov 16, 2022 at 5:14 PM Greg Stark wrote:
> > However I'm not a fan of commands that sometimes do one thing and
> > sometimes magically do something very different. I don't like the idea
> > that the same vacuum command would sometimes
On Thu, 17 Nov 2022 at 20:00, Justin Pryzby wrote:
>
> On Wed, Nov 16, 2022 at 05:14:07PM -0500, Greg Stark wrote:
> > I think this requesting autovacuum worker should be a distinct
> > command. Or at least an explicit option to vacuum.
>
> +1. I was going to suggest VACUUM (NOWAIT) ..
Yes, I
Hi,
While working on something else, I notice some more oddities. Here is
an example:
create extension postgres_fdw;
create server loopback foreign data wrapper postgres_fdw options
(dbname 'postgres');
create user mapping for current_user server loopback;
create table t1 (a text, b int);
On Fri, Nov 18, 2022 at 3:41 PM Drouvot, Bertrand
wrote:
>
> > However, I have a suggestion to simplify it
> > further by getting rid of the local variable tabentry and just
> > returning pgstat_fetch_stat_tabentry_ext(IsSharedRelation(relid),
> > relid);. Furthermore, the
Hi,
On 11/16/22 9:12 PM, Andres Freund wrote:
Hi,
On 2022-11-15 10:48:40 +0100, Drouvot, Bertrand wrote:
diff --git a/src/backend/utils/adt/pgstatfuncs.c
b/src/backend/utils/adt/pgstatfuncs.c
index ae3365d917..be7f175bf1 100644
--- a/src/backend/utils/adt/pgstatfuncs.c
+++
On 2022-Nov-02, David G. Johnston wrote:
> Version 2 attached, some significant re-working. Starting to think that
> initdb isn't the place for some of this content - in particular the stuff
> I'm deciding to move down to the Notes section. Might consider moving some
> of it to the Server Setup
On Fri, Nov 18, 2022 at 12:42 AM Robert Haas wrote:
>
> On Thu, Nov 17, 2022 at 2:22 AM Bharath Rupireddy
> wrote:
> > Duplication is a problem that I agree with and I have an idea here -
> > how about introducing a new function, say EnableStandbyMode() that
> > sets StandbyMode to true and
Hi,
On 11/18/22 7:06 AM, Bharath Rupireddy wrote:
On Fri, Nov 18, 2022 at 10:32 AM Drouvot, Bertrand
wrote:
Hi hackers,
Please find attached a patch proposal to avoid 2 calls to
pgstat_fetch_stat_tabentry_ext() in pgstat_fetch_stat_tabentry() in case
the relation is not a shared one and no
pá 18. 11. 2022 v 10:04 odesílatel Sergei Kornilov napsal:
> Hello
> Do we need new syntax actually? I think that a global unique index can be
> created automatically instead of raising an error "unique constraint on
> partitioned table must include all partitioning columns"
>
+1
Pavel
>
Thanks!
Please let me know if I can help out, e.g. with re-testing.
--
David Geier
(ServiceNow)
On 11/17/22 08:28, Thomas Munro wrote:
On Thu, Nov 17, 2022 at 8:01 PM David Geier wrote:
Can we make progress with this patch in the current commit fest, or discuss
what is still missing to
Hello
Do we need new syntax actually? I think that a global unique index can be
created automatically instead of raising an error "unique constraint on
partitioned table must include all partitioning columns"
regards, Sergei
On Fri, 18 Nov 2022 at 08:55, Bharath Rupireddy
wrote:
> However, I'm a bit
> worried about how it'll affect the tools/providers/extensions that
> depend on it.
Who is that? Which ones depend upon it?
--
Simon Riggshttp://www.EnterpriseDB.com/
On Thu, 17 Nov 2022 at 20:29, Tomas Vondra
wrote:
>
> On 11/17/22 18:29, Simon Riggs wrote:
> > On Thu, 17 Nov 2022 at 17:04, Simon Riggs
> > wrote:
> >>
> > 003 includes the idea to not-always do SubTransSetParent()
> >
> I'm a bit confused by the TransactionIdsAreOnSameXactPage naming. Isn't
On Fri, Nov 18, 2022 at 2:08 AM Robert Haas wrote:
>
> On Thu, Nov 17, 2022 at 2:55 AM Simon Riggs
> wrote:
> > No, it will have a direct effect only on people using promote_trigger_file
> > who do not read and act upon the deprecation notice before upgrading
> > by making a one line change to
Thanks everyone for the great feedback and suggestions.
Yes, it is. Using zero flag would short-cut get_attstatsslot() to just
return whether the slot type exists without loading it. Do you think we
need to emphasize this use case in the comments for 'flags'?
Perhaps, it's not really
On Fri, Nov 18, 2022 at 6:29 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-11-17 13:06:23 +0530, Bharath Rupireddy wrote:
> > I understand. I know it's a bit hard to measure the power savings, I'm
> > wondering if there's any info, maybe not necessarily related to
> > postgres, but in general how
Just rebased.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
>From 1efe0601596807c25769370f38884c7027a00839 Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi
Date: Tue, 15 Nov 2022 13:41:46 +0900
Subject: [PATCH v22] Make End-Of-Recovery error less scary
When recovery in any
At Tue, 08 Nov 2022 11:33:53 +0900 (JST), Kyotaro Horiguchi
wrote in
> Indeed, thanks! I'll do that in a few days.
Got too late, but rebased.. The contents of the two patches in the
last version was a bit shuffled but they are fixed.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software
71 matches
Mail list logo
