On Mon, Nov 21, 2022 at 1:17 PM Andres Freund wrote:
> On November 21, 2022 9:37:34 AM PST, Robert Haas
> wrote:
> >On Mon, Nov 21, 2022 at 12:30 PM Andres Freund wrote:
> >> This can't quite be right - isn't this only applying the limit if we found
> >> a
> >> visible tuple?
> >
> >It doesn't
In SELinux file context files you can specify <> for a file
meaning you don't want restorecon to relabel it. <> is
especially useful in an SELinux MLS environment when objects are
created at a specific security level and you don't want restorecon to
relabel them to the wrong security level.
Ted
Andrew Dunstan writes:
> The buildfarm server now creates a companion to branches_of_interest.txt
> called branches_of_interest.json which looks like this:
... okay ...
> It updates this every time it does a git fetch, currently every 5 minutes.
That up-to-five-minute delay, on top of whatever
On Mon, Nov 21, 2022 at 2:10 AM Andres Freund wrote:
> On 2022-11-20 17:26:11 -0500, Robert Haas wrote:
> > On Sun, Nov 20, 2022 at 3:43 PM Andres Freund wrote:
> > > I couldn't quite decide what wait_event_type to best group this under? In
> > > the
> > > attached patch I put it under timeouts,
Hi,
On November 21, 2022 12:58:16 PM PST, Alexander Korotkov
wrote:
>On Mon, Nov 21, 2022 at 2:10 AM Andres Freund wrote:
>> On 2022-11-20 17:26:11 -0500, Robert Haas wrote:
>> > On Sun, Nov 20, 2022 at 3:43 PM Andres Freund wrote:
>> > > I couldn't quite decide what wait_event_type to best g
On Tue, Nov 22, 2022 at 12:01 AM Andres Freund wrote:
> On November 21, 2022 12:58:16 PM PST, Alexander Korotkov
> wrote:
> >On Mon, Nov 21, 2022 at 2:10 AM Andres Freund wrote:
> >> On 2022-11-20 17:26:11 -0500, Robert Haas wrote:
> >> > On Sun, Nov 20, 2022 at 3:43 PM Andres Freund wrote:
>
On Mon, Nov 21, 2022 at 2:15 PM Tom Lane wrote:
> Andres Freund writes:
> > On November 21, 2022 10:44:17 AM PST, Simon Riggs
> > wrote:
> >> Robert, something like this perhaps? limit on both the index and the heap.
>
> > I don't think we should add additional code / struct members into very
n Mon, Nov 21, 2022 at 9:58 PM Tom Lane wrote:
> Andrew Dunstan writes:
> > The buildfarm server now creates a companion to branches_of_interest.txt
> > called branches_of_interest.json which looks like this:
>
> ... okay ...
>
Yeah, it's not as efficient as something like long polling or web s
On Mon, Nov 21, 2022 at 9:51 PM Andrew Dunstan wrote:
>
> On 2022-11-20 Su 17:32, Thomas Munro wrote:
> > On Sun, Nov 20, 2022 at 2:44 AM Andrew Dunstan
> wrote:
> >> It might not suit your use case, but one of the things I do to reduce
> >> fetch load is to run a local mirror which runs
> >>
>
Hi,
On 2022-11-20 11:58:12 -0800, Peter Geoghegan wrote:
> There is code in heap_prepare_freeze_tuple() that treats a raw xmax as
> "xmax_already_frozen = true", even when the raw xmax value isn't
> already set to InvalidTransactionId. I'm referring to this code:
>
> if ( ... ) // process raw
Hi,
On 2022-11-21 16:17:56 -0500, Robert Haas wrote:
> But ... what if they're not? Could the index contain a large number of
> pages containing just 1 tuple each, or no tuples at all? If so, maybe
> we can read ten bazillion index pages trying to find each heap tuple
> and still end up in trouble
On Tue, Nov 15, 2022 at 8:29 AM Peter Eisentraut <
peter.eisentr...@enterprisedb.com> wrote:
> On 09.11.22 00:12, Corey Huinker wrote:
> > As for the docs, they're very clear and probably sufficient as-is, but I
> > wonder if we should we explicitly state that the bind-state and bind
> > parameter
On Mon, Nov 21, 2022 at 1:34 PM Andres Freund wrote:
> Hm. But to get to that point we already need to have decided that xmax
> is not a normal xid. Unhelpfully we reuse the 'xid' variable for xmax as
> well:
> xid = HeapTupleHeaderGetRawXmax(tuple);
>
> I don't really know the HEAP_XMAX_I
Hi,
On 2022-11-19 13:18:54 -0800, Andres Freund wrote:
> I'll try to repost a version of the ubsan/asan patch together with the
> sanitycheck patch and see how that looks.
I just pushed the prerequisite patch making UBSAN_OPTIONS work. Attached
is 1) addition of SanityCheck 2) use of asan and ubs
Andres Freund writes:
> On 2022-11-21 16:17:56 -0500, Robert Haas wrote:
>> But ... what if they're not? Could the index contain a large number of
>> pages containing just 1 tuple each, or no tuples at all? If so, maybe
>> we can read ten bazillion index pages trying to find each heap tuple
>> and
On 2022-11-21 Mo 16:26, Magnus Hagander wrote:
>
> Is there a reason this file is a list of hashes each hash with a
> single value in it? Would it make more sense if it was:
> {
> "REL_11_STABLE": "140c803723",
> "REL_12_STABLE": "4cbcb7ed85",
> "REL_13_STABLE": "c13667b518",
> "REL_14_S
On Mon, Nov 21, 2022 at 11:27 PM Andrew Dunstan wrote:
>
> On 2022-11-21 Mo 16:26, Magnus Hagander wrote:
>
> >
> > Is there a reason this file is a list of hashes each hash with a
> > single value in it? Would it make more sense if it was:
> > {
> > "REL_11_STABLE": "140c803723",
> > "REL_12
On 11/21/22 15:57, Ted Toth wrote:
In SELinux file context files you can specify <> for a file
meaning you don't want restorecon to relabel it. <> is
especially useful in an SELinux MLS environment when objects are
created at a specific security level and you don't want restorecon to
relabel them
On 2022-11-21 Mo 15:58, Tom Lane wrote:
> Andrew Dunstan writes:
>> The buildfarm server now creates a companion to branches_of_interest.txt
>> called branches_of_interest.json which looks like this:
> ... okay ...
>
>> It updates this every time it does a git fetch, currently every 5 minutes.
>
Andrew Dunstan writes:
> On 2022-11-21 Mo 15:58, Tom Lane wrote:
>> But if we're trying to improve matters in this area, this doesn't seem
>> like quite the way to go.
> Well, 5 minutes was originally chosen because it was sufficient for the
> purpose for which up to now the server used its mirro
On 2022-11-21 Mo 16:20, Magnus Hagander wrote:
> n Mon, Nov 21, 2022 at 9:58 PM Tom Lane wrote:
>
> Andrew Dunstan writes:
> > The buildfarm server now creates a companion to
> branches_of_interest.txt
> > called branches_of_interest.json which looks like this:
>
> ... okay
On Mon, Nov 21, 2022 at 11:41 PM Tom Lane wrote:
> Andrew Dunstan writes:
> > On 2022-11-21 Mo 15:58, Tom Lane wrote:
> >> But if we're trying to improve matters in this area, this doesn't seem
> >> like quite the way to go.
>
> > Well, 5 minutes was originally chosen because it was sufficient f
Hi,
On 2022-11-13 17:53:04 -0600, Justin Pryzby wrote:
> On Fri, Nov 04, 2022 at 06:59:46PM -0700, Andres Freund wrote:
> > > diff --git a/.cirrus.yml b/.cirrus.yml
> > > index 9f2282471a9..99ac09dc679 100644
> > > --- a/.cirrus.yml
> > > +++ b/.cirrus.yml
> > > @@ -451,12 +451,20 @@ task:
> > >
>
On Mon, Nov 21, 2022 at 5:15 PM Tom Lane wrote:
> I think we should content ourselves with improving the demonstrated
> case, which is where we're forced to do a lot of heap fetches due
> to lots of not-all-visible tuples. Whether we can spend a lot of
> time scanning the index without ever findi
On Mon, Nov 21, 2022 at 11:42 PM Andrew Dunstan wrote:
>
> On 2022-11-21 Mo 16:20, Magnus Hagander wrote:
> > n Mon, Nov 21, 2022 at 9:58 PM Tom Lane wrote:
> >
> > Andrew Dunstan writes:
> > > The buildfarm server now creates a companion to
> > branches_of_interest.txt
> > > ca
Hi,
On 2022-09-29 18:17:55 -0700, Andres Freund wrote:
> Attached is a rebased version of this patch. Hopefully with a reasonable
> amount of comments? I kind of wanted to add a comment to reached_main, but it
> just seems to end up restating the variable name...
I've now pushed a version of thi
Robert Haas writes:
> On Mon, Nov 21, 2022 at 5:15 PM Tom Lane wrote:
>> I think we should content ourselves with improving the demonstrated
>> case, which is where we're forced to do a lot of heap fetches due
>> to lots of not-all-visible tuples.
> All right. I've been bitten by this problem en
On Mon, Nov 21, 2022 at 6:17 PM Tom Lane wrote:
> evidence that it's a live problem. API warts are really hard to
> get rid of once instituted.
Yeah, agreed.
--
Robert Haas
EDB: http://www.enterprisedb.com
On Mon, Nov 21, 2022 at 03:15:03PM -0800, Andres Freund wrote:
> Hi,
>
> On 2022-09-29 18:17:55 -0700, Andres Freund wrote:
> > Attached is a rebased version of this patch. Hopefully with a reasonable
> > amount of comments? I kind of wanted to add a comment to reached_main, but
> > it
> > just
Hi,
On November 21, 2022 3:42:38 PM PST, Justin Pryzby wrote:
>On Mon, Nov 21, 2022 at 03:15:03PM -0800, Andres Freund wrote:
>> Hi,
>>
>> On 2022-09-29 18:17:55 -0700, Andres Freund wrote:
>> > Attached is a rebased version of this patch. Hopefully with a reasonable
>> > amount of comments? I
On Mon, Nov 21, 2022 at 12:26:45AM -0500, Tom Lane wrote:
> Corey Huinker writes:
>> I'm making an attempt at this or something very similar to it. I don't yet
>> have a patch ready.
Nice to hear that. If a WIP or a proof of concept takes more than a
few hours, how about beginning a new thread w
On Fri, Oct 28, 2022 at 05:34:37PM +0530, vignesh C wrote:
> Those also should be handled, attached v2 version includes the changes
> for the same.
The basic options supported by PROCEDURE are a subset of ROUTINE with a
difference of COST, IMMUTABLE, [NOT] LEAKPROOF, ROWS, STABLE
and VOLATILE.
T
Hi hackers,
While working on avoiding unnecessary wakeups in logical/worker.c (as was
done for walreceiver.c in 05a7be9), I noticed that the tests began taking
much longer. This seems to be caused by the reduced frequency of calls to
maybe_reread_subscription() in LogicalRepApplyLoop(). Presentl
On Thu, Nov 17, 2022 at 01:32:11PM +0900, Ian Lawrence Barwick wrote:
> Fujii-san is marked as committer on the commifest entry for this patch [1];
> are you able to go ahead and get it committed?
That's the state of the patch since the 11th of October. Seeing the
lack of activity, I propose to t
Hi,
On 2022-11-02 01:50:38 +, Arne Roland wrote:
> I mainly changed the comments, the Assert and some casing.
The tests have been failing for a while
https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/40/3452
https://api.cirrus-ci.com/v1/task/6190372803051520/logs/cores.log
On Tue, Nov 22, 2022 at 1:41 PM Nathan Bossart wrote:
> On my machine, the attached patch
> improved 'check-world -j8' run time by ~12 seconds (from 3min 8sec to 2min
> 56 sec) and src/test/subscription test time by ~17 seconds (from 139
> seconds to 122 seconds).
Nice!
Maybe a comment to explai
On Mon, Nov 21, 2022 at 12:25 PM Aleksander Alekseev <
aleksan...@timescale.com> wrote:
> Hi hackers,
>
> > > I have a very serious concern about the current patch set. as someone
> who has faced transaction id wraparound in the past.
> >
> > [...]
> >
> > I had a similar stance when I started wor
On Mon, Nov 21, 2022 at 10:40 AM Pavel Borisov
wrote:
> > I have a very serious concern about the current patch set. as someone
> who has faced transaction id wraparound in the past.
> >
> > I can start by saying I think it would be helpful (if the other issues
> are approached reasonably) to hav
On Tue, Nov 22, 2022 at 03:16:05PM +1300, Thomas Munro wrote:
> Maybe a comment to explain why a single variable is enough?
This crossed my mind shortly after sending my previous message. Looking
closer, I see that several types of ALTER SUBSCRIPTION do not call
PreventInTransactionBlock(), so a
Hi,
On 2022-11-22 00:03:23 +0300, Alexander Korotkov wrote:
> On Tue, Nov 22, 2022 at 12:01 AM Andres Freund wrote:
> > On November 21, 2022 12:58:16 PM PST, Alexander Korotkov
> > wrote:
> > >On Mon, Nov 21, 2022 at 2:10 AM Andres Freund wrote:
> > >+1 for making a group of individual names s
Hi Nathan,
I have done almost same thing locally for [1], but I thought your code seemed
better.
Just One comment: IIUC the statement "ALTER SUBSCRIPTION" can be executed
inside the transaction. So if two subscriptions are altered in the same
transaction, only one of them will awake. Is it expec
On Tue, Nov 22, 2022 at 2:22 AM Andres Freund wrote:
>
> On 2022-11-21 15:47:12 +0300, Maxim Orlov wrote:
> > After some investigation, I think, the problem is in the snapbuild.c
> > (commit 272248a0c1b1, see [0]). We do allocate InitialRunningXacts
> > array in the context of builder->context, bu
On Mon, Nov 21, 2022 at 03:47:38PM -0500, Robert Haas wrote:
> On Mon, Nov 21, 2022 at 3:45 PM Andres Freund wrote:
> > On 2022-11-21 00:16:20 -0800, sirisha chamarthi wrote:
> > > At present, calling pg_stat_reset* functions requires super user access
> > > unless explicitly grant execute permiss
On Tue, Nov 22, 2022 at 6:14 AM Michael Paquier wrote:
>
> On Thu, Nov 17, 2022 at 01:32:11PM +0900, Ian Lawrence Barwick wrote:
> > Fujii-san is marked as committer on the commifest entry for this patch [1];
> > are you able to go ahead and get it committed?
>
> That's the state of the patch sinc
On Mon, Nov 21, 2022 at 07:01:18PM -0800, Andres Freund wrote:
> I plan to push this soon unless somebody has further comments.
> @@ -146,7 +146,8 @@ typedef enum
> WAIT_EVENT_RECOVERY_RETRIEVE_RETRY_INTERVAL,
> WAIT_EVENT_REGISTER_SYNC_REQUEST,
> WAIT_EVENT_VACUUM_DELAY,
> -
Hi,
On 2022-11-22 12:51:25 +0900, Michael Paquier wrote:
> On Mon, Nov 21, 2022 at 07:01:18PM -0800, Andres Freund wrote:
> > I plan to push this soon unless somebody has further comments.
>
> > @@ -146,7 +146,8 @@ typedef enum
> > WAIT_EVENT_RECOVERY_RETRIEVE_RETRY_INTERVAL,
> > WAIT_EVE
On Tue, Nov 22, 2022 at 03:03:52AM +, Hayato Kuroda (Fujitsu) wrote:
> Just One comment: IIUC the statement "ALTER SUBSCRIPTION" can be executed
> inside the transaction. So if two subscriptions are altered in the same
> transaction, only one of them will awake. Is it expected behavior?
>
> I
On Mon, Nov 21, 2022 at 5:02 PM fujii.y...@df.mitsubishielectric.co.jp <
fujii.y...@df.mitsubishielectric.co.jp> wrote:
> Hi Mr.Vondra, Mr.Pyhalov, Everyone.
>
> I discussed with Mr.Pyhalov about the above draft by directly sending mail
> to
> him(outside of pgsql-hackers). Mr.Pyhalov allowed me
Thanks for addressing my review comments on v47-0001.
Here are my review comments for v49-0001.
==
src/backend/replication/logical/applyparallelworker.c
1. GENERAL - NULL checks
There is inconsistent NULL checking in the patch.
Sometimes it is like (!winfo)
Sometimes explicit NULL checks
Hi,
On Sun, Nov 13, 2022 at 08:32:47PM +0100, Pavel Stehule wrote:
>
> updated patch attached
Thanks!
Some enhancement could probably be done by a native english speaker, but apart
from that it looks good to me, so hearing no other complaints I'm marking the
CF entry as Ready for Committer!
út 22. 11. 2022 v 6:26 odesílatel Julien Rouhaud
napsal:
> Hi,
>
> On Sun, Nov 13, 2022 at 08:32:47PM +0100, Pavel Stehule wrote:
> >
> > updated patch attached
>
> Thanks!
>
> Some enhancement could probably be done by a native english speaker, but
> apart
> from that it looks good to me, so hea
On Tue, Nov 22, 2022 at 2:15 AM Andres Freund wrote:
>
> Hi,
>
> On 2022-11-21 00:16:20 -0800, sirisha chamarthi wrote:
> > At present, calling pg_stat_reset* functions requires super user access
> > unless explicitly grant execute permission on those. In this thread, I am
> > proposing to grant e
On Mon, Nov 21, 2022 at 7:03 PM Drouvot, Bertrand
wrote:
>
> On 11/21/22 12:19 AM, Andres Freund wrote:
> >
> > That's better, but still seems like quite a bit of repetition, given the
> > number of accessors. I think I like my idea of a macro defining the whole
> > function a bit better.
> >
>
>
On Tue, 22 Nov 2022 at 05:59, Michael Paquier wrote:
>
> On Fri, Oct 28, 2022 at 05:34:37PM +0530, vignesh C wrote:
> > Those also should be handled, attached v2 version includes the changes
> > for the same.
>
> The basic options supported by PROCEDURE are a subset of ROUTINE with a
> difference
On Sat, 2022-10-22 at 14:22 +1300, Thomas Munro wrote:
> Problem 2: If ICU 67 ever decides to report a different version for
> a
> given collation (would it ever do that? I don't expect so, but ...),
> we'd be unable to open the collation with the search-by-collversion
> design, and potentially
Dear Nathan,
> I think you are correct. I did it this way in v2. I've also moved the
> bulk of the logic to logical/worker.c.
Thanks for updating! It becomes better. Further comments:
01. AlterSubscription()
```
+ LogicalRepWorkersWakeupAtCommit(subid);
+
```
Currently subids will be r
Hi hackers,
Please find attached a patch proposal to $SUBJECT.
The idea has been proposed by Andres in [1] and can be seen as preparatory work
for [1].
The patch introduces 2 new Macros, PGSTAT_DEFINE_REL_INT64_FIELD_ACCESSOR and
PGSTAT_DEFINE_REL_TSTZ_FIELD_ACCESSOR.
For some functions (nam
Hi,
On 11/22/22 7:19 AM, Bharath Rupireddy wrote:
On Mon, Nov 21, 2022 at 7:03 PM Drouvot, Bertrand
wrote:
On 11/21/22 12:19 AM, Andres Freund wrote:
That's better, but still seems like quite a bit of repetition, given the
number of accessors. I think I like my idea of a macro defining the
On Tuesday, November 22, 2022 1:39 PM Nathan Bossart
wrote:
> On Tue, Nov 22, 2022 at 03:03:52AM +, Hayato Kuroda (Fujitsu) wrote:
> > Just One comment: IIUC the statement "ALTER SUBSCRIPTION" can be
> > executed inside the transaction. So if two subscriptions are altered
> > in the same tran
Hello.
I noticed that $SUBJECT. "spurious" here means the locks on the rows
that are not seemingly qualified by the query condition (that is, EPQ
failure).
It doesn't seem to be a bug to me (or it
seems just inevitable.). But that doesn't seems to be described either
in the doc. If I'm right here
On Tuesday, November 22, 2022 2:49 PM Hayato Kuroda (Fujitsu)
>
> Dear Nathan,
>
> > I think you are correct. I did it this way in v2. I've also moved
> > the bulk of the logic to logical/worker.c.
>
> Thanks for updating! It becomes better. Further comments:
>
> 01. AlterSubscription()
>
Hi,
On 2022-11-13 20:32:47 +0100, Pavel Stehule wrote:
> updated patch attached
It fails with address sanitizer that's now part of CI:
https://cirrus-ci.com/task/6031397744279552?logs=test_world#L2659
[06:33:11.271] # ==31965==ERROR: AddressSanitizer: heap-buffer-overflow on
address 0x6190
út 22. 11. 2022 v 8:39 odesílatel Andres Freund napsal:
> Hi,
>
> On 2022-11-13 20:32:47 +0100, Pavel Stehule wrote:
> > updated patch attached
>
> It fails with address sanitizer that's now part of CI:
>
> https://cirrus-ci.com/task/6031397744279552?logs=test_world#L2659
>
> [06:33:11.271] # ==3
On Wed, Nov 16, 2022 at 7:38 AM Sergey Shinderuk
wrote:
> The failing query is:
> SELECT * FROM
>(SELECT *,
>count(salary) OVER (PARTITION BY depname || '') c1, -- w1
>row_number() OVER (PARTITION BY depname) rn, -- w2
>count(*) OVER (PARTITION BY depname)
Hi,
On 11/17/22 1:51 PM, Bharath Rupireddy wrote:
Hi,
pg_stat_bgwriter view currently reports checkpointer stats as well. It
is that way because historically checkpointer was part of bgwriter
until the commits 806a2ae and bf405ba, that went into PG 9.2,
separated them out. I think it is time fo
101 - 165 of 165 matches
Mail list logo
