Hi,
On 1/18/23 10:59 AM, Alvaro Herrera wrote:
On 2023-Jan-18, Drouvot, Bertrand wrote:
The current calls are done that way:
wait_for_replay_catchup called:
- 8 times with write LSN as an argument
- 1 time with insert LSN as an argument
- 16 times with flush LSN as an argument
So it looks
On Thursday, January 19, 2023 10:42 AM Peter Smith
wrote:
> On Wed, Jan 18, 2023 at 6:06 PM Peter Smith
> wrote:
> >
> > Here are my review comments for the latest patch v16-0001. (excluding
> > the test code)
> >
> ...
> >
> > 8. AlterSubscription (general)
> >
> > I observed during testing th
Dear Amit, hackers,
> Let me try to summarize the discussion till now. The problem we are
> trying to solve here is to allow a shutdown to complete when walsender
> is not able to send the entire WAL. Currently, in such cases, the
> shutdown fails. As per our current understanding, this can happen
On 18.01.23 08:04, Michael Paquier wrote:
On Tue, Jan 17, 2023 at 04:52:28PM +0900, Michael Paquier wrote:
On Tue, Jan 17, 2023 at 08:43:44AM +0100, Peter Eisentraut wrote:
Ok, I understand now, and I agree with this approach over the opposite. I
was confused because the snippet you showed abov
On Thu, Jan 19, 2023 at 09:42:03AM +0100, Peter Eisentraut wrote:
> I see that in the 0003 patch, most location fields now have an explicit
> markup with query_jumble_ignore. I thought we had previously resolved to
> consider location fields to be automatically ignored unless explicitly
> included
On 17.01.23 13:18, Aleksander Alekseev wrote:
This is a follow-up to [1] and c8ad4d81.
Additionally Bharath pointed out that there are other pieces of code
that we may want to change in a similar fashion,
proclist.h/proclist_types.h as one example. I didn't do this yet
because I would like to k
> Yes, the existing caller isn't using the fetched values when noshow is
> set to true. However, I think returning from GetConfigOptionValues()
> when noshow is set to true without fetching values limits the use of
> the function. What if someother caller wants to use the function to
> get the valu
Hello! In continuation of the topic, I, under the leadership of
Alexander Lakhin, prepared patches that fix these problems.
We decided that these checks would be enough and put them in the places
we saw fit.diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c
index f
Dear hackers, my good friend Hou Jiaxing and I have implemented a version of
the code that supports multiple integer range conditions in the in condition
control of the for loop statement in the plpgsql procedural language. A typical
example is as follows:
postgres=# do $$
declare
i int :=
On 1/19/23 4:47 AM, Nathan Bossart wrote:
This seems like a clear improvement to me. However, as the attribute
system becomes more sophisticated, I think we ought to improve the error
messages in user.c. IMHO messages like "permission denied" could be
greatly improved with some added context.
I
Hi,
On 1/19/23 3:46 AM, Andres Freund wrote:
Hi,
On 2023-01-18 11:24:19 +0100, Drouvot, Bertrand wrote:
On 1/6/23 4:40 AM, Andres Freund wrote:
Hm, that's quite expensive. Perhaps worth adding a C helper that can do that
for us instead? This will likely also be needed in real applications aft
In [1] I noticed a bit of a poor usage of appendStringInfoString which
just appends 4 spaces in a loop, one for each indent level of the
jsonb. It should be better just to use appendStringInfoSpaces and
just append all the spaces in one go rather than appending 4 spaces in
a loop. That'll save hav
> Possibly a better answer is to refactor into separate functions,
> along the lines of
>
> static bool
> ConfigOptionIsShowable(struct config_generic *conf)
>
> static void
> GetConfigOptionValues(struct config_generic *conf, const char **values)
Nice suggestion. Attached a patch for the same. Pl
Hi,
On Tue, Jan 17, 2023 at 10:53:23PM +0900, torikoshia wrote:
> >
> > For interactive EXPLAIN the query identifier is printed just after the
> > plan,
> > before the triggers and the JIT summary so auto_explain should do the
> > same.
> Thanks for the comment!
> Agreed and updated the patch.
Th
On 17/01/2023 22:51, Andres Freund wrote:
Hi,
On 2022-12-16 10:52:23 +, Niyas Sait wrote:
Subject: [PATCH v7] Enable postgres native build for windows-arm64 platform
elif host_cpu == 'arm' or host_cpu == 'aarch64'
- prog = '''
+ if cc.get_id() == 'msvc'
+cdata.set('USE_ARM
On Thu, Jan 19, 2023 at 11:11 AM Amit Kapila wrote:
>
> On Wed, Jan 18, 2023 at 12:09 PM Amit Kapila wrote:
> >
> > On Fri, Jan 13, 2023 at 11:50 AM Peter Smith wrote:
> > >
> > > Here are some review comments for patch v79-0002.
> > >
> >
> > So, this is about the latest v84-0001-Stop-extra-wor
On Thu, Jan 19, 2023 at 3:44 PM shveta malik wrote:
>
> On Thu, Jan 19, 2023 at 11:11 AM Amit Kapila wrote:
> >
> > On Wed, Jan 18, 2023 at 12:09 PM Amit Kapila
> > wrote:
> > >
> > > On Fri, Jan 13, 2023 at 11:50 AM Peter Smith
> > > wrote:
> > > >
> > > > Here are some review comments for p
On 2023-Jan-18, Tom Lane wrote:
> Alvaro Herrera writes:
> > and was surprised that the match for the 'day & drink' arm of the OR
> > disappears from the reported headline.
>
> I'd argue that that's exactly what should happen. It's supposed to
> find as-short-as-possible cover strings that sat
On Wed, Jan 18, 2023 at 6:00 PM Amit Kapila wrote:
> + */
> + ReorderBufferUpdateProgressCB update_progress;
>
> Are you suggesting changing the name of the above variable? If so, how
> about apply_progress, progress, or updateprogress? If you don't like
> any of these then feel free to suggest s
Hi Andres,
I also couldn't help and hacked a bit on the rdtsc pieces. I did figure out
how to do the cycles->nanosecond conversion with integer shift and multiply in
the common case, which does show a noticable speedup. But that's for another
day.
I also have code for that here. I decided agains
On Thu, 19 Jan 2023 at 12:06, Takamichi Osumi (Fujitsu)
wrote:
>
> Updated the comment and the function call.
>
> Kindly have a look at the updated patch v17.
Thanks for the updated patch, few comments:
1) min_apply_delay was accepting values like '600 m s h', I was not
sure if we should allow th
Is there anything that is currently blocking this patch? I'd quite
like it to get into PG16.
Especially since I ran into another use case that I would want to use
this patch for recently: Adding an async cancel function to Python
it's psycopg3 library. This library exposes both a Connection class
On Fri, 6 Jan 2023 at 11:20, vignesh C wrote:
>
> On Tue, 3 Jan 2023 at 16:01, vignesh C wrote:
> >
> > On Tue, 29 Nov 2022 at 00:57, Daniel Gustafsson wrote:
> > >
> > > > On 28 Nov 2022, at 20:02, Nikolay Shaplov wrote:
> > >
> > > > From my reviewer's point of view patch is ready for commit.
On 1/19/23 3:05 PM, tushar wrote:
which was working previously without patch.
My bad, I was testing against PG v15 but this issue is not
reproducible on master (without patch).
As you mentioned- "This implements the standard idea that you can't give
permissions
you don't have (but you can give
On Tue, Jan 17, 2023 at 7:33 PM Alvaro Herrera wrote:
> On 2022-Dec-12, Amit Langote wrote:
> > On Sun, Dec 11, 2022 at 6:25 PM Amit Langote
> > wrote:
> > > I've attached 0001 to remove those extraneous code blocks and add a
> > > comment mentioning that userid need not be recomputed.
> > >
> >
On Wed, Jan 11, 2023 at 4:20 PM wangw.f...@fujitsu.com
wrote:
>
> When I was reading the "Logical Decoding Output Plugins" chapter in pg-doc
> [1],
> I think in the summary section, only the callback message_cb is not described
> whether it is required or optional, and the description of callback
On Wed, 18 Jan 2023 at 03:30, Melanie Plageman
wrote:
>
> v49 attached
>
> On Tue, Jan 17, 2023 at 2:12 PM Andres Freund wrote:
> > On 2023-01-17 12:22:14 -0500, Melanie Plageman wrote:
> >
> > > > > +typedef struct PgStat_BackendIO
> > > > > +{
> > > > > + PgStat_Counter
> > > > > data[IOCO
On Thu, Jan 19, 2023 at 4:47 PM Amit Kapila wrote:
>
> On Wed, Jan 11, 2023 at 4:20 PM wangw.f...@fujitsu.com
> wrote:
> >
> > When I was reading the "Logical Decoding Output Plugins" chapter in pg-doc
> > [1],
> > I think in the summary section, only the callback message_cb is not
> > describe
On Fri, 6 Jan 2023 at 00:19, Reid Thompson
wrote:
>
> On Tue, 2023-01-03 at 16:22 +0530, vignesh C wrote:
> >
> > The patch does not apply on top of HEAD as in [1], please post a
> > rebased patch:
> > ...
> > Regards,
> > Vignesh
> >
>
> Attached is rebased patch, with some updates related t
On Sat, 14 Jan 2023 at 15:47, Dmitry Koval wrote:
>
> Hi!
>
> >The patch does not apply on top of HEAD ...
>
> Here is a fixed version.
> Small additional fixes:
> 1) added CRC calculation for empty 'pg_control_log' file;
> 2) added saving 'errno' before calling LWLockRelease and restoring after
Looks good to me. One tiny typo in a comment that I noticed when going
over the diff:
+* Mark the token as quoted, so it will only be compared literally
+* and not for some special meaning, such as "all" or a group
+* membership checks.
should be either:
1. a g
On Wed, 3 Aug 2022 at 09:04, David Rowley wrote:
>
> On Wed, 3 Aug 2022 at 07:04, Jacob Champion wrote:
> > This entry has been waiting on author input for a while (our current
> > threshold is roughly two weeks), so I've marked it Returned with
> > Feedback.
>
> Thanks for taking care of this. Y
On Tue, 3 Jan 2023 at 19:49, Drouvot, Bertrand
wrote:
>
> Hi,
>
> On 12/10/22 10:54 AM, Drouvot, Bertrand wrote:
> > Hi,
> >
> > On 12/7/22 11:11 AM, Drouvot, Bertrand wrote:
> >> Hi,
> >>
> >>> Hi,
> >>>
> >>> As [1] mentioned above has been committed (83a1a1b566), please find
> >>> attached V5
On Thu, Jan 19, 2023 at 4:13 PM Ashutosh Bapat
wrote:
>
> On Wed, Jan 18, 2023 at 6:00 PM Amit Kapila wrote:
>
> > + */
> > + ReorderBufferUpdateProgressCB update_progress;
> >
> > Are you suggesting changing the name of the above variable? If so, how
> > about apply_progress, progress, or update
Hi!
For the test Alexander described in the beginning of the discussion - the
results are
postgres@postgres=# set role regress_vacuum_conflict;
SET
Time: 0.324 ms
postgres@postgres=> vacuum vacuum_tab;
WARNING: permission denied to vacuum "vacuum_tab", skipping it
WARNING: permission denied to v
On Sat, 7 Jan 2023 at 10:37, Nathan Bossart wrote:
>
> rebased for cfbot
The patch does not apply on top of HEAD as in [1], please post a rebased patch:
=== Applying patches on top of PostgreSQL commit ID
d540a02a724b9643205abce8c5644a0f0908f6e3 ===
=== applying patch ./v2-0001-add-PROCESS_MAIN-t
> On 19 Jan 2023, at 12:14, vignesh C wrote:
> The patch does not apply on top of HEAD as in [1], please post a rebased
> patch:
Sorry for the silence, and thanks for your previous rebase, $life has kept me
too busy lately. I'll post a rebased version shortly.
--
Daniel Gustafsson
On 2023-Jan-19, Amit Langote wrote:
> It seems that, with the test as written, it's not the partitioned
> table referenced in the view's query that becomes a child of the UNION
> ALL parent subquery, but the subquery itself. The bug being fixed in
> 0002 doesn't affect the planning of this query
On 2023-Jan-18, Karl O. Pinc wrote:
> Oops. Already sent a revised patch that includes starting each
> module on a new page, for PDF output. I'll wait to rip that
> out after review and start a new thread if necessary.
Here's my review in the form of a delta patch.
I didn't find that a thing
On Wed, 2023-01-18 at 16:23 -0500, Bruce Momjian wrote:
> Is it possible to document when partition table statistics helps?
I think it would be difficult to come up with an exhaustive list.
Yours,
Laurenz Albe
On Wed, 2023-01-18 at 15:03 -0500, Tom Lane wrote:
> Laurenz Albe writes:
> > On Tue, 2023-01-17 at 10:32 -0500, Tom Lane wrote:
> > > I seem to recall that the original idea was to report the timestamp
> > > of the commit/abort record we are stopping at. Maybe my memory is
> > > faulty, but I th
On 1/19/23 2:44 AM, Nathan Bossart wrote:
On Wed, Jan 18, 2023 at 02:51:38PM -0500, Robert Haas wrote:
Should (nfree < SuperuserReservedBackends) be using <=, or am I confused?
I believe < is correct. At this point, the new backend will have already
claimed a proc struct, so if the number of r
On Thu, Jan 19, 2023 at 4:25 PM vignesh C wrote:
>
> On Thu, 19 Jan 2023 at 12:06, Takamichi Osumi (Fujitsu)
> wrote:
> >
> > Updated the comment and the function call.
> >
> > Kindly have a look at the updated patch v17.
>
> Thanks for the updated patch, few comments:
> 1) min_apply_delay was ac
Hi
čt 19. 1. 2023 v 10:23 odesílatel 2903807...@qq.com <2903807...@qq.com>
napsal:
> Dear hackers, my good friend Hou Jiaxing and I have implemented a version
> of the code that supports multiple integer range conditions in the in
> condition control of the for loop statement in the plpgsql proc
On Thu, Jan 19, 2023 at 12:06 PM Takamichi Osumi (Fujitsu)
wrote:
>
> Kindly have a look at the updated patch v17.
>
Can we try to optimize the test time for this test? On my machine, it
is the second highest time-consuming test in src/test/subscription. It
seems you are waiting twice for apply_d
On Wed, 18 Jan 2023 at 08:27, Ankit Kumar Pandey wrote:
> There is bit confusion in wording here:
>
> "returns a List of pathkeys
> which are in keys1 but not in keys2 and NIL if keys2 has a pathkey
> that does not exist as a pathkey in keys1."
>
> You mean extract common keys without ordering rig
On Thu, Jan 19, 2023 at 6:28 PM tushar
wrote:
> On 1/19/23 2:44 AM, Nathan Bossart wrote:
> > On Wed, Jan 18, 2023 at 02:51:38PM -0500, Robert Haas wrote:
> >> Should (nfree < SuperuserReservedBackends) be using <=, or am I
> confused?
> > I believe < is correct. At this point, the new backend w
On Thu, 19 Jan 2023 at 18:29, Amit Kapila wrote:
>
> On Thu, Jan 19, 2023 at 4:25 PM vignesh C wrote:
> >
> > On Thu, 19 Jan 2023 at 12:06, Takamichi Osumi (Fujitsu)
> > wrote:
> > >
> > > Updated the comment and the function call.
> > >
> > > Kindly have a look at the updated patch v17.
> >
> >
Hi Michael,
I got a customer case that matches this issue. The customer is on an
old version of 12, but I see the patch only went into 14:
On Tue, 8 Dec 2020 at 00:32, Michael Paquier wrote:
> > Yes the attached patch looks good to me for PostgreSQL. Thanks Michael.
> Okay, committed to HEAD the
čt 19. 1. 2023 v 1:20 odesílatel Bruce Momjian napsal:
> Just my luck, I had to dig into a two-"character" emoji that came to me
> as part of a Google Calendar entry --- here it is:
>
> 👩🏼⚕️🩺
>
> libc
> Unicode UTF8 len
> U+1F469 f0
Hi hackers,
> Fixed.
I noticed that this patch stuck a little and decided to take another look.
It seems to be well written, covered with tests and my understanding
is that all the previous feedback was accounted for. To your knowledge
is there anything that prevents us from moving it to "Ready
Hello, thank you very much for your reply. But I think you may have
misunderstood what we have done.
What we do this time is that we can use multiple range ranges
(condition_iterator) after in. Previously, we can only use such an interval
[lower, upper] after in, but in some scenarios, we may
On Thu, Jan 19, 2023 at 6:50 PM tushar
wrote:
> and in the error message too
>
> [edb@centos7tushar bin]$ ./psql postgres -U r2
>
> psql: error: connection to server on socket "/tmp/.s.PGSQL.5432" failed:
> FATAL: remaining connection slots are reserved for roles with privileges
> of pg_use_rese
On 18.01.23 18:01, Vik Fearing wrote:
On 1/18/23 16:06, Peter Eisentraut wrote:
On 05.12.22 21:18, Vik Fearing wrote:
On 12/5/22 15:57, Vik Fearing wrote:
The SQL:2023 Standard defines a new aggregate named ANY_VALUE. It
returns an implementation-dependent (i.e. non-deterministic) value
from
On Thu, Jan 19, 2023 at 6:15 AM tushar wrote:
> postgres=# create role fff with createrole;
> CREATE ROLE
> postgres=# create role xxx;
> CREATE ROLE
> postgres=# set role fff;
> SET
> postgres=> alter role xxx with createrole;
> ERROR: permission denied
> postgres=>
Here fff would need ADMIN OP
On Wed, Jan 18, 2023 at 6:17 PM Nathan Bossart wrote:
> > Here is a patch implementing the above proposal. Since this is fairly
> > closely related to already-committed work, I would like to get this
> > into v16. That way, all the changes to how CREATEROLE works will go
> > into a single release,
Pavel Stehule writes:
> čt 19. 1. 2023 v 10:23 odesílatel 2903807...@qq.com <2903807...@qq.com>
> napsal:
>> Dear hackers, my good friend Hou Jiaxing and I have implemented a version
>> of the code that supports multiple integer range conditions in the in
>> condition control of the for loop state
On Thu, Jan 19, 2023 at 9:21 AM tushar wrote:
> that is not true because the superuser can still able to connect,
It is true, but because superusers have all privileges.
--
Robert Haas
EDB: http://www.enterprisedb.com
On 1/18/23 20:05, gkokola...@pm.me wrote:
>
>
>
>
>
> --- Original Message ---
> On Wednesday, January 18th, 2023 at 3:00 PM, Tomas Vondra
> wrote:
>
>
>>
>>
>> Hi,
>>
>> On 1/16/23 16:14, gkokola...@pm.me wrote:
>>
>>> Hi,
>>>
>>> I admit I am completely at lost as to what is expe
On Wed, Jan 18, 2023 at 3:58 PM Mark Dilger
wrote:
> > On Jan 18, 2023, at 12:51 PM, Robert Haas wrote:
> >
> > Unless I'm missing something, it seems like this could be a quite small
> > patch.
>
> I didn't like the idea of the create/alter subscription commands needing to
> parse the connecti
čt 19. 1. 2023 v 15:20 odesílatel 2903807...@qq.com <2903807...@qq.com>
napsal:
> Hello, thank you very much for your reply. But I think you may have
> misunderstood what we have done.
>
> What we do this time is that we can use multiple range ranges
> (condition_iterator) after in. Previously, we
Hi,
On Thursday, January 19, 2023 3:14 PM Michael Paquier
wrote:
> On Wed, Jan 18, 2023 at 02:04:16PM +0530, Bharath Rupireddy wrote:
> > [1]
> > diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index
> > 89d53f2a64..6f9509267c 100644
> > --- a/doc/src/sgml/config.sgml
> > +++ b/
Alvaro Herrera writes:
> On 2023-Jan-18, Tom Lane wrote:
>> It's including hits for "day" into the cover despite the lack of any
>> nearby match to "drink".
> I suppose it would be possible to put 'day' and 'drink' in two different
> fragments: since the query has a & operator for them, the words
čt 19. 1. 2023 v 16:54 odesílatel Pavel Stehule
napsal:
>
>
> čt 19. 1. 2023 v 15:20 odesílatel 2903807...@qq.com <2903807...@qq.com>
> napsal:
>
>> Hello, thank you very much for your reply. But I think you may have
>> misunderstood what we have done.
>>
>> What we do this time is that we can us
On Wed, Jan 18, 2023 at 10:27:46AM -0500, Isaac Morland wrote:
> On Wed, 18 Jan 2023 at 00:00, Pavel Stehule wrote:
>
> > út 17. 1. 2023 v 20:29 odesílatel Isaac Morland
> > napsal:
> >
> >> I welcome comments and feedback. Now to try to find something manageable
> >> to review.
> >
> > looks w
On Wed, Jan 18, 2023 at 4:14 PM Nathan Bossart wrote:
> On Wed, Jan 18, 2023 at 02:51:38PM -0500, Robert Haas wrote:
> > Should (nfree < SuperuserReservedBackends) be using <=, or am I confused?
>
> I believe < is correct. At this point, the new backend will have already
> claimed a proc struct,
--- Original Message ---
On Thursday, January 19th, 2023 at 4:45 PM, Tomas Vondra
wrote:
>
>
> On 1/18/23 20:05, gkokola...@pm.me wrote:
>
> > --- Original Message ---
> > On Wednesday, January 18th, 2023 at 3:00 PM, Tomas Vondra
> > tomas.von...@enterprisedb.com wrote:
On Thu, 19 Jan 2023 13:35:17 +0100
Alvaro Herrera wrote:
> On 2023-Jan-18, Karl O. Pinc wrote:
>
> > Oops. Already sent a revised patch that includes starting each
> > module on a new page, for PDF output. I'll wait to rip that
> > out after review and start a new thread if necessary.
(I have
On Thu, 19 Jan 2023 at 00:45, Andrey Borodin wrote:
> But..do we have to treat any unknown start sequence of bytes as a TLS
> connection? Or is there some definite subset of possible first bytes
> that clearly indicates that this is a TLS connection or not?
Absolutely not, there's only one Messa
On Thu, Jan 19, 2023 at 10:42:47AM -0300, Arthur Nascimento wrote:
> Would it be possible to backport the patch to 12 and 13?
This was recently back-patched [0] [1] [2].
[0] https://postgr.es/m/y70xnvbuwqsr2...@paquier.xyz
[1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=c0ee694
On Thu, 19 Jan 2023 at 14:10, Nathan Bossart wrote:
> This was recently back-patched [0] [1] [2].
Oh, I see that now. Thanks! Sorry for the noise.
--
Arthur Nascimento
EDB
If we never expect getRecordTimestamp to fail, then why put it in the
if-condition?
getRecordTimestamp can fail if the record is not a restore point nor a
commit or abort record. A few lines before in the same function there is
this:
/* Otherwise we only consider stopping before COMMIT or ABORT
Laurenz Albe writes:
> On Wed, 2023-01-18 at 15:03 -0500, Tom Lane wrote:
>> Ah, but that only happens if recoveryTarget == RECOVERY_TARGET_TIME.
>> Digging in the git history, I see that this did use to work as
>> I remember: we always extracted the record time before printing it.
>> That was acc
=?UTF-8?Q?Torsten_F=C3=B6rtsch?= writes:
> Why not
> (void)getRecordTimestamp(record, &recordXtime);
> if (recoveryTarget == RECOVERY_TARGET_TIME)
> ...
Could've done it like that, but I already pushed the other
version, and I don't think it's worth the trouble to change.
Hi.
I took a quick look at the patch. It needs a rebase, although it applies
fine using patch.
A couple minor comments:
1) addl_conds seems a bit hard to understand, I'd use either the full
wording (additional_conds) or maybe extra_conds
2) some of the lines got quite long, and need a wrap
3)
On Thu, Jan 19, 2023 at 11:40:53AM -0500, Robert Haas wrote:
> On Wed, Jan 18, 2023 at 4:14 PM Nathan Bossart
> wrote:
>> On Wed, Jan 18, 2023 at 02:51:38PM -0500, Robert Haas wrote:
>> > Should (nfree < SuperuserReservedBackends) be using <=, or am I confused?
>>
>> I believe < is correct. At t
On Thu, Jan 19, 2023 at 2:05 AM Amit Kapila wrote:
>
> On Thu, Jan 19, 2023 at 8:39 AM Zheng Li wrote:
> >
> > On Wed, Jan 18, 2023 at 6:27 AM Amit Kapila wrote:
> > >
> > > On Sat, Jan 7, 2023 at 8:58 PM Zheng Li wrote:
> > > >
> >
> > Foreign Tables can also be considered replicated with DDL
Hi,
On 1/19/23 17:42, gkokola...@pm.me wrote:
>
> --- Original Message ---
> On Thursday, January 19th, 2023 at 4:45 PM, Tomas Vondra
> wrote:
>>
>> On 1/18/23 20:05, gkokola...@pm.me wrote:
>>
>>> --- Original Message ---
>>> On Wednesday, January 18th, 2023 at 3:00 PM, Tomas V
On Thu, 19 Jan 2023 11:03:53 -0600
"Karl O. Pinc" wrote:
> Attached are 2 patches, a regular and a delta from your v4 review:
>
> contrib_v5-delta.patch.txt
> contrib_v5.patch.txt
I left your appendix title unchanged: "Additional Supplied
Extensions and Modules".
I had put "Extensions" afte
On Thu, 19 Jan 2023 at 11:30, Justin Pryzby wrote:
> On Wed, Jan 18, 2023 at 10:27:46AM -0500, Isaac Morland wrote:
> >
> > I thought I had: https://commitfest.postgresql.org/42/4133/
>
> This is failing tests:
> http://cfbot.cputube.org/isaac-morland.html
>
> It seems like any "make check" would
On Wed, 2023-01-18 at 14:38 -0500, Robert Haas wrote:
> I was just noticing that what was committed here didn't actually fix
> the problem implied by the subject line. That is, non-superuser still
> can't own subscriptions. To put that another way, there's no way for
> the superuser to delegate the
On Tue, Jan 17, 2023 at 11:24 AM Thomas Munro wrote:
> Another idea would be to teach the latch infrastructure itself to
> magically swap latch events to position 0. Latches are usually
> prioritised; it's only in this rare race case that they are not.
I liked that idea for a while, but I suspec
On Thu, 2023-01-19 at 10:45 -0500, Robert Haas wrote:
> I wouldn't be OK with writing our own connection string parser for
> this purpose, but using PQconninfoParse seems OK. We still have to
> embed knowledge of which connection string parameters can trigger
> local file access, but that doesn't s
On Thu, Jan 19, 2023 at 05:28:25PM +0530, vignesh C wrote:
> The patch does not apply on top of HEAD as in [1], please post a rebased
> patch:
rebased
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
>From 7a7f96bf4eea5be6cc252dda6bc330e77a6a3316 Mon Sep 17 00:00:00 2001
From: Nath
On Thu, Jan 19, 2023 at 8:55 AM Aleksander Alekseev
wrote:
> I noticed that this patch stuck a little and decided to take another look.
>
> It seems to be well written, covered with tests and my understanding
> is that all the previous feedback was accounted for. To your knowledge
> is there anyth
On Thu, Jan 19, 2023 at 1:40 PM Jeff Davis wrote:
> On Thu, 2023-01-19 at 10:45 -0500, Robert Haas wrote:
> > I wouldn't be OK with writing our own connection string parser for
> > this purpose, but using PQconninfoParse seems OK. We still have to
> > embed knowledge of which connection string par
On Thu, Jan 19, 2023 at 12:54 PM Nathan Bossart
wrote:
> > OK. Might be worth a short comment.
>
> I added one.
Thanks. I'd move it to the inner indentation level so it's closer to
the test at issue.
I would also suggest reordering the documentation and the
postgresql.conf.sample file so that re
On 19/01/23 18:49, David Rowley wrote:
I think you should write a function like:
bool pathkeys_count_contained_in_unordered(List *keys1, List *keys2,
List **reorderedkeys, int *n_common)
which works very similarly to pathkeys> _count_contained_in, but
populates *reorderedkeys so it cont
On 2023-01-18 We 17:14, Tom Lane wrote:
> Andrew Dunstan writes:
>> I think we can do what you want but it's a bit harder than what you've
>> done. If we're not going to save the current run's product then we need
>> to run the upgrade test from a different directory (probably directly in
>> "$b
I spent some time re-reading this whole thread, and the more I read
the less happy I got. We are adding a lot of complexity and introducing
coding hazards that will surely bite somebody someday. And after awhile
I had what felt like an epiphany: the whole problem arises because the
system is wron
On Thu, Jan 19, 2023 at 02:17:35PM -0500, Robert Haas wrote:
> On Thu, Jan 19, 2023 at 12:54 PM Nathan Bossart
> wrote:
>> > OK. Might be worth a short comment.
>>
>> I added one.
>
> Thanks. I'd move it to the inner indentation level so it's closer to
> the test at issue.
I meant for it to cove
On Wed, Jan 18, 2023 at 1:31 PM Peter Geoghegan wrote:
> pgstat_report_analyze() will totally override the
> tabentry->dead_tuples information that drives autovacuum.c, based on
> an estimate derived from a random sample -- which seems to me to be an
> approach that just doesn't have any sound the
On Thu, Jan 19, 2023 at 2:46 PM Nathan Bossart wrote:
> > Thanks. I'd move it to the inner indentation level so it's closer to
> > the test at issue.
>
> I meant for it to cover the call to HaveNFreeProcs() as well since the same
> idea applies. I left it the same for now, but if you still think
Thomas Munro writes:
> So I think we probably need something like the attached, which I was
> originally trying to avoid.
Yeah, something like that. I also wonder if you don't need to think
a bit harder about the ordering of the flag checks, in particular
it seems like servicing reload_request b
On 11.01.23 12:05, Peter Eisentraut wrote:
I think there is also an adjacent issue: The subdir options may be
absolute or relative. So if you specify --prefix=/usr/local and
--sysconfdir=/etc/postgresql, then
config_paths_data.set_quoted('SYSCONFDIR', dir_prefix / dir_sysconf)
would pr
Hi,
On 2023-01-19 21:37:15 +0100, Peter Eisentraut wrote:
> On 11.01.23 12:05, Peter Eisentraut wrote:
> > I think there is also an adjacent issue: The subdir options may be
> > absolute or relative. So if you specify --prefix=/usr/local and
> > --sysconfdir=/etc/postgresql, then
> >
> > c
On 12/31/22 06:17, Peter Eisentraut wrote:
> On 21.12.22 06:46, Peter Eisentraut wrote:
>> And another update. The main changes are that I added an 'unspecified'
>> CMK algorithm, which indicates that the external KMS knows what it is
>> but the database system doesn't. This was discussed a whi
It would be great if PostgreSQL supported 'start with TLS', however, how
could clients activate the feature?
I would like to refrain users from configuring the handshake mode, and I
would like to refrain from degrading performance when a new client talks to
an old database.
What if the server tha
On Thu, Jan 19, 2023 at 01:50:05PM +0100, Laurenz Albe wrote:
> On Wed, 2023-01-18 at 16:23 -0500, Bruce Momjian wrote:
> > Is it possible to document when partition table statistics helps?
>
> I think it would be difficult to come up with an exhaustive list.
I was afraid of that. I asked only b
Hi,
On 2023-01-19 15:12:12 -0500, Robert Haas wrote:
> On Wed, Jan 18, 2023 at 1:31 PM Peter Geoghegan wrote:
> > pgstat_report_analyze() will totally override the
> > tabentry->dead_tuples information that drives autovacuum.c, based on
> > an estimate derived from a random sample -- which seems
1 - 100 of 169 matches
Mail list logo
