[HACKERS] Documentation of contrib modules

2007-06-21 Thread Albert Cervera Areny
Hi, I think I'll have some spare time and I wanted to add some documentation of contrib modules as discussed in [1]. Then it was suggested only some of the contrib modules should be in the main docbook documentation. IMHO all of them (except start-scripts, probably) should be there so t

Re: [HACKERS] month abreviation

2007-06-21 Thread Jaime Casanova
On 6/22/07, Euler Taveira de Oliveira <[EMAIL PROTECTED]> wrote: Jaime Casanova wrote: > note the month abreviation (mons?) is this intentional? > This notation has been used since the code was written (~7 years ago) [1]. [1] http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/ad

[HACKERS] pgstat_drop_relation bugfix

2007-06-21 Thread ITAGAKI Takahiro
I wrote: > the runtime statistics are not invalidated -- it cound be a bug. > pgstat_drop_relation() is expecting relid (pg_class.oid) as the argument, > but we pass it relfilenode. > > [storage/smgr/smgr.c] > smgr_internal_unlink(RelFileNode rnode, int which, bool isTemp, bool isRedo) > p

Re: [HACKERS] autovacuum launcher continues to run after reloading autovacuum=off

2007-06-21 Thread ITAGAKI Takahiro
I wrote: > I found that the autovacuum launcher continues to run and spawn workers > after reloading the configuration file with autovacuum = off in CVS HEAD. Sorry, I found this issue will be fixed in the 'more autovacuum fixes' patch. The workers still continues to run, but it would be not a ser

Re: [HACKERS] month abreviation

2007-06-21 Thread Euler Taveira de Oliveira
Jaime Casanova wrote: > note the month abreviation (mons?) is this intentional? > This notation has been used since the code was written (~7 years ago) [1]. [1] http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/datetime.c?rev=1.42;content-type=text%2Fx-cvsweb-markup --

Re: [HACKERS] EOL characters and multibyte encodings

2007-06-21 Thread Joe Conway
Tom Lane wrote: Joe Conway <[EMAIL PROTECTED]> writes: My first thought on fixing this issue was to simply replace all instances of '\r' in pg_proc.prosrc with '\n' prior to sending it to the R parser. As far as I know, any instances of '\r' embedded in a syntactically valid R statement must b

Re: [HACKERS] EOL characters and multibyte encodings

2007-06-21 Thread Andrew Dunstan
Joe Conway wrote: I finally was able PL/R to compile and run on Windows recently. This has lead to people using a Windows based client (typically PgAdmin III) to create PL/R functions. Immediately I started to receive reports of failures that turned out to be due to the carriage return (\r)

Re: [HACKERS] EOL characters and multibyte encodings

2007-06-21 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > I finally was able PL/R to compile and run on Windows recently. This has > lead to people using a Windows based client (typically PgAdmin III) to > create PL/R functions. Immediately I started to receive reports of > failures that turned out to be due to

[HACKERS] EOL characters and multibyte encodings

2007-06-21 Thread Joe Conway
I finally was able PL/R to compile and run on Windows recently. This has lead to people using a Windows based client (typically PgAdmin III) to create PL/R functions. Immediately I started to receive reports of failures that turned out to be due to the carriage return (\r) used in standard Win3

[HACKERS] Worries about delayed-commit semantics

2007-06-21 Thread Tom Lane
I've been reflecting a bit about whether the notion of deferred fsync for transaction commits is really safe. The proposed patch tries to ensure that no consequences of a committed transaction can reach disk before the commit WAL record is fsync'd, but ISTM there are potential holes in what it's d

Re: [HACKERS] tsearch in core patch

2007-06-21 Thread Tom Lane
Hannu Krosing <[EMAIL PROTECTED]> writes: > Ühel kenal päeval, N, 2007-06-21 kell 21:44, kirjutas Teodor Sigaev: >> 6) use encoding names instead of locale's names in configuration >> Ugh. I missed that knowledge of encoding doesn't allow to determine exact >> language > most languages can be w

Re: [HACKERS] tsearch in core patch

2007-06-21 Thread Hannu Krosing
Ühel kenal päeval, N, 2007-06-21 kell 21:44, kirjutas Teodor Sigaev: > http://www.sigaev.ru/misc/tsearch_core-0.52.gz > > Plan was: > > 1) rename FULLTEXT to TEXT SEARCH in SQL command > done > > 2) rework Snowball stemmer's as Tom suggested > done > > 3) ALTER FULLTEXT CONFIGURATION cfgname AD

Re: What does Page Layout version mean? (Was: Re: [HACKERS] Reducing NUMERIC size for 8.3)

2007-06-21 Thread Tom Lane
Heikki Linnakangas <[EMAIL PROTECTED]> writes: > * Page format changes that grow data size are problematic, because there > can be pages that can't be expanded to the new format because there's > not enough space. However, it would be possible to write a pre-upgrade > program to look for the pro

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Darcy Buskermolen
On Thursday 21 June 2007 08:34, Andrew Sullivan wrote: > On Thu, Jun 21, 2007 at 03:24:51PM +0200, Michael Paesold wrote: > > There are valid reasons against 5m as mega-bytes, because here m does > > not refer to a unit, it refers to a quantifier (if that is a reasonable > > English word) of a unit

[HACKERS] tsearch in core patch

2007-06-21 Thread Teodor Sigaev
http://www.sigaev.ru/misc/tsearch_core-0.52.gz Plan was: 1) rename FULLTEXT to TEXT SEARCH in SQL command done 2) rework Snowball stemmer's as Tom suggested done 3) ALTER FULLTEXT CONFIGURATION cfgname ADD/ALTER/DROP MAPPING done 4) remove support of default configuration per scheme. Default

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Andrew Sullivan
On Thu, Jun 21, 2007 at 11:55:56AM -0400, Tom Lane wrote: > where the HINT gets appended if there's something after the integer but > it doesn't look like any of the allowed units. Objections? Sounds like a good idea to me. A -- Andrew Sullivan | [EMAIL PROTECTED] The very definition of "news

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Tom Lane
Andrew Sullivan <[EMAIL PROTECTED]> writes: > Nevertheless, I think that Tom's original suggestion was at least a > HINT, which seems perfectly reasonable to me. That's the only idea in the whole thread that hasn't been objected to, so let's just do that and have done with it. (Even if we were

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Andrew Sullivan
On Thu, Jun 21, 2007 at 03:24:51PM +0200, Michael Paesold wrote: > There are valid reasons against 5m as mega-bytes, because here m does > not refer to a unit, it refers to a quantifier (if that is a reasonable > English word) of a unit. So it should really be 5mb. > > log_rotation_age = 5m > lo

Re: [HACKERS] to partition or not to partition that is the question

2007-06-21 Thread Timasmith
On Jun 19, 2:23 pm, [EMAIL PROTECTED] (Josh Berkus) wrote: > Tim, > > > I have two types of tables, for sake of argument lets call it these: > > > 1) product 10,000,000 rows > > 2) product_activity 1,000,000,000 rows > > pgsql-performance is the correct list for your question. Pl

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Peter Eisentraut
Am Donnerstag, 21. Juni 2007 15:12 schrieb Andrew Dunstan: > You don't seem to have any understanding that the units should be > interpreted in context. You are right. I definitely have an understanding that units must be interpretable without context. And that clearly works for the most part.

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Peter Eisentraut
Am Donnerstag, 21. Juni 2007 00:10 schrieb Gregory Stark: > Afaict nobody has expressed a single downside to accepting other > abbreviations. The two downsides I can see are that it would confuse users (even if it apparently wouldn't confuse *you*), and that there is a chance that the configurat

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Michael Paesold
Marko Kreen wrote: On 6/21/07, Michael Paesold <[EMAIL PROTECTED]> wrote: Marko Kreen wrote: > Considering Postgres will never user either "meter" or "mile" > in settings, I don't consider your argument valid. > > I don't see the value of having units globally unique (literally). > It's enough i

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Marko Kreen
On 6/21/07, Michael Paesold <[EMAIL PROTECTED]> wrote: Marko Kreen wrote: > Considering Postgres will never user either "meter" or "mile" > in settings, I don't consider your argument valid. > > I don't see the value of having units globally unique (literally). > It's enough if they unique in the

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Michael Paesold
Marko Kreen wrote: Considering Postgres will never user either "meter" or "mile" in settings, I don't consider your argument valid. I don't see the value of having units globally unique (literally). It's enough if they unique in the context of postgresql.conf. Thus +1 of having additional short

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Michael Paesold
Peter Eisentraut wrote: Am Donnerstag, 21. Juni 2007 00:38 schrieb Gregory Stark: I think people are worried that an 'm' in one column might mean something different than an 'm' in another column, and perhaps that is confusing. To whom? the person writing it? If everyone around here had gotte

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Marko Kreen
On 6/21/07, Peter Eisentraut <[EMAIL PROTECTED]> wrote: Am Donnerstag, 21. Juni 2007 00:38 schrieb Gregory Stark: > > I think people are worried that an 'm' in one column might mean something > > different than an 'm' in another column, and perhaps that is confusing. > > To whom? the person writi

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Andrew Dunstan
Peter Eisentraut wrote: If everyone around here had gotten their way we'd already be in a situation were you could write log_rotation_age = 5m log_rotation_size = 5m And someone trained in the metric system would think, "What, five meters?". So it rotates when age and size are the same o

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Dave Page
Gregory Stark wrote: "Dave Page" <[EMAIL PROTECTED]> writes: Peter Eisentraut wrote: Btw.: I'm currently at DebConf in Edinburgh. On Scottish motorway signage, "5m" means "five miles". Even the Americans do that better. Yeah, but you know *exactly* what it means :-p Well the good news is

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Gregory Stark
"Dave Page" <[EMAIL PROTECTED]> writes: > Peter Eisentraut wrote: > >> Btw.: I'm currently at DebConf in Edinburgh. On Scottish motorway signage, >> "5m" means "five miles". Even the Americans do that better. > > Yeah, but you know *exactly* what it means :-p Well the good news is that as long

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Dave Page
Peter Eisentraut wrote: Btw.: I'm currently at DebConf in Edinburgh. On Scottish motorway signage, "5m" means "five miles". Even the Americans do that better. Yeah, but you know *exactly* what it means :-p Regards, Dave ---(end of broadcast)

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Gregory Stark
"Peter Eisentraut" <[EMAIL PROTECTED]> writes: > Am Donnerstag, 21. Juni 2007 00:38 schrieb Gregory Stark: >> > I think people are worried that an 'm' in one column might mean something >> > different than an 'm' in another column, and perhaps that is confusing. >> >> To whom? the person writing i

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Brian Hurt
Peter Eisentraut wrote: Am Donnerstag, 21. Juni 2007 00:38 schrieb Gregory Stark: I think people are worried that an 'm' in one column might mean something different than an 'm' in another column, and perhaps that is confusing. To whom? the person writing it? If everyone aroun

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Peter Eisentraut
Am Donnerstag, 21. Juni 2007 00:38 schrieb Gregory Stark: > > I think people are worried that an 'm' in one column might mean something > > different than an 'm' in another column, and perhaps that is confusing. > > To whom? the person writing it? If everyone around here had gotten their way we'd

Re: What does Page Layout version mean? (Was: Re: [HACKERS] Reducing NUMERIC size for 8.3)

2007-06-21 Thread Heikki Linnakangas
Since we're discussing upgrades, let me summarize the discussions we had over dinner in Ottawa for the benefit of all: * pg_migrator is a sound approach to handling catalog changes. * Handling any page format change that doesn't grow the space taken by data is straightforward. Note that all 8.

Re: What does Page Layout version mean? (Was: Re: [HACKERS] Reducing NUMERIC size for 8.3)

2007-06-21 Thread Zdenek Kotala
Andrew Sullivan wrote: On Wed, Jun 20, 2007 at 12:34:21PM -0400, Robert Treat wrote: FWIW pg_migrator is a pretty good swing at an in-place upgrade tool for 8.1->8.2. Unfortunately until the PGDG decides that in-place upgrade is a constraint their willing to place on development, I see them a

Re: [HACKERS] Updated tsearch documentation

2007-06-21 Thread Oleg Bartunov
On Wed, 20 Jun 2007, Bruce Momjian wrote: We need to decide if we need oids as user-visible argument. I don't see any value, probably Teodor think other way. This is a good time to clean up the API because there are going to be user-visible changes anyway. Bruce, just remove oid argument spe

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Gregory Stark
"Heikki Linnakangas" <[EMAIL PROTECTED]> writes: > My 2c on this: > > The way I was taught in school is that "min" is for minute and "mon" is for > month. Specifically, not "m". Sure, but nobody's saying you shouldn't be able to use "min". If you think using "m" is wrong then by all means institu

Re: [HACKERS] Updated tsearch documentation

2007-06-21 Thread Oleg Bartunov
On Wed, 20 Jun 2007, Bruce Momjian wrote: Oleg Bartunov wrote: On Wed, 20 Jun 2007, Bruce Momjian wrote: Comments to editorial work of Bruce Momjian. fulltext-intro.sgml: it is useful to have a predefined list of lexemes. Bruce, here should be list of types of lexemes ! Agreed. Are the l

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Heikki Linnakangas
Dave Page wrote: Michael Paesold wrote: It's not about a certain standard. There are so many different ways in the world to write time units, so in a certain context a standard is really useful to constrain the format/syntax, but... This all was about usability of a configuration file, wasn't

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Dave Page
Michael Paesold wrote: It's not about a certain standard. There are so many different ways in the world to write time units, so in a certain context a standard is really useful to constrain the format/syntax, but... This all was about usability of a configuration file, wasn't it? Now, Peter,

Re: [HACKERS] GUC time unit spelling a bit inconsistent

2007-06-21 Thread Michael Paesold
Bruce Momjian wrote: Simon Riggs wrote: Please lets be real about this and allow the abbreviations suggested. Agreed. Your efforts to introduce units is excellent and much appreciated by all; please don't make them harder to use than the plain numbers were. Agreed. Agreed. I don't see t