Re: [HACKERS] plperl needs upgrade for Fedora 10

2008-11-04 Thread Andrew Dunstan
Andrew Dunstan wrote: 2. You have not provided the info I asked for, namely the configure params and the build log. e.g.: My apologies. I missed the attachments with this info. cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Zdenek Kotala
Robert Haas napsal(a): Really, what I'd ideally like to see here is a system where the V3 code is in essence error-recovery code. Everything should be V4-only unless you detect a V3 page, and then you error out (if in-place upgrade is not enabled) or jump to the appropriate V3-aware code (if

Re: [HACKERS] Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle

2008-11-04 Thread Robert Haas
I think we need to distinguish between patches that are clearly not going in, and patches that are not going in in their present form but might be able to be reworked. My suggestion would be that only the first category be moved to the Returned with feedback section, and the others just have

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Robert Haas
OK. It was original idea to make Convert on read which has several problems with no easy solution. One is that new data does not fit on the page and second big problem is how to convert TOAST table data. Another problem which is general is how to convert indexes... Convert on read has

Re: [HACKERS] Spurious Kerberos error messages

2008-11-04 Thread Peter Eisentraut
Tom Lane wrote: Peter Eisentraut [EMAIL PROTECTED] writes: I get the following display now when I connect to a non-running server, all default settings: psql: pg_krb5_init: krb5_cc_get_principal: No credentials cache found could not connect to server: No such file or directory Is

[HACKERS] SQL5 budget

2008-11-04 Thread Dmitry Turin
Hi, all. I had preliminary conversation with my employer about implementation of SQL5 [1] without Driven Scene [2]. He needs concrete budget. So i'm asking you to estimate and say, how much will it cost. In particular, speach goes about implemention of slides # 17-42, 47-56, 63, 102-109,

[HACKERS] libpq and sslmode=require

2008-11-04 Thread Bruce Momjian
In testing an SSL patch, I found that if I use 'sslmode=require' in the libpq connection string, it does not use SSL over a unix-domain socket. libpq should either use SSL (which I don't think it can), or error out, or we should at least document this behavior. -- Bruce Momjian [EMAIL

Re: [HACKERS] SQL5 budget

2008-11-04 Thread Dmitry Turin
I had preliminary conversation with my employer about implementation of SQL5 [1] without Driven Scene [2]. He needs concrete budget. So i'm asking you to estimate and say, how much will it cost. In particular, speach goes about implemention of slides # 17-42, 47-56, 63, 102-109, 114-143,

Re: [HACKERS] patch: array_ndims

2008-11-04 Thread Peter Eisentraut
Robert Haas wrote: After reading Josh Berkus's email suggesting that the intagg module be dropped, I was wondering what would be required to create a array enumerator (variously called unnest, unroll, array_enum, and, as contemplated by the TODO list, array_to_set). Pavel Stehule's

Re: [HACKERS] Enable pl/python to return records based on multiple OUT params

2008-11-04 Thread Tom Lane
Hannu Krosing [EMAIL PROTECTED] writes: ... even the code currently in CVS crashes the backend for this py=# create or replace function add_any(in i1 anyelement, in i2 anyelement, out t text) language plpythonu as $$ return i1 + i2 $$; CREATE FUNCTION py=# select * from add_any(1,2);

Re: [HACKERS] Enable pl/python to return records based on multiple OUT params

2008-11-04 Thread Hannu Krosing
On Tue, 2008-11-04 at 09:57 -0500, Tom Lane wrote: Hannu Krosing [EMAIL PROTECTED] writes: ... even the code currently in CVS crashes the backend for this py=# create or replace function add_any(in i1 anyelement, in i2 anyelement, out t text) language plpythonu as $$ return i1 + i2

Re: [HACKERS] libpq and sslmode=require

2008-11-04 Thread Peter Eisentraut
Bruce Momjian wrote: In testing an SSL patch, I found that if I use 'sslmode=require' in the libpq connection string, it does not use SSL over a unix-domain socket. libpq should either use SSL (which I don't think it can), or error out, or we should at least document this behavior. We

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Zdenek Kotala
Robert Haas napsal(a): OK. It was original idea to make Convert on read which has several problems with no easy solution. One is that new data does not fit on the page and second big problem is how to convert TOAST table data. Another problem which is general is how to convert indexes...

Re: [HACKERS] libpq and sslmode=require

2008-11-04 Thread Tom Lane
Bruce Momjian [EMAIL PROTECTED] writes: In testing an SSL patch, I found that if I use 'sslmode=require' in the libpq connection string, it does not use SSL over a unix-domain socket. It's always done that. regards, tom lane -- Sent via pgsql-hackers mailing list

[HACKERS] some strange bugs related to upgrade from 8.1 to 8.3

2008-11-04 Thread Pavel Stehule
Hello I started upgrade our databases from 8.1 to 8.3. I found two strange bugs related to tsearch2. a) server crash after creating tsearch2 function (I use tsearch2 contrib from 8.3) (gdb) bt #0 0x003838033075 in raise () from /lib64/libc.so.6 #1 0x003838034be3 in abort () from

Re: [HACKERS] Transactions and temp tables

2008-11-04 Thread Heikki Linnakangas
Emmanuel Cecchet wrote: What's the purpose of checking that a table is empty on prepare? I think I'd feel more comfortable with the approach of only accepting PREPARE TRANSACTIOn if the accessed temp tables have been created and destroyed in the same transaction, to avoid possibly surprising

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Robert Haas
I see. But Vacuum and other internals function access heap pages directly without ExecStoreTuple. Right. I don't think there's any getting around the fact that any function which accesses heap pages directly is going to need modification. The key is to make those modifications as non-invasive

Re: [HACKERS] Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle

2008-11-04 Thread Ron Mayer
Brendan Jurd wrote: ...Sep 18, 2008... Ron Mayer [EMAIL PROTECTED] wrote: The attached patch (1) adds a new GUC called IntervalStyle that decouples interval output from the DateStyle GUC, and (2) adds a new interval style that will match the SQL standards for interval

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Heikki Linnakangas
Zdenek Kotala wrote: Robert Haas napsal(a): Really, what I'd ideally like to see here is a system where the V3 code is in essence error-recovery code. Everything should be V4-only unless you detect a V3 page, and then you error out (if in-place upgrade is not enabled) or jump to the

Re: [HACKERS] Spurious Kerberos error messages

2008-11-04 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: Nothing has changed about when it fails, only the extra krb error message before the usual error messages (could not connect, server is starting up) are new. This probably has something to do with Magnus's work on concatenating rather than hiding

Re: [HACKERS] Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle

2008-11-04 Thread Ron Mayer
Ah. And one final question regarding functionality. It seems to me that the last remaining place where we input a SQL-2008 standard literal and do something different from what the standard suggests is with the string: '-1 2:03:04' The standard seems to say that the - affects both the days

Re: [HACKERS] Synchronous replication patch v1

2008-11-04 Thread Heikki Linnakangas
Fujii Masao wrote: On Fri, Oct 31, 2008 at 11:12 PM, Heikki Linnakangas [EMAIL PROTECTED] wrote: AFAICS, there's no security, at all. Anyone that can log in, can become a WAL sender, and receive all WAL for the whole cluster. One simple solution is to define the database only for replication.

Re: [HACKERS] Patch for SQL-Standard Interval output and decouplingDateStyle from IntervalStyle

2008-11-04 Thread Kevin Grittner
Ron Mayer [EMAIL PROTECTED] wrote: It seems to me that the last remaining place where we input a SQL-2008 standard literal and do something different from what the standard suggests is with the string: '-1 2:03:04' The standard seems to say that the - affects both the days and

Re: [HACKERS] Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle

2008-11-04 Thread Tom Lane
Ron Mayer [EMAIL PROTECTED] writes: Ah. And one final question regarding functionality. It seems to me that the last remaining place where we input a SQL-2008 standard literal and do something different from what the standard suggests is with the string: '-1 2:03:04' The standard seems

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Robert Haas
We've talked about this many times before, so I'm sure you know what my opinion is. Let me phrase it one more time: 1. You *will* need a function to convert a page from old format to new format. We do want to get rid of the old format pages eventually, whether it's during VACUUM, whenever a

Re: [HACKERS] Bitmap Indexes patch

2008-11-04 Thread Gregory Stark
Simon Riggs [EMAIL PROTECTED] writes: On Mon, 2008-11-03 at 23:28 +, Simon Riggs wrote: On Mon, 2008-11-03 at 17:37 -0500, Greg Stark wrote: There are a lot of comments in the code which imply that vacuuming is not implemented but in fact from what I can see it is -- sort of. It

Re: Bitmap Indexes patch (was Re: [HACKERS] Bitmap Indexes: request for feedback)

2008-11-04 Thread Gianni Ciolli
On Mon, Nov 03, 2008 at 04:53:28PM -0700, Vladimir Sitnikov wrote: I wish to focus on the performance aspect of the patch, however, it turned out there are major issues with functionality: the index stores wrong tids inside :( I really would love to fix that issue and have a chance to validate

Re: [HACKERS] [PATCH] Extending pg_class info + more flexible TOAST chunk size

2008-11-04 Thread Zdenek Kotala
Robert Haas napsal(a): Zdenek, It seems like there is general agreement that this patch needs some changes before being considered for application. Is that correct? http://archives.postgresql.org/pgsql-hackers/2008-11/msg00049.php Are you planning to send a new version for this CommitFest,

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Robert Haas
That's sane *if* you can guarantee that only negligible overhead is added for accessing data that is in the up-to-date format. I don't think that will be the case if we start putting version checks into every tuple access macro. Yes, the point is that you'll read the page as V3 or V4,

Re: [HACKERS] some strange bugs related to upgrade from 8.1 to 8.3

2008-11-04 Thread Tom Lane
Pavel Stehule [EMAIL PROTECTED] writes: I started upgrade our databases from 8.1 to 8.3. I found two strange bugs related to tsearch2. Did you follow the advice here: http://www.postgresql.org/docs/8.3/static/textsearch-migration.html a) server crash after creating tsearch2 function (I use

Re: [HACKERS] pre-MED

2008-11-04 Thread Tom Lane
Alex Hunsaker [EMAIL PROTECTED] writes: On Thu, Oct 30, 2008 at 05:16, Tom Lane [EMAIL PROTECTED] wrote: Surely they all have a way to call a SQL function that returns text. Sure but when you call that function you get *that* functions qualifier. And unless there already is a way to grab the

Re: [HACKERS] Patch for ALTER DATABASE WITH TABLESPACE

2008-11-04 Thread Bernd Helmle
--On Samstag, Oktober 25, 2008 23:50:47 +0200 Guillaume Lelarge [EMAIL PROTECTED] wrote: Hi, Here is my patch to add the ALTER DATABASE WITH TABLESPACE statement. It is part of the TODO list. It intends to allow the move of all relations of a database in its new default tablespace. Comments

Re: [HACKERS] Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle

2008-11-04 Thread Ron Mayer
Tom Lane wrote: Ron Mayer [EMAIL PROTECTED] writes: Ah. And one final question regarding functionality. It seems to me that the last remaining place where we input a SQL-2008 standard literal and do something different from what the standard suggests is with the string: '-1 2:03:04' The

Re: [HACKERS] gram.y = preproc.y

2008-11-04 Thread Tom Lane
Michael Meskes [EMAIL PROTECTED] writes: On Mon, Nov 03, 2008 at 07:10:01PM -0500, Tom Lane wrote: (You might need to compress the files if the message comes to more than 100-some KB. Also, given that preproc.y can be generated so easily, it could just be left out.) I did this this time.

Re: [HACKERS] Patch for ALTER DATABASE WITH TABLESPACE

2008-11-04 Thread Guillaume Lelarge
Bernd Helmle a écrit : --On Samstag, Oktober 25, 2008 23:50:47 +0200 Guillaume Lelarge [EMAIL PROTECTED] wrote: Here is my patch to add the ALTER DATABASE WITH TABLESPACE statement. It is part of the TODO list. It intends to allow the move of all relations of a database in its new default

Re: [HACKERS] Enable pl/python to return records based on multiple OUT params

2008-11-04 Thread David Blewett
On Sat, Nov 1, 2008 at 7:52 AM, Hannu Krosing [EMAIL PROTECTED] wrote: On Sat, 2008-11-01 at 06:13 +0200, Hannu Krosing wrote: attached is a patch which enables plpython to recognize function with multiple OUT params as returning a record Overrides previous patch. Fixed some bugs, added

Re: [HACKERS] [PATCH] PageGetTempPage cleanup

2008-11-04 Thread Zdenek Kotala
Tom Lane napsal(a): Zdenek Kotala [EMAIL PROTECTED] writes: I attach patch which cleans up code around PageGetTempPage. These changes were discussed here: http://archives.postgresql.org/pgsql-hackers/2008-08/msg00102.php Applied with a minor change: instead of inventing Page

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Tom Lane
Robert Haas [EMAIL PROTECTED] writes: Well, I just proposed an approach that doesn't work this way, so I guess I'll have to put myself in the disagree category, or anyway yet to be convinced. As long as you can move individual tuples onto new pages, you can eventually empty V3 pages and

Re: [HACKERS] plperl needs upgrade for Fedora 10

2008-11-04 Thread Pavel Stehule
2008/11/4 Andrew Dunstan [EMAIL PROTECTED]: Andrew Dunstan wrote: 2. You have not provided the info I asked for, namely the configure params and the build log. e.g.: My apologies. I missed the attachments with this info. no problem Pavel cheers andrew -- Sent via

Re: [HACKERS] libpq and sslmode=require

2008-11-04 Thread Bruce Momjian
Peter Eisentraut wrote: Bruce Momjian wrote: In testing an SSL patch, I found that if I use 'sslmode=require' in the libpq connection string, it does not use SSL over a unix-domain socket. libpq should either use SSL (which I don't think it can), or error out, or we should at least

Re: [HACKERS] Signal handling patch (v2) for Synch Rep

2008-11-04 Thread Simon Riggs
On Tue, 2008-11-04 at 21:04 +0900, Fujii Masao wrote: To be reviewed easily, I'm splitting Synch Rep patch into some pieces. Great idea. I'll be doing that also. -- Simon Riggs www.2ndQuadrant.com PostgreSQL Training, Services and Support -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Patch for ALTER DATABASE WITH TABLESPACE

2008-11-04 Thread Tom Lane
Guillaume Lelarge [EMAIL PROTECTED] writes: Bernd Helmle a écrit : However, i'm not satisfied with the syntax, which is currently ALTER DATABASE name TABLESPACE foo. We use all over the place SET TABLESPACE (e.g. for tables and indexes) and SET SCHEMA for namespaces even, so this looks

Re: [HACKERS] Probable problem with pg_standby

2008-11-04 Thread Detlef Ulherr
Fujii Masao wrote: On Tue, Nov 4, 2008 at 8:09 PM, Detlef Ulherr [EMAIL PROTECTED] wrote: All I did was forcing the primary in a recovery to generate a new timeline. The installed version was 8.3.4, but the problem is the same with earlier versions as well. It occurred in 8.2 also. this

[HACKERS] [PATCH] Cleanup of PLpgSQL_recfield

2008-11-04 Thread Jonah H. Harris
While looking to add some functionality to PL/pgSQL, I found that the rfno member of the PLpgSQL_recfield structure is unused. This patch is just a cleanup and doesn't seem along the same lines as the patches in CommitFest... should I add it to the wiki anyway? -- Jonah H. Harris, Senior DBA

Re: [HACKERS] Patch for ALTER DATABASE WITH TABLESPACE

2008-11-04 Thread Bernd Helmle
--On Dienstag, November 04, 2008 14:56:44 -0500 Tom Lane [EMAIL PROTECTED] wrote: [...] Not sure what Bernd tried exactly, but it can be done. Cool, i didn't recognize the obvious possibility to add a separate rule for this. I've just extended the alterdb_opt_item with SET TABLESPACE,

Re: [HACKERS] Patch for ALTER DATABASE WITH TABLESPACE

2008-11-04 Thread Guillaume Lelarge
Bernd Helmle a écrit : --On Dienstag, November 04, 2008 14:56:44 -0500 Tom Lane [EMAIL PROTECTED] wrote: [...] Not sure what Bernd tried exactly, but it can be done. Cool, i didn't recognize the obvious possibility to add a separate rule for this. I've just extended the

Re: [HACKERS] [PATCHES] updated hash functions for postgresql v1

2008-11-04 Thread Oleg Bartunov
Just interested if you repeat your tests not with cracklib-dict, but using 8-bit words. From our experience we found many hash functions are optimized for 7-bit words and produce too many collisions for 8-bit words. That's why we use crc32. Oleg On Tue, 4 Nov 2008, Kenneth Marshall wrote:

Re: [HACKERS] Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle

2008-11-04 Thread Ron Mayer
Brendan Jurd wrote: ...Sep 18, 2008...Ron Mayer [EMAIL PROTECTED] wrote: (1) ...GUC called IntervalStyle... (2) ...interval style that will match the SQL standards... ...an initial review... When I ran the regression tests, I got one failure in the new interval Fixed, and I did a

Re: [HACKERS] BufferAccessStrategy for bulk insert

2008-11-04 Thread Tom Lane
Robert Haas [EMAIL PROTECTED] writes: Patch resnapped to HEAD, with straightforward adjustments to compensate for Heikki's changes to the ReadBuffer interface. See attached. I looked this over a bit. A couple of suggestions: 1. You could probably simplify life a bit by treating the

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Robert Haas
Well, I just proposed an approach that doesn't work this way, so I guess I'll have to put myself in the disagree category, or anyway yet to be convinced. As long as you can move individual tuples onto new pages, you can eventually empty V3 pages and reinitialize them as new, empty V4 pages.

Re: [HACKERS] [PATCH] Cleanup of PLpgSQL_recfield

2008-11-04 Thread Tom Lane
Jonah H. Harris [EMAIL PROTECTED] writes: While looking to add some functionality to PL/pgSQL, I found that the rfno member of the PLpgSQL_recfield structure is unused. This patch is just a cleanup No, that'd be wrong. Note here: /* * PLpgSQL_datum is the common supertype for PLpgSQL_expr,

Re: [HACKERS] [PATCH] Cleanup of PLpgSQL_recfield

2008-11-04 Thread Alvaro Herrera
Jonah H. Harris escribió: While looking to add some functionality to PL/pgSQL, I found that the rfno member of the PLpgSQL_recfield structure is unused. This patch is just a cleanup and doesn't seem along the same lines as the patches in CommitFest... should I add it to the wiki anyway? Nah

Re: [HACKERS] [PATCH] Cleanup of PLpgSQL_recfield

2008-11-04 Thread Alvaro Herrera
Tom Lane escribió: Jonah H. Harris [EMAIL PROTECTED] writes: While looking to add some functionality to PL/pgSQL, I found that the rfno member of the PLpgSQL_recfield structure is unused. This patch is just a cleanup No, that'd be wrong. Oops. Reverting. -- Alvaro Herrera

Re: [HACKERS] Patch for ALTER DATABASE WITH TABLESPACE

2008-11-04 Thread Tom Lane
Guillaume Lelarge [EMAIL PROTECTED] writes: Should I provide a complete new patch with Bernd's and Tom's changes? Please --- it's better if you integrate it since you know the patch already. regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] plperl needs upgrade for Fedora 10

2008-11-04 Thread Andrew Dunstan
Pavel Stehule wrote: postgres=# select version(); version -- PostgreSQL 8.3.4 on x86_64-unknown-linux-gnu, compiled by GCC gcc (GCC) 4.3.2

Re: [HACKERS] BufferAccessStrategy for bulk insert

2008-11-04 Thread Robert Haas
2. The logic changes in RelationGetBufferForTuple seem bizarre and overcomplicated. ISTM that the buffer saved by the bistate ought to be about equivalent to relation-rd_targblock, ie, it's your first trial location and also a place to save the located buffer on the way out. I'd suggest

Re: [HACKERS] Probable problem with pg_standby

2008-11-04 Thread Fujii Masao
On Tue, Nov 4, 2008 at 8:09 PM, Detlef Ulherr [EMAIL PROTECTED] wrote: All I did was forcing the primary in a recovery to generate a new timeline. The installed version was 8.3.4, but the problem is the same with earlier versions as well. It occurred in 8.2 also. this problem is reproducible

Re: [HACKERS] Spurious Kerberos error messages

2008-11-04 Thread Tom Lane
Peter Eisentraut [EMAIL PROTECTED] writes: I get the following display now when I connect to a non-running server, all default settings: psql: pg_krb5_init: krb5_cc_get_principal: No credentials cache found could not connect to server: No such file or directory Is the server

Re: [HACKERS] [PATCHES] updated hash functions for postgresql v1

2008-11-04 Thread Kenneth Marshall
On Tue, Nov 04, 2008 at 11:32:47PM +0300, Oleg Bartunov wrote: Just interested if you repeat your tests not with cracklib-dict, but using 8-bit words. From our experience we found many hash functions are optimized for 7-bit words and produce too many collisions for 8-bit words. That's why we

Re: ARRAY vars (was [HACKERS] Enable pl/python to return records based on multiple OUT params)

2008-11-04 Thread Hannu Krosing
On Tue, 2008-11-04 at 14:05 -0500, David Blewett wrote: On Sat, Nov 1, 2008 at 7:52 AM, Hannu Krosing [EMAIL PROTECTED] wrote: On Sat, 2008-11-01 at 06:13 +0200, Hannu Krosing wrote: attached is a patch which enables plpython to recognize function with multiple OUT params as returning a

Re: [HACKERS] BufferAccessStrategy for bulk insert

2008-11-04 Thread Tom Lane
Robert Haas [EMAIL PROTECTED] writes: 2. The logic changes in RelationGetBufferForTuple seem bizarre and overcomplicated. ISTM that the buffer saved by the bistate ought to be about equivalent to relation-rd_targblock, ie, it's your first trial location and also a place to save the located

Re: [HACKERS] Synchronous replication patch v1

2008-11-04 Thread Fujii Masao
Hi, thank you for taking time to review the patch. On Fri, Oct 31, 2008 at 11:12 PM, Heikki Linnakangas [EMAIL PROTECTED] wrote: Fujii Masao wrote: Attached is a patch for a synchronous log-shipping replication which was discussed just a month ago. I would like you to review this patch in

Re: [HACKERS] [PATCHES] updated hash functions for postgresql v1

2008-11-04 Thread Kenneth Marshall
Oleg, Here is a little more information on the use of CRC32 as a hash function, with some warning caveats: http://home.comcast.net/~bretm/hash/8.html Regards, Ken On Tue, Nov 04, 2008 at 03:15:44PM -0600, Kenneth Marshall wrote: On Tue, Nov 04, 2008 at 11:32:47PM +0300, Oleg Bartunov wrote:

Re: array_agg (was Re: [HACKERS] The Axe list)

2008-11-04 Thread Peter Eisentraut
Ian Caulfield wrote: 2008/10/15 Ian Caulfield [EMAIL PROTECTED]: I started to look at implementing array_agg by making the existing intagg stuff more generic ... and here's what I've come up with. Going through the commit fest listings, I think we can safely omit this patch and work out an

Re: [HACKERS] libpq and sslmode=require

2008-11-04 Thread Magnus Hagander
Peter Eisentraut wrote: Bruce Momjian wrote: In testing an SSL patch, I found that if I use 'sslmode=require' in the libpq connection string, it does not use SSL over a unix-domain socket. libpq should either use SSL (which I don't think it can), or error out, or we should at least document

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Gregory Stark
Robert Haas [EMAIL PROTECTED] writes: We've talked about this many times before, so I'm sure you know what my opinion is. Let me phrase it one more time: 1. You *will* need a function to convert a page from old format to new format. We do want to get rid of the old format pages eventually,

[HACKERS] Re: Hot standby v5 patch - Databases created post backup remain inaccessible + replica SIGSEGV when coming out of standby

2008-11-04 Thread Simon Riggs
On Tue, 2008-11-04 at 18:33 +1300, Mark Kirkwood wrote: postgres=# \l List of databases Name| Owner | Encoding | Collation | Ctype | Access Privileges

[HACKERS] Signal handling patch (v2) for Synch Rep

2008-11-04 Thread Fujii Masao
Hi, To be reviewed easily, I'm splitting Synch Rep patch into some pieces. Attached is a patch of signal handling changes for Synch Rep. http://archives.postgresql.org/pgsql-hackers/2008-09/msg00950.php Though I've posted the WIP patch previously, this is a finished one. Please feel free to

[HACKERS] Spurious Kerberos error messages

2008-11-04 Thread Peter Eisentraut
I get the following display now when I connect to a non-running server, all default settings: psql: pg_krb5_init: krb5_cc_get_principal: No credentials cache found could not connect to server: No such file or directory Is the server running locally and accepting connections on

Re: [HACKERS] Windowing Function Patch Review - Performance Comparison.

2008-11-04 Thread David Rowley
Hitoshi Harada wrote: Test 3 and 5 did not seem to make use of an index to get a sorted list of results. I disabled enable_seqscan but the planner still failed to choose index_scan. Is there any reason for this? Perhaps I'm missing something. Hitoshi, can you take a look at this?

Re: [HACKERS] Synchronous replication patch v1

2008-11-04 Thread Fujii Masao
On Fri, Oct 31, 2008 at 10:15 PM, Heikki Linnakangas [EMAIL PROTECTED] wrote: Fujii Masao wrote: And, there are some problems in this patch; * This patch is somewhat big, though it should be subdivided for review. * Source code comments and documents are insufficient. Is it against the

[HACKERS] Probable problem with pg_standby

2008-11-04 Thread Detlef Ulherr
Hi, First to introduce myself, I am working in Sun Cluster engineering and I am responsible for the integration (the agent) between PostgreSQL and Sun Cluster. The PostgreSQL agent provides a feature which uses WAL file shipping and pg_standby as a replacement for shared storage. Let's talk

Re: [HACKERS] plperl needs upgrade for Fedora 10

2008-11-04 Thread Andrew Dunstan
Pavel Stehule wrote: 2008/11/4 Andrew Dunstan [EMAIL PROTECTED]: Andrew Dunstan wrote: 2. You have not provided the info I asked for, namely the configure params and the build log. e.g.: My apologies. I missed the attachments with this info. no problem Please

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Gregory Stark
Robert Haas [EMAIL PROTECTED] writes: Well, I just proposed an approach that doesn't work this way, so I guess I'll have to put myself in the disagree category, or anyway yet to be convinced. As long as you can move individual tuples onto new pages, you can eventually empty V3 pages and

Re: [HACKERS] [PATCHES] updated hash functions for postgresql v1

2008-11-04 Thread Kenneth Marshall
Sorry about the delay for this update to the new hash index implementation. I was trying to get the WAL logging in place and forgot to post the actual patch. The WAL for hash indexes will need to wait for 8.5, but I did want to add back in the piece of the Bob Jenkins 2006 hash function that was

Re: [HACKERS] libpq and sslmode=require

2008-11-04 Thread Bruce Momjian
Bruce Momjian wrote: would impose a noticeable connection initiation overhead on everyone's Unix-domain socket uses. You could make it use SSL in require mode, but it seems weird that prefer mode would end up doing something different than require mode. Maybe Magnus has an opinion

Re: [HACKERS] Updates of SE-PostgreSQL 8.4devel patches (r1168)

2008-11-04 Thread Bruce Momjian
KaiGai Kohei wrote: OK. I am wondering if we _want_ two ways to set column permisions, especially since I think there will be only one way to set row-level permissions. I think we should not see the feature from only the viewpoint of granularity in access controls. The both of new

Re: [HACKERS] [PATCH] Cleanup of PLpgSQL_recfield

2008-11-04 Thread Jonah H. Harris
On Tue, Nov 4, 2008 at 3:57 PM, Tom Lane [EMAIL PROTECTED] wrote: I am not real sure why the code is inconsistent about spelling the second field's name differently in some of the structs, but it seems like a bad idea --- as you've demonstrated, it invites confusion. What would probably be

Re: [HACKERS] Transactions and temp tables

2008-11-04 Thread Emmanuel Cecchet
Heikki Linnakangas wrote: Yes, I was trying to allow also ON COMMIT DROP and ON COMMIT DELETE ROW. An empty temp table at PREPARE time would be similar to an ON COMMIT DELETE ROW table. I think you'll want to check explicitly that the table is defined with ON COMMIT DELETE ROWS, instead of

Re: [HACKERS] [PATCH] Cleanup of PLpgSQL_recfield

2008-11-04 Thread Tom Lane
Jonah H. Harris [EMAIL PROTECTED] writes: On Tue, Nov 4, 2008 at 3:57 PM, Tom Lane [EMAIL PROTECTED] wrote: I am not real sure why the code is inconsistent about spelling the second field's name differently in some of the structs, but it seems like a bad idea --- as you've demonstrated, it

Re: [HACKERS] Patch for ALTER DATABASE WITH TABLESPACE

2008-11-04 Thread Guillaume Lelarge
Tom Lane a écrit : Guillaume Lelarge [EMAIL PROTECTED] writes: Should I provide a complete new patch with Bernd's and Tom's changes? Please --- it's better if you integrate it since you know the patch already. I worked with Bernd's patch and replace the WITH syntax with the SET one. It

[HACKERS] Windowing Function Patch Review - Standard Conformance

2008-11-04 Thread David Rowley
I wrote: All, This is my first patch review for PostgreSQL. I did submit a patch last commit fest (Boyer-Moore) so I feel I should review one this commit fest. I'm quite new to PostgreSQL so please don't rely on me totally. I'll do my best. Heikki is also reviewing this patch which makes me

Re: [HACKERS] Windowing Function Patch Review - Standard Conformance

2008-11-04 Thread Vladimir Sitnikov
Quoted from SQL:2008 If CUME_DIST is specified, then the relative *rank *of a row R is defined as NP/NR, where NP is defined to be the number of rows preceding or peer with R in the window ordering of the window partition of R and NR is defined to be the number of rows in the window

[HACKERS] Questions about patch Table command

2008-11-04 Thread Unicron
Hi I am reviewer of Patch Table command. I wanted to build code checked out from code repo got via rsyn, but I didn't find relating code in file gram.y. Do i need to add the code to the file?

Re: [HACKERS] Windowing Function Patch Review - Standard Conformance

2008-11-04 Thread Hitoshi Harada
2008/11/5 Vladimir Sitnikov [EMAIL PROTECTED]: Quoted from SQL:2008 If CUME_DIST is specified, then the relative rank of a row R is defined as NP/NR, where NP is defined to be the number of rows preceding or peer with R in the window ordering of the window partition of R and NR is defined

Re: [HACKERS] Windowing Function Patch Review - Standard Conformance

2008-11-04 Thread Vladimir Sitnikov
Even though I understand the definition, your suggestion of COUNT(*) OVER (ORDER BY salary) doesn't make sense. Why does not that make sense? I have not read the spec, however Oracle has a default window specification in case there is only an order by clause. The default window is range

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Robert Haas
Maybe. The difference is that I'm talking about converting tuples, not pages, so What happens when the data doesn't fit on the new page? is a meaningless question. No it's not, because as you pointed out you still need a way for the user to force it to happen sometime. Unless you're going

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Gregory Stark
Robert Haas [EMAIL PROTECTED] writes: Maybe. The difference is that I'm talking about converting tuples, not pages, so What happens when the data doesn't fit on the new page? is a meaningless question. No it's not, because as you pointed out you still need a way for the user to force it to

Re: [HACKERS] Windowing Function Patch Review - Standard Conformance

2008-11-04 Thread Hitoshi Harada
2008/11/5 Vladimir Sitnikov [EMAIL PROTECTED]: Even though I understand the definition, your suggestion of COUNT(*) OVER (ORDER BY salary) doesn't make sense. Why does not that make sense? I have not read the spec, however Oracle has a default window specification in case there is only an

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Robert Haas
No, that's not what I'm suggesting. My thought was that any V3 page would be treated as if it were completely full, with the exception of a completely empty page which can be reinitialized as a V4 page. So you would never add any tuples to a V3 page, but you would need to update xmax, hint

Re: [HACKERS] Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle

2008-11-04 Thread Brendan Jurd
On Wed, Nov 5, 2008 at 7:34 AM, Ron Mayer [EMAIL PROTECTED] wrote: Brendan Jurd wrote: When I ran the regression tests, I got one failure in the new interval Fixed, and I did a bit more testing both with and without HAVE_INT64_TIMESTAMP. Confirmed, all regression tests now pass on my system

Re: [HACKERS] Re: [BUGS] libpq does not manage SSL callbacks properly when other libraries are involved.

2008-11-04 Thread Bruce Momjian
Magnus Hagander wrote: Your analysis of this problem is right on target. When the SSL callbacks were implemented for threaded libpq, there was never any thought on the effect of unloading libpq while the callbacks were still registered. The attached patch unregisters the callback on

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Gregory Stark
Robert Haas [EMAIL PROTECTED] writes: No, that's not what I'm suggesting. My thought was that any V3 page would be treated as if it were completely full, with the exception of a completely empty page which can be reinitialized as a V4 page. So you would never add any tuples to a V3 page,

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Joshua D. Drake
Gregory Stark wrote: Robert Haas [EMAIL PROTECTED] writes: An old page which never goes away. New page formats are introduced for a reason -- to support new features. An old page lying around indefinitely means some pages can't support those new features. Just as an example, DBAs may be

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Gregory Stark
Joshua D. Drake [EMAIL PROTECTED] writes: Gregory Stark wrote: Robert Haas [EMAIL PROTECTED] writes: An old page which never goes away. New page formats are introduced for a reason -- to support new features. An old page lying around indefinitely means some pages can't support those new

Re: [HACKERS] [WIP] In-place upgrade

2008-11-04 Thread Joshua D. Drake
Gregory Stark wrote: Joshua D. Drake [EMAIL PROTECTED] writes: Gregory Stark wrote: Robert Haas [EMAIL PROTECTED] writes: An old page which never goes away. New page formats are introduced for a reason -- to support new features. An old page lying around indefinitely means some pages can't

Re: [HACKERS] Patch for SQL-Standard Interval output and decoupling DateStyle from IntervalStyle

2008-11-04 Thread Ron Mayer
Brendan Jurd wrote: The changes to the documentation all look good. I did notice one final typo that I think was introduced in the latest version. doc/src/sgml/datatype.sgml:2270 has Nonstandardrd instead of Nonstandard. Just checked in a fix to that one; and updated my website at

Re: [HACKERS] Synchronous replication patch v1

2008-11-04 Thread Fujii Masao
On Wed, Nov 5, 2008 at 12:51 AM, Heikki Linnakangas [EMAIL PROTECTED] wrote: Fujii Masao wrote: On Fri, Oct 31, 2008 at 11:12 PM, Heikki Linnakangas [EMAIL PROTECTED] wrote: AFAICS, there's no security, at all. Anyone that can log in, can become a WAL sender, and receive all WAL for the

Re: [HACKERS] Re: Hot standby v5 patch - restarted replica changes to warm standby mode

2008-11-04 Thread Mark Kirkwood
Simon Riggs wrote: On Tue, 2008-11-04 at 18:33 +1300, Mark Kirkwood wrote: While doing some tests yesterday I ran into the situation where the standby database would appear to go back into 'warm' mode after it was restarted. The set of steps to reproduce the behaviour is: 1/ Setup master