Re: [HACKERS] Congrats Alvaro!

2010-01-10 Thread Dimitri Fontaine
Congratulations, good things to all the family! Devrim GÜNDÜZ dev...@gunduz.org writes: Alvaro, one of our hackers and committers and my colleague more than 4 years, had a new baby today. Congrats Alvaro for his second daughter ! -committers, please commit your patches for our new

Re: [HACKERS] mailing list archiver chewing patches

2010-01-10 Thread Dimitri Fontaine
Andrew Dunstan and...@dunslane.net writes: That is assuming that the MUA gives you the option of specifying the attachment MIME type. Many (including mine) do not. It would mean an extra step - I'd have to gzip each patch or something like that. That would be unfortunate,as well as imposing

Re: [HACKERS] Add .gitignore files to CVS?

2010-01-10 Thread Dimitri Fontaine
Hi, Another occasion to show ignorance, I couldn't resist! Tom Lane t...@sss.pgh.pa.us writes: What you're talking about would require a great deal more maintenance effort, and I don't see the point compared to using a VPATH build. I've discovered VPATH builds pretty recently, in the

Re: [HACKERS] damage control mode

2010-01-10 Thread Magnus Hagander
On Sun, Jan 10, 2010 at 05:54, Josh Berkus j...@agliodbs.com wrote: Peter, Just to clarify: I am for sticking to the agreed dates.  If some things are not ready by the necessary date plus/minus one, they won't make the release.  If it's obvious earlier that something won't make the date, it

Re: [HACKERS] damage control mode

2010-01-10 Thread Magnus Hagander
On Sun, Jan 10, 2010 at 07:38, Tom Lane t...@sss.pgh.pa.us wrote: Robert Treat xzi...@users.sourceforge.net writes: ... I don't see much sense in worrying about it now; the 2 weeks between end of CF and Beta are when we need to be cut-throat. Given that this time the must-have feature is

Re: [HACKERS] damage control mode

2010-01-10 Thread Magnus Hagander
On Sun, Jan 10, 2010 at 08:09, Robert Treat xzi...@users.sourceforge.net wrote: On Sunday 10 January 2010 01:38:07 Tom Lane wrote: Robert Treat xzi...@users.sourceforge.net writes: ... I don't see much sense in worrying about it now; the 2 weeks between end of CF and Beta are when we need to

Re: [HACKERS] We need to rethink relation cache entry rebuild

2010-01-10 Thread Stefan Kaltenbrunner
Tom Lane wrote: I mentioned earlier that buildfarm member jaguar (that's the one that builds with CLOBBER_CACHE_ALWAYS) was showing suspicious intermittent failures. There's another one today: hmm I was just doing a CLOBBER_CACHE_ALWAYS build on one of my ARM based boxes and it seems to fall

Re: [HACKERS] Streaming replication status

2010-01-10 Thread Simon Riggs
On Fri, 2010-01-08 at 23:16 +0200, Heikki Linnakangas wrote: * I removed the feature that archiver was started during recovery. The idea of that was to enable archiving from a standby server, to relieve the master server of that duty, but I found it annoying because it causes trouble if the

Re: [HACKERS] Streaming replication status

2010-01-10 Thread Simon Riggs
On Fri, 2010-01-08 at 14:20 -0800, Josh Berkus wrote: On 1/8/10 1:16 PM, Heikki Linnakangas wrote: * A standby that connects to master, initiates streaming, and then sits idle without stalls recycling of old WAL files in the master. That will eventually lead to a full disk in master. Do we

Re: [HACKERS] We need to rethink relation cache entry rebuild

2010-01-10 Thread Simon Riggs
On Fri, 2010-01-08 at 20:01 -0500, Tom Lane wrote: I mentioned earlier that buildfarm member jaguar (that's the one that builds with CLOBBER_CACHE_ALWAYS) was showing suspicious intermittent failures. There's another one today:

Re: [HACKERS] synchronized snapshots

2010-01-10 Thread Simon Riggs
On Fri, 2010-01-08 at 20:36 +0100, Joachim Wieland wrote: The attached patch implements the idea of Heikki / Simon published in http://archives.postgresql.org/pgsql-hackers/2009-11/msg00271.php Since nobody objected to the idea in general, I have implemented it. As this is not currently

Re: [HACKERS] Streaming replication and triggering failover

2010-01-10 Thread Simon Riggs
On Fri, 2010-01-08 at 12:41 +0200, Heikki Linnakangas wrote: let's make the default no failover if no trigger file location is configured, and remove the notion that normal shutdown of master stops recovery. +1 -- Simon Riggs www.2ndQuadrant.com -- Sent via pgsql-hackers

Re: [HACKERS] damage control mode

2010-01-10 Thread Simon Riggs
On Sat, 2010-01-09 at 08:46 -0500, Robert Haas wrote: it seems much better to me to have the rule than not I think we can overplay the need for lots of rules here and the need to chase up status every 5 minutes. The first problem, in previous years, was patches spent too long on the patch

Re: [HACKERS] Congrats Alvaro!

2010-01-10 Thread Dave Page
Congratulations Alvaro! 2010/1/10 Devrim GÜNDÜZ dev...@gunduz.org: Alvaro, one of our hackers and committers and my colleague more than 4 years, had a new baby today. Congrats Alvaro for his second daughter ! -committers, please commit your patches for our new baby elephant! -- Devrim

[HACKERS] ECPG patch causes warning

2010-01-10 Thread Magnus Hagander
Hi! The ecpg patch at http://git.postgresql.org/gitweb?p=postgresql.git;a=commit;h=2f567552 causes a compile warning on win64 (andi think win32, but I didn't recheck that). Specifically, line 140 of typename.c has: return (-type); Where type is of type Oid, which is unsigned. This

Re: [HACKERS] Initial refactoring of plperl.c - updated

2010-01-10 Thread Tim Bunce
On Sun, Jan 10, 2010 at 01:16:13AM -0500, Tom Lane wrote: Tim Bunce tim.bu...@pobox.com writes: On Sat, Jan 09, 2010 at 11:16:18PM +0200, Peter Eisentraut wrote: What's the reason for the temp file here? Defensive. If the text2macro.pl program fails/dies then you'd be left with a broken

Re: [HACKERS] win32 socket definition

2010-01-10 Thread James Mansion
Tom Lane wrote: There's another copy of ListenSocket[] in the BackendParameters struct. I also wonder about postmaster.c's habit of using -1 for empty slots in ListenSocket ... how safe is that for Win64? On Windows, it should be INVALID_SOCKET. James -- Sent via pgsql-hackers mailing

Re: [HACKERS] win32 socket definition

2010-01-10 Thread Magnus Hagander
On Sun, Jan 10, 2010 at 13:33, James Mansion ja...@mansionfamily.plus.com wrote: Tom Lane wrote: There's another copy of ListenSocket[] in the BackendParameters struct. I also wonder about postmaster.c's habit of using -1 for empty slots in ListenSocket ... how safe is that for Win64? On

Re: [HACKERS] damage control mode

2010-01-10 Thread Robert Haas
On Sun, Jan 10, 2010 at 2:09 AM, Robert Treat xzi...@users.sourceforge.net wrote: But really if beta slips because we don't like the looks of our open issues list, thats signicantly better than the last couple releases where we held everything up just to get things into CVS months after feature

Re: [HACKERS] damage control mode

2010-01-10 Thread Robert Haas
On Sun, Jan 10, 2010 at 5:31 AM, Magnus Hagander mag...@hagander.net wrote: But really if beta slips because we don't like the looks of our open issues list, thats signicantly better than the last couple releases where we held everything up just to get things into CVS months after feature

Re: [HACKERS] damage control mode

2010-01-10 Thread Robert Haas
On Sun, Jan 10, 2010 at 5:27 AM, Magnus Hagander mag...@hagander.net wrote: On Sun, Jan 10, 2010 at 05:54, Josh Berkus j...@agliodbs.com wrote: Peter, Just to clarify: I am for sticking to the agreed dates.  If some things are not ready by the necessary date plus/minus one, they won't make

Re: [HACKERS] damage control mode

2010-01-10 Thread Andrew Dunstan
Josh Berkus wrote: I'll also say: if we can't make time-based releases work, we're probably dead as a project. MySQL and Ingres both tried feature-based releases, and look where they are now. I think you're engaging in a bit of 'post hoc ergo propter hoc' reasoning here. In any

Re: [HACKERS] maintenance announcement for dekeni.postgresql.org and minshara.postgresql.org

2010-01-10 Thread Stefan Kaltenbrunner
Stefan Kaltenbrunner wrote: Hi all! In order to install some OS security upgrades we are going to execute planned maintainance one the following hosts affecting the mentioned services tomorrow (10th January 13:00-14:00 GMT). Actual expected downtime will be a few minutes at most so this is

[HACKERS] RADIUS authentication

2010-01-10 Thread Magnus Hagander
The attached patch implements RADIUS authentication (RFC2865-compatible). The main usecase for me in this is the ability to use (token based) one-time-password systems easily with PostgreSQL. These systems almost always support RADIUS, and the implementation is fairly simple. RADIUS can of course

Re: [HACKERS] win32 socket definition

2010-01-10 Thread Magnus Hagander
On Sun, Jan 10, 2010 at 13:44, Magnus Hagander mag...@hagander.net wrote: On Sun, Jan 10, 2010 at 13:33, James Mansion ja...@mansionfamily.plus.com wrote: Tom Lane wrote: There's another copy of ListenSocket[] in the BackendParameters struct. I also wonder about postmaster.c's habit of using

Re: [HACKERS] Small Bug in GetConflictingVirtualXIDs

2010-01-10 Thread Simon Riggs
On Sun, 2009-12-27 at 20:11 +0100, Andres Freund wrote: On Tuesday 22 December 2009 11:42:30 Simon Riggs wrote: On Tue, 2009-12-22 at 03:19 +0100, Andres Freund wrote: On Monday 21 December 2009 16:48:52 Simon Riggs wrote: Giving the drop database a snapshot is not the answer. I expect

Re: [HACKERS] ECPG patch causes warning

2010-01-10 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: The ecpg patch at http://git.postgresql.org/gitweb?p=postgresql.git;a=commit;h=2f567552 causes a compile warning on win64 (andi think win32, but I didn't recheck that). Specifically, line 140 of typename.c has: return (-type); Where

Re: [HACKERS] ECPG patch causes warning

2010-01-10 Thread Boszormenyi Zoltan
Tom Lane írta: Magnus Hagander mag...@hagander.net writes: The ecpg patch at http://git.postgresql.org/gitweb?p=postgresql.git;a=commit;h=2f567552 causes a compile warning on win64 (andi think win32, but I didn't recheck that). Specifically, line 140 of typename.c has: return

Re: [HACKERS] Streaming replication status

2010-01-10 Thread Heikki Linnakangas
Simon Riggs wrote: On Fri, 2010-01-08 at 14:20 -0800, Josh Berkus wrote: On 1/8/10 1:16 PM, Heikki Linnakangas wrote: * A standby that connects to master, initiates streaming, and then sits idle without stalls recycling of old WAL files in the master. That will eventually lead to a full disk

Re: [HACKERS] [PATCH] Windows x64 [repost]

2010-01-10 Thread Magnus Hagander
On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada tsut...@sraoss.co.jp wrote: The following patches support Windows x64. 1) use intptr_t for Datum and pointer macros. (to support Windows LLP64)   almost the same as that post before.  

Re: [HACKERS] ECPG patch causes warning

2010-01-10 Thread Tom Lane
Boszormenyi Zoltan z...@cybertec.at writes: Tom Lane írta: I think that the compiler has caught an actual mistake here. Yes, it's a mistake, but not an actual bug. The intent was to be able to catch unhandled cases in the application, just as in ecpg_dynamic_type(). The fix for

Re: [HACKERS] [PATCH] Windows x64 [repost]

2010-01-10 Thread Tom Lane
Magnus Hagander mag...@hagander.net writes: On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada tsut...@sraoss.co.jp wrote: I was checked where the string converted with %ld is used. An especially fatal part is not found excluding one of plperl. I have not looked at the plperl stuff yet. I'd

Re: [HACKERS] Streaming replication status

2010-01-10 Thread Simon Riggs
On Sun, 2010-01-10 at 18:40 +0200, Heikki Linnakangas wrote: We don't have any way of monitoring that, as yet. Setting ps display is not enough here. Yeah, monitoring would be nice too. But what I was wondering is whether we need some way of stopping that from filling the disk in

Re: [HACKERS] damage control mode

2010-01-10 Thread Peter Eisentraut
On sön, 2010-01-10 at 01:38 -0500, Tom Lane wrote: Now the other approach we could take is that we'll ship *something* on 7 Mar, even if it's less stable than what we've traditionally considered to be beta quality. I don't think that really helps much though; it just means we need more time

Re: [HACKERS] RADIUS authentication

2010-01-10 Thread Peter Eisentraut
On sön, 2010-01-10 at 14:25 +0100, Magnus Hagander wrote: The attached patch implements RADIUS authentication (RFC2865-compatible). The main usecase for me in this is the ability to use (token based) one-time-password systems easily with PostgreSQL. These systems almost always support

Re: [HACKERS] Re: CVS HEAD: Error accessing system column from plpgsql trigger function

2010-01-10 Thread Tom Lane
Dean Rasheed dean.a.rash...@googlemail.com writes: 2010/1/9 Tom Lane t...@sss.pgh.pa.us: I think that a variant of your idea could be made to work: change plpgsql_LookupIdentifiers to a three-state variable (which'd basically mean in DECLARE, in a SQL expression, anywhere else), do no lookups

Re: [HACKERS] RADIUS authentication

2010-01-10 Thread Magnus Hagander
On Sun, Jan 10, 2010 at 18:55, Peter Eisentraut pete...@gmx.net wrote: On sön, 2010-01-10 at 14:25 +0100, Magnus Hagander wrote: The attached patch implements RADIUS authentication (RFC2865-compatible). The main usecase for me in this is the ability to use (token based) one-time-password

Re: [HACKERS] Initial refactoring of plperl.c - updated

2010-01-10 Thread Tom Lane
Tim Bunce tim.bu...@pobox.com writes: On Sun, Jan 10, 2010 at 01:16:13AM -0500, Tom Lane wrote: Doesn't make forcibly remove the target file if the command fails? Andrew, perhaps you could apply the attached to fix that. (Or I could bundle it into one of the split out plperl feature

Re: [HACKERS] ECPG patch causes warning

2010-01-10 Thread Boszormenyi Zoltan
Tom Lane írta: Boszormenyi Zoltan z...@cybertec.at writes: Tom Lane írta: I think that the compiler has caught an actual mistake here. Yes, it's a mistake, but not an actual bug. The intent was to be able to catch unhandled cases in the application, just as in

Re: [HACKERS] Congrats Alvaro!

2010-01-10 Thread David Fetter
On Sun, Jan 10, 2010 at 05:16:48AM +0200, Devrim GUNDUZ wrote: Alvaro, one of our hackers and committers and my colleague more than 4 years, had a new baby today. Congrats Alvaro for his second daughter ! In short, +1 from Alvaro and Sra. Herrera :) -committers, please commit your

Re: [HACKERS] Feature patch 1 for plperl [PATCH]

2010-01-10 Thread Tom Lane
Tim Bunce tim.bu...@pobox.com writes: On Fri, Jan 08, 2010 at 10:36:43PM -0500, Robert Haas wrote: I kind of thought Tom said these were a bad idea, and I think I kind of agree. Tom had some concerns which I believe I've addressed. You haven't addressed them, you've simply ignored them. For

Re: [HACKERS] Feature patch 1 for plperl [PATCH]

2010-01-10 Thread Robert Haas
On Sun, Jan 10, 2010 at 1:49 PM, Tom Lane t...@sss.pgh.pa.us wrote: Tim Bunce tim.bu...@pobox.com writes: On Fri, Jan 08, 2010 at 10:36:43PM -0500, Robert Haas wrote: I kind of thought Tom said these were a bad idea, and I think I kind of agree. Tom had some concerns which I believe I've

Re: [HACKERS] Feature patch 1 for plperl [PATCH]

2010-01-10 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Sun, Jan 10, 2010 at 1:49 PM, Tom Lane t...@sss.pgh.pa.us wrote: What happens when the supplied code has errors, takes an unreasonable amount of time to run, does something unsafe, depends on the backend not being in an error state already, etc

Re: [HACKERS] Feature patch 1 for plperl [PATCH]

2010-01-10 Thread Andrew Dunstan
Robert Haas wrote: Anyway, I think you've put this pretty well here: the current definition will make people WANT to use multi-line values for this, and we don't support that. I think Tim's example is fairly contrived - setting a global variable here does not seem likely to be useful to very

Re: [HACKERS] Streaming replication status

2010-01-10 Thread Josh Berkus
We need monitoring anywhere we have a max_* parameter. Otherwise we won't know how close we are to disaster until we hit the limit and things break down. Otherwise we will have to set parameters by trial and error, or set them so high they are meaningless. I agree. Thing is, though, we have

Re: [HACKERS] Re: CVS HEAD: Error accessing system column from plpgsql trigger function

2010-01-10 Thread Dean Rasheed
2010/1/10 Tom Lane t...@sss.pgh.pa.us: I've applied a patch along these lines. Cool. Thanks, that works great. Cheers, Dean -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Feature patch 1 for plperl [PATCH]

2010-01-10 Thread Robert Haas
On Sun, Jan 10, 2010 at 2:49 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Sun, Jan 10, 2010 at 1:49 PM, Tom Lane t...@sss.pgh.pa.us wrote: What happens when the supplied code has errors, takes an unreasonable amount of time to run, does something unsafe,

Re: [HACKERS] Feature patch 1 for plperl [PATCH]

2010-01-10 Thread Andrew Dunstan
Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: On Sun, Jan 10, 2010 at 1:49 PM, Tom Lane t...@sss.pgh.pa.us wrote: What happens when the supplied code has errors, takes an unreasonable amount of time to run, does something unsafe, depends on the backend not being in an

Re: [HACKERS] [PATCH] remove redundant ownership checks

2010-01-10 Thread Robert Haas
On Sun, Dec 20, 2009 at 10:53 PM, I wrote: On Thu, Dec 17, 2009 at 7:19 PM, Tom Lane t...@sss.pgh.pa.us wrote: KaiGai Kohei kai...@ak.jp.nec.com writes: [ patch to remove EnableDisableRule's permissions check ] I don't particularly like this patch, mainly because I disagree with randomly

Re: [HACKERS] Feature patch 1 for plperl [PATCH]

2010-01-10 Thread Robert Haas
On Sun, Jan 10, 2010 at 2:58 PM, Andrew Dunstan and...@dunslane.net wrote: I don't know why you would do either of these things. I at least would load one module which would in turn load others. So I'd expect to see something like this:   plperl.on_perl_init = 'use lib /my/app; use

Re: [HACKERS] [PATCH] remove redundant ownership checks

2010-01-10 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I have looked this over a little bit and I guess I don't see why the lack of a grand plan for how to organize all of our permissions checks ought to keep us from removing this one on the grounds of redundancy. We have to attack this problem in small

Re: [HACKERS] Feature patch 1 for plperl [PATCH]

2010-01-10 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: As an example, if people were using such functionality then the DBA couldn't start preloading plperl for performance without breaking behavior that some of his users might be depending on. If we made plperl.on_perl_init

Re: [HACKERS] Streaming replication status

2010-01-10 Thread Simon Riggs
On Sun, 2010-01-10 at 12:10 -0800, Josh Berkus wrote: We need monitoring anywhere we have a max_* parameter. Otherwise we won't know how close we are to disaster until we hit the limit and things break down. Otherwise we will have to set parameters by trial and error, or set them so high

Re: [HACKERS] Typed tables

2010-01-10 Thread Peter Eisentraut
On tor, 2009-11-05 at 19:24 +0200, Peter Eisentraut wrote: I'm planning to work on typed tables support. The idea is that you create a table out of a composite type (as opposed to the other way around, which is currently done automatically). CREATE TYPE persons_type AS (name text, bdate

Re: [HACKERS] Streaming replication status

2010-01-10 Thread Josh Berkus
Currently there is no way of knowing what the average/current transit time is on replication, no way of knowing what is happening if we go idle etc.. Those things need to be included because they are not otherwise accessible. Cars need windows, not just a finely tuned engine. Like I said, I

Re: [HACKERS] Feature patch 1 for plperl [PATCH]

2010-01-10 Thread Andrew Dunstan
Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: As an example, if people were using such functionality then the DBA couldn't start preloading plperl for performance without breaking behavior that some of his users might be depending on. If we

Re: [HACKERS] damage control mode

2010-01-10 Thread Josh Berkus
Now the other approach we could take is that we'll ship *something* on 7 Mar, even if it's less stable than what we've traditionally considered to be beta quality. I don't think that really helps much though; it just means we need more time in beta. Well, we're shipping an alpha, aren't we?

Re: [HACKERS] Typed tables

2010-01-10 Thread Josh Berkus
On 1/10/10 2:34 PM, Peter Eisentraut wrote: On tor, 2009-11-05 at 19:24 +0200, Peter Eisentraut wrote: I'm planning to work on typed tables support. The idea is that you create a table out of a composite type (as opposed to the other way around, which is currently done automatically). Nice.

Re: [HACKERS] Feature patch 1 for plperl [PATCH]

2010-01-10 Thread David E. Wheeler
On Jan 10, 2010, at 11:17 AM, Robert Haas wrote: It's nicer to write: plperl.on_perl_init='strict,warnings,LDAP,HTML::Parser,Archive::Zip' rather than: plperl.on_perl_init='use strict;use warnings;use LDAP;use HTML::Parser;use Archive::Zip;' Well, no, because sometimes I just want to

Re: [HACKERS] We need to rethink relation cache entry rebuild

2010-01-10 Thread Tom Lane
I wrote: Basically I think we have to fix this by ensuring that an error escape can't occur while a relcache entry is in a partially rebuilt state. Attached is a draft patch for this. In addition to fixing the stated problem, it also takes care of a thinko that I found along the way:

Re: [HACKERS] Feature patch 1 for plperl [PATCH]

2010-01-10 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: Tom Lane wrote: No, they have to all be PGC_POSTMASTER to answer that concern. Only breaking things for superusers isn't really that big an improvement over breaking them for everybody. Well, I don't know about Tim but I think I could live with

Re: [HACKERS] mailing list archiver chewing patches

2010-01-10 Thread Alvaro Herrera
Dimitri Fontaine wrote: Andrew Dunstan and...@dunslane.net writes: That is assuming that the MUA gives you the option of specifying the attachment MIME type. Many (including mine) do not. It would mean an extra step - I'd have to gzip each patch or something like that. That would be

Re: [HACKERS] Feature patch 1 for plperl [PATCH]

2010-01-10 Thread Tom Lane
Tim Bunce tim.bu...@pobox.com writes: I didn't get any significant feedback from the earlier draft so here's the finished 'feature patch 1' for plperl. (This builds on my earlier plperl refactoring patch, and the follow-on ppport.h patch.) Just looking over this patch, I don't think it's

Re: [HACKERS] [PATCH] remove redundant ownership checks

2010-01-10 Thread Robert Haas
On Sun, Jan 10, 2010 at 4:54 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: I have looked this over a little bit and I guess I don't see why the lack of a grand plan for how to organize all of our permissions checks ought to keep us from removing this one on

Re: [HACKERS] Red-black tree for GIN

2010-01-10 Thread Robert Haas
On Thu, Dec 31, 2009 at 4:19 PM, Robert Haas robertmh...@gmail.com wrote: My other question is as related to performance.  Can you provide a test case that shows the performance improvement with this patch? So, we still don't have a test case for this patch. During the November CommitFest,

Re: [HACKERS] Red-black tree for GIN

2010-01-10 Thread Greg Stark
On Mon, Jan 11, 2010 at 2:42 AM, Robert Haas robertmh...@gmail.com wrote: The coding pattern that this patch uses also merits some discussion. Basically, rbtree.c is a generic implementation of red-black trees - from a textbook - which ginbulk.c then uses for GIN.  One possible advantage of

Re: [HACKERS] RADIUS authentication

2010-01-10 Thread Stephen Frost
Magnus, * Magnus Hagander (mag...@hagander.net) wrote: The attached patch implements RADIUS authentication (RFC2865-compatible). Great! We have a few environments which use RADIUS auth, nice that PG might be able to use that auth method in the future. I'm not a fan of having the shared

Re: [HACKERS] damage control mode

2010-01-10 Thread Robert Haas
On Sun, Jan 10, 2010 at 6:24 PM, Josh Berkus j...@agliodbs.com wrote: Now the other approach we could take is that we'll ship *something* on 7 Mar, even if it's less stable than what we've traditionally considered to be beta quality.  I don't think that really helps much though; it just means

Re: [HACKERS] quoting psql varible as identifier

2010-01-10 Thread Robert Haas
On Tue, Jan 5, 2010 at 8:23 AM, Pavel Stehule pavel.steh...@gmail.com wrote: 2010/1/5 Tom Lane t...@sss.pgh.pa.us: Robert Haas robertmh...@gmail.com writes: On Mon, Jan 4, 2010 at 2:51 PM, Pavel Stehule pavel.steh...@gmail.com wrote: I don't have a problem to write second and safe fmtId

Re: [HACKERS] Listen / Notify - what to do when the queue is full

2010-01-10 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 - do we need to limit the payload to pure ASCII ? I think yes, we need to. I also think we need to reject other payloads with elog(ERROR...). ...[snip other followups] On the one hand, I don't see the problem with ASCII here - the payload

Re: [HACKERS] Testing with concurrent sessions

2010-01-10 Thread Greg Sabino Mullane
-BEGIN PGP SIGNED MESSAGE- Hash: RIPEMD160 Using DBI/DBD::Pg would raise another issue - what version of libpq would it be using? Not the one in the build being tested, that's for

Re: [HACKERS] quoting psql varible as identifier

2010-01-10 Thread Pavel Stehule
2010/1/11 Robert Haas robertmh...@gmail.com: On Tue, Jan 5, 2010 at 8:23 AM, Pavel Stehule pavel.steh...@gmail.com wrote: 2010/1/5 Tom Lane t...@sss.pgh.pa.us: Robert Haas robertmh...@gmail.com writes: On Mon, Jan 4, 2010 at 2:51 PM, Pavel Stehule pavel.steh...@gmail.com wrote: I don't have

Re: [HACKERS] Red-black tree for GIN

2010-01-10 Thread Oleg Bartunov
Robert, we have benchmark for rbtree http://www.sai.msu.su/~megera/wiki/2009-07-27 rbtree, actually, fix corner cases with ordered input, with little overhead. As you may see from knngist patch, rbtree used in gist code, so, please, leave rbtree code as is. Oleg On Sun, 10 Jan 2010, Robert

Re: [HACKERS] Listen / Notify - what to do when the queue is full

2010-01-10 Thread Peter Eisentraut
On mån, 2010-01-11 at 04:05 +, Greg Sabino Mullane wrote: On the one hand, I don't see the problem with ASCII here - the payload is meant as a quick shorthand convenience, not a literal payload of important information. Is it not? The notify name itself is already a quick shorthand

Re: [HACKERS] Typed tables

2010-01-10 Thread Peter Eisentraut
On sön, 2010-01-10 at 15:27 -0800, Josh Berkus wrote: On 1/10/10 2:34 PM, Peter Eisentraut wrote: On tor, 2009-11-05 at 19:24 +0200, Peter Eisentraut wrote: I'm planning to work on typed tables support. The idea is that you create a table out of a composite type (as opposed to the other

Re: [HACKERS] xpath improvement suggestion

2010-01-10 Thread Peter Eisentraut
On ons, 2010-01-06 at 23:46 +0100, Arie Bikker wrote: Hope this is the right attachement type (I'm new at this) BTW. here a some nice examples: - Get the number of attributes of the first childnode: select ( xpath('count(@*)',(xpath('*[1]','a b=cd e=f g=j//a'))[1]))[1]; - an