Re: [HACKERS] is sync rep stalled?

2010-10-02 Thread Josh Berkus
What we actually need to do is talk and listen. I'd like to suggest that we have an online "focus day" (onlist) on Sync Rep on Oct 5 and maybe 6 as well?. Meeting in person is possible, but probably impractical. But a design sprint, not a code sprint. I'd suggest something even simpler: (1) C

Re: [HACKERS] is sync rep stalled?

2010-10-02 Thread Josh Berkus
On 09/30/2010 10:52 PM, Tom Lane wrote: IMHO we should push out the end date by at least a week to reflect the lack of time spent on the CF so far. I agree that we should postpone the end of the CF by one week to deal with the distractions people have had. --

[HACKERS] Review: Fix snapshot taking inconsistencies

2010-10-02 Thread Steve Singer
This is my review on the "Fix snapshot taking inconsistencies patch". The patch applies against master (a13f12b3a18da0a61571cb134fdecea03a10d6f) However initdb fails with: FATAL: return type mismatch in function declared to return record DETAIL: Function's final statement must be SELECT or

Re: [HACKERS] configure gaps

2010-10-02 Thread Tom Lane
Peter Eisentraut writes: > Actually, it turns out the handling of nls-global.mk for missing > xgettext has been broken since revision 1. Ooohh ... the ifdef's are in the wrong place, aren't they. Maybe it would be better to use the "missing" script for xgettext and drop the ifdefs?

Re: [HACKERS] configure gaps

2010-10-02 Thread Peter Eisentraut
On lör, 2010-10-02 at 16:43 -0400, Andrew Dunstan wrote: > > > On 10/02/2010 01:35 PM, Peter Eisentraut wrote: > > > > > b) with gettext installed but not gettext-tools (and in particular > > > xgettext was missing), the NLS stuff failed. > > xgettext is not required for the build. > > here i

Re: [HACKERS] configure gaps

2010-10-02 Thread Tom Lane
I wrote: > Andrew Dunstan writes: >> make -C backend all >> make[2]: Entering directory `/usr/local/src/pg_9_0/src/backend' >> msgfmt -o po/de.mo po/de.po >> You don't have 'xgettext'. >> make[2]: *** [po/de.mo] Error 1 > It seems to me that this indicates brain death on the part of the SLES > pa

Re: [HACKERS] configure gaps

2010-10-02 Thread Tom Lane
Andrew Dunstan writes: > On 10/02/2010 01:35 PM, Peter Eisentraut wrote: >> xgettext is not required for the build. > here is the tail of my make log with gettext-tools uninstalled (platform > is SLES 11 SP1): > make -C backend all > make[2]: Entering directory `/usr/local/src/pg_9_0/sr

Re: [HACKERS] configure gaps

2010-10-02 Thread Andrew Dunstan
On 10/02/2010 02:31 PM, Dimitri Fontaine wrote: Rob Wultsch writes: One of the things I really like about drizzle is if there a missing dependency it will explicitly tell you what you are missing and where to go find it for popular platforms. Choose your platform wisely. Then, apt-get build-

Re: [HACKERS] configure gaps

2010-10-02 Thread Andrew Dunstan
On 10/02/2010 01:35 PM, Peter Eisentraut wrote: b) with gettext installed but not gettext-tools (and in particular xgettext was missing), the NLS stuff failed. xgettext is not required for the build. here is the tail of my make log with gettext-tools uninstalled (platform is SLES 11 SP1):

Re: [HACKERS] ISN patch that applies cleanly with git apply

2010-10-02 Thread Tom Lane
Peter Geoghegan writes: > Peter Eisentraut asked Jan to produce a regression test for the ISN > contrib module, which he is apparently working on. I would like to see > him more clearly explaining how that will work though - so far, it's > really just been described in very broad strokes. Even mo

Re: [HACKERS] INSERT ... VALUES... with ORDER BY / LIMIT

2010-10-02 Thread Tom Lane
Hitoshi Harada writes: > 2010/10/2 Jeff Davis : >> On Fri, 2010-10-01 at 18:52 +0900, Hitoshi Harada wrote: > While tackling the top-level CTEs patch, I found that INSERT ... > VALUES isn't aware of ORDER BY / LIMIT. > From my reading the source around transformInsertStmt(), VALUES in > INSERT is

Re: [HACKERS] missing tags

2010-10-02 Thread Marc G. Fournier
Agreed, I thought of that when Andrew sent the original ... On Sat, 2 Oct 2010, Magnus Hagander wrote: On Sat, Oct 2, 2010 at 16:08, Tom Lane wrote: Magnus Hagander writes: On Sat, Oct 2, 2010 at 13:36, Andrew Dunstan wrote: I think the confusion is from the use of "tagged" in the commit

Re: [HACKERS] configure gaps

2010-10-02 Thread Dimitri Fontaine
Rob Wultsch writes: > One of the things I really like about drizzle is if there a missing > dependency it will explicitly tell you what you are missing and where > to go find it for popular platforms. Choose your platform wisely. Then, apt-get build-dep postgresql-9.0 :) Regards, -- dim -- Se

Re: [HACKERS] INSERT ... VALUES... with ORDER BY / LIMIT

2010-10-02 Thread Hitoshi Harada
2010/10/2 Jeff Davis : > On Fri, 2010-10-01 at 18:52 +0900, Hitoshi Harada wrote: >> While tackling the top-level CTEs patch, I found that INSERT ... >> VALUES isn't aware of ORDER BY / LIMIT. >> >> regression=# CREATE TABLE t1(x int); >> CREATE TABLE >> regression=# INSERT INTO t1 VALUES (1),(2),(

Re: [HACKERS] configure gaps

2010-10-02 Thread Peter Eisentraut
On lör, 2010-10-02 at 13:01 -0400, Andrew Dunstan wrote: > Specifically, a) when python was installed but python-devel was not, > configure passed by the compile for python failed quite miserably, and Yeah. Same is true if libperl-dev or similar is not installed. > b) with gettext installed bu

Re: [HACKERS] configure gaps

2010-10-02 Thread Rob Wultsch
On Sat, Oct 2, 2010 at 10:01 AM, Andrew Dunstan wrote: > I'm, not sure if this is worth fixing, but it seemed worth mentioning. ISTM > that if we pass configure, we should be able to assume that the requisite > build tools, libraries, include files etc. are present. One of the things I really li

[HACKERS] ISN patch that applies cleanly with git apply

2010-10-02 Thread Peter Geoghegan
I am reviewing Jan Otto's ISN patch, as part of the ongoing commit-fest. I've attached a revised patch, which was produced with git diff. The original was produced against CVS head. The patch produces this warning when applied to master: pe...@linux-peter-home:~/postgresql> git apply isbn_git_pat

[HACKERS] configure gaps

2010-10-02 Thread Andrew Dunstan
While trying to build PostgreSQL 9.0 on a machine where the SA had omitted to install a lot of the required packages, I noticed a couple of cases where configure passed but the build failed due to missing pieces in the toolset. Specifically, a) when python was installed but python-devel was

Re: [HACKERS] missing tags

2010-10-02 Thread Andrew Dunstan
On 10/02/2010 10:45 AM, Magnus Hagander wrote: On Sat, Oct 2, 2010 at 16:08, Tom Lane wrote: Magnus Hagander writes: On Sat, Oct 2, 2010 at 13:36, Andrew Dunstan wrote: I think the confusion is from the use of "tagged" in the commit message Possibly Marc should adopt the habit of making t

Re: [HACKERS] missing tags

2010-10-02 Thread Magnus Hagander
On Sat, Oct 2, 2010 at 16:08, Tom Lane wrote: > Magnus Hagander writes: >> On Sat, Oct 2, 2010 at 13:36, Andrew Dunstan wrote: >> I think the confusion is from the use of "tagged" in the commit >> message > > Possibly Marc should adopt the habit of making the commit messages read > like "Stamp 9

Re: [HACKERS] missing tags

2010-10-02 Thread Tom Lane
Magnus Hagander writes: > On Sat, Oct 2, 2010 at 13:36, Andrew Dunstan wrote: >> There are commit messages from about 22 hours ago that say that the > This was intentional - to wait with the tags until the tarballs have > been verified *and published*, so we don't end up having to move the > tag

Re: [HACKERS] PG-Git usernames

2010-10-02 Thread Magnus Hagander
On Fri, Oct 1, 2010 at 20:23, Peter Eisentraut wrote: > On fre, 2010-10-01 at 16:26 +0200, Magnus Hagander wrote: >> Personally, I don't see any advantage at all of git.postgresql.org >> over github for a development repository. Others may have different >> opinions, of course. > > My personal obj

Re: [HACKERS] missing tags

2010-10-02 Thread Magnus Hagander
On Sat, Oct 2, 2010 at 13:36, Andrew Dunstan wrote: >  There are commit messages from about 22 hours ago that say that the > upcoming releases have been tagged, but I don't see the corresponding tags > when I list out the tags in my repo (and there has been a commit since > then). > > I'm not sure

[HACKERS] missing tags

2010-10-02 Thread Andrew Dunstan
There are commit messages from about 22 hours ago that say that the upcoming releases have been tagged, but I don't see the corresponding tags when I list out the tags in my repo (and there has been a commit since then). I'm not sure where the release procedures are documented - I couldn't f