Re: [HACKERS] bug of recovery?

2011-09-27 Thread Heikki Linnakangas
On 26.09.2011 21:06, Simon Riggs wrote: On Mon, Sep 26, 2011 at 10:50 AM, Fujii Masaomasao.fu...@gmail.com wrote: Currently, if a reference to an invalid page is found during recovery, its information is saved in hash table invalid_page_tab. Then, if such a reference is resolved, its

Re: [HACKERS] bug of recovery?

2011-09-27 Thread Heikki Linnakangas
On 27.09.2011 00:28, Florian Pflug wrote: On Sep26, 2011, at 22:39 , Tom Lane wrote: It might be worthwhile to invoke XLogCheckInvalidPages() as soon as we (think we) have reached consistency, rather than leaving it to be done only when we exit recovery mode. I believe we also need to prevent

Re: [HACKERS] bug of recovery?

2011-09-27 Thread Simon Riggs
On Tue, Sep 27, 2011 at 6:54 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: I think you're mixing this up with the multi-page page split operations in b-tree. This is different from that. What the invalid_page_tab is for is the situation where you for example, insert to a

Re: [HACKERS] [v9.2] Fix Leaky View Problem

2011-09-27 Thread Kohei KaiGai
2011/9/26 Robert Haas robertmh...@gmail.com: On Mon, Sep 12, 2011 at 3:31 PM, Kohei KaiGai kai...@kaigai.gr.jp wrote: The Part-2 tries to tackles a leaky-view scenarios by functions with very tiny cost estimation value. It was same one we had discussed in the commitfest-1st. It prevents to

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-27 Thread Kohei KaiGai
2011/9/26 Tom Lane t...@sss.pgh.pa.us: Kohei KaiGai kai...@kaigai.gr.jp writes: How about this fix on regression test of sepgsql? IMO, the fundamental problem with the sepgsql regression tests is that they think they don't need to play by the rules that apply to every other PG regression

[HACKERS] Postgresql parser

2011-09-27 Thread andurkar
Hello, Currently I am working on Postgresql... I need to study the gram.y and scan.l parser files...since I want to do some qery modification. Can anyone please help me to understand the files. What should I do ? Is there any documentation available ? Regards, Aditi. -- View this message in

Re: [HACKERS] unite recovery.conf and postgresql.conf

2011-09-27 Thread Fujii Masao
On Mon, Sep 26, 2011 at 7:45 PM, Peter Eisentraut pete...@gmx.net wrote: On sön, 2011-09-25 at 12:58 -0400, Tom Lane wrote: And it's not like we don't break configuration file contents in most releases anyway, so I really fail to see why this one has suddenly become sacrosanct. Well, there

Re: [HACKERS] Postgresql parser

2011-09-27 Thread Kerem Kat
On Tue, Sep 27, 2011 at 11:44, andurkar andurkarad10.c...@coep.ac.in wrote: Hello, Currently I am working on Postgresql... I need to study the gram.y and scan.l parser files...since I want to do some qery modification. Can anyone please help me to understand the files. What should I do ? Is

Re: [HACKERS] fix for pg_upgrade

2011-09-27 Thread panam
Hi Bruce, here is the whole dump (old DB): http://postgresql.1045698.n5.nabble.com/file/n4844725/dump.txt dump.txt Regards, panam -- View this message in context: http://postgresql.1045698.n5.nabble.com/fix-for-pg-upgrade-tp3411128p4844725.html Sent from the PostgreSQL - hackers mailing list

Re: [HACKERS] bug of recovery?

2011-09-27 Thread Florian Pflug
On Sep27, 2011, at 07:59 , Heikki Linnakangas wrote: On 27.09.2011 00:28, Florian Pflug wrote: On Sep26, 2011, at 22:39 , Tom Lane wrote: It might be worthwhile to invoke XLogCheckInvalidPages() as soon as we (think we) have reached consistency, rather than leaving it to be done only when we

Re: [HACKERS] Postgresql parser

2011-09-27 Thread Florian Pflug
On Sep27, 2011, at 10:44 , andurkar wrote: Currently I am working on Postgresql... I need to study the gram.y and scan.l parser files...since I want to do some qery modification. Can anyone please help me to understand the files. What should I do ? Is there any documentation available ?

Re: [HACKERS] heap_update temporary release of buffer lock

2011-09-27 Thread Robert Haas
On Tue, Sep 20, 2011 at 3:47 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Robert Haas's message of mar sep 20 16:04:03 -0300 2011: On 20.09.2011 20:42, Alvaro Herrera wrote: I notice that heap_update releases the buffer lock, after

Re: [HACKERS] [v9.1] sepgsql - userspace access vector cache

2011-09-27 Thread Robert Haas
On Fri, Sep 2, 2011 at 12:38 PM, Kohei Kaigai kohei.kai...@emea.nec.com wrote: I've committed this, but I still think it would be helpful to revise that comment.  The turn boosted up is not very precise or informative.  Could you submit a separate, comment-only patch to improve this? I tried

Re: [HACKERS] CUDA Sorting

2011-09-27 Thread Vitor Reus
Hey hackers, I'm still having problems reading the values of the columns in tuplesort.c, in order to understand how to port this to CUDA. Should I use the heap_getattr macro to read them? 2011/9/24 Hannu Krosing ha...@krosing.net On Mon, 2011-09-19 at 10:36 -0400, Greg Smith wrote: On

Re: [HACKERS] the big picture for index-only scans

2011-09-27 Thread Robert Haas
On Sun, Aug 21, 2011 at 3:13 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: PS. Robert, the LOCKING section in the header comment of visibilitymap.c is out-of-date: it claims that the VM bit is cleared after releasing the lock on the heap page. Fixed, along with your other

Re: [HACKERS] Support UTF-8 files with BOM in COPY FROM

2011-09-27 Thread Peter Eisentraut
On mån, 2011-09-26 at 21:49 +0300, Peter Eisentraut wrote: If I store a BOM in row 1, column 1 of my table, because, well, maybe it's an XML document or something, then it needs to be able to survive a copy out and in. The only way we could proceed with this would be if we prohibited BOMs in

Re: [HACKERS] Postgresql parser

2011-09-27 Thread Alvaro Herrera
Excerpts from Florian Pflug's message of mar sep 27 08:28:00 -0300 2011: On Sep27, 2011, at 10:44 , andurkar wrote: Currently I am working on Postgresql... I need to study the gram.y and scan.l parser files...since I want to do some qery modification. Can anyone please help me to

Re: [HACKERS] Support UTF-8 files with BOM in COPY FROM

2011-09-27 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: Alternative consideration: We could allow this in CSV format if we made users quote the first value if it starts with a BOM. This might be a reasonable way to get MS compatibility. I don't think we can get away with a retroactive restriction on the

[HACKERS] [PATCH] Addition of some trivial auto vacuum logging

2011-09-27 Thread Royce Ausburn
Hi all, I spent a bit of today diagnosing a problem where long held transactions were preventing auto vacuum from doing its job. Eventually I had set log_autovacuum_min_duration to 0 to see what was going on. Unfortunately it wasn't until I tried a VACUUM VERBOSE that I found there were dead

Re: [HACKERS] [PATCH] Addition of some trivial auto vacuum logging

2011-09-27 Thread Tom Lane
Royce Ausburn royce...@inomial.com writes: The attached patch adds extra detail the the existing autovacuum log message that is emitted when the log_autovacuum_min_duration threshold is met, exposing the unremovable dead tuple count similar to what you get from VACUUM VERBOSE. Sample log

Re: [HACKERS] [PATCH] Addition of some trivial auto vacuum logging

2011-09-27 Thread Kevin Grittner
Royce Ausburn royce...@inomial.com wrote: As this is my first patch to postgresql, I'm expecting I've done something wrong. Please if you want me to fix something up, or just go away please say so ;) I appreciate that this is a trivial patch, and perhaps doesn't add value except for my

Re: [HACKERS] random isolation test failures

2011-09-27 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mar sep 27 01:11:39 -0300 2011: Alvaro Herrera alvhe...@commandprompt.com writes: I just tweaked isolationtester so that it collects the error messages and displays them all together at the end of the test. After seeing it run, I didn't like it -- I

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-27 Thread Tom Lane
I wrote: I think it should be possible to still use all the existing testing infrastructure if the check/test script does something like make REGRESS=label dml misc check I've now worked through the process of actually running the sepgsql regression tests, and I must say that I had no

Re: [HACKERS] random isolation test failures

2011-09-27 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Tom Lane's message of mar sep 27 01:11:39 -0300 2011: Hmm, is that really an appropriate fix? I'm worried that it might mask event-ordering differences that actually are significant. In the attached, it only affects the case

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-27 Thread Robert Haas
On Tue, Sep 27, 2011 at 3:39 PM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: I think it should be possible to still use all the existing testing infrastructure if the check/test script does something like       make REGRESS=label dml misc check I've now worked through the process of actually

[HACKERS] [PATCH] Log crashed backend's query v2

2011-09-27 Thread Marti Raudsepp
On Sat, Sep 24, 2011 at 22:57, Marti Raudsepp ma...@juffo.org wrote: However, I now realize that it does make sense to write a separate simpler function for the crashed backend case with no vbeentry-st_changecount check loops, no checkUser, etc. That would be more robust and easier to review.

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-27 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Sep 27, 2011 at 3:39 PM, Tom Lane t...@sss.pgh.pa.us wrote: Accordingly, the attached patch does what I suggested above, namely dike out the Makefile's knowledge of how to run the regression tests and put it into the chkselinuxenv script.

Re: [HACKERS] Hot Backup with rsync fails at pg_clog if under load

2011-09-27 Thread Florian Pflug
On Sep23, 2011, at 21:10 , Robert Haas wrote: So the actual error message in the last test was: 2011-09-21 13:41:05 CEST FATAL: could not access status of transaction 1188673 ...but we can't tell if that was before or after nextXid, which seems like it would be useful to know. If

Re: [HACKERS] [PATCH] Log crashed backend's query v2

2011-09-27 Thread Florian Pflug
On Sep28, 2011, at 00:19 , Marti Raudsepp wrote: (I'm still not sure what adt means) I always assumed it stood for abstract data type. Most of the files in this directory seem to correspond to an SQL-level data type like intX, varchar, tsquery, ..., and contain the I/O functions for that type,

Re: [HACKERS] Online base backup from the hot-standby

2011-09-27 Thread Steve Singer
On 11-09-26 10:56 PM, Fujii Masao wrote: Looks weired. Though the WAL record starting from 0/6000298 was read successfully, then re-fetch of the same record fails at the end of recovery. One possible cause is the corruption of archived WAL file. What restore_command on the standby and

[HACKERS] pg_upgrade - add config directory setting

2011-09-27 Thread Steve Crawford
It would perhaps be useful to add optional --old-confdir and --new-confdir parameters to pg_upgrade. If these parameters are absent then pg_upgrade would work as it does now and assume that the config files are in the datadir. The reason for this suggestion is that packages for Ubuntu (and I

[HACKERS] Mismatch of relation names: pg_toast.pg_toast_nnn during pg_upgrade from 8.4 to 9.1

2011-09-27 Thread Jamie Fox
Hi - I've had no problem upgrading copies our qa databases (which are backed up and restored with pg_dump/pg_restore)  but have run into the same problem each time I try to upgrade a copy of our production database (backed up and restored via PITR).  After verifying a successful restore and

Re: [HACKERS] [PATCH] Addition of some trivial auto vacuum logging

2011-09-27 Thread Royce Ausburn
Thanks for the tips guys. Just a question: is the utility great enough to warrant me working further on this? I have no real desire to implement this particular feature -- I simply saw an opportunity to cut my teeth on something easy. I'd be happy to find something on the TODO list instead

Re: [HACKERS] [PATCH] Addition of some trivial auto vacuum logging

2011-09-27 Thread Stephen Frost
* Royce Ausburn (royce...@inomial.com) wrote: Just a question: is the utility great enough to warrant me working further on this? I have no real desire to implement this particular feature -- I simply saw an opportunity to cut my teeth on something easy. I'd be happy to find something on

Re: [HACKERS] [PATCH] Addition of some trivial auto vacuum logging

2011-09-27 Thread Alvaro Herrera
Excerpts from Royce Ausburn's message of mar sep 27 21:28:26 -0300 2011: Thanks for the tips guys. Just a question: is the utility great enough to warrant me working further on this? I have no real desire to implement this particular feature -- I simply saw an opportunity to cut my

Re: [HACKERS] contrib/sepgsql regression tests are a no-go

2011-09-27 Thread Robert Haas
On Tue, Sep 27, 2011 at 6:30 PM, Tom Lane t...@sss.pgh.pa.us wrote: I have not touched the documentation, either.  One thing I'd like to do is adjust both the SGML documentation and the hints printed by the script to uniformly use sudo ...root-privileged-command... rather than recommending use

Re: [HACKERS] [PATCH] Addition of some trivial auto vacuum logging

2011-09-27 Thread Tom Lane
Alvaro Herrera alvhe...@commandprompt.com writes: Excerpts from Royce Ausburn's message of mar sep 27 21:28:26 -0300 2011: Tom's suggestion looks like it's less trivial that I can do just yet, but I'll take a look and ask for help if I need it. It's not that difficult. Just do a search on

Re: [HACKERS] pg_upgrade - add config directory setting

2011-09-27 Thread Mr. Aaron W. Swenson
On Tue, Sep 27, 2011 at 04:13:41PM -0700, Steve Crawford wrote: It would perhaps be useful to add optional --old-confdir and --new-confdir parameters to pg_upgrade. If these parameters are absent then pg_upgrade would work as it does now and assume that the config files are in the datadir.

Re: [HACKERS] [PATCH] Log crashed backend's query v2

2011-09-27 Thread Tom Lane
Florian Pflug f...@phlo.org writes: On Sep28, 2011, at 00:19 , Marti Raudsepp wrote: (I'm still not sure what adt means) I always assumed it stood for abstract data type. Yeah, that's what I think too. Over time it's been used to hold most code that is a SQL-callable function, many of which

Re: [HACKERS] Online base backup from the hot-standby

2011-09-27 Thread Fujii Masao
On Wed, Sep 28, 2011 at 8:10 AM, Steve Singer ssinger...@sympatico.ca wrote: This is the test procedure I'm trying today, I wasn't able to reproduce the crash.  What I was doing the other day was similar but I can't speak to unintentional differences. Thanks for the info! I tried your test

Re: [HACKERS] pg_upgrade automatic testing

2011-09-27 Thread Bruce Momjian
Bruce Momjian wrote: Peter Eisentraut wrote: 8.4 - master upgrade fails like this: Restoring user relation files Mismatch of relation names in database regression: old name pg_toast.pg_toast_27437, new name pg_toast.pg_toast_27309 Failure, exiting This has been 100%

Re: [HACKERS] pg_upgrade automatic testing

2011-09-27 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: I propose I just remove the 8.4 test and always allow toast table names not to match --- the oids are still checked and are preserved. +1. You'll still make the check for non-toast tables, of course? regards, tom lane -- Sent

Re: [HACKERS] fix for pg_upgrade

2011-09-27 Thread Bruce Momjian
panam wrote: Hi Bruce, here is the whole dump (old DB): http://postgresql.1045698.n5.nabble.com/file/n4844725/dump.txt dump.txt Wow, that is interesting. I see this in the dump output: -- For binary upgrade, must preserve relfilenodes SELECT

Re: [HACKERS] pg_upgrade automatic testing

2011-09-27 Thread Bruce Momjian
Tom Lane wrote: Bruce Momjian br...@momjian.us writes: I propose I just remove the 8.4 test and always allow toast table names not to match --- the oids are still checked and are preserved. +1. You'll still make the check for non-toast tables, of course? Yes, only toast tables will

[HACKERS] pg_regress input/output directory option

2011-09-27 Thread Michael Paquier
Hi all, Why are there no options in_regress to specify the directory where input and output data are located? Such options would bring more flexibility when running regressions without make check/installcheck for an external application. Is there a particular reason for that? Or do you think that