Re: [HACKERS] Trust intermediate CA for client certificates

2013-03-18 Thread Ian Pilcher
On 03/18/2013 12:07 AM, Craig Ringer wrote: So this problem is verified. Thanks for taking the time to look into this. Good to know I'm not crazy. What we need to happen instead is for root.crt to contain only the trusted certificates and have a *separate* file or directory for intermediate

Re: [HACKERS] Trust intermediate CA for client certificates

2013-03-18 Thread Craig Ringer
On 03/18/2013 01:07 PM, Craig Ringer wrote: System wide installation of the root may allow OpenSSL to discover it and use it for verification back to the root without having to trust it to sign clients. I'll do some more checking to see if this is possible with how Pg uses OpenSSL but I'm

Re: [HACKERS] Trust intermediate CA for client certificates

2013-03-18 Thread Craig Ringer
On 03/18/2013 02:27 PM, Ian Pilcher wrote: On 03/18/2013 12:07 AM, Craig Ringer wrote: So this problem is verified. * Trusted certificates - What currently goes in the (unfortunately named) root.crt file. Well, a little unfortunate. It contains roots of *client authentication* trust, which

Re: [HACKERS] Patch to add regression tests for SCHEMA

2013-03-18 Thread robins
Thanks Alvaro. Since the tests were running fine, I didn't bother with elaborate names, but since you're concerned guess I'll make that change and re-submit. And yes, I've already submitted (to Commitfest) another patch related to regression tests for SEQUENCE. Would submit the SCHEMA patch once

Re: [HACKERS] Improving avg performance for numeric

2013-03-18 Thread Pavel Stehule
2013/3/16 Hadi Moshayedi h...@moshayedi.net: Revisiting: http://www.postgresql.org/message-id/45661be7.4050...@paradise.net.nz I think the reasons which the numeric average was slow were: (1) Using Numeric for count, which is slower than int8 to increment, (2) Constructing/deconstructing

Re: [HACKERS] Improving avg performance for numeric

2013-03-18 Thread Hadi Moshayedi
Hi Pavel, Thanks a lot for your feedback. I'll work more on this patch this week, and will send a more complete patch later this week. I'll also try to see how much is the speed up of this method for other types. Thanks, -- Hadi On Mon, Mar 18, 2013 at 10:36 AM, Pavel Stehule

Re: [HACKERS] Strange Windows problem, lock_timeout test request

2013-03-18 Thread Boszormenyi Zoltan
2013-03-18 06:47 keltezéssel, Tom Lane írta: Boszormenyi Zoltan z...@cybertec.at writes: The volatile marking shouldn't even be necessary there. The signal handler doesn't writes to it, only the main code. Well, (a) that's not the case in the patch as committed, and (b) even if it were true,

Re: [HACKERS] Patch to add regression tests for SCHEMA

2013-03-18 Thread robins
Hi, Attached is an updated patch that uses better schema / role names. -- Robins Tharakan On 18 March 2013 12:59, robins thara...@gmail.com wrote: Thanks Alvaro. Since the tests were running fine, I didn't bother with elaborate names, but since you're concerned guess I'll make that change

Re: [HACKERS] Trust intermediate CA for client certificates

2013-03-18 Thread Stephen Frost
Craig, all, * Craig Ringer (cr...@2ndquadrant.com) wrote: PROBLEM VERIFIED Let me just say ugh. I've long wondered why we have things set up in such a way that the whole chain has to be in one file, but it didn't occur to me that it'd actually end up causing this issue. In some ways, I really

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Simon Riggs
On 18 March 2013 00:50, Greg Smith g...@2ndquadrant.com wrote: On 3/17/13 1:41 PM, Simon Riggs wrote: So I'm now moving towards commit using a CRC algorithm. I'll put in a feature to allow algorithm be selected at initdb time, though that is mainly a convenience to allow us to more easily do

Re: [HACKERS] Strange Windows problem, lock_timeout test request

2013-03-18 Thread Tom Lane
Boszormenyi Zoltan z...@cybertec.at writes: How about the attached patch over current GIT? In other words, why I am wrong with this idea? Because it's wrong. Removing volatile means that the compiler is permitted to optimize away stores (and fetches!) on the basis of their being unnecessary

Re: [HACKERS] in-catalog Extension Scripts and Control parameters (templates?)

2013-03-18 Thread Dimitri Fontaine
Alvaro Herrera alvhe...@2ndquadrant.com writes: Here's a rebased version; there were some merge conflicts with master. Thanks! I also fixed some compiler warnings. I haven't reviewed the patch in any detail yet. One thing that jump at me from the code style perspective is the strange way

Re: [HACKERS] Improving avg performance for numeric

2013-03-18 Thread Pavel Stehule
Hello I played with sum(numeric) optimization Now it is based on generic numeric_add function - this code is relative old - now we can design aggregates with internal transition buffers, and probably we can do this work more effective. I just removed useles palloc/free operations and I got a

[HACKERS] pg_upgrade segfaults when given an invalid PGSERVICE value

2013-03-18 Thread Steve Singer
If you try running pg_upgrade with the PGSERVICE environment variable set to some invalid/non-existent service pg_upgrade segfaults Program received signal SIGSEGV, Segmentation fault. 0x0040bdd1 in check_pghost_envvar () at server.c:304 304 for (option = start;

Re: [HACKERS] Materialized view assertion failure in HEAD

2013-03-18 Thread Tom Lane
I wrote: BTW, is there a really solid reason why a matview couldn't be allowed to have OIDs on demand, and thereby dodge this whole problem? I'm thinking that the analogy to regular views not having OIDs is not a very good argument, because certainly matview rows are going to need all the

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Bruce Momjian
On Sun, Mar 17, 2013 at 05:50:11PM -0700, Greg Smith wrote: As long as the feature is off by default, so that people have to turn it on to hit the biggest changed code paths, the exposure to potential bugs doesn't seem too bad. New WAL data is no fun, but it's not like this hasn't happened

Re: [HACKERS] transforms

2013-03-18 Thread Josh Berkus
On 03/13/2013 09:54 AM, Dimitri Fontaine wrote: Peter Eisentraut pete...@gmx.net writes: At run time, this will sort itself out, because all the required modules will be loaded. The problem is when you create the glue extension and haven't invoked any code from any of the dependent extension

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-18 Thread Fujii Masao
On Sun, Mar 17, 2013 at 9:24 PM, Michael Paquier michael.paqu...@gmail.com wrote: Please find attached the patches wanted: - 20130317_dump_only_valid_index.patch, a 1-line patch that makes pg_dump not take a dump of invalid indexes. This patch can be backpatched to 9.0. Don't indisready and

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Pavel Stehule
2013/3/18 Bruce Momjian br...@momjian.us: On Sun, Mar 17, 2013 at 05:50:11PM -0700, Greg Smith wrote: As long as the feature is off by default, so that people have to turn it on to hit the biggest changed code paths, the exposure to potential bugs doesn't seem too bad. New WAL data is no fun,

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-18 Thread Fujii Masao
On Wed, Mar 13, 2013 at 9:04 PM, Michael Paquier michael.paqu...@gmail.com wrote: I have been working on improving the code of the 2 patches: 1) reltoastidxid removal: snip - Fix a bug with pg_dump and binary upgrade. One valid index is necessary for a given toast relation. Is this bugfix

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Simon Riggs
On 18 March 2013 17:52, Bruce Momjian br...@momjian.us wrote: On Sun, Mar 17, 2013 at 05:50:11PM -0700, Greg Smith wrote: As long as the feature is off by default, so that people have to turn it on to hit the biggest changed code paths, the exposure to potential bugs doesn't seem too bad. New

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Stephen Frost
* Bruce Momjian (br...@momjian.us) wrote: With a potential 10-20% overhead, I am unclear who would enable this at initdb time. I'd expect that quite a few people would, myself included on a brand new DB that I didn't have any reason to think would need to be super-performant. I assume a user

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Josh Berkus
With a potential 10-20% overhead, I am unclear who would enable this at initdb time. People who know they have a chronic issue with bad disks/cards/drivers would. Or anyone with enough machines that IO corruption is an operational concern worth more than 10% overhead. Or, in a word: Heroku,

Re: [HACKERS] Materialized view assertion failure in HEAD

2013-03-18 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: I wrote: BTW, is there a really solid reason why a matview couldn't be allowed to have OIDs on demand, and thereby dodge this whole problem? I'm thinking that the analogy to regular views not having OIDs is not a very good argument, because certainly

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Jeff Davis
On Mon, 2013-03-18 at 13:52 -0400, Bruce Momjian wrote: In fact, this feature is going to need pg_upgrade changes to detect from pg_controldata that the old/new clusters have the same checksum setting. I believe that has been addressed in the existing patch. Let me know if you see any

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Jeff Davis
On Sun, 2013-03-17 at 22:26 -0700, Daniel Farina wrote: as long as I am able to turn them off easily To be clear: you don't get the performance back by doing ignore_checksum_failure = on. You only get around the error itself, which allows you to dump/reload the good data. Regards, Jeff

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Bruce Momjian
On Mon, Mar 18, 2013 at 11:42:23AM -0700, Jeff Davis wrote: On Mon, 2013-03-18 at 13:52 -0400, Bruce Momjian wrote: In fact, this feature is going to need pg_upgrade changes to detect from pg_controldata that the old/new clusters have the same checksum setting. I believe that has been

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Bruce Momjian
On Mon, Mar 18, 2013 at 06:24:37PM +, Simon Riggs wrote: On 18 March 2013 17:52, Bruce Momjian br...@momjian.us wrote: On Sun, Mar 17, 2013 at 05:50:11PM -0700, Greg Smith wrote: As long as the feature is off by default, so that people have to turn it on to hit the biggest changed code

Re: [HACKERS] Re: Doc patch making firm recommendation for setting the value of commit_delay

2013-03-18 Thread Bruce Momjian
On Fri, Mar 15, 2013 at 05:47:30PM -0400, Tom Lane wrote: Noah Misch n...@leadboat.com writes: I'm marking this patch Ready for Committer, qualified with a recommendation to adopt only the wal.sgml changes. I've committed this along with some further wordsmithing. I kept Peter's

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Simon Riggs
On 18 March 2013 19:02, Jeff Davis pg...@j-davis.com wrote: On Sun, 2013-03-17 at 22:26 -0700, Daniel Farina wrote: as long as I am able to turn them off easily To be clear: you don't get the performance back by doing ignore_checksum_failure = on. You only get around the error itself, which

Re: [HACKERS] JSON Function Bike Shedding

2013-03-18 Thread Andrew Dunstan
On 03/01/2013 11:09 AM, Merlin Moncure wrote: On Fri, Feb 22, 2013 at 11:50 AM, David E. Wheeler da...@justatheory.com wrote: On Feb 22, 2013, at 9:37 AM, Robert Haas robertmh...@gmail.com wrote: What I think is NOT tolerable is choosing a set of short but arbitrary names which are different

Re: [HACKERS] Materialized view assertion failure in HEAD

2013-03-18 Thread Tom Lane
Kevin Grittner kgri...@ymail.com writes: Tom Lane t...@sss.pgh.pa.us wrote: [ why not allow matviews to have OID columns? ] An oid column in a materialized view will not be significantly more stable than its ctid.  The same logical row could easily have a different OID on a REFRESH or even

[HACKERS] machine-parseable object descriptions

2013-03-18 Thread Alvaro Herrera
For Dimitri's patch to add support for dropped objects in event triggers, there's an open question about how to report objects that are being dropped in a tabular format. What I proposed last had three columns: (type, schema, identity). The type is a description of the object class; I propose

Re: [HACKERS] JSON Function Bike Shedding

2013-03-18 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: I've been sitting here for a while mulling none too happily over the debate on the names for the proposed JSON extraction functions. I haven't really been happy with any of the suggestions, much, not least my own original function names which were

Re: [HACKERS] JSON Function Bike Shedding

2013-03-18 Thread Josh Berkus
On 03/18/2013 12:29 PM, Andrew Dunstan wrote: One wrinkle in this picture is the variadic forms of extraction which don't lend themselves nicely to use with an operator. We could decide to do away with those altogether, or come up with a better name. I'm loath to use json_path since it's a

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Greg Smith
On 3/18/13 10:52 AM, Bruce Momjian wrote: With a potential 10-20% overhead, I am unclear who would enable this at initdb time. If you survey people who are running PostgreSQL on cloud hardware, be it Amazon's EC2 or similar options from other vendors, you will find a high percentage of them

Re: [HACKERS] machine-parseable object descriptions

2013-03-18 Thread Tom Lane
Alvaro Herrera alvhe...@2ndquadrant.com writes: For Dimitri's patch to add support for dropped objects in event triggers, there's an open question about how to report objects that are being dropped in a tabular format. What I proposed last had three columns: (type, schema, identity). The

Re: [HACKERS] machine-parseable object descriptions

2013-03-18 Thread Dimitri Fontaine
Alvaro Herrera alvhe...@2ndquadrant.com writes: For Dimitri's patch to add support for dropped objects in event triggers, there's an open question about how to report objects that are being dropped in a tabular format. What I proposed last had three columns: (type, schema, identity). The

Re: [HACKERS] Materialized view assertion failure in HEAD

2013-03-18 Thread Kevin Grittner
Tom Lane t...@sss.pgh.pa.us wrote: Kevin Grittner kgri...@ymail.com writes: Tom Lane t...@sss.pgh.pa.us wrote: [ why not allow matviews to have OID columns? ] An oid column in a materialized view will not be significantly more stable than its ctid.  The same logical row could easily have a

Re: [HACKERS] Trust intermediate CA for client certificates

2013-03-18 Thread Ian Pilcher
On 03/18/2013 02:01 AM, Craig Ringer wrote: This appears to match Ian's description of having a validation-only cert list and a separate list of certs used to verify clients. I'd like to follow Apache's model: Ready for some more good news? It's possible that I'm missing something, but Apache

Re: [HACKERS] Add some regression tests for SEQUENCE

2013-03-18 Thread Robins Tharakan
Hi, Please find an updated patch (reworked on the names of SEQUENCES / ROLES / SCHEMA etc.) Takes code-coverage of 'make check' for SEQUENCE to ~95%. -- Robins Tharakan On 16 March 2013 02:03, robins thara...@gmail.com wrote: Hi, I've added some regression tests for SEQUENCE. A cumulative

Re: [HACKERS] machine-parseable object descriptions

2013-03-18 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: I could also live with keeping the schema column as proposed, if people think it has a use, but letting it be redundant with a schema name included in the identity string. But it seems like a bad idea to try to shear schema off of identity. +1 Use case

Re: [HACKERS] Add some regression tests for SEQUENCE

2013-03-18 Thread Josh Kupershmidt
On Mon, Mar 18, 2013 at 3:10 PM, Robins Tharakan thara...@gmail.com wrote: Hi, Please find an updated patch (reworked on the names of SEQUENCES / ROLES / SCHEMA etc.) Takes code-coverage of 'make check' for SEQUENCE to ~95%. There is a typo difference between sequence.out and sequence.sql

Re: [HACKERS] Add some regression tests for SEQUENCE

2013-03-18 Thread Robins Tharakan
Duh. Apologies. That's what happens when you make that 1 last change. Please find an updated patch. -- Robins Tharakan On 19 March 2013 04:07, Josh Kupershmidt schmi...@gmail.com wrote: On Mon, Mar 18, 2013 at 3:10 PM, Robins Tharakan thara...@gmail.com wrote: Hi, Please find an

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-18 Thread Michael Paquier
On Tue, Mar 19, 2013 at 3:03 AM, Fujii Masao masao.fu...@gmail.com wrote: On Sun, Mar 17, 2013 at 9:24 PM, Michael Paquier michael.paqu...@gmail.com wrote: Please find attached the patches wanted: - 20130317_dump_only_valid_index.patch, a 1-line patch that makes pg_dump not take a dump of

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-18 Thread Michael Paquier
On Tue, Mar 19, 2013 at 3:24 AM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Mar 13, 2013 at 9:04 PM, Michael Paquier michael.paqu...@gmail.com wrote: I have been working on improving the code of the 2 patches: 1) reltoastidxid removal: snip - Fix a bug with pg_dump and binary

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-03-18 Thread Michael Paquier
On Tue, Mar 19, 2013 at 8:54 AM, Michael Paquier michael.paqu...@gmail.comwrote: On Tue, Mar 19, 2013 at 3:03 AM, Fujii Masao masao.fu...@gmail.comwrote: On Sun, Mar 17, 2013 at 9:24 PM, Michael Paquier michael.paqu...@gmail.com wrote: Please find attached the patches wanted: -

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Ants Aasma
On Mon, Mar 18, 2013 at 2:04 AM, Greg Smith g...@2ndquadrant.com wrote: On 3/15/13 5:32 AM, Ants Aasma wrote: Best case using the CRC32 instruction would be 6.8 bytes/cycle [1]. But this got me thinking about how to do this faster... [1]

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Daniel Farina
On Mon, Mar 18, 2013 at 1:31 PM, Greg Smith g...@2ndquadrant.com wrote: On 3/18/13 10:52 AM, Bruce Momjian wrote: With a potential 10-20% overhead, I am unclear who would enable this at initdb time. If you survey people who are running PostgreSQL on cloud hardware, be it Amazon's EC2 or

Re: [HACKERS] pg_upgrade segfaults when given an invalid PGSERVICE value

2013-03-18 Thread Bruce Momjian
On Mon, Mar 18, 2013 at 12:08:09PM -0400, Steve Singer wrote: If you try running pg_upgrade with the PGSERVICE environment variable set to some invalid/non-existent service pg_upgrade segfaults Program received signal SIGSEGV, Segmentation fault. 0x0040bdd1 in check_pghost_envvar ()

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Greg Smith
On 3/18/13 5:36 PM, Daniel Farina wrote: Clarification, because I think this assessment as delivered feeds some unnecessary FUD about EBS: EBS is quite reliable. Presuming that all noticed corruptions are strictly EBS's problem (that's quite a stretch), I'd say the defect rate falls somewhere

Re: [HACKERS] machine-parseable object descriptions

2013-03-18 Thread Darren Duncan
On 2013.03.18 1:03 PM, Alvaro Herrera wrote: For Dimitri's patch to add support for dropped objects in event triggers, there's an open question about how to report objects that are being dropped in a tabular format. Now that JSON is a built-in type with 9.2+, could we not perhaps use that to

[HACKERS] backward incompatible pg_basebackup and pg_receivexlog

2013-03-18 Thread Peter Eisentraut
pg_basebackup and pg_receivexlog from 9.3 won't work with earlier servers anymore. I wonder if this has been fully thought through. We have put in a lot of effort to make client programs compatible with many server versions as well as keeping the client/server protocol compatible across many

Re: [HACKERS] Enabling Checksums

2013-03-18 Thread Daniel Farina
On Mon, Mar 18, 2013 at 7:13 PM, Greg Smith g...@2ndquadrant.com wrote: I wasn't trying to flog EBS as any more or less reliable than other types of storage. What I was trying to emphasize, similarly to your quite a stretch comment, was the uncertainty involved when such deployments fail.

Re: [HACKERS] Optimizing pglz compressor

2013-03-18 Thread Daniel Farina
On Wed, Mar 6, 2013 at 6:32 AM, Joachim Wieland j...@mcknight.de wrote: On Tue, Mar 5, 2013 at 8:32 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: With these tweaks, I was able to make pglz-based delta encoding perform roughly as well as Amit's patch. Out of curiosity, do we know how

Re: [HACKERS] Trust intermediate CA for client certificates

2013-03-18 Thread Craig Ringer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/18/2013 08:55 PM, Stephen Frost wrote: Makes sense to me. I'm not particular about the names, but isn't this set of CAs generally considered intermediary? Eg: 'trusted', ' intermediate', etc? They are intermediary, but we're dealing with the

Re: [HACKERS] Trust intermediate CA for client certificates

2013-03-18 Thread Stephen Frost
Craig, * Craig Ringer (cr...@2ndquadrant.com) wrote: They are intermediary, but we're dealing with the case where trust and authorization are not the same thing. Trust stems from the trusted root in the SSL CA model, but that's a chain of trust for *identity* (authentication), not