Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-06-25 Thread Mark Kirkwood
On 25/06/13 15:56, Tom Lane wrote: Mark Kirkwood mark.kirkw...@catalyst.net.nz writes: One of the reasons for fewer reviewers than submitters, is that it is a fundamentally more difficult job. I've submitted a few patches in a few different areas over the years - however if I grab a patch on

Re: [HACKERS] fixing pg_ctl with relative paths

2013-06-25 Thread Hari Babu
On January 23, 2013 9:13 AM Josh Kupershmidt wrote: There have been some complaints[1][2] in the past about pg_ctl not playing nice with relative path specifications for the datadir. Here's a concise illustration: $ mkdir /tmp/mydata/ initdb /tmp/mydata/ $ cd /tmp/ $ pg_ctl -D ./mydata/

[HACKERS] converting datum to numeric

2013-06-25 Thread Szymon Guz
Hi, I've got a couple of questions. I was using numeric_out like this: DatumGetCString(DirectFunctionCall1(numeric_out, d)); Why do I have to use DirectFunctionCall1 instead of calling numeric_out? I was suggested to use numeric_send instead of numeric_out, however when changing the function

Re: [HACKERS] [RFC] Minmax indexes

2013-06-25 Thread Simon Riggs
On 25 June 2013 00:51, Bruce Momjian br...@momjian.us wrote: On Sat, Jun 15, 2013 at 11:39:23AM -0400, Tom Lane wrote: Simon Riggs si...@2ndquadrant.com writes: On 15 June 2013 00:01, Josh Berkus j...@agliodbs.com wrote: If we're going to start adding reloptions for specific table

Re: [HACKERS] Problem building in a directory shared from Mac to Ubuntu

2013-06-25 Thread Craig Ringer
On 06/25/2013 01:14 PM, Ashutosh Bapat wrote: Hi, I am observing a strange problem when I build latest PostgreSQL head on Ubuntu 12.04. I am running Ubuntu 12.04 as VM on Mac 10.7. The build directory points to a sub-directory of host directory shared from Mac to Ubuntu 12.04. shared how?

Re: [HACKERS] converting datum to numeric

2013-06-25 Thread Pavel Stehule
Hello 2013/6/25 Szymon Guz mabew...@gmail.com: Hi, I've got a couple of questions. I was using numeric_out like this: DatumGetCString(DirectFunctionCall1(numeric_out, d)); Why do I have to use DirectFunctionCall1 instead of calling numeric_out? numeric_out functions doesn't use C calling

Re: [HACKERS] Problem building in a directory shared from Mac to Ubuntu

2013-06-25 Thread Ashutosh Bapat
On Tue, Jun 25, 2013 at 12:03 PM, Craig Ringer cr...@2ndquadrant.comwrote: On 06/25/2013 01:14 PM, Ashutosh Bapat wrote: Hi, I am observing a strange problem when I build latest PostgreSQL head on Ubuntu 12.04. I am running Ubuntu 12.04 as VM on Mac 10.7. The build directory points to a

Re: [HACKERS] converting datum to numeric

2013-06-25 Thread Szymon Guz
On 25 June 2013 08:51, Pavel Stehule pavel.steh...@gmail.com wrote: Hello 2013/6/25 Szymon Guz mabew...@gmail.com: Hi, I've got a couple of questions. I was using numeric_out like this: DatumGetCString(DirectFunctionCall1(numeric_out, d)); Why do I have to use

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-06-25 Thread David Rowley
On Tue, Jun 25, 2013 at 3:56 PM, Tom Lane t...@sss.pgh.pa.us wrote: FWIW, a large part of the reason for the commitfest structure is that by reviewing patches, people can educate themselves about parts of the PG code that they don't know already, and thus become better qualified to do more

Re: [HACKERS] [9.4 CF 1] The Commitfest Slacker List

2013-06-25 Thread Brendan Jurd
On 25 June 2013 04:13, Joshua D. Drake j...@commandprompt.com wrote: On 06/24/2013 10:59 AM, Andres Freund wrote: On 2013-06-24 10:50:42 -0700, Josh Berkus wrote: This project is enormously stingy with giving credit to people. It's not like it costs us money, you know. I am all for

[HACKERS] PostgreSQL 9.3 latest dev snapshot

2013-06-25 Thread Misa Simic
Hi, Where we can find latest snapshot for 9.3 version? We have taken latest snapshot from http://ftp.postgresql.org/pub/snapshot/dev/ But it seems it is for 9.4 version... Thanks, Misa

Re: [HACKERS] Reduce maximum error in tuples estimation after vacuum.

2013-06-25 Thread Kyotaro HORIGUCHI
Hello, I have tried to reproduce the problem in different m/c's, but couldn't reproduce it. I have ran tests with default configuration. I think you had reproduced it. Output on Windows: --- postgres=# create table t (a int, b int); (snip) postgres=# select n_live_tup,

Re: [HACKERS] [Review] Add SPI_gettypmod() to return a field's typemod from a TupleDesc

2013-06-25 Thread Jeevan Chalke
Hi Mark, Is this the latest patch you are targeting for 9.4 CF1 ? I am going to review it. From the comment, here is one issue you need to resolve first: *** exec_eval_datum(PLpgSQL_execstate *estat *** 4386,4396 errmsg(record \%s\ has no field

Re: [HACKERS] proposal: enable new error fields in plpgsql (9.4)

2013-06-25 Thread Rushabh Lathia
Hi Pavel, I gone through the discussion over here and found that with this patch we enable the new error fields in plpgsql. Its a simple patch to expose the new error fields in plpgsql. Patch gets applied cleanly. make and make install too went smooth. make check was smooth too. Patch also

Re: [HACKERS] proposal: enable new error fields in plpgsql (9.4)

2013-06-25 Thread Pavel Stehule
2013/6/25 Rushabh Lathia rushabh.lat...@gmail.com: Hi Pavel, I gone through the discussion over here and found that with this patch we enable the new error fields in plpgsql. Its a simple patch to expose the new error fields in plpgsql. Patch gets applied cleanly. make and make install too

Re: [HACKERS] Add more regression tests for CREATE OPERATOR

2013-06-25 Thread Robins Tharakan
Thanks a ton Szymon (for a reminder on this one). As a coincidental turn of events, I have had to travel half way across the world and am without my personal laptop (without a linux distro etc.) and just recovering from a jet-lag now. I'll try to install a VM on a make-shift laptop and get

Re: [HACKERS] proposal: enable new error fields in plpgsql (9.4)

2013-06-25 Thread Rushabh Lathia
On Tue, Jun 25, 2013 at 2:41 PM, Pavel Stehule pavel.steh...@gmail.comwrote: 2013/6/25 Rushabh Lathia rushabh.lat...@gmail.com: Hi Pavel, I gone through the discussion over here and found that with this patch we enable the new error fields in plpgsql. Its a simple patch to expose the

Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division

2013-06-25 Thread Jeevan Chalke
On Tue, Jun 25, 2013 at 11:11 AM, Jeevan Chalke jeevan.cha...@enterprisedb.com wrote: Hi David, I hope this is the latest patch to review, right ? I am going to review it. I have gone through the discussion on this thread and I agree with Stephen Frost that it don't add much improvements

Re: [HACKERS] PostgreSQL 9.3 latest dev snapshot

2013-06-25 Thread Michael Paquier
On Tue, Jun 25, 2013 at 5:33 PM, Misa Simic misa.si...@gmail.com wrote: Hi, Where we can find latest snapshot for 9.3 version? We have taken latest snapshot from http://ftp.postgresql.org/pub/snapshot/dev/ But it seems it is for 9.4 version... 9.3 has moved to branch REL9_3_STABLE a couple

Re: [HACKERS] [PATCH] Fix conversion for Decimal arguments in plpython functions

2013-06-25 Thread Szymon Guz
On 25 June 2013 05:16, Steve Singer st...@ssinger.info wrote: One concern I have is that this patch makes pl/python functions involving numerics more than 3 times as slow as before. create temp table b(a numeric); insert into b select generate_series(1,1); create or replace function

Re: [HACKERS] proposal: enable new error fields in plpgsql (9.4)

2013-06-25 Thread Pavel Stehule
2013/6/25 Rushabh Lathia rushabh.lat...@gmail.com: On Tue, Jun 25, 2013 at 2:41 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2013/6/25 Rushabh Lathia rushabh.lat...@gmail.com: Hi Pavel, I gone through the discussion over here and found that with this patch we enable the new

Re: [HACKERS] [PATCH] Fix conversion for Decimal arguments in plpython functions

2013-06-25 Thread Szymon Guz
On 25 June 2013 05:16, Steve Singer st...@ssinger.info wrote: On 05/28/2013 04:41 PM, Szymon Guz wrote: Hi, I've got a patch. This is for a plpython enhancement. There is an item at the TODO list http://wiki.postgresql.org/**

Re: [HACKERS] patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]

2013-06-25 Thread Amit Kapila
On Monday, June 24, 2013 8:20 PM Tom Lane wrote: Amit Kapila amit.kap...@huawei.com writes: I will summarize the results, and if most of us feel that they are not good enough, then we can return this patch. Aside from the question of whether there's really any generally-useful

Re: [HACKERS] Naming of ORDINALITY column

2013-06-25 Thread Dean Rasheed
On 24 June 2013 04:29, Josh Berkus j...@agliodbs.com wrote: On 06/23/2013 08:00 PM, Andrew Gierth wrote: OK, let's try to cover all the bases here in one go. 1. Stick with ?column? as a warning flag that you're not supposed to be using this without aliasing it to something. How do I

Re: FILTER for aggregates [was Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division]

2013-06-25 Thread Dean Rasheed
On 24 June 2013 03:50, Tom Lane t...@sss.pgh.pa.us wrote: David Fetter da...@fetter.org writes: On Sun, Jun 23, 2013 at 07:44:26AM -0700, Kevin Grittner wrote: I think it is OK if that gets a syntax error. If that's the worst case I like this approach. I think reducing the usefulness of

Re: [HACKERS] Index on regexes

2013-06-25 Thread Heikki Linnakangas
On 13.06.2013 23:19, Alexander Korotkov wrote: Hackers, Attached patch contains opclass which demonstrates advantages of GIN additional information storing itself without other GIN improvements. It implements inversed task of regex indexing. It works so: you create index on regexes and search

Re: [HACKERS] [PATCH] Fix conversion for Decimal arguments in plpython functions

2013-06-25 Thread Ronan Dunklau
Concerning the efficiency problem, it should be noted that the latest 3.3 release of cpython introduces an accelerator for decimal data types, as a C-module. This module was previously available from the Python package index at: https://pypi.python.org/pypi/cdecimal/2.2 It may be overkill to try

Re: [HACKERS] [PATCH] Fix conversion for Decimal arguments in plpython functions

2013-06-25 Thread Szymon Guz
Well, I really don't like the idea of such a dependency. However it could be added as configuration option, so you could compile postgres with e.g. --with-cdecimal, and then it would be user dependent. Maybe it is a good idea for another patch. On 25 June 2013 14:23, Ronan Dunklau

[HACKERS] Hash partitioning.

2013-06-25 Thread Yuri Levinsky
Hi, Do we have any plans to implement Hash Partitioning, maybe I missing this feature? Sincerely yours, Yuri Levinsky, DBA Celltick Technologies Ltd., 32 Maskit St., Herzliya 46733, Israel Mobile: +972 54 6107703, Office: +972 9 9710239; Fax: +972 9 9710222 image002.jpg

Re: backend hangs at immediate shutdown (Re: [HACKERS] Back-branch update releases coming in a couple weeks)

2013-06-25 Thread MauMau
From: Alvaro Herrera alvhe...@2ndquadrant.com Yeah, I see that --- after removing that early exit, there are unwanted messages. And in fact there are some signals sent that weren't previously sent. Clearly we need something here: if we're in immediate shutdown handler, don't signal anyone

Re: [HACKERS] Possible bug in CASE evaluation

2013-06-25 Thread Andres Freund
On 2013-06-24 21:35:53 -0400, Noah Misch wrote: On Sat, Jun 22, 2013 at 04:54:50PM +0200, Andres Freund wrote: On 2013-06-21 16:45:28 +0200, Andres Freund wrote: On 2013-06-21 09:51:05 -0400, Noah Misch wrote: That being said, if we discover a simple-enough fix that performs well,

Re: [HACKERS] Possible bug in CASE evaluation

2013-06-25 Thread Pavel Stehule
2013/6/25 Andres Freund and...@2ndquadrant.com: On 2013-06-24 21:35:53 -0400, Noah Misch wrote: On Sat, Jun 22, 2013 at 04:54:50PM +0200, Andres Freund wrote: On 2013-06-21 16:45:28 +0200, Andres Freund wrote: On 2013-06-21 09:51:05 -0400, Noah Misch wrote: That being said, if we

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Bruce Momjian
On Tue, Jun 25, 2013 at 03:48:19PM +0300, Yuri Levinsky wrote: Hi, Do we have any plans to implement Hash Partitioning, maybe I missing this feature? You can do it by writing your own constraint and trigger functions that control the hashing. -- Bruce Momjian br...@momjian.us

Re: [HACKERS] PostgreSQL 9.3 latest dev snapshot

2013-06-25 Thread Fujii Masao
On Tue, Jun 25, 2013 at 6:33 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, Jun 25, 2013 at 5:33 PM, Misa Simic misa.si...@gmail.com wrote: Hi, Where we can find latest snapshot for 9.3 version? We have taken latest snapshot from http://ftp.postgresql.org/pub/snapshot/dev/

Re: [HACKERS] Patch for fail-back without fresh backup

2013-06-25 Thread Sawada Masahiko
On Tue, Jun 25, 2013 at 12:19 PM, Pavan Deolasee pavan.deola...@gmail.com wrote: On Mon, Jun 24, 2013 at 7:17 PM, Sawada Masahiko sawada.m...@gmail.com wrote: [Server] standby_name = 'slave1' synchronous_transfer = commit wal_sender_timeout = 30 [Server]

Re: [HACKERS] PostgreSQL 9.3 latest dev snapshot

2013-06-25 Thread Michael Paquier
On 2013/06/25, at 22:23, Fujii Masao masao.fu...@gmail.com wrote: On Tue, Jun 25, 2013 at 6:33 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, Jun 25, 2013 at 5:33 PM, Misa Simic misa.si...@gmail.com wrote: Hi, Where we can find latest snapshot for 9.3 version? We have

Re: FILTER for aggregates [was Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division]

2013-06-25 Thread Tom Lane
Dean Rasheed dean.a.rash...@gmail.com writes: On 24 June 2013 03:50, Tom Lane t...@sss.pgh.pa.us wrote: Going on the same principle, we could probably let FILTER be an unreserved keyword while FILTER_FOLLOWED_BY_PAREN could be a type_func_name_keyword. (I've not tried this though.) I've not

Re: FILTER for aggregates [was Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division]

2013-06-25 Thread Pavel Stehule
2013/6/25 Tom Lane t...@sss.pgh.pa.us: Dean Rasheed dean.a.rash...@gmail.com writes: On 24 June 2013 03:50, Tom Lane t...@sss.pgh.pa.us wrote: Going on the same principle, we could probably let FILTER be an unreserved keyword while FILTER_FOLLOWED_BY_PAREN could be a type_func_name_keyword.

Re: [HACKERS] proposal: enable new error fields in plpgsql (9.4)

2013-06-25 Thread Pavel Stehule
Hello 2013/6/25 Rushabh Lathia rushabh.lat...@gmail.com: Hi Pavel, I gone through the discussion over here and found that with this patch we enable the new error fields in plpgsql. Its a simple patch to expose the new error fields in plpgsql. Patch gets applied cleanly. make and make

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Yuri Levinsky
Bruce, Many thanks. According to PostgreSQL documentation it's only range and list partitions are supported. My question is: when I am following your advice, is PostgreSQL will do partitioning pruning on select? My expectation is: I divided my table on 128 hash partitions according let's say

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Bruce Momjian
On Tue, Jun 25, 2013 at 05:19:47PM +0300, Yuri Levinsky wrote: Bruce, Many thanks. According to PostgreSQL documentation it's only range and list partitions are supported. My question is: when I am following your advice, is PostgreSQL will do partitioning pruning on select? My expectation is:

Re: FILTER for aggregates [was Re: [HACKERS] Department of Redundancy Department: makeNode(FuncCall) division]

2013-06-25 Thread Robert Haas
On Sun, Jun 23, 2013 at 10:50 PM, Tom Lane t...@sss.pgh.pa.us wrote: David Fetter da...@fetter.org writes: On Sun, Jun 23, 2013 at 07:44:26AM -0700, Kevin Grittner wrote: I think it is OK if that gets a syntax error. If that's the worst case I like this approach. I think reducing the

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Robert Haas
On Tue, Jun 25, 2013 at 9:21 AM, Bruce Momjian br...@momjian.us wrote: On Tue, Jun 25, 2013 at 03:48:19PM +0300, Yuri Levinsky wrote: Hi, Do we have any plans to implement Hash Partitioning, maybe I missing this feature? You can do it by writing your own constraint and trigger functions

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Bruce Momjian
On Tue, Jun 25, 2013 at 11:02:40AM -0400, Robert Haas wrote: On Tue, Jun 25, 2013 at 9:21 AM, Bruce Momjian br...@momjian.us wrote: On Tue, Jun 25, 2013 at 03:48:19PM +0300, Yuri Levinsky wrote: Hi, Do we have any plans to implement Hash Partitioning, maybe I missing this feature?

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-25 Thread Andrew Dunstan
On 06/24/2013 07:24 PM, Cédric Villemain wrote: Le mardi 25 juin 2013 00:18:26, Andrew Dunstan a écrit : On 06/24/2013 04:02 PM, Cédric Villemain wrote: WIth extension, we do have to set VPATH explicitely if we want to use VPATH (note that contribs/extensions must not care that postgresql has

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-25 Thread Cédric Villemain
Le mardi 25 juin 2013 17:18:51, Andrew Dunstan a écrit : On 06/24/2013 07:24 PM, Cédric Villemain wrote: Le mardi 25 juin 2013 00:18:26, Andrew Dunstan a écrit : On 06/24/2013 04:02 PM, Cédric Villemain wrote: WIth extension, we do have to set VPATH explicitely if we want to use VPATH

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-25 Thread Heikki Linnakangas
On 25.06.2013 01:24, Alexander Korotkov wrote: On Wed, Jun 19, 2013 at 1:21 AM, Alexander Korotkovaekorot...@gmail.comwrote: On Mon, Jun 17, 2013 at 10:27 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: That has some obvious limitations. First of all, you can run out of memory. Yes,

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Robert Haas
On Tue, Jun 25, 2013 at 11:06 AM, Bruce Momjian br...@momjian.us wrote: Not really. Constraint exclusion won't kick in for a constraint like CHECK (hashme(a) % 16 == 3) and a WHERE clause of the form a = 42. Uh, I thought we checked the constant against every CHECK constraint and only

Re: [HACKERS] Fix pgstattuple/pgstatindex to use regclass-type as the argument

2013-06-25 Thread Robert Haas
On Thu, Jun 20, 2013 at 2:32 PM, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Jun 20, 2013 at 11:43 AM, Satoshi Nagayasu sn...@uptime.jp wrote: (2013/06/17 4:02), Fujii Masao wrote: On Sat, Mar 9, 2013 at 3:23 PM, Satoshi Nagayasu sn...@uptime.jp wrote: It is obviously easy to keep two

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Bruce Momjian
On Tue, Jun 25, 2013 at 11:15:24AM -0400, Robert Haas wrote: On Tue, Jun 25, 2013 at 11:06 AM, Bruce Momjian br...@momjian.us wrote: Not really. Constraint exclusion won't kick in for a constraint like CHECK (hashme(a) % 16 == 3) and a WHERE clause of the form a = 42. Uh, I thought we

Re: [HACKERS] C++ compiler

2013-06-25 Thread Joshua D. Drake
On 06/24/2013 09:16 PM, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: Right. I don't think there are any C features we want to avoid; are there any? We're avoiding C99-and-later features that are not in C89, such as // for comments, as well as more useful things. It might be time

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Robert Haas
On Tue, Jun 25, 2013 at 11:45 AM, Bruce Momjian br...@momjian.us wrote: On Tue, Jun 25, 2013 at 11:15:24AM -0400, Robert Haas wrote: On Tue, Jun 25, 2013 at 11:06 AM, Bruce Momjian br...@momjian.us wrote: Not really. Constraint exclusion won't kick in for a constraint like CHECK (hashme(a)

Re: [HACKERS] pgbench --startup option

2013-06-25 Thread Robert Haas
On Thu, Jun 20, 2013 at 1:46 PM, Jeff Janes jeff.ja...@gmail.com wrote: I've fixed a conflict, and I've removed extraneous semicolons from the C. I've left in the fixing of some existing bad indenting in the existing code, which is not strictly related to my change. OK, I like this idea a

Re: [HACKERS] Support for REINDEX CONCURRENTLY

2013-06-25 Thread Fujii Masao
On Tue, Jun 25, 2013 at 8:15 AM, Michael Paquier michael.paqu...@gmail.com wrote: Patch updated according to comments. Thanks for updating the patch! When I ran VACUUM FULL, I got the following error. ERROR: attempt to apply a mapping to unmapped relation 16404 STATEMENT: vacuum full; Could

Re: [HACKERS] refresh materialized view concurrently

2013-06-25 Thread Robert Haas
On Fri, Jun 21, 2013 at 5:20 AM, Hitoshi Harada umi.tan...@gmail.com wrote: If I don't miss something, the requirement for the CONCURRENTLY option is to allow simple SELECT reader to read the matview concurrently while the view is populating the new data, and INSERT/UPDATE/DELETE and SELECT FOR

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: I looked at predtest.c but I can't see how we accept = and = ranges, but not CHECK (a % 16 == 3). It is the '%' operator? I am not sure why the hashme() function is there. Wouldn't it work if hashme() was an immutable function? No. Robert's

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Yuri Levinsky
Guys, I am sorry for taking your time. The reason for my question is: As former Oracle DBA and now simple beginner PostgreSQL DBA I would like to say: the current partitioning mechanism might be improved. Sorry, it seems to me far behind yesterday requirements. As model for improvement the Oracle

Re: [HACKERS] [PATCH] add long options to pgbench (submission 1)

2013-06-25 Thread Robert Haas
On Thu, Jun 20, 2013 at 9:17 AM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Thu, Jun 20, 2013 at 9:59 AM, Fabien COELHO coe...@cri.ensmp.fr wrote: Please fix that and re-send the patch. Find attached diff wrt current master. Thanks. I would like to solicit opinions on whether

Re: [HACKERS] [PATCH] add long options to pgbench (submission 1)

2013-06-25 Thread Andres Freund
On 2013-06-25 12:11:06 -0400, Robert Haas wrote: On Thu, Jun 20, 2013 at 9:17 AM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Thu, Jun 20, 2013 at 9:59 AM, Fabien COELHO coe...@cri.ensmp.fr wrote: Please fix that and re-send the patch. Find attached diff wrt current master.

Re: [HACKERS] isolationtester and 'specs' subdirectory

2013-06-25 Thread Robert Haas
On Thu, Jun 20, 2013 at 7:10 PM, Josh Kupershmidt schmi...@gmail.com wrote: I eventually tracked down the cause of this failure to a trailing ':' in my $LIBRARY_PATH, which causes gcc to look inside the current directory for a 'specs' file [1] among other things. Although I probably don't need

Re: [HACKERS] [PATCH] add long options to pgbench (submission 1)

2013-06-25 Thread Alvaro Herrera
Robert Haas escribió: On Thu, Jun 20, 2013 at 9:17 AM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Thu, Jun 20, 2013 at 9:59 AM, Fabien COELHO coe...@cri.ensmp.fr wrote: Please fix that and re-send the patch. Find attached diff wrt current master. Thanks. I would like to

Re: [HACKERS] [PATCH] add long options to pgbench (submission 1)

2013-06-25 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: I would like to solicit opinions on whether this is a good idea. I understand that the patch author thinks it's a good idea, and I don't have a strong position either way. But I want to hear what other people think. If it makes pgbench more

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Bruce Momjian
On Tue, Jun 25, 2013 at 12:08:34PM -0400, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: I looked at predtest.c but I can't see how we accept = and = ranges, but not CHECK (a % 16 == 3). It is the '%' operator? I am not sure why the hashme() function is there. Wouldn't it work if

Re: [HACKERS] pluggable compression support

2013-06-25 Thread Robert Haas
On Thu, Jun 20, 2013 at 8:09 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-06-15 12:20:28 +0200, Andres Freund wrote: On 2013-06-14 21:56:52 -0400, Robert Haas wrote: I don't think we need it. I think what we need is to decide is which algorithm is legally OK to use. And then put

Re: [HACKERS] [PATCH] add long options to pgbench (submission 1)

2013-06-25 Thread Robert Haas
On Tue, Jun 25, 2013 at 12:17 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: I would like to solicit opinions on whether this is a good idea. I understand that the patch author thinks it's a good idea, and I don't have a strong position either way. But I

Re: [HACKERS] pg_filedump 9.3: checksums (and a few other fixes)

2013-06-25 Thread Jeff Davis
On Mon, 2013-06-24 at 20:34 -0400, Josh Kupershmidt wrote: This patch is in the current CommitFest, does it still need to be reviewed? If so, I notice that the version in pgfoundry's CVS is rather different than the version the patch seems to have been built against (presumably the

Re: [HACKERS] Improvement of checkpoint IO scheduler for stable transaction responses

2013-06-25 Thread Heikki Linnakangas
On 21.06.2013 11:29, KONDO Mitsumasa wrote: I took results of my separate patches and original PG. * Result of DBT-2 | TPS 90%tile Average Maximum -- original_0.7 | 3474.62 18.348328 5.739 36.977713 original_1.0 | 3469.03 18.637865 5.842

[HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Josh Berkus
Hackers, I'd like to take a straw poll here on how we should acknowledge reviewers. Please answer the below with your thoughts, either on-list or via private email. How should reviewers get credited in the release notes? a) not at all b) in a single block titled Reviewers for this version at

Re: [HACKERS] Clean switchover

2013-06-25 Thread Fujii Masao
On Mon, Jun 24, 2013 at 3:41 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-06-14 04:56:15 +0900, Fujii Masao wrote: On Wed, Jun 12, 2013 at 9:48 PM, Stephen Frost sfr...@snowman.net wrote: * Magnus Hagander (mag...@hagander.net) wrote: On Wed, Jun 12, 2013 at 1:48 PM, Andres Freund

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Heikki Linnakangas
On 25.06.2013 20:17, Josh Berkus wrote: Hackers, I'd like to take a straw poll here on how we should acknowledge reviewers. Please answer the below with your thoughts, either on-list or via private email. How should reviewers get credited in the release notes? a) not at all b) in a single

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Erik Rijkers
On Tue, June 25, 2013 19:17, Josh Berkus wrote: How should reviewers get credited in the release notes? b) in a single block titled Reviewers for this version at the bottom. Should there be a criteria for a creditable review? b) yes, they have to do more than it compiles Should reviewers

Re: [HACKERS] request a new feature in fuzzystrmatch

2013-06-25 Thread Liming Hu
On Mon, Jun 24, 2013 at 6:02 PM, Joe Conway m...@joeconway.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/14/2013 12:08 PM, Liming Hu wrote: I have implemented the code according to Joe's suggestion, and put the code at:

Re: [HACKERS] Review: Patch to compute Max LSN of Data Pages

2013-06-25 Thread Andres Freund
Hi, On 2013-06-16 17:19:49 -0700, Josh Berkus wrote: Amit posted a new version of this patch on January 23rd. But last comment on it by Tom is not sure everyone wants this. https://commitfest.postgresql.org/action/patch_view?id=905 ... so, what's the status of this patch? That comment

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Andres Freund
On 2013-06-25 10:17:07 -0700, Josh Berkus wrote: How should reviewers get credited in the release notes? a) not at all b) in a single block titled Reviewers for this version at the bottom. c) on the patch they reviewed, for each patch b). If the review was substantial enough the reviewer

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Josh Berkus
On 06/25/2013 10:46 AM, Andres Freund wrote: Not sure. Seems like it might be a way to spend a lot of effort without achieving all that much. But I can also imagine that it feels nice and encourages a casual reviewer/contributor. So it's either b) or c). Although I'd perhaps exclude regular

Re: [HACKERS] INTERVAL overflow detection is terribly broken

2013-06-25 Thread Rok Kralj
So, any insights on these problems? They might not be critical, but might be silently corrupting someone's data. 2013/6/23 Rok Kralj rok.kr...@gmail.com Hi, after studying ITERVAL and having a long chat with RhoidumToad and StuckMojo on #postgresql, I am presenting you 3 bugs regarding

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Joshua D. Drake
On 06/25/2013 10:17 AM, Josh Berkus wrote: Hackers, I'd like to take a straw poll here on how we should acknowledge reviewers. Please answer the below with your thoughts, either on-list or via private email. How should reviewers get credited in the release notes? a) not at all b) in a

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Alvaro Herrera
Yuri Levinsky escribió: As former Oracle DBA and now simple beginner PostgreSQL DBA I would like to say: the current partitioning mechanism might be improved. Sorry, it seems to me far behind yesterday requirements. I don't think you'll find anybody that disagrees with this. -- Álvaro

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Claudio Freire
On Tue, Jun 25, 2013 at 12:55 PM, Robert Haas robertmh...@gmail.com wrote: Let me back up a minute. You told the OP that he could make hash partitioning by writing his own constraint and trigger functions. I think that won't work. But I'm happy to be proven wrong. Do you have an example

Re: [HACKERS] GIN improvements part 3: ordering in index

2013-06-25 Thread Alexander Korotkov
On Tue, Jun 25, 2013 at 7:31 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 25.06.2013 01:24, Alexander Korotkov wrote: On Wed, Jun 19, 2013 at 1:21 AM, Alexander Korotkovaekorot...@gmail.com **wrote: On Mon, Jun 17, 2013 at 10:27 PM, Heikki Linnakangas hlinnakan...@vmware.com

Re: [HACKERS] pgbench --startup option

2013-06-25 Thread Fabien COELHO
OK, I like this idea a lot, but I have a question. Right now, to use this, you have to supply the startup SQL on the command line. And that could definitely be useful. But ISTM that you might also want to take the startup SQL from a file, and indeed you might well want to include

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Andres Freund
On 2013-06-25 11:04:38 -0700, Joshua D. Drake wrote: a) not at all b) in a single block titled Reviewers for this version at the bottom. c) on the patch they reviewed, for each patch C. The idea that reviewers are somehow less than authors is rather disheartening. It's not about the

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Andrew Dunstan
On 06/25/2013 01:17 PM, Josh Berkus wrote: Hackers, I'd like to take a straw poll here on how we should acknowledge reviewers. Please answer the below with your thoughts, either on-list or via private email. How should reviewers get credited in the release notes? a) not at all b) in a

Re: [HACKERS] pluggable compression support

2013-06-25 Thread Andres Freund
On 2013-06-25 12:22:31 -0400, Robert Haas wrote: On Thu, Jun 20, 2013 at 8:09 PM, Andres Freund and...@2ndquadrant.com wrote: On 2013-06-15 12:20:28 +0200, Andres Freund wrote: On 2013-06-14 21:56:52 -0400, Robert Haas wrote: I don't think we need it. I think what we need is to decide is

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Claudio Freire
On Tue, Jun 25, 2013 at 2:17 PM, Josh Berkus j...@agliodbs.com wrote: How should reviewers get credited in the release notes? c) on the patch they reviewed, for each patch This not only makes sense, it also lets people reading release notes know there's been a review, and how thorough it was. I

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Josh Berkus
On 06/25/2013 11:26 AM, Andres Freund wrote: On 2013-06-25 11:04:38 -0700, Joshua D. Drake wrote: a) not at all b) in a single block titled Reviewers for this version at the bottom. c) on the patch they reviewed, for each patch C. The idea that reviewers are somehow less than authors is

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Joshua D. Drake
On 06/25/2013 11:26 AM, Andres Freund wrote: On 2013-06-25 11:04:38 -0700, Joshua D. Drake wrote: a) not at all b) in a single block titled Reviewers for this version at the bottom. c) on the patch they reviewed, for each patch C. The idea that reviewers are somehow less than authors is

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Christopher Browne
On Tue, Jun 25, 2013 at 12:08 PM, Yuri Levinsky yu...@celltick.com wrote: Guys, I am sorry for taking your time. The reason for my question is: As former Oracle DBA and now simple beginner PostgreSQL DBA I would like to say: the current partitioning mechanism might be improved. Sorry, it

Re: [HACKERS] pluggable compression support

2013-06-25 Thread Josh Berkus
On 06/25/2013 11:42 AM, Andres Freund wrote: True. So, how do we proceed on that? The ASF decided it was safe to use lz4 in cassandra. Does anybody have contacts over there? Btw, I have the feeling we hold this topic to a higher standard wrt patent issues than other work in postgres...

Re: [HACKERS] [PATCH] add long options to pgbench (submission 1)

2013-06-25 Thread Fabien COELHO
I think I'd like to quibble with some of the names a bit, though. That is a good idea, because I'm not a native English speaker and I was not so sure for many options. The patch adds --fill-factor, but I think we should spell it without the hyphen: --fillfactor. Fine with me. I think

Re: [HACKERS] pluggable compression support

2013-06-25 Thread Andres Freund
On 2013-06-25 12:08:22 -0700, Josh Berkus wrote: On 06/25/2013 11:42 AM, Andres Freund wrote: True. So, how do we proceed on that? The ASF decided it was safe to use lz4 in cassandra. Does anybody have contacts over there? Btw, I have the feeling we hold this topic to a higher

Re: [HACKERS] pluggable compression support

2013-06-25 Thread Claudio Freire
On Tue, Jun 25, 2013 at 4:15 PM, Andres Freund and...@2ndquadrant.com wrote: However, can you tell me what exactly you are concerned about? lz4 is under the BSD license, and released by Google. Snappy is released/copyrighted by google. lz4 by Yann Collet. Both are under BSD licenses (3 and 2

Re: [HACKERS] pluggable compression support

2013-06-25 Thread Tom Lane
Josh Berkus j...@agliodbs.com writes: However, can you tell me what exactly you are concerned about? lz4 is under the BSD license, and released by Google. Why are we worried, exactly? Patents. The license on the code doesn't matter --- worst case, if someone objected, we could rewrite the

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread Dean Rasheed
On 25 June 2013 18:17, Josh Berkus j...@agliodbs.com wrote: Hackers, I'd like to take a straw poll here on how we should acknowledge reviewers. Please answer the below with your thoughts, either on-list or via private email. How should reviewers get credited in the release notes? a) not

Re: [HACKERS] pluggable compression support

2013-06-25 Thread Josh Berkus
On 06/25/2013 12:23 PM, Tom Lane wrote: Josh Berkus j...@agliodbs.com writes: However, can you tell me what exactly you are concerned about? lz4 is under the BSD license, and released by Google. Why are we worried, exactly? Patents. The license on the code doesn't matter --- worst case, if

Re: [HACKERS] Kudos for Reviewers -- straw poll

2013-06-25 Thread David Fetter
On Tue, Jun 25, 2013 at 10:17:07AM -0700, Josh Berkus wrote: Hackers, I'd like to take a straw poll here on how we should acknowledge reviewers. Please answer the below with your thoughts, either on-list or via private email. How should reviewers get credited in the release notes? a)

Re: [HACKERS] Hash partitioning.

2013-06-25 Thread Tom Lane
Christopher Browne cbbro...@gmail.com writes: There would indeed be merit in improving the partitioning apparatus, and actually, I think it's been a couple of years since there has been serious discussion of this. We could certainly use a partitioning mechanism that's easier to use than what

[HACKERS] LATERAL quals revisited

2013-06-25 Thread Tom Lane
I've been studying the bug reported at http://www.postgresql.org/message-id/20130617235236.GA1636@jeremyevans.local that the planner can do the wrong thing with queries like SELECT * FROM i LEFT JOIN LATERAL (SELECT * FROM j WHERE i.n = j.n) j ON true; I think the fundamental problem is that,

Re: [HACKERS] Improvement of checkpoint IO scheduler for stable transaction responses

2013-06-25 Thread Robert Haas
On Tue, Jun 25, 2013 at 1:15 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: I'm not sure it's a good idea to sleep proportionally to the time it took to complete the previous fsync. If you have a 1GB cache in the RAID controller, fsyncing the a 1GB segment will fill it up. But since it

Re: [HACKERS] Improvement of checkpoint IO scheduler for stable transaction responses

2013-06-25 Thread Heikki Linnakangas
On 25.06.2013 23:03, Robert Haas wrote: On Tue, Jun 25, 2013 at 1:15 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: I'm not sure it's a good idea to sleep proportionally to the time it took to complete the previous fsync. If you have a 1GB cache in the RAID controller, fsyncing the a

  1   2   >