Hello, Sev.
You wrote:
SZ Thank you all for considering my feature request.
SZ Dimitri's suggestion is a very good one - I feel it will accomplish the
SZ goal of allowing more granularity in the Listen.
SZ We might also want to add a flag in postgresql.conf to disable this
SZ enhancement so
On 19 November 2013 09:59 Amit Kapila wrote:
On Mon, Nov 18, 2013 at 8:31 PM, Haribabu kommi
haribabu.ko...@huawei.com wrote:
On 18 November 2013 20:01 Amit Kapila wrote:
Code changes are fine.
If two or three errors are present in the configuration file, it
prints the last error
On 12 November 2013 16:00, Pavel Stehule pavel.steh...@gmail.com wrote:
Hello
here is patch with fault tolerant drop trigger and drop rule support
drop trigger [if exists] trgname on [if exists] tablename;
drop rule [if exists] trgname on [if exists] tablename;
Regards
Pavel
Hi,
I
Referring to the instructions located here:
http://www.postgresql.org/docs/8.3/static/install-win32-libpq.html
I noticed that the msvs makefile doesn't work. One file is missing, and the
manifest embedding test is a bit awkward. The attached patch fixes these
issues.
BR,
Wim.
Hi All,
I was reading b tree index code and I wanted to the know the calling
function which calls
btinserthttp://doxygen.postgresql.org/nbtree_8c.html#a2b69e4abd6e38fbb317a503b8cf6e00a
(PG_FUNCTION_ARGShttp://doxygen.postgresql.org/fmgr_8h.html#adf4dec9b7d23f1b4c68477affde8b7ff)
function in
Thank you for looking in detail for this patch, and giving
thoughtful advices.
I'm aware that you said you were going to refactor this, but I took a
quick look through it anyway. I don't think mere refactoring is going
to make me happy with it :-(.
Ouch.. Anyway I've refactored this patch
On Tue, Nov 19, 2013 at 2:22 AM, Rohit Goyal rhtgyl...@gmail.com wrote:
I was reading b tree index code and I wanted to the know the calling
function which calls btinsert(PG_FUNCTION_ARGS) function in nbtree.c file.
Moreover, my goal behind reading this function was to check how tuple is
On 11/19/2013 05:36 PM, Wim Dumon wrote:
Referring to the instructions located here:
http://www.postgresql.org/docs/8.3/static/install-win32-libpq.html
Are you in fact trying to build 8.3? Or the current version? You linked
to the 8.3 docs, but the patch filename suggests it's against 9.3.1.
On Tue, Nov 19, 2013 at 11:26 AM, Peter Geoghegan p...@heroku.com wrote:
On Tue, Nov 19, 2013 at 2:22 AM, Rohit Goyal rhtgyl...@gmail.com wrote:
I was reading b tree index code and I wanted to the know the calling
function which calls btinsert(PG_FUNCTION_ARGS) function in nbtree.c
file.
On Sat, Oct 26, 2013 at 11:19 AM, Thomas Munro mu...@ip9.org wrote:
On 25 October 2013 01:17, Josh Berkus j...@agliodbs.com wrote:
On 10/24/2013 04:55 PM, Robert Haas wrote:
I wonder if we should go so far as to make this the default behavior,
instead of just making it an option.
+1 from
On Tue, Nov 19, 2013 at 7:31 PM, Rohit Goyal rhtgyl...@gmail.com wrote:
On Tue, Nov 19, 2013 at 11:26 AM, Peter Geoghegan p...@heroku.com wrote:
On Tue, Nov 19, 2013 at 2:22 AM, Rohit Goyal rhtgyl...@gmail.com wrote:
I was reading b tree index code and I wanted to the know the calling
On 11/19/2013 06:22 PM, Rohit Goyal wrote:
Hi All,
I was reading b tree index code and I wanted to the know the calling
function which calls btinsert
http://doxygen.postgresql.org/nbtree_8c.html#a2b69e4abd6e38fbb317a503b8cf6e00a(PG_FUNCTION_ARGS
9.3.1 is the version that failed for me, MSVS 2012, Windows 7.
Build commands:
cd src
nmake /f win32.mak
The first build error:
link.exe -lib @C:\Users\wim\AppData\Local\Temp\nmB317.tmp
rc.exe /l 0x409 /fo.\Release\libpq.res libpq-dist.rc
Microsoft (R) Windows (R) Resource
Hello, I've totally refactored the series of patches and cut out
the appropriate portion as 'unique (and non-nullable) index
stuff'.
As the discussion before, it got rid of path distinctness. This
patch works only on index 'full-orederedness', i.e., unique index
on non-nullable columns.
This
Hello, I've totally refactored the series of pathes and cut out
the appropriate portion as 'UNION stuff'.
This patch rquires another 'pathkeys expansion using fully-orderd
index' patch to work.
http://www.postgresql.org/message-id/20131119.203516.251520490.horiguchi.kyot...@lab.ntt.co.jp
1.
On 11/19/2013 06:55 PM, Wim Dumon wrote:
9.3.1 is the version that failed for me, MSVS 2012, Windows 7.
Build commands:
cd src
nmake /f win32.mak
OK, so you're trying to build libpq (and just libpq, not the rest of
PostgreSQL) using the standalone makefile, instead of using build.pl to
Hello
I am thinking so @2 is not good idea. Using well known idiom IF EXISTS
once before table name and second after table name can be difficult and
messy for users. If you like it, use different idiom or different keyword,
please.
My person favourite is @1 - fault tolerant version - but I
On Tue, Nov 19, 2013 at 11:52 AM, Craig Ringer cr...@2ndquadrant.comwrote:
On 11/19/2013 06:22 PM, Rohit Goyal wrote:
Hi All,
I was reading b tree index code and I wanted to the know the calling
function which calls btinsert
On 18 November 2013 23:30 Fujii Masao wrote:
On Tue, Nov 19, 2013 at 12:01 AM, Haribabu kommi
haribabu.ko...@huawei.com wrote:
On 18 November 2013 18:45 Fujii Masao wrote:
On Mon, Nov 18, 2013 at 6:31 PM, Haribabu kommi
haribabu.ko...@huawei.com wrote:
On 18 November 2013 11:19
Hi Rohit,
On 2013-11-19 13:11:12 +0100, Rohit Goyal wrote:
Please tel me how to attached gdb to pid and debug.
Also what I understood from your reply is that everything is abstracted, so
am doesnot care abt backend implementation. Now, I want to modify B tree
indexing scheme. So, which files
On Thu, Nov 14, 2013 at 12:26 PM, Andres Freund and...@2ndquadrant.com wrote:
As you know, the reason we are working changeset extraction is that we
want to build logical unidirection and bidirectional replication
ontop. To use changeset extraction effectively, I think one set of
related
Hi,
Here is a review of the first three patches:
1) Further gin refactoring:
make check passes (core tests and contrib tests).
Code compiles without warnings.
Then... About the patch... Even if I got little experience with code of
gin, moving the flag for search mode out of btree, as well as
On 11/19/2013 08:11 PM, Rohit Goyal wrote:
Also what I understood from your reply is that everything is abstracted,
so am doesnot care abt backend implementation. Now, I want to modify B
tree indexing scheme. So, which files I should focus ?
Depends on whether you can do what you want
On Tue, Nov 19, 2013 at 2:27 AM, Andres Freund and...@2ndquadrant.com wrote:
* --write-standby-enable seems to loose quite some functionality in
comparison to --write-recovery-conf since it doesn't seem to set
primary_conninfo, standby anymore.
Yes... The idea here might be to generate a
On Fri, Nov 15, 2013 at 10:49 AM, Andres Freund and...@2ndquadrant.com wrote:
Another reason I'm not in a hurry is that the problem we're trying
to solve doesn't seem to be causing real-world trouble. So by
awhile, I'm thinking let's let it get through 9.4 beta testing.
Well, there have been
On Fri, Nov 15, 2013 at 10:14 AM, Tom Lane t...@sss.pgh.pa.us wrote:
Michael Paquier michael.paqu...@gmail.com writes:
Currently, bgworkers offer the possibility to connect to a given
database using BackgroundWorkerInitializeConnection in bgworker.h, but
there is actually no way to disconnect
On Tue, Nov 19, 2013 at 9:14 PM, Haribabu kommi
haribabu.ko...@huawei.com wrote:
On 18 November 2013 23:30 Fujii Masao wrote:
On Tue, Nov 19, 2013 at 12:01 AM, Haribabu kommi
haribabu.ko...@huawei.com wrote:
On 18 November 2013 18:45 Fujii Masao wrote:
On Mon, Nov 18, 2013 at 6:31 PM,
On 11/19/2013 12:45 AM, Noah Misch wrote:
On Fri, Nov 15, 2013 at 01:01:48PM -0500, Andrew Dunstan wrote:
The triggers don't fire if there is no real XID, so only actual data
changes should cause the trigger to fire.
What's the advantage of this provision? Without it, an individual trigger
On Fri, Nov 15, 2013 at 3:04 PM, Andres Freund and...@2ndquadrant.com wrote:
Questions:
* What do you like/dislike about the API (storage/atomics.h)
* decide whether it's ok to rely on inline functions or whether we need
to provide out-of-line versions. I think we should just bite the
On Fri, Nov 15, 2013 at 4:01 PM, J Smith dark.panda+li...@gmail.com wrote:
On Fri, Nov 15, 2013 at 3:21 PM, Robert Haas robertmh...@gmail.com wrote:
I think what would help the most is if you could arrange to obtain a
stack backtrace at the point when the error is thrown. Maybe put a
long
On Thu, Nov 14, 2013 at 5:26 PM, Andres Freund and...@2ndquadrant.comwrote:
But for that the receiving side needs to know up to where changes have
been applied. One relatively easy solution for that is that the
receiving side does something like:
UPDATE replication_progress SET lsn =
Hi,
On 2013-11-18 23:15:59 +0100, Andres Freund wrote:
Afaics it's likely a combination/interaction of bugs and fixes between:
* the initial HS code
* 5a031a5556ff83b8a9646892715d7fef415b83c3
* f44eedc3f0f347a856eea8590730769125964597
Yes, the combination of those is guilty.
Man, this is
On 2013-11-19 15:20:01 +0100, Andres Freund wrote:
Imo something the attached patch should be done. The description I came
up with is:
Fix Hot-Standby initialization of clog and subtrans.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
On 11/19/2013 09:20 AM, Andres Freund wrote:
Imo this warrants and expedited point release :(
I presume anyone who is vulnerable to it would need to recreate their
secondary servers to get rid of potential problems?
cheers
andrew
--
Sent via pgsql-hackers mailing list
Fujii Masao masao.fu...@gmail.com writes:
On the second thought, I'm thinking that it might be overkill to add
such not simple code for that small benefit.
Yeah --- there's a limit to how much code we should expend on detecting
this type of error. It's not like the case is all that plausible.
On Sun, Nov 17, 2013 at 8:47 PM, Ian Lawrence Barwick barw...@gmail.com wrote:
Review for Pavel Stehule's patch in CF 2013-11:
https://commitfest.postgresql.org/action/patch_view?id=1253
Patch applies cleanly and works as intended; it's a very straightforward
patch so no surprises there.
On Tue, Nov 19, 2013 at 2:06 PM, Haribabu kommi
haribabu.ko...@huawei.com wrote:
On 19 November 2013 09:59 Amit Kapila wrote:
On Mon, Nov 18, 2013 at 8:31 PM, Haribabu kommi
haribabu.ko...@huawei.com wrote:
On 18 November 2013 20:01 Amit Kapila wrote:
Code changes are fine.
If two or
On Tue, Nov 19, 2013 at 2:41 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Tue, Nov 19, 2013 at 9:14 PM, Haribabu kommi
haribabu.ko...@huawei.com wrote:
On 18 November 2013 23:30 Fujii Masao wrote:
On Tue, Nov 19, 2013 at 12:01 AM, Haribabu kommi
haribabu.ko...@huawei.com wrote:
On
On Fri, Nov 15, 2013 at 9:01 PM, FabrÃzio de Royes Mello
fabriziome...@gmail.com wrote:
On Wed, Nov 13, 2013 at 9:37 PM, Josh Berkus j...@agliodbs.com wrote:
handyrep@john:~/handyrep$ pg_isready --version
pg_isready (PostgreSQL) 9.3.1
handyrep@john:~/handyrep$ pg_isready -h john -p 5432 -U
Robert Haas robertmh...@gmail.com writes:
On point #2, I don't personally know of any systems that I care about
where inlining isn't supported. However, we've gone to quite a bit of
trouble relatively recently to keep things working for platforms where
that is the case, so I feel the need for
On 2013-11-19 09:33:34 -0500, Andrew Dunstan wrote:
On 11/19/2013 09:20 AM, Andres Freund wrote:
Imo this warrants and expedited point release :(
I presume anyone who is vulnerable to it would need to recreate their
secondary servers to get rid of potential problems?
Yes. There's less
On Fri, Nov 15, 2013 at 6:51 AM, Simon Riggs si...@2ndquadrant.com wrote:
Not enough. This feature is clearly being suggested as a way to offer
Postgres in embedded mode for users by a back door. Doing that forces
us to turn off many of the server's features and we will take a huge
step
Robert Haas robertmh...@gmail.com writes:
On Fri, Nov 15, 2013 at 6:51 AM, Simon Riggs si...@2ndquadrant.com wrote:
Not enough. This feature is clearly being suggested as a way to offer
Postgres in embedded mode for users by a back door. Doing that forces
us to turn off many of the server's
On 11/19/13, 9:57 AM, Tom Lane wrote:
Hm. Now that I think about it, isn't Peter proposing to break systems
without working inline over here?
http://www.postgresql.org/message-id/1384257026.8059.5.ca...@vanquo.pezone.net
No, that's about const, volatile, #, and memcmp.
I don't have an
On 2013-11-19 09:57:20 -0500, Tom Lane wrote:
Robert Haas robertmh...@gmail.com writes:
On point #2, I don't personally know of any systems that I care about
where inlining isn't supported. However, we've gone to quite a bit of
trouble relatively recently to keep things working for
Alright, we'll look into doing that heading into the weekend.
Interestingly, we haven't experienced the issue since our main Java
developer made some modifications to our backend system. I'm not
entirely sure what the changes entail except that it's a one-liner
that involves re-SELECTing a table
On Tue, Nov 19, 2013 at 9:57 AM, Tom Lane t...@sss.pgh.pa.us wrote:
Robert Haas robertmh...@gmail.com writes:
On point #2, I don't personally know of any systems that I care about
where inlining isn't supported. However, we've gone to quite a bit of
trouble relatively recently to keep things
On Tue, Nov 19, 2013 at 10:16 AM, Andres Freund and...@2ndquadrant.com wrote:
On the other hand, if the complaint is
my hardware doesn't support 64-bit CAS, it's not reasonable to tell them
to buy a new server.
Agreed. I've am even wondering about 32bit CAS since it's not actually
that hard
On 2013-11-19 09:12:42 -0500, Robert Haas wrote:
On point #1, I dunno. It looks like a lot of rearrangement to me, and
I'm not really sure what the final form of it is intended to be.
Understandable. I am not that sure what parts we want to rearange
either. We very well could leave barrier.h
On Tue, Nov 19, 2013 at 10:26 AM, Andres Freund and...@2ndquadrant.com wrote:
On 2013-11-19 09:12:42 -0500, Robert Haas wrote:
On point #1, I dunno. It looks like a lot of rearrangement to me, and
I'm not really sure what the final form of it is intended to be.
Understandable. I am not that
On 2013-11-19 10:23:57 -0500, Robert Haas wrote:
The only fundamental thing that I don't immediately see how we can
support is the spinlock based memory barrier since that introduces a
circularity (atomics need barrier, barrier needs spinlocks, spinlock
needs atomics).
We've been pretty
Peter Eisentraut pete...@gmx.net writes:
On 11/19/13, 9:57 AM, Tom Lane wrote:
Hm. Now that I think about it, isn't Peter proposing to break systems
without working inline over here?
http://www.postgresql.org/message-id/1384257026.8059.5.ca...@vanquo.pezone.net
No, that's about const,
On Tue, Nov 19, 2013 at 10:31 AM, Andres Freund and...@2ndquadrant.com wrote:
On 2013-11-19 10:23:57 -0500, Robert Haas wrote:
The only fundamental thing that I don't immediately see how we can
support is the spinlock based memory barrier since that introduces a
circularity (atomics need
On 2013-11-19 10:30:24 -0500, Tom Lane wrote:
I don't have an informed opinion about requiring inline support
(although it would surely be nice).
inline is C99, and we've generally resisted requiring C99 features.
Maybe it's time to move that goalpost, and maybe not.
But it's a part of
Andres Freund and...@2ndquadrant.com writes:
The only animal we have that doesn't support quiet inlines today is
HP-UX/ac++, and I think - as in patch 1 in the series - we might be able
to simply suppress the warning there.
Or just not worry about it, if it's only a warning? Or does the
On Sun, Nov 17, 2013 at 5:10 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Pavel Stehule pavel.steh...@gmail.com writes:
[ rebased patch for RAISE WHEN ]
I have to say I do not see the point of this. It does nothing you
can't do already with IF condition THEN RAISE And frankly
the RAISE
On 2013-11-19 10:37:35 -0500, Tom Lane wrote:
Andres Freund and...@2ndquadrant.com writes:
The only animal we have that doesn't support quiet inlines today is
HP-UX/ac++, and I think - as in patch 1 in the series - we might be able
to simply suppress the warning there.
Or just not worry
On Mon, Nov 18, 2013 at 1:57 AM, Alexey Klyukin al...@hintbits.com wrote:
Hi Martijn,
On Sun, Nov 17, 2013 at 7:56 PM, Martijn van Oosterhout klep...@svana.org
wrote:
On Sat, Nov 16, 2013 at 09:26:33PM +0100, Alexey Klyukin wrote:
Hi,
Attached is the patch that improves usage of '*'
On Nov 19, 2013, at 6:59 AM, Andres Freund and...@2ndquadrant.com wrote:
Yes. There's less expensive ways to do it, but those seem to complicated
to suggest.
If this is something that could be built into to a tool, acknowledging the
complexity, I'd be happy to see about building it.
--
--
On Thu, Nov 14, 2013 at 05:50:02PM +0100, Hannu Krosing wrote:
If we could somehow turn old json into a text domain with json syntax
check
(which it really is up to 9.3) via pg_upgrade that would be great.
It would be the required for pg_dump to have some swicth to output
different typename
On Wed, Nov 13, 2013 at 6:59 PM, Hannu Krosing ha...@2ndquadrant.com wrote:
I remember strong voices in support of *not* normalising json, so that
things like
{a:1,a:true, a:b, a:none}
would go through the system unaltered, for claimed standard usage of
json as
processing instructions.
On Tue, Nov 19, 2013 at 10:51:06AM -0500, Robert Haas wrote:
I think this was the consensus solution when this was last discussed,
and I support it. There is similar space for a binary XML data type
if someone feels like implementing it. I think the names that were
proposed previously were
On Mon, Nov 18, 2013 at 9:39 AM, Ian Lawrence Barwick barw...@gmail.com wrote:
postgres=# BEGIN ;
BEGIN
postgres=*# INSERT INTO foo (id) VALUES (1);
INSERT 0 1
postgres=*# COMMIT ;
NOTICE: Pre-commit trigger called
ERROR: relation bar does not exist
LINE 1: SELECT foo
On 11/19/2013 10:51 AM, Robert Haas wrote:
I suggest we add another type, maybe jsobj, which has input and output
as standard
JSON but which is defined from the start to be equivalent of existing
object
and not preservable source code to such object.
I think this was the consensus solution
On Tue, Nov 19, 2013 at 10:55 AM, Bruce Momjian br...@momjian.us wrote:
On Tue, Nov 19, 2013 at 10:51:06AM -0500, Robert Haas wrote:
I think this was the consensus solution when this was last discussed,
and I support it. There is similar space for a binary XML data type
if someone feels like
2013/11/19 Robert Haas robertmh...@gmail.com
On Sun, Nov 17, 2013 at 5:10 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Pavel Stehule pavel.steh...@gmail.com writes:
[ rebased patch for RAISE WHEN ]
I have to say I do not see the point of this. It does nothing you
can't do already with IF
On 11/19/2013 11:00 AM, Robert Haas wrote:
On Tue, Nov 19, 2013 at 10:55 AM, Bruce Momjian br...@momjian.us wrote:
On Tue, Nov 19, 2013 at 10:51:06AM -0500, Robert Haas wrote:
I think this was the consensus solution when this was last discussed,
and I support it. There is similar space for a
On 11/19/2013 10:58 AM, Robert Haas wrote:
On Mon, Nov 18, 2013 at 9:39 AM, Ian Lawrence Barwick barw...@gmail.com wrote:
postgres=# BEGIN ;
BEGIN
postgres=*# INSERT INTO foo (id) VALUES (1);
INSERT 0 1
postgres=*# COMMIT ;
NOTICE: Pre-commit trigger called
ERROR:
I wrote:
Andrew Gierth and...@tao11.riddles.org.uk writes:
Here is a new patch with the following changes on top of Heikki's
version (all the changes in which I've otherwise kept):
Here is an updated version:
I've been hacking on this patch all day yesterday. What I'm on about at
the moment
On Thu, Nov 14, 2013 at 2:54 PM, Hannu Krosing ha...@2ndquadrant.com wrote:
I am sure you could also devise an json encoding scheme
where white space is significant ;)
I don't even have to think hard. If you want your JSON to be
human-readable, it's entirely possible that you want it stored
On Mon, Nov 18, 2013 at 3:21 PM, Bruce Momjian br...@momjian.us wrote:
On Thu, Nov 7, 2013 at 02:40:17PM -0500, Peter Eisentraut wrote:
On 11/7/13, 1:00 PM, Josh Berkus wrote:
If we wanted to change the defaults, I think it would be easier to
create a separate bin name (e.g. pg_backup) than
On Tue, Nov 19, 2013 at 10:59 AM, Pavel Stehule pavel.steh...@gmail.com wrote:
Now that having been said, I'm a bit wary of adding every new frammish
someone suggests to PL/pgsql. Many of the things we've added recently
are things I anticipate that I'll never use.
lot of features are popular
Robert Haas robertmh...@gmail.com writes:
However, pggit log 9f0ae0c82060e3dcd1fa7ac8bbe35a3f9a44dbba does not
show that line being added by the diff.
I dunno what your pggit script does, but git log doesn't normally
show the diff at all. git show
9f0ae0c82060e3dcd1fa7ac8bbe35a3f9a44dbba,
On Tue, Nov 19, 2013 at 08:54:49AM -0500, Andrew Dunstan wrote:
On 11/19/2013 12:45 AM, Noah Misch wrote:
On Fri, Nov 15, 2013 at 01:01:48PM -0500, Andrew Dunstan wrote:
The triggers don't fire if there is no real XID, so only actual data
changes should cause the trigger to fire.
What's the
On Tue, Nov 19, 2013 at 12:33 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote:
* on-dsm-detach-v2.patch
It reminded me the hook registration/invocation mechanism on apache/httpd.
It defines five levels for invocation order (REALLY_FIRST, FIRST, MIDDLE,
LAST, REALLY_LAST), but these are alias of
On Mon, Nov 18, 2013 at 8:20 PM, Josh Berkus j...@agliodbs.com wrote:
On 11/18/2013 05:09 PM, Josh Berkus wrote:
Folks,
Speaking of legacy code with bad default behaviors: pg_ctl. The current
utility is designed to fathfully reproduce the rather hackish shell
script we originally had for
On Mon, Nov 18, 2013 at 9:07 PM, Bruce Momjian br...@momjian.us wrote:
Well, ERROR is what LOCK returns, so if we change SET TRANSACTION to be
WARNING, we should change LOCK too, so on backward-compatibility
grounds, ERROR makes more sense.
Personally, I am fine with changing them all to
Robert Haas robertmh...@gmail.com writes:
On Mon, Nov 18, 2013 at 9:39 AM, Ian Lawrence Barwick barw...@gmail.com
wrote:
I'd expect this to lead to a failed transaction block,
or at least some sort of notice that the transaction itself
has been rolled back.
Ending up in a failed
On Thu, Nov 14, 2013 at 1:02 AM, Sawada Masahiko sawada.m...@gmail.com wrote:
I attached patch adds new wal_level 'all'.
If wal_level is set 'all', the server logs WAL not only when wal_level
is set 'hot_standby' ,but also when updating hint bit.
That is, we will be able to know all of the
Hi,
On 2013-11-15 13:01:48 -0500, Andrew Dunstan wrote:
Attached is a patch to provide a new event trigger that will fire on
transaction commit. I have tried to make certain that it fires at a
sufficiently early stage in the commit process that some of the evils
mentioned in previous
On Tue, Nov 19, 2013 at 12:45 AM, Noah Misch n...@leadboat.com wrote:
On Fri, Nov 15, 2013 at 01:01:48PM -0500, Andrew Dunstan wrote:
The triggers don't fire if there is no real XID, so only actual data
changes should cause the trigger to fire.
What's the advantage of this provision? Without
2013/11/19 Robert Haas robertmh...@gmail.com
On Tue, Nov 19, 2013 at 10:59 AM, Pavel Stehule pavel.steh...@gmail.com
wrote:
Now that having been said, I'm a bit wary of adding every new frammish
someone suggests to PL/pgsql. Many of the things we've added recently
are things I anticipate
On Tue, Nov 19, 2013 at 3:54 PM, KONDO Mitsumasa
kondo.mitsum...@lab.ntt.co.jp wrote:
(2013/11/15 19:27), Sawada Masahiko wrote:
On Thu, Nov 14, 2013 at 7:51 PM, Florian Weimer fwei...@redhat.com
wrote:
On 11/14/2013 07:02 AM, Sawada Masahiko wrote:
I attached patch adds new wal_level
Robert Haas wrote
On Mon, Nov 18, 2013 at 9:07 PM, Bruce Momjian lt;
bruce@
gt; wrote:
Well, ERROR is what LOCK returns, so if we change SET TRANSACTION to be
WARNING, we should change LOCK too, so on backward-compatibility
grounds, ERROR makes more sense.
Personally, I am fine with
Hi,
On 2013-11-19 07:40:30 -0500, Robert Haas wrote:
This way, after a crash, restart, disconnect the replay process can look
into shared memory and check how far it has already replayed and restart
seamlessly. With minimal effort.
It would be much less invasive for the replication apply
On Tue, Nov 19, 2013 at 11:53 AM, David Johnston pol...@yahoo.com wrote:
Well, at this point we have already broken backward compatibility by
releasing this. With Tom's thread necromancy I missed the fact this got
released in 9.3
Eh, really? I don't see it in 9.3.
--
Robert Haas
On Tue, Nov 19, 2013 at 2:03 AM, Maxim Boguk maxim.bo...@gmail.com wrote:
Case:
SELECT * FROM very_large_table ORDER BY [some indexed column(s)] OFFSET
[some large value] LIMIT N;
Idea:
Use IOS (index only scan) to skip the first OFFSET values than switch to
common index scan to fetch
On Mon, Nov 18, 2013 at 11:45 AM, Andres Freund and...@2ndquadrant.com wrote:
Yes, we probably should make a decision, unless Robert's idea can be
implemented. We have to balance the ease of debugging MVCC failures
with the interface we give to the user community.
Imo that patch really
On 2013-11-19 12:23:30 -0500, Robert Haas wrote:
On Mon, Nov 18, 2013 at 11:45 AM, Andres Freund and...@2ndquadrant.com
wrote:
Yes, we probably should make a decision, unless Robert's idea can be
implemented. We have to balance the ease of debugging MVCC failures
with the interface we
David Johnston pol...@yahoo.com writes:
Robert Haas wrote
I don't think it's worth breaking backward compatibility. I'm not
entirely sure what I would have decided here in a vacuum, but at this
point existing precedent seems determinative.
Well, at this point we have already broken backward
Andrew Dunstan and...@dunslane.net writes:
Perhaps my understanding of when XIDs are acquired is insufficient. When
exactly is it optional?
My understanding of Noah's comment is that we would be exposing what
used to be an optimisation only implementation detail to the user, and
so we would
On Tue, Nov 19, 2013 at 12:27 PM, David E. Wheeler
da...@justatheory.com wrote:
On Nov 19, 2013, at 8:14 AM, Robert Haas robertmh...@gmail.com wrote:
Everyone on this thread who thinks that there is Only One Right Way To
Do It should take a chill pill. There is, in fact, more than one
right
On Tue, Nov 19, 2013 at 3:53 AM, Dean Rasheed dean.a.rash...@gmail.com wrote:
1). Keep the existing syntax:
DROP TRIGGER [ IF EXISTS ] name ON table_name [ CASCADE | RESTRICT ];
but make it tolerate a non-existent table when IF EXISTS is specified.
I don't love this option, but I like it
On Nov 19, 2013, at 8:14 AM, Robert Haas robertmh...@gmail.com wrote:
Everyone on this thread who thinks that there is Only One Right Way To
Do It should take a chill pill. There is, in fact, more than one
right way to do it.
You shoulda been a Perl hacker, Robert.
D
--
Sent via
On Tue, Nov 19, 2013 at 11:38 AM, Andres Freund and...@2ndquadrant.com wrote:
/*-
*
* atomics.h
*Generic atomic operations support.
*
* Hardware and compiler dependent functions for manipulating memory
*
On Tue, Nov 19, 2013 at 11:57 AM, Andres Freund and...@2ndquadrant.com wrote:
Agreed. As an alternative we could just have a single - probably longer
than NAMEDATALEN - string to identify replication progress and rely on
the users of the facility to build the identifier automatically
On 11/19/2013 06:20 AM, Andres Freund wrote:
Hi,
On 2013-11-18 23:15:59 +0100, Andres Freund wrote:
Afaics it's likely a combination/interaction of bugs and fixes between:
* the initial HS code
* 5a031a5556ff83b8a9646892715d7fef415b83c3
* f44eedc3f0f347a856eea8590730769125964597
Yes,
On 2013-11-19 12:43:44 -0500, Robert Haas wrote:
* To be useful they usually will need to be placed in memory shared between
* processes or threads, most frequently by embedding them in structs. Be
* careful to align atomic variables to their own size!
What does that mean exactly?
The
On 2013-11-19 09:51:28 -0800, Josh Berkus wrote:
On 11/19/2013 06:20 AM, Andres Freund wrote:
Hi,
On 2013-11-18 23:15:59 +0100, Andres Freund wrote:
Afaics it's likely a combination/interaction of bugs and fixes between:
* the initial HS code
*
On 11/19/2013 08:14 AM, Robert Haas wrote:
On Thu, Nov 14, 2013 at 2:54 PM, Hannu Krosing ha...@2ndquadrant.com wrote:
I am sure you could also devise an json encoding scheme
where white space is significant ;)
I don't even have to think hard. If you want your JSON to be
human-readable,
1 - 100 of 194 matches
Mail list logo