[HACKERS] Implementing parallel sequence doubts

2014-08-21 Thread Haribabu Kommi
Hi Hackers, Implementation of Parallel Sequence Scan Approach: 1.Parallel Sequence Scan can achieved by using the background workers doing the job of actual sequence scan including the qualification check also. 2. Planner generates the parallel scan plan by checking the possible criteria of

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Heikki Linnakangas
On 08/13/2014 09:43 PM, Atri Sharma wrote: Sorry, forgot to attach the patch for fixing cube in contrib, which breaks since we now reserve cube keyword. Please find attached the same. Ugh, that will make everyone using the cube extension unhappy. After this patch, they will have to quote

[HACKERS] Parallel Sequence Scan doubts

2014-08-21 Thread Haribabu Kommi
Corrected subject. Hi Hackers, Implementation of Parallel Sequence Scan Approach: 1.Parallel Sequence Scan can achieved by using the background workers doing the job of actual sequence scan including the qualification check also. 2. Planner generates the parallel scan plan by checking the

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-08-21 Thread Dilip kumar
On 21 August 2014 08:31, Amit Kapila Wrote, Not sure. How about *concurrent* or *multiple*? multiple isn't right, but we could say concurrent. I also find concurrent more appropriate. Dilip, could you please change it to concurrent in doc updates, variables, functions unless you see any

Re: [HACKERS] pg_xlogdump --stats

2014-08-21 Thread Heikki Linnakangas
On 07/07/2014 10:32 PM, Abhijit Menon-Sen wrote: At 2014-07-07 09:48:44 +0200, and...@2ndquadrant.com wrote: I'd suggest only defining INT64_MODIFIER here and build INT64_FORMAT, UINT64_FORMAT ontop, in c.h. Oh, I see. I'm sorry, I misread your earlier suggestion. Regenerated patches

Re: [HACKERS] Specifying the unit in storage parameter

2014-08-21 Thread Michael Paquier
On Fri, Aug 8, 2014 at 12:32 PM, Fujii Masao masao.fu...@gmail.com wrote: This is not user-friendly. I'd like to propose the attached patch which introduces the infrastructure which allows us to specify the unit when setting INTEGER storage parameter like autovacuum_vacuum_cost_delay. Comment?

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Andrew Gierth
Heikki == Heikki Linnakangas hlinnakan...@vmware.com writes: On 08/13/2014 09:43 PM, Atri Sharma wrote: Sorry, forgot to attach the patch for fixing cube in contrib, which breaks since we now reserve cube keyword. Please find attached the same. Heikki Ugh, that will make everyone using

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

2014-08-21 Thread Heikki Linnakangas
On 07/23/2014 09:14 AM, Viswanatham kirankumar wrote: On 16 July 2014 23:12, Tom Lane wrote Christoph Berg c...@df7cb.de writes: Re: Viswanatham kirankumar 2014-07-16 ec867def52699d4189b584a14baa7c2165440...@blreml504-mbx.china.huawei.com Attached patch is implementing following TODO item

Re: [HACKERS] 9.5: Memory-bounded HashAgg

2014-08-21 Thread Jeff Davis
On Wed, 2014-08-20 at 14:32 -0400, Robert Haas wrote: Well, I think you're certainly right that a hash table lookup is more expensive than modulo on a 32-bit integer; so much is obvious. But if the load factor is not too large, I think that it's not a *lot* more expensive, so it could be

[HACKERS] [TODO] Track number of files ready to be archived in pg_stat_archiver

2014-08-21 Thread Julien Rouhaud
Hello, Attached patch implements the following TODO item : Track number of WAL files ready to be archived in pg_stat_archiver However, it will track the total number of any file ready to be archived, not only WAL files. Please let me know what you think about it. Regards. -- Julien Rouhaud

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-21 Thread Christoph Berg
Re: Thom Brown 2014-08-20 CAA-aLv7TeF8iM=7u7tsgl4s5jh1a+shq_ny7gorzc_g_yj7...@mail.gmail.com ERROR: table test is not permanent Perhaps this would be better as table test is unlogged as permanent doesn't match the term used in the DDL syntax. I was also wondering that, but then figured

Re: [HACKERS] [TODO] Process pg_hba.conf keywords as case-insensitive

2014-08-21 Thread Christoph Berg
Re: Heikki Linnakangas 2014-08-21 53f5a2d6.2050...@vmware.com 1) database and role names behave similar to SQL identifiers (case-sensitive / case-folding). 2) users and user-groups only requires special handling and behavior as follows Normal user : A. unquoted ( USER ) will

Re: [HACKERS] run xmllint during build (was Re: need xmllint on borka)

2014-08-21 Thread Fabien COELHO
Hello Peter, Agreed. I have committed the SGML changes that make things valid now, but I will postpone the xmllint addition until the 9.5 branch, complete with more documentation. Per the above announcement, here is an updated patch, also with more documentation and explanations. It would

Re: [HACKERS] pg_receivexlog --status-interval add fsync feedback

2014-08-21 Thread Sawada Masahiko
On Thu, Aug 21, 2014 at 2:54 PM, furu...@pm.nttdata.co.jp wrote: When replication slot is not specified in pg_receivexlog, the flush location in the feedback message always indicates invalid. So there seems to be no need to send the feedback as soon as fsync is issued, in that case. How

Re: Compute attr_needed for child relations (was Re: [HACKERS] inherit support for foreign tables)

2014-08-21 Thread Etsuro Fujita
(2014/08/21 13:21), Ashutosh Bapat wrote: On Wed, Aug 20, 2014 at 3:25 PM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp mailto:fujita.ets...@lab.ntt.co.jp wrote: Hi Ashutish, I am sorry that I mistook your name's spelling. (2014/08/14 22:30), Ashutosh Bapat wrote: On Thu,

Re: [HACKERS] run xmllint during build (was Re: need xmllint on borka)

2014-08-21 Thread Fabien COELHO
Also, a general comment, which is independent of this patch: I found the documentation build especially not resilient, with a lack of clear error messages when something is broken. Basically, if configure does not found something for the doc (openjade, osx, xmllint, ...) it does not complain.

Re: [HACKERS] inherit support for foreign tables

2014-08-21 Thread Etsuro Fujita
(2014/07/02 11:23), Noah Misch wrote: On Fri, Jun 20, 2014 at 05:04:06PM +0900, Kyotaro HORIGUCHI wrote: Attached is the rebased patch of v11 up to the current master. The rest of these review comments are strictly observations; they're not requests for you to change the patch, but they may

Re: [HACKERS] documentation update for doc/src/sgml/func.sgml

2014-08-21 Thread Fabien COELHO
attached is a small patch which updates doc/src/sgml/func.sgml. The change explains that functions like round() and others might behave different depending on your operating system (because of rint(3)) and that this is according to an IEEE standard. It also points out that #.5 is not always

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

2014-08-21 Thread Amit Kapila
On Tue, Aug 19, 2014 at 9:51 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Mon, Aug 18, 2014 at 7:50 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Wouldn't it make a lot more sense to create it correctly in the first place? Looking at the code, I think it is very well possible to

Re: [HACKERS] plpgsql.extra_warnings='num_into_expressions'

2014-08-21 Thread Heikki Linnakangas
On 08/07/2014 01:11 AM, Marko Tiikkaja wrote: On 7/21/14, 10:56 PM, I wrote: Here's a patch which allows you to notice those annoying bugs with INTO slightly more quickly. Adding to the next commit phest. New version, fixed bugs with set operations and VALUES lists. Looks good. It seems

Re: [HACKERS] documentation update for doc/src/sgml/func.sgml

2014-08-21 Thread Andreas 'ads' Scherbaum
On 08/21/2014 11:53 AM, Fabien COELHO wrote: attached is a small patch which updates doc/src/sgml/func.sgml. The change explains that functions like round() and others might behave different depending on your operating system (because of rint(3)) and that this is according to an IEEE standard.

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Andrew Gierth
A progress update: Atri We envisage that handling of arbitrary grouping sets will be Atri best done by having the planner generating an Append of Atri multiple aggregation paths, presumably with some way of moving Atri the original input path to a CTE. We have not really explored Atri yet

Re: [HACKERS] documentation update for doc/src/sgml/func.sgml

2014-08-21 Thread Fabien COELHO
I do not understand why the last sentence in the first paragraph about bitwise ops is put there with rounding issues, which seem unrelated. It seems to me that it belongs to the second paragraph which is about bitwise operators. That's the part which came from Josh Berkus. We discussed

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Heikki Linnakangas
On 08/21/2014 01:28 PM, Andrew Gierth wrote: A progress update: Atri We envisage that handling of arbitrary grouping sets will be Atri best done by having the planner generating an Append of Atri multiple aggregation paths, presumably with some way of moving Atri the original input

Re: [HACKERS] plpgsql.extra_warnings='num_into_expressions'

2014-08-21 Thread Marko Tiikkaja
On 8/21/14, 1:19 PM, Heikki Linnakangas wrote: On 08/07/2014 01:11 AM, Marko Tiikkaja wrote: On 7/21/14, 10:56 PM, I wrote: Here's a patch which allows you to notice those annoying bugs with INTO slightly more quickly. Adding to the next commit phest. New version, fixed bugs with set

Re: [HACKERS] plpgsql.extra_warnings='num_into_expressions'

2014-08-21 Thread Heikki Linnakangas
On 08/21/2014 02:09 PM, Marko Tiikkaja wrote: On 8/21/14, 1:19 PM, Heikki Linnakangas wrote: On 08/07/2014 01:11 AM, Marko Tiikkaja wrote: On 7/21/14, 10:56 PM, I wrote: Here's a patch which allows you to notice those annoying bugs with INTO slightly more quickly. Adding to the next commit

Re: [HACKERS] proposal: rounding up time value less than its unit.

2014-08-21 Thread Heikki Linnakangas
On 07/10/2014 09:52 AM, Tomonari Katsumata wrote: Hi, Several couple weeks ago, I posted a mail to pgsql-doc. http://www.postgresql.org/message-id/53992ff8.2060...@po.ntts.co.jp In this thread, I concluded that it's better to round up the value which is less than its unit. Current behavior

Re: [HACKERS] Removing dependency to wsock32.lib when compiling code on WIndows

2014-08-21 Thread Andrew Dunstan
On 08/15/2014 11:00 PM, Noah Misch wrote: On Fri, Aug 15, 2014 at 12:49:36AM -0700, Michael Paquier wrote: Btw, how do you determine if MSVC is using HAVE_GETADDRINFO? Is it decided by the inclusion of getaddrinfo.c in @pgportfiles of Mkvdbuild.pm? src/include/pg_config.h.win32 dictates it,

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-21 Thread Fabrízio de Royes Mello
On Thu, Aug 21, 2014 at 5:23 AM, Christoph Berg c...@df7cb.de wrote: Re: Thom Brown 2014-08-20 CAA-aLv7TeF8iM= 7u7tsgl4s5jh1a+shq_ny7gorzc_g_yj7...@mail.gmail.com ERROR: table test is not permanent Perhaps this would be better as table test is unlogged as permanent doesn't match the

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-21 Thread Thom Brown
On 21 August 2014 14:45, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Thu, Aug 21, 2014 at 5:23 AM, Christoph Berg c...@df7cb.de wrote: Re: Thom Brown 2014-08-20 CAA-aLv7TeF8iM= 7u7tsgl4s5jh1a+shq_ny7gorzc_g_yj7...@mail.gmail.com ERROR: table test is not permanent

Re: [HACKERS] add line number as prompt option to psql

2014-08-21 Thread Alvaro Herrera
Jeevan Chalke wrote: I have initialize cur_lineno to UINTMAX - 2. And then observed following behaviour to check wrap-around. postgres=# \set PROMPT1 '%/[%l]%R%# ' postgres[18446744073709551613]=# \set PROMPT2 '%/[%l]%R%# ' postgres[18446744073709551613]=# select

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Tom Lane
Andrew Gierth and...@tao11.riddles.org.uk writes: Heikki == Heikki Linnakangas hlinnakan...@vmware.com writes: Heikki I think we should bite the bullet and rename the extension, I agree, the contrib/cube patch as posted is purely so we could test everything without having to argue over the

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Andrew Gierth
Heikki == Heikki Linnakangas hlinnakan...@vmware.com writes: Heikki Uh, that's ugly. The EXPLAIN out I mean; as an implementation Heikki detail chaining the nodes might be reasonable. But the above Heikki gets unreadable if you have more than a few grouping sets. It's good for highlighting

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Pavel Stehule
2014-08-21 17:00 GMT+02:00 Tom Lane t...@sss.pgh.pa.us: Andrew Gierth and...@tao11.riddles.org.uk writes: Heikki == Heikki Linnakangas hlinnakan...@vmware.com writes: Heikki I think we should bite the bullet and rename the extension, I agree, the contrib/cube patch as posted is purely so

[HACKERS] Hardening pg_upgrade

2014-08-21 Thread Bruce Momjian
Now that everyone is happy with how pg_upgrade_support uses global variables to set preserved oids (or at least has no better ideas), I think it is time to lock down this usage to prevent future breakage. Specifically, the first attached patch causes pg_upgrade_support functions to throw errors

Re: [HACKERS] proposal: rounding up time value less than its unit.

2014-08-21 Thread Tom Lane
Heikki Linnakangas hlinnakan...@vmware.com writes: The patch also rounds a zero up to one. A naked zero with no unit is not affected, but e.g if you have log_rotation_age=0s, it will not disable the feature as you might expect, but set it to 1 minute. Should we do something about that?

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-21 Thread Baker, Keith [OCDUS Non-JJ]
Hello Andres, Thanks for your response. About SA_RESTART: I would like to offer you a different perspective which may alter your current opinion. I believe the port.h QNX macro replacement for SA_RESTART is still a reasonable solution on QNX for these reasons: First,

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Andrew Gierth
Tom == Tom Lane t...@sss.pgh.pa.us writes: I agree, the contrib/cube patch as posted is purely so we could test everything without having to argue over the new name first. Tom I wonder if you've tried hard enough to avoid reserving the keyword. GROUP BY cube(a,b) is currently legal

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Pavel Stehule
2014-08-21 17:58 GMT+02:00 Andrew Gierth and...@tao11.riddles.org.uk: Tom == Tom Lane t...@sss.pgh.pa.us writes: I agree, the contrib/cube patch as posted is purely so we could test everything without having to argue over the new name first. Tom I wonder if you've tried hard enough to

Re: [HACKERS] pg_dumpall reccomendation in release notes

2014-08-21 Thread Bruce Momjian
On Tue, Feb 25, 2014 at 05:05:09PM -0800, Josh Berkus wrote: On 02/25/2014 04:42 PM, Bruce Momjian wrote: On Tue, Feb 25, 2014 at 06:41:26PM -0500, Tom Lane wrote: I'm not sure what many limitations you think pg_dumpall has that pg_dump doesn't. I do think that it might be time to

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-21 Thread Alvaro Herrera
Baker, Keith [OCDUS Non-JJ] wrote: About configure: ./configure barked at 2 things on QNX, and it advised using both --without-readline --disable-thread-safety. I can investigate further, but I have been focusing on the bigger issues first. I don't think

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Tom Lane
Andrew Gierth and...@tao11.riddles.org.uk writes: Tom == Tom Lane t...@sss.pgh.pa.us writes: Tom I wonder if you've tried hard enough to avoid reserving the keyword. GROUP BY cube(a,b) is currently legal syntax and means something completely incompatible to what the spec requires. Well, if

Re: [HACKERS] Hardening pg_upgrade

2014-08-21 Thread David G Johnston
Bruce Momjian wrote I had to make an exception for temporary tables because pg_upgrade uses temporary tables to collect schema information. I tried writing the query to use CTEs (second patch), but I would then have to have one query for 8.3, which doesn't support CTEs, and another for 8.4+,

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Merlin Moncure
On Thu, Aug 21, 2014 at 1:13 PM, Tom Lane t...@sss.pgh.pa.us wrote: Andrew Gierth and...@tao11.riddles.org.uk writes: Tom == Tom Lane t...@sss.pgh.pa.us writes: Tom I wonder if you've tried hard enough to avoid reserving the keyword. GROUP BY cube(a,b) is currently legal syntax and means

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-21 Thread Heikki Linnakangas
On 08/21/2014 05:04 PM, Thom Brown wrote: On 21 August 2014 14:45, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Thu, Aug 21, 2014 at 5:23 AM, Christoph Berg c...@df7cb.de wrote: Re: Thom Brown 2014-08-20 CAA-aLv7TeF8iM= 7u7tsgl4s5jh1a+shq_ny7gorzc_g_yj7...@mail.gmail.com

Re: [HACKERS] Hardening pg_upgrade

2014-08-21 Thread Bruce Momjian
On Thu, Aug 21, 2014 at 11:43:42AM -0700, David G Johnston wrote: Bruce Momjian wrote I had to make an exception for temporary tables because pg_upgrade uses temporary tables to collect schema information. I tried writing the query to use CTEs (second patch), but I would then have to have

Re: [HACKERS] run xmllint during build (was Re: need xmllint on borka)

2014-08-21 Thread Peter Eisentraut
On 8/21/14 5:12 AM, Fabien COELHO wrote: However, it seems that it is not run for target html, nor for pdf/ps targets. I'm wondering whether it is an oversight or if there is a reason for that. Maybe the intention is that an explicit htmlhelp is expected to do the checking, but then why

Re: [HACKERS] run xmllint during build (was Re: need xmllint on borka)

2014-08-21 Thread Peter Eisentraut
On 8/21/14 5:12 AM, Fabien COELHO wrote: Also, a general comment, which is independent of this patch: I found the documentation build especially not resilient, with a lack of clear error messages when something is broken. Basically, if configure does not found something for the doc (openjade,

Re: [HACKERS] Enable WAL archiving even in standby

2014-08-21 Thread Robert Haas
On Tue, Aug 19, 2014 at 7:33 AM, Fujii Masao masao.fu...@gmail.com wrote: On Fri, Aug 15, 2014 at 4:30 AM, Robert Haas robertmh...@gmail.com wrote: On Wed, Aug 13, 2014 at 6:42 AM, Fujii Masao masao.fu...@gmail.com wrote: I'd propose the attached WIP patch which allows us to enable WAL

Re: [HACKERS] run xmllint during build (was Re: need xmllint on borka)

2014-08-21 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: On 8/21/14 5:12 AM, Fabien COELHO wrote: However, it seems that it is not run for target html, nor for pdf/ps targets. I'm wondering whether it is an oversight or if there is a reason for that. Maybe the intention is that an explicit htmlhelp is

Re: [HACKERS] proposal: rounding up time value less than its unit.

2014-08-21 Thread Peter Eisentraut
On 8/21/14 11:16 AM, Tom Lane wrote: Heikki Linnakangas hlinnakan...@vmware.com writes: The patch also rounds a zero up to one. A naked zero with no unit is not affected, but e.g if you have log_rotation_age=0s, it will not disable the feature as you might expect, but set it to 1 minute.

Re: [HACKERS] run xmllint during build (was Re: need xmllint on borka)

2014-08-21 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: We could use $(missing) for that, which is already used for bison, flex, and perl. +1 ... I'm surprised it's not like that already. Fabien's quite right to complain that the Makefile has no business inserting defaults for things configure couldn't find.

Re: [HACKERS] Hardening pg_upgrade

2014-08-21 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: Specifically, the first attached patch causes pg_upgrade_support functions to throw errors when called by a backend that is not in binary upgrade mode. (This seems like a good safety measure.) Agreed about that part. Second, and more importantly, the

Re: [HACKERS] Hardening pg_upgrade

2014-08-21 Thread Magnus Hagander
On Thu, Aug 21, 2014 at 10:07 PM, Tom Lane t...@sss.pgh.pa.us wrote: Bruce Momjian br...@momjian.us writes: I tried writing the query to use CTEs (second patch), but I would then have to have one query for 8.3, which doesn't support CTEs, and another for 8.4+, plus the CTE query was more

Re: [HACKERS] run xmllint during build (was Re: need xmllint on borka)

2014-08-21 Thread Peter Eisentraut
On 8/21/14 4:00 PM, Tom Lane wrote: It is only run when the build is via XML/XSLT, not via SGML/DSSSL (because the SGML/DSSSL build already checks the validity anyway). I'm confused. I thought the point of this change was mostly that the SGML toolchain is less strict than the XML toolchain,

Re: [HACKERS] run xmllint during build (was Re: need xmllint on borka)

2014-08-21 Thread Fabien COELHO
It is only run when the build is via XML/XSLT, not via SGML/DSSSL (because the SGML/DSSSL build already checks the validity anyway). I'm confused. I thought the point of this change was mostly that the SGML toolchain is less strict than the XML toolchain, and you wanted to have the

Re: [HACKERS] run xmllint during build (was Re: need xmllint on borka)

2014-08-21 Thread Fabien COELHO
ISTM that it may be more helful to do: ifndef JADE #error no jade found on your system, cannot generate the documention endif We could use $(missing) for that, which is already used for bison, flex, and perl. I'm fine with $(missing) or whatever else that provides a clear message.

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Andrew Dunstan
On 08/21/2014 02:48 PM, Merlin Moncure wrote: Basically, I'm afraid that unilaterally renaming cube is going to break enough applications that there will be more people who flat out don't want this patch than there will be who get benefit from it, and we end up voting to revert the feature

Re: [HACKERS] proposal: rounding up time value less than its unit.

2014-08-21 Thread David G Johnston
Peter Eisentraut-2 wrote On 8/21/14 11:16 AM, Tom Lane wrote: Heikki Linnakangas lt; hlinnakangas@ gt; writes: The patch also rounds a zero up to one. A naked zero with no unit is not affected, but e.g if you have log_rotation_age=0s, it will not disable the feature as you might expect,

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-21 Thread Alvaro Herrera
Heikki Linnakangas wrote: In Postgres internals slang, non-permanent means temporary or unlogged. But I agree we shouldn't expose users to that term; we use it in the docs, and it's not used in command names either. Agreed. I am going over this patch, and the last bit I need to sort out is

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: I'm inclined to think that the audience for this is far larger than the audience for the cube extension, which I have not once encountered in the field. Perhaps so. I would really prefer not to have to get into estimating how many people will be

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-21 Thread Tom Lane
Alvaro Herrera alvhe...@2ndquadrant.com writes: Agreed. I am going over this patch, and the last bit I need to sort out is the wording of these messages. I have temporarily settled on this: ereport(ERROR, (errcode(ERRCODE_INVALID_TABLE_DEFINITION),

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-21 Thread Andres Freund
On 2014-08-21 16:59:17 -0400, Alvaro Herrera wrote: Heikki Linnakangas wrote: In Postgres internals slang, non-permanent means temporary or unlogged. But I agree we shouldn't expose users to that term; we use it in the docs, and it's not used in command names either. Agreed. I am

Re: [HACKERS] jsonb format is pessimal for toast compression

2014-08-21 Thread Josh Berkus
On 08/20/2014 03:42 PM, Arthur Silva wrote: What data are you using right now Josh? The same data as upthread. Can you test the three patches (9.4 head, 9.4 with Tom's cleanup of Heikki's patch, and 9.4 with Tom's latest lengths-only) on your workload? I'm concerned that my workload is unusual

Re: [HACKERS] Add the number of pinning backends to pg_buffercache's output

2014-08-21 Thread Andres Freund
On 2014-07-02 08:55:05 +, Rajeev rastogi wrote: Also can we change the description of function pg_buffercache_pages to include pinning_backend also in the description. I'm not sure what you mean here - I've adjusted the docs to include the column? Or do you mean that it errorneously was

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: Andrew Dunstan and...@dunslane.net writes: I'm inclined to think that the audience for this is far larger than the audience for the cube extension, which I have not once encountered in the field. +1 Perhaps so. I would really prefer not to have

Re: [HACKERS] pg_upgrade: allow multiple -o/-O options

2014-08-21 Thread Bruce Momjian
On Tue, Mar 4, 2014 at 04:52:56PM +0100, Pavel Raiskup wrote: Hello, RFE: Consider that you want to run pg_upgrade via some script with some default '-o' option. But then you also want to give the script's user a chance to specify the old-server's options according user's needs. Then

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-21 Thread Alvaro Herrera
Tom Lane wrote: Alvaro Herrera alvhe...@2ndquadrant.com writes: Agreed. I am going over this patch, and the last bit I need to sort out is the wording of these messages. I have temporarily settled on this: ereport(ERROR,

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread David Fetter
On Thu, Aug 21, 2014 at 06:15:33PM -0400, Stephen Frost wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: Andrew Dunstan and...@dunslane.net writes: I'm inclined to think that the audience for this is far larger than the audience for the cube extension, which I have not once encountered in

Re: [HACKERS] Should extension--unpackaged-$ver.sql's \echo use FROM unpackaged;?

2014-08-21 Thread Andres Freund
On 2014-07-06 16:58:33 -0400, Robert Haas wrote: On Thu, Jul 3, 2014 at 9:03 AM, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Jul 3, 2014 at 4:26 AM, Andres Freund and...@2ndquadrant.com wrote: Hi, Fujii noticed that I'd used \echo Use CREATE EXTENSION pg_buffercache to load this

Re: [HACKERS] ALTER TABLESPACE MOVE command tag tweak

2014-08-21 Thread Stephen Frost
Alvaro, * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: ALTER TABLE ALL IN TABLESPACE xyz which AFAICS should work since ALL is already a reserved keyword. Pushed to master and REL9_4_STABLE. Apologies on it taking so long- things have a bit interesting for me over the past month or two.

Re: [HACKERS] Is this a bug?

2014-08-21 Thread Bruce Momjian
On Tue, Mar 18, 2014 at 09:11:46AM -0400, Robert Haas wrote: On Mon, Mar 17, 2014 at 10:27 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, Mar 18, 2014 at 10:24 AM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Thu, Mar 13, 2014 at 10:22 AM, Robert Haas

Re: [HACKERS] pgcrypto: PGP signatures

2014-08-21 Thread Thomas Munro
Hi Marko, I took a quick look at your patch at http://www.postgresql.org/message-id/53edbcf0.9070...@joh.to (sorry I didn't reply directly as I didn't have the message). It applies cleanly, builds, and the tests pass. I will hopefully have more to say after I've poked at it and understood it

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-21 Thread Fabrízio de Royes Mello
On Thu, Aug 21, 2014 at 8:04 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Andres Freund wrote: Have you looked at the correctness of the patch itself? Last time I'd looked it has fundamental correctness issues. I'd outlined a possible solution, but I haven't looked since. Yeah,

Re: [HACKERS] WIP Patch for GROUPING SETS phase 1

2014-08-21 Thread Andrew Gierth
Stephen == Stephen Frost sfr...@snowman.net writes: I'm inclined to think that the audience for this is far larger than the audience for the cube extension, which I have not once encountered in the field. Stephen +1 Most of my encounters with cube have been me suggesting it to people on

Re: [HACKERS] New Model For Role Attributes and Fine Grained Permssions

2014-08-21 Thread Stephen Frost
Heikki, * Heikki Linnakangas (hlinnakan...@vmware.com) wrote: On 08/19/2014 04:27 AM, Brightwell, Adam wrote: This is a proof-of-concept patch for a new model around role attributes and fine grained permissions meant to alleviate the current over dependence on superuser. Hmm. How does this

Re: [HACKERS] inherit support for foreign tables

2014-08-21 Thread Noah Misch
On Wed, Aug 20, 2014 at 08:11:01PM +0900, Etsuro Fujita wrote: (2014/07/02 11:23), Noah Misch wrote: Your chosen ANALYZE behavior is fair, but the messaging from a database-wide ANALYZE VERBOSE needs work: INFO: analyzing test_foreign_inherit.parent INFO: parent: scanned 1 of 1 pages,

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-21 Thread Fabrízio de Royes Mello
On Thu, Aug 21, 2014 at 10:26 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: On Thu, Aug 21, 2014 at 8:04 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Andres Freund wrote: Have you looked at the correctness of the patch itself? Last time I'd looked it has

Re: [HACKERS] Removing dependency to wsock32.lib when compiling code on WIndows

2014-08-21 Thread Noah Misch
On Thu, Aug 21, 2014 at 09:18:22AM -0400, Andrew Dunstan wrote: On 08/15/2014 11:00 PM, Noah Misch wrote: On Fri, Aug 15, 2014 at 12:49:36AM -0700, Michael Paquier wrote: Btw, how do you determine if MSVC is using HAVE_GETADDRINFO? Is it decided by the inclusion of getaddrinfo.c in

[HACKERS] Are postgresql-9.4 binaries available on Windows XP?

2014-08-21 Thread Hiroshi Inoue
Hi Dave and Andrew, I recently noticed the thread [BUGS] BUG #11039: installation fails when trying to install C++ redistributable . Unfortunately I have no XP machine at hand and can't test the installer by myself. Looking at the binaries in the package, they seem to be built using Visual

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-21 Thread Alvaro Herrera
Fabrízio de Royes Mello wrote: I forgot to mention... I did again a lot of tests using different replication scenarios to make sure all is ok: - slaves async - slaves sync - cascade slaves On v13 you mean? -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] [GSoC2014] Patch ALTER TABLE ... SET LOGGED

2014-08-21 Thread Fabrízio de Royes Mello
Em sexta-feira, 22 de agosto de 2014, Alvaro Herrera alvhe...@2ndquadrant.com escreveu: Fabrízio de Royes Mello wrote: I forgot to mention... I did again a lot of tests using different replication scenarios to make sure all is ok: - slaves async - slaves sync - cascade slaves On

Re: [HACKERS] inherit support for foreign tables

2014-08-21 Thread Alvaro Herrera
Noah Misch wrote: I'm anticipating a bug report along these lines: I saw poor estimates involving a child foreign table, so I ran ANALYZE VERBOSE, which reported 'INFO: analyzing public.parent inheritance tree'. Estimates remained poor, so I scratched my head for awhile before

Re: [HACKERS] option -T in pg_basebackup doesn't work on windows

2014-08-21 Thread Amit Kapila
On Thu, Aug 21, 2014 at 3:44 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Tue, Aug 19, 2014 at 9:51 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Mon, Aug 18, 2014 at 7:50 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Wouldn't it make a lot more sense to create it correctly

Re: [HACKERS] pg_receivexlog --status-interval add fsync feedback

2014-08-21 Thread furuyao
Thank you for updating the patch. I reviewed the patch. First of all, I think that we should not append the above message to section of '-r' option. (Or these message might not be needed at all) Whether flush location in feedback message is valid, is not depend on '-r' option. If we

Re: Compute attr_needed for child relations (was Re: [HACKERS] inherit support for foreign tables)

2014-08-21 Thread Ashutosh Bapat
On Thu, Aug 21, 2014 at 3:00 PM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: (2014/08/21 13:21), Ashutosh Bapat wrote: On Wed, Aug 20, 2014 at 3:25 PM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp mailto:fujita.ets...@lab.ntt.co.jp wrote: Hi Ashutish, I am sorry that I mistook

Re: [HACKERS] Proposal to add a QNX 6.5 port to PostgreSQL

2014-08-21 Thread Noah Misch
On Thu, Aug 21, 2014 at 01:33:38AM +0200, Andres Freund wrote: On 2014-07-25 18:29:53 -0400, Tom Lane wrote: * QNX lacks sigaction SA_RESTART: I modified src/include/port.h to define macros to retry system calls upon EINTR (open,read,write,...) when compiled on QNX That's