Re: [HACKERS] Additional role attributes superuser review

2015-01-01 Thread Magnus Hagander
On Wed, Dec 31, 2014 at 4:23 PM, Stephen Frost sfr...@snowman.net wrote: * Magnus Hagander (mag...@hagander.net) wrote: On Wed, Dec 31, 2014 at 3:08 PM, Stephen Frost sfr...@snowman.net wrote: * Magnus Hagander (mag...@hagander.net) wrote: I think having it do exactly what pg_dump needs

Re: [HACKERS] Additional role attributes superuser review

2014-12-31 Thread Magnus Hagander
On Tue, Dec 30, 2014 at 4:16 PM, Stephen Frost sfr...@snowman.net wrote: * Magnus Hagander (mag...@hagander.net) wrote: On Mon, Dec 29, 2014 at 11:01 PM, Stephen Frost sfr...@snowman.net wrote: That said, a 'DUMP' privilege which allows the user to dump the contents of the entire

Re: [HACKERS] Additional role attributes superuser review

2014-12-31 Thread Magnus Hagander
On Wed, Dec 31, 2014 at 3:08 PM, Stephen Frost sfr...@snowman.net wrote: * Magnus Hagander (mag...@hagander.net) wrote: On Tue, Dec 30, 2014 at 4:16 PM, Stephen Frost sfr...@snowman.net wrote: The approach I was thinking was to document and implement this as impliciting granting exactly

Re: [HACKERS] Additional role attributes superuser review

2014-12-30 Thread Magnus Hagander
to DUMP by default - perhaps we need a separate one for DUMPAUTH or DUMPPASSWORDS. (We could dump all the users *without* passwords with just the DUMP privilege) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Additional role attributes superuser review

2014-12-26 Thread Magnus Hagander
. (And a better description - what is xlog operations really?) And the one under WAL would be very similar to what REPLICATION does today. Or are you saying that it should specifically *not* allow base backups done through the replication protocol, only the exclusive ones? -- Magnus Hagander Me: http

Re: [HACKERS] Re: [pgsql-pkg-debian] Updated libpq5 packages cause connection errors on postgresql 9.2

2014-12-20 Thread Magnus Hagander
On Fri, Dec 19, 2014 at 3:57 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Fri, Dec 19, 2014 at 11:52 AM, Christoph Berg c...@df7cb.de wrote: Googling for digest too big for rsa key seems to indicate that this problem occurs when you are using

[HACKERS] Re: [pgsql-pkg-debian] Updated libpq5 packages cause connection errors on postgresql 9.2

2014-12-19 Thread Magnus Hagander
too small for. And we did change that in 9.4 - commit 326e1d73c476a0b5061ef00134bdf57aed70d5e7 disabled SSL in favor of always using TLS for security reasons. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Some modes of vcregress not mentioned in MSVC scripts

2014-12-17 Thread Magnus Hagander
(pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] analyze_new_cluster.bat and delete_old_cluster.bat not ignored with vcregress upgradecheck

2014-12-17 Thread Magnus Hagander
be good to back-patch the patch attached to prevent the inclusion of those files in the future. Applied, thanks. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Custom timestamp format in logs

2014-12-14 Thread Magnus Hagander
)t or such in the log_line_prefix itself in that case? That could also be expanded to other parameters, should we need them? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

Re: [HACKERS] Commitfest problems

2014-12-12 Thread Magnus Hagander
feature of it. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Commitfest problems

2014-12-12 Thread Magnus Hagander
On Fri, Dec 12, 2014 at 9:05 PM, Josh Berkus j...@agliodbs.com wrote: On 12/12/2014 11:52 AM, Magnus Hagander wrote: On Fri, Dec 12, 2014 at 8:43 PM, Tomas Vondra t...@fuzzy.cz wrote: On 11.12.2014 16:06, Bruce Momjian wrote: On Wed, Dec 10, 2014 at 11:00:21PM -0800, Josh Berkus wrote: 3

Re: [HACKERS] GSSAPI, SSPI - include_realm default

2014-12-09 Thread Magnus Hagander
On Dec 9, 2014 10:52 PM, Peter Eisentraut pete...@gmx.net wrote: On 12/5/14 1:06 PM, Stephen Frost wrote: I suggest we also backpatch some documentation suggesting that people manually change the include_realm parameter (perhaps also with a note saying that the default will change in

Re: [HACKERS] Buildfarm not happy with test module move

2014-12-01 Thread Magnus Hagander
? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] How about a option to disable autovacuum cancellation on lock conflict?

2014-11-29 Thread Magnus Hagander
On Nov 29, 2014 9:23 AM, Andres Freund and...@2ndquadrant.com wrote: Hi, I've more than once seen that autovacuums on certain tables never succeed because regular exclusive (or similar) lockers cause it to give way/up before finishing. Usually if some part of the application uses explicit

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Magnus Hagander
of that was specifically a concern on Windows of course, since no dependencies can be expected to exist there - icu is a lot more likely to already exist packaged up on linux/bsd) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list

Re: [HACKERS] [pgsql-packagers] Palle Girgensohn's ICU patch

2014-11-26 Thread Magnus Hagander
with broken text sorting is acceptable; but I can't speak on behalf of the other contributors to Postgres.app without consulting them first. Is it broken *worse* in 9.4 than it was in previous versions? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com

Re: [HACKERS] GSSAPI, SSPI - include_realm default

2014-11-26 Thread Magnus Hagander
also backpatch some documentation suggesting that people manually change the include_realm parameter (perhaps also with a note saying that the default will change in 9.5). -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing

Re: [HACKERS] [PATCH] add ssl_protocols configuration option

2014-11-20 Thread Magnus Hagander
*definitely* drop SSLv2, and we should. But anything that we're going to reject at a later stage anyway, we should reject early. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] [PATCH] add ssl_protocols configuration option

2014-11-20 Thread Magnus Hagander
On Thu, Nov 20, 2014 at 10:19 AM, Dag-Erling Smørgrav d...@des.no wrote: Magnus Hagander mag...@hagander.net writes: Alex Shulgin a...@commandprompt.com writes: * The code allows specifying SSLv2 and SSLv3 in the GUC, but removes them forcibly after parsing the complete string (a warning

Re: [HACKERS] PostgreSQL doesn't stop propley when --slot option is specified with pg_receivexlog.

2014-11-19 Thread Magnus Hagander
! Is this: + if (reportFlushPosition lastFlushPosition blockpos + walfile != 1) really correct? Shouldn't that walfile test be against -1 (minus one)? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] SSL information view

2014-11-19 Thread Magnus Hagander
On Tue, Nov 11, 2014 at 1:04 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, Nov 11, 2014 at 1:43 AM, Magnus Hagander mag...@hagander.net wrote: Right now it just truncates the dn at NAMEDATALEN - so treating it the same as we do with hostnames. My guess is this is not a big

Re: [HACKERS] Order of views in stats docs

2014-11-16 Thread Magnus Hagander
On Sun, Nov 9, 2014 at 3:46 PM, Magnus Hagander mag...@hagander.net wrote: On Thu, Nov 6, 2014 at 3:01 PM, Peter Eisentraut pete...@gmx.net wrote: On 11/6/14 6:16 AM, Magnus Hagander wrote: Another thought I had in that case is maybe we need to break out the pg_stat_activity

Re: [HACKERS] remove pg_standby?

2014-11-10 Thread Magnus Hagander
with a version that's not even supported anymore - so strong +1 for getting rid of it. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] SSL information view

2014-11-10 Thread Magnus Hagander
On Mon, Jul 21, 2014 at 5:24 PM, Bernd Helmle maili...@oopsware.de wrote: --On 12. Juli 2014 15:08:01 +0200 Magnus Hagander mag...@hagander.net wrote: Before doing that, however, I'd like to ask for opinions :) The hack currently exposes a separate view that you can join

Re: [HACKERS] remove pg_standby?

2014-11-10 Thread Magnus Hagander
On Nov 10, 2014 6:16 PM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Nov 5, 2014 at 6:36 AM, Peter Eisentraut pete...@gmx.net wrote: While we're talking about removing old things, is there any use left for pg_standby? -1 for removing it. There is still the case where I'd like to use

Re: [HACKERS] remove pg_standby?

2014-11-10 Thread Magnus Hagander
as pg_standby has features that are actually useful and that are not in the built-in system, we shouldn't remove it. We should, however, try to fix those in the main system so we can get rid of it after that :) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com

Re: [HACKERS] Order of views in stats docs

2014-11-09 Thread Magnus Hagander
On Thu, Nov 6, 2014 at 3:01 PM, Peter Eisentraut pete...@gmx.net wrote: On 11/6/14 6:16 AM, Magnus Hagander wrote: Another thought I had in that case is maybe we need to break out the pg_stat_activity and pg_stat_replication views into their own table. They are really the only two views

Re: [HACKERS] Order of views in stats docs

2014-11-06 Thread Magnus Hagander
On Wed, Nov 5, 2014 at 4:57 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: http://www.postgresql.org/docs/9.3/static/monitoring-stats.html, table 27-1. Can somebody find or explain the order of the views in there? It's not actually alphabetical, but it's

[HACKERS] Order of views in stats docs

2014-11-05 Thread Magnus Hagander
of the table without realizing the order that I'm missing now and am about to break? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Time to remove dummy autocommit GUC?

2014-11-05 Thread Magnus Hagander
On Nov 5, 2014 5:27 PM, Kevin Grittner kgri...@ymail.com wrote: Tom Lane t...@sss.pgh.pa.us wrote: ISTM that by now we could just flat-out remove it. +1 +1. I thought we had already removed it years ago :-) /Magnus

[HACKERS] pg_receivelog completion command

2014-11-02 Thread Magnus Hagander
we could have a background process that queues them up - much like we do in the main backend, which is definitely more complicated. Thoughts on the best way to deal with that? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers

Re: [HACKERS] pg_receivelog completion command

2014-11-02 Thread Magnus Hagander
On Sun, Nov 2, 2014 at 2:31 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-11-02 14:26:04 +0100, Magnus Hagander wrote: I had a discussion with a few people recently about a hack I wrote for pg_receivexlog at some point, but never ended up submitting, and in cleaning that up realized

Re: [HACKERS] Superuser connect during smart shutdown

2014-10-19 Thread Magnus Hagander
On Oct 19, 2014 4:34 AM, Robert Haas robertmh...@gmail.com wrote: But TBH I suspect 95% of the problems here would vanish if smart shutdown weren't the default ... But for your repeated objections, we would have changed the default to fast years ago. AFAICT everyone else is in favor of

Re: [HACKERS] [PATCH] add ssl_protocols configuration option

2014-10-19 Thread Magnus Hagander
; and on the whole we don't need another marginally-useful GUC. Having the guc could certainly be useful in some cases. If we do, we should of course *also* have a corresponding configuration option in libpq, so I'd say this patch is incomplete if we do want to do it. -- Magnus Hagander Me: http

Re: [HACKERS] [PATCH] add ssl_protocols configuration option

2014-10-19 Thread Magnus Hagander
On Sun, Oct 19, 2014 at 6:17 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: If anything, I think the default should be default, and then we have that map out to something. Because once you've initdb'ed, the config file wil be stuck with a default and we

Re: [HACKERS] [PATCH] add ssl_protocols configuration option

2014-10-19 Thread Magnus Hagander
On Oct 19, 2014 9:18 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Sun, Oct 19, 2014 at 6:17 PM, Tom Lane t...@sss.pgh.pa.us wrote: And in the end, if we set values like this from PG --- whether hard-wired or via a GUC --- the SSL library people

Re: [HACKERS] Additional role attributes superuser review

2014-10-16 Thread Magnus Hagander
On Oct 16, 2014 1:59 PM, Stephen Frost sfr...@snowman.net wrote: * Simon Riggs (si...@2ndquadrant.com) wrote: On 15 October 2014 06:22, Stephen Frost sfr...@snowman.net wrote: BACKUP: pg_start_backup() pg_stop_backup() pg_switch_xlog() pg_create_restore_point()

Re: [HACKERS] Corporate and Individual Contributor License Agreements (CLAs)

2014-10-06 Thread Magnus Hagander
://wiki.postgresql.org/wiki/Developer_FAQ#Do_I_need_to_sign_a_copyright_assignment.3F Bottom line is, there is no CLA to sign. (And the PostgeSQL Global Development Group certainly has it's own website - it's www.postgresql.org) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill

Re: [HACKERS] Last Commitfest patches waiting review

2014-10-03 Thread Magnus Hagander
. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] open items for 9.4

2014-09-29 Thread Magnus Hagander
stuff. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] make pg_controldata accept -D dirname

2014-09-24 Thread Magnus Hagander
anything, not even if you have a data directory named -D. I haven't looked at the code, but definitely +1 for the feature. That's really quite annoying. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Should we excise the remnants of borland cc support?

2014-09-23 Thread Magnus Hagander
On Sep 23, 2014 2:51 AM, Tom Lane t...@sss.pgh.pa.us wrote: Andres Freund and...@2ndquadrant.com writes: On 2014-09-20 10:03:43 -0400, Andrew Dunstan wrote: I thought the Borland stuff was there only so we could build client libraries for use with things like Delphi. FWIW I got offlist

Re: [HACKERS] TODO item for protocol revision: Negotiate encryption in connection handshake

2014-09-03 Thread Magnus Hagander
of some more generic capabilities negotiation though, even if we only have SSL to begin with. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] pg_receivexlog and replication slots

2014-08-31 Thread Magnus Hagander
regular if statements for things that can happen, and just ignore the others I think - since the callers are fairly simple to trace. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-29 Thread Magnus Hagander
On Fri, Aug 29, 2014 at 10:34 PM, Peter Eisentraut pete...@gmx.net wrote: On 8/27/14 2:55 AM, Magnus Hagander wrote: I think the easy way of doing that is to just create an xlog.tar file. Since we already create base.tar and possibly n*tablespace.tar, adding one more file shouldn't be a big

Re: [HACKERS] re-reading SSL certificates during server reload

2014-08-28 Thread Magnus Hagander
On Thu, Aug 28, 2014 at 3:20 AM, Robert Haas robertmh...@gmail.com wrote: On Wed, Aug 27, 2014 at 6:40 AM, Magnus Hagander mag...@hagander.net wrote: On Wed, Aug 27, 2014 at 11:56 AM, Alexey Klyukin al...@hintbits.com wrote: Greetings, Is there a strong reason to disallow reloading server key

Re: [HACKERS] re-reading SSL certificates during server reload

2014-08-28 Thread Magnus Hagander
On Thu, Aug 28, 2014 at 4:05 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Thu, Aug 28, 2014 at 3:20 AM, Robert Haas robertmh...@gmail.com wrote: On Wed, Aug 27, 2014 at 6:40 AM, Magnus Hagander mag...@hagander.net wrote: Key and cert files are loaded

Re: [HACKERS] re-reading SSL certificates during server reload

2014-08-28 Thread Magnus Hagander
On Thu, Aug 28, 2014 at 4:14 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-08-28 10:12:19 -0400, Tom Lane wrote: Magnus Hagander mag...@hagander.net writes: On Thu, Aug 28, 2014 at 4:05 PM, Tom Lane t...@sss.pgh.pa.us wrote: Why would they need to be BACKEND, as opposed to just

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-27 Thread Magnus Hagander
On Wed, Aug 27, 2014 at 5:16 AM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Aug 27, 2014 at 6:16 AM, Magnus Hagander mag...@hagander.net wrote: On Tue, Aug 26, 2014 at 10:46 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-08-26 16:41:44 -0400, Peter Eisentraut wrote: On 8/26/14

Re: [HACKERS] re-reading SSL certificates during server reload

2014-08-27 Thread Magnus Hagander
diong to support non-openssl libraries. Making a change like this at the same time is probably a good idea. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Sample LDIF for pg_service.conf no longer works

2014-08-27 Thread Magnus Hagander
into that problem as wel,l just not had time to prepare a proper example in the core schema :) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-26 Thread Magnus Hagander
of WAL. -x is a good default for smaller systems, but -X is a safer one for bigger ones. So I agree that changing the default mode would make sense. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-26 Thread Magnus Hagander
On Tue, Aug 26, 2014 at 6:51 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-08-26 18:40:27 +0200, Magnus Hagander wrote: On Mon, Aug 25, 2014 at 1:35 PM, Andres Freund and...@2ndquadrant.com wrote: Hi, currently pg_basebackup uses fetch mode when only -x is specified - which

Re: [HACKERS] Missing comment block at the top of streamutil.h and receivelog.h

2014-08-26 Thread Magnus Hagander
it. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Switch pg_basebackup to use -X stream instead of -X fetch by default?

2014-08-26 Thread Magnus Hagander
On Tue, Aug 26, 2014 at 10:46 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-08-26 16:41:44 -0400, Peter Eisentraut wrote: On 8/26/14 12:40 PM, Magnus Hagander wrote: I think the first reason is gone now, and the risk/damage of the two connections is probably smaller than running

Re: [HACKERS] Hardening pg_upgrade

2014-08-21 Thread Magnus Hagander
on that old a version. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PQgetssl() and alternative SSL implementations

2014-08-19 Thread Magnus Hagander
to meet the needs of the ODBC driver too. +1. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PQgetssl() and alternative SSL implementations

2014-08-19 Thread Magnus Hagander
document which are available from all of them, but I'd hope the list of only in X is pretty small. +1. I bet the most common ones will be in all of them, because frankly, it's functionality you just need to use SSL properly. -- Magnus Hagander Me: http://www.hagander.net/ Work: http

Re: [HACKERS] PQgetssl() and alternative SSL implementations

2014-08-19 Thread Magnus Hagander
using a mix of openssl and gnutls or a mix of nss and openssl for example. It's not likely to happen as long as you only use the officially built packages, but you're likely in for quite a bit of pain if you are using any non-standard packaging like the oneclick installers etc. -- Magnus Hagander

Re: [HACKERS] PQgetssl() and alternative SSL implementations

2014-08-19 Thread Magnus Hagander
On Tue, Aug 19, 2014 at 9:09 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Tue, Aug 19, 2014 at 8:49 PM, Robert Haas robertmh...@gmail.com wrote: I have a hard time believing that something like this will really satisfy anyone. Why not just add

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-07-25 Thread Magnus Hagander
it to the next CF - this was just a very quick review, and it needs a proper one along with openssl version testing :) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] implement subject alternative names support for SSL connections

2014-07-25 Thread Magnus Hagander
On Fri, Jul 25, 2014 at 7:15 PM, Alexey Klyukin al...@hintbits.com wrote: On Fri, Jul 25, 2014 at 6:34 PM, Magnus Hagander mag...@hagander.net wrote: I just took a very quick look at the code, and just noticed one thing: Why keep looping once you've found a match? When you set result=true

[HACKERS] 9.4 docs current as of

2014-07-24 Thread Magnus Hagander
9.4 beta docs are listed as Current as of 2014-05-10. I'm assuming that's just a step we missed in the version stamping? Needs to go on a checklist? Should we backpatch a fix for that? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql

Re: [HACKERS] 9.4 docs current as of

2014-07-24 Thread Magnus Hagander
On Thu, Jul 24, 2014 at 5:17 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: 9.4 beta docs are listed as Current as of 2014-05-10. I'm assuming that's just a step we missed in the version stamping? No, what that means is that nobody has looked at the commit

[HACKERS] PDF builds broken again

2014-07-23 Thread Magnus Hagander
file produced! Do we actually have any buildfarm boxes building the PDFs? And if so, any idea why they didn't catch it? Do we have a reasonable way to figure out which commit actually broke it, other than manually testing backing out each of the 11 commits since 9.0.17? -- Magnus Hagander

Re: [HACKERS] PDF builds broken again

2014-07-23 Thread Magnus Hagander
On Wed, Jul 23, 2014 at 12:31 PM, Magnus Hagander mag...@hagander.net wrote: It seems at least the 9.0 PDFs are broken (trying to build for the release): Lots of errors/warnings (and AFAIK no way to see which is which in the output), but It hink this is the telltale as usual: Overfull \hbox

Re: [HACKERS] PDF builds broken again

2014-07-23 Thread Magnus Hagander
On Wed, Jul 23, 2014 at 1:31 PM, Magnus Hagander mag...@hagander.net wrote: On Wed, Jul 23, 2014 at 12:31 PM, Magnus Hagander mag...@hagander.net wrote: It seems at least the 9.0 PDFs are broken (trying to build for the release): Lots of errors/warnings (and AFAIK no way to see which is which

Re: [HACKERS] PDF builds broken again

2014-07-23 Thread Magnus Hagander
On Wed, Jul 23, 2014 at 3:15 PM, Magnus Hagander mag...@hagander.net wrote: On Wed, Jul 23, 2014 at 1:31 PM, Magnus Hagander mag...@hagander.net wrote: On Wed, Jul 23, 2014 at 12:31 PM, Magnus Hagander mag...@hagander.net wrote: It seems at least the 9.0 PDFs are broken (trying to build

Re: [HACKERS] PDF builds broken again

2014-07-23 Thread Magnus Hagander
On Wed, Jul 23, 2014 at 4:06 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: On Wed, Jul 23, 2014 at 12:31 PM, Magnus Hagander mag...@hagander.net wrote: ! pdfTeX error (ext4): \pdfendlink ended up in different nesting level than \pd Additional point

Re: [HACKERS] PDF builds broken again

2014-07-23 Thread Magnus Hagander
On Wed, Jul 23, 2014 at 10:15 PM, Andrew Dunstan and...@dunslane.net wrote: On 07/23/2014 06:31 AM, Magnus Hagander wrote: Do we actually have any buildfarm boxes building the PDFs? And if so, any idea why they didn't catch it? AFAIK, nobody's ever asked for such a thing. The docs

Re: [HACKERS] [bug fix] pg_ctl always uses the same event source

2014-07-21 Thread Magnus Hagander
On Sun, Jul 20, 2014 at 7:44 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Fri, Jul 18, 2014 at 7:08 PM, MauMau maumau...@gmail.com wrote: From: Magnus Hagander mag...@hagander.net On Fri, Jul 18, 2014 at 5:33 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Thu, Jul 17, 2014 at 4:51

Re: [HACKERS] [bug fix] pg_ctl always uses the same event source

2014-07-18 Thread Magnus Hagander
On Fri, Jul 18, 2014 at 5:33 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Thu, Jul 17, 2014 at 4:51 PM, Magnus Hagander mag...@hagander.net wrote: Did anyone actually test this patch? :) I admit I did not build it on Windows specifically because I assumed that was done as part

Re: [HACKERS] [bug fix] pg_ctl always uses the same event source

2014-07-17 Thread Magnus Hagander
the patch with this change, so please verify that it still works. I also rewrote the documentation slightly. With that, applied. Thanks! -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] [bug fix] pg_ctl always uses the same event source

2014-07-17 Thread Magnus Hagander
On Thu, Jul 17, 2014 at 12:45 PM, Magnus Hagander mag...@hagander.net wrote: On Wed, Jul 16, 2014 at 2:01 PM, MauMau maumau...@gmail.com wrote: From: Amit Kapila amit.kapil...@gmail.com So as a conclusion, the left over items to be handled for patch are: 1. Remove the new usage related

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-07-16 Thread Magnus Hagander
On Jul 16, 2014 7:05 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Tom Lane wrote: Dilip kumar dilip.ku...@huawei.com writes: On 15 July 2014 19:01, Magnus Hagander Wrote, I am late to this game, but the first thing to my mind was - do we really need the whole forking/threading

Re: [HACKERS] [bug fix] pg_ctl always uses the same event source

2014-07-16 Thread Magnus Hagander
On Wed, Jul 16, 2014 at 6:37 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Tue, Jul 15, 2014 at 8:57 PM, MauMau maumau...@gmail.com wrote: From: Magnus Hagander mag...@hagander.net Well, it does in a couple of places. I'm nto sure it's that important (as nobody has AFAIK ever requested

Re: [HACKERS] SSL information view

2014-07-16 Thread Magnus Hagander
On Mon, Jul 14, 2014 at 7:54 PM, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: On 07/13/2014 10:35 PM, Magnus Hagander wrote: On Sun, Jul 13, 2014 at 10:32 PM, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: On 07/12/2014 03:08 PM, Magnus Hagander wrote: As an administrator, I find

Re: [HACKERS] [bug fix] pg_ctl always uses the same event source

2014-07-16 Thread Magnus Hagander
On Wed, Jul 16, 2014 at 12:31 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Wed, Jul 16, 2014 at 2:11 PM, Magnus Hagander mag...@hagander.net wrote: On Wed, Jul 16, 2014 at 6:37 AM, Amit Kapila amit.kapil...@gmail.com wrote: There's also the change to throw an error if the source

Re: [HACKERS] Removing dependency to wsock32.lib when compiling code on WIndows

2014-07-15 Thread Magnus Hagander
with michael about the scaryness of touching this. Also, it is definitely a separate patch if we do... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] [bug fix] pg_ctl always uses the same event source

2014-07-15 Thread Magnus Hagander
source, and not the pg_ctl source - so we need to make it really clear that this is *only* for output from pg_ctl). -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Removing dependency to wsock32.lib when compiling code on WIndows

2014-07-15 Thread Magnus Hagander
On Tue, Jul 15, 2014 at 2:14 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, Jul 15, 2014 at 8:46 PM, Magnus Hagander mag...@hagander.net wrote: On Thu, Jun 19, 2014 at 4:13 PM, MauMau maumau...@gmail.com wrote: From: Michael Paquier michael.paqu...@gmail.com You are right, I

Re: [HACKERS] SSL compression info in psql header

2014-07-15 Thread Magnus Hagander
On Tue, Jul 15, 2014 at 1:08 AM, Robert Haas robertmh...@gmail.com wrote: On Sat, Jul 12, 2014 at 8:49 AM, Magnus Hagander mag...@hagander.net wrote: It's today really hard to figure out if your SSL connection is actually *using* SSL compression. This got extra hard when we the default value

Re: [HACKERS] TODO : Allow parallel cores to be used by vacuumdb [ WIP ]

2014-07-15 Thread Magnus Hagander
review i also noticed - you added quoting of the table name, but forgot to do it for the schema name. You should probably also look at using something like quote_identifier(), that'll make things easier). -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com

Re: [HACKERS] Audit of logout

2014-07-15 Thread Magnus Hagander
just superuser vs non-superuser... I think going with the PGC_SU_BACKEND is the right choice at this time, until we have an actual usecase for the other :) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] [bug fix] pg_ctl always uses the same event source

2014-07-15 Thread Magnus Hagander
On Tue, Jul 15, 2014 at 4:01 PM, MauMau maumau...@gmail.com wrote: From: Magnus Hagander mag...@hagander.net Is there a reason for there still being changes in guc.c, pgevent.c etc? Shouldn't it all be confined to pg_ctl now? That's my understanding from the thread that that's the only part

Re: [HACKERS] SSL compression info in psql header

2014-07-15 Thread Magnus Hagander
On Tue, Jul 15, 2014 at 4:28 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: As far as my research shows, the function SSL_get_current_compression() which it uses was added in OpenSSL 0.9.6, which is a long time ago (stopped being maintained in 2004). AFAICT

Re: [HACKERS] SSL compression info in psql header

2014-07-15 Thread Magnus Hagander
On Tue, Jul 15, 2014 at 4:41 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: Out of curiosity, since one of those boxes seems to be yours, which version of OpenSSL does it actually have? Claims to be 0.9.7: cube:~ tgl$ ls -l /usr/lib/*ssl* -rwxr-xr-x 1

Re: [HACKERS] SSL compression info in psql header

2014-07-15 Thread Magnus Hagander
On Tue, Jul 15, 2014 at 6:03 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: Being a completely newbie when it comes to writing configure checks - does this seem correct? Looks reasonable to me. Thanks, I've applied it - let's hope the buildfarm is happier

Re: [HACKERS] SSL information view

2014-07-13 Thread Magnus Hagander
On Sun, Jul 13, 2014 at 10:32 PM, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: On 07/12/2014 03:08 PM, Magnus Hagander wrote: As an administrator, I find that you fairly often want to know what your current connections are actually using as SSL parameters, and there is currently

Re: [HACKERS] Missing autocomplete for CREATE DATABASE

2014-07-12 Thread Magnus Hagander
On Fri, Jul 11, 2014 at 1:10 PM, Magnus Hagander mag...@hagander.net wrote: On Fri, Jul 11, 2014 at 12:01 AM, Vik Fearing vik.fear...@dalibo.com wrote: On 07/10/2014 09:32 PM, Magnus Hagander wrote: It seems psql is missing autocomplete entries for LC_COLLATE and LC_CTYPE for the CREATE

[HACKERS] SSL compression info in psql header

2014-07-12 Thread Magnus Hagander
for whether it returns NULL or not. Comments? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ diff --git a/src/bin/psql/command.c b/src/bin/psql/command.c index cede72a..b8a8e35 100644 --- a/src/bin/psql/command.c +++ b/src/bin/psql/command.c @@ -1800,8 +1800,9

[HACKERS] SSL information view

2014-07-12 Thread Magnus Hagander
in pg_stat_activity and pg_stat_replication? Second, I was planning to implement it by adding fields to PgBackendStatus and thus to BackendStatusArray, booleans directly in the struct and strings similar to how we track for example hostnames. Anybody see a problem with that? -- Magnus Hagander Me: http

Re: [HACKERS] SSL information view

2014-07-12 Thread Magnus Hagander
On Sat, Jul 12, 2014 at 4:36 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: As an administrator, I find that you fairly often want to know what your current connections are actually using as SSL parameters, and there is currently no other way than gdb

Re: [HACKERS] Extending MSVC scripts to support --with-extra-version

2014-07-12 Thread Magnus Hagander
it. Applied, thanks! -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] pg_receivexlog and replication slots

2014-07-11 Thread Magnus Hagander
that I remember about being able to use an auto-drop slot in pg_basebackup, but this would be different - this would be about creating and dropping a regular physical replication slot... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql

Re: [HACKERS] pg_receivexlog and replication slots

2014-07-11 Thread Magnus Hagander
On Fri, Jul 11, 2014 at 11:14 AM, Andres Freund and...@2ndquadrant.com wrote: On 2014-07-11 11:08:48 +0200, Magnus Hagander wrote: Is there a particular reason why pg_receivexlog only supports using manually created slots but pg_recvlogical supports creating and dropping them? Wouldn't

Re: [HACKERS] Missing autocomplete for CREATE DATABASE

2014-07-11 Thread Magnus Hagander
On Fri, Jul 11, 2014 at 12:01 AM, Vik Fearing vik.fear...@dalibo.com wrote: On 07/10/2014 09:32 PM, Magnus Hagander wrote: It seems psql is missing autocomplete entries for LC_COLLATE and LC_CTYPE for the CREATE DATABASE command. Attached patch adds that. I doubt this is important enough

[HACKERS] Missing autocomplete for CREATE DATABASE

2014-07-10 Thread Magnus Hagander
It seems psql is missing autocomplete entries for LC_COLLATE and LC_CTYPE for the CREATE DATABASE command. Attached patch adds that. I doubt this is important enough to backpatch - thoughts? -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ diff --git a/src

Re: [HACKERS] 9.5 CF1

2014-06-18 Thread Magnus Hagander
. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/

<    3   4   5   6   7   8   9   10   11   12   >