On Wed, Feb 20, 2013 at 2:16 PM, Heikki Linnakangas
wrote:
> Where does this leave the PQconninfoParseParams/PQconninfodefaultsMerge
> patch? I'm not sure. Somehow I thought it would be necessary for this work,
> but it wasn't. I didn't remember that we already have PQconninfoParse()
> function, w
On Sun, Feb 17, 2013 at 1:35 AM, Amit kapila wrote:
> On Tuesday, February 12, 2013 2:49 AM Heikki Linnakangas wrote:
> On 04.02.2013 17:32, Alvaro Herrera wrote:
>> Phil Sorber wrote:
>>> On Mon, Feb 4, 2013 at 10:16 AM, Alvaro Herrera
>>> wrote:
>>>&
On Wed, Feb 13, 2013 at 5:48 PM, Josh Berkus wrote:
> On 02/13/2013 02:13 PM, Tom Lane wrote:
>> The big-picture question of course is whether we want to carry and
>> maintain a filesystem-specific hack. I don't have a sense that btrfs
>> is so widely used as to justify this.
>
> If this is a val
On Mon, Feb 11, 2013 at 4:19 PM, Heikki Linnakangas
wrote:
> On 04.02.2013 17:32, Alvaro Herrera wrote:
>>
>> Phil Sorber wrote:
>>>
>>> On Mon, Feb 4, 2013 at 10:16 AM, Alvaro Herrera
>>> wrote:
>>>>
>>>> Phil Sorber wrote
On Fri, Feb 8, 2013 at 1:07 PM, Phil Sorber wrote:
> On Fri, Feb 8, 2013 at 12:46 PM, Fujii Masao wrote:
>> No maybe. But I think that all the client commands should follow the
>> same rule. Otherwise a user would get confused when specifying
>> options.
>
> I would co
On Fri, Feb 8, 2013 at 10:20 AM, Peter Eisentraut wrote:
> On 2/8/13 5:23 AM, Magnus Hagander wrote:
>> But do you have any actual proof that the problem is in "we
>> loose reviewers because we're relying on email"?
>
> Here is one: Me.
>
> Just yesterday I downloaded a piece of software that was
On Fri, Feb 8, 2013 at 12:46 PM, Fujii Masao wrote:
> No maybe. But I think that all the client commands should follow the
> same rule. Otherwise a user would get confused when specifying
> options.
I would consider the rest of the apps using it as a consensus. I will
make sure it aligns in behav
On Wed, Feb 6, 2013 at 11:36 AM, Fujii Masao wrote:
> On Thu, Feb 7, 2013 at 1:15 AM, Phil Sorber wrote:
>> On Wed, Feb 6, 2013 at 11:11 AM, Fujii Masao wrote:
>>> On Thu, Feb 7, 2013 at 12:05 AM, Phil Sorber wrote:
>>>> On Tue, Feb 5, 2013 at 12:44 PM, Phil Sorb
On Wed, Feb 6, 2013 at 11:22 AM, Tom Lane wrote:
> Robert Haas writes:
>> On Tue, Feb 5, 2013 at 12:18 AM, Phil Sorber wrote:
>>> On Mon, Feb 4, 2013 at 10:52 PM, Tom Lane wrote:
>>>> I don't believe that callers should be trying to free() the result.
>&g
On Wed, Feb 6, 2013 at 11:11 AM, Fujii Masao wrote:
> On Thu, Feb 7, 2013 at 12:05 AM, Phil Sorber wrote:
>> On Tue, Feb 5, 2013 at 12:44 PM, Phil Sorber wrote:
>>> On Tue, Feb 5, 2013 at 9:08 AM, Phil Sorber wrote:
>>>> On Tue, Feb 5, 2013 at 9:06 AM, Alvaro He
On Tue, Feb 5, 2013 at 12:44 PM, Phil Sorber wrote:
> On Tue, Feb 5, 2013 at 9:08 AM, Phil Sorber wrote:
>> On Tue, Feb 5, 2013 at 9:06 AM, Alvaro Herrera
>> wrote:
>>> Phil Sorber escribió:
>>>> On Tue, Feb 5, 2013 at 6:41 AM, Robert Haas wrote:
>>
On Wed, Feb 6, 2013 at 9:59 AM, Simon Riggs wrote:
> On 6 February 2013 14:38, Alvaro Herrera wrote:
>> Robert Haas escribió:
>>> On Mon, Feb 4, 2013 at 5:50 PM, Alvaro Herrera
>>> wrote:
>>
>>> > I propose to have a new subdirectory src/include/shared, and two
>>> > header files:
>>
>>> > The
On Tue, Feb 5, 2013 at 9:08 AM, Phil Sorber wrote:
> On Tue, Feb 5, 2013 at 9:06 AM, Alvaro Herrera
> wrote:
>> Phil Sorber escribió:
>>> On Tue, Feb 5, 2013 at 6:41 AM, Robert Haas wrote:
>>> > On Sat, Feb 2, 2013 at 9:55 PM, Phil Sorber wrote:
>>>
On Tue, Feb 5, 2013 at 9:06 AM, Alvaro Herrera wrote:
> Phil Sorber escribió:
>> On Tue, Feb 5, 2013 at 6:41 AM, Robert Haas wrote:
>> > On Sat, Feb 2, 2013 at 9:55 PM, Phil Sorber wrote:
>> >> OK, here is the patch that handles the connection string in dbname.
&
On Tue, Feb 5, 2013 at 6:41 AM, Robert Haas wrote:
> On Sat, Feb 2, 2013 at 9:55 PM, Phil Sorber wrote:
>> OK, here is the patch that handles the connection string in dbname.
>> I'll post the other patch under a different posting because I am sure
>> it will get pl
On Mon, Feb 4, 2013 at 10:52 PM, Tom Lane wrote:
> Phil Sorber writes:
>> get_progname() returns a strdup()'d value. Shouldn't it then be simply
>> char * and not const char *? Otherwise free() complains loudly without
>> a cast.
>
> I don't believe t
get_progname() returns a strdup()'d value. Shouldn't it then be simply
char * and not const char *? Otherwise free() complains loudly without
a cast.
diff --git a/src/include/port.h b/src/include/port.h
new file mode 100644
index 99d3a9b..2d6a435
*** a/src/include/port.h
--- b/src/include/port.h
*
On Mon, Feb 4, 2013 at 10:16 AM, Alvaro Herrera
wrote:
> Phil Sorber wrote:
>> On Mon, Feb 4, 2013 at 9:13 AM, Alvaro Herrera
>> wrote:
>
>> > Uh, no existing code can use this new functionality? That seems
>> > disappointing.
>>
>> I wrote this
On Mon, Feb 4, 2013 at 9:13 AM, Alvaro Herrera wrote:
>
>> > On Feb 3, 2013 4:16 AM, "Phil Sorber" wrote:
>> >>
>> >> This patch came up from discussion about pg_isready.
>> >>
>> >> PQconninfoParseParams is similar to
On Sun, Feb 3, 2013 at 1:37 AM, Magnus Hagander wrote:
>
> On Feb 3, 2013 4:16 AM, "Phil Sorber" wrote:
>>
>> This patch came up from discussion about pg_isready.
>>
>> PQconninfoParseParams is similar to PQconninfoParse but takes two
>> arrays
This patch came up from discussion about pg_isready.
PQconninfoParseParams is similar to PQconninfoParse but takes two
arrays like PQconnectdbParams. It essentially exposes
conninfo_array_parse().
PQconninfodefaultsMerge essentially exposes conninfo_add_defaults().
It allows you to pass a PQconni
On Tue, Jan 29, 2013 at 11:43 AM, Fujii Masao wrote:
> On Tue, Jan 29, 2013 at 3:12 AM, Alvaro Herrera
> wrote:
>> Phil Sorber escribió:
>>> On Mon, Jan 28, 2013 at 11:20 AM, Fujii Masao wrote:
>>> > Maybe. But I'm not inclined to add new libpq interface
On Mon, Jan 28, 2013 at 1:12 PM, Alvaro Herrera
wrote:
> Phil Sorber escribió:
>> On Mon, Jan 28, 2013 at 11:20 AM, Fujii Masao wrote:
>> > Maybe. But I'm not inclined to add new libpq interface at this stage.
>> > Because we are in the last CommitFest and I
On Mon, Jan 28, 2013 at 11:20 AM, Fujii Masao wrote:
> Maybe. But I'm not inclined to add new libpq interface at this stage.
> Because we are in the last CommitFest and I'm not sure whether
> we have enough time to implement that. Instead, how about using
> both PQconninfoParse() and PQconndefault
On Sun, Jan 27, 2013 at 2:38 PM, Phil Sorber wrote:
> On Fri, Jan 25, 2013 at 11:20 AM, Fujii Masao wrote:
>> On Fri, Jan 25, 2013 at 4:10 AM, Phil Sorber wrote:
>>> On Thu, Jan 24, 2013 at 1:12 PM, Fujii Masao wrote:
>>>> set_pglocale_pgservice() should be call
On Fri, Jan 25, 2013 at 11:20 AM, Fujii Masao wrote:
> On Fri, Jan 25, 2013 at 4:10 AM, Phil Sorber wrote:
>> On Thu, Jan 24, 2013 at 1:12 PM, Fujii Masao wrote:
>>> set_pglocale_pgservice() should be called?
>>>
>>> I think that the command name (
On Jan 26, 2013 6:56 PM, "Craig Ringer" wrote:
>
> On 01/27/2013 06:20 AM, Phil Sorber wrote:
> > On Sat, Jan 26, 2013 at 4:37 PM, Pavel Stehule
wrote:
> >> 2013/1/26 Phil Sorber :
> >>> On Sat, Jan 26, 2013 at 12:39 PM, Pavel Stehule <
pavel.s
On Sat, Jan 26, 2013 at 4:37 PM, Pavel Stehule wrote:
> 2013/1/26 Phil Sorber :
>> On Sat, Jan 26, 2013 at 12:39 PM, Pavel Stehule
>> wrote:
>>> 2013/1/26 Phil Sorber :
>>>> On Sat, Jan 26, 2013 at 11:53 AM, Pavel Stehule
>>>> wrote:
>>&
On Wed, Jan 23, 2013 at 6:36 AM, Michael Paquier
wrote:
>
> On 2013/01/23, at 18:12, Simon Riggs wrote:
>
>> On 23 January 2013 04:49, Michael Paquier wrote:
>>
>>> - recovery.conf is removed (no backward compatibility in this version of the
>>> patch)
>>
>> If you want to pursue that, you know
On Sat, Jan 26, 2013 at 12:39 PM, Pavel Stehule wrote:
> 2013/1/26 Phil Sorber :
>> On Sat, Jan 26, 2013 at 11:53 AM, Pavel Stehule
>> wrote:
>>> 2013/1/26 Phil Sorber :
>>>> On Sat, Jan 26, 2013 at 4:02 AM, Pavel Stehule
>>>> wrote:
>>
On Sat, Jan 26, 2013 at 11:53 AM, Pavel Stehule wrote:
> 2013/1/26 Phil Sorber :
>> On Sat, Jan 26, 2013 at 4:02 AM, Pavel Stehule
>> wrote:
>>> Hello
>>>
>>> We now haw to solve small puppet issue, because our puppets try to
>>> s
On Sat, Jan 26, 2013 at 4:02 AM, Pavel Stehule wrote:
> Hello
>
> We now haw to solve small puppet issue, because our puppets try to
> start server too early, when old instance live still.
>
> Maybe some new parameter - is_done can be useful.
>
What about something like:
pg_isready; while [ $? -n
On Thu, Jan 24, 2013 at 1:12 PM, Fujii Masao wrote:
> set_pglocale_pgservice() should be called?
>
> I think that the command name (i.e., pg_isready) should be given to
> PQpingParams() as fallback_application_name. Otherwise, the server
> by default uses "unknown" as the application name of pg_is
On Wed, Jan 23, 2013 at 8:12 PM, Fujii Masao wrote:
> On Thu, Jan 24, 2013 at 8:47 AM, Phil Sorber wrote:
>> On Wed, Jan 23, 2013 at 6:07 PM, Tom Lane wrote:
>>> Phil Sorber writes:
>>>> On Wed, Jan 23, 2013 at 1:58 PM, Bruce Momjian wrote:
>>>>>
On Thu, Jan 24, 2013 at 2:27 AM, Craig Ringer wrote:
> On 01/24/2013 01:50 AM, Phil Sorber wrote:
>> This looks good to me now. Compiles and works as described.
> Ready to go?
>
> https://commitfest.postgresql.org/action/patch_view?id=1008
>
I guess I wasn't ready to
On Wed, Jan 23, 2013 at 6:07 PM, Tom Lane wrote:
> Phil Sorber writes:
>> On Wed, Jan 23, 2013 at 1:58 PM, Bruce Momjian wrote:
>>> On Wed, Jan 23, 2013 at 12:27:45PM -0500, Tom Lane wrote:
>>>> +1 for default timeout --- if this isn't like "p
On Wed, Jan 23, 2013 at 1:44 PM, Stephen Frost wrote:
> * Robert Haas (robertmh...@gmail.com) wrote:
>> For all of that, I'm not sure that people failing to seek consensus
>> before coding is really so much of a problem as you seem to think.
>
> For my part, I don't think the lack of consensus-fin
On Wed, Jan 23, 2013 at 2:51 PM, Bruce Momjian wrote:
> On Wed, Jan 23, 2013 at 02:50:01PM -0500, Phil Sorber wrote:
>> On Wed, Jan 23, 2013 at 1:58 PM, Bruce Momjian wrote:
>> > On Wed, Jan 23, 2013 at 12:27:45PM -0500, Tom Lane wrote:
>> >> Phil Sorber writes:
&
On Wed, Jan 23, 2013 at 1:58 PM, Bruce Momjian wrote:
> On Wed, Jan 23, 2013 at 12:27:45PM -0500, Tom Lane wrote:
>> Phil Sorber writes:
>> > On Wed, Jan 23, 2013 at 11:07 AM, Robert Haas
>> > wrote:
>> >> [rhaas pgsql]$ pg_isready -h www.google.com
>&
On Wed, Jan 23, 2013 at 12:31 AM, Jon Erdman
wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
>
> Done. Attached.
> - --
> Jon T Erdman (aka StuckMojo)
> PostgreSQL Zealot
>
> On 01/22/2013 11:17 PM, Phil Sorber wrote:
>> On Wed, Jan 23, 20
I get the following error when I try to compile just a specific binary
in src/bin/scripts:
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith
-Wdeclaration-after-statement -Wendif-labels
-Wmissing-format-attribute -Wformat-security -fno-strict-aliasing
-fwrapv -fexcess-precision=standard reindexdb
On Wed, Jan 23, 2013 at 11:07 AM, Robert Haas wrote:
> On Mon, Jan 21, 2013 at 12:23 PM, Phil Sorber wrote:
>> Changing up the subject line because this is no longer a work in
>> progress nor is it pg_ping anymore.
>
> OK, I committed this. However, I have one suggestion.
On Wed, Jan 23, 2013 at 10:37 AM, Robert Haas wrote:
> On Mon, Jan 21, 2013 at 1:45 PM, Phil Sorber wrote:
>> Attached is a patch that adds a note about the FATAL messages that
>> appear in the logs if you don't pass a valid user or dbname to PQping
>> or PQpingParams
On Jan 23, 2013 8:59 AM, "Andrew Dunstan" wrote:
>
>
> On 01/23/2013 08:47 AM, Phil Sorber wrote:
>>
>> On Wed, Jan 23, 2013 at 1:32 AM, David Fetter wrote:
>>>
>>> On Wed, Jan 23, 2013 at 01:05:12PM +0800, Craig Ringer wrote:
>>>>
&
On Wed, Jan 23, 2013 at 1:32 AM, David Fetter wrote:
> On Wed, Jan 23, 2013 at 01:05:12PM +0800, Craig Ringer wrote:
>> Hi all
>>
>> Would a committer be willing to pop some entries in .gitignore for
>> Windows native build outputs?
>>
>> *.sln
>> *.vcproj
>> *.vcxproj
>>
>> It'd make life easier
On Wed, Jan 23, 2013 at 12:10 AM, Jon Erdman
wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
>
> Updated the patch in commitfest with the doc change, and added a
> comment to explain the whitespace change (it was to clean up the sql
> indentation). I've also attached the new patch here
On Tue, Jan 22, 2013 at 8:33 AM, Dimitri Fontaine
wrote:
> Heikki Linnakangas writes:
>> You might not want to keep a copy of the whole data directory around, as you
>> have to in a cascading standby. I can see value in a separate WAL proxy
>> software, especially if it's integrated into a larger
On Mon, Jan 21, 2013 at 8:47 PM, Josh Berkus wrote:
>> My own experience is different from yours, I guess. I actually like
>> it when I post a patch, or suggest a concept, and Tom fires back with
>> a laundry list of reasons it won't work.
>
> This can be a problem with new submitters, though. I
On Mon, Jan 21, 2013 at 8:23 PM, Robert Haas wrote:
> What I don't like is when I
> (or anyone) posts a patch and somebody says something that boils down
> to "no one wants that". *That* ticks me off. Because you know what?
> At a minimum, *I* want that. If I didn't, I wouldn't have written a
>
On Wed, Jan 16, 2013 at 8:18 AM, Abhijit Menon-Sen wrote:
> Here's a breakdown based purely on the names from the CF page (i.e. I
> didn't check archives to see who actually posted reviews, and didn't
> take into account reviews posted without updating the CF page).
FWIW, I reviewed at least one
Attached is a patch that adds a note about the FATAL messages that
appear in the logs if you don't pass a valid user or dbname to PQping
or PQpingParams.
This was requested in the pg_isready thread.
libpq_pqping_doc.diff
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-ha
Changing up the subject line because this is no longer a work in
progress nor is it pg_ping anymore.
On Sun, Jan 20, 2013 at 10:36 PM, Craig Ringer wrote:
> On 01/21/2013 11:26 AM, Robert Haas wrote:
>> On Sun, Jan 20, 2013 at 2:59 PM, Phil Sorber wrote:
>>> Ok. I can add some
On Fri, Dec 21, 2012 at 2:46 PM, Bruce Momjian wrote:
> There has been discussion in the past of removing or significantly
> changing the way streaming replication/point-in-time-recovery (PITR) is
> setup in Postgres. Currently the file recovery.conf is used, but that
> was designed for PITR and
On Fri, Jan 18, 2013 at 7:55 AM, Heikki Linnakangas
wrote:
> On 18.01.2013 06:38, Phil Sorber wrote:
>> Is it possible to re-use walreceiver code from the backend?
>>
>> I was thinking that it would actually be very useful to have the whole
>> replication functio
On Fri, Jan 18, 2013 at 8:48 PM, Phil Sorber wrote:
>
> +1
>
Is there more work being done on this, or is the current patch ready to review?
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailp
On Sun, Jan 20, 2013 at 11:38 AM, Robert Haas wrote:
> On Sun, Jan 20, 2013 at 9:58 AM, Phil Sorber wrote:
>> This was done to silence useless error messages in the logs. If you
>> attempt to connect as some user that does not exist, or to some
>> database that does not exis
On Sun, Jan 20, 2013 at 8:40 AM, Robert Haas wrote:
> On Fri, Jan 18, 2013 at 4:17 PM, Phil Sorber wrote:
>> Updated patch is rebased against current master and copyright year is
>> updated.
>
> I took a look at this. According to the documentation for
> PQpingParams
On Jan 19, 2013 10:55 AM, "Jon Erdman"
wrote:
>
>
> I did realize that since I moved it to + the doc should change, but I
didn't address that. I'll get on it this weekend.
>
> As far as the column name and displayed values go, they're taken from the
CREATE FUNCTION syntax, and were recommended by
On Tue, Jan 15, 2013 at 11:06 AM, Tom Lane wrote:
> Peter Eisentraut writes:
>> On 1/14/13 10:22 AM, Tom Lane wrote:
>>> Also it appears to me that the hunk at lines 812ff is changing the
>>> default behavior, which is not what the patch is advertised to do.
>
>> True, I had forgotten to mention
On Sat, Dec 29, 2012 at 1:56 PM, Stephen Frost wrote:
> * Jon Erdman (postgre...@thewickedtribe.net) wrote:
>> Oops! Here it is in the proper diff format. I didn't have my env set up
>> correctly :(
>
> No biggie, and to get the bike-shedding started, I don't really like the
> column name or the
On Tue, Dec 25, 2012 at 1:47 AM, Michael Paquier
wrote:
>
>
> On Mon, Dec 24, 2012 at 12:44 AM, Phil Sorber wrote:
>>
>> Updated patch attached.
>
> Thanks. I am marking this patch as ready for committer.
>
> --
> Michael Paquier
> http://michael.otaco
On Tue, Jan 15, 2013 at 9:05 AM, Heikki Linnakangas
wrote:
> Now that a standby server can follow timeline switches through streaming
> replication, we should do teach pg_receivexlog to do the same. Patch
> attached.
Is it possible to re-use walreceiver code from the backend?
I was thinking that
On Tue, Jan 1, 2013 at 10:10 AM, Magnus Hagander wrote:
> So, it turns out the reason I got no feedback on this tool, was that I
> forgot both to email about and to actually push the code to github :O
> So this is actually code that's almost half a year old and that I was
> supposed to submit for
On Sun, Dec 23, 2012 at 10:07 AM, Phil Sorber wrote:
> On Sun, Dec 23, 2012 at 9:57 AM, Erik Rijkers wrote:
>> On Sun, December 23, 2012 15:29, Michael Paquier wrote:
>>>
>>> Once the 2 small things I noticed are fixed, this patch can be marked as
>>> ready fo
On Sun, Dec 23, 2012 at 9:57 AM, Erik Rijkers wrote:
> On Sun, December 23, 2012 15:29, Michael Paquier wrote:
>>
>> Once the 2 small things I noticed are fixed, this patch can be marked as
>> ready for committer.
>
> I wasn't going to complain about it, but if we're going for small things
> anyw
On Sun, Dec 23, 2012 at 9:29 AM, Michael Paquier
wrote:
>
>
> On Sat, Dec 22, 2012 at 4:07 AM, Phil Sorber wrote:
>>
>>
>> Added new version with default verbose and quiet option. Also updated
>> docs to reflect changes.
>
> Thanks for the updated patches.
On Wed, Dec 19, 2012 at 8:28 AM, Michael Paquier
wrote:
>
>
> On Wed, Dec 12, 2012 at 12:06 AM, Bruce Momjian wrote:
>>
>> On Sat, Dec 8, 2012 at 08:59:00AM -0500, Phil Sorber wrote:
>> > On Sat, Dec 8, 2012 at 7:50 AM, Michael Paquier
>> > wrote:
>>
On Sat, Dec 8, 2012 at 7:50 AM, Michael Paquier
wrote:
> On Fri, Dec 7, 2012 at 12:56 PM, Phil Sorber wrote:
>>
>> Something I was just thinking about while testing this again. I
>> mentioned the issue before about someone meaning to put -v and putting
>> -V inste
On Thu, Dec 6, 2012 at 8:54 PM, Michael Paquier
wrote:
>
>
> On Thu, Dec 6, 2012 at 12:29 AM, Phil Sorber wrote:
>>
>> On Wed, Dec 5, 2012 at 8:53 AM, Alvaro Herrera
>> wrote:
>> > No, I think it is the reference docs on the returned value that must be
>
On Wed, Dec 5, 2012 at 8:53 AM, Alvaro Herrera wrote:
> Phil Sorber escribió:
>> On Mon, Dec 3, 2012 at 11:59 PM, Michael Paquier
>> wrote:
>
>> > - Same thing with this example:
>> > +
>> > +Standard Usage:
>> > +
>
On Mon, Dec 3, 2012 at 11:59 PM, Michael Paquier
wrote:
> On Sun, Dec 2, 2012 at 5:56 AM, Phil Sorber wrote:
>>
>> Here is the updated patch. I renamed it, but using v5 to stay consistent.
>
>
> After looking at this patch, I found the following problems:
> - There
On Tue, Nov 27, 2012 at 9:43 AM, Phil Sorber wrote:
> On Tue, Nov 27, 2012 at 8:45 AM, Michael Paquier
> wrote:
>>
>>
>> On Tue, Nov 27, 2012 at 7:35 PM, Dimitri Fontaine
>> wrote:
>>>
>>> Peter Eisentraut writes:
>>> > Sure, PQping
On Tue, Nov 27, 2012 at 8:45 AM, Michael Paquier
wrote:
>
>
> On Tue, Nov 27, 2012 at 7:35 PM, Dimitri Fontaine
> wrote:
>>
>> Peter Eisentraut writes:
>> > Sure, PQping is useful for this very specific use case of seeing whether
>> > the server has finished starting up. If someone came with a
I am going to be unavailable until Wednesday, so maybe gives us a few
more days for feedback.
On Fri, Nov 23, 2012 at 9:48 AM, Michael Paquier
wrote:
>
>
> On Sat, Nov 17, 2012 at 2:48 AM, Phil Sorber wrote:
>>
>> On Thu, Nov 15, 2012 at 10:55 PM, Michael Paquier
>>
On Thu, Nov 15, 2012 at 10:55 PM, Michael Paquier
wrote:
> On Fri, Nov 16, 2012 at 12:34 PM, Phil Sorber wrote:
>> On Thu, Nov 15, 2012 at 9:23 PM, Michael Paquier
>> wrote:
>> > 3) Having an output close to what ping actually does would also be nice,
>> > the
&
Attached is updated patch v4 with the changes Michael pointed out.
On Fri, Nov 16, 2012 at 12:28 AM, Tom Lane wrote:
> Phil Sorber writes:
>> On Thu, Nov 15, 2012 at 10:55 PM, Michael Paquier
>> wrote:
>>> Hum, it is not really consistent to use a magic number here,
On Thu, Nov 15, 2012 at 10:55 PM, Michael Paquier
wrote:
> Hum, it is not really consistent to use a magic number here, particularly in
> the case where an additional state would be added in the enum PGPing. So why
> not simply return PQPING_NO_ATTEMPT when there are incorrect options or you
> sho
Thanks for the review.
On Thu, Nov 15, 2012 at 9:23 PM, Michael Paquier
wrote:
> Hi Phil,
>
> I am currently looking at your patch.
> A lot of people already had a look at at, but I hope I will be helpful in
> finalizing it and hand it over to a committer.
>
> Strangely I got the following error
On Tue, Oct 16, 2012 at 12:24 PM, Pavel Stehule wrote:
> 2012/10/16 Shigeru HANADA :
>> Hi Pavel,
>>
>> On Tue, Oct 16, 2012 at 6:59 AM, Pavel Stehule
>> wrote:
>>> here is updated patch, I moved lot of code from lexer to command.com,
>>> and now more \gset doesn't disable other backslash command
On Tue, Oct 23, 2012 at 6:22 PM, Christopher Browne wrote:
> On Tue, Oct 23, 2012 at 6:12 PM, Peter Eisentraut wrote:
>> On 10/22/12 11:47 AM, Phil Sorber wrote:
>> Also, it seems that about 75% of the patch is connection options processing.
>> How about
>> we get ri
On Tue, Oct 23, 2012 at 6:12 PM, Peter Eisentraut wrote:
> Quick review ...
>
> Code:
>
> *** install: all installdirs
> *** 54,59
> --- 55,61
> $(INSTALL_PROGRAM) clusterdb$(X) '$(DESTDIR)$(bindir)'/clusterdb$(X)
> $(INSTALL_PROGRAM) vacuumdb$(X) '$(DESTDI
On Sun, Oct 21, 2012 at 6:20 PM, Tom Lane wrote:
> Phil Sorber writes:
>> Here is the new patch. I renamed the utility from pg_ping to pingdb to
>> go along with the naming convention of src/bin/scripts.
>
> Uh, no, that's not a step forward. Leaving out a "pg&qu
On Mon, Oct 15, 2012 at 9:18 PM, Tom Lane wrote:
> Phil Sorber writes:
>> On Mon, Oct 15, 2012 at 7:12 PM, Tom Lane wrote:
>>> Yeah, I know a whole new executable is kind of a pain, and the amount of
>>> infrastructure and added maintenance seems a bit high compared
On Mon, Oct 15, 2012 at 9:18 PM, Tom Lane wrote:
> Phil Sorber writes:
>> I would also like it to have a regression test
>> which none of those seem to have.
>
> [ shrug... ] There is nothing in the current regression infrastructure
> that would work for this, so that
On Mon, Oct 15, 2012 at 7:12 PM, Tom Lane wrote:
> Andres Freund writes:
>> Why not add a pg_ctl subcommand for that? For me that sounds like a good
>> place
>> for it...
>
> I think that's a bad fit, because every other pg_ctl subcommand requires
> access to the data directory. It would be ver
On Mon, Oct 15, 2012 at 5:32 PM, Andres Freund wrote:
> On Monday, October 15, 2012 11:28:36 PM Thom Brown wrote:
>> On 13 October 2012 22:19, Phil Sorber wrote:
>> > Based on a previous thread
>> > (http://archives.postgresql.org/pgsql-hackers/2012-10/msg00131.php)
Based on a previous thread
(http://archives.postgresql.org/pgsql-hackers/2012-10/msg00131.php) I
have put together a first attempt of a pg_ping utility. I am attaching
two patches. One for the executable and one for the docs.
I would also like to make a regression tests and translations, but
wante
On Sat, Oct 13, 2012 at 3:14 PM, Tom Lane wrote:
> Phil Sorber writes:
>> On Wed, Oct 10, 2012 at 7:54 PM, Bruce Momjian wrote:
>>> Also, do we want to centralize the definition of pg_strdup() in /port,
>>> or leave each module to define it on its own?
>
>
On Wed, Oct 10, 2012 at 7:54 PM, Bruce Momjian wrote:
> On Mon, Oct 8, 2012 at 09:03:37PM -0400, Bruce Momjian wrote:
>> On Mon, Oct 8, 2012 at 04:33:29PM -0400, Tom Lane wrote:
>> > Bruce Momjian writes:
>> > > A while ago I noticed that in some places we strdup/pg_strdup() optarg
>> > > strin
On Wed, Oct 3, 2012 at 11:42 AM, Pavel Stehule wrote:
> 2012/10/3 Phil Sorber :
>> On Wed, Oct 3, 2012 at 11:35 AM, Bruce Momjian wrote:
>>> On Tue, Oct 2, 2012 at 11:01:36PM -0400, Phil Sorber wrote:
>>>> I was wondering recently if there was any command line
On Wed, Oct 3, 2012 at 11:35 AM, Bruce Momjian wrote:
> On Tue, Oct 2, 2012 at 11:01:36PM -0400, Phil Sorber wrote:
>> I was wondering recently if there was any command line tool that
>> utilized PQping() or PQpingParams(). I searched the code and couldn't
>> find any
I was wondering recently if there was any command line tool that
utilized PQping() or PQpingParams(). I searched the code and couldn't
find anything and was wondering if there was any interest to have
something like this included? I wrote something for my purposes of
performing a health check that
On Tue, Oct 2, 2012 at 12:30 PM, Tom Lane wrote:
> Andres Freund writes:
>>> pg_calloc(randomly different API for pg_malloc0)
>
>> Do we need this?
>
> I thought about getting rid of it, but there are some dozens of calls
> scattered across several files, so I wasn't sure it was worth it.
> A
Thom Brown and I were doing some hacking the other day and came across
this missing define. We argued over who was going to send the patch in
and I lost. So here it is.
pg_type_uuid_oid.diff
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make c
On Sun, Sep 2, 2012 at 1:13 AM, Pavel Stehule wrote:
> -- Forwarded message --
> From: Pavel Stehule
> Date: 2012/9/1
> Subject: PATCH: psql boolean display
> To: Phil Sorber
>
>
> Hello
>
> I am looking to your patch:
>
> I have only one n
On Mon, Aug 20, 2012 at 7:19 PM, Tom Lane wrote:
> "Kevin Grittner" writes:
>> The type itself does output true/false; it's just psql that uses
>> t/f.
>
> No, 't'/'f' is what boolout() returns. The 'true'/'false' results from
> casting bool to text are intentionally different --- IIRC, Peter E.
On Aug 20, 2012 6:31 PM, "Thom Brown" wrote:
>
> On 20 August 2012 23:16, Phil Sorber wrote:
> >
> > On Aug 20, 2012 6:08 PM, "Thom Brown" wrote:
> >>
> >> On 20 August 2012 23:06, Phil Sorber wrote:
> >> >
> >> >
On Aug 20, 2012 6:28 PM, "Kevin Grittner"
wrote:
>
> Gurjeet Singh wrote:
>
> > On occasions I have wanted psql to emit the full 'True'/'False'
> > words instead of cryptic one-letter t/f, which can get lost on
> > long rows that get wrapped around on screen. Writing long-winded
> > CASE expressi
On Aug 20, 2012 6:08 PM, "Thom Brown" wrote:
>
> On 20 August 2012 23:06, Phil Sorber wrote:
> >
> > On Aug 20, 2012 5:56 PM, "Thom Brown" wrote:
> >>
> >> On 20 August 2012 22:31, Phil Sorber wrote:
> >> > On Aug 20, 2012 5:
On Aug 20, 2012 5:56 PM, "Thom Brown" wrote:
>
> On 20 August 2012 22:31, Phil Sorber wrote:
> > On Aug 20, 2012 5:19 PM, "Phil Sorber" wrote:
> >>
> >> On Aug 20, 2012 5:11 PM, "Pavel Stehule"
wrote:
> >> >
> >>
1 - 100 of 116 matches
Mail list logo
