Re: [HACKERS] psql: Add \dL to show languages

2011-01-19 Thread Andreas Karlsson
On Tue, 2011-01-18 at 19:34 -0500, Josh Kupershmidt wrote: Got that now too. I lost my ~/.emacs file recently, which is mostly why I'm making whitespace mistakes. Rebuilding slowly though; (setq-default show-trailing-whitespace t) is what I needed. Aha, I see. I left the Call Handler and

Re: [HACKERS] psql: Add \dL to show languages

2011-01-19 Thread Robert Haas
On Wed, Jan 19, 2011 at 5:47 PM, Andreas Karlsson andr...@proxel.se wrote: The patch looks alright now so I will mark it as ready for committer now. This patch doesn't seem terribly consistent to me - we show the name of the call handler and the name of the validator, but for the inline handler

Re: [HACKERS] psql: Add \dL to show languages

2011-01-19 Thread Josh Kupershmidt
On Wed, Jan 19, 2011 at 9:09 PM, Robert Haas robertmh...@gmail.com wrote: This patch doesn't seem terribly consistent to me - we show the name of the call handler and the name of the validator, but for the inline handler we just indicate whether there is one or not.  That seems like something

Re: [HACKERS] psql: Add \dL to show languages

2011-01-19 Thread Robert Haas
On Wed, Jan 19, 2011 at 11:19 PM, Josh Kupershmidt schmi...@gmail.com wrote: On Wed, Jan 19, 2011 at 9:09 PM, Robert Haas robertmh...@gmail.com wrote: This patch doesn't seem terribly consistent to me - we show the name of the call handler and the name of the validator, but for the inline

Re: [HACKERS] psql: Add \dL to show languages

2011-01-18 Thread Andreas Karlsson
Hi Josh, Nope, I do not have any better ideas than DO Blocks?. Everything looks good with the exception one bug now. \dL foo * QUERY ** SELECT l.lanname AS Name, pg_catalog.pg_get_userbyid(l.lanowner) as Owner, l.lanpltrusted AS Trusted FROM pg_catalog.pg_language

Re: [HACKERS] psql: Add \dL to show languages

2011-01-18 Thread Josh Kupershmidt
On Tue, Jan 18, 2011 at 1:35 PM, Andreas Karlsson andr...@proxel.se wrote: Hi Josh, Nope, I do not have any better ideas than DO Blocks?. Everything looks good with the exception one bug now. \dL foo * QUERY ** SELECT l.lanname AS Name,      

Re: [HACKERS] psql: Add \dL to show languages

2011-01-17 Thread Peter Eisentraut
On mån, 2011-01-17 at 07:37 +0100, Magnus Hagander wrote: which, as Magnus points out, includes non-procedural languages (SQL). I think that list languages could be confusing to newcomers -- the very people who might be reading through the help output of psql for the first time -- who

Re: [HACKERS] psql: Add \dL to show languages

2011-01-17 Thread David Fetter
On Mon, Jan 17, 2011 at 02:48:43PM +0200, Peter Eisentraut wrote: On mån, 2011-01-17 at 07:37 +0100, Magnus Hagander wrote: which, as Magnus points out, includes non-procedural languages (SQL). I think that list languages could be confusing to newcomers -- the very people who might

Re: [HACKERS] psql: Add \dL to show languages

2011-01-17 Thread Bruce Momjian
Peter Eisentraut wrote: On m?n, 2011-01-17 at 07:37 +0100, Magnus Hagander wrote: which, as Magnus points out, includes non-procedural languages (SQL). I think that list languages could be confusing to newcomers -- the very people who might be reading through the help output of psql

Re: [HACKERS] psql: Add \dL to show languages

2011-01-17 Thread Andreas Karlsson
On Mon, 2011-01-17 at 07:37 +0100, Magnus Hagander wrote: Yeah. Procedural langauges may strictly be wrong, but people aren't likely to misunderstand it. That was idea when suggesting we call it procedural languages. It is short and I do not think it can be misunderstood. Regards, Andreas

Re: [HACKERS] psql: Add \dL to show languages

2011-01-17 Thread Andreas Karlsson
On Sun, 2011-01-16 at 22:32 -0500, Josh Kupershmidt wrote: On Sat, Jan 15, 2011 at 8:26 PM, Andreas Karlsson andr...@proxel.se wrote: Should we include a column in \dL+ for the laninline function (DO blocks)? Hrm, I guess that could be useful for the verbose output at least. Magnus

Re: [HACKERS] psql: Add \dL to show languages

2011-01-17 Thread Josh Kupershmidt
Hi all, I've updated the patch to address the following points: * help string now says list procedural languages (no parentheses now) * the language name column is now titled Name * added another column in verbose mode for 9.0+ showing whether DO blocks are possible with the language. I named

Re: [HACKERS] psql: Add \dL to show languages

2011-01-16 Thread Magnus Hagander
On Sun, Jan 16, 2011 at 02:26, Andreas Karlsson andr...@proxel.se wrote: Hi Josh, Contents and Purpose This patch adds the \dL command in psql to list the procedual languages. snip Some things I noticed when using it though. I do not like the use of parentheses in

Re: [HACKERS] psql: Add \dL to show languages

2011-01-16 Thread Robert Haas
On Sun, Jan 16, 2011 at 7:04 AM, Magnus Hagander mag...@hagander.net wrote: I do not like the use of parentheses in the usage description list (procedural) languages. Why not have it simply as list procedural languages? Because it lists non-procedural langauges as well? (I didn't check it,

Re: [HACKERS] psql: Add \dL to show languages

2011-01-16 Thread Josh Kupershmidt
On Sat, Jan 15, 2011 at 8:26 PM, Andreas Karlsson andr...@proxel.se wrote: Hi Josh, Here is my review of this patch for the commitfest. Review of https://commitfest.postgresql.org/action/patch_view?id=439 Thanks a lot for the review! Contents and Purpose This patch

Re: [HACKERS] psql: Add \dL to show languages

2011-01-16 Thread Josh Kupershmidt
On Sun, Jan 16, 2011 at 8:52 PM, Robert Haas robertmh...@gmail.com wrote: On Sun, Jan 16, 2011 at 7:04 AM, Magnus Hagander mag...@hagander.net wrote: I do not like the use of parentheses in the usage description list (procedural) languages. Why not have it simply as list procedural languages?

Re: [HACKERS] psql: Add \dL to show languages

2011-01-16 Thread Robert Haas
On Sun, Jan 16, 2011 at 10:40 PM, Josh Kupershmidt schmi...@gmail.com wrote: On Sun, Jan 16, 2011 at 8:52 PM, Robert Haas robertmh...@gmail.com wrote: On Sun, Jan 16, 2011 at 7:04 AM, Magnus Hagander mag...@hagander.net wrote: I do not like the use of parentheses in the usage description list

Re: [HACKERS] psql: Add \dL to show languages

2011-01-16 Thread Magnus Hagander
On Mon, Jan 17, 2011 at 05:22, Robert Haas robertmh...@gmail.com wrote: On Sun, Jan 16, 2011 at 10:40 PM, Josh Kupershmidt schmi...@gmail.com wrote: On Sun, Jan 16, 2011 at 8:52 PM, Robert Haas robertmh...@gmail.com wrote: On Sun, Jan 16, 2011 at 7:04 AM, Magnus Hagander mag...@hagander.net

Re: [HACKERS] psql: Add \dL to show languages

2011-01-15 Thread Andreas Karlsson
Hi Josh, Here is my review of this patch for the commitfest. Review of https://commitfest.postgresql.org/action/patch_view?id=439 Contents and Purpose This patch adds the \dL command in psql to list the procedual languages. To me this seems like a useful addition to the

[HACKERS] psql: Add \dL to show languages

2010-11-21 Thread Josh Kupershmidt
Hi all, I'd like to revive Fernando Ike's patch implementing the \dL command for psql to list available languages, last version here: http://archives.postgresql.org/pgsql-hackers/2009-07/msg01092.php The original patch produced columns Name, Owner, Procedural Language, Trusted, Call Handler,

Re: [HACKERS] psql: Add \dL to show languages

2010-11-21 Thread Robert Haas
On Sun, Nov 21, 2010 at 8:18 PM, Josh Kupershmidt schmi...@gmail.com wrote: I'd like to revive Fernando Ike's patch implementing the \dL command for psql to list available languages, last version here:  http://archives.postgresql.org/pgsql-hackers/2009-07/msg01092.php Please add this patch to

Re: [HACKERS] psql: Add \dL to show languages

2010-11-21 Thread Josh Kupershmidt
On Sun, Nov 21, 2010 at 8:39 PM, Robert Haas robertmh...@gmail.com wrote: Please add this patch to the currently open CommitFest: Added to 2011-01. https://commitfest.postgresql.org/action/commitfest_view/open And please also help with review of patches from the current CommitFest:

Re: [HACKERS] psql: Add \dL to show languages

2010-11-21 Thread Robert Haas
On Sun, Nov 21, 2010 at 9:44 PM, Josh Kupershmidt schmi...@gmail.com wrote: On Sun, Nov 21, 2010 at 8:39 PM, Robert Haas robertmh...@gmail.com wrote: Please add this patch to the currently open CommitFest: Added to 2011-01. https://commitfest.postgresql.org/action/commitfest_view/open And