[HACKERS] Transactions and temp tables

2008-10-06 Thread Emmanuel Cecchet
es I have been using to test it. The test cases try to compile the various use cases that I have seen reported on the list. Let me know what you think of the patch and if it could be applied to 8.3 and 8.4? Thanks in advance for your feedback, manu -- Emmanuel Cecchet FTO @ Frog Thinker Ope

Re: [HACKERS] Transactions and temp tables

2008-10-07 Thread Emmanuel Cecchet
patch bug-fixes, and this isn't one. Ok understood. Thanks for your feedback and don't hesitate to enlighten me on the potential locking issue I did not understand. Emmanuel -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: http://www.frogthi

Re: [HACKERS] Transactions and temp tables

2008-10-07 Thread Emmanuel Cecchet
advance for your feedback, Emmanuel Emmanuel Cecchet wrote: Hi Heikki, The patch allows preparing any transaction that has dropped the temp table, even if it wasn't created in the same transaction. Is that sane? If you have a temp table created with an 'on commit delete rows' op

Re: [HACKERS] Transactions and temp tables

2008-10-07 Thread Emmanuel Cecchet
Hi, On Tue, Oct 07, 2008 at 04:57:37PM -0400, Emmanuel Cecchet wrote: Heikki, Here is a new version of the patch using a hash table as you suggested. I also include the tests that I have added to the regression test suite to test the various scenarios. All patches are based on Postgres

Re: [HACKERS] Transactions and temp tables

2008-10-07 Thread Emmanuel Cecchet
Hi, Here are the patches for 8.4 (1 patch for the code and 1 patch for the regression tests). Thanks in advance for your feedback, Emmanuel David Fetter wrote: On Tue, Oct 07, 2008 at 06:12:14PM -0400, Emmanuel Cecchet wrote: Hi, On Tue, Oct 07, 2008 at 04:57:37PM -0400, Emmanuel

[HACKERS] Building Postgres in Eclipse

2008-10-08 Thread Emmanuel Cecchet
Hi all, I am building Postgres using Eclipse with the CDT plugins (pre-packaged distrib from eclipse.org). I am wondering if anyone else is using Eclipse here? If I am not the only one, we could setup a page on the Wiki explaining how to setup the project under Eclipse and share our settings.

Re: [HACKERS] Building Postgres in Eclipse

2008-10-08 Thread Emmanuel Cecchet
Dave Page wrote: I don't know of anyone else actually working that way, but I've certainly heard of people wanting to. It would be good if you can document what you've done for their benefit. Any recommendation where I should setup the page? manu -- Sent via pgsql-hackers mailing list (pgsq

Re: [HACKERS] Transactions and temp tables

2008-10-08 Thread Emmanuel Cecchet
? Let me know what you think of the additional TRANS_PREPARED transaction state. It looks like the behavior of what happens between PREPARE and COMMIT/ROLLBACK is pretty much undefined. Emmanuel -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: http://w

Re: [HACKERS] Transactions and temp tables

2008-10-08 Thread Emmanuel Cecchet
Tom Lane wrote: Emmanuel Cecchet <[EMAIL PROTECTED]> writes: Thanks for the example, I get it now. Does it make sense to allow any request execution between PREPARE TRANSACTION and the subsequent COMMIT or ROLLBACK? Yes. Don't even think of trying to disallow that.

Re: [HACKERS] Transactions and temp tables

2008-10-09 Thread Emmanuel Cecchet
. The RemoveTempTable callback does not try to acquire locks on these tables. Now postmaster can terminate even with transactions in the prepared state that accessed temp tables. Let me know what you think. manu Tom Lane wrote: Emmanuel Cecchet <[EMAIL PROTECTED]> writes: Ok, so actu

Re: [HACKERS] Transactions and temp tables

2008-10-10 Thread Emmanuel Cecchet
Hi all, Here is the latest patch and the regression tests for the temp tables and 2PC issue. Is there a way to stop and restart postmaster between 2 tests? Thanks for your feedback, Emmanuel -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web:

Re: [HACKERS] Building Postgres in Eclipse

2008-10-10 Thread Emmanuel Cecchet
uggestions and comments are welcome of course. Emmanuel -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: http://www.frogthinker.org email: [EMAIL PROTECTED] Skype: emmanuel_cecchet -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To m

Re: [HACKERS] Transactions and temp tables

2008-10-14 Thread Emmanuel Cecchet
Emmanuel Cecchet wrote: Here is the latest patch and the regression tests for the temp tables and 2PC issue. Is there a way to stop and restart postmaster between 2 tests? Thanks for your feedback, Emmanuel I did not get any comment on that one. How should I proceed so that the patch

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-10-22 Thread Emmanuel Cecchet
the "create rule" part so we are in time to change that... no? -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: http://www.frogthinker.org email: [EMAIL PROTECTED] Skype: emmanuel_cecchet -- Sent via pgsql-hackers mailing list (pg

Re: [HACKERS] Hot Standby utility and administrator functions

2008-10-27 Thread Emmanuel Cecchet
_timestamp(), I would like to have something like pg_xact_xid_status(txid) that would return something of a xid_status type that can be completed, recovered or not_found with a timestamp that would only be meaningful if the status is recovered or completed. Regards, Emmanuel -- Emmanuel Cec

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-10-31 Thread Emmanuel Cecchet
e trigger function and trigger names -- The trigger function body could raise an exception if the insert/update/delete operation does not fit into any single partition -- logic to check mutual exclusivity of ranges/lists -- misc. issues to convert it from wip to commit-ready If we think this is ok a

Re: [HACKERS] Well done, Hackers

2008-11-01 Thread Emmanuel Cecchet
mplaining after volunteer contributors is the best way to not get any more contributions and have nice empty commit fests in the future. Maybe that's the way to go to solve the issue at hand! ;-) manu -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: ht

Re: [HACKERS] Transactions and temp tables

2008-11-03 Thread Emmanuel Cecchet
Hi Heikki, Emmanuel Cecchet wrote: Here is the latest patch and the regression tests for the temp tables and 2PC issue. This fails: postgres=# begin; BEGIN postgres=# CREATE TEMPORARY TABLE temp1 (id int4); CREATE TABLE postgres=# PREPARE TRANSACTION 'foo'; PREPARE TRANSACTIO

Re: [HACKERS] Stack trace

2008-11-03 Thread Emmanuel Cecchet
like print_stack_trace(); that I can insert in arbitrary location in the code. Some references: http://www.tlug.org.za/wiki/index.php/Obtaining_a_stack_trace_in_C_upon_SIGSEGV http://www.delorie.com/gnu/docs/glibc/libc_665.html manu -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Develo

Re: [HACKERS] Transactions and temp tables

2008-11-04 Thread Emmanuel Cecchet
temp tables (even with delete rows on commit) that can cross commit boundaries, then we can remove that second bookkeeping and only allow temp tables that have been created withing the scope of the transaction. I fixed the hash_freeze problem but this drop cascade on temp table seems to be an

Re: [HACKERS] Transactions and temp tables

2008-11-07 Thread Emmanuel Cecchet
compilation of the tests I have even if some are not really relevant anymore without the support for empty temp tables but we will probably reuse them later. Thanks in advance for the feedback, Emmanuel Emmanuel Cecchet wrote: Heikki Linnakangas wrote: Yes, I was trying to allow also ON COMMIT DROP and

Re: [HACKERS] Transactions and temp tables

2008-11-17 Thread Emmanuel Cecchet
Hi Heikki, Emmanuel Cecchet wrote: As I have not found yet an elegant solution to deal with the DROP CASCADE issue, here is a simpler patch that handles temp tables that are dropped at commit time. This is a good first step and we will try to elaborate further to support ON COMMIT DELETE ROWS

Re: [HACKERS] Transactions and temp tables

2008-11-19 Thread Emmanuel Cecchet
ore testing would be appreciated with more complex cases like VACUUM FULL, subtransactions etc. -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: http://www.frogthinker.org email: [EMAIL PROTECTED] Skype: emmanuel_cecchet -- Sent via pgsql-hackers mai

Re: [HACKERS] Transactions and temp tables

2008-11-21 Thread Emmanuel Cecchet
Heikki Linnakangas wrote: Emmanuel Cecchet wrote: I still quite did not get what the big deal was if an ON COMMIT DELETE ROWS temp table was created inside a transaction. In case the transaction that created a temp table rolls back, the table needs to be removed. Removing a temporary table

Re: [HACKERS] Transactions and temp tables

2008-11-24 Thread Emmanuel Cecchet
Heikki, The following test fails with your patch on my system. Could you check if you can reproduce? psql (8.4devel) Type "help" for help. test=# begin; BEGIN test=# create table paul(x int); CREATE TABLE test=# insert into paul values(1); INSERT 0 1 test=# prepare transaction 'persistentTabl

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-11-27 Thread Emmanuel Cecchet
clarify this... i intend to say that, the trigger will insert or create the partition and insert... -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: http://www.frogthinker.org email: [EMAIL PROTECTED] Skype: emmanuel_cecchet -- Sent via pgsql-hac

Re: [HACKERS] Transactions and temp tables

2008-12-01 Thread Emmanuel Cecchet
quot;tablecmds.c", Line: 7823) LOG: server process (PID 15969) was terminated by signal 6: Aborted LOG: terminating any other active server processes FATAL: the database system is in recovery mode Thanks, manu -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulti

Re: [HACKERS] Transactions and temp tables

2008-12-03 Thread Emmanuel Cecchet
I would really like to have support for temp tables at least for the case where the table is created and dropped in the same transaction. But I guess that the other limitations on index, sequences and views would still hold, right? manu Heikki Linnakangas wrote: Emmanuel Cecchet wrote

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-09 Thread Emmanuel Cecchet
wrote: On Thu, Nov 27, 2008 at 11:09 AM, Emmanuel Cecchet <[EMAIL PROTECTED]> wrote: I have been following that discussion very closely but it seems that we are debating solutions without a good specification of the problem/requirements. I would suggest that we collect all the partit

Re: [HACKERS] Sync Rep: Second thoughts

2008-12-14 Thread Emmanuel Cecchet
n. So as long as you state clearly how it behaves and define all the terms you use that should be fine. manu -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: http://www.frogthinker.org email: m...@frogthinker.org Skype: emmanuel_cecchet -- Sent via pg

Re: [HACKERS] Sync Rep: First Thoughts on Code

2008-12-14 Thread Emmanuel Cecchet
is helps, manu -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: http://www.frogthinker.org email: m...@frogthinker.org Skype: emmanuel_cecchet -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-15 Thread Emmanuel Cecchet
itions (inherit tables and modify the trigger)... and what i want to see is an automatic creation when it's needed... -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: http://www.frogthinker.org email: m...@frogthinker.org Skype: emmanuel_cecchet ###

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-15 Thread Emmanuel Cecchet
Nikhil Sontakke wrote: A similar DELETE trigger should be pretty easy to write up in C. I think the main challenge is with UPDATE triggers especially if the new row will fall into another child table - but we can always throw an error for such a case initially. I agree. A first implementation c

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-15 Thread Emmanuel Cecchet
ITAGAKI Takahiro wrote: Emmanuel Cecchet wrote In the meantime, I have made some more tests with the trigger in C (see attached patch). Hmm... The inserting partition is passed by trigger arguments. Actually this is just a fallback option. The preferred option is to name the trigger

Re: [HACKERS] Fwd: [PATCHES] Auto Partitioning Patch - WIP version 1

2008-12-16 Thread Emmanuel Cecchet
would certainly require some additional hooks to return the proper value. Best regards, Emmanuel Regards, --- ITAGAKI Takahiro NTT Open Source Software Center -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: http://www.frogthinker.org email: m...@fr

[HACKERS] Partitioning wiki page

2008-12-16 Thread Emmanuel Cecchet
. Thanks, Emmanuel -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Partitioning wiki page

2008-12-17 Thread Emmanuel Cecchet
gards, Emmanuel -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Partitioning wiki page

2008-12-17 Thread Emmanuel Cecchet
integrate that in the wiki page. Thanks for the feedback, Emmanuel On Tue, Dec 16, 2008 at 09:48:35PM -0500, Emmanuel Cecchet wrote: Hi all, I have put a first draft of the wiki page dedicated to the table partitioning development at http://wiki.postgresql.org/wiki/Table_partitioning The page is

Re: [HACKERS] Partitioning wiki page

2008-12-17 Thread Emmanuel Cecchet
n arbitrary depth of partitions even though partition management might become slightly more complex/ I will try to integrate the comments as I see them on the mailing list but feel free also to update the wiki page with your thoughts and use cases. Thanks again for the feedback, Emmanuel -- Em

Re: [HACKERS] Partitioning wiki page

2008-12-18 Thread Emmanuel Cecchet
with a constructive proposal that does not offend anyone, I think that it is best that I do not contribute anything to the wiki anymore. Best, Emmanuel -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.or

Re: [HACKERS] Sync Rep: Second thoughts

2008-12-21 Thread Emmanuel Cecchet
ing window for concurrent transactions. The writeset extraction mechanisms have had too many limitations so far to allow the use of certification-based replication in production (AFAIK). Good luck with Postgres-R. Emmanuel Emmanuel Cecchet wrote: What the application is going to see is a f

Re: [HACKERS] incoherent view of serializable transactions

2008-12-22 Thread Emmanuel Cecchet
noted in the documentation. I don't know if there's any way to fix this without killing performance. -Kevin -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: http://www.frogthinker.org email: m...@frogthinker.org Skype: emmanuel_cecchet

Re: [HACKERS] Sync Rep: Second thoughts

2008-12-22 Thread Emmanuel Cecchet
a user expects a cluster to behave like a single database instance. Happy holidays, Emmanuel -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: http://www.frogthinker.org email: m...@frogthinker.org Skype: emmanuel_cecchet -- Sent via pgsql-hackers mailing

Re: [HACKERS] incoherent view of serializable transactions

2008-12-23 Thread Emmanuel Cecchet
still have in serializable transactions. Why don't users program the application to deal with a lower isolation (actually I think they do)? But I am probably missing the point which was to fix the doc? Emmanuel -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & C

Re: [HACKERS] incoherent view of serializable transactions

2008-12-23 Thread Emmanuel Cecchet
Jeff Davis wrote: On Tue, 2008-12-23 at 00:42 -0500, Emmanuel Cecchet wrote: I still don't get why people would use SERIALIZABLE since there is no efficient implementation of it. If they need true serializable transactions, and don't care about efficiency. Is there such

Re: [HACKERS] Sync Rep: Second thoughts

2008-12-24 Thread Emmanuel Cecchet
good admission control on top of the GCS (in the application). I am now off for the holidays. Cheers, Emmanuel -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your sub

Re: [Fwd: Re: [HACKERS] Transactions and temp tables]

2008-12-24 Thread Emmanuel Cecchet
transaction. Hopefully we will be able to come up with a working solution in 8.5. Thanks for your help, Emmanuel Emmanuel Cecchet wrote: I just saw that this new patch was not considered because the previous version ended being rejected. Note that this version of the patch aims at

Re: [HACKERS] incoherent view of serializable transactions

2008-12-24 Thread Emmanuel Cecchet
side, but I still have not seen a single use case in industry where this was a requirement (but my db experience is probably narrow). Have nice serializable holidays ;-) manu -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: http://www.frogthinke

Re: [HACKERS] Table Partitioning Feature

2009-01-22 Thread Emmanuel Cecchet
ioned tables. Please feel free to post your comments and suggestions. Thanks, Amit Persistent Systems -- Emmanuel Cecchet FTO @ Frog Thinker Open Source Development & Consulting -- Web: http://www.frogthinker.org

[HACKERS] COPY enhancements

2009-09-10 Thread Emmanuel Cecchet
The attached patch contains both contribs as well as unit tests. I will submit shortly the new patch at commitfest.postgresql.org. Thanks in advance for your feedback, Emmanuel -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com aster-copy-improvements-patch-8.5v3.txt.gz

Re: [HACKERS] COPY enhancements

2009-09-10 Thread Emmanuel Cecchet
Hi David, My C isn't all that great, to put it mildly, but I noticed C++-style //comments like this, which we don't use. Ok, I will fix that. Are these dependent on each other, or could they be reviewed, etc. separately? The code implementing the functionality are independent (separate

Re: [HACKERS] COPY enhancements

2009-09-10 Thread Emmanuel Cecchet
e --> copy_logging_table_name error_logging_tuple_label --> don't know what this is for, see above error_logging_tuple_partition_key --> don't know what this is for, see above tuple_routing_in_copy --> copy_partitioning tuple_routing_cache_size --> copy_partitioning_cache_size

Re: [HACKERS] COPY enhancements

2009-09-10 Thread Emmanuel Cecchet
hat if you have a deep tree hierarchy, you don't necessarily have to insert at the top of the tree, you can start anywhere down the tree. Once we have the full partitioning support (in 8.5?), we can probably re-use some of their mechanism to route directly the tuple to the ri

Re: [HACKERS] COPY enhancements

2009-09-10 Thread Emmanuel Cecchet
ferent files and from the file names it would be easy to identify the faulty client. I am not sure how you would use the pid to identify the faulty client more easily? Emmanuel -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers mailing list (pgsql-h

Re: [HACKERS] COPY enhancements

2009-09-10 Thread Emmanuel Cecchet
Tom Lane wrote: It might be time to switch COPY over to a more easily extensible option syntax, such as we just adopted for EXPLAIN. Could you point me to the thread detailing the extensible option syntax for EXPLAIN? Is that new to 8.5? Thanks Emmanuel -- Emmanuel Cecchet Aster Data

Re: [HACKERS] COPY enhancements

2009-09-11 Thread Emmanuel Cecchet
#x27; ] [ FORCE NOT NULL (/column/ [, ...]) ] [, ERRORS { SKIP | LOG INTO { tablename | 'filename' } [ LABEL label_name ] [ KEY key_name ] [ MAX ERRORS /count/ ] } ] Is this what you had in mind? Emmanuel -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com

Re: [HACKERS] COPY enhancements

2009-09-11 Thread Emmanuel Cecchet
n example. Emmanuel / / Emmanuel Cecchet writes: The new syntax could look like: COPY /tablename/ [ ( /column/ [, ...] ) ] FROM { '/filename/' | STDIN } [ [, BINARY ] [, OIDS ] [, DELIMITER [ AS ] '/delimiter/' ] [, NULL [ AS ]

Re: [HACKERS] COPY enhancements

2009-09-11 Thread Emmanuel Cecchet
rt the new extension (and it will have to be documented) so it should not make a big difference whether it is explicitly part of the command grammar or a set of generic options. manu -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers mailing list (pgs

Re: [HACKERS] COPY enhancements

2009-09-11 Thread Emmanuel Cecchet
d how you figure out which rows are missing or extra. Emmanuel -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] COPY enhancements

2009-09-11 Thread Emmanuel Cecchet
option with different values. The last value prevails? I know that this example looks stupid but when you have a lot of options it sometimes happen that you put twice an option with different values (that happens with some JDBC driver options...). manu -- Emmanuel Cecchet Aster Data Systems

Re: [HACKERS] Patch for automating partitions in PostgreSQL 8.4 Beta 2

2009-09-14 Thread Emmanuel Cecchet
help with the partitioning implementation and/or testing of that feature since this is of interest for Aster too. Emmanuel -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] COPY enhancements

2009-09-14 Thread Emmanuel Cecchet
Greg Smith wrote: On Fri, 11 Sep 2009, Emmanuel Cecchet wrote: I guess the problem with extra or missing columns is to make sure that you know exactly which data belongs to which column so that you don't put data in the wrong columns which is likely to happen if this is fully auto

Re: [HACKERS] generic copy options

2009-09-14 Thread Emmanuel Cecchet
, or someone else is welcome to pick it up. It's on my git repo as well, as usual. -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] generic copy options

2009-09-14 Thread Emmanuel Cecchet
Robert Haas wrote: On Mon, Sep 14, 2009 at 2:51 PM, Emmanuel Cecchet wrote: This looks good. Shoud I try to elaborate on that for the patch with error logging and autopartitioning in COPY? That make sense to me. You shouldn't need to do anything else in gram.y; whatever you wa

Re: [HACKERS] generic copy options

2009-09-16 Thread Emmanuel Cecchet
decide to drop the old syntax (in 8.6?), we will be able to clean a lot especially in psql. Emmanuel On Mon, Sep 14, 2009 at 2:51 PM, Emmanuel Cecchet wrote: This looks good. Shoud I try to elaborate on that for the patch with error logging and autopartitioning in COPY? That make s

Re: [HACKERS] generic copy options

2009-09-16 Thread Emmanuel Cecchet
ed for the server to still support the syntax, is it necessary for newer version of psql to support the old syntax? I am attaching the new version of the patch with the current modifications addressing your comments. Emmanuel -- Emmanuel Cecchet Aster Data Systems Web:

Re: [HACKERS] generic copy options

2009-09-17 Thread Emmanuel Cecchet
here is that the parser does not have to be changed again if we add new options, we just have to handle them in the COPY code (which will probably have to be refactored at some point as it was discussed in a previous thread). manu 2009/9/17 Emmanuel Cecchet : Robert Haas wrote: I

Re: [HACKERS] generic copy options

2009-09-17 Thread Emmanuel Cecchet
should be sent as is to the server as you suggest. I'll come with a patch for that today. Emmanuel -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www

Re: [HACKERS] generic copy options

2009-09-17 Thread Emmanuel Cecchet
Pavel Stehule wrote: Well, I wonder how many users just upgrade psql vs upgrade the server. I was thinking that when users perform a database upgrade their application often remain the same and therefore the server needs to support the old syntax. Unless you are upgrading a machine where a bunch

Re: [HACKERS] generic copy options

2009-09-17 Thread Emmanuel Cecchet
Tom Lane wrote: Emmanuel Cecchet writes: Tom Lane wrote: psql has MORE need to support old syntax than the backend does, because it's supposed to work against old servers. Well, I wonder how many users just upgrade psql vs upgrade the server. We have establis

Re: [HACKERS] generic copy options

2009-09-17 Thread Emmanuel Cecchet
(error logging and autopartitioning) on this implementation. We might come up with new ideas for the documentation side of things with more options. manu -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com ### Eclipse Workspace Patch 1.0 #P Postgres8.5-COPY Index: src/test/r

Re: [HACKERS] generic copy options

2009-09-17 Thread Emmanuel Cecchet
Dan, My bad, I copy/pasted the hard link in output/copy.source instead of @abs_build...@. Here is a complete version of the patch with the fix on output/copy.source. Emmanuel On Thu, Sep 17, 2009 at 11:07:33AM -0400, Emmanuel Cecchet wrote: Tom Lane wrote: I wonder though if we

Re: [HACKERS] generic copy options

2009-09-17 Thread Emmanuel Cecchet
Here you go. Emmanuel Dan Colish wrote: On Thu, Sep 17, 2009 at 02:56:07PM -0400, Emmanuel Cecchet wrote: Dan, My bad, I copy/pasted the hard link in output/copy.source instead of @abs_build...@. Here is a complete version of the patch with the fix on output/copy.source. Emmanuel

Re: [HACKERS] generic copy options

2009-09-17 Thread Emmanuel Cecchet
Time: 124.303 ms COMMIT Time: 4.130 ms -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] generic copy options

2009-09-18 Thread Emmanuel Cecchet
ed in performance testing on that, that would be great. Emmanuel -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] generic copy options

2009-09-20 Thread Emmanuel Cecchet
syntax in most other places, so why here? There are counter-precedents even in the syntax of COPY itself: you can't write "()" for an empty column name list, and you can't write "()" for an empty copy_generic_option_list. Well this one was in Robert's initial patch

Re: [HACKERS] generic copy options

2009-09-20 Thread Emmanuel Cecchet
o modify all other formats to make sure they throw an error telling the user that this option is not supported. I don't think this is a great design and that it will be easy to extend. Emmanuel -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers ma

Re: [HACKERS] generic copy options

2009-09-20 Thread Emmanuel Cecchet
Tom Lane wrote: Emmanuel Cecchet writes: Here you will force every format to use the same set of options How does this "force" any such thing? As far as I understand it, every format will have to handle every format options that may exist so that they can either imple

Re: [HACKERS] generic copy options

2009-09-20 Thread Emmanuel Cecchet
anyone. Emmanuel Robert Haas wrote: On Sun, Sep 20, 2009 at 2:25 PM, Emmanuel Cecchet wrote: Tom Lane wrote: Emmanuel Cecchet writes: Here you will force every format to use the same set of options How does this "force" any such thing? As far as I und

Re: [HACKERS] generic copy options

2009-09-21 Thread Emmanuel Cecchet
mandatory and be either text, binary or csv (for now). manu -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Join optimization for inheritance tables

2009-09-22 Thread Emmanuel Cecchet
auses be simple "Var op Var" clauses. But the main thing is that a large fraction of the patch is doing something I don't think we should try to do. regards, tom lane -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent vi

Re: [HACKERS] COPY enhancements

2009-09-24 Thread Emmanuel Cecchet
Yes, I have to update the patch following what Tom already integrated of the COPY patch. I will get a new version posted as soon as I can. Emmanuel Robert Haas wrote: On Fri, Sep 18, 2009 at 12:14 AM, Emmanuel Cecchet wrote: Here is a new version of error logging and autopartitioning in

Re: [HACKERS] COPY enhancements

2009-09-25 Thread Emmanuel Cecchet
Robert, Here is the new version of the patch that applies to CVS HEAD as of this morning. Emmanuel On Fri, Sep 18, 2009 at 12:14 AM, Emmanuel Cecchet wrote: Here is a new version of error logging and autopartitioning in COPY based on the latest COPY patch that provides the new syntax

Re: [HACKERS] Join optimization for inheritance tables

2009-09-26 Thread Emmanuel Cecchet
what is the right approach for this. manu On Tue, 2009-09-22 at 18:16 -0400, Emmanuel Cecchet wrote: If the partitioning implementation does not make progress (and does not make it for 8.5) Manu, not sure if you are referring to Kedar's patch I reviewed earlier in July, but that

Re: [HACKERS] COPY enhancements

2009-10-04 Thread Emmanuel Cecchet
+m and that will do the trick. I am attaching a copy of the file, hoping that the attachment will arrive with the malformed terminator in your inbox! manu Jeff Davis wrote: On Fri, 2009-09-25 at 10:01 -0400, Emmanuel Cecchet wrote: Robert, Here is the new version of the patch that applies

Re: [HACKERS] COPY enhancements

2009-10-05 Thread Emmanuel Cecchet
d by Tom. The new format of options has been introduced just before this patch. I am attaching a revised version of the patch. Emmanuel -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com aster-copy-newsyntax-patch-8.5v6context.txt.gz Description: GNU Zip compressed d

Re: [HACKERS] COPY enhancements

2009-10-06 Thread Emmanuel Cecchet
e from a successful COPY command or not will be left to the user. Emmanuel -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com

Re: [HACKERS] COPY enhancements

2009-10-07 Thread Emmanuel Cecchet
appelation, so I'm going with both. But in all seriousness if this patch needs substantial reworking (which it sounds like it does) we should postpone it to the next CF; we are quickly running out of days, and it's not fair to reviewers or committers to ask for new reviews of substantia

Re: [HACKERS] COPY enhancements

2009-10-07 Thread Emmanuel Cecchet
Robert Haas wrote: On Wed, Oct 7, 2009 at 9:12 AM, Emmanuel Cecchet wrote: Hi all, I think there is a misunderstanding about what the current patch is about. The patch includes 2 things: - error logging in a table for bad tuples in a COPY operation (see http://wiki.postgresql.org/wiki

Re: [HACKERS] COPY enhancements

2009-10-07 Thread Emmanuel Cecchet
Andrew Dunstan wrote: Tom Lane wrote: Andrew Dunstan writes: Emmanuel Cecchet wrote: If you prefer to postpone the auto-partitioning to the next commit fest, I can strip it from the current patch and re-submit it for the next fest (but it's just 2 isolated me

Re: [HACKERS] COPY enhancements

2009-10-07 Thread Emmanuel Cecchet
Robert Haas wrote: On Wed, Oct 7, 2009 at 11:39 AM, Emmanuel Cecchet wrote: Robert Haas wrote: On Wed, Oct 7, 2009 at 9:12 AM, Emmanuel Cecchet wrote: Hi all, I think there is a misunderstanding about what the current patch is about. The patch includes 2 things: - error

Re: [HACKERS] COPY enhancements

2009-10-07 Thread Emmanuel Cecchet
ependent from COPY to me. manu -- Emmanuel Cecchet Aster Data Systems Web: http://www.asterdata.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] COPY enhancements

2009-10-13 Thread Emmanuel Cecchet
e every row in a sub-transaction -> is there any real benefits compared to pg_loader? Tom was also suggesting 'refactoring COPY into a series of steps that the user can control'. What would these steps be? Would that be per row and allow to discard a bad tuple? Emmanuel -- Emmanuel

Re: [HACKERS] COPY enhancements

2009-10-13 Thread Emmanuel Cecchet
Tom Lane wrote: Emmanuel Cecchet writes: - speed with error logging best effort: no use of sub-transactions but errors that can safely be trapped with pg_try/catch (no index violation, There aren't any. You can *not* put a try/catch around arbitrary code without a subtransa

Re: [HACKERS] COPY enhancements

2009-10-20 Thread Emmanuel Cecchet
Tom, Emmanuel Cecchet writes: Tom Lane wrote: There aren't any. You can *not* put a try/catch around arbitrary code without a subtransaction. Don't even think about it Well then why the tests provided with the patch are working? Because they carefully exercise o

[HACKERS] DISTINCT ON

2009-11-03 Thread Emmanuel Cecchet
or (but I guess it should): SELECT DISTINCT ON ('1'::varchar, '2'::varchar, '1'::varchar) a FROM (SELECT 1 AS a) AS a ORDER BY '1'::varchar, '2'::varchar, '2'::varchar; Am I misunderstanding something or is there a bug? Thanks for th

Re: [HACKERS] DISTINCT ON

2009-11-04 Thread Emmanuel Cecchet
Tom Lane wrote: Greg Stark writes: On Wed, Nov 4, 2009 at 3:17 AM, Emmanuel Cecchet wrote: SELECT DISTINCT ON ('1'::varchar, '1'::varchar) a FROM (SELECT 1 AS a) AS a ORDER BY '1'::varchar, '1'::varchar, '2'::varchar; T

[HACKERS] Partitioning option for COPY

2009-11-11 Thread Emmanuel Cecchet
logging related comments that do not apply here. Looking forward to your feedback Emmanuel -- Emmanuel Cecchet Aster Data Web: http://www.asterdata.com Index: src/test/regress/parallel_schedule === RCS file: /home/manu/cvsrepo/pgsql

Re: [HACKERS] Partitioning option for COPY

2009-11-11 Thread Emmanuel Cecchet
uld be replaced with the catalog. This implementation is only for the current 8.5 and it will not be needed anymore once we get a fully functional partitioning in Postgres which seems to be for a future version. Best regards, Emmanuel -- Emmanuel Cecchet Aster Data Web: http://www.asterdata.co

Re: [HACKERS] Patch committers

2009-11-11 Thread Emmanuel Cecchet
The following email expresses my personal opinion and does not reflect the opinion of my employers. Bruce Momjian wrote: I also think the bad economy is making it harder for people/companies to devote time to community stuff when paid work is available. Actually the bad economy should be a b

  1   2   >