Re: [Pharo-dev] Atomic commits

100% Agreed. > On 8 Jan 2016, at 18:25, Dimitris Chloupis wrote: > > When one uses a tool in a way that is not suppose to use , the one must > expect all sort of new and fascinating problems. > > Some think that putting changes in 2121 files in a single commit is a good > idea, github polite

Re: [Pharo-dev] Better class comment version2

I guess that is a class comment for LayoutFrame. I think this is great improvement. By I the way, I noticed something really strange when I was using it in my learning project of a TicTacToe game. I started initializing a LayoutFrame using #fractions:offsets:, but I had strange incorrect result

Re: [Pharo-dev] [pharo-project/pharo-core] 636bf8: 50521

Cool! Nice addition. When the shortcut reminder appears, on my Mac, the Command symbol ⌘ is not displayed, instead there is generic symbol that looks like this: ⌧ (but might be a different one). There might be a problem with some font configuration. > > Log Message: > --- > 50521 >

Re: [Pharo-dev] Better class comment version2

right. So, your > rectangle 'offsets' was in fact: > -3 @ -3 corner: 3 @ 3 > which is exactly the reverse of what you intended ;) > > Using the elementary distance accessors is the correct approach. > > Regards, > > Thierry > > Le 10/01/2016 23:05,

[Pharo-dev] Bad layoutFrame>>#hash

I happened to look at the new code for LayoutFrame>>#hash hash ^self species hash bitXor: (self leftFraction bitXor: (self leftOffset bitXor: (self topFraction bitXor: (self topOffset bitXor: (self rightFra

Re: [Pharo-dev] Bad layoutFrame>>#hash

Since it's not obvious why xor-ing is a bad way to produce hash, here is a link that gives some background https://en.wikipedia.org/wiki/Hash_function#Uniformity > On 11 Jan 2016, at 10:01, David Allouche wrote: > > I happened to look at the new code for LayoutFrame>

Re: [Pharo-dev] Morphic Migrations gotchas, was Re: Better class comment version2

I wonder whether it would be worth reversing this change, to remove an unnecessary incompatibility with other dialects. But maybe there is no development activity outside of Pharo, that would justify making any effort to maintain compatibility. I do not know. Practicality beats purity, if clean

Re: [Pharo-dev] Problem with gitfiletree numeration

> On 13 Jan 2016, at 15:33, Thierry Goubier wrote: > > > > 2016-01-13 14:32 GMT+01:00 Mariano Martinez Peck >: > > On Wed, Jan 13, 2016 at 10:00 AM, Thierry Goubier > wrote: > > > 2016-01-13 13:56 GMT+01:00 Mariano Martinez P

Re: [Pharo-dev] Bad layoutFrame>>#hash

antagonising people, but I will not write lengthy messages like this one every time someone questions my thinking. Have a nice day. > Le 11/1/16 10:09, David Allouche a écrit : >> Since it's not obvious why xor-ing is a bad way to produce hash, here is a >> link that gives some

Re: [Pharo-dev] Bad layoutFrame>>#hash

> On 13 Jan 2016, at 18:09, Stephan Eggermont wrote: > > Name: > SLICE-Issue-17363-LayoutFrame-fractions-0--0-corner-1--1--LayoutFrame-identity-should-be-true-and-it-is-not-StephanEggermont.2 > Author: StephanEggermont > Time: 13 January 2016, 6:06:01.571074 pm > UUID: 9a5e9ae3-1357-4bfb-921a-3

Re: [Pharo-dev] Code reviews

> On 13 Jan 2016, at 18:37, Ben Coman wrote: > > On Thu, Jan 14, 2016 at 12:22 AM, David Allouche wrote: >> >> By the way, how do you guys do code reviews for code integrated into the >> core? > > Its fairly informal. Once a Slice has been submitted to the &

Re: [Pharo-dev] Bad layoutFrame>>#hash

> On 13 Jan 2016, at 19:31, Nicolas Cellier > wrote: > > Note that Squeak has reduced the number of collisions for floats by not > erasing the most significant bits of each word. > I've tested the squeak implementation with Andres Valloud tool in VW, it does > not perform so bad for the sets

Re: [Pharo-dev] Bad layoutFrame>>#hash

> On 13 Jan 2016, at 20:32, stepharo wrote: > > Hi david > > I would like to turn your post into a chapter for a forthcoming book so that > people can read and get the idea. Yes I would be glad :-) Please just remember to credit the author. Is there a recommended license for Pharo documenta

Re: [Pharo-dev] Bad layoutFrame>>#hash

> On 14 Jan 2016, at 01:55, Ben Coman wrote: > > On Thu, Jan 14, 2016 at 5:45 AM, David Allouche wrote: >> >>> On 13 Jan 2016, at 20:32, stepharo wrote: >>> >>> Hi david >>> >>> I would like to turn your post into a chapter for

Re: [Pharo-dev] Bad layoutFrame>>#hash

> On 14 Jan 2016, at 13:31, David Allouche wrote: > >> >> On 14 Jan 2016, at 01:55, Ben Coman wrote: >> >> On Thu, Jan 14, 2016 at 5:45 AM, David Allouche wrote: >>> >>>> On 13 Jan 2016, at 20:32, stepharo wrote: >>>> >>

Re: [Pharo-dev] [Moose-dev] [Pharo-users] [ann] gtdebugger in pharo 5.0

> On 15 Jan 2016, at 13:39, Tudor Girba wrote: >> On Jan 14, 2016, at 12:59 PM, Andrei Chis wrote: > >> Most (all?) other tools don't have Accept/Cancel buttons. > > The logic is that these are actions that do not depend on the selection, so > in Glamour we map these on actions that are appli

Re: [Pharo-dev] Contributing to Pharo

> On 15 Jan 2016, at 21:01, stepharo wrote: > > Le 15/1/16 20:45, David Allouche a écrit : > >> it does not show the package that contains my fix (Spec-Tools) > This is strange. And MC shows the package as dirty? Then this is a bug. I do not know how MC shows a package

Re: [Pharo-dev] Contributing to Pharo

> On 15 Jan 2016, at 23:23, Nicolai Hess wrote: > 2016-01-15 23:16 GMT+01:00 David Allouche <mailto:da...@allouche.net>>: >> On 15 Jan 2016, at 21:01, stepharo > <mailto:steph...@free.fr>> wrote: >> Le 15/1/16 20:45, David Allouche a écrit : >>> i

Re: [Pharo-dev] Contributing to Pharo

> On 15 Jan 2016, at 23:33, David Allouche wrote: > > So yes, it's broken, but maybe it's something else entirely, I get new > reproducible errors every few minutes: errors when activating pretty printing > in the diff viewer in Monticello, unexpected contextual men

Re: [Pharo-dev] Contributing to Pharo

> On 15 Jan 2016, at 23:49, Nicolai Hess wrote: > > 2016-01-15 23:33 GMT+01:00 David Allouche <mailto:da...@allouche.net>>: > > So yes, it's broken, but maybe it's something else entirely, I get new > reproducible errors every few minutes: errors when

Re: [Pharo-dev] Contributing to Pharo

> On 15 Jan 2016, at 23:55, Nicolai Hess wrote: > > 2016-01-15 23:48 GMT+01:00 David Allouche <mailto:da...@allouche.net>>: > > Built a new latest image. Now I no longer have any syntax highlighting in the > debuggers or class browser… > > Now, people sh

Re: [Pharo-dev] Contributing to Pharo

> On 15 Jan 2016, at 23:58, David Allouche wrote: >> >> I am now (at this moment) working with the image version 50528. > > Yes, that's the one where syntax highlighting appears broken. Nevermind, it works… I must have imagined it did not, or a transient bout of colour-blindness…

Re: [Pharo-dev] Contributing to Pharo

> On 16 Jan 2016, at 02:15, Ben Coman wrote: > On Sat, Jan 16, 2016 at 3:45 AM, David Allouche <mailto:da...@allouche.net>> wrote: > it shows a bunch of packages I have not touched > it does not show the package that contains my fix (Spec-Tools) > > I am curiou

Re: [Pharo-dev] Contributing to Pharo

> On 16 Jan 2016, at 02:42, Ben Coman wrote: > > So if occasionally if everything seems against you, after trying a > fresh Image as you already did, slide back to the last build that > worked for you (I don't think the issues you experience are Spur > related, but 50496 might be a good fallbac

Re: [Pharo-dev] Contributing to Pharo

> On 16 Jan 2016, at 12:12, stepharo wrote: >>> On 16 Jan 2016, at 02:42, Ben Coman wrote: >>> >>> So if occasionally if everything seems against you, after trying a >>> fresh Image as you already did, slide back to the last build that >>> worked for you (I don't think the issues you experience

Re: [Pharo-dev] Contributing to Pharo

> On 16 Jan 2016, at 12:14, stepharo wrote: > > Le 16/1/16 09:59, David Allouche a écrit : >> >> But, really, this "list of dirty packages" should really only list dirty >> packages. What is the use case for selecting a non-dirty package? > > be

Re: [Pharo-dev] gtdebugger in pharo 5.0

Cool. While you are there, could provide a way to separate instance variables from local variables (and class shared variables too, maybe)? It could be different columns, filtering, tabs, I do not really care. Currently, when debugging classes with lots of instance variables (like morphic stuff

Re: [Pharo-dev] new debugger shortcuts

> On 17 Jan 2016, at 17:41, Tudor Girba wrote: > > Hi, > > The existing debugger shortcuts are conflicting with code editing shortcuts. > > Now, I defined the following shortcuts: > resume - cmd + r > restart - cmd + shift + a > over - cmd + shift + o > through - cmd + shift + t > into - cmd

Re: [Pharo-dev] gtdebugger in pharo 5.0

> On 17 Jan 2016, at 16:52, Tudor Girba wrote: > > Hi, > >> On Jan 17, 2016, at 1:18 PM, David Allouche wrote: >> >> Cool. While you are there, could provide a way to separate instance >> variables from local variables (and class shared variables t

Re: [Pharo-dev] spotter: top search for senders and references

BTW, thanks for the explanations for Spotter. > On 19 Jan 2016, at 18:37, Tudor Girba wrote: > > And then, in Spotter we have another discovery mechanism: Shift. When you > press it, all clickable things get highlighted (including the arrow). We > chose Shift because it is something that you t

Re: [Pharo-dev] [pharo-project/pharo-core] 4e9825: 50535

> On 19 Jan 2016, at 19:07, Nicolas Cellier > wrote: > > I can only tell what the github interface let me see: > > 1) the diffs in update scripts (my guess comes from here) > -script50534 > +script50535 > > and > update50535 > > 2) the commentForCurrentUpdate.st > > 3) the ConfigurationOf

Re: [Pharo-dev] Spotter suggestions

Since you asked to keep challenging… Preamble: Sorry, I did one of those long messages again. I hope I am not annoying people with that. > On 19 Jan 2016, at 22:40, Tudor Girba wrote: > > Hi, > >> On Jan 19, 2016, at 9:18 PM, stepharo wrote: >> >> >> &

Re: [Pharo-dev] Spotter suggestions

> On 20 Jan 2016, at 10:39, David Allouche wrote: > > And some suggestion for all lists: Another one: Esc should close Spotter. I see Cmd-W does that, but Spotter is not a "normal" window, it is an incremental search popup. Thanks.

Re: [Pharo-dev] Spotter suggestions

> On 20 Jan 2016, at 11:05, Tudor Girba wrote: > > Hi, > >> On Jan 20, 2016, at 10:48 AM, David Allouche wrote: >> >> >>> On 20 Jan 2016, at 10:39, David Allouche wrote: >>> >>> And some suggestion for all lists: >> >

Re: [Pharo-dev] Spotter suggestions

> On 21 Jan 2016, at 22:36, stepharo wrote: > > Le 20/1/16 10:39, David Allouche a écrit : >> Since you asked to keep challenging… >> >> Preamble: Sorry, I did one of those long messages again. I hope I am not >> annoying people with that. > >

Re: [Pharo-dev] another spotter question

> On 22 Jan 2016, at 10:23, Aliaksei Syrel wrote: > Sorry for long email > I found it rather short and synthetic ;-) At least compared to my recent messages.

Re: [Pharo-dev] another spotter question

> On 22 Jan 2016, at 11:08, Aliaksei Syrel wrote: > > I was talking about clickable arrow to open preview ;) > Oh wow! I had no idea you click that area to toggle the preview! Even with the shift hints. At the very least, it needs something more in the shift hints than just a change in backg

Re: [Pharo-dev] Contributing to Pharo

Thanks Dale for all the explanations. How Monticello and version control relate in the big picture is starting to make sense for me. Now, I better understand why filetree ended up uses a file-per-method format, even though that is relatively hostile to git user interfaces optimised for other l

Re: [Pharo-dev] 17502. Morph layoutProperties must not be nil by default

> On 31 Jan 2016, at 13:38, Esteban Lorenzano wrote: > > >> On 31 Jan 2016, at 13:26, Henrik Nergaard > > wrote: >> >> LayoutProperties is an optional part of Morph using some type of defined >> layout (mostly used by the LayoutPolicy subclasses), this is though

Re: [Pharo-dev] 17502. Morph layoutProperties must not be nil by default

> On 1 Feb 2016, at 10:49, Esteban Lorenzano wrote: > > but layoutProperties are not immutable so if you receive an instance of > NullLayoutProperties (singleton), and you do something like this: > > myMorph cellInset: 5, you has to check for correct properties anyway… that’s > why is implem