i didn't followed the last livedocs patchs but the last time i test it,
after the rtl stuff was commited, its just worked fine.
Great, so then I can just pull off my unread mails from that TODO list :)
Goba
i didn't followed the last livedocs patchs but the last time i test it,
after the rtl stuff was commited, its just worked fine.
Moshe.
"Gabor Hojtsy" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
> What is the status of RTL support in livedocs?
>
> Goba
>
> moshe doron írta:
> > you
What is the status of RTL support in livedocs?
Goba
moshe doron írta:
you correction is mistake. RTL and CHARSET are defines not vars at all.
--/moshe
"Nuno Lopes" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
Moshe, as I've already told you, your patch had a little bug with GLOBALS.
On Wed, 5 May 2004, Nuno Lopes wrote:
> OMG.
>
> using global $DEFINE is right!
>
> If you don't declare it as global, it won't work if register_globals is off
> (as you should have it! :)
$GLOBALS['key'] please, no global $key;
Derick
"Moshe Doron" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
> > Thanks; looks good, although I'd prefer it if we didn't have too many
> > special cases going on.
>
> > You have an RTL constant to indicate that the content is RTL, but then
> there
> > are a number of places where you
> Thanks; looks good, although I'd prefer it if we didn't have too many
> special cases going on.
> You have an RTL constant to indicate that the content is RTL, but then
there
> are a number of places where you use that to generate a dir="rtl"
attribute.
> It would be better to define a DIRECTION
OMG.
using global $DEFINE is right!
If you don't declare it as global, it won't work if register_globals is off
(as you should have it! :)
Nuno
- Original Message -
> you correction is mistake. RTL and CHARSET are defines not vars at all.
>
> --/moshe
you correction is mistake. RTL and CHARSET are defines not vars at all.
--/moshe
"Nuno Lopes" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
> Moshe, as I've already told you, your patch had a little bug with GLOBALS.
>
> Attached is a correction for your patch.
>
> Nuno
>
> - Or
x27;] = 'format_emphasis';
but then:
function format_em($node) { ... }
--Wez.
-Original Message-
From: moshe doron [mailto:[EMAIL PROTECTED]
Sent: 05 May 2004 19:14
To: [EMAIL PROTECTED]
Subject: [PHP-DOC] [PATCH] rtl...
"Wez Furlong" <[EMAIL PROTECTED]> wrote
Moshe, as I've already told you, your patch had a little bug with GLOBALS.
Attached is a correction for your patch.
Nuno
- Original Message -
>
> "Wez Furlong" <[EMAIL PROTECTED]> wrote in message
> news:[EMAIL PROTECTED]
> >
> > Now, quit complaining and get coding ;-)
> >
> > --Wez.
"Wez Furlong" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
>
> Now, quit complaining and get coding ;-)
>
> --Wez.
>
http://moshe.i-com-it.com/patchs/livedocs-rtl3.patch.txt
this patch contains:
1. initial rtl support.
2. add some missing htmlspecialchars().
i change the htmlenti
>
To: <[EMAIL PROTECTED]>
Sent: Tuesday, May 04, 2004 10:43 AM
Subject: [PHP-DOC] [PATCH] rtl second edition
> here the 'all in one method':
> http://moshe.i-com-it.com/patchs/livedocs-rtl2.patch.txt
> rejections?
>
> --/moshe.
here the 'all in one method':
http://moshe.i-com-it.com/patchs/livedocs-rtl2.patch.txt
rejections?
--/moshe.
On Mon, 3 May 2004, moshe doron wrote:
>
> > > We need also to decide how to choose the encoding and how to choose if
> RTL
> > > or LTR for each language.
> > > Create an array with this info? It's dificult to extract this info from
> > the
> > > old (actual) build system because livedocs can be
Please tell me what RTL mean ?
Thanks
http://www.raovat.org
- Original Message -
From: "Derick Rethans" <[EMAIL PROTECTED]>
To: "Nuno Lopes" <[EMAIL PROTECTED]>
Cc: "moshe doron" <[EMAIL PROTECTED]>; "PHPdoc"
<[EMAIL PROTECT
Moshe Doron wrote:
"Mehdi Achour" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
I'm 100% with Gabor here. We should only focus on the rendering part
now. The build system will remain the same for the moment.
Moshe, can you please wait for an answer before commiting ? Next time,
please
no rejections.
"Nuno Lopes" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
> > more feedbacks?
> > goba, adding new i18n.php file that will hold the languages data is
> agreed?
> >
> > > --/moshe.
>
> My proposal:
> in common.php have something like this:
>
> $rtl_langs = array('he',.
> more feedbacks?
> goba, adding new i18n.php file that will hold the languages data is
agreed?
>
> > --/moshe.
My proposal:
in common.php have something like this:
$rtl_langs = array('he',);
if (isset($rtl_langs[$lang]) {
define('RTL', 1);
}
$chars = array('he' => 'ISO-xpto'; 'ja'=>'BI
"Mehdi Achour" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
> I'm 100% with Gabor here. We should only focus on the rendering part
> now. The build system will remain the same for the moment.
>
> Moshe, can you please wait for an answer before commiting ? Next time,
> please propose
I'm 100% with Gabor here. We should only focus on the rendering part
now. The build system will remain the same for the moment.
Moshe, can you please wait for an answer before commiting ? Next time,
please propose the patch *before* commiting it, it will avoid us to
commit, revert, re-commit an
> > We need also to decide how to choose the encoding and how to choose if
RTL
> > or LTR for each language.
> > Create an array with this info? It's dificult to extract this info from
> the
> > old (actual) build system because livedocs can be used for more than one
> > language.
> >
>
> i'm +1 f
"Moshe Doron" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
>
> "Nuno Lopes" <[EMAIL PROTECTED]> wrote in message
> news:[EMAIL PROTECTED]
> > The old build system is used when you run build.sh in livedocs.
> > It does a ./configure --with-lang=$lang
> >
> > I don't know if we will e
On Sun, 2 May 2004, Nuno Lopes wrote:
> But I think we don't need any other file for RTL. We need just an array
> (sorry Derick :)) with the languages that use RTL.
I never said we shouldn't do that, i said you did it in the wrong place.
Derick
"Nuno Lopes" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
> The old build system is used when you run build.sh in livedocs.
> It does a ./configure --with-lang=$lang
>
> I don't know if we will ever get ride of this build system.
>
> The use of entities is a good idea, Goba! we may
Are you planing to use on the old build system forever? Shouldn't livdocs
replace completely the old system sometime?
Livedocs is currently not aimed at replacing the complete build system.
Livedocs itself needs command line tools to build the index and
configure the system. It does not know that
The old build system is used when you run build.sh in livedocs.
It does a ./configure --with-lang=$lang
I don't know if we will ever get ride of this build system.
The use of entities is a good idea, Goba! we may add the entites for
livedocs in language-snippets.ent, for example.
Moshe: There wo
Are you planing to use on the old build system forever? Shouldn't livdocs
replace completely the old system sometime?
also if the answers to those two questions are yes and no, Imho, the multi
languages support on the old build is realy creak part (specially in the
aspect of not duplication the co
I think that having a file for each language with the strings is OK.
But I think we don't need any other file for RTL. We need just an array
(sorry Derick :)) with the languages that use RTL.
Which languages use RTL? and which charset?
A lot of strings can be extracted from the phpdoc build system
"Nuno Lopes" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
> > The issue you raise here is more files arrangement Issue then real
issue.
> > what about one file per language that contains all the strings using the
> on
> > the next phases and include() on the end of the file rtl_sty
> The issue you raise here is more files arrangement Issue then real issue.
> what about one file per language that contains all the strings using the
on
> the next phases and include() on the end of the file rtl_style_mapping or
> ltr_style_mapping?
>
> if ok, someone with filesystem access to th
"Gabor Hojtsy" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
> Hi Moshe,
>
> > In 3 months delay cause by work loading here is rtl:
> > http://moshe.i-com-it.com/patchs/livedocs-rtl.patch.txt
> >
> > Here is reminder what i did:
> >
> > 1. Make the style_mapping.php (optionally - def
31 matches
Mail list logo
