On Tue, Sep 17, 2013 at 5:08 PM, Yannick Torrès yannick.tor...@gmail.com
wrote:
I just push a patch for this :
Great, thanks :-)
On a related note, can you review
https://github.com/php/web-doc-editor/pull/2 ?
This has come about because I just reverted an invalid edit on
I can't test it actually, but il seems fine for me.
Best,
Yannick
2013/9/18 Chris Wright daveran...@php.net
On Tue, Sep 17, 2013 at 5:08 PM, Yannick Torrès yannick.tor...@gmail.com
wrote:
I just push a patch for this :
Great, thanks :-)
On a related note, can you review
Could you please give me a filename as example for this ?
2013/9/16 Hannes Magnusson hannes.magnus...@gmail.com
On Sun, Sep 15, 2013 at 3:27 PM, Chris Wright c...@daverandom.com wrote:
I've pushed a couple of commits to clear the backlog here and
something that is definitely a problem with
About decon.xml, the type tag is necessary for the check. See the regex
from the last modified file from my last commit
Best,
Yannick
2013/9/17 Yannick Torrès yannick.tor...@gmail.com
I just push a patch for this :
On Tue, Sep 17, 2013 at 12:34 PM, Yannick Torrès yannick.tor...@gmail.com
wrote:
Could you please give me a filename as example for this ?
en/reference/array/functions/array-intersect-ukey.xml
en/reference/array/functions/array-multisort.xml
Interestingly, the following file also has one but
I just push a patch for this :
http://git.php.net/?p=web/doc-editor.git;a=commitdiff;h=46ed4c5754dc2ed8a541c3168d9b97c7db08c871
It will solve '...' argument warning, but not the en/language/oop5/decon.xml
warning ;)
2013/9/17 Chris Wright chr...@aquacool.ltd.uk
On Tue, Sep 17, 2013 at 12:34
On Sun, Sep 15, 2013 at 3:27 PM, Chris Wright c...@daverandom.com wrote:
I've pushed a couple of commits to clear the backlog here and
something that is definitely a problem with the checker is that it
considers varargs to have a missing initializer. Having the strict
standards checker ignore
I've pushed a couple of commits to clear the backlog here and
something that is definitely a problem with the checker is that it
considers varargs to have a missing initializer. Having the strict
standards checker ignore any thing structured like this:
methodparam choice=opt
OK great. I'll make a start on correcting the obvious ones and leave
any I'm not sure about alone, hopefully we can get the outstanding
list down to just these cases fairly quickly, which will quite
effectively separate the wheat from the chaff, and we can take another
look at the situation at
Some of you may have noticed that I've been on a bit of a crusade to
nuke as many issues as possible in the OE - keep the patches list
empty, evaluate changes that are left in work in progress by users
who don't realise they need to create a patch (I know this is an issue
as I have previously done
Tangent:
On Mon, Sep 9, 2013 at 4:37 PM, Chris Wright c...@daverandom.com wrote:
I know the new MD-esque format is pretty much definitely going to
happen...
Docs migration is a serious subject that needs more discussion if it's
going to happen.
On Mon, Sep 9, 2013 at 3:37 PM, Chris Wright c...@daverandom.com wrote:
- What sort of timescale are we looking at for this (I'm not expecting
dates but maybe weeks vs. months vs. years?)
We do things whenever we have time.
This change is even more tricky (although easier in some respect) then
On 10 September 2013 00:28, Hannes Magnusson hannes.magnus...@gmail.com wrote:
IMO an optional argument should have a way to skip it, using default value.
its annoying when in userland you have to do
if ($option) {
foo($arg1, $arg2, $option);
} else {
foo($arg1, $arg2);
}
And I consider
That's a slightly different issue though.
In general functions with optional arguments have default value, or can be
faked with for example empty array or null. In those cases we should use
that for the initializer argument.
For others, I think we need to evaluate them on case by case bases what
14 matches
Mail list logo
