So that llvmpipe can run in a reasonable amount of time.
---
tests/shaders/fp-indirections2.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/shaders/fp-indirections2.c b/tests/shaders/fp-indirections2.c
index 0b1ee28..5cf09eb 100644
---
---
tests/spec/glsl-1.30/execution/fs-texelFetchOffset-2D.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/tests/spec/glsl-1.30/execution/fs-texelFetchOffset-2D.c
b/tests/spec/glsl-1.30/execution/fs-texelFetchOffset-2D.c
index 1905900..f461d58 100644
---
To fix Windows run.
---
tests/spec/glsl-1.30/execution/fs-discard-exit-2.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/tests/spec/glsl-1.30/execution/fs-discard-exit-2.c
b/tests/spec/glsl-1.30/execution/fs-discard-exit-2.c
index 2a003fe..e9b6cd2
On 09/18/2014 04:24 AM, Neil Roberts wrote:
Ilia Mirkin imir...@alum.mit.edu writes:
Just bikeshedding here, but isn't the common way of doing this to just have
(1ULL bits) - 1
?
Yes, that's probably more clear. One advantage of doing the shift in the
other direction is if we ever end up
Reviewed-by: Brian Paul bri...@vmware.com
Just a minor suggestion below (in 2 places).
On 09/18/2014 08:09 AM, srol...@vmware.com wrote:
From: Roland Scheidegger srol...@vmware.com
The test takes ages (somewhere in the order of an hour) on llvmpipe, because
the driver announces support
Not exactly sure why, but the max = ~(~0ul bits) assignment resulted
in max=0 when bits==32 with MinGW. This caused us to do a divide by zero
and many of the tests failed.
Special-case the 32-bit case and change the arithmetic to be a little
simpler (to me at least). Change sn_to_float() to be
Ugh, I see this has already been covered today. I don't have a strong
preference for which fix is used.
-Brian
On 09/17/2014 11:14 AM, Brian Paul wrote:
Not exactly sure why, but the max = ~(~0ul bits) assignment resulted
in max=0 when bits==32 with MinGW. This caused us to do a divide
The Mesa program optimizer was failing some assertions because of
the SWZ 0, 1 terms.
---
tests/all.py|1 +
tests/asmparsertest/shaders/ARBfp1.0/swz-08.txt |8
2 files changed, 9 insertions(+)
create mode 100644
Two comments below.
-Brian
On 09/09/2014 03:23 AM, Iago Toral Quiroga wrote:
This has been hanging here for a while, so if nobody says otherwise I'd
like to push this next week.
Iago
On jue, 2014-06-12 at 09:00 +0200, Iago Toral Quiroga wrote:
This tests correct rendering of polygons using
. There is no way to access the hidden name or
+// make it unhidden, without exiting the scope that hid it.
+
+#version 120
+
+struct Name {
+float a;
+};
+
+void main()
+{
+vec4 Name = vec4(1.0);
+gl_Position = Name;
+}
+
Reviewed-by: Brian Paul bri...@vmware.com
Basic checking that the SKIP_PIXELS, SKIP_ROWS parameters are
multiples of the block size.
And check that if a GL error is generated, the glCompressedTexSubImage2D()
call is no-op'd (to exercise a Mesa bug.)
---
tests/texturing/s3tc-errors.c | 78 +
1
From: Meng-Lin Wu mengl...@vmware.com
Reviewed-by: Brian Paul bri...@vmware.com
---
tests/spec/ext_timer_query/CMakeLists.gl.txt |5 +--
tests/spec/ext_timer_query/time-elapsed.c| 58 +++---
2 files changed, 44 insertions(+), 19 deletions(-)
diff --git a/tests/spec
From: Meng-Lin Wu mengl...@vmware.com
And silence MinGW compiler warnings when printing 64-bit ints.
Reviewed-by: Brian Paul bri...@vmware.com
---
tests/spec/arb_timer_query/CMakeLists.gl.txt |4 +---
tests/spec/arb_timer_query/timestamp-get.c | 32 --
2 files
to do that too. But the two get time functions in the two test
aren't identical (one returns float, the other int64, for example) and I
don't have time right now to unify things.
I'd like to commit these as-is for the time being.
-Brian
Cheers,
Emil
On 04/09/14 20:34, Brian Paul wrote
On 09/04/2014 03:07 PM, Emil Velikov wrote:
On 04/09/14 21:56, Brian Paul wrote:
On 09/04/2014 02:25 PM, Emil Velikov wrote:
Hi Brian,
Wouldn't it be better if we add a couple of wrapper functions: piglit_get_time
and piglit_sleep ? This way we'll be able to keep the tests clean and
OS
: GL_ARB_explicit_attrib_location
// [end config]
//
// While the GL_ARB_explicit_attrib_location specification does not say
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
For the exceed test, we create an array in a UBO that's one vector
larger than what's supposed to be supported.
The shader program is allowed to link or not link in this situation.
But if it does link, the behavior of indexing beyond the UBO size
probably isn't well defined. Instead of
On 08/15/2014 08:52 AM, Ilia Mirkin wrote:
Brian,
You recently went on a campaign against setting .window_width/height
in piglit tests, in order to fix issues on Windows I guess? I noticed
that a bunch of failures on a NV17 card (GeForce4 MX 440) are due to
the fact that the window sizes are
Basic checking that the SKIP_PIXELS, SKIP_ROWS parameters are
multiples of the block size.
And check that if a GL error is generated, the glCompressedTexSubImage2D()
call is no-op'd (to exercise a Mesa bug.)
---
tests/texturing/s3tc-errors.c | 78 +
1
if you have any doubts though.
See my other replies for a few minor nits.
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 08/12/2014 11:18 AM, Emil Velikov wrote:
For some bizzare reason the MSVC build fails with unresolved symbols
without these two set in. I'm suspecting that something fishy is
happening with waffle and/or cmake + MSVC. Until we have that one
resolved, this helps us get through with the build.
On 08/12/2014 11:18 AM, Emil Velikov wrote:
MSVC 2013 provides _MSC_VER 1800 and __STDC_VERSION__ 199901L. As
such the preprocessor tries ot evaluate the undefined symbol __GNUC__,
s/ot/to/
agrees that is less than 3 and we end up with the following error
message:
On 08/12/2014 11:18 AM, Emil Velikov wrote:
This will allow up to use waffle with it's upcoming WGL support for
s/up/us/
s/it's/its/
Windows. With that done, the final step to removing glut is to convert
piglit to use waffle for MacOS.
Current implementation does not have input
) == 0)
prim_restart_index = 0xff;
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 08/07/2014 04:17 PM, Anuj Phogat wrote:
On Tue, Aug 5, 2014 at 3:07 PM, Brian Paul bri...@vmware.com wrote:
---
tests/all.py |1 +
tests/spec/glsl-1.10/execution/CMakeLists.gl.txt |1 +
tests/spec/glsl-1.10/execution/fragdepth.c | 115
not unique.\n);
+free(frequency);
return false;
}
}
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http
On 08/06/2014 07:23 PM, Vinson Lee wrote:
tests is a static array.
Fixes Coverity Array compared against 0 defect.
Signed-off-by: Vinson Lee v...@freedesktop.org
---
.../glsl-1.50/execution/geometry/tri-strip-ordering-with-prim-restart.c | 2 --
1 file changed, 2 deletions(-)
diff --git
);
}
+ if (draw_red_only)
+ glColorMask(GL_TRUE, GL_TRUE, GL_TRUE, GL_TRUE);
+
pass = piglit_probe_rect_halves_equal_rgba(0, 0, window_width,
window_height);
piglit_present_results();
For the series: Reviewed-by: Brian Paul bri...@vmware.com
On 08/07/2014 11:34 AM, Anuj Phogat wrote:
On Wed, Aug 6, 2014 at 5:53 AM, Brian Paul bri...@vmware.com wrote:
On 08/05/2014 08:07 PM, Anuj Phogat wrote:
This test verifies the bug fix in i965 drivers in mesa commit 984a02b.
Reproduces another bug in the driver with GL_DEPTH_COMPONENT16
...
On Fri, Aug 1, 2014 at 11:07 AM, Brian Paul bri...@vmware.com wrote:
Check that we're sampling from the expected array slices.
---
.../render-1darray-1slice.shader_test | 35 +++
.../ext_texture_array/render-1darray.shader_test | 45
);
+ }
+ }
+ piglit_present_results();
+ return pass ? PIGLIT_PASS : PIGLIT_FAIL;
+}
Looks good otherwise.
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org
On 08/05/2014 10:49 AM, Roland Scheidegger wrote:
Am 01.08.2014 17:07, schrieb Brian Paul:
For creating 1D/2D array textures. Each slice of the array is a
solid color (red, green, blue, white, etc.)
---
tests/util/piglit-util-gl.c | 97 ---
tests
OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * Test GLSL gl_FragDepth output.
+ * We draw overlapping red and green quads. The red quad is at Z=0
+ * while the green quad's fragment depths vary from left to right.
+ * Should see intersecting quads.
+ *
+ * Brian Paul
+ * 5 August
For creating 1D/2D array textures. Each slice of the array is a
solid color (red, green, blue, white, etc.)
---
tests/util/piglit-util-gl.c | 97 ---
tests/util/piglit-util-gl.h |1 +
2 files changed, 92 insertions(+), 6 deletions(-)
diff --git
And remove the previous glEnable(GL_TEXTURE_2D_ARRAY) call. It's
never legal.
---
tests/shaders/shader_runner.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 2069fdf..398745f 100644
---
Check that we're sampling from the expected array slices.
---
.../render-1darray-1slice.shader_test | 35 +++
.../ext_texture_array/render-1darray.shader_test | 45
.../render-2darray-1slice.shader_test | 34 +++
The second parameter should be the number of 1D slices, not the 3rd.
As it was, piglit_depth_texture() was only initializing the first
slice's data and not the other slices.
---
tests/shaders/shader_runner.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This was never hit since no callers create 1D mipmapped depth textures.
But fix it anyway.
---
tests/util/piglit-util-gl.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c
index bbea519..caeb564 100644
---
Each slice of the 2D array is a solid color (red, green, blue, white,
etc.)
---
tests/util/piglit-util-gl.c | 79 +++
tests/util/piglit-util-gl.h |1 +
2 files changed, 74 insertions(+), 6 deletions(-)
diff --git a/tests/util/piglit-util-gl.c
And remove the previous glEnable(GL_TEXTURE_2D_ARRAY) call. It's
never legal.
---
tests/shaders/shader_runner.c |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 2069fdf..e4607ae 100644
---
Check that we're sampling from the expected array slices.
---
tests/spec/ext_texture_array/render.shader_test | 44 +++
1 file changed, 44 insertions(+)
create mode 100644 tests/spec/ext_texture_array/render.shader_test
diff --git
print_usage_and_exit(char *prog_name)
{
printf(Usage: %s num_samples blit_type\n
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
Commit 42d2fdf changed the test to use the default window size. But
even before that, the window was too small for common values of
GL_MAX_VERTEX/FRAGMENT/COMBINED_UNIFORM_BLOCKS so we skipped some
testing.
Now use a larger window and call glViewport() so that if we resize
the window we don't
using
+ * glVertexAttribPointer. We test all combinations of GL_INT_2_10_10_10_REV
+ * vs. GL_UNSIGNED_INT_2_10_10_10_REV and 4 vs. GL_BGRA and normalized vs.
+ * unnormalized.
+ *
+ * Authors: Meng-Lin Wu, Brian Paul
+ */
+
+
+#include piglit-util-gl.h
+
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
CountCrossbarCombinations() const;
bool RunCrossbarTest(glmachine machine, BasicResult r, Window w);
- PFNGLACTIVETEXTUREARBPROC p_glActiveTextureARB;
- PFNGLMULTITEXCOORD2FARBPROC p_glMultiTexCoord2fARB;
-
}; // class TexCombineTest
} // namespace GLEAN
Reviewed-by: Brian
/spec/glsl-1.20/compiler/literals/valid-float-suffix-F.vert
create mode 100644
tests/spec/glsl-1.20/compiler/literals/valid-float-suffix-capital-f.vert
Yeah, there's failures in this area on Windows but I never investigated why.
Reviewed-by: Brian Paul bri...@vmware.com
With core profile contexts, all vertex arrays must be in a vertex array object.
This fixes the test with Mesa.
v2: test for core profile instead of gl version
---
.../vertex-attrib-pointer-type-size-match.c |6 ++
1 file changed, 6 insertions(+)
diff --git
On 07/17/2014 12:36 PM, Matt Turner wrote:
On Thu, Jul 17, 2014 at 6:26 AM, Brian Paul bri...@vmware.com wrote:
With GL 3.0 and later, all vertex arrays must be in a vertex array object.
This fixes the test with Mesa.
Isn't it 3.1 (i.e., specifically core profiles) and later
The GLSLParserTest, ShaderTest and GleanTest subclasses of the Test
class were prepending the TEST_BIN_DIR variable onto the executable
name (such as glslparsertest, shader_runner, and glean). But
the Test class itself also does that so we were prepending TEST_BIN_DIR
twice.
With unix paths,
The GLSLParserTest and ShaderTest subclasses of the PiglitTest class
were prepending the TEST_BIN_DIR variable onto the executable name
(such as glslparsertest and shader_runner). But the PiglitTest
class itself also does that so we were prepending TEST_BIN_DIR twice.
With unix paths,
MSVC's strtod() function does not parse inf or -inf so add a
wrapper function to do that. Several generated shader tests use
inf uniforms.
---
tests/shaders/shader_runner.c | 35 +--
1 file changed, 33 insertions(+), 2 deletions(-)
diff --git
On 07/11/2014 04:30 PM, Matthew McClure wrote:
Okay fixed. If approved, I am new to the project and do not have commit access
so I will need help checking this in.
Thanks,
Matthew
LGTM. I'll put my R-b on it and push it soon.
-Brian
___
Piglit
12 is somewhat arbitrary, but it avoids total failure if the max
line width is something large (like 255 in llvmpipe).
---
tests/general/polygon-offset.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/general/polygon-offset.c b/tests/general/polygon-offset.c
index
different than the build and I had to fix a number of issues along these
lines a while back.
That said, this looks OK to me. It's doing basically the same thing as
we do for shader_runner tests.
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit
-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
detection
On 07/09/2014 03:56 PM, Chad Versace wrote:
Now that piglit-dispatch supports every OpenGL API, there is no
longer a need to provide separate implementations for GL and GLES.
This patch is safe for GLES because glGetStringi() is available in
OpenGL ES 3.0.
This patch brings us one
against master 5c1760e on
- Intel Ivybridge
- mesa-10.2.2
- piglit run -p gbm -x glean -x glx tests/quick.py
I did a quick read-through and the series looks good to me.
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
On 07/09/2014 03:10 PM, Matthew McClure wrote:
I reproduced Brian's issue with the NVIDIA drivers. Below is a list of the
configurations I ran:
GeForce GTX 650
* Ubuntu NVIDIA 304.88 - Allocation of Variable[GL_MAX_VARYING_FLOATS]
succeeded, VBO usage succeeds.
* Ubuntu NVIDIA 331.89 -
On 07/07/2014 07:51 AM, Matthew McClure wrote:
With this patch, we add a test that will stress the bound resource limits
as determined by the GL API getInteger values. The bound resources are
populated with floats given a table of primes. Each contribution is
multiplied into the final
The spec for GL_ARB_explicit_attrib_location says it requires OpenGL 2.0
or GL_ARB_vertex_shader and it's written against the OpenGL 3.2 core
spec / GLSL 1.50. The extension spec says nothing about how the
extension would work in GLSL before 1.50.
Note that this extension adds a new layout
On 07/08/2014 11:01 AM, Matthew McClure wrote:
I ran this on Ubuntu 12.04.3 with:
OpenGL vendor string: NVIDIA Corporation
OpenGL renderer string: GeForce GTX 650/PCIe/SSE2
OpenGL version string: 4.2.0 NVIDIA 304.116
OpenGL shading language version string: 4.20 NVIDIA via Cg compiler
OpenGL
, using fetchTexel()
+ * to grab a particular sample. We read back the colors to a temporary image.
+ * Finally, we check that the colors in the temp images are different for at
+ * least some of the pixels/samples.
+ *
+ * Brian Paul
+ * July 2014
+ */
+
+
+#include piglit-util-gl-common.h
Spotted by Meng-Lin Wu.
---
tests/general/clipflat.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/general/clipflat.c b/tests/general/clipflat.c
index 37a40af..03a069c 100644
--- a/tests/general/clipflat.c
+++ b/tests/general/clipflat.c
@@ -295,7 +295,7 @@
On 07/08/2014 04:49 PM, Matthew McClure wrote:
Update to reflect feedback from Brian Paul. The update includes documentation for each
function and removal of the flat qualifier, since this version of the test is
using GLSL 1.30.
Verified on:
Ubuntu 12.04.3
OpenGL vendor string: NVIDIA
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
I'm having trouble with Mako since the requirement bump.
I had an older version of Mako installed. I tried upgrading with sudo
pip install --user --upgrade Mako but that didn't seem to work. Then I
uninstalled Mako and tried installing again. The installation had some
warnings but seems
On 07/07/2014 09:26 AM, Brian Paul wrote:
I'm having trouble with Mako since the requirement bump.
I had an older version of Mako installed. I tried upgrading with sudo
pip install --user --upgrade Mako but that didn't seem to work. Then I
uninstalled Mako and tried installing again
Since the test shaders require GLSL 1.30
---
.../arb_blend_func_extended/execution/fbo-extended-blend-explicit.c |2 +-
tests/spec/arb_blend_func_extended/execution/fbo-extended-blend.c|2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
---
tests/spec/arb_provoking_vertex/xfb-before-flatshading.c |2 --
1 file changed, 2 deletions(-)
diff --git a/tests/spec/arb_provoking_vertex/xfb-before-flatshading.c
b/tests/spec/arb_provoking_vertex/xfb-before-flatshading.c
index 67cc581..6d168ea 100644
---
On 06/30/2014 10:49 AM, Jason Ekstrand wrote:
On Sat, Jun 28, 2014 at 6:28 AM, Brian Paul bri...@vmware.com
mailto:bri...@vmware.com wrote:
On 06/27/2014 05:31 PM, Jason Ekstrand wrote:
This is a simple sanity test for the ARB_copy_image extension.
This tests
]);
+
+ return pass ? PIGLIT_PASS : PIGLIT_FAIL;
+}
Looks good otherwise.
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 06/27/2014 05:31 PM, Jason Ekstrand wrote:
This tests all of the possible different combinations of texture targets
such as GL_TEXTURE_2D, GL_TEXTURE_CUBE_MAP, GL_TEXTURE_1D_ARRAY, etc. The
only targets not tested are GL_TEXTURE_2D_MULTISAMPLE and
GL_TEXTURE_2D_MULTISAMPLE_ARRAY but those
On 06/27/2014 05:31 PM, Jason Ekstrand wrote:
This tests glCopyTexSubImage on all of the allowed combinations of internal
texture formats.
Signed-off-by: Jason Ekstrand jason.ekstr...@intel.com
---
tests/all.py| 77 +++
Instead of spot checking a few internalFormat/format/type combinations
test all of them. And only test the core profile formats. The
ext_texture_integer-errors test hits the other legacy/compat formats.
Remove the tests for glDrawPixels, glReadPixels, etc. since that's
covered in the new
};
For all 6 unused-var-removal patches:
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
For the GLUT framework, check the context version and whether
GL_ARB_compatibility is supported to determine if we should set
piglit_is_core_profile. Fixes some issues when running GL 3.1 and
later on Windows.
---
tests/util/piglit-framework-gl/piglit_glut_framework.c |8
1 file
...@lists.freedesktop.org on behalf of Brian Paul
bri...@vmware.com
Sent: Wednesday, June 25, 2014 8:45 AM
To: piglit@lists.freedesktop.org
Subject: [Piglit] [PATCH] util/framework/glut: check if we have a core profile
For the GLUT framework, check the context version and whether
GL_ARB_compatibility is supported
Even for functions such as glGetStringi() which are in OpenGL 3.0, we
call get_core_proc_address() with gl_10x_version = 10 (seems to be a
larger problem in the dispatch code generation). That means we try
GetProcAddress(OPENGL32.DLL) and fail. Now, if GetProcAddress()
fails, try
Check if actually got a core profile. Then, if the tests requires
a compat profile, skip the test.
---
.../piglit-framework-gl/piglit_glut_framework.c| 22
1 file changed, 22 insertions(+)
diff --git a/tests/util/piglit-framework-gl/piglit_glut_framework.c
GL_MAX_UNIFORM_BLOCK_SIZE is in bytes. A component is regarded as being
four bytes in size. So to compute the number of components, divide the
block size by 4.
With this change, nvidia's driver passes the test.
Found by Kai Ninomiya of VMware.
---
tests/spec/arb_uniform_buffer_object/minmax.c
OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+/**
+ * Test OpenGL 3.0 rendering to integer texture formats.
+ * Brian Paul
+ * 19 June 2014
+ */
+
+#include piglit-util-gl-common.h
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+ config.supports_gl_compat_version = 30;
+ config.window_visual
at this I assumed it was the
glReadPixels(w=2,h=2) that was significant. I'll post a fix-up patch...
-Brian
On 06/08/2014 03:16 PM, Brian Paul wrote:
---
tests/general/pbo-readpixels-small.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/tests/general/pbo-readpixels-small.c
b
This test requires a 2x2 window size- it's not just the glReadPixels(2x2)
that matters.
---
tests/general/pbo-readpixels-small.c |9 +
1 file changed, 9 insertions(+)
diff --git a/tests/general/pbo-readpixels-small.c
b/tests/general/pbo-readpixels-small.c
index 900a929..9f2f338
Reviewed-by: Brian Paul bri...@vmware.com
On Fri, Jun 13, 2014 at 11:03 PM, Vinson Lee v...@freedesktop.org wrote:
Fix clang unused-const-variable warnings.
tests/fbo/fbo-generatemipmap-1d.c:44:20: warning: unused variable 'red'
[-Wunused-const-variable]
static const float red[] = {1, 0
good otherwise.
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
---
tests/spec/gl-3.0/vertexattribipointer.c | 43 +++---
1 file changed, 34 insertions(+), 9 deletions(-)
diff --git a/tests/spec/gl-3.0/vertexattribipointer.c
b/tests/spec/gl-3.0/vertexattribipointer.c
index b69e731..633b881 100644
---
Just to be clear, I think forward slash is / while backward slash is \.
-Brian
On 06/12/2014 06:22 AM, jfons...@vmware.com wrote:
From: José Fonseca jfons...@vmware.com
It's fine for URLs to have forward slash directory separators when viewing
the HTML on Windows. But if one moves the HTML
'] =
concurrent_test('ext_packed_depth_stencil-readdrawpixels')
oes_packed_depth_stencil = {}
spec['OES_packed_depth_stencil'] = oes_packed_depth_stencil
Reviewed-by: Brian Paul bri...@vmware.com
Hmm, I did that but somehow it didn't make it into my patch. Thanks.
-Brian
Add a test that actually draws something with uniform buffer objects
along the lines of what an application might do.
---
tests/all.py |1 +
.../arb_uniform_buffer_object/CMakeLists.gl.txt|1 +
tests/spec/arb_uniform_buffer_object/rendering.c |
Test executable not found.\n)
err =
-returncode = None
+returncode = 0
else:
raise e
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
IN THE SOFTWARE.
-//
-// END_COPYRIGHT
-
-// tdepthstencil.h: Test GL_EXT_packed_depth_stencil extension.
-// Brian Paul 1 October 2005
-
-
-#include cassert
-#include cmath
-#include cstring
-#include tdepthstencil.h
-#include rand.h
-#include image.h
-#include piglit-util-gl-common.h
-
-namespace GLEAN
IN THE SOFTWARE.
-//
-// END_COPYRIGHT
-
-// tbufferobject.c - test various buffer object features/extensions
-// Author: Brian Paul
-
-
-#define GL_GLEXT_PROTOTYPES
-#include cassert
-#include cmath
-#include cstring
-#include stdlib.h
-#include tbufferobject.h
-
-
-namespace GLEAN
.
+ * Based on an original Glean test written by Brian Paul.
+ */
+
+#include piglit-util-gl-common.h
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+ config.supports_gl_compat_version = 12;
+ config.window_visual = (PIGLIT_GL_VISUAL_RGBA |
+ PIGLIT_GL_VISUAL_DEPTH
DEALINGS
+ * IN THE SOFTWARE.
+ */
+
+/**
+ * Test GL_EXT_packed_depth_stencil with glRead/DrawPixels
+ * Based on an original Glean test written by Brian Paul.
+ */
+
+#include piglit-util-gl-common.h
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+ config.supports_gl_compat_version = 12
);
return EXCEPTION_CONTINUE_SEARCH;
}
The series looks OK to me, AFAICT.
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 06/05/2014 09:38 AM, Neil Roberts wrote:
This adds a test for glClearTexSubImage when clearing a sub-region of
a 2D texture using a range of formats that are supported in basic GL.
A utility function is added to test a format combination so that
further tests can be added with other formats
On 06/05/2014 09:38 AM, Neil Roberts wrote:
This adds a test for glClearTexSubImage when clearing a sub-region of
a texture using a range of sized internal formats.
---
tests/all.py | 1 +
tests/spec/arb_clear_texture/CMakeLists.gl.txt | 1 +
On 06/05/2014 09:38 AM, Neil Roberts wrote:
This adds a test for glClearTexSubImage when clearing a sub-region of
textures using an internal format of GL_RED and GL_RG.
---
tests/all.py | 1 +
tests/spec/arb_clear_texture/CMakeLists.gl.txt | 1 +
are then rendered to
the window and probed for the correct results.
---
Overall, the series looks good to me. Just a few nits that I posted.
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http
On 06/05/2014 05:51 AM, Jose Fonseca wrote:
Looks ok. Though I still wonder if it wouldn't be to do as I suggested in another
similar review request -- to treat config.window_width/height as minimum
values, as opposed to maximum values. That is, something along the lines of
diff --git
601 - 700 of 1161 matches
Mail list logo
