Before, the test always drew green rects for all the target buffers.
Now we draw a different color into each buffer to be more thorough.
Plus, replace 16 with MAX_TARGETS, add some comments, etc.
Note: the test now fails with Mesa's swrast because swrast errantly
writes the same color to all
Just some formatting issues on this one and the same for patch 3/4.
On 11/01/2013 04:51 PM, Jon Ashburn wrote:
Tests GL_ARB_viewport_array validity for indices. Use both valid and
invalid parameters (index, first, count) for all these new API entry points:
glDepthRangeArrayv,
with Nvidia Quadro 600. All tests pass except Scissor Box with a
negative height fails to return a gl error.
Reviewed-by: Brian Paul bri...@vmware.com
Signed-off-by: Jon Ashburn j...@lunarg.com
---
tests/all.tests | 1 +
tests/spec/arb_viewport_array
Typos below.
On 11/04/2013 08:15 AM, Jon Ashburn wrote:
Tests rendering into a single framebuffer surface with multiple viewports
via a geometry shader. Scissoring is used to restrict quads to a smaller
area on the surface. Confirm that each area of the surface delineated by
a scissor
This passes w/ Mesa but crashes NVIDIA's driver.
---
.../declarations/bad-variable-redeclaration.frag | 29
1 file changed, 29 insertions(+)
create mode 100644
tests/spec/glsl-1.10/compiler/declarations/bad-variable-redeclaration.frag
diff --git
On 11/02/2013 09:02 PM, Dylan Baker wrote:
Could you add a note about python code?
Just something like: All python code should conform to python's PEP8
standard, using only spaces and no tabs would be great.
Go for it!
-Brian
___
Piglit mailing
I've tried to describe Piglit's coding style and conventions in more
detail. Hopefully, new contributors will read this and it'll save
some some time and effort for the reviewers.
Please feel free to add/update this info.
---
HACKING | 57
+ in the progress of another.);
pass = false;
}
}
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman
Exercises an NVIDIA driver bug.
---
tests/all.tests |1 +
tests/texturing/CMakeLists.gl.txt |1 +
tests/texturing/cubemap-getteximage-pbo.c | 157 +
3 files changed, 159 insertions(+)
create mode 100644
Exercises an NVIDIA driver bug related to glGetTexImage and sRGB
texture views.
---
tests/all.tests|1 +
tests/spec/arb_texture_view/CMakeLists.gl.txt |1 +
tests/spec/arb_texture_view/getteximage-srgb.c | 119
3 files changed,
On 10/28/2013 05:53 PM, Zack Rusin wrote:
Increase the subpixel precision to 8 bits. This requires
changing some of the code to 64 bits to avoid overflows.
Signed-off-by: Zack Rusin za...@vmware.com
---
Reviewed-by: Brian Paul bri...@vmware.com
On 10/28/2013 12:16 PM, Jon Ashburn wrote:
Tests GL_ARB_texture_view rendering with various texture targets.
Creates texture maps with different solid colors for each level or layer
reads the framebuffer to ensure the rendered color is correct.
Tested on Nvidia Quadro 600, all subtests pass.
On 10/29/2013 03:55 PM, Jon Ashburn wrote:
Tests GL_ARB_viewport_array regarding the validity for the indices.
Use both valid and invalid parameters (index, first, count) for these new
API entry points:
glViewportArrayv, glViewportIndexedf, glViewportIndexedfv, glGetFloati_v.
Also test that
On 10/29/2013 03:55 PM, Jon Ashburn wrote:
Tests rendering into a single framebuffer surface with multiple viewports
via a geometry shader. Scissoring is used to restrict quads to a smaller
area on the surface. Confirm that each area of the surface delineated by
a scissor rectangle for
On 10/29/2013 03:55 PM, Jon Ashburn wrote:
Tested GLenums are GL_MAX_VIEWPORT_DIMS, GL_MAX_VIEWPORTS,
GL_VIEWPORT_SUBPIXEL_BITS, GL_VIEWPORT_BOUNDS_RANGE, GL_LAYER_PROVOKING_VERTEX,
GL_VIEWPORT_INDEX_PROVOKING_VERTEX.
Tested on Nvidia Quadro 600, test passes.
---
tests/all.tests
);
+ vpIndexLoc = glGetUniformLocation(program, idx);
+}
With above fixes: Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
],
+ vali[2], vali[3]);
+ }
+ }
+ pass = piglit_check_gl_error(GL_NO_ERROR) pass;
+
+ piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
query does generate
an error).
Reviewed-by: Brian Paul bri...@vmware.com
Tested-by: Brian Paul bri...@vmware.com
NVIDIA's 325.15 driver fails on the error check on line 96, but that
looks like their bug.
Thanks for making all the changes, Carl.
-Brian
On 10/25/2013 10:41 AM, Jon Ashburn wrote:
RE your comment:
+config.window_width = 128;
+config.window_height = 128;
Is 128 special? Can you just go with the defaults? In the past we've
had trouble on Windows when the width is 130 or so pixels. Long story.
128 isn't special
On 10/24/2013 03:49 PM, Jon Ashburn wrote:
Tests texture views with data format changes. 1D textures only.
Uses multiple simultaneous views with different lifetimes and
check results via glGetTexImage().
Tested on Nvidia Quadro 600, all subtests pass.
---
tests/all.tests
Another quick review. Minor things below.
On 10/24/2013 03:49 PM, Jon Ashburn wrote:
Tests GL_ARB_texture_view rendering with various layers and levels.
Creates texture maps with different solid colors for each level or layer,
reads the framebuffer to ensure the rendered color is correct.
In the subject, space after colon.
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
(layers_clamping(), Minlayer range and numlayer clamp);
+
+ pass = piglit_check_gl_error(GL_NO_ERROR) pass;
+ piglit_report_result(pass ? PIGLIT_PASS : PIGLIT_FAIL);
+}
With those changes,
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing
I didn't really study this test, but some things jumped out...
On 10/24/2013 03:49 PM, Jon Ashburn wrote:
Tests GL_ARB_texture_view rendering with various texture targets.
Creates texture maps with different solid colors for each level or layer
reads the framebuffer to ensure the rendered
On 10/18/2013 05:06 PM, Jon Ashburn wrote:
Tests GL_ARB_texture_view and validity of input parameters.
Use both valid and invalid parameters, although mostly invalid
parameters are tested since other tests will use valid parameters.
Only the parameters texture, origtexture, minlevel,
The same formatting nitpicks from patch 1 apply to this patch and #3.
More below.
On 10/18/2013 05:06 PM, Jon Ashburn wrote:
When calling glTextureView() only certain formats are valid based on the format
of the original texture. This tests valid/invalid combinations.
Tested on Nvidia Quadro
On 10/16/2013 05:37 PM, Jon Ashburn wrote:
When calling glTextureView() only certain formats are valid based on the format
of the original texture. This tests valid/invalid combinations.
Tested on Nvidia Quadro 600, all tests pass.
---
tests/all.tests | 1 +
On 10/16/2013 05:37 PM, Jon Ashburn wrote:
The new target supplied with textureView must be compatible with the
original textures target. This tests valid and invalid combinations.
Tested on Nvidia Quadro 600, all tests pass.
---
tests/all.tests | 1 +
On 10/17/2013 12:14 PM, Carl Worth wrote:
It is legal to gen and delete a new object while another object is active.
It is also legal to delete the currently active object.
Ensure that both of these operations can be performed without any error.
---
tests/all.tests
Test error checking for width != height and depth % 6 != 0 for cube arrays.
---
tests/spec/arb_texture_storage/texture-storage.c | 66 ++
1 file changed, 66 insertions(+)
diff --git a/tests/spec/arb_texture_storage/texture-storage.c
silences tests/fbo/fbo-alphatest-formats.c:184:3: warning: format not
a string literal and no format arguments [-Wformat-security]
---
A number of tests are generating this warning. If there's no objection,
I'll clean up the other tests too.
---
tests/fbo/fbo-alphatest-formats.c |6 +++---
silences a bunch of warnings such as:
tests/fbo/fbo-alphatest-formats.c:184:3: warning: format not
a string literal and no format arguments [-Wformat-security]
---
tests/fbo/fbo-alphatest-formats.c|6 +++---
tests/fbo/fbo-blending-formats.c |
---
tests/glean/tshaderapi.cpp |1 +
1 file changed, 1 insertion(+)
diff --git a/tests/glean/tshaderapi.cpp b/tests/glean/tshaderapi.cpp
index 5111c30..fcd6547 100644
--- a/tests/glean/tshaderapi.cpp
+++ b/tests/glean/tshaderapi.cpp
@@ -440,6 +440,7 @@
---
tests/spec/amd_vertex_shader_layer/layered-2d-texture-render.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/spec/amd_vertex_shader_layer/layered-2d-texture-render.c
b/tests/spec/amd_vertex_shader_layer/layered-2d-texture-render.c
index 88a2bfa..71fc249
Anuj,
Your genmipmap-errors test checks if glGenerateMipmaps raises
GL_INVALID_OPERATION for integer and depth/stencil texture formats.
Can you tell me which version of the GL spec or extension describes this?
genmipmap-errors fails with NVIDIA's OpenGL 4.2 since it does not raise
any
The valid_formats[] list includes formats supported either by
GL 3.0 or GL_EXT_texture_float and GL_EXT_texture_rg.
---
tests/spec/arb_internalformat_query/minmax.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/spec/arb_internalformat_query/minmax.c
We obviously should require this extension.
---
tests/spec/ext_texture_array/compressed.c |1 +
1 file changed, 1 insertion(+)
diff --git a/tests/spec/ext_texture_array/compressed.c
b/tests/spec/ext_texture_array/compressed.c
index c964fd7..7f87b62 100644
---
in piglit.
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 08/21/2013 09:44 PM, Ian Romanick wrote:
From: Ian Romanick ian.d.roman...@intel.com
Many of these tests fail on older GPU such as Intel i915 due to the
precision requirement. This is because many GPUs in this class only use
24-bit floats. Many also implement many instructions cheaply
is not too common in piglit.
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
(GL_VERTEX_ARRAY);
}
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 06/07/2013 12:30 PM, Fabian Bieler wrote:
Test that glProgramParameter() triggers the required errors.
The value of GEOMETRY_VERTICES_OUT is limited by the implementation
dependend constants MAX_GEOMETRY_OUTPUT_VERTICES and
MAX_VERTEX_VARYING_COMPONENTS.
From the ARB_geometry_shader4 spec
On May 16, 2013, at 9:28 AM, Eric Anholt e...@anholt.net wrote:
---
tests/all.tests | 2 +
tests/spec/CMakeLists.txt | 1 +
tests/spec/gl-3.2/CMakeLists.gl.txt | 14 +++
tests/spec/gl-3.2/CMakeLists.txt| 1 +
tests/spec/gl-3.2/minmax.c | 177
On 05/08/2013 07:27 PM, Marek Olšák wrote:
On Thu, May 9, 2013 at 1:16 AM, Brian Paulbri...@vmware.com wrote:
BTW, I tried to test this with NVIDIA's driver but it appears that piglit
can't create a GL 3.1 context:
$ bin/gl-3.1-max-samplers -auto
piglit: info: Failed to create GL 3.1 core
a program from optional VS and FS sources,
+ * throwing PIGLIT_FAIL on error.
+ */
+GLint
+piglit_build_simple_program(const char *vs_source, const char *fs_source)
How would you feel about adding a gs_source for geometry shaders too?
Otherwise,
Reviewed-by: Brian Paul bri...@vmware.com
)
/**/
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On 05/05/2013 12:11 AM, Vinson Lee wrote:
The macro 'report' expands to multiple statements. Add braces to nest
all statements in expanded macro within if-statement.
Fixes Nesting level does not match indentation defect reported by
Coverity.
Signed-off-by: Vinson Leev...@freedesktop.org
---
The previous implementation didn't really work too well.
If you tried something like
profile.remove_test(spec/!OpenGL 3.1/primitive-restart-xfb generated)
you'd just get a Python exception and die.
Also, it was painful to remove whole categories of tests, such as
spec/!OpenGL 3.1/.
The new
I'd like to rename tests/all.tests (and the others) to something like
tests/all_tests.py.
The contents of all.tests is Python code so putting the .py suffix on
it makes sense. Then, I'd like to be able to import that code into
another test spec file where I do blacklisting.
For example,
Two new things:
1. Test small mipmap level sizes (width,height=1,2,4)
2. Test NPOT textures
Passes with NVIDIA's driver. Checks for a Mesa bug.
---
tests/texturing/s3tc-errors.c | 104 -
1 files changed, 103 insertions(+), 1 deletions(-)
diff --git
This is pretty trivial, but it's useful for debugging a Mesa display
list optimization.
---
tests/all.tests |1 +
tests/spec/gl-1.0/CMakeLists.gl.txt |1 +
tests/spec/gl-1.0/dlist-shademodel.c | 101 ++
3 files changed, 103
These are some special cases not covered by the beginend-coverage test.
In particular, we do some drawing/probing.
---
tests/all.tests |1 +
tests/spec/gl-1.0/CMakeLists.gl.txt |1 +
tests/spec/gl-1.0/dlist-beginend.c | 358 +++
3
---
tests/spec/gl-1.0/beginend-coverage.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/tests/spec/gl-1.0/beginend-coverage.c
b/tests/spec/gl-1.0/beginend-coverage.c
index 22d0034..1e8dd7d 100644
--- a/tests/spec/gl-1.0/beginend-coverage.c
+++
When Piglit's configured to use GLUT instead of Waffle we don't have
full support for the -fbo option. So in beginend-coverage we now
check if we really have a FBO bound in order to compute the right
fbo_attachment value.
---
tests/spec/gl-1.0/beginend-coverage.c |9 +++--
1 files
= piglit_check_gl_error(GL_NO_ERROR) pass;
+ piglit_present_results();
+ return pass ? PIGLIT_PASS : PIGLIT_FAIL;
+}
Otherwise LGTM.
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http
On 04/19/2013 09:54 PM, Dylan Baker wrote:
I have some concerns with this patch:
1) It has two imports that are not being used: cgi, os (not os.path)
I'll fix that.
2) getopt: I've been trying to get rid of getopt and replace it with
argparse (I have a patch set ready to go to replace the
On 04/19/2013 04:33 AM, Jose Fonseca wrote:
Yes, assuming stderr messages are driver warnings seems a bit pedantic.
We could do the other way around -- have a whitelist of warning regular
expressions that we do known that are worrisome.
Yeah, that's an idea. But I think the only ones that
Normally, if anything unexpected is printed to stderr we report 'warn'
for the test result. The list of expected/allowed stderr message is
found at the end of core.py. It's a PITA to update this list and if
you've temporarily inserted extra debug code in Mesa/gallium it causes
piglit to just
the
+ * results file will have all the pertinant info for the GL driver
+ * that was tested.
+ *
+ * Note that the piglit framework tries to run glxinfo/wglinfo and
+ * put the output in the results file, but sometimes those programs
+ * aren't installed.
+ *
+ * Brian Paul
+ * April 2013
+ */
+
+
+#include
).
+# When multiple result files are specified, compare the results
+# of each test run to look for differences/regressions.
+#
+# Brian Paul
+# April 2013
+
+
+from getopt import getopt, GetoptError
+import cgi
+import os, os.path
+import sys
+import string
+
+sys.path.append(os.path.dirname
On 04/17/2013 03:48 AM, Kenneth Graunke wrote:
Does anyone object to porting to Python 3.x (and dropping 2.x support)?
Some useful data points:
- Debian stable has 3.1, testing/unstable have 3.2
- Fedora 18 and Arch Linux have 3.3
- Windows installers for 3.3 are available on python.org
- Mac
On 04/06/2013 03:21 AM, Jose Fonseca wrote:
Brian,
Series looks alright, but it looks to me this is a pervasive issue, and not
just a few isolated cases:
piglit $ git grep config.window_width | wc -l
461
So I wonder if there isn't a more definite solution. For example, could we
simply
---
tests/spec/arb_sampler_objects/framebufferblit.c |2 --
tests/spec/arb_sampler_objects/srgb-decode.c |2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/tests/spec/arb_sampler_objects/framebufferblit.c
b/tests/spec/arb_sampler_objects/framebufferblit.c
index
---
.../bindattriblocation-scratch-name.c |2 --
tests/spec/arb_shader_objects/clear-with-deleted.c |2 --
tests/spec/arb_shader_objects/delete-repeat.c |2 --
.../arb_shader_objects/getactiveuniform-beginend.c |2 --
tests/spec/arb_shader_objects/getuniform.c
---
.../framebuffer-blit-levels.c |2 --
.../get-renderbuffer-internalformat.c |2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/tests/spec/arb_framebuffer_object/framebuffer-blit-levels.c
---
.../elements-negative-offset.c |2 --
.../mixed-immediate-and-vbo.c |2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/tests/spec/arb_vertex_buffer_object/elements-negative-offset.c
---
tests/spec/gl-1.0/edgeflag-quads.c |2 --
tests/spec/gl-1.0/edgeflag.c |2 --
2 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/tests/spec/gl-1.0/edgeflag-quads.c
b/tests/spec/gl-1.0/edgeflag-quads.c
index 12ad289..702513d 100644
---
---
tests/general/draw-pixels.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/tests/general/draw-pixels.c b/tests/general/draw-pixels.c
index 383f335..0506ead 100644
--- a/tests/general/draw-pixels.c
+++ b/tests/general/draw-pixels.c
@@ -871,6 +871,10 @@
As it was, many of the generated / expected pixel values were all
zeros. Use better values that actually fit in the given datatype.
For example, we were trying to store 0x23 (6 - j) in a GLbyte.
---
tests/general/draw-pixels.c | 36 +++-
1 files changed, 7
And set the pixel unpack alignment to 1 so that we don't fail if
the window width isn't a multiple of four.
---
tests/general/draw-pixels.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/general/draw-pixels.c b/tests/general/draw-pixels.c
index 26fd121..33a1eb0
;
+}
It looks like you're building a complete mipmap but only testing the
0th mipmap level. Could you hit those other levels by drawing some
smaller quads?
Otherwise looks good. Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit
in addition to the counter-clockwise triangles.
Plus minor clean-ups.
---
tests/general/provoking-vertex.c | 58 +++--
1 files changed, 42 insertions(+), 16 deletions(-)
diff --git a/tests/general/provoking-vertex.c b/tests/general/provoking-vertex.c
index
I happened to find a bug in NVIDIA's driver with indirect GLX rendering.
I was going to write a piglit test for it but found that we have no
way to request an indirect GLX context in piglit.
We could either:
1. add a PIGLIT_GL_VISUAL_INDIRECT bit/flag
2. add a bol
On 03/26/2013 11:13 AM, Marek Olšák wrote:
Hi,
would anyone like to comment on this? Or is it still stuck in the
moderation queue?
I can't find the patch you're referring to. Repost?
-Brian
___
Piglit mailing list
Piglit@lists.freedesktop.org
If a window is redrawn while minimized we were emitting an invalid
size when doing SwapBuffers. With the VMware SVGA driver it meant we
were emitting invalid dimensions for the SurfaceCopy command.
--
I've been running with this patch for a few days and haven't seen
any regressions. Tested in
Looks OK to me but you might want to wait for other feedback.
Reviewed-by: Brian Paul bri...@vmware.com
On 03/27/2013 05:00 PM, Marek Olšák wrote:
The patch seems to be too large for a mailing list. It's here:
http://cgit.freedesktop.org/~mareko/piglit/commit/?id
Some of the ES tests check for this error code. If the installed
glxproto.h file isn't new enough this symbol may be missing and
compilation will fail.
---
tests/util/piglit-glx-util.c |4
tests/util/piglit-glx-util.h |4
2 files changed, 4 insertions(+), 4 deletions(-)
diff
On 03/20/2013 02:11 AM, Rico Schüller wrote:
Hi,
this patch disables the print_float function, which is only used in
the already disabled main function.
Cheers
Rico
---
Thanks. I'll push these patches soon, after cleaning up the commit
messages a bit.
-Brian
On 03/19/2013 05:14 AM, Jose Fonseca wrote:
Series looks good to me.
Reviewed-by: Jose Fonsecajfons...@vmware.com
Thanks. BTW, I'm fixing my tabs vs. spaces indentation errors before
committing.
-Brian
___
Piglit mailing list
On 03/19/2013 03:04 AM, Rico Schüller wrote:
---
tests/glx/glx-query-drawable.c | 1 -
1 file changed, 1 deletion(-)
Pushed. Thanks.
-Brian
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
NVIDIA's later GPUs/drivers report 192 combined texture units.
This causes us to read outside the too-small arrays and segfault.
Increase the array sizes and add a check for the future.
---
tests/general/texunits.c | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff
Use piglit_check_gl_error().
---
tests/general/texunits.c | 46 ++
1 files changed, 14 insertions(+), 32 deletions(-)
diff --git a/tests/general/texunits.c b/tests/general/texunits.c
index e419bde..6eca7b5 100644
--- a/tests/general/texunits.c
+++
Use piglit_check_gl_error(). Note: we're getting an INVALID_OPERATION
error from glBlitFramebuffer() with NVIDIA's driver. That'll be
investigated/fixed separately. At least the test now reports FAIL
instead of dying on an assertion.
---
tests/fbo/fbo-clear-formats.c | 19 +++
.
+
+ glDeleteTextures(3, tex);
+
+ piglit_report_result(PIGLIT_PASS);
+ return 0;
+}
+
+void
+piglit_init(int argc, char **argv)
+{
+#if defined(PIGLIT_USE_OPENGL)
+ piglit_require_extension(GL_ARB_texture_view);
+#endif
+}
Looks good otherwise.
Reviewed-by: Brian Paul bri...@vmware.com
On 03/05/2013 11:03 AM, Roland Scheidegger wrote:
Am 05.03.2013 17:05, schrieb Brian Paul:
On 03/05/2013 08:37 AM, srol...@vmware.com wrote:
From: Roland Scheideggersrol...@vmware.com
This is pretty rough and doesn't really test all that much (just
textureOffsetLod, but there's other
Clear the large FBO to a non-black color and probe for it in the
final test.
This uncovers a bug in Mesa's llvmpipe driver where we ran out of
bin commmand memory and skipped some tiles, leaving them black.
Setting the clear color to white (and actually clearing the FBO)
helps to detect that.
;
+ case GL_TRIANGLE_STRIP:
+ return GL_TRIANGLE_STRIP;
+ case GL_TRIANGLE_FAN:
+ return GL_TRIANGLE_FAN;
+ default:
+ return (unrecognized enum);
+ }
+}
Reviewed-by: Brian Paul bri...@vmware.com
---
tests/util/piglit-util-gl-common.h | 12 ++
tests/util/piglit-util-gl-enum.c | 41
2 files changed, 53 insertions(+), 0 deletions(-)
diff --git a/tests/util/piglit-util-gl-common.h
b/tests/util/piglit-util-gl-common.h
index 336953d..accf1f3
---
tests/general/longprim.c | 16 ++--
1 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/tests/general/longprim.c b/tests/general/longprim.c
index f5a0bd7..b4344f2 100644
--- a/tests/general/longprim.c
+++ b/tests/general/longprim.c
@@ -54,19 +54,6 @@ static const
---
tests/shaders/shader_runner.c | 22 --
1 files changed, 4 insertions(+), 18 deletions(-)
diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c
index 0ae9e0c..582c85c 100644
--- a/tests/shaders/shader_runner.c
+++ b/tests/shaders/shader_runner.c
@@
in Mesa.
+ *
+ * Brian Paul
+ * Feb 2013
+ */
+
+
+#include piglit-util-gl-common.h
+
+PIGLIT_GL_TEST_CONFIG_BEGIN
+ config.supports_gl_compat_version = 10;
+ config.window_visual = PIGLIT_GL_VISUAL_RGB | PIGLIT_GL_VISUAL_DOUBLE;
+PIGLIT_GL_TEST_CONFIG_END
+
+
+/**
+ * Test a specific
OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ *
+ */
+
+
+/**
+ * Test glPolygonMode + glPolygonOffset.
+ *
+ * Brian Paul
+ * Feb 2013
+ */
+
+
+#include piglit-util-gl-common.h
.
Reviewed-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ *
+ */
+
+
+/**
+ * Test drawing primitives with too few vertices. In particular,
+ * GL_QUADS and GL_QUAD_STRIP with 3 verts seems to regress every
+ * once in a while in Mesa.
+ *
+ * Brian Paul
+ * Feb 2013
Replaced by new piglit scissor-polygon test.
---
tests/all.tests |1 -
tests/glean/CMakeLists.gl.txt |1 -
tests/glean/tscissor.cpp | 180 -
tests/glean/tscissor.h| 52
4 files changed, 0 insertions(+), 234
On 02/07/2013 10:45 PM, Tom Gall wrote:
This ported test goes into tests/spec/arb_texture_rectangle. It
tests the ARB_texture_rectangle extension.
Create a 255x127 texture of varying colors and bind it as a
GL_ARB_texture_recangle target. Draw that rectangle to the window, and
check that the
LGTM. Are you asking for another review or do you need someone to
commit/push it for you?
-Brian
On 02/06/2013 03:38 PM, Tom Gall wrote:
It was a little over two weeks ago when v2 of these 2 patches to port
ttexrect to piglit and remove it from glean were posted.
It has a Reviewed-by: Brian
-by: Brian Paul bri...@vmware.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
OK, I thought you had git-write ability. I'll commit/push soon.
-Brian
On 02/07/2013 08:23 AM, Tom Gall wrote:
Hi Brian,
It has your reviewed by.
Ideally I was looking for it to be committed unless of course there's
something egregious about it that we both missed.
On Thu, Feb 7, 2013 at
On 02/07/2013 08:35 AM, Brian Paul wrote:
OK, I thought you had git-write ability. I'll commit/push soon.
Actually, I found a few more issues with the code.
The piglit_swap_buffers() call should be moved after the probing code.
And you should use piglit_present_results() instead. After
901 - 1000 of 1161 matches
Mail list logo
