Re: Review Request: icon-less popupapplets and popupappletified clock

2008-09-12 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/182/#review188 --- Ship it! Code looks good to me. After the naming change

Re: plasma design online

2008-09-12 Thread Richard Moore
On 9/11/08, Riccardo Iaconelli [EMAIL PROTECTED] wrote: On Thursday 11 September 2008 20:25:04 Alex Merry wrote: All the files are currently empty. Sorry, I had a little bug in the update script, try now. =) They still seem to be empty. Rich. ___

Re: AppletScript configAccepted

2008-09-12 Thread Petri Damstén
On Thursday 11 September 2008 19:27:06 Petri Damstén wrote: Diff attached is very much work in progress, but it's a start. More features added, still have problems with background. Background was hidden under the webpage. Now it shows but it also shows in dashboard applet and I also cannot

Re: AppletScript configAccepted

2008-09-12 Thread Aaron J. Seigo
On Friday 12 September 2008, Petri Damstén wrote: On Thursday 11 September 2008 19:27:06 Petri Damstén wrote: Diff attached is very much work in progress, but it's a start. More features added, still have problems with background. Background was hidden under the webpage. =) Now it shows

Re: Review Request: [MOCKUP] Clock: remove Use local time zone

2008-09-12 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/186/#review191 --- Ship it! i like it much better with the box on top.. nice work.

Re: power management settings mockup

2008-09-12 Thread Aaron J. Seigo
On Friday 12 September 2008, Sebastian Kügler wrote: and code duplication. http://reviewboard.vidsolbach.de/r/182/ -- I hope this gets in quickly (hint hint hint). heh; yes, this should go in you already marked it as Ship It! after all. The configuration dialog should make it easy to -

Re: Review Request: icon-less popupapplets and popupappletified clock

2008-09-12 Thread Rob Scheepmaker
On Friday 12 September 2008 16:12:09 Marco Martin wrote: digital and analog clock, popup actually works now ;) still one issue: when is on desktop it seems the whole dialog is not a window but seems to become a proxywidget, even if dialog doesn't have the applet as parent, really don't

Re: Review Request: icon-less popupapplets and popupappletified clock

2008-09-12 Thread Sebastian Kügler
On Friday 12 September 2008 16:55:14 Aaron J. Seigo wrote: +setIcon(QIcon()); then you need to set up your applet properly yourself. try moving the resize(128, 128) to after the setIcon call. That seems to be it, thanks! :) (Now on to finding out why the popup doesn't show up :) --

Re: power management settings mockup

2008-09-12 Thread Sebastian Kügler
On Friday 12 September 2008 17:29:31 Celeste Lyn Paul wrote: Hi Sebas, here are some quick thoughts: thanks, see comment below. Battery charge level: needs a colon at the end Battery charge level label should be sentence case System performance profile label should be sentence case. Aye,

Re: Review Request: Plasma::Dialog resizeRegion() added

2008-09-12 Thread Alessandro Diaferia
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/181/ --- (Updated 2008-09-12 09:27:19.952770) Review request for Plasma. Summary

Re: power management settings mockup

2008-09-12 Thread Sebastian Kügler
On Friday 12 September 2008 18:09:59 Guillaume Pothier wrote: 2008/9/12 Sebastian Kügler [EMAIL PROTECTED]: The configuration dialog should make it easy to - know about battery charge level and performance profile - dim / undim display (*1) It would be nice to also be able to adjust the

Re: power management settings mockup

2008-09-12 Thread Aaron J. Seigo
On Friday 12 September 2008, Guillaume Pothier wrote: 2008/9/12 Sebastian Kügler [EMAIL PROTECTED]: The configuration dialog should make it easy to - know about battery charge level and performance profile - dim / undim display (*1) It would be nice to also be able to adjust the display

Re: power management settings mockup

2008-09-12 Thread Chani
* Inhibit suspend after idle time is pretty complex. how about reversing the logic with Suspend automatically when idle? As I said, the inhibit is temporary. The Suspend automatically sounds like a permanent setting to me. Maybe Do not suspend automatically (overriding the suspend

Re: power management settings mockup

2008-09-12 Thread Celeste Lyn Paul
On Friday 12 September 2008 13:11:43 Aaron J. Seigo wrote: On Friday 12 September 2008, Chani wrote: * Inhibit suspend after idle time is pretty complex. h darn, that png won't display on my n810. dunno why. how many clicks would it take to switch power profiles? :) that's something

Re: power management settings mockup

2008-09-12 Thread Aaron J. Seigo
On Friday 12 September 2008, Celeste Lyn Paul wrote: On Friday 12 September 2008 13:11:43 Aaron J. Seigo wrote: thoughts? (seele) Plasma popup and window dialog, correct? right, that would be the difference. popups don't appear as their own window to the user, but get the plasma frame

Re: power management settings mockup

2008-09-12 Thread Celeste Lyn Paul
On Friday 12 September 2008 14:41:26 Celeste Lyn Paul wrote: On Friday 12 September 2008 14:31:24 Chani wrote: On 9/12/08, Celeste Lyn Paul [EMAIL PROTECTED] wrote: On Friday 12 September 2008 13:11:43 Aaron J. Seigo wrote: hm... here's a thought: * all popups should be

Re: power management settings mockup

2008-09-12 Thread Sebastian Kügler
(Yes, for the popup, I had instant apply in mind) On Friday 12 September 2008 20:26:20 Aaron J. Seigo wrote: All instant apply dialogs must have an Undo/Revert function so you will still have a button somewhere. hm.. that's an added requirement we have no infrastructure for ... i'll have

Re: power management settings mockup

2008-09-12 Thread Aaron J. Seigo
On Friday 12 September 2008, Sebastian Kügler wrote: (I'm on the list, CC:ing me not necessary, it confuses my filtering ...) On Friday 12 September 2008 19:21:58 Riccardo Iaconelli wrote: On Friday 12 September 2008 18:35:37 Sebastian Kügler wrote: Nice :) It's only a mockup. I want to