Notes for SLC BoF

2014-09-11 Thread Marco Martin
main points of the discussion this morning about Share Like Connect (went a bit in KActivityManager land) https://notes.kde.org/p/SLC_bof_2014 * SLC will use KWin * the information of the current document/url will be sent to kwin, is the only one that * who can know the current active window *

Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/ --- Review request for Plasma. Repository: plasma-desktop Description

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/#review66226 --- Ship it! Woo, I like patches with lots of red :) Looks good

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/#review66227 --- Kai, Martin. What's the status of this? Might be good to work

Re: Review Request 119274: Use Atlas textures in SvgItem

2014-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119274/ --- (Updated Sept. 11, 2014, 11:45 a.m.) Status -- This change has been

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/#review66228 --- Should be good, tough is better to put screenshot in the

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Kai Uwe Broulik
On Sept. 11, 2014, 11:47 vorm., Marco Martin wrote: Should be good, tough is better to put screenshot in the review request if the patch is about visual changes I would have if the internet weren't that slow... On Sept. 11, 2014, 11:47 vorm., Marco Martin wrote:

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-11 Thread Martin Klapetek
On Sept. 11, 2014, 1:45 p.m., David Edmundson wrote: Kai, Martin. What's the status of this? Might be good to work it out whilst you're both here. It's ready, waiting for Ship it. - Martin --- This is an automatically generated

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Marco Martin
On Sept. 11, 2014, 11:47 a.m., Marco Martin wrote: Should be good, tough is better to put screenshot in the review request if the patch is about visual changes Kai Uwe Broulik wrote: I would have if the internet weren't that slow... right :) so yeah, ship it - Marco

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Sebastian Kügler
On Sept. 11, 2014, 11:47 a.m., Marco Martin wrote: desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 https://git.reviewboard.kde.org/r/120141/diff/1/?file=311519#file311519line75 this may pose a performance problem, don't bind things to properties that

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-11 Thread David Edmundson
On Sept. 11, 2014, 11:45 a.m., David Edmundson wrote: Kai, Martin. What's the status of this? Might be good to work it out whilst you're both here. Martin Klapetek wrote: It's ready, waiting for Ship it. Ship it! - David

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/ --- (Updated Sept. 11, 2014, 12:56 p.m.) Status -- This change has been

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Marco Martin
On Sept. 11, 2014, 11:47 a.m., Marco Martin wrote: desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 https://git.reviewboard.kde.org/r/120141/diff/1/?file=311519#file311519line75 this may pose a performance problem, don't bind things to properties that

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Kai Uwe Broulik
On Sept. 11, 2014, 11:47 vorm., Marco Martin wrote: desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 https://git.reviewboard.kde.org/r/120141/diff/1/?file=311519#file311519line75 this may pose a performance problem, don't bind things to properties that

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread David Edmundson
On Sept. 11, 2014, 11:47 a.m., Marco Martin wrote: desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 https://git.reviewboard.kde.org/r/120141/diff/1/?file=311519#file311519line75 this may pose a performance problem, don't bind things to properties that

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Kai Uwe Broulik
On Sept. 11, 2014, 11:47 vorm., Marco Martin wrote: desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 75 https://git.reviewboard.kde.org/r/120141/diff/1/?file=311519#file311519line75 this may pose a performance problem, don't bind things to properties that

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/#review66247 --- Ship it! And then we need to fix the horrible Free Space

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-11 Thread Martin Klapetek
On Sept. 11, 2014, 3:08 p.m., Kai Uwe Broulik wrote: And then we need to fix the horrible Free Space Notifier notification ;) http://quickgit.kde.org/?p=plasma-workspace.gita=commitdiffh=66c83af0baaf018947bb5e4edadd28ed4cb45e27 ;) - Martin

Re: Review Request 120036: Note loading in Notes Plasmoid

2014-09-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120036/#review66248 --- Ship it! Some minor nitpicks below. Thanks!

Re: Review Request 120130: to prevent a compiler error

2014-09-11 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120130/ --- (Updated Sept. 11, 2014, 3:45 p.m.) Review request for Plasma, Daniel

Re: Review Request 120130: to prevent a compiler error

2014-09-11 Thread Jan Grulich
On Zář. 11, 2014, 1:55 odp., Kevin Krammer wrote: Ship It! Push it to all branches please, which means master, Plasma/5.0 and 0.9.3. Thanks. - Jan --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 120130: to prevent a compiler error

2014-09-11 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120130/ --- (Updated Sept. 11, 2014, 2:44 p.m.) Status -- This change has been

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120141/#review66282 --- I'm sorry to reopen, but my clock config dialog now looks

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Eike Hein
On Sept. 11, 2014, 4:36 p.m., Eike Hein wrote: I'm sorry to reopen, but my clock config dialog now looks like this: ![Screenshot](http://wstaw.org/m/2014/09/11/clock.png) What gives? :) Hmm I also don't really like how different from KConfigDialog this still is ... color scheme,

Re: Review Request 120141: Cleanup Applet Configuration sidebar

2014-09-11 Thread Kai Uwe Broulik
On Sept. 11, 2014, 4:36 nachm., Eike Hein wrote: I'm sorry to reopen, but my clock config dialog now looks like this: ![Screenshot](http://wstaw.org/m/2014/09/11/clock.png) What gives? :) Eike Hein wrote: Hmm I also don't really like how different from KConfigDialog this

[Breeze] [Bug 158379] Draw focus rect in Kate Part instead of Widget Style (Oxygen)

2014-09-11 Thread Hugo Pereira Da Costa
https://bugs.kde.org/show_bug.cgi?id=158379 --- Comment #11 from Hugo Pereira Da Costa hugo.pere...@free.fr --- Git commit c71ed504dad4f92979e905067b22cafc015b8afd by Hugo Pereira Da Costa. Committed on 11/09/2014 at 21:18. Pushed by hpereiradacosta into branch 'master'. - Use QGridLayout for

New Review Tools Trial

2014-09-11 Thread David Edmundson
Hey all. Plasma-framework is taking part in a trial of using gerrit for reviews. See https://techbase.kde.org/Development/Gerrit *How will this affect you*: - If you review frameworks patches you may need to also check another tool - Currently gerrit does not email plasma-devel, I hope to get

Review Request 120151: Cleanups in Host::categories (applets/systemtray)

2014-09-11 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120151/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 120151: Cleanups in Host::categories (applets/systemtray)

2014-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120151/#review66301 --- applets/systemtray/plugin/host.cpp

Re: Kioslave repos

2014-09-11 Thread David Faure
On Wednesday 20 August 2014 11:38:12 Jonathan Riddell wrote: On Wed, Aug 20, 2014 at 12:28:30PM +0200, Aleix Pol wrote: On Tue, Aug 19, 2014 at 9:49 PM, David Faure fa...@kde.org wrote: On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: On Tue, Jul 01, 2014 at 11:25:11PM