Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-11 Thread Martin Gräßlin
On Feb. 11, 2015, 5:14 nachm., Andrew Lake wrote: It might be worth investigating the use-case a bit further to try to understand if this is the best way to solve this. Is it useful? Yes. But there are potentiall negative impacts that should be balanced against the relative increase

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-11 Thread Aleix Pol Gonzalez
On Feb. 11, 2015, 5:14 p.m., Andrew Lake wrote: It might be worth investigating the use-case a bit further to try to understand if this is the best way to solve this. Is it useful? Yes. But there are potentiall negative impacts that should be balanced against the relative increase in

Re: Review Request 122524: Port to KPackage and away from sycoca

2015-02-11 Thread Marco Martin
On Feb. 11, 2015, 2:25 p.m., Sebastian Kügler wrote: components/shellprivate/widgetexplorer/widgetexplorer.cpp, line 33 https://git.reviewboard.kde.org/r/122524/diff/1/?file=348257#file348257line33 Is this still needed? Marco Martin wrote: right, widgetsMenuActions() is

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-11 Thread Andrew Lake
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122522/#review75870 --- It might be worth investigating the use-case a bit further to

Re: Review Request 122331: Add libinput support to kcm-touchpad

2015-02-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/#review75871 --- I tried testing the change. I added some debug into

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-11 Thread Marco Martin
On Feb. 11, 2015, 4:14 p.m., Andrew Lake wrote: It might be worth investigating the use-case a bit further to try to understand if this is the best way to solve this. Is it useful? Yes. But there are potentiall negative impacts that should be balanced against the relative increase in

Build failed in Jenkins: plasma-workspace_master_qt5 #1307

2015-02-11 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/1307/changes Changes: [notmart] port package structures to KPackage [notmart] start porting the widget explorer to KPackage [notmart] port image wallpaper to KPackage [notmart] port plasmashell to KPackage [notmart] port plasmawindowed

Re: Review Request 122524: Port to KPackage and away from sycoca

2015-02-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122524/ --- (Updated Feb. 11, 2015, 5:01 p.m.) Status -- This change has been

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-11 Thread Kai Uwe Broulik
On Feb. 10, 2015, 1:29 nachm., David Edmundson wrote: I'm not convinced this is right. From the doc you linked: This is necessary for the system to implement auto-suspend when all sessions are idle. When we lock the screen, powerdevil is still running, no? Powerdevil

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-11 Thread Martin Gräßlin
On Feb. 11, 2015, 2:43 nachm., Sebastian Kügler wrote: What's the use case this satisfies? Aleix Pol Gonzalez wrote: See the attached bug report. This used to be present IIRC in the old xscreensaver based greeter. The use case is simple: e.g. distinguishing a system in a computer

Review Request 122528: [screenlocker] Grab XServer while establishing the grab

2015-02-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122528/ --- Review request for Plasma. Repository: plasma-workspace Description

Build failed in Jenkins: plasma-desktop_stable_qt5 #68

2015-02-11 Thread KDE CI System
See http://build.kde.org/job/plasma-desktop_stable_qt5/68/changes Changes: [jr] add subdirectories optionally for documentation because translations may be incomplete -- [...truncated 36 lines...] KDE Continuous Integration Build == Building Project:

Build failed in Jenkins: plasma-desktop_master_qt5 #993

2015-02-11 Thread KDE CI System
See http://build.kde.org/job/plasma-desktop_master_qt5/993/changes Changes: [jr] add subdirectories optionally for documentation because translations may be incomplete -- [...truncated 37 lines...] KDE Continuous Integration Build == Building Project:

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-11 Thread Martin Gräßlin
On Feb. 11, 2015, 2:43 nachm., Sebastian Kügler wrote: What's the use case this satisfies? Aleix Pol Gonzalez wrote: See the attached bug report. Martin Gräßlin wrote: This used to be present IIRC in the old xscreensaver based greeter. The use case is simple: e.g.

Re: Review Request 122524: Port to KPackage and away from sycoca

2015-02-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122524/#review75858 --- Ship it! A few const issues, and one possible crasher.

Re: Review Request 122524: Port to KPackage and away from sycoca

2015-02-11 Thread Marco Martin
On Feb. 11, 2015, 2:25 p.m., Sebastian Kügler wrote: components/shellprivate/widgetexplorer/widgetexplorer.cpp, line 33 https://git.reviewboard.kde.org/r/122524/diff/1/?file=348257#file348257line33 Is this still needed? right, widgetsMenuActions() is still not really ported, still

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122522/ --- (Updated Feb. 11, 2015, 2:59 nachm.) Review request for Plasma and

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-11 Thread Aleix Pol Gonzalez
On Feb. 11, 2015, 2:43 p.m., Sebastian Kügler wrote: What's the use case this satisfies? Aleix Pol Gonzalez wrote: See the attached bug report. Martin Gräßlin wrote: This used to be present IIRC in the old xscreensaver based greeter. The use case is simple: e.g.

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-11 Thread Sebastian Kügler
On Feb. 11, 2015, 1:43 p.m., Sebastian Kügler wrote: What's the use case this satisfies? Aleix Pol Gonzalez wrote: See the attached bug report. Martin Gräßlin wrote: This used to be present IIRC in the old xscreensaver based greeter. The use case is simple: e.g.

Jenkins build is back to normal : plasma-desktop_stable_qt5 #69

2015-02-11 Thread KDE CI System
See http://build.kde.org/job/plasma-desktop_stable_qt5/69/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

2015-02-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122400/ --- (Updated Feb. 11, 2015, 2:51 p.m.) Review request for Plasma. Changes

Re: Review Request 122331: Add libinput support to kcm-touchpad

2015-02-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/#review75869 --- +1 from me. - David Edmundson On Jan. 30, 2015, 7:41 p.m.,

Change in plasma-framework[master]: Port to kpackage::package

2015-02-11 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/367 Change subject: Port to kpackage::package .. Port to kpackage::package Change-Id: Id52b8d6bf76ab964c02cec9f0bba1dcdf3950d76 --- M

Re: Review Request 122524: Port to KPackage and away from sycoca

2015-02-11 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122524/#review75856 --- Two things broken, - no wallpaper plugin listing - can not

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

2015-02-11 Thread David Edmundson
On Feb. 10, 2015, 7:51 p.m., Xuetian Weng wrote: kcms/dateandtime/main.cpp, line 146 https://git.reviewboard.kde.org/r/122400/diff/5/?file=348191#file348191line146 This part can be async. You can do it by chain two different callback if it need to be done one after

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Thomas Pfeiffer
On Feb. 10, 2015, 9:01 a.m., Mark Gaiser wrote: I'm not quite sure if a user wants to see a warning message at all. When i use my notebook in a dark environment i usually put the brightness all the way down (depending on the notebook). Kai Uwe Broulik wrote: As I stated above,

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Thomas Pfeiffer
On Feb. 10, 2015, 11:50 p.m., Thomas Pfeiffer wrote: Basic rule from design for safety: Don't use a warning if you can prevent the dangerous action completely. In this case that means: Setting the brightness to zero should only be possible via keyboard, because that ensures

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Martin Klapetek
On Feb. 11, 2015, 12:50 a.m., Thomas Pfeiffer wrote: Basic rule from design for safety: Don't use a warning if you can prevent the dangerous action completely. In this case that means: Setting the brightness to zero should only be possible via keyboard, because that ensures

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

2015-02-11 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122533/ --- (Updated Feb. 11, 2015, 9:25 p.m.) Review request for Plasma. Changes

Re: theme mixing

2015-02-11 Thread Jens Reuterberg
Well there was talk about some easy way to edit colors and spacing of individual SVG-files (I mean it IS reaaally complex to edit themes)... Might be worth looking into? Pedro: I can only suggest that you try to edit them in Karbon instead of Inkscape since it contains a better sorting of

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Ken Vermette
On Feb. 10, 2015, 9:01 a.m., Mark Gaiser wrote: I'm not quite sure if a user wants to see a warning message at all. When i use my notebook in a dark environment i usually put the brightness all the way down (depending on the notebook). Kai Uwe Broulik wrote: As I stated above,

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Kai Uwe Broulik
On Feb. 10, 2015, 9:01 vorm., Mark Gaiser wrote: I'm not quite sure if a user wants to see a warning message at all. When i use my notebook in a dark environment i usually put the brightness all the way down (depending on the notebook). Kai Uwe Broulik wrote: As I stated above,

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Thomas Pfeiffer
On Feb. 10, 2015, 11:50 p.m., Thomas Pfeiffer wrote: Basic rule from design for safety: Don't use a warning if you can prevent the dangerous action completely. In this case that means: Setting the brightness to zero should only be possible via keyboard, because that ensures

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

2015-02-11 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122533/ --- (Updated Feb. 11, 2015, 9:24 p.m.) Review request for Plasma. Changes

Re: Review Request 122331: Add libinput support to kcm-touchpad

2015-02-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122331/#review75896 --- Ship it! Built my X with libinput support. Without this

Change in plasma-framework[master]: Put all non tiled frame textures in the atlas

2015-02-11 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/370 Change subject: Put all non tiled frame textures in the atlas .. Put all non tiled frame textures in the atlas Change-Id:

Review Request 122540: Add screen reader to Accessibility KCM

2015-02-11 Thread Frederik Gladhorn
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122540/ --- Review request for Plasma, Jonathan Riddell, Sebastian Sauer, and Jeremy

Re: Review Request 122510: [screenlocker] Mark session as idle in logind while screen is locked

2015-02-11 Thread Martin Gräßlin
On Feb. 10, 2015, 2:29 p.m., David Edmundson wrote: I'm not convinced this is right. From the doc you linked: This is necessary for the system to implement auto-suspend when all sessions are idle. When we lock the screen, powerdevil is still running, no? Powerdevil has

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Emmanuel Pescosta
On Feb. 10, 2015, 10:01 a.m., Mark Gaiser wrote: I'm not quite sure if a user wants to see a warning message at all. When i use my notebook in a dark environment i usually put the brightness all the way down (depending on the notebook). Kai Uwe Broulik wrote: As I stated above,

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Martin Klapetek
On Feb. 11, 2015, 12:50 a.m., Thomas Pfeiffer wrote: Basic rule from design for safety: Don't use a warning if you can prevent the dangerous action completely. In this case that means: Setting the brightness to zero should only be possible via keyboard, because that ensures

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Emmanuel Pescosta
On Feb. 11, 2015, 12:50 a.m., Thomas Pfeiffer wrote: Basic rule from design for safety: Don't use a warning if you can prevent the dangerous action completely. In this case that means: Setting the brightness to zero should only be possible via keyboard, because that ensures

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Martin Klapetek
On Feb. 11, 2015, 12:50 a.m., Thomas Pfeiffer wrote: Basic rule from design for safety: Don't use a warning if you can prevent the dangerous action completely. In this case that means: Setting the brightness to zero should only be possible via keyboard, because that ensures

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Emmanuel Pescosta
On Feb. 11, 2015, 12:50 a.m., Thomas Pfeiffer wrote: Basic rule from design for safety: Don't use a warning if you can prevent the dangerous action completely. In this case that means: Setting the brightness to zero should only be possible via keyboard, because that ensures

Re: Get panel list and hidding them via C++ module

2015-02-11 Thread Sebastian Kügler
On Tuesday, February 10, 2015 22:24:02 Evgeniy Alekseev wrote: On Tuesday 10 February 2015 12:32:49 Sebastian Kügler wrote: Why not just add the ability to hide a panel with a shortcut? Just an idea that some related items may be collected by one item (e.g. Plasmoid) to prevent similar

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Martin Klapetek
On Feb. 11, 2015, 12:50 a.m., Thomas Pfeiffer wrote: Basic rule from design for safety: Don't use a warning if you can prevent the dangerous action completely. In this case that means: Setting the brightness to zero should only be possible via keyboard, because that ensures

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Martin Klapetek
On Feb. 10, 2015, 10:01 a.m., Mark Gaiser wrote: I'm not quite sure if a user wants to see a warning message at all. When i use my notebook in a dark environment i usually put the brightness all the way down (depending on the notebook). Kai Uwe Broulik wrote: As I stated above,

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Emmanuel Pescosta
On Feb. 10, 2015, 10:01 a.m., Mark Gaiser wrote: I'm not quite sure if a user wants to see a warning message at all. When i use my notebook in a dark environment i usually put the brightness all the way down (depending on the notebook). Kai Uwe Broulik wrote: As I stated above,

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

2015-02-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- (Updated Feb. 11, 2015, 9:31 a.m.) Status -- This change has been

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Emmanuel Pescosta
On Feb. 11, 2015, 12:50 a.m., Thomas Pfeiffer wrote: Basic rule from design for safety: Don't use a warning if you can prevent the dangerous action completely. In this case that means: Setting the brightness to zero should only be possible via keyboard, because that ensures

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Heiko Tietze
On Feb. 10, 2015, 11:50 nachm., Thomas Pfeiffer wrote: Basic rule from design for safety: Don't use a warning if you can prevent the dangerous action completely. In this case that means: Setting the brightness to zero should only be possible via keyboard, because that ensures

Re: Review Request 122505: Warn about brightness getting too low

2015-02-11 Thread Martin Klapetek
On Feb. 11, 2015, 12:50 a.m., Thomas Pfeiffer wrote: Basic rule from design for safety: Don't use a warning if you can prevent the dangerous action completely. In this case that means: Setting the brightness to zero should only be possible via keyboard, because that ensures

Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122522/ --- Review request for Plasma. Bugs: 294778

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122522/#review75846 --- Ship it! Ship It! - David Edmundson On Feb. 11, 2015,

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122522/#review75848 --- -2 This is not part of the original design. At least, this

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122522/#review75849 --- What's the use case this satisfies? - Sebastian Kügler On

Review Request 122524: Port to KPackage and away from sycoca

2015-02-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122524/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 122522: [lookandfeel] Include hostname in InfoPane of LockScreen

2015-02-11 Thread Aleix Pol Gonzalez
On Feb. 11, 2015, 2:43 p.m., Sebastian Kügler wrote: What's the use case this satisfies? See the attached bug report. - Aleix --- This is an automatically generated e-mail. To reply, visit:

Change in plasma-framework[master]: Fix leak in ContainmentActions

2015-02-11 Thread David Edmundson (Code Review)
David Edmundson has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/366 Change subject: Fix leak in ContainmentActions .. Fix leak in ContainmentActions Change-Id:

Re: Review Request 122533: Port accessibility kcm somewhat to xcb xkb

2015-02-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122533/#review75900 --- kcms/access/kaccess.h