D19874: Reduce the margins of KickoffItem

ndavis created this revision. ndavis added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY A lot of space on the left and right of each KickoffItem was wasted, so I've reduced the

D19694: [RFC] Reduce sidebar icon size/increase list information density

ndavis added a comment. In D19694#434169 , @ngraham wrote: > I was talking about the problem of small monochrome icons in the sidebar itself, not in the tooltip. But anyway since then I fixed the tooltip too. > > Any more #VDG

D19694: [RFC] Reduce sidebar icon size/increase list information density

ngraham added a comment. I was talking about the problem of small monochrome icons in the sidebar itself, not in the tooltip. But anyway since then I fixed the tooltip too. Any more #VDG or #plasma opinions

D10091: Combine source and version into a single piece of metadata

ngraham abandoned this revision. ngraham added a comment. Nah. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D10091 To: ngraham, apol, #discover_software_store, #vdg Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. The spacing change is clearly correct. As for the width change, we should match the exact calculation used for the other combobox we're trying to match, which is `width:

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf added a comment. I think I'm still off by a pixel, will test better tomorrow. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19873 To: filipf, #plasma, ngraham Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19873: [image-wallpaper] Fix horizontal alignment of the "Positioning:" row

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Master currently has bad horizontal alignment of the "Positioning:" row since it's not a part of the FormLayout as everything else.

D19872: [plasma-workspace-wallpapers] Add the Elarun wallpaper

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. OMG I love this one! +1000 shipit! REPOSITORY R131 Plasma Wallpapers BRANCH add-elarun (branched from master) REVISION DETAIL https://phabricator.kde.org/D19872 To: filipf,

D18934: [Notifications] Port the close ToolButton to RoundButton

filipf abandoned this revision. filipf added a comment. Abandoning due to the impending overhaul of notifications. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18934 To: filipf, ngraham, #vdg, rooty, #plasma, broulik Cc: plasma-devel, jraleigh, GB_2,

D19802: [comic] Modernize configuration windows

ngraham added inline comments. INLINE COMMENTS > filipf wrote in configAdvanced.qml:55 > It's always the plural now, but I also realized we shouldn't be using > singular if value is 1 because some Slavic languages use singular with 21, > 31, etc. Yep, even if the quantity will always be more

D19872: [plasma-workspace-wallpapers] Add the Elarun wallpaper

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Elarun is an iconic and beautiful KDE wallpaper that only takes up 1.4 MiB of disk space and as such would make a fine addition to

Re: Plasma distro-specific installation path?

There's an utility called kf5-config which prints several paths. It might work for your purposes too. -Ongun On Sat, 16 Mar 2019 at 11:49, Michail Vourlakos wrote: > > Hello, > > one question please: Is there any way to know from Qt/KDE frameworks side in > which global installation path

D19855: Fix bugzilla login page widgets tab order

cfeck added a comment. QLineEdit has Qt::StrongFocus policy and it is the focus proxy of KPasswordLineEdit. My impression was that KPasswordLineEdit then automatically also had Qt::StrongFocus. Appearantly, the policy is propagated in the other direction, so a correct fix would be to

D18934: [Notifications] Port the close ToolButton to RoundButton

filipf updated this revision to Diff 54262. filipf added a comment. rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18934?vs=54259=54262 BRANCH arcpatch-D18934 REVISION DETAIL https://phabricator.kde.org/D18934 AFFECTED FILES

D19838: [powerdevil] Touch up messages/prompts

rooty added inline comments. INLINE COMMENTS > rooty wrote in powerdevilcore.cpp:330 > Hmm sure Actually you're right, without "the profile" and "it" it sounds fancier haha REPOSITORY R122 Powerdevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D19838 To: rooty, #vdg,

D19838: [powerdevil] Touch up messages/prompts

This revision was automatically updated to reflect the committed changes. Closed by commit R122:22d725ca0361: [powerdevil] Touch up messages/prompts (authored by rooty). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19838?vs=54260=54261 REVISION DETAIL

D19838: [powerdevil] Touch up messages/prompts

rooty updated this revision to Diff 54260. rooty added a comment. "or because" REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19838?vs=54168=54260 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19838 AFFECTED FILES

D18934: [Notifications] Port the close ToolButton to RoundButton

filipf updated this revision to Diff 54259. filipf added a comment. fix dumb value REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18934?vs=54258=54259 BRANCH arcpatch-D18934 REVISION DETAIL https://phabricator.kde.org/D18934 AFFECTED FILES

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

filipf added a comment. Alright so I'd like to give RoundButton another chance. Its advantage is that the frame is considerably smaller. The control seems a bit weird though, it needs implicitWidth and an embedded icon class to work properly. REPOSITORY R120 Plasma Workspace

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

filipf updated this revision to Diff 54258. filipf added a comment. Try using RoundButton REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18934?vs=51444=54258 BRANCH arcpatch-D18934 REVISION DETAIL https://phabricator.kde.org/D18934 AFFECTED

D19865: Linux softraid: Define _GNU_SOURCE for pipe2

awilcox created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. awilcox requested review of this revision. REVISION SUMMARY In a strict POSIX compilation environment, pipe2 is not defined. Use the _GNU_SOURCE FTM to expose it. Fixes a failure to

D19802: [comic] Modernize configuration windows

filipf marked 7 inline comments as done. filipf added inline comments. INLINE COMMENTS > ngraham wrote in configAdvanced.qml:55 > The way you do this properly is as follows, with `i18ncp()`: > > text: i18ncp("@item:valuesuffix spacing to number + unit", " strip per > comic", "strips per

D19802: [comic] Modernize configuration windows

filipf updated this revision to Diff 54254. filipf added a comment. avoid using headings, fix spinbox strings REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19802?vs=54001=54254 BRANCH modernized-comic-settings (branched from master) REVISION

D19863: [Host] Add Message.sh

broulik created this revision. broulik added a reviewer: ltoscano. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Noticed it was still untranslated, found there's no `Message.sh` TEST PLAN None. 5.15 since

D19855: Fix bugzilla login page widgets tab order

sitter added a comment. While that fixes the drkonqi bug just fine I am not sure that is the best fix for the problem. As I understand it KPasswordLineEdit doesn't set itself to StrongFocus, seeing as it is a replacement for QLineEdit that seems inconsistent and should be rectified though.

D19851: [kirigami] make it compile without foreach

mlaurent added inline comments. INLINE COMMENTS > apol wrote in kirigamiplugin.cpp:48 > qAsConst isn't necessary because the method is already const. > Is it just for readability? Yep just for readability. It's just for avoiding that we thing it will detach. For sure here it will not detach.

D19857: [DownloadJob] Report total size only if known

bshah added a comment. Other download managers show the downloaded amount as total amount, so it is e.g 25 MiB out of 25 MiB. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D19857 To: broulik, #plasma Cc: bshah, plasma-devel, jraleigh, GB_2,

D19800: [Application Dashboard] Improve mouse handler

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0ecb1359eaca: [Application Dashboard] Improve mouse handler (authored by trmdi, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D19852: Change default Klipper behavior to accept images

kdautovic updated this revision to Diff 54239. kdautovic added a comment. Removed the use of goto. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19852?vs=54237=54239 REVISION DETAIL https://phabricator.kde.org/D19852 AFFECTED FILES

D19852: Change default Klipper behavior to accept images

kdautovic updated this revision to Diff 54237. kdautovic added a comment. Remove the image filter which stopped copying images to clipboard. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19852?vs=54222=54237 REVISION DETAIL

D19852: Change default Klipper behavior to accept images

kdautovic added a comment. You mean line 739? else if( data->hasImage() ) { if( m_bIgnoreImages ) return; } REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19852 To: kdautovic, #plasma_workspaces, davidedmundson Cc:

D19857: [DownloadJob] Report total size only if known

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In case the download size isn't known, the browser reports `-1` TEST PLAN It now shows "xyz

D19745: Fix system tray UI/UX & refactor

ngraham added reviewers: mart, hein. ngraham added a comment. A few more days of waiting may be required since most of the Plasma developers are quite busy right now. But it will get reviewed, don't worry! REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19788: [service runner] throw out kde3 "compat" code

GB_2 added a comment. GTK+ was recently renamed to GTK (https://mail.gnome.org/archives/gtk-devel-list/2019-February/msg0.html). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19788 To: sitter, broulik Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel,

D19852: Change default Klipper behavior to accept images

davidedmundson added a comment. We don't use goto. Whilst I think doing this makes sense, it's not the complete solution you've not got this far as we filter out the images on line 753 which is run before this. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19800: [Application Dashboard] Improve mouse handler

ngraham added a comment. Land on the `Plasma/5.15` stable branch please: https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 If you need a hand with that, let me know. :) REPOSITORY R119 Plasma Desktop BRANCH fix-390424 (branched from master)

D19800: [Application Dashboard] Improve mouse handler

ngraham accepted this revision. ngraham added a comment. Yep, I can no longer reproduce the issue under any circumstances. Thanks a lot for fixing this! REPOSITORY R119 Plasma Desktop BRANCH fix-390424 (branched from master) REVISION DETAIL https://phabricator.kde.org/D19800 To:

D19826: kns: Show subcategories for things that have one

This revision was automatically updated to reflect the committed changes. Closed by commit R134:3dfd7cbc8e4b: kns: Show subcategories for things that have one (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D19851: [kirigami] make it compile without foreach

apol added inline comments. INLINE COMMENTS > kirigamiplugin.cpp:48 > { > -foreach (const QString , m_stylesFallbackChain) { > +for (const QString : qAsConst(m_stylesFallbackChain)) { > const QString candidate = QStringLiteral("styles/") + style + > QLatin1Char('/') +

D19855: Fix bugzilla login page widgets tab order

marcelomariano created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. marcelomariano requested review of this revision. REVISION SUMMARY BUG: 398275 REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D19855 AFFECTED FILES

D19852: Change default Klipper behavior to accept images

kdautovic updated this revision to Diff 54222. kdautovic added a comment. Added a special case for not saving history when the data is an image and m_bIgnoreImages is set. This allows copying images to clipboard, and keeping the current default behavior of Klipper to not save images in

D19826: kns: Show subcategories for things that have one

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Nifty :) REPOSITORY R134 Discover Software Store BRANCH arcpatch-D19826_1 REVISION DETAIL https://phabricator.kde.org/D19826 To: apol, #discover_software_store, leinir Cc: leinir,

D19826: kns: Show subcategories for things that have one

apol updated this revision to Diff 54219. apol added a comment. Rebase and test with opendesktop apps REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19826?vs=54085=54219 BRANCH arcpatch-D19826_1 REVISION DETAIL

D19852: Change default Klipper behavior to accept images

davidedmundson added a comment. It means only spectacle fills memory, not doing work in gimp. The issue is that spectacle closes, but we need klipper to copy the image in advance as it doesn't know that spectacle is about to close. It's unique to this situation. > Your approach is

D19852: Change default Klipper behavior to accept images

kdautovic added a comment. The problem I see with that is that memory usage wasn't solved. Regardless of whether we use my approach or your approach, they're going to use the same amount of memory if people copy screenshots to clipboard. Your approach is just going to give the data a

D19852: Change default Klipper behavior to accept images

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. You're just going to burn through memory like crazy. We can't do this. It also doesn't properly fix the klipper issue as it then breaks for anyone who has

D19837: Add support for applications in KNSBackend

This revision was automatically updated to reflect the committed changes. Closed by commit R134:ffc6023c5412: Add support for applications in KNSBackend (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19837?vs=54204=54213

D19852: Change default Klipper behavior to accept images

kdautovic created this revision. kdautovic added a reviewer: Plasma: Workspaces. kdautovic added a project: Plasma: Workspaces. Herald edited projects, added Plasma; removed Plasma: Workspaces. Herald added a subscriber: plasma-devel. kdautovic requested review of this revision. REVISION SUMMARY

D19851: [kirigami] make it compile without foreach

mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without foreach TEST PLAN autotest ok REPOSITORY R169 Kirigami BRANCH

D19837: Add support for applications in KNSBackend

leinir updated this revision to Diff 54204. leinir marked 2 inline comments as done. leinir added a comment. Address various comments, and also fix one issue discovered while addressing those REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D19837: Add support for applications in KNSBackend

leinir marked 4 inline comments as done. leinir added inline comments. INLINE COMMENTS > apol wrote in KNSBackend.cpp:151 > we can just compare with == here, it will be easier to read. Tru dat... i was just keeping consistency with the long list below, but yeah, at the very least for now we've

D19788: [service runner] throw out kde3 "compat" code

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1f3ab6f7dddb: [service runner] throw out kde3 compat code (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19788?vs=53960=54185

D19837: Add support for applications in KNSBackend

apol added inline comments. INLINE COMMENTS > KNSBackend.cpp:151 > > -const auto topLevelName = knsrcPlasma.contains(fileName)? i18n("Plasma > Addons") : i18n("Application Addons"); > -const QUrl decoration(knsrcPlasma.contains(fileName)? >

D19837: Add support for applications in KNSBackend

leinir added a comment. In D19837#433343 , @ngraham wrote: > Can you edit the test plan to indicate the name of an app from the store that now appears in Discover's Applications section? A quick test of this patch didn't reveal ExeQt or

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. Hello, Any progress on this one? Does it usually take long to review? Sorry for impatience. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19745 To: ratijastk, #vdg, #plasma, broulik Cc: ngraham, ndavis, anthonyfieroni,

D19838: [powerdevil] Touch up messages/prompts

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Awesome. Go ahead and make your proposed change if you'd like, then shipit! INLINE COMMENTS > rooty wrote in powerdevilcore.cpp:367 > "or because the action is not supported", "This is

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt updated this revision to Diff 54176. fvogt added a comment. One more file. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19821?vs=54143=54176 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19821 AFFECTED FILES

D19821: Fix breeze dialog background with Qt 5.12.2

fvogt added a comment. There's a special case in `./src/desktoptheme/breeze/icons/audio.svgz` and `.../battery.svgz`: It has color scheme definitions both in a