Re: ddcutil in Plasma Powerdevil

Hey Jonathan, Unfortunately I did not test it for a long time (last time was around 5.15), and don't really have the possibility now because I'm away from home. *If I remember correctly,* back then I had a few instances when the startup of plasma (during the splashscreen) was quite longer due to re

D24161: Make KCM look more like applet

GB_2 added inline comments. INLINE COMMENTS > sefaeyeoglu wrote in MuteButton.qml:32 > I feel like QQC2 tooltips look out of place. They don't have the same shadow > as //normal// tooltips and do not fade in That is something that needs to be fixed in the QQC2 desktop style, so it is unrelated

D24255: [startplasma] don't set QT_AUTO_SCREEN_SCALE_FACTOR with Qt >= 5.14

dfaure created this revision. dfaure added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. REVISION SUMMARY It gives the following runtime warning: Warning: QT_AUTO_SCREEN_SCALE_FACTOR is deprecated. Inst

D23305: Add plugin showing nvidia GPU load stats

davidedmundson closed this revision. davidedmundson added a comment. Merged REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D23305 To: davidedmundson, #plasma, apol Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu added a comment. In D13243#538519 , @davidedmundson wrote: > What's the use case? I have a "module-null-sink" loaded at all times. I use it to record from via OBS, so I can selectively record Desktop Audio. (This is coupled w

D13243: Add checkbox that can show virtual streams in the applet.

davidedmundson added a comment. What's the use case? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13243 To: sefaeyeoglu, #plasma, drosca, #vdg Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D24161: Make KCM look more like applet

sefaeyeoglu added a comment. In D24161#538429 , @ngraham wrote: > I love it, and the code changes look sane to me. > > #plasma folks or @drosca, any objections? Glad you like it 😄 Looks like t

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu updated this revision to Diff 66926. sefaeyeoglu added a comment. Add copyright header REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13243?vs=66925&id=66926 BRANCH arcpatch-D13243 REVISION DETAIL https://phabricator.kde

D24194: Add per-origin media controls blacklist

broulik updated this revision to Diff 66924. broulik edited the test plan for this revision. broulik added a comment. - Show media controls only if there is a player or something blacklisted on that page, otherwise it gets annoying REPOSITORY R856 Plasma Browser Integration CHANGES SINCE L

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu updated this revision to Diff 66925. sefaeyeoglu added a comment. Rebase onto master REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13243?vs=35273&id=66925 BRANCH arcpatch-D13243 REVISION DETAIL https://phabricator.kde.o

D23158: [applets/kickoff] Improve appearance of draggable button grid in settings window

This revision was automatically updated to reflect the committed changes. Closed by commit R119:184f2a8274dc: [applets/kickoff] Improve appearance of draggable button grid in settings window (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.k

D24251: [applets/kickoff] Somewhat fix the ConfigButtons component sizing

ngraham added a comment. Thanks, I've squashed the changes here into D23158 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24251 To: davidedmundson, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleig

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham updated this revision to Diff 66922. ngraham added a comment. Squash changes from D24251 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23158?vs=66916&id=66922 BRANCH improve-kickoff-settings-button-gri

D13243: Add checkbox that can show virtual streams in the applet.

sefaeyeoglu added a comment. In D13243#538434 , @ngraham wrote: > Yikes, looks like this never went anywhere. :/ > > Can you rebase it? I actually don't remember ever making this but of course I can :D REPOSITORY R115 Plasma Audio V

D24251: [applets/kickoff] Somewhat fix the ConfigButtons component sizing

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY ConfigButtons previously rendered one of the child item, the top title, abo

D24161: Make KCM look more like applet

ngraham accepted this revision. ngraham added a subscriber: drosca. ngraham added a comment. This revision is now accepted and ready to land. I love it, and the code changes look sane to me. #plasma folks or @drosca, any objections? REPOSITORY

D13243: Add checkbox that can show virtual streams in the applet.

ngraham added reviewers: Plasma, drosca, VDG. ngraham added a comment. Yikes, looks like this never went anywhere. :/ Can you rebase it? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13243 To: sefaeyeoglu, #plasma, drosca, #vdg Cc: ngraham,

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66920. sefaeyeoglu edited the test plan for this revision. sefaeyeoglu added a comment. Make icon full height for playback devices, too REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=6691

D23274: Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#538369 , @ngraham wrote: > I could get behind always having an "app-global" hamburger menu on the left when the menubar isn't shown, but this would require implementing the same pattern for every app, by putting a

D24161: Make KCM look more like applet

sefaeyeoglu marked 2 inline comments as done. sefaeyeoglu added a comment. Right! I completely forgot about that. Will work on it REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24161 To: sefaeyeoglu, #plasma, #vdg Cc: ngraham, davidedmundson, GB_2

D24161: Make KCM look more like applet

ngraham added a comment. Nice. Now that I compare the two, one remaining difference is that each item's icon differs in location in the applet vs the KCM. In the Applet, it's larger and to the left of everything else; whereas in the KCM the icon is small and in the same row as the title

D23675: [Folder View] Don't query file information if tooltips are disabled

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes logical sense and nothing's broke. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23675 To: broulik, #plasma, hein, ngraham Cc: ngraham, plasma-dev

D24161: Make KCM look more like applet

sefaeyeoglu marked 2 inline comments as done. sefaeyeoglu added inline comments. INLINE COMMENTS > ngraham wrote in VolumeSlider.qml:44 > Hmm, I don't like how this makes tickmarks appear. If you need to round the > value, you can do that in `onMoved: { blabla; }`, or just round the value of >

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66917. sefaeyeoglu added a comment. Remove stepping again, change label text of port selection REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=66909&id=66917 BRANCH feat-applet-ux REVI

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham updated this revision to Diff 66916. ngraham added a comment. Rebase again REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23158?vs=66915&id=66916 BRANCH improve-kickoff-settings-button-grid (branched from master) REVISION DETAIL https:/

D23158: [Kickoff] Improve appearance of draggable button grid in settings window

ngraham updated this revision to Diff 66915. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23158?vs=63756&id=66915 BRANCH improve-kickoff-settings-button-grid (branched from master) REVISION DETAIL https://phabr

D23274: Add "Show intro page" button to System Settings sidebar

ngraham added a comment. Implemented the requested change for Systemsettings (https://commits.kde.org/systemsettings/ea0f40c9c03b679ff23688d1eabda61c972f6bc1) and Discover (https://commits.kde.org/discover/b8dfc2d02cc2ac8e7416923e00454a7dc8020f7b). REPOSITORY R124 System Settings REVISIO

D23274: Add "Show intro page" button to System Settings sidebar

ngraham added a comment. I could get behind always having an "app-global" hamburger menu on the left when the menubar isn't shown, but this would require implementing the same pattern for every app, by putting a little mini-toolbar above the app's sidebar that's separate from the toolbar abo

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma updated this revision to Diff 66913. maximma added a comment. Bug Fix 410988 REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24146?vs=66694&id=66913 BRANCH calculatorApplet (branched from master) REVISION DETAIL https://phabricator.kde.or

D24161: Make KCM look more like applet

ngraham added inline comments. INLINE COMMENTS > DeviceListItem.qml:54 > +visible: portbox.count > 1 > +text: i18nd("kcm_pulseaudio", "Port") > +} While we're at it, let's also make this say "Port:" > VolumeSlider.qml:44 > to: PulseAudio.MaximalVolume >

D23274: Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#538334 , @ngraham wrote: > In D23274#538315 , @mart wrote: > > > In D23274#537633 , @ngraham wrote: > > > > > Yeah I wou

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma added a comment. ok REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24146 To: maximma, #plasma, cfeck Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed,

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

ngraham added a comment. Change the files to remove those changes using your text editor, then run `arc diff`. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24146 To: maximma, #plasma, cfeck Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, f

D24246: Only show panel toolbox when desktop toolbox is open

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d9533e674adc: Only show panel toolbox when desktop toolbox is open (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24246?vs=66906&id=66911

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma added a comment. ok, how remove changes from those path? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24146 To: maximma, #plasma, cfeck Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin

D23274: Add "Show intro page" button to System Settings sidebar

ngraham added a comment. In D23274#538315 , @mart wrote: > In D23274#537633 , @ngraham wrote: > > > Yeah I would say so. > > > i strongly disagree, it's the opposite of every other kirigami app

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

ngraham added a comment. If there are three changes necessary (fix display, fix bug, change C behavior) then we need three patches in a dependency chain. :) See https://community.kde.org/Infrastructure/Phabricator#If_the_patches_are_all_for_the_same_project REPOSITORY R114 Plasma Addons R

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66909. sefaeyeoglu edited the test plan for this revision. sefaeyeoglu added a comment. Remove redundant whitespace from copyright header REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=66

D23274: Add "Show intro page" button to System Settings sidebar

mart reopened this revision. mart added a comment. This revision is now accepted and ready to land. In D23274#537633 , @ngraham wrote: > Yeah I would say so. i strongly disagree, it's the opposite of every other kirigami app, and i really

D23274: Add "Show intro page" button to System Settings sidebar

mart added a comment. In D23274#537632 , @GB_2 wrote: > Shouldn't the "Show intro page" button be on the left, like in Discover, and the hamburger menu button on the right, like in for example Dolphin? (#consistency

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 66908. sefaeyeoglu added a comment. Use QQC2 ToolButton instead of Button for Mute. Add stepping to volume slider, similar to applet. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=66783

KDE CI: Plasma » libksysguard » kf5-qt5 FreeBSDQt5.13 - Build # 18 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/libksysguard/job/kf5-qt5%20FreeBSDQt5.13/18/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 26 Sep 2019 17:48:45 + Build duration: 36 sec and counting CONSOLE OUTPUT [...truncated 4

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma added a comment. In D24146#538295 , @ngraham wrote: > Make a second patch that only fixes the bug, and then remove those changes from this patch. Do I need to create another page with only bug fix? Or do I need to make another co

D24246: Only show panel toolbox when desktop toolbox is open

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. no. this is in progress in a feature branch already REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24246 To: GB_2, #plasma, #vdg, ngraham, mart Cc:

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

romangg accepted this revision. romangg added a comment. Yea, 5.17. Thanks! REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D24129 To: GB_2, #plasma, #vdg, ngraham, romangg Cc: romangg, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

ngraham added a comment. Make a second patch that only fixes the bug, and then remove those changes from this patch. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D24146 To: maximma, #plasma, cfeck Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jrale

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma added a comment. In D24146#538292 , @ngraham wrote: > In D24146#538284 , @maximma wrote: > > > > > > Excellent. Could you split this out so we have two patches: Yes, could you e

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

ngraham added a comment. In D24146#538284 , @maximma wrote: > 1. I am not sure where the description window is. You can click on the Edit Revision button to add stuff to the description. > 2. Yes, this fixes this bug. I am not sure ho

D24194: Add per-origin media controls blacklist

broulik updated this revision to Diff 66907. broulik retitled this revision from "Add per-domain media controls blacklist" to "Add per-origin media controls blacklist". broulik edited the summary of this revision. broulik added a comment. - Work on origin rather than hostname - Merge whiteli

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma added a comment. 1. I am not sure where the description window is. 2. Yes, this fixes this bug. I am not sure how much this is the right solution, because I am not familiar with js at a sufficient level. But having considered all the solutions, I realized that this is one of the sim

D24129: Fix clipping and use a real ScrollView for the Display Configuration KCM screen overview

GB_2 added a comment. Ping. REPOSITORY R104 KScreen BRANCH master REVISION DETAIL https://phabricator.kde.org/D24129 To: GB_2, #plasma, #vdg, ngraham Cc: romangg, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexey

D24246: Only show panel toolbox when desktop toolbox is open

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY This way the panel toolbox isn't always visible, because with D23951

D24208: [Notifications] Dodge Plasma dialogs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This works great! Instead of temporarily hiding the pop-ups, maybe it should appear above the dialog? Not a huge deal though. 5.17 branch? REPOSITORY R120 Plasma Workspace RE

D24205: [GTK3] Make selection-mode headerbars closer to Adwaita

This revision was automatically updated to reflect the committed changes. Closed by commit R98:1de5b06acc94: [GTK3] Make selection-mode headerbars closer to Adwaita (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24205?vs=66787&id=66

D24205: [GTK3] Make selection-mode headerbars closer to Adwaita

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. 5.17 branch please REPOSITORY R98 Breeze for Gtk BRANCH selection-mode-headerbars (branched from master) REVISION DETAIL https://phabricator.kde.org/D24205 To: cblack, #breeze, ng

D24203: Add settings change listener

This revision was automatically updated to reflect the committed changes. Closed by commit R856:0eaba6b4a184: Add settings change listener (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24203?vs=66785&id=66900 REVISIO

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

broulik added a comment. Also keep in mind that Qt 5.14 supposedly supports markdown editing, which I would love in the notes applet, which would be preferred over "rich text" imho. REPOSITORY R114 Plasma Addons BRANCH notes-applet-tuning (branched from master) REVISION DETAIL https:/

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

yerilov added a comment. @ngraham yeah this is the best way to go as it seems to me. What I did was just drawing attention to this problem since I cannot code and it's hard to understand how everything works for a non-coder. @ltoscano I'd vote for any solution which makes Notes more configu

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

ngraham added reviewers: Plasma, cfeck. ngraham added a comment. 1. This needs more explanation in the Description section to indicate why the proposed change is a good idea. 2. This seems like it has some unrelated changes in it, which look worthwhile, but they should be in a separate patc

D24205: [GTK3] Make selection-mode headerbars closer to Adwaita

ngraham added a comment. Which one of the screenshots depicts how this looks with one of the default color schemes? The one with the purple background or the teal background? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24205 To: cblack, #breeze Cc: ngraham

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

ngraham added a comment. In D24181#538206 , @ltoscano wrote: > @ngraham Let's make it configurable, but not change the default then. I disagree that changing this default on an application which support rich text by default helps making the life

D24203: Add settings change listener

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Seems to work on FF ESR REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D24203 To: broulik, #plasma, fvogt, ognarb Cc: plasma-devel, LeGast00n, The

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

ltoscano added a comment. @ngraham Let's make it configurable, but not change the default then. I disagree that changing this default on an application which support rich text by default helps making the life of everyone better. @yerilov, as you can see, I didn't request a change, becaus

D23675: [Folder View] Don't query file information if tooltips are disabled

broulik added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23675 To: broulik, #plasma, hein Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreu

D24161: Make KCM look more like applet

ngraham added inline comments. INLINE COMMENTS > MuteButton.qml:26 > > -Button { > +QQC2.Button { > property bool muted: true Now that this thing is moved next to the volume slider, I feel like it should be a ToolButton, like in the applet. REPOSITORY R115 Plasma Audio Volume Applet

D24224: Start of the accessibility KCM

mart added inline comments. INLINE COMMENTS > Bell.qml:27 > + > +ColumnLayout { > +QQC2.GroupBox { Shouldn't use groupboxes at all, but just FormLayouts with sections Kirigami.FormLayout { Item{ Kirigami.formData.title: i18n("Audible Bell") Kirigami.formData.isSection:

D24224: Start of the accessibility KCM

ngraham added a comment. Don't change `kcm_access` to `kcmaccess` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24224 To: tcanabrava Cc: ngraham, whiting, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,

D24224: Start of the accessibility KCM

mart added a comment. Visually, it looks exactly like the old one, but in qml.. which gives it several layouting problems Since is tabbed (vdg should be contacted tough to see if they don't have a different option other than tabbed) it should use https://phabricator.kde.org/D23835 (which t

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

yerilov added a comment. @ltoscano D22774 added the ability to choose between paste with and without formatting in the context menu, so yes, no problem with distinguishing. Adding another shortcut like Ctrl+Shift+V is also a viable solution but these ki

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

ngraham added a comment. In D24181#538185 , @ltoscano wrote: > Please ignore the last part of my last comment. My question on the way a paste happens is still relevant, so please answer it: if users use the right click, they will surely distigui

D24187: Start of the accessibility KCM

tcanabrava abandoned this revision. tcanabrava added a comment. closing this as arc diff opened two reviews with the same content =/ REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24187 To: tcanabrava Cc: mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jrale

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava added a comment. got it, updating. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava, #plasma, mart, ngraham Cc: GB_2, nicolasfella, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenB

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

ltoscano added a comment. Please ignore the last part of my last comment. My question on the way a paste happens is still relevant, so please answer it: if users use the right click, they will surely distiguish "paste" and "paste without formatting". If they use the shortcut, they can learn

D24224: Start of the accessibility KCM

tcanabrava added a comment. In D24224#537680 , @whiting wrote: > Thanks for taking this on Tomaz, Just throwing some ideas out but if it would help to have less tabs it might be useful to put all the keyboard features on one tab called Keyboard

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

ltoscano added a comment. Please also note that the notes applications is a rich text editor by default (like the buttons shows). So I would vote for a revert of D22774 . REPOSITORY R114 Plasma Addons BRANCH notes-applet-tuning (branched from master)

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

ltoscano added a comment. I don't see how using the "running in circles" argument can solve the problem. I totally understand how notes works, thanks. The situation is how I described above: applications with just paste may have non-formatting option; applications which have both options de

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

yerilov added a comment. > Do those applications provide the paste-with-formatting action too? No they don't. So it is one more thing that actually makes Plasma more feature-rich DE. > When you talk about "pastes text", "paste it", etc, which way do you mean? Well, we're running

D24194: Add per-domain media controls blacklist

broulik added a comment. > AFAICT it doesn't reload the mpris state in the content-script immediately when settings change, can that be implemented? First we need D24203 . It might be tricky to properly unload e.g. the media sessions stuff, but I can

D24194: Add per-domain media controls blacklist

fvogt added a comment. AFAICT it doesn't reload the mpris state in the content-script immediately when settings change, can that be implemented? IMO the blacklist should be more than the domain, it should test the same conditions as CORS, so protocol, domain and port. INLINE COMMENTS >

D23996: Port away from deprecated KIO::suggestName

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fd765b4a232a: Port away from deprecated KIO::suggestName (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23996?vs=66234&id=66893#toc REPOSITORY R120 Plasma Workspa

D24130: Remove unused include

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1e636858146b: Remove unused include (authored by nicolasfella). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24130?vs=66580&id=66892 REVISION DETAIL h

D24242: Port away from foreach

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN builds, energy saving kcm opens fine REPOSITORY R122 Powerdevil BRANCH foreach REVI

D24238: Port the pager applet away from QtWidgets

dfaure added inline comments. INLINE COMMENTS > broulik wrote in windowmodel.cpp:81 > Isn't that the combined geometry of all screens, not just a single screen? Oh indeed. But then this was the wrong thing to use anyway. You don't want to center the window in relation to the combined geometry,

D24223: [RFC] Add global themes that mimic other platforms' workflows

ngraham added a comment. In D24223#537927 , @fabianr wrote: > > It doesn't auto-hide by default in macOS. I decided to make it span the full width of the screen because not doing this is IMO one of the dumbest parts of that macOS dock, because i

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

ltoscano added a comment. Do those applications provide the paste-with-formatting action too? When you talk about "pastes text", "paste it", etc, which way do you mean? Shortcut, right click + "Paste" entry, middle menu click, all of them, some of them? REPOSITORY R114 Plasma Addons

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

yerilov added a comment. Talking about cross-platform: Windows Notes app pastes text with no formatting, as Gnome Sticky Notes do, even Android apps do not use pasting with formatting by default. Yep, I understand expecting pasting with formatting for Office apps, but for Notes widget it i

D24204: Move save failure message above options

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R856:83602d804e71: Move save failure message above options (authored by broulik). REPOSITORY R856 Plasma Browser Integrat

D24238: Port the pager applet away from QtWidgets

broulik added inline comments. INLINE COMMENTS > windowmodel.cpp:81 > QRect windowGeo = TaskFilterProxyModel::data(index, role).toRect(); > -const QRect &desktopGeo = d->desktopWidget->geometry(); > Isn't that the combined geometry of all screens, not just a single screen? RE

D24187: Start of the accessibility KCM

mart added a comment. "file:///mnt/storage/diau/kde5/share/kpackage/kcms/kcmaccess/contents/ui/main.qml" "Error loading QML file.\n55: Type KeyboardFilters unavailable\n35: id is not unique\n" INLINE COMMENTS > CMakeLists.txt:26 > > -install(TARGETS kcm_access DESTINATION ${KDE_INSTA

D24238: Port the pager applet away from QtWidgets

dfaure created this revision. dfaure added reviewers: hein, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. TEST PLAN Builds REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.17 REVISION DETAIL https://phabricator.kde

ddcutil in Plasma Powerdevil

The DDCUtil features of Powerdevil in KDE Plasma are currently disabled by default "DDCUtil library support is disabled by default as recomended by authors, add -DHAVE_DDCUTIL=On to enable" This is based on a conversation from 2017 where it was decided it was unstable. I see work has continued on